*** IlyaG has quit IRC | 00:00 | |
*** rongze has joined #openstack-cinder | 00:03 | |
openstackgerrit | Tom Barron proposed openstack/cinder: Add standard QoS spec support to cDOT drivers https://review.openstack.org/179352 | 00:04 |
---|---|---|
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/178410 | 00:06 |
*** rongze has quit IRC | 00:07 | |
*** rushil has quit IRC | 00:07 | |
*** garthb has quit IRC | 00:09 | |
*** primechuck has joined #openstack-cinder | 00:12 | |
*** IanGovett has quit IRC | 00:16 | |
openstackgerrit | Anurag Palsule proposed openstack/cinder: Send pool free and total capacity metrics to ceilometer https://review.openstack.org/180447 | 00:26 |
*** leeantho has quit IRC | 00:28 | |
openstackgerrit | Edwin Wang proposed openstack/cinder: Add iSCSI protocol support for IBM FlashSystem https://review.openstack.org/156206 | 00:28 |
*** ebalduf has joined #openstack-cinder | 00:32 | |
*** primechuck has quit IRC | 00:40 | |
*** ebalduf has quit IRC | 00:41 | |
*** tobe4333 has joined #openstack-cinder | 00:45 | |
*** ebalduf has joined #openstack-cinder | 00:45 | |
*** mtanino has joined #openstack-cinder | 00:46 | |
*** akerr has joined #openstack-cinder | 00:50 | |
*** akerr_ has joined #openstack-cinder | 00:52 | |
*** akerr has quit IRC | 00:55 | |
*** ebalduf has quit IRC | 00:56 | |
*** IlyaG has joined #openstack-cinder | 00:57 | |
*** rongze has joined #openstack-cinder | 01:03 | |
*** akerr has joined #openstack-cinder | 01:04 | |
*** akerr__ has joined #openstack-cinder | 01:07 | |
*** akerr_ has quit IRC | 01:07 | |
*** rongze has quit IRC | 01:08 | |
openstackgerrit | wanghao proposed openstack/cinder: Notification with volume and snapshot metadata https://review.openstack.org/180400 | 01:09 |
*** akerr has quit IRC | 01:10 | |
openstackgerrit | wanghao proposed openstack/cinder: Implement function to import/export snapshots https://review.openstack.org/144590 | 01:15 |
*** MentalRay has joined #openstack-cinder | 01:23 | |
*** IlyaG has quit IRC | 01:23 | |
*** IlyaG has joined #openstack-cinder | 01:23 | |
*** vilobhmm1 has quit IRC | 01:25 | |
*** IlyaG has quit IRC | 01:27 | |
*** IlyaG has joined #openstack-cinder | 01:29 | |
*** bill_az has quit IRC | 01:30 | |
*** Longgeek has quit IRC | 01:38 | |
nikeshm | patrickeast: hi there | 01:40 |
patrickeast | nikeshm: hey | 01:41 |
nikeshm | hi able to add jenkins slave nodes now,but telnet 127.0.0.1 4730 status is not showing noop-check-communication job | 01:42 |
*** heyun has joined #openstack-cinder | 01:42 | |
patrickeast | nikeshm: hmm, ok, so a couple of things to check for | 01:42 |
*** dims has quit IRC | 01:42 | |
patrickeast | nikeshm: make sure zuul and zuul-merger services are running, make sure if you look at the job configuration in jenkins that there are slaves with the correct label, and ensure that the gearman plugin in jenkins can connect to gearman | 01:43 |
patrickeast | for the last part go to manage jenkins -> configure system -> Gearman Plguin Config and make sure it is enabled and the test connection gives an OK | 01:44 |
*** davechen has joined #openstack-cinder | 01:47 | |
*** Rockyg has quit IRC | 01:47 | |
*** davechen1 has joined #openstack-cinder | 01:50 | |
*** davechen has quit IRC | 01:53 | |
*** vilobhmm1 has joined #openstack-cinder | 01:54 | |
*** vmtrooper has joined #openstack-cinder | 02:01 | |
*** davechen has joined #openstack-cinder | 02:03 | |
*** davechen1 has quit IRC | 02:04 | |
*** rex_lee has joined #openstack-cinder | 02:04 | |
*** vilobhmm1 has quit IRC | 02:05 | |
*** setmason has joined #openstack-cinder | 02:05 | |
*** tobe4333 has quit IRC | 02:11 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/cinder: Leverage dict comprehension in PEP-0274 https://review.openstack.org/143851 | 02:13 |
openstackgerrit | Thang Pham proposed openstack/cinder: Switch get_all_snapshots to use objects https://review.openstack.org/161077 | 02:16 |
*** setmason has quit IRC | 02:18 | |
*** setmason has joined #openstack-cinder | 02:20 | |
*** setmason has quit IRC | 02:27 | |
*** Longgeek has joined #openstack-cinder | 02:28 | |
*** adurbin_ has quit IRC | 02:30 | |
*** vmtrooper has quit IRC | 02:33 | |
*** Yogi1 has joined #openstack-cinder | 02:34 | |
*** bkopilov has quit IRC | 02:34 | |
*** patrickeast has quit IRC | 02:35 | |
openstackgerrit | Peter Wang proposed openstack/cinder: Add 'source-id' and 'source-name' support in VNX driver https://review.openstack.org/178969 | 02:40 |
*** Longgeek has quit IRC | 02:41 | |
*** Longgeek_ has joined #openstack-cinder | 02:41 | |
*** rongze has joined #openstack-cinder | 02:41 | |
openstackgerrit | Thang Pham proposed openstack/cinder: Complete switch to snapshot objects https://review.openstack.org/163910 | 02:44 |
*** setmason has joined #openstack-cinder | 02:47 | |
*** Yogi1 has quit IRC | 02:50 | |
*** setmason has quit IRC | 02:50 | |
*** MentalRay has quit IRC | 02:55 | |
*** vmtrooper has joined #openstack-cinder | 03:01 | |
openstackgerrit | wanghao proposed openstack/cinder: Implement function to import/export snapshots https://review.openstack.org/144590 | 03:02 |
*** Longgeek_ has quit IRC | 03:04 | |
*** vmtrooper has quit IRC | 03:04 | |
*** vmtrooper has joined #openstack-cinder | 03:04 | |
*** Longgeek has joined #openstack-cinder | 03:06 | |
*** markvoelker has joined #openstack-cinder | 03:18 | |
openstackgerrit | xing-yang proposed openstack/cinder: EMC VMAX Manage/Unmanage Volume https://review.openstack.org/182460 | 03:23 |
*** sgotliv has joined #openstack-cinder | 03:26 | |
nikeshm | patrickeast: thanks | 03:28 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/178410 | 03:30 |
*** sgotliv has quit IRC | 03:31 | |
*** dims has joined #openstack-cinder | 03:31 | |
*** dims has quit IRC | 03:36 | |
*** BharatK has joined #openstack-cinder | 03:39 | |
*** coolsvap|afk is now known as coolsvap | 03:42 | |
openstackgerrit | Jeegn Chen proposed openstack/cinder: Address 0x712d8e0e error in VNX Cinder Driver https://review.openstack.org/181789 | 03:42 |
*** Lee1092 has joined #openstack-cinder | 03:43 | |
*** sgotliv has joined #openstack-cinder | 03:46 | |
*** Longgeek has quit IRC | 03:50 | |
*** Longgeek has joined #openstack-cinder | 03:55 | |
*** Longgeek has quit IRC | 04:00 | |
*** bkopilov has joined #openstack-cinder | 04:04 | |
openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Add a new parameter connector to migrate_volume_completion https://review.openstack.org/181819 | 04:07 |
*** daneyon has quit IRC | 04:10 | |
openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Add a new parameter connector to migrate_volume_completion https://review.openstack.org/181819 | 04:10 |
*** dannywilson has quit IRC | 04:14 | |
*** setmason has joined #openstack-cinder | 04:29 | |
*** setmason has quit IRC | 04:30 | |
*** setmason has joined #openstack-cinder | 04:31 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 04:33 |
openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 04:34 |
*** anuragpalsule has joined #openstack-cinder | 04:40 | |
*** BharatK has quit IRC | 04:40 | |
*** vmtrooper has quit IRC | 04:40 | |
*** vilobhmm1 has joined #openstack-cinder | 04:42 | |
*** akerr__ is now known as akerr_away | 04:45 | |
*** markvoelker has quit IRC | 04:47 | |
*** markvoelker has joined #openstack-cinder | 04:49 | |
*** sks has joined #openstack-cinder | 04:52 | |
*** BharatK has joined #openstack-cinder | 04:53 | |
*** deepakcs has joined #openstack-cinder | 04:54 | |
*** abehl has joined #openstack-cinder | 04:54 | |
*** abehl has quit IRC | 04:55 | |
*** abehl has joined #openstack-cinder | 04:55 | |
*** Longgeek has joined #openstack-cinder | 04:57 | |
*** turul_ has quit IRC | 05:07 | |
*** Longgeek has quit IRC | 05:08 | |
*** Apoorva has quit IRC | 05:16 | |
openstackgerrit | Edwin Wang proposed openstack/cinder: Add iSCSI protocol support for IBM FlashSystem https://review.openstack.org/156206 | 05:27 |
*** BharatK has quit IRC | 05:30 | |
openstackgerrit | XinXiaohui proposed openstack/cinder-specs: capacity-headroom https://review.openstack.org/170380 | 05:36 |
*** BharatK has joined #openstack-cinder | 05:42 | |
*** IlyaG has quit IRC | 05:52 | |
morganfainberg | thingee: got a couple people to introduce you to in Vancouver if you don't know them. | 05:58 |
*** dims has joined #openstack-cinder | 06:00 | |
*** Longgeek has joined #openstack-cinder | 06:05 | |
*** dims has quit IRC | 06:06 | |
*** nlevinki has joined #openstack-cinder | 06:14 | |
*** mtanino has quit IRC | 06:17 | |
wanghao | ping DuncanT and thingee | 06:19 |
wanghao | hi~, I have update the path about 'Notification with volume and snapshot metadata'(https://review.openstack.org/#/c/180400/), would you help me to check the code already ok? | 06:20 |
wanghao | The log message have updated according your suggestion. | 06:21 |
*** Longgeek has quit IRC | 06:22 | |
*** vilobhmm11 has joined #openstack-cinder | 06:23 | |
*** setmason has quit IRC | 06:25 | |
*** afazekas has joined #openstack-cinder | 06:25 | |
*** afazekas_ has joined #openstack-cinder | 06:25 | |
*** vilobhmm1 has quit IRC | 06:25 | |
*** vmtrooper has joined #openstack-cinder | 06:41 | |
*** vmtrooper has quit IRC | 06:45 | |
nikeshm | DuncanT: hi | 06:45 |
*** ronis has joined #openstack-cinder | 06:52 | |
*** dulek has joined #openstack-cinder | 06:59 | |
*** alecv has joined #openstack-cinder | 07:03 | |
*** dulek has quit IRC | 07:06 | |
*** e0ne has joined #openstack-cinder | 07:16 | |
openstackgerrit | Pradeep Sathasivam proposed openstack/cinder: Adds friendly zone name support https://review.openstack.org/180518 | 07:17 |
*** vilobhmm11 has quit IRC | 07:21 | |
*** IlyaG has joined #openstack-cinder | 07:23 | |
*** afazekas_ has quit IRC | 07:25 | |
*** afazekas has quit IRC | 07:25 | |
*** afazekas has joined #openstack-cinder | 07:27 | |
*** jistr has joined #openstack-cinder | 07:34 | |
*** ankit_ag has joined #openstack-cinder | 07:37 | |
*** geguileo has quit IRC | 07:48 | |
*** Longgeek has joined #openstack-cinder | 07:49 | |
*** geguileo has joined #openstack-cinder | 07:51 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: test. https://review.openstack.org/182964 | 07:55 |
*** dulek has joined #openstack-cinder | 07:57 | |
*** Longgeek has quit IRC | 08:00 | |
*** links has joined #openstack-cinder | 08:02 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: test. https://review.openstack.org/182964 | 08:04 |
*** dulek has quit IRC | 08:08 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: test. https://review.openstack.org/182964 | 08:11 |
*** rongze has quit IRC | 08:18 | |
*** rongze has joined #openstack-cinder | 08:24 | |
*** rongze has quit IRC | 08:25 | |
*** lpetrut has joined #openstack-cinder | 08:26 | |
*** e0ne has quit IRC | 08:40 | |
*** dulek has joined #openstack-cinder | 08:48 | |
openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 08:54 |
openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Add a new parameter connector to migrate_volume_completion https://review.openstack.org/181819 | 08:56 |
*** lpetrut has quit IRC | 08:58 | |
openstackgerrit | Pavel Boldin proposed openstack/cinder: Add `iscsi_bsoflags' configuration option https://review.openstack.org/182871 | 08:59 |
*** dulek has quit IRC | 09:00 | |
openstackgerrit | Chhavi Agarwal proposed openstack/cinder-specs: Grouping Multi Backend Pool Aware Cinder Scheduler https://review.openstack.org/182980 | 09:01 |
*** mkerrin has joined #openstack-cinder | 09:05 | |
*** agarciam has quit IRC | 09:07 | |
openstackgerrit | wanghao proposed openstack/cinder-specs: Adopt oslo guru meditation report to cinder https://review.openstack.org/182983 | 09:10 |
openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 09:13 |
*** jungleboyj has quit IRC | 09:13 | |
*** bnemec has quit IRC | 09:13 | |
openstackgerrit | wanghao proposed openstack/cinder: ntroduce Guru Meditation Reports into Cinder https://review.openstack.org/182985 | 09:13 |
*** bnemec has joined #openstack-cinder | 09:13 | |
*** jungleboyj has joined #openstack-cinder | 09:14 | |
*** dulek has joined #openstack-cinder | 09:17 | |
*** atuvenie has joined #openstack-cinder | 09:27 | |
*** rongze has joined #openstack-cinder | 09:29 | |
openstackgerrit | wanghao proposed openstack/cinder-specs: Adopt oslo guru meditation report to cinder https://review.openstack.org/182983 | 09:30 |
*** afazekas has quit IRC | 09:32 | |
*** dims has joined #openstack-cinder | 09:36 | |
*** Longgeek has joined #openstack-cinder | 09:36 | |
*** dulek has quit IRC | 09:37 | |
*** rongze has quit IRC | 09:37 | |
*** dims has quit IRC | 09:40 | |
*** e0ne has joined #openstack-cinder | 09:44 | |
*** e0ne is now known as e0ne_ | 09:44 | |
*** Longgeek has quit IRC | 09:44 | |
*** IanGovett has joined #openstack-cinder | 09:46 | |
openstackgerrit | Peter Wang proposed openstack/cinder: Add 'source-id' and 'source-name' support in VNX driver https://review.openstack.org/178969 | 09:48 |
*** e0ne_ is now known as e0ne | 09:52 | |
*** davechen has left #openstack-cinder | 09:53 | |
*** afazekas has joined #openstack-cinder | 09:58 | |
openstackgerrit | Tina Tang proposed openstack/cinder: Create consistgroup from cgsnapshot support in VNX driver https://review.openstack.org/163706 | 10:02 |
openstackgerrit | Pranali Deore proposed openstack/cinder: Cinder v2 create and update api returns 500 https://review.openstack.org/182994 | 10:04 |
*** dims has joined #openstack-cinder | 10:07 | |
*** aix has joined #openstack-cinder | 10:20 | |
openstackgerrit | Pranali Deore proposed openstack/cinder: Cinder type create and update api returns 500 https://review.openstack.org/183000 | 10:23 |
*** rongze has joined #openstack-cinder | 10:25 | |
*** heyun has quit IRC | 10:27 | |
*** lpetrut has joined #openstack-cinder | 10:36 | |
*** Zhongjun has joined #openstack-cinder | 10:36 | |
*** aix has quit IRC | 10:42 | |
*** haomaiwang has joined #openstack-cinder | 10:42 | |
*** haomaiwa_ has joined #openstack-cinder | 10:45 | |
*** haomaiwang has quit IRC | 10:45 | |
*** rongze has quit IRC | 10:55 | |
*** jamielennox is now known as jamielennox|away | 10:58 | |
*** akerr_away is now known as akerr__ | 11:04 | |
*** e0ne is now known as e0ne_ | 11:12 | |
*** deepakcs has quit IRC | 11:14 | |
*** haomaiwa_ has quit IRC | 11:15 | |
*** cdelatte has joined #openstack-cinder | 11:15 | |
*** delattec has joined #openstack-cinder | 11:15 | |
*** e0ne_ is now known as e0ne | 11:19 | |
*** timcl has joined #openstack-cinder | 11:24 | |
*** timcl has left #openstack-cinder | 11:27 | |
*** Longgeek has joined #openstack-cinder | 11:29 | |
*** atuvenie_ has joined #openstack-cinder | 11:32 | |
*** atuvenie has quit IRC | 11:35 | |
*** rongze has joined #openstack-cinder | 11:41 | |
openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver fix problems under multipath https://review.openstack.org/150767 | 11:42 |
*** chlong has joined #openstack-cinder | 11:48 | |
*** irenab has joined #openstack-cinder | 11:51 | |
*** dulek has joined #openstack-cinder | 11:52 | |
*** irenab has left #openstack-cinder | 11:52 | |
*** diegows has joined #openstack-cinder | 11:52 | |
*** aix has joined #openstack-cinder | 11:58 | |
*** Longgeek has quit IRC | 12:01 | |
*** bkopilov has quit IRC | 12:03 | |
*** e0ne is now known as e0ne_ | 12:05 | |
*** e0ne_ is now known as e0ne | 12:06 | |
*** timcl has joined #openstack-cinder | 12:07 | |
*** Lee1092 has quit IRC | 12:21 | |
*** coolsvap is now known as coolsvap|afk | 12:22 | |
*** atuvenie_ has quit IRC | 12:23 | |
*** rongze has quit IRC | 12:25 | |
*** BharatK has quit IRC | 12:26 | |
*** atuvenie_ has joined #openstack-cinder | 12:29 | |
*** markvoelker has quit IRC | 12:31 | |
*** markvoelker has joined #openstack-cinder | 12:31 | |
*** crose has joined #openstack-cinder | 12:34 | |
*** anuragpalsule has left #openstack-cinder | 12:34 | |
*** crose has quit IRC | 12:35 | |
*** BharatK has joined #openstack-cinder | 12:35 | |
*** crose has joined #openstack-cinder | 12:35 | |
*** erlon has joined #openstack-cinder | 12:38 | |
erlon | aarefiev: ping | 12:39 |
aarefiev | erlon: hi | 12:39 |
*** atuvenie_ has quit IRC | 12:40 | |
erlon | aarefiev: hi Anton, so, about the health status, Im not familiar with the RPC services, using this general queue you said its possible to send query messages from cinder services? | 12:41 |
aarefiev | erlon: cinder manage will send message via rpc to all cinder services, you can see example at https://github.com/openstack/cinder/blob/master/cinder/cmd/manage.py#L302 | 12:46 |
*** bswartz has quit IRC | 12:46 | |
aarefiev | erlon: manage will do the same | 12:46 |
aarefiev | erlon: as delete method | 12:47 |
erlon | aarefiev: mhm, I'm not against this approach, I was just wondering about that other possibility | 12:49 |
*** Zhongjun has quit IRC | 12:49 | |
aarefiev | erlon: what possibility | 12:50 |
*** e0ne is now known as e0ne_ | 12:51 | |
erlon | aarefiev: to query the RPC, instead of trigger the check using cinder manage, to poke the RPC from cinder-{volume,api,sched} | 12:51 |
erlon | aarefiev: that would eliminate the need of another API and CLI | 12:52 |
*** lpabon has joined #openstack-cinder | 12:53 | |
*** e0ne_ is now known as e0ne | 12:53 | |
*** porrua has joined #openstack-cinder | 12:54 | |
aarefiev | erlon: in nova it was implemented via conductor, compute nodes just send periodic update via rpc, certainly cinder needs something like that, I'm watching to service group membership | 12:56 |
*** porrua has quit IRC | 12:57 | |
erlon | aarefiev: service group membership? | 13:02 |
aarefiev | erlon: http://docs.openstack.org/developer/tooz/ | 13:03 |
*** afazekas has quit IRC | 13:05 | |
*** afazekas has joined #openstack-cinder | 13:08 | |
*** ociuhandu has joined #openstack-cinder | 13:09 | |
erlon | aarefiev: hmm, this intends to be a common conductor for openstack projects? | 13:09 |
*** annegentle has joined #openstack-cinder | 13:10 | |
*** Longgeek has joined #openstack-cinder | 13:15 | |
*** crose has quit IRC | 13:16 | |
*** Yogi1 has joined #openstack-cinder | 13:17 | |
aarefiev | erlon: it isn't conductor, it is just api based on diff drivers(db, memcached, redis, zookeeper) | 13:17 |
erlon | aarefiev: hmm | 13:18 |
*** bswartz has joined #openstack-cinder | 13:18 | |
aarefiev | erlon: they implements group membership, and has such useful for health status methods as join and leave group | 13:23 |
*** jdurgin has joined #openstack-cinder | 13:23 | |
*** fthiagogv has joined #openstack-cinder | 13:25 | |
*** changbl has quit IRC | 13:25 | |
*** ankit_ag has quit IRC | 13:25 | |
*** IanGovett has quit IRC | 13:25 | |
*** IanGovett has joined #openstack-cinder | 13:26 | |
erlon | aarefiev: so, to use this it would require to add another service on cinder, right? | 13:26 |
erlon | aarefiev: and add cinder-{volume,api,sched} to a group | 13:27 |
aarefiev | erlon: no, it is just api wich services should support | 13:29 |
*** rmesta has joined #openstack-cinder | 13:29 | |
aarefiev | erlon: no needs in another services | 13:29 |
erlon | aarefiev: hmm, so why thats is not the proposal in the first place? | 13:30 |
*** Zhongjun has joined #openstack-cinder | 13:31 | |
aarefiev | erlon: it is good question | 13:31 |
aarefiev | erlon: maybe sometimes, proposal for nova https://review.openstack.org/#/c/138607/ | 13:32 |
*** bkopilov has joined #openstack-cinder | 13:33 | |
*** jungleboyj has quit IRC | 13:35 | |
*** dustins has joined #openstack-cinder | 13:36 | |
*** mriedem_away is now known as mriedem | 13:38 | |
*** IanGovett1 has joined #openstack-cinder | 13:40 | |
*** IanGovett has quit IRC | 13:43 | |
erlon | aarefiev: that seems to be a very polemic topic, and nova would use it to replace several drivers | 13:43 |
aarefiev | erlon: yep, time will tell | 13:44 |
erlon | aarefiev: I think the usage for cinder won't convince people to accept | 13:44 |
aarefiev | erlon: it should be discussed, there are a lot of work in that direction for cinder, but I think it's very useful changes | 13:47 |
*** e0ne is now known as e0ne_ | 13:47 | |
*** Longgeek has quit IRC | 13:48 | |
*** rongze has joined #openstack-cinder | 13:48 | |
*** setmason has joined #openstack-cinder | 13:51 | |
dulek | thingee: Hi! | 13:53 |
dulek | thingee: I've noticed that sessions here: http://libertydesignsummit.sched.org/type/design+summit/Cinder | 13:53 |
dulek | thingee: doesn't match the dates and hours in the etherpad (https://etherpad.openstack.org/p/cinder-liberty-proposed-sessions) | 13:54 |
*** mtanino has joined #openstack-cinder | 14:00 | |
*** xyang has joined #openstack-cinder | 14:03 | |
*** rushil has joined #openstack-cinder | 14:04 | |
*** e0ne_ is now known as e0ne | 14:06 | |
*** vmtrooper has joined #openstack-cinder | 14:08 | |
*** vmtrooper has quit IRC | 14:09 | |
*** Yogi1 has quit IRC | 14:12 | |
openstackgerrit | Anton Arefiev proposed openstack/cinder: Add entry create and cast tasks to manage workflow https://review.openstack.org/139071 | 14:12 |
openstackgerrit | Anton Arefiev proposed openstack/cinder: Fix lvm manage existing volume https://review.openstack.org/156939 | 14:12 |
*** setmason has quit IRC | 14:12 | |
*** markvoelker has quit IRC | 14:13 | |
*** Ctina has joined #openstack-cinder | 14:19 | |
*** Ctina is now known as ctina | 14:20 | |
*** ganso_ has joined #openstack-cinder | 14:20 | |
*** yrabl has quit IRC | 14:23 | |
*** breitz has quit IRC | 14:24 | |
*** breitz has joined #openstack-cinder | 14:24 | |
*** primechuck has joined #openstack-cinder | 14:26 | |
*** akshai has joined #openstack-cinder | 14:26 | |
*** mkerrin has quit IRC | 14:27 | |
*** aswadr has joined #openstack-cinder | 14:27 | |
*** yrabl has joined #openstack-cinder | 14:27 | |
*** dulek has quit IRC | 14:28 | |
*** akerr__ has quit IRC | 14:29 | |
*** shakamunyi has joined #openstack-cinder | 14:29 | |
*** jungleboyj has joined #openstack-cinder | 14:30 | |
*** eharney has joined #openstack-cinder | 14:30 | |
*** Lee1092 has joined #openstack-cinder | 14:31 | |
*** MentalRay has joined #openstack-cinder | 14:31 | |
openstackgerrit | Anton Arefiev proposed openstack/python-cinderclient: Add findall server side filtering https://review.openstack.org/180534 | 14:34 |
*** MentalRay has quit IRC | 14:34 | |
*** markvoelker has joined #openstack-cinder | 14:40 | |
*** dulek has joined #openstack-cinder | 14:41 | |
*** barra204 has joined #openstack-cinder | 14:43 | |
*** Longgeek has joined #openstack-cinder | 14:45 | |
*** atuvenie_ has joined #openstack-cinder | 14:46 | |
*** markstur_ has joined #openstack-cinder | 14:52 | |
*** crose has joined #openstack-cinder | 14:53 | |
*** markstur_ has left #openstack-cinder | 14:56 | |
*** setmason has joined #openstack-cinder | 14:56 | |
*** IlyaG has quit IRC | 15:00 | |
*** IlyaG has joined #openstack-cinder | 15:00 | |
*** sks has quit IRC | 15:04 | |
*** Longgeek has quit IRC | 15:04 | |
*** rushil has quit IRC | 15:05 | |
*** Longgeek_ has joined #openstack-cinder | 15:05 | |
*** Longgeek_ has quit IRC | 15:05 | |
*** Longgeek has joined #openstack-cinder | 15:05 | |
*** rushil has joined #openstack-cinder | 15:07 | |
*** dustins_ has joined #openstack-cinder | 15:08 | |
*** timcl1 has joined #openstack-cinder | 15:09 | |
*** timcl has quit IRC | 15:10 | |
*** atuvenie_ has quit IRC | 15:10 | |
hemna | tbarron, ping. | 15:10 |
tbarron | hemna: pong | 15:11 |
hemna | I updated the slide deck to include the Netapp image on slide 14 | 15:11 |
hemna | take a look see. | 15:11 |
tbarron | hemna: ty, looking | 15:11 |
*** akshai has quit IRC | 15:11 | |
*** rushil has quit IRC | 15:11 | |
*** dustins has quit IRC | 15:12 | |
tbarron | waiting on dropbox & likely on our proxy ... | 15:12 |
hemna | heh | 15:12 |
jungleboyj | hemna: You have much experience with iscsi and multipath ? | 15:13 |
hemna | jungleboyj, lol | 15:13 |
hemna | we've been churning over that very subject here the last few weeks | 15:13 |
jungleboyj | hemna: Not sure if that is the response I was looking for? .... oh. | 15:13 |
jungleboyj | hemna: Ok ... What have you been seeing? | 15:13 |
hemna | so, the 3PAR array doesn't currently support sending multiple target portals back in the discovery | 15:14 |
*** bswartz has quit IRC | 15:14 | |
hemna | so we've been working on overcoming that one. | 15:14 |
hemna | once Nova gets os-brick support, our problems are solved | 15:14 |
hemna | because brick supports the target_portals[] coming back from initialize_connection | 15:15 |
hemna | and nova's libvirt volume iscsi doesn't | 15:16 |
jungleboyj | hemna: Ok. We are seeing weird behavior on our system where sometimes volumes are being configured to use /dev/mapper/mpath and sometimes it get /dev/disk/by-path/<iscsi device> | 15:16 |
*** rushil has joined #openstack-cinder | 15:16 | |
hemna | on nova ? | 15:16 |
jungleboyj | hemna: Have you ever seen anything like that? | 15:16 |
hemna | so nova has a conf entry that enables multipath or not. | 15:16 |
*** bswartz has joined #openstack-cinder | 15:16 | |
hemna | that conf entry has to be on for you to get /dev/mapper/mpath passed up to libvirt | 15:16 |
jungleboyj | hemna: Yep, that was the first problem we figured out. We got that setup. | 15:17 |
hemna | as well as the multipath daemon running. | 15:17 |
jungleboyj | hemna: Yep, we have that up too. | 15:17 |
hemna | ok | 15:18 |
hemna | and you are still seeing /dev/disk/by-path/<XXX> being sent up ? | 15:18 |
jungleboyj | hemna: Yep, intermittently. | 15:18 |
jungleboyj | Thus my confusion. | 15:18 |
hemna | hrmm | 15:19 |
hemna | encrypted volumes ? | 15:19 |
jungleboyj | Shouldn't be. | 15:19 |
hemna | I've seen /dev/disk/by-path being used for encrypted volumes, which I thought was odd | 15:19 |
jungleboyj | Would multipathd return /dev/disk/by-path if it couldn't get multiple paths back to the storage? | 15:20 |
Swanson | Since you're on the subject is there an eta for nova getting os-brick support? | 15:20 |
hemna | so there is a check in the libvirt driver that looks for a multipath device | 15:21 |
hemna | that code is different than it is in os-brick currently | 15:21 |
hemna | Swanson, https://review.openstack.org/#/c/175569/ | 15:21 |
*** skraynev has quit IRC | 15:21 | |
jungleboyj | I am wondering if this might be because we have find_multipaths set to yes . | 15:21 |
hemna | if nova's conf entry is turned on, it should find a multipath device regardless | 15:22 |
Swanson | hemna: excellent! Thanks! | 15:22 |
hemna | even if only 1 LUN has shown up | 15:22 |
*** rushil has quit IRC | 15:22 | |
jungleboyj | hemna: That was what I thought as well. | 15:22 |
hemna | some volumes show up after the initial discovery happens | 15:22 |
hemna | and multipath daemon will add those to the multipath device association when they show up | 15:22 |
hemna | or it's supposed to | 15:22 |
hemna | but multipath -ll should find a multipath device for the /dev/disk/by-path/<XXX> entry if it's on | 15:23 |
*** skraynev has joined #openstack-cinder | 15:23 | |
hemna | Swanson, I was hoping to get it out of WIP before Vancouver, but I'm not sure I can just yet. I do have 2 days left though :P | 15:23 |
*** ronis has quit IRC | 15:24 | |
*** lpetrut has left #openstack-cinder | 15:24 | |
*** links has quit IRC | 15:24 | |
*** rushil has joined #openstack-cinder | 15:25 | |
*** tsekiyama has joined #openstack-cinder | 15:25 | |
jungleboyj | Going to have them recreate with Debug on and see if I can track down where things are going wrong. | 15:26 |
jungleboyj | hemna: Just wanted to make sure there wasn't something obvious I was missing. | 15:26 |
hemna | yah it's tough to tell from here | 15:26 |
hemna | but if multipath is on in nova.conf and the daemon is running, you should get a multipath device instead of /dev/disk/by-path/<XXX> | 15:27 |
hemna | but this is all nova's libvirt volume code....so..... | 15:27 |
tbarron | hemna: wonder if dropbox is "eventually consistent" - I don't see the page 14 update yet. | 15:28 |
*** haomaiwang has joined #openstack-cinder | 15:28 | |
*** haomaiwang has quit IRC | 15:29 | |
tbarron | hemna: I'll check again in an hour or so | 15:29 |
*** haomaiwang has joined #openstack-cinder | 15:29 | |
Swanson | hemna: I don't know enough to review that patch but it certainly looks to remove a lot of duplicate code. | 15:31 |
*** abehl has quit IRC | 15:31 | |
tbarron | jungleboyj: hemna: we're waiting for os-brick to land in Nova for that reason too. In HA failover, we now send the un-failed over portal instead of just the first in the list :-) | 15:31 |
*** ebalduf has joined #openstack-cinder | 15:31 | |
tbarron | but I want to return the whole list since there's a window before nova uses the info in which | 15:31 |
tbarron | the usability state could change | 15:31 |
*** nlevinki has quit IRC | 15:33 | |
*** Yogi1 has joined #openstack-cinder | 15:36 | |
tbarron | http://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/api-microversions.html | 15:39 |
*** zhenguo has quit IRC | 15:39 | |
tbarron | ^^^^^^^^^^^^^^ feel free to tell me I haven't been paying attention, but have we discussed doing this kind of thing? | 15:39 |
hemna | Swanson, yah I'm not done yet with it. | 15:43 |
e0ne | jgriffith: what dou you think about adding to the Friday's sprint agenta item about unit tests and functional tests in cinder? will we have time for it? | 15:47 |
jgriffith | e0ne: I think that would be useful, if there's time, and if there are other people interested | 15:48 |
jgriffith | e0ne: otherwise you and I can just tackle it :) | 15:48 |
e0ne | jgriffith: you noted few months ago that we need improve quolity both of them | 15:48 |
jgriffith | e0ne: yeah, I sure did | 15:48 |
*** markvoelker has quit IRC | 15:50 | |
e0ne | jgriffith: i just realized that for our distro we don't have tests for python-cinderclient except rally tests:( | 15:51 |
*** daneyon has joined #openstack-cinder | 15:52 | |
*** daneyon has quit IRC | 15:52 | |
*** daneyon has joined #openstack-cinder | 15:53 | |
smcginnis | tbarron: I do see you on slide 14. Maybe proxy caching or something? | 15:55 |
tbarron | smcginnis: likely. I'll try again after lunch. Thanks. | 15:56 |
*** lpetrut has joined #openstack-cinder | 15:56 | |
*** dims has quit IRC | 15:56 | |
*** dims has joined #openstack-cinder | 15:56 | |
jgriffith | e0ne: You mean for MOS? | 15:57 |
jgriffith | e0ne: or you mean in general? | 15:57 |
e0ne | jgriffith: yes. but is it different in general? | 15:57 |
jgriffith | e0ne: nah, should be "same" | 15:57 |
e0ne | jgriffith:until yesterday i didn't know that tempest doesn't use clients | 15:57 |
jgriffith | e0ne: hopefully some day this: https://goo.gl/37VSM7 | 15:58 |
jgriffith | will land | 15:58 |
jgriffith | and we can start building those tests out | 15:58 |
jgriffith | right now we test pretty much nothing :( | 15:58 |
jgriffith | e0ne: that's why I pushed the functional test in cinderclient change | 15:58 |
tbarron | smcginnis: but before I leave for lunch, let me check that I'm using the right link: https://www.dropbox.com/s/vg4guyt5dxlbx77/FCPastPresentVancouver-v2.pptx?dl=0 | 15:58 |
jgriffith | e0ne: the removal of those from Tempest has been a long term goal | 15:59 |
*** markvoelker has joined #openstack-cinder | 15:59 | |
*** hodos has joined #openstack-cinder | 15:59 | |
smcginnis | tbarron: Maybe not. Mine looks different: https://www.dropbox.com/s/khdc2rn3zp5y61g/FCPastPresentVancouver.pptx | 15:59 |
*** kmartin has joined #openstack-cinder | 15:59 | |
jgriffith | e0ne: so now I just need them to turn on the changes to project and we'll be good :) | 15:59 |
smcginnis | jgriffith: Speaking of unit tests... | 16:00 |
e0ne | jgriffith: what do you mean "removal those from Tempest"? | 16:00 |
smcginnis | jgriffith: I tried taking a look at this: https://github.com/openstack/cinder/blob/master/cinder/tests/unit/integrated/test_volumes.py#L83 | 16:00 |
tbarron | smcginnis: hemna: that was it. Looks good! Thanks! Sorry for the confusion. Now I can go back to doing some work :-) | 16:00 |
jgriffith | e0ne: there "used" to be cli tests in Tempest | 16:00 |
smcginnis | jgriffith: The bug referenced is closed. | 16:00 |
hemna | tbarron, ok sweet | 16:00 |
jgriffith | smcginnis: looking | 16:00 |
tbarron | hemna: thanks again | 16:00 |
smcginnis | So I tried to remove the skip but the test doesn't appear to be doing what I expected it to at all. | 16:00 |
jgriffith | smcginnis: oh... these | 16:01 |
smcginnis | jgriffith: Looked like it was originally you, so hoping you have some clue/pointer. | 16:01 |
e0ne | jgriffith: https://github.com/openstack/tempest/commit/464d287f5ba52aeeff3d6ca4daa17d80f4c1e5db | 16:01 |
smcginnis | jgriffith: "oh... these" - that sounds kind of ominous. :) | 16:01 |
*** leeantho has joined #openstack-cinder | 16:02 | |
e0ne | CLI tests are removed from tempest 2 weeks ago | 16:02 |
jgriffith | smcginnis: those tests have been "troublesome" in the past | 16:02 |
jgriffith | smcginnis: so honestly I don't remember the details on this | 16:02 |
*** setmason has quit IRC | 16:02 | |
jgriffith | smcginnis: might be worth trying to turn it back on (remove the skip) | 16:03 |
smcginnis | jgriffith: Yeah, tried that. Looked like something isn't being mocked that should be or vice versa. | 16:03 |
*** setmason has joined #openstack-cinder | 16:03 | |
jgriffith | smcginnis: ahh... ok | 16:03 |
smcginnis | jgriffith: Been a bit now since I tried, so a little foggy. Maybe I'll try again. | 16:04 |
jgriffith | smcginnis: yeah, that was part of the problem I have with all of those tests | 16:04 |
smcginnis | jgriffith: Thought I would ping you on it in case it rang any bells. | 16:04 |
jgriffith | smcginnis: almost everything in the /api directory | 16:04 |
jgriffith | smcginnis: see my earlier conversation with e0ne about "fixing up our unit tests" :) | 16:04 |
e0ne | :) | 16:04 |
smcginnis | jgriffith: What's your opinion? Worth figuring out how to remove the skip? Or just leave it until things are "fixed up"? :) | 16:04 |
jgriffith | smcginnis: depends... what are your plans for today :) | 16:05 |
*** asrangne has joined #openstack-cinder | 16:05 | |
*** alecv has quit IRC | 16:06 | |
jgriffith | smcginnis: so my thoughts... | 16:06 |
smcginnis | jgriffith: Yeah... I'll put it on my "someday maybe" list. ;) | 16:06 |
jgriffith | smcginnis: if we can figure out "what" that's actually intending to test (frankly I'm ont certain at first glance) | 16:07 |
jgriffith | smcginnis: it might be worth rewrting the module altogether and more "better" | 16:07 |
smcginnis | More better is always a good thing. | 16:07 |
jgriffith | smcginnis: :) | 16:07 |
jgriffith | smcginnis: I'm kind of unclear on if that actually "tests" anything though | 16:08 |
*** aswadr has quit IRC | 16:08 | |
jgriffith | smcginnis: looks like 90% of the code path is "fakes" | 16:08 |
smcginnis | jgriffith: Yeah, to the point you've made in the past, a lot of our unit tests just test that mock works. :/ | 16:09 |
jgriffith | smcginnis: so seems that we start the API service (not good in a unit test IMO) | 16:09 |
jgriffith | smcginnis: and send it 'stuff' that routes to fakes | 16:09 |
*** _cjones_ has joined #openstack-cinder | 16:09 | |
jgriffith | smcginnis: honestly, I'd propose figuring out *what* it's actually intended to test, and if it's something that's not already covered then write "proper" unit tests for it | 16:10 |
jgriffith | smcginnis: testing the actual "methods" of the module of interest, as opposed to firing up a service and mocking everything under the sun out | 16:10 |
*** daneyon_ has joined #openstack-cinder | 16:11 | |
jgriffith | smcginnis: Oh... wait | 16:11 |
jgriffith | ya know what... | 16:11 |
smcginnis | jgriffith: That sounds like a good plan to me. I'll keep it on my list to look in to when I have a little more time. | 16:11 |
smcginnis | Integrated? | 16:11 |
jgriffith | AFAIC this can just go away | 16:11 |
smcginnis | Oh? | 16:11 |
*** rushil has quit IRC | 16:11 | |
jgriffith | It's checking the same 'stuff' that's going to be picked up by the client functional tests | 16:11 |
smcginnis | jgriffith: It does seem a little redundant. | 16:12 |
jgriffith | also, this burns me up..... the test is "make api calls, dump the output to debug" | 16:12 |
jgriffith | LOG | 16:12 |
smcginnis | I think other than covering some of the faked code, it's not actually adding to our code coverage significantly. | 16:12 |
jgriffith | smcginnis: look at line 47 | 16:12 |
*** _cjones_ has quit IRC | 16:12 | |
jgriffith | smcginnis: what is that supposedly testing? | 16:12 |
*** _cjones_ has joined #openstack-cinder | 16:12 | |
*** abehl has joined #openstack-cinder | 16:13 | |
smcginnis | jgriffith: Yeah, lot of that through there. | 16:13 |
smcginnis | Testing get_volumes and then just dumping output. | 16:13 |
nikeshm | asselin : hi | 16:13 |
jgriffith | smcginnis: all of them except the one being skipped :) | 16:13 |
smcginnis | No asserts or anything. | 16:13 |
jgriffith | smcginnis: I'd propose ripping that crap out of there myself | 16:13 |
*** daneyon has quit IRC | 16:13 | |
smcginnis | jgriffith: So I think with the "integrated" tests it seems like there should be something verifying some of the interaction - so there's probably some value somewhere here - but I agree most of this is probably not really testing anything. | 16:14 |
smcginnis | But maybe should be. | 16:15 |
jgriffith | smcginnis: Yeah, also that's "old" stuff from the original nova-fork | 16:15 |
jgriffith | smcginnis: I think it's pretty much osbolete at this point | 16:15 |
nikeshm | asselin : in nodepool vms,i am not getting internet, this can solve my problem ./prepare_node.sh:echo 'nameserver 127.0.0.1' > /etc/resolv.conf to ./prepare_node.sh:echo 'nameserver 10.0.0.1' > /etc/resolv.conf but this change is not reflecting | 16:16 |
smcginnis | jgriffith: Noticed that. Yeah, I would think a few things have changed since then. :) | 16:16 |
*** e0ne is now known as e0ne_ | 16:18 | |
nikeshm | asselin : ? | 16:21 |
*** patrickeast has joined #openstack-cinder | 16:22 | |
asselin | nikeshm, hi | 16:22 |
asselin | nikeshm, where are you putting those commands? | 16:23 |
*** afazekas has quit IRC | 16:24 | |
*** e0ne_ is now known as e0ne | 16:25 | |
nikeshm | asselin: /etc/nodepool/scripts/prepare_node.sh | 16:26 |
asselin | nikeshm, have you tried using dib? | 16:26 |
nikeshm | asselin: no,how to change it through dib | 16:27 |
asselin | dib uses the elements in /etc/nodepool/elements | 16:27 |
*** shakamunyi has quit IRC | 16:27 | |
asselin | elements are small script fragments | 16:28 |
asselin | that are composed together | 16:28 |
*** barra204 has quit IRC | 16:28 | |
asselin | so you can manage each separately | 16:28 |
asselin | /etc/nodepool/elements/puppet/bin/prepare-node | 16:29 |
asselin | I just commented out the last line from what upstream has: #echo 'nameserver 8.8.8.8'> /etc/resolv.conf | 16:29 |
*** madskier has joined #openstack-cinder | 16:29 | |
*** dannywil_ has joined #openstack-cinder | 16:30 | |
*** krtaylor has quit IRC | 16:31 | |
*** ebalduf has quit IRC | 16:33 | |
*** BharatK has quit IRC | 16:39 | |
*** Yogi1 has quit IRC | 16:39 | |
*** ronis has joined #openstack-cinder | 16:40 | |
*** madskier has quit IRC | 16:42 | |
*** ebalduf has joined #openstack-cinder | 16:42 | |
*** jistr has quit IRC | 16:42 | |
nikeshm | asselin: do we have to run any further command after changing in that file | 16:43 |
*** garthb has joined #openstack-cinder | 16:44 | |
nikeshm | asselin:/etc/nodepool/elements/puppet/bin/prepare-node here i modified echo "nameserver 10.0.0.1"> /etc/resolv.conf but its not refecting in new vms | 16:45 |
asselin | nikeshm, you need to be a new image with that | 16:45 |
*** abehl has quit IRC | 16:45 | |
asselin | nodepool dib-image-build | 16:45 |
asselin | nodepool dib-image-build dpc | 16:45 |
asselin | need to build* | 16:46 |
nikeshm | asselin: thanks, what about nodepool image-update | 16:47 |
asselin | nikeshm, do you that anymore | 16:47 |
asselin | don't use that anymore * | 16:47 |
jgriffith | hemna: awesome, thanks (re the executor wrapper thingy) | 16:47 |
hemna | jgriffith, it's on my list :) | 16:48 |
asselin | nikeshm, http://docs.openstack.org/infra/nodepool/configuration.html | 16:48 |
jgriffith | hemna: hehe... it was on mine for 9 months; thanks to you I now get to take it off :) | 16:48 |
hemna | :) | 16:48 |
asselin | nikeshm, http://docs.openstack.org/infra/nodepool/operation.html | 16:49 |
*** rushil has joined #openstack-cinder | 16:49 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Added a unit test for masking iscsiadm passwords https://review.openstack.org/181553 | 16:49 |
*** Yogi1 has joined #openstack-cinder | 16:49 | |
xyang | jgriffith: question for you on this: https://review.openstack.org/#/c/163706/11/cinder/tests/unit/test_emc_vnxdirect.py, line 3405 | 16:50 |
xyang | jgriffith: do you suggest to remove the assert calls? | 16:50 |
*** Apoorva has joined #openstack-cinder | 16:51 | |
jgriffith | xyang: so I don't think it's necessary, but I received a -1 on one of my patches for doing the "expected mock.call" thing | 16:56 |
jgriffith | xyang: I'm not sure if I missed a discussion on the toopic or not | 16:56 |
jgriffith | xyang: that's why I mentioned it in the review | 16:56 |
xyang | jgriffith: ok, I don't know what is preferred way | 16:57 |
jgriffith | xyang: My understanding was that at one point or another somebody pointed out that those checks do more harm than good | 16:57 |
jgriffith | eharney: Not sure if you have any insight on any of that ^^ I think your name was mentioned in the conversation (but I'm not sure) | 16:57 |
xyang | jgriffith: hmm, that makes me more confused:( | 16:57 |
jgriffith | xyang: which part? | 16:58 |
jgriffith | xyang: so my opinion is "don't care" leave it the way it is | 16:58 |
xyang | jgriffith: I mean I don't understand what to change to:). Ok, thanks | 16:58 |
jgriffith | xyang: BUT if there's an issue with them that I'm not aware of, or people don't want them I just wanted to get some conversation going | 16:58 |
jgriffith | xyang: like I said, I received a -1 for having them at one point | 16:58 |
*** abehl has joined #openstack-cinder | 16:59 | |
eharney | my opinion is that those test cases are very big :) | 16:59 |
eharney | but i'm not too sure on the specific question | 16:59 |
jgriffith | eharney: LOL... umm, well there is that :( | 16:59 |
jgriffith | eharney: I kinda lost the forest for the trees | 16:59 |
jgriffith | eharney: somebody raised an issue with asserting mock.x was called | 17:00 |
jgriffith | eharney: for the life of me I can't remember the details, I moved on and filed in the back of my brain | 17:00 |
eharney | that's pretty normal though, isn't it? | 17:00 |
jgriffith | eharney: but it sounds like you don't know anything about it either.... so I don't know who does | 17:00 |
patrickeast | sounds like this treads close to the holy war on black box vs white box unit testing… i think the argument most people have is that testing for individual calls or sequence of calls shouldn’t matter and makes tests prone to failures for OK changes | 17:00 |
jgriffith | eharney: yes, we have it EVERYWHERE | 17:00 |
patrickeast | so it costs more time to keep them updated | 17:00 |
jgriffith | patrickeast: that sounds about right | 17:01 |
eharney | i guess i'm in Xing's boat at the moment, not getting what the alternative would be | 17:01 |
jgriffith | patrickeast: so I guess the answer is "not required but not discouraged"? | 17:01 |
patrickeast | hah | 17:01 |
*** madskier has joined #openstack-cinder | 17:01 | |
xyang | but if you don't do, someone will ask you to add test coverage | 17:01 |
jgriffith | eharney: well.. alternative would be to write and actual unit test | 17:02 |
jgriffith | eharney: that calls a 'small' segment of code and tests what it returns/does | 17:02 |
jgriffith | eharney: so the "assertFalse" or whatever method | 17:02 |
jgriffith | eharney: know what I mean? | 17:03 |
patrickeast | its hard for some of this stuff, like for our remote management calls to backends, since the behavior we would expect has to be mocked out… we really do want to validate that some sequence of api calls were made | 17:03 |
eharney | jgriffith: yeah, so the question is whether we should have tests that run through a whole method checking that it does steps 1 through 20 or not | 17:03 |
* e0ne wants to propose one more "holly war" topic: verifying error and api response messages in unit tests | 17:03 | |
jgriffith | so clearly I must have some bad info on this stuff, which is "good" | 17:03 |
jgriffith | because I don't want to make it a "thing" by any means, just wanted to make sure I didn't miss a discussion on the topic | 17:04 |
e0ne | bb in ~2 hours | 17:04 |
*** krtaylor has joined #openstack-cinder | 17:04 | |
jgriffith | xyang: let's do this.... ignore me and move on :) | 17:04 |
xyang | jgriffith: sounds good:) | 17:05 |
jgriffith | xyang: if you want to improve the unit test by making the test cases "smaller" that would be awesome, but that ship has sailed for now | 17:05 |
*** e0ne has quit IRC | 17:05 | |
*** ebalduf has quit IRC | 17:05 | |
xyang | jgriffith: doesn't it already have small unit tests in that patch? I can check | 17:05 |
hemna | small edits to the slide deck for the FC preso. I think this is the final if everyone is ok with it. | 17:06 |
xyang | jgriffith: there's a assertraises. I'll ask her to see if it is possible to do small assert calls | 17:07 |
hemna | just moved the logos around on slide 14. | 17:07 |
jgriffith | xyang: let's just ignore me for the rest of the week, might be best for everybody :) | 17:07 |
xyang | jgriffith: :) | 17:07 |
jgriffith | hemna: using my psychic channeling abilities to "view" said preso | 17:07 |
hemna | same dropbox url :) | 17:08 |
jgriffith | hemna: and that would be? | 17:08 |
* hemna waits for etherpad to load..... | 17:08 | |
hemna | https://etherpad.openstack.org/p/vancouver_fc_in_openstack | 17:08 |
jgriffith | :) | 17:08 |
hemna | it's in there | 17:08 |
hemna | https://www.dropbox.com/s/khdc2rn3zp5y61g/FCPastPresentVancouver.pptx?dl=0 | 17:09 |
hemna | that one | 17:09 |
*** setmason has quit IRC | 17:09 | |
jgriffith | hemna: so the fact that it's built off of a deck called "marketing presentation" is never promising :) | 17:09 |
hemna | hehe | 17:09 |
hemna | I had to start somewhere | 17:10 |
jgriffith | hemna: I see what you did there | 17:10 |
*** setmason has joined #openstack-cinder | 17:10 | |
*** xyang has quit IRC | 17:12 | |
*** xyang has joined #openstack-cinder | 17:13 | |
*** Apoorva has quit IRC | 17:15 | |
*** setmason has quit IRC | 17:16 | |
*** Apoorva has joined #openstack-cinder | 17:16 | |
jgriffith | hemna: LGTM, thanks! | 17:16 |
*** dulek has quit IRC | 17:19 | |
*** setmason has joined #openstack-cinder | 17:19 | |
*** lpetrut has quit IRC | 17:21 | |
*** vilobhmm1 has joined #openstack-cinder | 17:23 | |
hemna | jgriffith, coolio. | 17:24 |
hemna | I'm bringing my mactop with me | 17:24 |
hemna | going to go pickup a thunderbolt -> HDMI output cable today | 17:24 |
hemna | I'm not sure what the room will have though for plugging in | 17:24 |
*** isd has joined #openstack-cinder | 17:25 | |
jgriffith | hemna: They usually "have" everything you need, but never hurts to be prepared | 17:26 |
jgriffith | hemna: I'll have an adapter or two as well just incase | 17:26 |
hemna | ok cool | 17:27 |
*** tim_o_ has joined #openstack-cinder | 17:27 | |
*** rushil has quit IRC | 17:27 | |
*** lpetrut has joined #openstack-cinder | 17:29 | |
*** earlephilhower has joined #openstack-cinder | 17:30 | |
*** Lee1092 has quit IRC | 17:31 | |
*** lpetrut has quit IRC | 17:34 | |
*** rushil has joined #openstack-cinder | 17:37 | |
*** xyang has quit IRC | 17:38 | |
*** kmartin has quit IRC | 17:39 | |
*** harlowja has quit IRC | 17:41 | |
*** harlowja has joined #openstack-cinder | 17:42 | |
*** kmartin has joined #openstack-cinder | 17:46 | |
*** e0ne has joined #openstack-cinder | 17:53 | |
*** marcusvrn has quit IRC | 17:54 | |
*** marcusvrn has joined #openstack-cinder | 17:55 | |
*** madskier has quit IRC | 17:59 | |
*** ebalduf has joined #openstack-cinder | 18:00 | |
*** isd has quit IRC | 18:01 | |
openstackgerrit | Alfredo Moralejo proposed openstack/cinder: rbd driver in cinder does not manage glance images multi-location https://review.openstack.org/182616 | 18:01 |
*** isd has joined #openstack-cinder | 18:02 | |
*** BharatK has joined #openstack-cinder | 18:02 | |
*** dannywilson has joined #openstack-cinder | 18:02 | |
*** ctina_ has joined #openstack-cinder | 18:02 | |
*** patrickeast has quit IRC | 18:03 | |
*** patrickeast_ has joined #openstack-cinder | 18:03 | |
*** hemna_ has joined #openstack-cinder | 18:04 | |
*** hemna_ has quit IRC | 18:05 | |
*** ctina has quit IRC | 18:05 | |
*** dannywil_ has quit IRC | 18:05 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Added a unit test for masking iscsiadm passwords https://review.openstack.org/181553 | 18:06 |
*** ctina_ has quit IRC | 18:06 | |
*** ebalduf has quit IRC | 18:09 | |
*** Zhongjun has quit IRC | 18:09 | |
*** lpabon has quit IRC | 18:11 | |
*** lpetrut has joined #openstack-cinder | 18:16 | |
*** rongze has quit IRC | 18:19 | |
*** ronis has quit IRC | 18:26 | |
thingee | hemna: one more thing sorry https://review.openstack.org/#/c/181553/3 | 18:33 |
thingee | hemna: I tested this myself and seems to pass just fine. | 18:33 |
uberjay | anyone have hints/tips for setting up third-party CI log publishing to s3? | 18:36 |
asselin | uberjay, this is what I use: https://github.com/rasselin/os-ext-testing/blob/master/puppet/install_log_server.sh | 18:37 |
nikeshm | asselin patrickeast : http://paste.openstack.org/show/223043/ tried to run dsvm-tempest-full manually but its failing cd: /opt/stack/new/devstack: No such file or directory | 18:37 |
asselin | uberjay, https://github.com/rasselin/os-ext-testing/blob/master/puppet/modules/os_ext_testing/templates/jenkins_job_builder/config/macros.yaml.erb#L126 | 18:37 |
*** aix has quit IRC | 18:38 | |
uberjay | asselin: right, you run a dedicated log server instance? we're going to do this, but i figured if we can get away without an instance, that'd be nice. | 18:38 |
asselin | uberjay, you can ask in infra...I think they're migrating to swift | 18:39 |
uberjay | asselin: interesting, thanks! | 18:39 |
*** atan8 has joined #openstack-cinder | 18:43 | |
nikeshm | asselin : line no 192 of http://paste.openstack.org/show/223043/ | 18:43 |
*** BharatK has quit IRC | 18:44 | |
*** IanGovett1 has quit IRC | 18:44 | |
*** vilobhmm1 has quit IRC | 18:44 | |
asselin | nikeshm, look here: logs/devstack-gate-setup-workspace-new.txt.gz | 18:44 |
*** vilobhmm1 has joined #openstack-cinder | 18:45 | |
*** rushil has quit IRC | 18:46 | |
*** changbl has joined #openstack-cinder | 18:46 | |
*** fthiagogv has quit IRC | 18:47 | |
*** IanGovett has joined #openstack-cinder | 18:51 | |
*** markvoelker has quit IRC | 18:54 | |
*** dannywilson has quit IRC | 18:54 | |
*** rushil has joined #openstack-cinder | 18:57 | |
*** IanGovett1 has joined #openstack-cinder | 18:58 | |
*** markvoelker has joined #openstack-cinder | 19:00 | |
*** IanGovett has quit IRC | 19:01 | |
*** harlowja has quit IRC | 19:03 | |
*** harlowja has joined #openstack-cinder | 19:05 | |
*** dannywilson has joined #openstack-cinder | 19:05 | |
*** ebalduf has joined #openstack-cinder | 19:10 | |
*** abehl has quit IRC | 19:11 | |
*** ebalduf has quit IRC | 19:14 | |
*** annegentle has quit IRC | 19:17 | |
tbarron | I've been asked a question that I don't know the answer to (though if I'd been paying adequate attention, ...) | 19:20 |
tbarron | Are cinder folks planning to do anything with microversions for extensions, as in http://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/api-microversions.html | 19:21 |
tbarron | Is this something we've discussed? | 19:21 |
*** ebalduf has joined #openstack-cinder | 19:22 | |
*** harlowja has quit IRC | 19:25 | |
*** harlowja has joined #openstack-cinder | 19:26 | |
nikeshm | asselin : build successfully for lvm driver :) | 19:27 |
*** timcl1 has quit IRC | 19:27 | |
*** Lee1092 has joined #openstack-cinder | 19:30 | |
nikeshm | asselin : thanks, | 19:32 |
*** IlyaG has quit IRC | 19:34 | |
*** IlyaG has joined #openstack-cinder | 19:34 | |
*** ebalduf has quit IRC | 19:35 | |
*** alexpilotti has joined #openstack-cinder | 19:35 | |
*** ebalduf has joined #openstack-cinder | 19:37 | |
*** IlyaG has quit IRC | 19:38 | |
*** ebalduf has quit IRC | 19:41 | |
*** ebalduf has joined #openstack-cinder | 19:42 | |
*** angela-s has joined #openstack-cinder | 19:45 | |
*** abehl has joined #openstack-cinder | 19:49 | |
*** daneyon has joined #openstack-cinder | 19:51 | |
*** kmartin has quit IRC | 19:51 | |
*** openstackgerrit has quit IRC | 19:52 | |
*** MentalRay has joined #openstack-cinder | 19:52 | |
*** openstackgerrit has joined #openstack-cinder | 19:52 | |
*** rushil has quit IRC | 19:54 | |
*** daneyon_ has quit IRC | 19:54 | |
*** IlyaG has joined #openstack-cinder | 19:57 | |
*** rushil has joined #openstack-cinder | 19:57 | |
*** markvoelker has quit IRC | 19:57 | |
*** dannywil_ has joined #openstack-cinder | 19:58 | |
nikeshm | asselin : there? | 20:00 |
nikeshm | asselin : where can i set this tox -e all -- volume --concurrency=2 | tee -a console.log.out | 20:00 |
*** annegentle has joined #openstack-cinder | 20:00 | |
*** dannywilson has quit IRC | 20:00 | |
nikeshm | patrickeast : there? | 20:03 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Added a unit test for masking iscsiadm passwords https://review.openstack.org/181553 | 20:04 |
patrickeast_ | nikeshm: hey | 20:04 |
thingee | hemna: thanks | 20:05 |
*** danieru has quit IRC | 20:05 | |
hemna | np man | 20:05 |
hemna | sorry I missed that | 20:05 |
patrickeast_ | nikeshm: so if you are using devstack-gate there are a couple of environment variables to confgiure that control what tests are run and the concurrency | 20:05 |
*** abehl has quit IRC | 20:05 | |
patrickeast_ | nikeshm: DEVSTACK_GATE_TEMPEST_REGEX and TEMPEST_CONCURRENCY | 20:05 |
patrickeast_ | those get piped in to the ‘volume’ and ‘2’ from your line above | 20:06 |
patrickeast_ | nikeshm: here is where it actually gets called https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L640 | 20:07 |
*** ganso_ has quit IRC | 20:07 | |
nikeshm | patrickeast : thanks | 20:08 |
*** ebalduf has quit IRC | 20:08 | |
*** asrangne has quit IRC | 20:09 | |
*** ebalduf has joined #openstack-cinder | 20:09 | |
patrickeast_ | nikeshm: np | 20:10 |
*** asrangne has joined #openstack-cinder | 20:10 | |
*** cdelatte has quit IRC | 20:10 | |
*** delattec has quit IRC | 20:10 | |
*** markvoelker has joined #openstack-cinder | 20:11 | |
*** ebalduf has quit IRC | 20:14 | |
*** ebalduf has joined #openstack-cinder | 20:15 | |
*** abehl has joined #openstack-cinder | 20:17 | |
*** mriedem has quit IRC | 20:18 | |
asselin | nikeshm, glad to hear your making progress | 20:24 |
*** rushil has quit IRC | 20:26 | |
*** mriedem has joined #openstack-cinder | 20:27 | |
*** rushil has joined #openstack-cinder | 20:29 | |
*** kmartin has joined #openstack-cinder | 20:29 | |
*** lcurtis has joined #openstack-cinder | 20:41 | |
*** madskier has joined #openstack-cinder | 20:42 | |
*** abehl has quit IRC | 20:42 | |
*** ebalduf has quit IRC | 20:46 | |
*** annegentle has quit IRC | 20:47 | |
*** jdurgin has quit IRC | 20:48 | |
*** changbl has quit IRC | 20:48 | |
*** jdurgin has joined #openstack-cinder | 20:48 | |
*** dustins_ has quit IRC | 20:48 | |
*** dannywil_ has quit IRC | 20:49 | |
*** rushil has quit IRC | 20:50 | |
*** dannywilson has joined #openstack-cinder | 20:51 | |
*** jaypipes has quit IRC | 20:53 | |
*** sgotliv has quit IRC | 20:53 | |
*** abehl has joined #openstack-cinder | 20:54 | |
*** rushil has joined #openstack-cinder | 20:54 | |
*** cbader has quit IRC | 20:55 | |
*** krtaylor has quit IRC | 20:55 | |
*** bswartz has quit IRC | 20:56 | |
*** dannywilson has quit IRC | 20:56 | |
*** jdurgin has quit IRC | 20:59 | |
*** MentalRay has quit IRC | 21:00 | |
*** setmason has quit IRC | 21:05 | |
*** MentalRay has joined #openstack-cinder | 21:06 | |
*** vilobhmm1 has quit IRC | 21:07 | |
*** setmason has joined #openstack-cinder | 21:07 | |
*** vilobhmm1 has joined #openstack-cinder | 21:08 | |
*** haomaiwang has quit IRC | 21:08 | |
*** vilobhmm1 has quit IRC | 21:08 | |
*** rushil has quit IRC | 21:08 | |
*** chlong has quit IRC | 21:08 | |
*** vilobhmm1 has joined #openstack-cinder | 21:09 | |
*** vilobhmm1 has quit IRC | 21:09 | |
*** haomaiwa_ has joined #openstack-cinder | 21:09 | |
*** vilobhmm1 has joined #openstack-cinder | 21:09 | |
*** jdurgin has joined #openstack-cinder | 21:10 | |
*** vilobhmm1 has quit IRC | 21:10 | |
*** vilobhmm1 has joined #openstack-cinder | 21:10 | |
*** dannywilson has joined #openstack-cinder | 21:10 | |
*** vilobhmm1 has quit IRC | 21:11 | |
*** markvoelker has quit IRC | 21:14 | |
*** rushil has joined #openstack-cinder | 21:16 | |
*** crose has quit IRC | 21:18 | |
*** jungleboyj has quit IRC | 21:18 | |
*** ebalduf has joined #openstack-cinder | 21:19 | |
*** Yogi1 has quit IRC | 21:21 | |
*** openstackgerrit has quit IRC | 21:22 | |
*** openstackgerrit has joined #openstack-cinder | 21:22 | |
*** madskier has quit IRC | 21:23 | |
*** markvoelker has joined #openstack-cinder | 21:24 | |
*** lpetrut has quit IRC | 21:27 | |
*** annegentle has joined #openstack-cinder | 21:28 | |
*** sgotliv has joined #openstack-cinder | 21:28 | |
*** setmason has quit IRC | 21:30 | |
*** rushil has quit IRC | 21:31 | |
*** vilobhmm1 has joined #openstack-cinder | 21:33 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields https://review.openstack.org/183222 | 21:35 |
*** vilobhmm1 has quit IRC | 21:37 | |
*** setmason has joined #openstack-cinder | 21:38 | |
*** e0ne has quit IRC | 21:39 | |
*** e0ne has joined #openstack-cinder | 21:40 | |
*** Lee1092 has quit IRC | 21:41 | |
*** erlon has quit IRC | 21:41 | |
*** mriedem has quit IRC | 21:47 | |
*** ociuhandu has quit IRC | 21:48 | |
*** abehl has quit IRC | 21:54 | |
*** vilobhmm1 has joined #openstack-cinder | 21:57 | |
*** jdurgin has quit IRC | 22:00 | |
*** e0ne has quit IRC | 22:01 | |
*** Rockyg has joined #openstack-cinder | 22:02 | |
*** jungleboyj has joined #openstack-cinder | 22:02 | |
*** vilobhmm1 has quit IRC | 22:03 | |
*** vilobhmm1 has joined #openstack-cinder | 22:03 | |
*** markvoelker has quit IRC | 22:04 | |
*** vilobhmm1 has quit IRC | 22:04 | |
*** vilobhmm1 has joined #openstack-cinder | 22:04 | |
*** vilobhmm1 has quit IRC | 22:04 | |
*** vilobhmm1 has joined #openstack-cinder | 22:05 | |
*** vilobhmm1 has quit IRC | 22:05 | |
*** hodos has quit IRC | 22:06 | |
*** primechuck has quit IRC | 22:16 | |
*** vilobhmm1 has joined #openstack-cinder | 22:16 | |
*** eharney has quit IRC | 22:17 | |
*** cdelatte has joined #openstack-cinder | 22:17 | |
*** annegentle has quit IRC | 22:20 | |
*** isd has quit IRC | 22:24 | |
*** markvoelker has joined #openstack-cinder | 22:25 | |
jungleboyj | hemna: The FC slides look great. Thank you! | 22:29 |
hemna | :) welcome. should be a party! | 22:29 |
jungleboyj | Indeed. | 22:30 |
jungleboyj | Sorry I haven't been much help on the presentations. It has been a wild month. | 22:30 |
*** sgotliv has quit IRC | 22:30 | |
*** IlyaG_ has joined #openstack-cinder | 22:36 | |
openstackgerrit | Joshua Huber proposed openstack/cinder: Add cinder volume driver for Blockbridge EPS https://review.openstack.org/178295 | 22:36 |
*** IlyaG has quit IRC | 22:36 | |
*** daneyon has quit IRC | 22:39 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/178410 | 22:42 |
*** IlyaG has joined #openstack-cinder | 22:42 | |
*** IlyaG_ has quit IRC | 22:43 | |
*** annegentle has joined #openstack-cinder | 22:45 | |
*** annegentle has quit IRC | 22:47 | |
*** shakamunyi has joined #openstack-cinder | 22:47 | |
*** barra204 has joined #openstack-cinder | 22:47 | |
*** rmesta has quit IRC | 22:48 | |
mtanino | jungleboyj: Hi, Can we still backport critical fixes except security issue? I noticed this. https://review.openstack.org/#/c/183330/ | 22:49 |
jungleboyj | mtanino: Yeah, I was thinking about that. I think for a little longer we can take fixes for Juno. I am about to propose a backport as well that would be good to get pulled back. | 22:50 |
jungleboyj | mtanino: With scrutiny though. | 22:50 |
*** IlyaG has quit IRC | 22:50 | |
*** IlyaG has joined #openstack-cinder | 22:51 | |
mtanino | jungleboyj: I think it is better to backport this for stable/juno if we can. https://bugs.launchpad.net/cinder/+bug/1454835 | 22:51 |
openstack | Launchpad bug 1454835 in Cinder "[LVM] Volume migration destroys volume data" [Critical,Fix committed] - Assigned to Mitsuhiro Tanino (mitsuhiro-tanino) | 22:51 |
mtanino | this is critical. | 22:52 |
*** nikeshm has quit IRC | 22:52 | |
jungleboyj | mtanino: I would agree if jgriffith is ok with it. | 22:53 |
hemna | who needs volume data anyway | 22:53 |
mtanino | jungleboyj: I got it. | 22:53 |
jungleboyj | hemna: I hear it is overrated. | 22:54 |
hemna | yah, silly users | 22:54 |
hemna | and on that note, it's time to go buy beer. | 22:55 |
*** hemna is now known as hemnafk | 22:55 | |
jungleboyj | hemnafk: Sounds like a good plan. About to go do the same. | 22:55 |
hemnafk | jungleboyj, +1 | 22:55 |
*** MentalRay has quit IRC | 22:56 | |
*** markvoelker has quit IRC | 22:58 | |
*** ociuhandu has joined #openstack-cinder | 22:59 | |
*** IlyaG has quit IRC | 23:00 | |
*** IlyaG has joined #openstack-cinder | 23:01 | |
*** bswartz has joined #openstack-cinder | 23:01 | |
*** vilobhmm1 has quit IRC | 23:03 | |
*** vilobhmm1 has joined #openstack-cinder | 23:03 | |
*** barra204 has quit IRC | 23:04 | |
*** shakamunyi has quit IRC | 23:04 | |
*** Trozz has quit IRC | 23:04 | |
*** markvoelker has joined #openstack-cinder | 23:05 | |
*** SamYaple has quit IRC | 23:05 | |
*** IlyaG has quit IRC | 23:05 | |
*** asrangne__ has joined #openstack-cinder | 23:08 | |
openstackgerrit | Tom Barron proposed openstack/cinder: Add standard QoS spec support to cDOT drivers https://review.openstack.org/179352 | 23:10 |
*** chlong has joined #openstack-cinder | 23:10 | |
*** asrangne has quit IRC | 23:11 | |
*** atan8 has quit IRC | 23:16 | |
*** barra204 has joined #openstack-cinder | 23:18 | |
*** shakamunyi has joined #openstack-cinder | 23:18 | |
*** madskier has joined #openstack-cinder | 23:20 | |
*** ebalduf has quit IRC | 23:23 | |
*** madskier has quit IRC | 23:24 | |
*** jungleboyj has quit IRC | 23:26 | |
*** atan8 has joined #openstack-cinder | 23:26 | |
*** lcurtis has quit IRC | 23:26 | |
*** atan8 has quit IRC | 23:26 | |
*** Longgeek has quit IRC | 23:30 | |
*** Longgeek has joined #openstack-cinder | 23:30 | |
*** _cjones_ has quit IRC | 23:32 | |
*** _cjones_ has joined #openstack-cinder | 23:33 | |
*** angela-s has left #openstack-cinder | 23:43 | |
*** IlyaG has joined #openstack-cinder | 23:45 | |
*** IlyaG has quit IRC | 23:46 | |
*** ebalduf has joined #openstack-cinder | 23:47 | |
*** ebalduf has quit IRC | 23:52 | |
*** IlyaG has joined #openstack-cinder | 23:53 | |
*** setmason has quit IRC | 23:53 | |
*** IlyaG has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!