| *** jcru has joined #openstack-cinder | 00:25 | |
| *** aix has quit IRC | 00:26 | |
| *** jcru has quit IRC | 00:28 | |
| *** jcru has joined #openstack-cinder | 00:28 | |
| *** jcru has quit IRC | 00:29 | |
| *** aix has joined #openstack-cinder | 00:30 | |
| *** annashen has joined #openstack-cinder | 00:36 | |
| *** annashen has quit IRC | 00:41 | |
| *** xyang has quit IRC | 00:48 | |
| *** vilobhmm has joined #openstack-cinder | 00:52 | |
| *** topshare has joined #openstack-cinder | 01:04 | |
| *** Longgeek has joined #openstack-cinder | 01:08 | |
| *** liusheng has quit IRC | 01:13 | |
| *** Longgeek has quit IRC | 01:15 | |
| *** alexpilotti has quit IRC | 01:19 | |
| *** harlowja_at_home has joined #openstack-cinder | 01:21 | |
| *** mtanino has joined #openstack-cinder | 01:25 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver check before associating LUN to a LUN group https://review.openstack.org/148144 | 01:25 |
|---|---|---|
| *** vilobhmm has quit IRC | 01:27 | |
| *** lcurtis has joined #openstack-cinder | 01:30 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver fix problems under multipath https://review.openstack.org/150767 | 01:32 |
| *** Yogi1 has joined #openstack-cinder | 01:34 | |
| *** Lee1092 has joined #openstack-cinder | 01:40 | |
| *** harlowja_at_home has quit IRC | 01:50 | |
| *** annashen has joined #openstack-cinder | 01:54 | |
| *** annashen has quit IRC | 01:58 | |
| *** annashen has joined #openstack-cinder | 01:59 | |
| *** xyang has joined #openstack-cinder | 02:01 | |
| *** ho has joined #openstack-cinder | 02:02 | |
| *** Yogi1 has quit IRC | 02:08 | |
| *** Administrator__ has quit IRC | 02:14 | |
| *** Administrator__ has joined #openstack-cinder | 02:14 | |
| *** asselin_ has quit IRC | 02:23 | |
| *** julim has quit IRC | 02:24 | |
| *** takedakn has joined #openstack-cinder | 02:49 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 02:53 |
| *** jungleboyj_ has joined #openstack-cinder | 02:53 | |
| *** takedakn has quit IRC | 02:57 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder-specs: Enhance list operations with the additional keys and next link https://review.openstack.org/148181 | 02:57 |
| *** coolsvap|afk is now known as coolsvap | 02:58 | |
| *** annashen has quit IRC | 03:05 | |
| *** Longgeek has joined #openstack-cinder | 03:11 | |
| openstackgerrit | Jeegn Chen proposed openstack/cinder: More error handling on VNX migration failure. https://review.openstack.org/159704 | 03:13 |
| *** Longgeek has quit IRC | 03:13 | |
| *** Longgeek has joined #openstack-cinder | 03:14 | |
| *** topshare_ has joined #openstack-cinder | 03:18 | |
| *** Longgeek_ has joined #openstack-cinder | 03:19 | |
| *** topshare has quit IRC | 03:20 | |
| *** Longgeek has quit IRC | 03:20 | |
| *** lcurtis has quit IRC | 03:25 | |
| *** buster_604 has joined #openstack-cinder | 03:31 | |
| *** takedakn has joined #openstack-cinder | 03:35 | |
| *** topshare_ has quit IRC | 03:36 | |
| *** topshare has joined #openstack-cinder | 03:37 | |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 03:39 |
| openstackgerrit | Tina Tang proposed openstack/cinder: Attach/detach batch processing in VNX driver https://review.openstack.org/154350 | 03:40 |
| *** Longgeek has joined #openstack-cinder | 03:41 | |
| *** Ilja has joined #openstack-cinder | 03:43 | |
| *** Longgeek_ has quit IRC | 03:44 | |
| *** takedakn has quit IRC | 03:48 | |
| *** haomaiwang has joined #openstack-cinder | 03:49 | |
| *** shyama has joined #openstack-cinder | 04:09 | |
| *** Longgeek has quit IRC | 04:11 | |
| *** Longgeek has joined #openstack-cinder | 04:11 | |
| *** topshare has quit IRC | 04:20 | |
| *** vincent_hou has joined #openstack-cinder | 04:22 | |
| vincent_hou | mtanino: Ping. | 04:22 |
| mtanino | vincent_hou: hi | 04:22 |
| mtanino | vincent_hou: May be previous comment is confusiong. | 04:23 |
| mtanino | vincent_hou: simple question. Can you delete the dest volume using "cinder delete vol-id" after the migration will be failed? | 04:24 |
| mtanino | vincent_hou: I think we can't. | 04:24 |
| vincent_hou | OK. If we still have dest volume in the DB. It is already across two steps. | 04:25 |
| vincent_hou | The first is migration fails, then we delete the dest volume. The second is deleting this dest volume also fails. | 04:26 |
| vincent_hou | When the first step happened, then we reach rpcapi.delete_volume(ctxt, volume) | 04:27 |
| mtanino | vincent_hou: yup | 04:27 |
| vincent_hou | If rpcapi.delete_volume(ctxt, volume) also fails, then we will have this dest volume still in DB. | 04:27 |
| mtanino | vincent_hou: Also we can see the volume using "cinder list" right? | 04:28 |
| vincent_hou | yes. | 04:28 |
| *** Ilja has quit IRC | 04:28 | |
| mtanino | vincent_hou: In this situation can you delete the volume using cinder delete? | 04:28 |
| vincent_hou | No, because rpcapi.delete_volume(ctxt, volume) is already trying to do that and it fails. | 04:29 |
| mtanino | vincent_hou: OK. After trying to solve the root cause of deletion failure such as "occupied by other devices", | 04:30 |
| vincent_hou | I guess one possible solution is to clean the DB record for it. | 04:31 |
| mtanino | vincent_hou: user wnat to delete the volume again. | 04:31 |
| vincent_hou | Right, it is quite confusing. | 04:32 |
| mtanino | vincent_hou: So I want to clear the migration_status at Line 510 or Line 517 when volume deletion is failed | 04:32 |
| vincent_hou | The dest volume is still in DB, but user cannot delete ot even force delete it. | 04:32 |
| mtanino | vincent_hou: yes yes | 04:33 |
| vincent_hou | For this issue, I think clearing the migration_status is not enough. | 04:33 |
| mtanino | vincent_hou: Yes. both solving the root cause of deletion failure and clean up of migration_status are needed? | 04:34 |
| mtanino | vincent_hou: but we can't solve the root cause via Cinder. | 04:35 |
| vincent_hou | How about doing a check in delete_volume? First I need to know it is a dest volume or not. If it is a dest volume, then we need to clear the DB anyway. | 04:35 |
| *** [1]Thelo has joined #openstack-cinder | 04:35 | |
| *** topshare has joined #openstack-cinder | 04:36 | |
| mtanino | vincent_hou: Please see line 522 and 523. I added flags for cheking migration source, dest volumes | 04:36 |
| mtanino | vincent_hou: you can use "is_migrating_dest" flag | 04:37 |
| vincent_hou | If we cannot remove the dest volume from the backend, then we cannot force to delete it from the backend. | 04:37 |
| vincent_hou | OK. | 04:37 |
| mtanino | vincent_hou: so please move these flags around Line 494 or someting and use it. | 04:38 |
| *** Thelo has quit IRC | 04:38 | |
| *** [1]Thelo is now known as Thelo | 04:38 | |
| *** bkopilov has quit IRC | 04:39 | |
| *** harry has joined #openstack-cinder | 04:39 | |
| harry | is e0ne here? | 04:40 |
| harry | ping e0ne | 04:40 |
| harry | @e0ne I am harry | 04:40 |
| mtanino | vincent_hou: good night, zzz | 04:40 |
| *** mtanino is now known as mtanino_away | 04:40 | |
| harry | Oh, let's contact him tomorrow ;-) | 04:41 |
| vincent_hou | mtanino: Thank you. take care. | 04:41 |
| harry | e0ne: are you here? | 04:42 |
| harry | ping thingee | 04:43 |
| harry | thingee: are you here? | 04:43 |
| openstackgerrit | Mike Perez proposed openstack/cinder: Revert "Datera's export to avoid deprecated keys" https://review.openstack.org/164574 | 04:43 |
| *** annashen has joined #openstack-cinder | 04:47 | |
| *** changbl has quit IRC | 04:48 | |
| *** bkopilov has joined #openstack-cinder | 04:55 | |
| *** xyang has quit IRC | 04:57 | |
| *** xyang has joined #openstack-cinder | 04:57 | |
| *** BharatK has joined #openstack-cinder | 05:00 | |
| *** annashen has quit IRC | 05:03 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 05:06 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 05:10 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 05:15 |
| *** anuragpalsule has joined #openstack-cinder | 05:23 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 05:27 |
| *** Ilja has joined #openstack-cinder | 05:28 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 05:36 |
| *** Mandell has joined #openstack-cinder | 05:52 | |
| *** vincent_hou has quit IRC | 05:55 | |
| *** changbl has joined #openstack-cinder | 05:58 | |
| *** lpetrut has joined #openstack-cinder | 06:01 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/152401 | 06:09 |
| *** nlevinki has joined #openstack-cinder | 06:12 | |
| *** vilobhmm has joined #openstack-cinder | 06:13 | |
| *** Mandell has quit IRC | 06:17 | |
| *** nshaikh has joined #openstack-cinder | 06:17 | |
| openstackgerrit | Pranali Deore proposed openstack/cinder: Mocked utils.execute for broken tests https://review.openstack.org/164093 | 06:21 |
| *** afazekas has joined #openstack-cinder | 06:23 | |
| *** pradipta has joined #openstack-cinder | 06:25 | |
| *** Administrator__ has quit IRC | 06:26 | |
| *** Mandell has joined #openstack-cinder | 06:26 | |
| *** Administrator__ has joined #openstack-cinder | 06:26 | |
| *** xyang has quit IRC | 06:33 | |
| *** nkrinner has joined #openstack-cinder | 06:42 | |
| *** abehl has joined #openstack-cinder | 06:47 | |
| *** vilobhmm has quit IRC | 06:49 | |
| *** Longgeek_ has joined #openstack-cinder | 06:52 | |
| *** Longgeek has quit IRC | 06:52 | |
| *** ronis has joined #openstack-cinder | 07:11 | |
| *** pratyu has joined #openstack-cinder | 07:13 | |
| *** pcaruana has quit IRC | 07:14 | |
| *** kaisers has joined #openstack-cinder | 07:24 | |
| *** TobiasE has joined #openstack-cinder | 07:26 | |
| *** mtanino_away has quit IRC | 07:28 | |
| *** e0ne has joined #openstack-cinder | 07:34 | |
| *** sgotliv has quit IRC | 07:36 | |
| *** e0ne has quit IRC | 07:39 | |
| *** rwsu has joined #openstack-cinder | 07:43 | |
| *** Miouge has joined #openstack-cinder | 07:44 | |
| *** liusheng has joined #openstack-cinder | 07:44 | |
| *** markus_z has joined #openstack-cinder | 08:08 | |
| *** jordanP has joined #openstack-cinder | 08:09 | |
| *** dulek has joined #openstack-cinder | 08:16 | |
| *** asselin_ has joined #openstack-cinder | 08:18 | |
| *** pradipta has quit IRC | 08:22 | |
| *** asselin_ has quit IRC | 08:23 | |
| *** lpetrut has quit IRC | 08:28 | |
| *** Miouge has quit IRC | 08:29 | |
| *** Miouge has joined #openstack-cinder | 08:32 | |
| *** ndipanov has joined #openstack-cinder | 08:33 | |
| *** Miouge has quit IRC | 08:36 | |
| *** nellysmitt has joined #openstack-cinder | 08:40 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Backup object https://review.openstack.org/157085 | 08:40 |
| openstackgerrit | Tina Tang proposed openstack/cinder: Attach/detach batch processing in VNX driver https://review.openstack.org/154350 | 08:42 |
| *** Miouge has joined #openstack-cinder | 08:44 | |
| *** topshare_ has joined #openstack-cinder | 08:53 | |
| *** Miouge has quit IRC | 08:54 | |
| *** topshare has quit IRC | 08:55 | |
| *** lpetrut has joined #openstack-cinder | 08:56 | |
| *** lpetrut has quit IRC | 08:57 | |
| *** nlevinki has quit IRC | 09:01 | |
| *** Mandell has quit IRC | 09:01 | |
| *** jistr has joined #openstack-cinder | 09:11 | |
| *** harry has quit IRC | 09:14 | |
| *** harry has joined #openstack-cinder | 09:14 | |
| *** nlevinki has joined #openstack-cinder | 09:16 | |
| *** deepakcs has joined #openstack-cinder | 09:22 | |
| *** sgotliv has joined #openstack-cinder | 09:26 | |
| deepakcs | DuncanT, ping, reg. the discussion u were having with BharatK | 09:26 |
| deepakcs | DuncanT, I don't think its a good idea to assume user knows about fallocate (context: <DuncanT> choices = ['qcow2', 'sparse', 'dd', 'fallocate']) | 09:27 |
| deepakcs | DuncanT, or even know about which is better (dd Vs fallocate etc) | 09:27 |
| deepakcs | DuncanT, I was thinking of something like this: | 09:27 |
| deepakcs | volume_format = ['qcow2', 'raw'] and provisioning_type = ['thick', 'thin'] - generic and easy to understand | 09:28 |
| deepakcs | DuncanT, ^^ what do you think ? | 09:28 |
| DuncanT | deepakcs: Can you have thin and thick provisioned qcow2 in any meaningful way? | 09:30 |
| *** harry has quit IRC | 09:31 | |
| deepakcs | DuncanT, good point, we can ignore the prov_type for qcow2 (as we only support thin there, and it doesn't make sense to have thick) | 09:31 |
| deepakcs | DuncanT, but for raw {thin, thick} we can use fallocate for thick and fall back to 'dd' if fallocate doesn't work for some FS reason, thin would be to use sparse | 09:32 |
| DuncanT | deepakcs: I'm not sure which is clearer. Is there a reason you'd want to use dd rather than fallocate? | 09:32 |
| DuncanT | Trying fallocate, waiting for it to fail the using dd is likely to produce messy logs and bad performance, I'd have thought? | 09:32 |
| deepakcs | DuncanT, for some (rare?) cases where FS doesn't support fallocate, for eg: glusterfs fuse didn't support in 3.4 but it does in 3.6 and we would want to support both | 09:32 |
| deepakcs | DuncanT, and user doesn't have to worry whether it works or not, either way we give him thick volume | 09:33 |
| deepakcs | DuncanT, we can control the logs (just put a warn, don't dump stack) | 09:33 |
| deepakcs | DuncanT, one other way could be choice = ['qcow2', 'raw-thin', 'raw-thick'] | 09:34 |
| DuncanT | I think I'd prefer the explicit choice for now. Warnings are supposed to be things admins can fix, so we definitely don't want warning. | 09:35 |
| deepakcs | DuncanT, choice = ['qcow2', 'raw-thin', 'raw-thick'] isn't explicit you mean ? I am not sure if dd and fallocate are good to be exposed Vs thin and thick ? | 09:36 |
| DuncanT | deepakcs: If 'thick' was one choice, I'd agree, but ti isn't, it still leaves a choice between dd and falocate. | 09:37 |
| deepakcs | DuncanT, Hmm ok , my concern there is that just choosing dd/fallocate doesn't really tell the format type (raw) Vs choosign qcow2, there should be some symettry, no ? | 09:39 |
| DuncanT | deepakcs: I'm far more concerned with correctness than symmetry here. Until we don't support any filesystems that don't support fallocate, we need to be able to force dd, and even then we might want to keep it for debugging | 09:40 |
| DuncanT | I think one option with all of the choices is clearer than any alternative presented | 09:41 |
| *** marcusvrn1 has joined #openstack-cinder | 09:42 | |
| jordanP | sorry for jumping in late: is the choice presented to end users or sysadmins ? | 09:42 |
| jordanP | if it's for sysadmin, imo we can assume they know the difference between dd and fallocate | 09:42 |
| DuncanT | jordanP: Admins, and I agree if it was tennant facing we'd need to clear it up | 09:43 |
| deepakcs | jordanP, its cinder.conf, mostly sysadmins, but making it friendlier is what i was aiming for, but DuncanT's point is good too | 09:43 |
| deepakcs | DuncanT, ok so 1 option with multiple explicit choices is what we go with then. | 09:44 |
| jordanP | right, though I am not sure to see the difference between 'sparse' and 'fallocate' myself :) | 09:44 |
| DuncanT | deepakcs: Thanks | 09:44 |
| deepakcs | DuncanT, and what about back compat, i know u said u don't know whats the right way there, but BharatK says there is deprecate option provided in oslo.cfg, we should use that then ? | 09:45 |
| DuncanT | jordanP: It is fallocate .v. dd - fallocate is substantially faster and places less load on the system, for filesystems that support it | 09:45 |
| deepakcs | jordanP, and sparse is thinp , fallocate is thick (from FS perspective) | 09:46 |
| jordanP | ah ok, yeah, got it thanks | 09:46 |
| DuncanT | deepakcs: You should use the deprecate option, yes. The hard bit is figuring out if the new type option is specified or not, and if not how to emulate the old behaviour. I'm sure it can be done, but it is probably fiddly (and should have its own unit test(s) making all of the combinations clear) | 09:47 |
| deepakcs | DuncanT, " if the new type option is specified or not" - if new_option not in cfg , then its not specified, otherwise it is.. didn't get u on this one | 09:48 |
| DuncanT | deepakcs: Config options have a default value | 09:48 |
| DuncanT | deepakcs: Other than setting the default to none or something, and translating that in the code, I'm not sure how to tell it isn't set. It might be easy, if so, great. I don't know | 09:49 |
| deepakcs | DuncanT, I see ur point now, yeah, setting new_option default to some invalid value could be the only way out | 09:50 |
| deepakcs | DuncanT, unless oslo has a way to tell whther the option is literally specified in the conf or not :) | 09:51 |
| DuncanT | deepakcs: I've no idea, sorry. All I know is that it is a tricky area. | 09:51 |
| DuncanT | deepakcs: Might be worth approaching the oslo_cfg maintainers for advice? | 09:52 |
| DuncanT | deepakcs: If you get a good solution, please let me know | 09:52 |
| deepakcs | DuncanT, sure, and thanks for your suggestions | 09:54 |
| *** topshare_ has quit IRC | 09:55 | |
| deepakcs | DuncanT, i know that in manila project they wanted to implement something similar (a config option that _must_ be specified by the admin), IIRC they set the default to None and used the same trick | 09:55 |
| *** topshare has joined #openstack-cinder | 09:56 | |
| *** sseverson has quit IRC | 10:00 | |
| *** sseverson has joined #openstack-cinder | 10:01 | |
| *** Maike has joined #openstack-cinder | 10:06 | |
| *** nlevinki has quit IRC | 10:09 | |
| *** Ilja1 has joined #openstack-cinder | 10:12 | |
| *** Ilja has quit IRC | 10:13 | |
| *** sgotliv has quit IRC | 10:14 | |
| *** sgotliv has joined #openstack-cinder | 10:14 | |
| *** topshare has quit IRC | 10:15 | |
| *** coolsvap is now known as coolsvap|afk | 10:19 | |
| *** topshare has joined #openstack-cinder | 10:23 | |
| *** nlevinki has joined #openstack-cinder | 10:23 | |
| *** ho has quit IRC | 10:24 | |
| *** Administrator__ has quit IRC | 10:24 | |
| *** sgotliv has quit IRC | 10:25 | |
| *** Ilja1 has quit IRC | 10:29 | |
| *** topshare has quit IRC | 10:32 | |
| *** Ilja has joined #openstack-cinder | 10:37 | |
| *** rakesh_mishra__ has joined #openstack-cinder | 10:40 | |
| *** rakesh_mishra__ has quit IRC | 10:41 | |
| *** rakesh_mishra__ has joined #openstack-cinder | 10:42 | |
| rakesh_mishra__ | Hi | 10:45 |
| rakesh_mishra__ | can any one tell me when i create the snapshot where it stores in the file system | 10:45 |
| rakesh_mishra__ | Like images are store in the below location | 10:45 |
| rakesh_mishra__ | /opt/stack/data/glance/images | 10:45 |
| rakesh_mishra__ | this is the volume-snapshot | 10:45 |
| *** topshare has joined #openstack-cinder | 10:47 | |
| *** topshare has quit IRC | 10:47 | |
| *** topshare has joined #openstack-cinder | 10:48 | |
| *** avishay has joined #openstack-cinder | 10:49 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 10:51 | |
| *** rakesh_mishra__ has quit IRC | 10:51 | |
| DuncanT | rakesh_mishra_: If you're using the default cinder driver (LVM) and the default devstack config (loopback) then they are stored on the cinder looback file | 10:56 |
| DuncanT | "sudo losetup -a" should list it | 10:56 |
| rakesh_mishra_ | DuncanT: yes i am using deafult config file and lvm driver | 11:05 |
| *** haomaiwang has quit IRC | 11:06 | |
| rakesh_mishra_ | DuncanT: it showing below output when i run the command | 11:08 |
| rakesh_mishra_ | /dev/loop0: [0801]:404258 (/opt/stack/data/stack-volumes-default-backing-file) | 11:08 |
| rakesh_mishra_ | /dev/loop1: [0801]:404677 (/opt/stack/data/stack-volumes-lvmdriver-1-backing-file) | 11:08 |
| *** nlevinki has quit IRC | 11:09 | |
| *** takedakn has joined #openstack-cinder | 11:14 | |
| *** takedakn has quit IRC | 11:18 | |
| *** takedakn has joined #openstack-cinder | 11:18 | |
| *** aix has quit IRC | 11:21 | |
| DuncanT | Can you post up /etc/cinder/cinder.conf please? Us paste.openstack.org | 11:22 |
| *** timcl has joined #openstack-cinder | 11:24 | |
| *** rakesh_mishra_ has quit IRC | 11:24 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 11:24 | |
| *** topshare has quit IRC | 11:26 | |
| *** sgotliv has joined #openstack-cinder | 11:31 | |
| *** IanGovett has joined #openstack-cinder | 11:31 | |
| rakesh_mishra_ | DuncanT: yes one minute | 11:34 |
| rakesh_mishra_ | DuncanT: http://paste.openstack.org/show/192610/ | 11:36 |
| DuncanT | Ok, your snapshots and volumes are all in /opt/stack/data/stack-volumes-lvmdriver-1-backing-file | 11:37 |
| rakesh_mishra_ | but this is the single file | 11:37 |
| rakesh_mishra_ | i have created so many snapshots | 11:37 |
| DuncanT | Yes. It is an LVM device | 11:37 |
| DuncanT | They all go on the same pv or pvs. Devstack by default sets up one | 11:38 |
| DuncanT | On a 'real' deployment, you'd use one or more dedicated spindles most likely | 11:38 |
| *** rushiagr_away is now known as rushiagr | 11:39 | |
| rakesh_mishra_ | pv? | 11:40 |
| DuncanT | Pysical volume. It's LVM terminology, google should find you an LVM primer | 11:40 |
| DuncanT | Physical volume, sorry | 11:40 |
| rakesh_mishra_ | thanks | 11:40 |
| rakesh_mishra_ | but i have created a volume of 1GB so it should take 1GB space instead of update the dictionary in stack-volumes-lvmdriver-1-backing-file | 11:41 |
| *** rakesh_mishra_ has quit IRC | 11:42 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 11:42 | |
| rakesh_mishra_ | but i have created a volume of 1GB so it should take 1GB space instead of update the dictionary in stack-volumes-lvmdriver-1-backing-file | 11:43 |
| *** pratyu has quit IRC | 11:44 | |
| *** nlevinki has joined #openstack-cinder | 11:45 | |
| *** rakesh_mishra__ has joined #openstack-cinder | 11:48 | |
| *** rakesh_mishra_ has quit IRC | 11:50 | |
| *** jaypipes has joined #openstack-cinder | 11:51 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 11:52 | |
| DuncanT | LVM doesn't work like that, and you've got thin provisioning enabled | 11:54 |
| DuncanT | Please go and find an LVM primer | 11:54 |
| *** rakesh_mishra__ has quit IRC | 11:54 | |
| *** rushiagr is now known as rushiagr_away | 11:55 | |
| *** rakesh_mishra_ has quit IRC | 11:55 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 11:55 | |
| *** TobiasE1 has joined #openstack-cinder | 12:00 | |
| *** rushiagr_away is now known as rushiagr | 12:01 | |
| *** jcru has joined #openstack-cinder | 12:01 | |
| *** jcru has quit IRC | 12:01 | |
| *** TobiasE has quit IRC | 12:01 | |
| *** jcru has joined #openstack-cinder | 12:02 | |
| *** nlevinki has quit IRC | 12:02 | |
| *** rakesh_mishra_ has quit IRC | 12:03 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 12:03 | |
| *** deepakcs has quit IRC | 12:07 | |
| *** nlevinki has joined #openstack-cinder | 12:15 | |
| *** bswartz has quit IRC | 12:26 | |
| *** alexpilotti has joined #openstack-cinder | 12:27 | |
| *** rakesh_mishra_ has quit IRC | 12:32 | |
| *** porrua has joined #openstack-cinder | 12:42 | |
| *** lpetrut has joined #openstack-cinder | 12:47 | |
| *** openstackgerrit has quit IRC | 12:50 | |
| *** openstackgerrit has joined #openstack-cinder | 12:50 | |
| *** fifieldt has joined #openstack-cinder | 12:51 | |
| *** akerr has joined #openstack-cinder | 12:53 | |
| *** avishay has quit IRC | 13:00 | |
| *** bswartz has joined #openstack-cinder | 13:01 | |
| *** Yogi1 has joined #openstack-cinder | 13:02 | |
| *** Mandell has joined #openstack-cinder | 13:02 | |
| nikesh_vedams | Hi | 13:04 |
| *** Mandell has quit IRC | 13:07 | |
| *** julim has joined #openstack-cinder | 13:09 | |
| *** aix has joined #openstack-cinder | 13:10 | |
| nikesh_vedams | i am using this local.conf for setting up devstack in my CI and running tox -e all -- volume | tee -a console.log.out fro cinder volume tests for tgt but around 14 tests are failing | 13:11 |
| *** dustins has joined #openstack-cinder | 13:13 | |
| nikesh_vedams | any idea | 13:13 |
| nikesh_vedams | is any thing missing in local.conf | 13:13 |
| nikesh_vedams | http://paste.openstack.org/show/192628/ | 13:17 |
| *** TobiasE has joined #openstack-cinder | 13:18 | |
| *** TobiasE1 has quit IRC | 13:19 | |
| *** ganso_ has joined #openstack-cinder | 13:21 | |
| *** topshare has joined #openstack-cinder | 13:22 | |
| *** topshare has quit IRC | 13:22 | |
| *** topshare has joined #openstack-cinder | 13:23 | |
| *** IanGovett has quit IRC | 13:24 | |
| openstackgerrit | abhiram moturi proposed openstack/cinder: Enhance unit tests for zfssa drivers https://review.openstack.org/152676 | 13:25 |
| *** timcl has quit IRC | 13:25 | |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: Fix missing translations for log messages https://review.openstack.org/164692 | 13:27 |
| *** sandywalsh has joined #openstack-cinder | 13:31 | |
| *** IanGovett has joined #openstack-cinder | 13:32 | |
| *** scottda has joined #openstack-cinder | 13:34 | |
| *** shyama has quit IRC | 13:36 | |
| *** scottda has quit IRC | 13:36 | |
| *** jungleboyj_ has quit IRC | 13:37 | |
| *** mriedem has joined #openstack-cinder | 13:37 | |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: Fix missing translations for log messages https://review.openstack.org/164697 | 13:37 |
| *** anuragpalsule has quit IRC | 13:38 | |
| *** timcl has joined #openstack-cinder | 13:41 | |
| *** scottda has joined #openstack-cinder | 13:42 | |
| openstackgerrit | Ankit Agrawal proposed openstack/cinder: Fix missing translations for log messages https://review.openstack.org/164702 | 13:50 |
| *** lpabon has joined #openstack-cinder | 13:50 | |
| *** scottda has quit IRC | 13:52 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 13:54 | |
| *** takedakn has quit IRC | 14:09 | |
| *** asselin_ has joined #openstack-cinder | 14:15 | |
| *** rakesh_mishra_ has quit IRC | 14:15 | |
| *** jecarey has joined #openstack-cinder | 14:21 | |
| *** bkopilov has quit IRC | 14:22 | |
| *** mwichmann has joined #openstack-cinder | 14:22 | |
| *** abehl has quit IRC | 14:22 | |
| *** topshare has quit IRC | 14:24 | |
| *** jungleboyj_ has joined #openstack-cinder | 14:24 | |
| *** BharatK has quit IRC | 14:26 | |
| *** thangp has joined #openstack-cinder | 14:26 | |
| *** jungleboyj_ is now known as jungleboyj | 14:26 | |
| *** Mandell has joined #openstack-cinder | 14:28 | |
| *** scottda has joined #openstack-cinder | 14:32 | |
| *** bkopilov has joined #openstack-cinder | 14:33 | |
| *** scottda has quit IRC | 14:35 | |
| *** [1]Thelo has joined #openstack-cinder | 14:37 | |
| *** Yogi11 has joined #openstack-cinder | 14:39 | |
| *** Thelo has quit IRC | 14:39 | |
| *** [1]Thelo is now known as Thelo | 14:39 | |
| *** Yogi1 has quit IRC | 14:42 | |
| *** rakesh_mishra_ has joined #openstack-cinder | 14:43 | |
| *** hemnafk is now known as hemna | 14:49 | |
| *** Maike has quit IRC | 14:50 | |
| *** nshaikh has quit IRC | 14:58 | |
| *** patrickeast has joined #openstack-cinder | 15:01 | |
| *** rushiagr is now known as rushiagr_away | 15:02 | |
| *** Maike has joined #openstack-cinder | 15:03 | |
| *** Maike has quit IRC | 15:03 | |
| *** Maike has joined #openstack-cinder | 15:04 | |
| hemna | winston-d_zZZ, ping | 15:10 |
| *** topshare has joined #openstack-cinder | 15:11 | |
| *** david-lyle_afk is now known as david-lyle | 15:15 | |
| *** topshare has quit IRC | 15:16 | |
| *** scottda has joined #openstack-cinder | 15:16 | |
| *** scottda has quit IRC | 15:17 | |
| *** porrua has quit IRC | 15:17 | |
| *** dannywilson has joined #openstack-cinder | 15:18 | |
| *** anuragpalsule has joined #openstack-cinder | 15:20 | |
| *** anuragpalsule has quit IRC | 15:20 | |
| *** anuragpalsule has joined #openstack-cinder | 15:21 | |
| *** rmesta has joined #openstack-cinder | 15:21 | |
| *** tsekiyama has joined #openstack-cinder | 15:22 | |
| *** rushiagr_away is now known as rushiagr | 15:30 | |
| *** _cjones_ has joined #openstack-cinder | 15:31 | |
| *** rmesta has left #openstack-cinder | 15:33 | |
| *** scottda has joined #openstack-cinder | 15:33 | |
| *** scottda has quit IRC | 15:35 | |
| *** Longgeek_ has quit IRC | 15:36 | |
| *** Yogi11 has quit IRC | 15:37 | |
| *** Mandell has quit IRC | 15:38 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Remove unused file locks on c-vol service startup https://review.openstack.org/164745 | 15:40 |
| *** Yogi1 has joined #openstack-cinder | 15:42 | |
| Swanson | Are the 9 million "Can not find policy directory: policy.d" littering the c-api log any kind of problem? | 15:42 |
| DuncanT | Swanson: A problem? Not unless you've got policy in a policy.d directory you're expecting to get used. It is a bug in the packaging though - whatever install c-api should create an empty policy.d directory | 15:44 |
| hemna | Swanson, It would be a problem if it were 10million. 9million is fine. | 15:44 |
| hemna | DuncanT, if you have a minute, can you go over https://review.openstack.org/#/c/163554/ again for me ? | 15:45 |
| hemna | I'd like to get that one over with | 15:45 |
| Swanson | Thanks! Just noticed a lot of those messages. | 15:45 |
| DuncanT | hemna: Sure | 15:47 |
| openstackgerrit | Ronen Mesonzhnik proposed openstack/cinder: Provide backup service that uses ProtecTIER as the backend https://review.openstack.org/153969 | 15:47 |
| *** _cjones_ has quit IRC | 15:48 | |
| kaisers | jgriffith: Hi! Is it ok for you to follow up now regarding the ci issue 3rdparty meeting ? | 15:49 |
| *** rushiagr is now known as rushiagr_away | 15:53 | |
| Swanson | Every time I try to create an 11th volume I get this error "ERROR: Request Entity Too Large (HTTP 413) (Request-ID: req-a333fd96-c58e-42f8-9733-7f981d1edaf8)" | 15:53 |
| Swanson | I presume this isn't a quota thing as I've upped my quota. | 15:53 |
| jgriffith | kaisers: sure | 15:54 |
| jgriffith | kaisers: sorry I didn't catc exactly what you're running in to | 15:54 |
| jgriffith | catch | 15:54 |
| kaisers | kaisers: np | 15:56 |
| *** harlowja_at_home has joined #openstack-cinder | 15:56 | |
| jgriffith | kaisers: gimmie the run down and maybe I can help :) | 15:56 |
| kaisers | Basically some of the feedbacks to gerrit do not turn up in the gerrit ui | 15:56 |
| jgriffith | kaisers: ahh | 15:56 |
| jgriffith | kaisers: failing issues? | 15:56 |
| kaisers | jgriffith: yep | 15:56 |
| jgriffith | kaisers: yeah... when's the last pull you made from the repo? | 15:57 |
| kaisers | most stuff still fails :-( | 15:57 |
| kaisers | jgriffith: friday? | 15:57 |
| jgriffith | kaisers: so up until the new year I didn't report failures | 15:57 |
| kaisers | jgriffith: i think | 15:57 |
| jgriffith | kaisers: oh LOL | 15:57 |
| jgriffith | well then that's different | 15:57 |
| jgriffith | :) | 15:57 |
| kaisers | jgriffith: :) | 15:57 |
| jgriffith | kaisers: some show, and some don't? That's odd | 15:57 |
| kaisers | jgriffith: i forked some weeks ago and did fiddle a bit with it | 15:57 |
| *** kfox1111 has joined #openstack-cinder | 15:57 | |
| jgriffith | kaisers: do you have the branch you're using in github somewhere? | 15:58 |
| kaisers | jgriffith: the casusbelli fork is mine | 15:58 |
| *** anuragpalsule has quit IRC | 15:59 | |
| jgriffith | kaisers: link? | 15:59 |
| kaisers | jgriffith: but i didn't do too many changes, primarily added logging config by variables | 15:59 |
| *** BharatK has joined #openstack-cinder | 15:59 | |
| kaisers | jgriffith: oh, sorry | 15:59 |
| jgriffith | :) | 15:59 |
| kaisers | jgriffith: #link https://github.com/casusbelli/sos-ci | 16:00 |
| jgriffith | sure there's a way to find it but i'm not that smart :) | 16:00 |
| *** rakesh_mishra_ has quit IRC | 16:00 | |
| kaisers | jgriffith: sry, page is open most of the time in me browser and never thought it might be different for the rest of the world. :) | 16:00 |
| jgriffith | kaisers: haha.. I do that all the time | 16:01 |
| *** nkrinner has quit IRC | 16:01 | |
| *** gary-smith_ has quit IRC | 16:01 | |
| kaisers | jgriffith: Most of my adaptions are done at installation time by different ansible scripts that install sos-ci with my configuration settings on our ci server | 16:01 |
| *** gary-smith_ has joined #openstack-cinder | 16:01 | |
| *** nlevinki has quit IRC | 16:02 | |
| *** rushiagr_away is now known as rushiagr | 16:02 | |
| *** gary-smith_ has quit IRC | 16:03 | |
| *** gary-smith_ has joined #openstack-cinder | 16:04 | |
| jgriffith | kaisers: checkout your subject forming: ie around line 85 | 16:04 |
| nikesh_vedams | jgriffith: after switching to kvm,now performance is very good of SOSCI,but tempest tests were failing so i tried with tgt but tempest is failing onn tgt also,using this http://paste.openstack.org/show/192628/ for local.conf | 16:04 |
| kaisers | jgriffith: ok | 16:05 |
| jgriffith | kaisers: actually that all looks pretty good | 16:05 |
| smcgindia | nikesh_vedams: Publishing your logs might make it easier to see what's going on. | 16:06 |
| kaisers | jgriffith: did not touch much, only added the failure subject line | 16:06 |
| jgriffith | kaisers: so here's what I have done in the past: | 16:06 |
| kaisers | jgriffith: not added but adopted to your variable based subject setting | 16:06 |
| jgriffith | kaisers: add a logger in there that dumps the same data to a local log file | 16:06 |
| jgriffith | then go through and see if you can find the missing pieces and why | 16:06 |
| jgriffith | also add a check to that send notification | 16:06 |
| jgriffith | see what falls out | 16:06 |
| jgriffith | I haven't had issues with that myself, but who know | 16:07 |
| kaisers | jgriffith: ok. Did you see the paste link in the meeting chat? | 16:07 |
| nikesh_vedams | smcgindia :http://115.119.152.41/vedams-ci-logs/refs-changes-93-164093-2/console.log.out | 16:07 |
| *** Maike has quit IRC | 16:07 | |
| nikesh_vedams | smcgindia : did you move to india ,earlier you irc name was smcginnis right :) | 16:08 |
| kaisers | jgriffith: i just want to add: From the log ouput that string looks ok. Maybe you see something ? | 16:08 |
| kaisers | jgriffith: i mean only the output at line 7 or 12 in http://paste.openstack.org/show/192655/ | 16:08 |
| *** rmesta has joined #openstack-cinder | 16:09 | |
| kaisers | jgriffith: that pretty much contains the data posted. | 16:09 |
| smcgindia | nikesh_vedams: In India for the week, so decided to change it for now. About ready to get some sleep. :) | 16:09 |
| kaisers | jgriffith: i'll see into reading std.err/out to see if that returns something... | 16:09 |
| smcgindia | nikesh_vedams: It looks like you are getting LVM errors. | 16:09 |
| *** scottda has joined #openstack-cinder | 16:10 | |
| smcgindia | nikesh_vedams: Search for "Traceback" here: http://115.119.152.41/vedams-ci-logs/refs-changes-93-164093-2/logs/screen-c-vol.log.txt | 16:10 |
| nikesh_vedams | smcgindia:which city? | 16:10 |
| smcgindia | nikesh_vedams: Search for "Details" in your console.log.out. They are timing out. | 16:10 |
| *** dulek has quit IRC | 16:11 | |
| smcgindia | nikesh_vedams: In Bangalore. | 16:11 |
| nikesh_vedams | smcgindia: i m in hyderabad | 16:11 |
| nikesh_vedams | ok | 16:11 |
| smcgindia | nikesh_vedams: Ah, wouldn't mind visiting there some day. I've only seen BLR. | 16:11 |
| *** openstackgerrit has quit IRC | 16:11 | |
| smcgindia | nikesh_vedams: From the Detail output of the failed tests you can get the associated volumes. | 16:12 |
| *** openstackgerrit has joined #openstack-cinder | 16:12 | |
| smcgindia | nikesh_vedams: You can then use that ID to search in your c-vol.log. | 16:12 |
| *** scottda has quit IRC | 16:12 | |
| smcgindia | nikesh_vedams: You can trace through there and see what operations were being performed. | 16:12 |
| smcgindia | nikesh_vedams: You can also get the request ID "req-xxxxxx" and search on that to get all log messages within the current operation. | 16:13 |
| *** rmesta has left #openstack-cinder | 16:13 | |
| smcgindia | nikesh_vedams: Maybe not all LVMs fault. Would this be related to your work: | 16:13 |
| smcgindia | nikesh_vedams: ISCSITargetRemoveFailed: Failed to remove iscsi target for volume | 16:13 |
| smcgindia | nikesh_vedams: File "/opt/stack/cinder/cinder/volume/targets/scst.py", line 362, in remove_iscsi_target | 16:14 |
| *** Ilja has quit IRC | 16:14 | |
| nikesh_vedams | smcgindia:ok but is local.conf good | 16:15 |
| smcgindia | nikesh_vedams: As far as I can tell. You would probably have bigger issues if not. Maybe. | 16:15 |
| nikesh_vedams | smcgindia: because tgt setup is also failing | 16:16 |
| nikesh_vedams | ok | 16:16 |
| *** aix has quit IRC | 16:16 | |
| smcgindia | nikesh_vedams: Are the resulting conf files (cinder.conf, etc) as you would expect for your setup? | 16:16 |
| *** patrickeast has quit IRC | 16:17 | |
| nikesh_vedams | yes | 16:17 |
| *** btran has joined #openstack-cinder | 16:17 | |
| *** nlevinki has joined #openstack-cinder | 16:18 | |
| smcgindia | nikesh_vedams: Sorry, I don't have any experience with that part of things. | 16:18 |
| nikesh_vedams | np | 16:19 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Switch get_all_snapshots to use objects https://review.openstack.org/161077 | 16:25 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Create unit tests for volume objects https://review.openstack.org/164764 | 16:25 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Create unit tests for volume objects https://review.openstack.org/164764 | 16:27 |
| *** TobiasE has quit IRC | 16:27 | |
| *** markstur has quit IRC | 16:28 | |
| *** nellysmitt has quit IRC | 16:30 | |
| *** dflorea has joined #openstack-cinder | 16:30 | |
| *** anuragpalsule has joined #openstack-cinder | 16:31 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Switch to oslo_versionedobjects https://review.openstack.org/160209 | 16:36 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Raise exception for invalid mock assert calls https://review.openstack.org/160208 | 16:36 |
| *** sandywalsh has quit IRC | 16:36 | |
| *** Adriano_ has joined #openstack-cinder | 16:39 | |
| *** Apoorva has joined #openstack-cinder | 16:40 | |
| *** scottda has joined #openstack-cinder | 16:40 | |
| *** scottda has quit IRC | 16:42 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Switch to oslo_versionedobjects https://review.openstack.org/160209 | 16:44 |
| *** nlevinki has quit IRC | 16:45 | |
| *** markus_z has quit IRC | 16:52 | |
| *** Yogi11 has joined #openstack-cinder | 16:54 | |
| *** openstackgerrit has quit IRC | 16:54 | |
| *** ronis has quit IRC | 16:54 | |
| *** openstackgerrit has joined #openstack-cinder | 16:55 | |
| *** Yogi1 has quit IRC | 16:55 | |
| *** leeantho has joined #openstack-cinder | 16:57 | |
| *** vilobhmm has joined #openstack-cinder | 16:58 | |
| *** nellysmitt has joined #openstack-cinder | 16:58 | |
| *** mtanino has joined #openstack-cinder | 16:59 | |
| *** harlowja_at_home has quit IRC | 17:00 | |
| *** annashen has joined #openstack-cinder | 17:00 | |
| *** anuragpalsule has quit IRC | 17:05 | |
| *** thingee has joined #openstack-cinder | 17:05 | |
| marcusvrn1 | asselin: hi | 17:08 |
| asselin | marcusvrn1, hi | 17:09 |
| marcusvrn1 | asselin: if you have some free time, could you review my change(https://review.openstack.org/#/c/161837)? it's about the snapshot bug fix that was impacting my CI...and I would like to put all snapshots tests back again as soon as possible, because more changes to conclude the migration to snapshots object are coming and if the tests are excluded, I will not know if some change will break my driver. | 17:14 |
| *** patrickeast has joined #openstack-cinder | 17:15 | |
| *** cbader has joined #openstack-cinder | 17:16 | |
| *** cbader02 has joined #openstack-cinder | 17:16 | |
| thingee | marcusvrn1: happy to see the ci reporting, good work to your team :) | 17:16 |
| asselin | marcusvrn1, looking | 17:17 |
| marcusvrn1 | thingee: thanks! :) | 17:18 |
| marcusvrn1 | asselin: thanks too | 17:18 |
| *** erlon has joined #openstack-cinder | 17:19 | |
| *** markstur has joined #openstack-cinder | 17:19 | |
| *** cbader02 has quit IRC | 17:21 | |
| *** Mandell has joined #openstack-cinder | 17:24 | |
| asselin | marcusvrn1, nice work on the ci system | 17:25 |
| *** timcl has quit IRC | 17:25 | |
| *** BharatK has quit IRC | 17:26 | |
| *** BharatK has joined #openstack-cinder | 17:26 | |
| *** harlowja has joined #openstack-cinder | 17:28 | |
| patrickeast | thingee: speaking of ci’s… just a quick update on the Pure Storage CI system, we’ve had it offline for the last week or so while moving things around in our lab (adding more physical machines to it, better networking, etc) | 17:28 |
| *** timcl has joined #openstack-cinder | 17:29 | |
| patrickeast | thingee: it should be back up by the 19th, but it something happens, hypothetically, what happens? | 17:29 |
| patrickeast | s/it/if/ | 17:29 |
| marcusvrn1 | asselin: thanks! do you know who can give approval to this change? maybe thingee? | 17:30 |
| asselin | thingee, hemna jgriffith are cores: https://review.openstack.org/#/c/161837 | 17:31 |
| marcusvrn1 | asselin: It's really hard to keep CI working... hehehe | 17:31 |
| marcusvrn1 | jgriffith: thanks | 17:32 |
| jgriffith | marcusvrn1: sure | 17:32 |
| asselin | yes it is...lots of interesting things come up | 17:33 |
| *** BharatK has quit IRC | 17:35 | |
| thingee | patrickeast: we'll visit it on the 19th, just keep me updated | 17:35 |
| thingee | jgriffith: hitting this issue on my ci https://bugs.launchpad.net/nova/+bug/1432490 | 17:36 |
| openstack | Launchpad bug 1432490 in tempest "TestEncryptedCinderVolumes cryptsetup name is too long" [Undecided,New] | 17:36 |
| thingee | jgriffith: not really sure who to blame :) | 17:36 |
| *** rushiagr is now known as rushiagr_away | 17:36 | |
| thingee | jgriffith: I'm having an internal change be made to not pass the volume name in the iqn as a work around, but annoying | 17:36 |
| jgriffith | thingee: yeah, I was reading that. So that's specific to your system not accepting the longer name though | 17:36 |
| jgriffith | thingee: right? | 17:36 |
| thingee | jgriffith: no cryptsetup says it' | 17:37 |
| thingee | s too long | 17:37 |
| thingee | Datera is passing the volume name in the iqn | 17:37 |
| jgriffith | hmm... why isn't anybody else hitting it? | 17:37 |
| thingee | which is causing it to be too long imo | 17:37 |
| jgriffith | thingee: hmm... lemme look | 17:38 |
| thingee | jgriffith: http://paste.openstack.org/show/192537/ | 17:38 |
| *** rushil has joined #openstack-cinder | 17:38 | |
| thingee | in case you missed the stack trace | 17:38 |
| thingee | mtreinish: https://bugs.launchpad.net/nova/+bug/1432490 | 17:38 |
| openstack | Launchpad bug 1432490 in tempest "TestEncryptedCinderVolumes cryptsetup name is too long" [Undecided,New] | 17:38 |
| jgriffith | thingee: I see the stack trace | 17:38 |
| jgriffith | thingee: not finding it in other CI setups though | 17:39 |
| jgriffith | at least not yet | 17:39 |
| thingee | mtreinish: I think this might just be something that needs to be worked out in my backend and or cryptsetup. | 17:39 |
| thingee | jgriffith: yeah, pretty sure not passing the volume name in would help | 17:39 |
| mtreinish | thingee: ok, that's what I was thinking too when I looked at the bug | 17:39 |
| thingee | jgriffith: the device name is just too long ip-172.30.128.2:3260-iscsi-iqn.2013-05.com.daterainc:OpenStack-TestEncryptedCinderVolumes-676292884:01:sn:aef6a6f1cd84768f-lun-0 | 17:39 |
| thingee | jgriffith: volume name in this case from tempest being OpenStack-TestEncryptedCinderVolumes-676292884:01 | 17:40 |
| thingee | I think just not adding that to the iqn would fix it | 17:40 |
| thingee | for now | 17:40 |
| DuncanT | Volume names can be up to 255 characters long... | 17:41 |
| jgriffith | thingee: so what I'm saying is the combination of your iqn length etc is what seems to push it over the limit for crypt | 17:41 |
| jgriffith | thingee: http://54.164.167.86/solidfire-ci-logs/refs-changes-45-164745-1/logs/screen-n-cpu.log.txt | 17:41 |
| thingee | jgriffith: yup, I'm saying the same too | 17:41 |
| jgriffith | thingee: also the dsvm-full logs from the gate don't show this trace that I found in ER | 17:41 |
| jgriffith | thingee: ahh... ok :) | 17:41 |
| thingee | jgriffith: how cinder constructs a device + iqn | 17:42 |
| thingee | device name* | 17:42 |
| thingee | ip-<portal>-<iqn>-lun-0 | 17:42 |
| *** angela-s has joined #openstack-cinder | 17:42 | |
| thingee | DuncanT: yeah, but with the way cinder/brick constructs the device name, it ends being longer | 17:42 |
| DuncanT | Do we know how long dmcrypt can take? | 17:43 |
| thingee | mtreinish, jgriffith, DuncanT: so technically, this bug can be triggered with a longer volume name | 17:43 |
| thingee | mtreinish: DuncanT saying the volume name can be 255 chars. | 17:43 |
| thingee | mtreinish: if the backend is passing the volume name in the iqn I guess | 17:44 |
| thingee | forgot about that part | 17:44 |
| jgriffith | thingee: mtreinish DuncanT FWIW, what I'm getting at is there's a bunch of extraneous 'stuff' in the datera iqn prefix | 17:44 |
| *** jordanP has quit IRC | 17:44 | |
| *** afazekas has quit IRC | 17:44 | |
| jgriffith | thingee: mtreinish DuncanT no need for IP address IMO | 17:44 |
| jgriffith | thingee: mtreinish DuncanT also you really shouldn't use Name anyway | 17:45 |
| jgriffith | thingee: mtreinish DuncanT names aren't unique | 17:45 |
| thingee | jgriffith: that's the device name that comes from brick | 17:45 |
| DuncanT | jgriffith: Agreed. We have the id for uniqueness | 17:45 |
| thingee | jgriffith: /dev/disk-by-path/ip-<portal>-<datera-iqn>-lun-0 | 17:45 |
| jgriffith | ummm: iqn.2010-01.com.solidfire:l74j.uuid-ba85f55b-5026-4df3-aece-f5becff21781.5571 | 17:45 |
| thingee | jgriffith: weird, datera iqn is iqn.2013-05.com.daterainc:OpenStack-TestEncryptedCinderVolumes-676292884:01 | 17:46 |
| jgriffith | thingee: oh.. yeah, I see what you're saying | 17:46 |
| jgriffith | ip-192.168.140.9:3260-iscsi-iqn.2010-10.org.openstack:volume-ccfd8535-97b3-4d1c-9a31-12ea1110dd31-lun-1 | 17:46 |
| jgriffith | ^^ LVM | 17:46 |
| *** jungleboyj has quit IRC | 17:46 | |
| thingee | jgriffith, DuncanT: https://github.com/openstack/cinder/blob/master/cinder/brick/initiator/connector.py#L417 | 17:47 |
| jgriffith | thingee: If you want my advice (and you probably don't) I would not use volume-name | 17:47 |
| hemna | sup | 17:47 |
| jgriffith | or the display name at any rate | 17:48 |
| hemna | brick issues ? | 17:48 |
| hemna | or ? | 17:48 |
| jgriffith | use Cinder's unique identifiers | 17:48 |
| hemna | that looks like a target iqn ? | 17:48 |
| thingee | hemna: https://bugs.launchpad.net/nova/+bug/1432490 | 17:48 |
| openstack | Launchpad bug 1432490 in tempest "TestEncryptedCinderVolumes cryptsetup name is too long" [Undecided,New] | 17:48 |
| *** jungleboyj has joined #openstack-cinder | 17:49 | |
| hemna | ah yah, that's the iqn that comes from the driver | 17:49 |
| hemna | brick constructs the /dev/disk/by-path entry to look for it showing up | 17:49 |
| thingee | hemna: not, that's the device name that comes from brick which contains the iqn from the driver | 17:49 |
| hemna | yah, saying the same thing | 17:49 |
| thingee | sort of :) | 17:49 |
| hemna | brick constructs that path string based upon the target portal iqn information coming from the driver | 17:50 |
| thingee | right | 17:50 |
| hemna | as that's what the kernel will dynamically populate in /dev/disk/by-path | 17:50 |
| *** jistr has quit IRC | 17:51 | |
| jgriffith | hemna: thingee DuncanT Added a comment to the bug since the discussion here is just repetitive and confusing to some :) | 17:51 |
| hemna | so cryptsetup hates that long string ? | 17:51 |
| thingee | jgriffith: pretty sure uuid from cinder would reach a limit too | 17:51 |
| thingee | jgriffith: if it was in the iqn | 17:51 |
| jgriffith | thingee: nope | 17:51 |
| jgriffith | thingee: not if you cut that ridiculously long display-name out of it | 17:51 |
| jgriffith | thingee: otherwise everybody would be failing for the same thing | 17:51 |
| jgriffith | thingee: the name 'datera" isn't exactly *long* :) | 17:52 |
| thingee | jgriffith: ah you're right | 17:52 |
| hemna | OpenStack-TestEncryptedCinderVolumes-676292884:01:sn:aef6a6f1cd84768f that's a bit longer than a uuid | 17:52 |
| jgriffith | thingee: it happens once in a while... it's actually that I just get lucky sometimes | 17:52 |
| jgriffith | thingee: which is better than smart :) | 17:52 |
| thingee | hemna: technically it's just OpenStack-TestEncryptedCinderVolumes-676292884 | 17:53 |
| *** BharatK has joined #openstack-cinder | 17:53 | |
| thingee | jgriffith: cool thanks, I'll suggest that internally | 17:53 |
| thingee | I'll just close out the bug for now | 17:53 |
| jgriffith | thingee: if it's not doable shout, we can come up with an algorithm pretty easy to condense that | 17:53 |
| jgriffith | thingee: nahh... you should leave the bug open IMO | 17:53 |
| hemna | so | 17:53 |
| hemna | another way to fix this | 17:54 |
| hemna | is to have cryptsetup use the actual /dev/SDX device | 17:54 |
| jgriffith | hemna: NOOOOOO | 17:54 |
| hemna | which is linked to the /dev/disk/by-path entry | 17:54 |
| thingee | mtreinish: updated the bug | 17:54 |
| jgriffith | hemna: so FWIW there's funny stuff that goes on with the sdx files | 17:54 |
| mtreinish | thingee: cool, thanks | 17:54 |
| hemna | oh? | 17:54 |
| jgriffith | hemna: that I can't convince anybody of | 17:54 |
| hemna | educate me | 17:55 |
| jgriffith | hemna: yeah, like sometimes they "move" or get "remapped" | 17:55 |
| hemna | ah hence the need for /dev/mapper crap | 17:55 |
| jgriffith | right | 17:55 |
| hemna | yah there is that | 17:55 |
| jgriffith | hemna: so it's "ok" to do that sort of thing if everyone/everything is cognisant | 17:56 |
| hemna | but in the case of crypsetup, it's simply initializing the crypto crap on the raw device isn't it? | 17:56 |
| hemna | so if it moves, then it should be still ok? | 17:56 |
| hemna | no idea really, just guessing | 17:56 |
| jgriffith | in theory :) | 17:56 |
| hemna | hehe | 17:56 |
| jgriffith | but when sdx files get unmapped and remapped things sometimes go a bit "wonky" | 17:56 |
| hemna | true | 17:56 |
| *** Apoorva has quit IRC | 17:57 | |
| hemna | totally agree with that | 17:57 |
| jgriffith | besides, why change the structure of how the cryptsetup stuff works when it's a simple fix on the other end? | 17:57 |
| jgriffith | hemna: I dunno, maybe I'm paranoid. Suppose if folks want to go that route it might be fine | 17:57 |
| hemna | I dunno, was just thinking out of the box a bit | 17:57 |
| jgriffith | hemna: yeah... and a month ago I would've said... "cool" | 17:58 |
| hemna | then it doesn't really matter what the iqn pattern is for cinder volumes. | 17:58 |
| jgriffith | hemna: but after looking at the detach/rescue test I'm terrified | 17:58 |
| hemna | but that length might pose issues elsewhere as well | 17:58 |
| *** ronis has joined #openstack-cinder | 17:59 | |
| openstackgerrit | yatin proposed openstack/python-cinderclient: cinder list now prints dash '-' when data is None https://review.openstack.org/159814 | 18:00 |
| *** jdurgin has joined #openstack-cinder | 18:02 | |
| thingee | hemna, jgriffith: so wanted to talk about multi-attach again. I still don't agree with the current workflow and wanted to raise it on the ops ML since I already started initial discussions at the ops meetup, which i raised before things were merged. | 18:02 |
| hemna | I'm not sure what the issue is really | 18:03 |
| hemna | if this is the attachment_id thing | 18:03 |
| jgriffith | thingee: FWIW I did make comments regarding workflow, but I wanted the work to move forward and not get stuck for another release | 18:03 |
| hemna | no one is using cinder to do detaches directly. | 18:03 |
| hemna | nova volume-detach <nova uuid> <cinder uuid> | 18:03 |
| thingee | hemna, jgriffith: I would like to propose following a format that morganfainberg told me about in keystone and that's listing the API as experimental. Meaning use at your own risk. We can make backwards compat changes. | 18:03 |
| hemna | operators shouldn't even care | 18:03 |
| hemna | and don't really. | 18:04 |
| jgriffith | thingee: ? | 18:04 |
| hemna | I don't think that makes sense to me. | 18:04 |
| thingee | hemna: why? | 18:04 |
| thingee | hemna: when you introduce looking for an attachment_id, that's changing the flow | 18:05 |
| hemna | because no one is going to call cinder directly to detach a volume. | 18:05 |
| hemna | it simply won't work. | 18:05 |
| jgriffith | hemna: thingee sorry... can you guys back up a second? | 18:05 |
| hemna | you have to coordinate w/ nova for anything meaningful to happen. | 18:05 |
| thingee | hemna: doesn't matter. we always assume someone is doing something weird with the api | 18:05 |
| jgriffith | hemna: thingee I think the two of you may have knowledge that I don't (like what you're talking about) :) | 18:05 |
| hemna | hehe | 18:05 |
| hemna | operators aren't always right. | 18:06 |
| hemna | :P | 18:06 |
| hemna | this is the most flexible way to ensure the correct attachment is detached. | 18:06 |
| * jgriffith still doesn't actually know what's being discussed so keeping quiet | 18:06 | |
| thingee | jgriffith: hemna please correct me if I'm wrong on any of this, and I really hope I am. So if you have multiple attachments going on, you have to now look up the instance, the volume you want to detach, then look through a list of attachment ids, for one that matches the attachment you want to detach | 18:07 |
| thingee | jgriffith, hemna: then detach with that attachment id | 18:07 |
| hemna | thingee, you already have to lookup the instance you want to detach | 18:07 |
| thingee | jgriffith: hemna mentioned we follow this format because of how vmware does things | 18:07 |
| thingee | hemna: yup | 18:07 |
| hemna | nova volume-detach <instance uuid> <cinder volume> | 18:07 |
| thingee | I think the attachment id thing is not necessary | 18:07 |
| hemna | and if we are just talking about cinder | 18:08 |
| hemna | then you STILL have to know the instance uuid you want to detach | 18:08 |
| hemna | so you aren't gaining anything | 18:08 |
| hemna | the volume has a list of attachments | 18:08 |
| jgriffith | sorry... I'm confused | 18:08 |
| hemna | you can't just say, hey cinder, detach | 18:08 |
| hemna | detach what from what ? | 18:08 |
| hemna | you have to know the instance uuid anyway | 18:08 |
| hemna | the new api makes it clean | 18:08 |
| jgriffith | you don't like "nova volume-detach <instance-uuid> <volume-uuid>"? | 18:08 |
| jgriffith | how else would you do it? | 18:08 |
| hemna | I don't get it. | 18:09 |
| *** rushil_ has joined #openstack-cinder | 18:09 | |
| thingee | jgriffith: I don' | 18:09 |
| thingee | t have a problem with that | 18:09 |
| *** BharatK has quit IRC | 18:09 | |
| thingee | that's not what I'm talking about | 18:09 |
| thingee | this https://review.openstack.org/#/c/85847/47/cinder/api/contrib/admin_actions.py | 18:09 |
| hemna | jgriffith, so in the existing multiattach workflow | 18:10 |
| hemna | to detach a volume | 18:10 |
| hemna | from a specific instance | 18:10 |
| thingee | v1/<uuid>/os-admin-actions/os-force-detach body contains attachment_id | 18:10 |
| hemna | or host | 18:10 |
| hemna | you need to know the attachment id | 18:10 |
| hemna | each attachment for a volume has an attachment id | 18:10 |
| thingee | this is tacked on. You already know the volume because it's in the attachment id | 18:10 |
| jgriffith | hemna: time out | 18:10 |
| jgriffith | let's take one at a time for my sake :) | 18:10 |
| jgriffith | thingee: so having the attachment_id in the force | 18:10 |
| hemna | that id references the specific entry in the volume_attachment table, which can be an instance_uuid or a hostname. | 18:10 |
| jgriffith | thingee: you could easily change that... add an optional instance_id | 18:11 |
| thingee | hemna: but you're passing a useless volume-uuid in the endpoint | 18:11 |
| hemna | so, to detach a volume, you call detach with an optional attachment_id | 18:11 |
| jgriffith | thingee: do the lookup in Cinder | 18:11 |
| thingee | this is just tacked on imo | 18:11 |
| jgriffith | if it's provided use it, else detach everything | 18:11 |
| jgriffith | ok... I'll just let you guys handle it | 18:12 |
| jgriffith | I can't talk about multiple things at once... too confusing | 18:12 |
| kaisers | jgriffith: Solved the sos-ci issue we talked about, wanna know? | 18:12 |
| kaisers | jgriffith: oops | 18:12 |
| kaisers | jgriffith: not now :-D | 18:12 |
| jgriffith | kaisers: for sure! | 18:12 |
| jgriffith | haha | 18:12 |
| kaisers | jgriffith: i'm working with openstack-dev/ci-sandbox project | 18:13 |
| kaisers | jgriffith: but down below in run_tempest.yml sos-ci expects the commit to come from the cinder project afaics | 18:14 |
| thingee | hemna: can you explain to me the workflow for multi-attach how you see it? | 18:14 |
| kaisers | jgriffith: so it fetches the wrong commit id | 18:14 |
| jgriffith | kaisers: Yup! | 18:14 |
| kaisers | jgriffith: will solve now... | 18:14 |
| jgriffith | kaisers: cool... makes sense | 18:14 |
| hemna | thingee, you fetch the volume. it has a list of attachments. find the attachment you want to detach, and call detach with that attachment id. | 18:14 |
| hemna | it's agnostic to hostname or instanceuuid. | 18:15 |
| kaisers | jgriffith: my working replies to gerrit probably came from tests that went wrong and where it did not to that lookup because stuff went bust beforehand... | 18:15 |
| *** Mandell has quit IRC | 18:15 | |
| hemna | if the attachment id isn't passed, cinder tries it's best to comply. | 18:15 |
| kaisers | s/to/do | 18:15 |
| hemna | if there is 1 attachment, cinder will detach. else, it complains that it doesn't know which one you want to detach, since you didn't tell it which one. | 18:15 |
| hemna | simple | 18:15 |
| hemna | :P | 18:15 |
| jgriffith | kaisers: interesting... some day I need to get some good error handling and unit tests in there | 18:16 |
| jgriffith | kaisers: and update the config info... it's painfully out of date | 18:16 |
| kaisers | jgriffith: Anyways, thanks for the hint earlier on! | 18:16 |
| jgriffith | kaisers: honestly I didn't think anybody else would use it :) | 18:16 |
| *** sgotliv has quit IRC | 18:16 | |
| jgriffith | kaisers: but... check out these stats for March: | 18:16 |
| kaisers | jgriffith: Never think things like that | 18:16 |
| kaisers | jgriffith: if it's out there, it is out there!!! | 18:16 |
| *** IanGovett has quit IRC | 18:16 | |
| kaisers | hehe | 18:17 |
| *** rushiagr_away is now known as rushiagr | 18:17 | |
| jgriffith | kaisers: for March. 185/11 | 18:17 |
| *** IanGovett has joined #openstack-cinder | 18:17 | |
| jgriffith | kaisers: that's 185 succesful sos-ci runs, 11 fails | 18:17 |
| jgriffith | kaisers: not bad numbers | 18:17 |
| kaisers | jgriffith: yep | 18:17 |
| *** IanGovett has quit IRC | 18:18 | |
| jgriffith | kaisers: and I don't have to "manage" it so to speak | 18:18 |
| jgriffith | kaisers: or hire somebody to manage it for me | 18:18 |
| jgriffith | :) | 18:18 |
| kaisers | jgriffith: And i did invest quite some time in other approaches but from my perspective they were to complex. That's why i looked into it | 18:18 |
| kaisers | jgriffith: :) | 18:18 |
| jgriffith | kaisers: yeah, that's why I wrote it. Anyway... glad to hear it's useful for ya | 18:19 |
| jgriffith | kaisers: FWIW I gladly accept pull requests :) | 18:19 |
| kaisers | jgriffith: yep, thanks & read you later | 18:19 |
| jgriffith | kaisers: have a good one! | 18:19 |
| kaisers | jgriffith: i just removed some i made weeks ago | 18:19 |
| kaisers | jgriffith: yeah, one should be up, right | 18:19 |
| *** paul-- has quit IRC | 18:20 | |
| kaisers | might cherry pick one or two others, have to see if i can disentangle them from my stuff | 18:20 |
| kaisers | jgriffith: nope, nonsense, currently there is none up from me, sry | 18:20 |
| jgriffith | :) | 18:20 |
| jgriffith | no worries | 18:20 |
| kaisers | ok, I'll let loose the beast on cinder now | 18:21 |
| *** Mandell has joined #openstack-cinder | 18:21 | |
| kaisers | jgriffith: for testing :) | 18:21 |
| *** jungleboyj has quit IRC | 18:21 | |
| *** jungleboyj has joined #openstack-cinder | 18:22 | |
| *** BharatK has joined #openstack-cinder | 18:23 | |
| *** dflorea has quit IRC | 18:24 | |
| *** dflorea has joined #openstack-cinder | 18:25 | |
| *** jecarey has quit IRC | 18:25 | |
| *** dflorea has quit IRC | 18:27 | |
| *** dflorea has joined #openstack-cinder | 18:27 | |
| openstackgerrit | Tomoki Sekiyama proposed openstack/python-cinderclient: Implement reset-state for attach_status and migration_status https://review.openstack.org/164309 | 18:28 |
| mtanino | jungleboyj: ping, | 18:28 |
| *** paul-- has joined #openstack-cinder | 18:29 | |
| *** timcl1 has joined #openstack-cinder | 18:29 | |
| *** timcl has quit IRC | 18:30 | |
| mtanino | jungleboyj: Can we push this ( https://review.openstack.org/#/c/161328/ ) to juno/stable? we need one more +2 from someone? | 18:30 |
| *** Yogi11 has quit IRC | 18:30 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Complete switch to snapshot objects https://review.openstack.org/163910 | 18:32 |
| *** dflorea has quit IRC | 18:32 | |
| *** IanGovett has joined #openstack-cinder | 18:32 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Complete switch to snapshot objects https://review.openstack.org/163910 | 18:33 |
| *** Maike has joined #openstack-cinder | 18:34 | |
| *** Mandell has quit IRC | 18:34 | |
| *** Yogi1 has joined #openstack-cinder | 18:35 | |
| *** timcl1 has quit IRC | 18:35 | |
| thingee | hemna: so you pass the attachment_id to nova volume-detach? | 18:36 |
| *** timcl has joined #openstack-cinder | 18:36 | |
| *** jungleboyj has quit IRC | 18:38 | |
| *** jungleboyj has joined #openstack-cinder | 18:39 | |
| *** emagana has joined #openstack-cinder | 18:41 | |
| hemna | nikesh_vedams, when you migrate a volume, it potentially turns into a retype | 18:43 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder: Make unused iscsi_num_targets, iser_num_targets configs as deprecated https://review.openstack.org/161036 | 18:44 |
| *** annashen has quit IRC | 18:44 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/python-cinderclient: Update to change name for volume type client https://review.openstack.org/141187 | 18:45 |
| *** annashen has joined #openstack-cinder | 18:45 | |
| *** annashen has quit IRC | 18:55 | |
| *** afazekas has joined #openstack-cinder | 18:57 | |
| *** Apoorva has joined #openstack-cinder | 18:57 | |
| *** annashen has joined #openstack-cinder | 18:58 | |
| nikesh_vedams | hemna:hmm bit confuse with these two sentences "DuncanT -> Migrate - move between backends of the same volume type" and "when you migrate a volume, it potentially turns into a retype" :) | 18:59 |
| thingee | hemna: so you pass the attachment_id to nova volume-detach? | 19:01 |
| hemna | thingee, no | 19:01 |
| hemna | nova volume-detach <instance uuid> <volume uuid> | 19:01 |
| hemna | nova does the rest. | 19:01 |
| kmartin | nikesh_vedams, I can help you, what do you not understand? | 19:01 |
| thingee | hemna: ok good | 19:01 |
| hemna | thingee, part of the nova work is to have nova get the attachment_id from the attachments in the volume and pass the right attachment_id along. | 19:02 |
| *** Apoorva has quit IRC | 19:02 | |
| Swanson | So I up quota to 100 volumes. I create 10 volumes just fine. The 11 fails with a Quota exceeded (10 volumes already consumed) in c-api. | 19:03 |
| Swanson | Bug or is there something else I need to do to get the quota over 10? | 19:03 |
| hemna | thingee, also, if the attachment_id isn't passed, cinder tries to detach. if there is only 1 attachment, it will detach. | 19:05 |
| hemna | if there are more than 1, it balks. | 19:05 |
| hemna | thingee, jgriffith suggested at one point, we could have it simply untattach all, if no attachment_id is passed. | 19:05 |
| hemna | thingee, for now I opted to be 'safe', and not do that. | 19:06 |
| hemna | we can revisit in L if you like. | 19:06 |
| *** BharatK has quit IRC | 19:07 | |
| jgriffith | hemna: ahh... yeah, I noted that in the comments at one point | 19:07 |
| jgriffith | hemna: honestly I also think that getting the code merged at this point was more important | 19:07 |
| jgriffith | hemna: I'd rather adjust some details later if possible | 19:07 |
| jgriffith | hemna: don't want to block this "again" | 19:07 |
| jgriffith | just don't let anybody implement it yet, and since it's not in Nova that shouldn't be a problem | 19:08 |
| *** lpetrut has quit IRC | 19:08 | |
| jgriffith | IMHO | 19:08 |
| jgriffith | lunch... bbl | 19:09 |
| thingee | jgriffith: so that was the point of marking it as expermenital now. If we decide later we want to change something about the API, there was a note in the doc string and release notes about it being experimental | 19:09 |
| hemna | jgriffith, +1 and the scheduler check is in as well. unless a driver reports multiattach: true as a capability, the scheduler will puke on create 'no host found'. | 19:09 |
| thingee | jgriffith: it's what keystone folks are doing now for new APIs | 19:09 |
| jgriffith | thingee: sure, but really it's irrelevant for the most part I think since it can't be used anyway | 19:09 |
| jgriffith | thingee: cool | 19:09 |
| thingee | jgriffith: I always assume folks will use things. | 19:09 |
| thingee | jgriffith: even if I don't mean them to | 19:10 |
| jgriffith | thingee: fair | 19:10 |
| hemna | thingee, how do you mark the API as experimental ? | 19:10 |
| thingee | hemna: morganfainberg just told me in the doc string of the code itself, release notes and any api ref doc on it (which we won't have yet) | 19:10 |
| morganfainberg | thingee, we aslo include hints in our JSON Home doc | 19:11 |
| *** annashen has quit IRC | 19:11 | |
| thingee | json home doc? | 19:11 |
| *** annashen has joined #openstack-cinder | 19:11 | |
| morganfainberg | if you do a get on the keystone root / you can get json home doc outlineing our APIs | 19:11 |
| thingee | morganfainberg: nice | 19:12 |
| hemna | thingee, url ? | 19:12 |
| hemna | I can add a comment block about it as a follow up patch if you like, if that's all it is. | 19:12 |
| thingee | hemna: url to what? | 19:13 |
| thingee | an example? | 19:13 |
| hemna | thingee, yes please | 19:13 |
| thingee | morganfainberg: got an example? | 19:13 |
| thingee | for hemna | 19:13 |
| *** afazekas has quit IRC | 19:13 | |
| morganfainberg | https://review.openstack.org/#/c/160032/ | 19:14 |
| *** vilobhmm has quit IRC | 19:14 | |
| *** vilobhmm has joined #openstack-cinder | 19:15 | |
| hemna | morganfainberg, the json_home.py | 19:15 |
| hemna | not sure how that translates to cinder's contrib code | 19:15 |
| morganfainberg | hemna, hm. let me find an example | 19:15 |
| hemna | cinder's detach isn't experimental | 19:16 |
| hemna | but passing in the attachment_id is. :P | 19:16 |
| hemna | so..... | 19:16 |
| hemna | thingee, what would you like me to do ? | 19:16 |
| morganfainberg | right. so i'd just mark in documentation and code as such. | 19:16 |
| hemna | just comment in the code/ | 19:16 |
| hemna | ? | 19:16 |
| morganfainberg | doesn't map to a whole API. | 19:16 |
| *** leeantho has quit IRC | 19:21 | |
| *** afazekas has joined #openstack-cinder | 19:21 | |
| *** HoloIRCUser has joined #openstack-cinder | 19:21 | |
| *** HoloIRCUser has quit IRC | 19:21 | |
| thingee | hemna: as morganfainberg mentioned, I'm fine with the doc just mentioning the attachment_id piece for multi-attach. | 19:22 |
| thingee | hemna: I can do the same for release notes later if you agree. | 19:22 |
| thingee | hemna: do we still have time to do the brick cut? | 19:22 |
| hemna | ! | 19:22 |
| thingee | hemna: things are less hectic for me to help with that now | 19:22 |
| thingee | :) | 19:22 |
| hemna | at this point, it would be pushing it. | 19:23 |
| hemna | we need brick to get a release to pypi | 19:23 |
| thingee | yea | 19:23 |
| hemna | then global requirements change | 19:23 |
| hemna | then my cinder patch taken off of -2 and WIP | 19:23 |
| hemna | lots of moving parts | 19:23 |
| hemna | fwiw, there are no outstanding os-brick patches | 19:24 |
| thingee | jgriffith: on sos-ci, I worked on a thing that uses pushover notifications to do push notifications to ios/android. Pretty small change, not sure if you're interested in introducing every use case in the project, but thought I would ask before I did a PR. | 19:25 |
| hemna | is there a way to filter all cinder patches to see if anyone is touching cinder/brick/* ? | 19:25 |
| *** annashen has quit IRC | 19:25 | |
| hemna | lunch.... | 19:26 |
| *** crose has joined #openstack-cinder | 19:26 | |
| thingee | hemna: in gerrit you can do search for file:^Regex | 19:27 |
| thingee | hemna: https://review.openstack.org/Documentation/user-search.html | 19:27 |
| *** annashen has joined #openstack-cinder | 19:28 | |
| tsekiyama | hemna: project:openstack/cinder file:^cinder/brick/.* status:open | 19:28 |
| thingee | tsekiyama: :) | 19:28 |
| *** timcl1 has joined #openstack-cinder | 19:29 | |
| *** bswartz has quit IRC | 19:30 | |
| *** afazekas has quit IRC | 19:30 | |
| *** annashen has quit IRC | 19:31 | |
| *** timcl has quit IRC | 19:32 | |
| *** annashen has joined #openstack-cinder | 19:32 | |
| *** dflorea has joined #openstack-cinder | 19:32 | |
| *** crose has quit IRC | 19:34 | |
| *** annashen has quit IRC | 19:37 | |
| *** annashen has joined #openstack-cinder | 19:37 | |
| *** dflorea has quit IRC | 19:37 | |
| *** mriedem has quit IRC | 19:39 | |
| *** rushiagr is now known as rushiagr_away | 19:42 | |
| *** enterprisedc has quit IRC | 19:42 | |
| thingee | bbl lunch | 19:43 |
| *** leeantho has joined #openstack-cinder | 19:43 | |
| *** mriedem has joined #openstack-cinder | 19:47 | |
| *** alexpilotti has quit IRC | 19:50 | |
| *** Apoorva has joined #openstack-cinder | 19:50 | |
| *** Mandell has joined #openstack-cinder | 19:51 | |
| *** sgotliv has joined #openstack-cinder | 19:52 | |
| *** xyang1 has joined #openstack-cinder | 19:53 | |
| *** xyang has joined #openstack-cinder | 19:54 | |
| *** nellysmitt has quit IRC | 19:54 | |
| *** afazekas has joined #openstack-cinder | 19:57 | |
| *** r-daneel has joined #openstack-cinder | 19:58 | |
| jbernard | thangp: heya | 20:00 |
| jbernard | thangp: i believe you're working on cinder objects, no? | 20:01 |
| thangp | jbernard: yup | 20:01 |
| jbernard | thangp: im getting a strange import error maybe you can explain | 20:01 |
| thangp | sure | 20:01 |
| jbernard | thangp: http://sprunge.us/eQGT | 20:02 |
| jbernard | thangp: from brick/initiator/connector im attempting to import a volume driver | 20:03 |
| thangp | jbernard: it's probably coming from https://github.com/openstack/cinder/blob/master/cinder/cmd/volume.py#L59 | 20:04 |
| thangp | jbernard: 1 sec | 20:05 |
| jbernard | thangp: i see this when starting cinder-volume | 20:05 |
| jbernard | thangp: sure | 20:05 |
| thangp | jbernard: ah ok...the traceback is coming from the object serializer | 20:06 |
| *** dflorea has joined #openstack-cinder | 20:06 | |
| *** rushiagr_away is now known as rushiagr | 20:07 | |
| thangp | jbernard: what is the value of CONF.volume_api_class? | 20:07 |
| jbernard | thangp: at which point? | 20:08 |
| thangp | File "/vagrant/cinder/cinder/volume/__init__.py", line 27, in <module> | 20:08 |
| thangp | API = importutils.import_class(CONF.volume_api_class) | 20:08 |
| jbernard | thangp: ahh, one sec | 20:08 |
| thangp | i'm just trying to trace back | 20:08 |
| jbernard | (Pdb) print CONF.volume_api_class | 20:09 |
| jbernard | cinder.volume.api.API | 20:10 |
| *** sgotliv has quit IRC | 20:10 | |
| thangp | jbernard: did you make any changes to cinder/brick/initiator/connector.py? | 20:10 |
| jbernard | a few ;) | 20:10 |
| jbernard | which all seem to be okay, except the imports | 20:11 |
| thangp | jbernard: could you share, at least the imports | 20:11 |
| jbernard | so 'from cinder.volume.drivers.rbd import RBDDriver' | 20:11 |
| jbernard | that is when i begin to see this traceback | 20:11 |
| thangp | jbernard: that's it? hmm... | 20:11 |
| jbernard | thangp: i can paste the entire diff if you need | 20:12 |
| jbernard | thangp: or the whole patchset, let me know what you need | 20:12 |
| thangp | let me look in inder.volume.drivers.rbd | 20:12 |
| thangp | jbernard: sure | 20:12 |
| hemna | thingee, tsekiyama thank you | 20:12 |
| jbernard | thangp: could a circular import cause such a thing? | 20:13 |
| thangp | jbernard: maybe, but i'm not sure where | 20:14 |
| thangp | jbernard: cinder/volume/api.py isnt doing anything special with base | 20:14 |
| *** sgotliv has joined #openstack-cinder | 20:14 | |
| *** afazekas has quit IRC | 20:15 | |
| *** ndipanov has quit IRC | 20:16 | |
| *** afazekas has joined #openstack-cinder | 20:16 | |
| *** lpabon has quit IRC | 20:16 | |
| *** alexpilotti has joined #openstack-cinder | 20:19 | |
| *** timcl1 has quit IRC | 20:19 | |
| *** jungleboyj has quit IRC | 20:21 | |
| *** rushil__ has joined #openstack-cinder | 20:21 | |
| *** timcl has joined #openstack-cinder | 20:22 | |
| *** jungleboyj has joined #openstack-cinder | 20:22 | |
| *** afazekas has quit IRC | 20:23 | |
| *** rushil has quit IRC | 20:23 | |
| thangp | jbernard: try removing the import - from cinder.objects import base as objects_base and instead of using objects_base, using objects.base in cinder/cinder/volume/api.py | 20:24 |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Fail immediately for images in a container https://review.openstack.org/163170 | 20:25 |
| *** lpetrut has joined #openstack-cinder | 20:25 | |
| *** timcl has quit IRC | 20:26 | |
| *** jungleboyj has quit IRC | 20:27 | |
| *** rushiagr is now known as rushiagr_away | 20:27 | |
| *** jungleboyj has joined #openstack-cinder | 20:28 | |
| thangp | jbernard: so I tried that myself, after a couple of changes, it now complains with File "/opt/stack/cinder/cinder/volume/api.py", line 45, in <module> | 20:28 |
| thangp | from cinder import utils ImportError: cannot import name utils | 20:28 |
| thangp | jbernard: there's something odd with importing RBDriver in connector.py | 20:29 |
| openstackgerrit | Rushil Chugh proposed openstack/cinder: Fixing mount when state_path is configured with a final '/' https://review.openstack.org/163032 | 20:30 |
| jbernard | thangp: yeah, im seeing similar results | 20:30 |
| *** julim has quit IRC | 20:31 | |
| *** jungleboyj has quit IRC | 20:33 | |
| *** jungleboyj has joined #openstack-cinder | 20:33 | |
| openstackgerrit | Rushil Chugh proposed openstack/cinder: Fixing mount when state_path is configured with a final '/' https://review.openstack.org/163032 | 20:34 |
| *** afazekas has joined #openstack-cinder | 20:38 | |
| *** e0ne has joined #openstack-cinder | 20:39 | |
| *** annashen has quit IRC | 20:40 | |
| thangp | jbernard: can you try to import RBDDriver in InitiatorConnector.__init__ - it worked for me | 20:42 |
| thangp | jbernard: I think there is a circular dependency somewhere | 20:42 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/157642 | 20:42 |
| *** jcru has quit IRC | 20:44 | |
| jbernard | thangp: yep, one sec | 20:44 |
| *** jcru has joined #openstack-cinder | 20:46 | |
| *** afazekas has quit IRC | 20:47 | |
| jbernard | thangp: you mean import at the class level? | 20:49 |
| thangp | jbernard: yup | 20:49 |
| jbernard | thangp: would that be allowed? | 20:49 |
| *** afazekas has joined #openstack-cinder | 20:49 | |
| *** e0ne has quit IRC | 20:49 | |
| thangp | jbernard: depends on what you're doing :) | 20:49 |
| thingee | rhe00: hey are the ci stuff going? have you been getting the help you need? | 20:49 |
| thingee | hey how are* | 20:50 |
| jbernard | thangp: ok :) well at least it will unblock my current path | 20:50 |
| jbernard | thangp: thanks for your time | 20:50 |
| thangp | jbernard: but I think there are some dependencies that rdb.py is pulling that is not there yet | 20:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements https://review.openstack.org/155579 | 20:50 |
| *** Yogi1 has quit IRC | 20:50 | |
| thangp | jbernard: np | 20:50 |
| *** annashen has joined #openstack-cinder | 20:51 | |
| jbernard | thangp: importing within the class still breaks for me | 20:53 |
| thangp | __import__('cinder.volume.drivers.rbd.RBDDriver') | 20:54 |
| thangp | jbernard: ^% | 20:54 |
| thangp | jbernard: http://paste.openstack.org/show/192726/ | 20:54 |
| jbernard | thangp: will that support 'from X import Y' syntax as well? | 20:55 |
| *** dustins has quit IRC | 20:56 | |
| thangp | yeah, just do __import__('x.y') | 20:56 |
| *** jaypipes has quit IRC | 20:56 | |
| *** jaypipes has joined #openstack-cinder | 20:57 | |
| jbernard | thangp: oh man, that's pretty sneaky | 20:57 |
| jbernard | thangp: ;) | 20:57 |
| thangp | jbernard: :) | 20:57 |
| jbernard | thangp: also, i worry that kittens will be killed when i save this buffer | 20:57 |
| thangp | haha | 20:57 |
| *** boichev has quit IRC | 20:58 | |
| *** harlowja is now known as harlowja_away | 20:58 | |
| jbernard | thangp: http://sprunge.us/giQQ | 21:01 |
| thangp | jbernard: try just __import__('cinder.volume.drivers.rbd') | 21:01 |
| *** dflorea has quit IRC | 21:01 | |
| thangp | jbernard: that should pull everything in rdb | 21:01 |
| jbernard | thangp: ahh, that works | 21:02 |
| thangp | jbernard: cool | 21:02 |
| jbernard | thangp: i think, one sec ;) | 21:02 |
| jbernard | thangp: so, i should be able to access RBDDriver as 'rbd.RBDDriver', right? | 21:03 |
| thangp | jbernard: yup | 21:03 |
| jbernard | thangp: assuming the latest import | 21:03 |
| *** Mandell has quit IRC | 21:03 | |
| jbernard | thangp: http://sprunge.us/gHWY | 21:04 |
| mtanino | hemna: thank you for the review :) | 21:05 |
| hemna | mtanino, np :) | 21:05 |
| thangp | jbernard: oh, __import__('cinder.volume.drivers.rbd', globals=globals()) | 21:06 |
| thangp | jbernard: or just assign a var to it | 21:07 |
| thangp | jbernard: then just use it, e.g. rdb = __import__() rdb.RDBDriver() | 21:07 |
| thangp | jbernard: https://docs.python.org/2/library/functions.html#__import__ | 21:07 |
| jbernard | thangp: ok, i need to read about that | 21:08 |
| jbernard | thangp: thanks again! | 21:08 |
| thangp | jbernard: np | 21:08 |
| *** akerr has quit IRC | 21:10 | |
| *** annashen has quit IRC | 21:12 | |
| hemna | smcgindia, so there was no way around the \ in https://review.openstack.org/#/c/158732 ? | 21:12 |
| *** tellesnobrega has quit IRC | 21:13 | |
| smcgindia | hemna: Unfortunately no. :[ | 21:14 |
| smcgindia | hemna: Things go boom without it when trying to use (). | 21:15 |
| hemna | smcgindia, dang ok. not a big deal. it's more readable than it was previously anyway | 21:15 |
| *** rushil__ has quit IRC | 21:15 | |
| hemna | I was about to suggest using () | 21:15 |
| smcgindia | hemna: I think so. And safer. | 21:15 |
| hemna | heh | 21:15 |
| smcgindia | hemna: ;) | 21:15 |
| hemna | but if it pukes....bleh | 21:15 |
| smcgindia | hemna: I think if you look back in the comments I have a paste of some tests I did there. | 21:15 |
| *** thangp has quit IRC | 21:16 | |
| hemna | heh Eric complained about it too. | 21:16 |
| hemna | funny | 21:16 |
| smcgindia | hemna: Yeah, I knew it was going to happen so I put the note in the commit. | 21:16 |
| *** afazekas has quit IRC | 21:16 | |
| hemna | I'm kew w/ it. | 21:16 |
| smcgindia | hemna: But of course got the comments anyway. :) | 21:16 |
| hemna | thanks man | 21:16 |
| smcgindia | hemna: Thanks for looking at it! | 21:16 |
| *** tellesnobrega has joined #openstack-cinder | 21:18 | |
| hemna | thangp | 21:18 |
| *** Mandell has joined #openstack-cinder | 21:18 | |
| *** rushil_ has quit IRC | 21:19 | |
| *** dflorea has joined #openstack-cinder | 21:22 | |
| *** lpetrut has quit IRC | 21:23 | |
| *** jungleboyj has quit IRC | 21:23 | |
| *** afazekas has joined #openstack-cinder | 21:23 | |
| *** afazekas has quit IRC | 21:29 | |
| *** annashen has joined #openstack-cinder | 21:30 | |
| *** hemna has quit IRC | 21:32 | |
| *** mriedem is now known as mriedem_away | 21:33 | |
| *** jcru has quit IRC | 21:33 | |
| *** bswartz has joined #openstack-cinder | 21:42 | |
| *** sgotliv has quit IRC | 21:42 | |
| *** hemna has joined #openstack-cinder | 21:43 | |
| *** hemna has quit IRC | 21:47 | |
| *** hemna has joined #openstack-cinder | 21:52 | |
| *** dflorea has quit IRC | 21:59 | |
| *** Lee1092 has quit IRC | 22:00 | |
| *** ronis has quit IRC | 22:03 | |
| *** dflorea has joined #openstack-cinder | 22:04 | |
| *** Maike has quit IRC | 22:05 | |
| *** harlowja_away is now known as harlowja | 22:11 | |
| *** annashen has quit IRC | 22:14 | |
| *** annashen has joined #openstack-cinder | 22:15 | |
| *** dflorea has quit IRC | 22:18 | |
| *** dflorea_ has joined #openstack-cinder | 22:21 | |
| *** Mandell has quit IRC | 22:24 | |
| *** Mandell has joined #openstack-cinder | 22:29 | |
| openstackgerrit | Richard Hedlind proposed openstack/cinder: Decrement remaining retries after failed REST call. https://review.openstack.org/163296 | 22:36 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: WIP: Remove Brick from cinder codebase https://review.openstack.org/155552 | 22:36 |
| hemna | just rebasing | 22:37 |
| *** xyang has quit IRC | 22:42 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Don't override extra specs with config in VMAX https://review.openstack.org/162658 | 22:42 |
| *** tsekiyam_ has joined #openstack-cinder | 22:52 | |
| *** tsekiyama has quit IRC | 22:55 | |
| *** sgotliv has joined #openstack-cinder | 22:56 | |
| *** dflorea_ has quit IRC | 22:57 | |
| *** tsekiyam_ has quit IRC | 22:57 | |
| *** dflorea has joined #openstack-cinder | 23:01 | |
| *** dflorea has quit IRC | 23:02 | |
| *** dflorea has joined #openstack-cinder | 23:03 | |
| *** patrickeast_ has joined #openstack-cinder | 23:03 | |
| *** patrickeast has quit IRC | 23:04 | |
| *** patrickeast_ is now known as patrickeast | 23:04 | |
| *** dflorea has quit IRC | 23:07 | |
| *** sgotliv has quit IRC | 23:10 | |
| *** hemna is now known as hemnafk | 23:13 | |
| *** dflorea has joined #openstack-cinder | 23:13 | |
| *** ganso_ has quit IRC | 23:17 | |
| *** r-daneel has quit IRC | 23:19 | |
| *** lnr has joined #openstack-cinder | 23:30 | |
| *** lnr has left #openstack-cinder | 23:31 | |
| *** jaypipes has quit IRC | 23:41 | |
| *** r-daneel has joined #openstack-cinder | 23:42 | |
| *** r-daneel has quit IRC | 23:47 | |
| *** dannywilson has quit IRC | 23:51 | |
| *** alexpilotti has quit IRC | 23:57 | |
| *** ho has joined #openstack-cinder | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!