| openstackgerrit | Thang Pham proposed openstack/cinder: Raise exception for invalid mock assert calls https://review.openstack.org/160208 | 00:16 |
|---|---|---|
| *** _cjones_ has quit IRC | 00:16 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Switch to oslo_versionedobjects https://review.openstack.org/160209 | 00:18 |
| *** ho has joined #openstack-cinder | 00:22 | |
| *** e0ne has quit IRC | 00:49 | |
| *** bill_az has joined #openstack-cinder | 00:50 | |
| *** tshefi has quit IRC | 00:51 | |
| *** Lee1092 has joined #openstack-cinder | 00:59 | |
| *** topshare has joined #openstack-cinder | 01:00 | |
| *** _cjones_ has joined #openstack-cinder | 01:12 | |
| *** takedakn has joined #openstack-cinder | 01:14 | |
| *** takedakn has quit IRC | 01:17 | |
| *** mriedem1 has quit IRC | 01:26 | |
| *** _cjones_ has quit IRC | 01:31 | |
| *** bill_az has quit IRC | 01:37 | |
| *** liusheng has quit IRC | 01:46 | |
| *** _cjones_ has joined #openstack-cinder | 01:51 | |
| *** qwebirc49866 has joined #openstack-cinder | 01:58 | |
| *** qwebirc49866 has quit IRC | 01:58 | |
| *** DaveChen has joined #openstack-cinder | 02:01 | |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 02:02 |
| *** krtaylor has quit IRC | 02:04 | |
| *** Ilja has quit IRC | 02:06 | |
| *** kaufer has joined #openstack-cinder | 02:09 | |
| *** diegows has quit IRC | 02:11 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Delete the temporary volume if migration fails https://review.openstack.org/160682 | 02:12 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Test. https://review.openstack.org/161141 | 02:13 |
| openstackgerrit | Vincent Hou proposed openstack/cinder-specs: Enhance list operations with the additional keys and next link https://review.openstack.org/148181 | 02:17 |
| *** kaisers has joined #openstack-cinder | 02:19 | |
| *** kaisers1 has quit IRC | 02:20 | |
| *** [1]Thelo has joined #openstack-cinder | 02:24 | |
| *** hflai has joined #openstack-cinder | 02:26 | |
| *** haomaiwang has joined #openstack-cinder | 02:26 | |
| *** Thelo has quit IRC | 02:26 | |
| *** [1]Thelo is now known as Thelo | 02:26 | |
| *** Krast has joined #openstack-cinder | 02:32 | |
| *** Thelo has left #openstack-cinder | 02:33 | |
| *** Thelo has joined #openstack-cinder | 02:33 | |
| *** coolsvap has joined #openstack-cinder | 02:34 | |
| *** _cjones_ has quit IRC | 02:37 | |
| *** krtaylor has joined #openstack-cinder | 02:55 | |
| *** Longgeek has joined #openstack-cinder | 02:55 | |
| *** kaufer has quit IRC | 02:57 | |
| *** jcru has joined #openstack-cinder | 02:58 | |
| *** vilobhmm has joined #openstack-cinder | 02:59 | |
| *** vilobhmm1 has joined #openstack-cinder | 03:04 | |
| *** vilobhmm has quit IRC | 03:05 | |
| *** buster_604 has quit IRC | 03:13 | |
| *** jcru has quit IRC | 03:15 | |
| *** buster_604 has joined #openstack-cinder | 03:18 | |
| *** buster_604 has quit IRC | 03:19 | |
| *** Mandell has joined #openstack-cinder | 03:19 | |
| *** buster_604 has joined #openstack-cinder | 03:42 | |
| *** _cjones_ has joined #openstack-cinder | 03:44 | |
| *** sandywalsh has quit IRC | 03:45 | |
| *** _cjones_ has quit IRC | 03:55 | |
| *** vilobhmm1 has quit IRC | 04:15 | |
| *** vilobhmm has joined #openstack-cinder | 04:16 | |
| *** buster_604 has quit IRC | 04:26 | |
| *** esker has quit IRC | 04:28 | |
| *** esker has joined #openstack-cinder | 04:28 | |
| *** Ilja has joined #openstack-cinder | 04:43 | |
| *** BharatK has joined #openstack-cinder | 04:48 | |
| *** _cjones_ has joined #openstack-cinder | 04:52 | |
| *** _cjones_ has quit IRC | 04:56 | |
| *** buster_604 has joined #openstack-cinder | 04:56 | |
| *** buster_604 has quit IRC | 04:58 | |
| *** Ilja has quit IRC | 05:00 | |
| *** sgotliv has quit IRC | 05:11 | |
| *** Ilja has joined #openstack-cinder | 05:26 | |
| *** lpetrut has joined #openstack-cinder | 05:28 | |
| *** BharatK has quit IRC | 05:52 | |
| *** BharatK has joined #openstack-cinder | 05:56 | |
| *** pradipta has joined #openstack-cinder | 05:58 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Fixes VNX NotImplementedError of unmanage https://review.openstack.org/162532 | 06:00 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/152401 | 06:05 |
| *** anshul has joined #openstack-cinder | 06:09 | |
| *** deepakcs has joined #openstack-cinder | 06:09 | |
| *** BharatK has quit IRC | 06:32 | |
| *** BharatK has joined #openstack-cinder | 06:34 | |
| *** nlevinki has joined #openstack-cinder | 06:35 | |
| *** sgotliv has joined #openstack-cinder | 06:39 | |
| *** beecee has quit IRC | 06:43 | |
| *** sgotliv has quit IRC | 06:44 | |
| *** bkopilov has quit IRC | 06:50 | |
| *** _cjones_ has joined #openstack-cinder | 06:53 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Fixes VNX NotImplementedError of unmanage https://review.openstack.org/162532 | 06:54 |
| openstackgerrit | Peter Wang proposed openstack/cinder: Fixes VNX NotImplementedError of unmanage https://review.openstack.org/162532 | 06:56 |
| *** rwsu has joined #openstack-cinder | 06:57 | |
| *** sgotliv has joined #openstack-cinder | 06:58 | |
| *** _cjones_ has quit IRC | 06:58 | |
| *** rwsu is now known as rwsu-afk | 06:58 | |
| *** Ilja has quit IRC | 06:59 | |
| openstackgerrit | Abhijeet Malawade proposed openstack/cinder: Get volume from db again before updating it's status https://review.openstack.org/144409 | 07:05 |
| *** ankit_ag has joined #openstack-cinder | 07:08 | |
| *** afazekas has joined #openstack-cinder | 07:09 | |
| openstackgerrit | Huang Zhiteng proposed openstack/cinder: DO NOT MERGE: Scheduler Raises NoValidHostNotComplete when it doesn't have complete view https://review.openstack.org/162050 | 07:15 |
| *** nkrinner has joined #openstack-cinder | 07:17 | |
| *** vilobhmm has quit IRC | 07:18 | |
| *** ankit8188 has joined #openstack-cinder | 07:31 | |
| *** ankit_ag has quit IRC | 07:33 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver check before associating LUN to a LUN group https://review.openstack.org/148144 | 07:42 |
| *** Miouge has joined #openstack-cinder | 07:44 | |
| *** bkopilov has joined #openstack-cinder | 07:45 | |
| *** TobiasE1 has joined #openstack-cinder | 07:47 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver fix problems under multipath https://review.openstack.org/150767 | 07:49 |
| *** bkopilov has quit IRC | 07:50 | |
| *** bkopilov has joined #openstack-cinder | 07:50 | |
| *** bkopilov has quit IRC | 07:53 | |
| *** bkopilov has joined #openstack-cinder | 07:54 | |
| *** _cjones_ has joined #openstack-cinder | 07:55 | |
| *** Ilja has joined #openstack-cinder | 07:58 | |
| *** _cjones_ has quit IRC | 08:00 | |
| *** nellysmitt has joined #openstack-cinder | 08:00 | |
| *** Ilja has quit IRC | 08:07 | |
| *** chlong has quit IRC | 08:07 | |
| *** nellysmitt has quit IRC | 08:12 | |
| *** nellysmitt has joined #openstack-cinder | 08:12 | |
| *** lpetrut has quit IRC | 08:20 | |
| openstackgerrit | Tina Tang proposed openstack/cinder: Attach/detach batch processing in VNX driver https://review.openstack.org/154350 | 08:21 |
| *** ronis has joined #openstack-cinder | 08:22 | |
| *** lpetrut has joined #openstack-cinder | 08:30 | |
| *** enterprisedc has quit IRC | 08:30 | |
| *** bkopilov has quit IRC | 08:31 | |
| *** Ilja has joined #openstack-cinder | 08:31 | |
| *** Ilja has quit IRC | 08:32 | |
| *** Ilja has joined #openstack-cinder | 08:32 | |
| *** lpetrut has quit IRC | 08:33 | |
| *** Ilja1 has joined #openstack-cinder | 08:35 | |
| *** Ilja has quit IRC | 08:36 | |
| *** RanZ has joined #openstack-cinder | 08:38 | |
| *** Mandell has quit IRC | 08:39 | |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 08:43 |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Huawei driver remove LUN controller change https://review.openstack.org/152116 | 08:45 |
| wanghao | hi guys: there is a patch:'https://review.openstack.org/#/c/159374/', has already got +2 for a week, could you help me to merge it? THX | 08:47 |
| *** jordanP has joined #openstack-cinder | 08:48 | |
| *** Kennan_ has joined #openstack-cinder | 08:48 | |
| Kennan_ | hi all, could I ask one question ? | 08:49 |
| Kennan_ | in devstack | 08:49 |
| Kennan_ | 2015-03-09 16:49:47.391 TRACE cinder.volume.manager ProcessExecutionError: Unexpected error while running command. 2015-03-09 16:49:47.391 TRACE cinder.volume.manager Command: sudo cinder-rootwrap /etc/cinder/rootwrap.conf env LC_ALL=C LVM_SYSTEM_DIR=/etc/cinder vgs --noheadings --unit=g -o name,size,free,lv_count,uuid --separator : --nosuffix stack-volumes-lvmdriver-1 2015-03-09 16:49:47.391 TRACE cinder.volume.manager Exi | 08:49 |
| Kennan_ | but when I run | 08:50 |
| Kennan_ | sudo vgs --noheadings --unit=g -o name,size,free,lv_count,uuid --separator : --nosuffix stack-volumes-lvmdriver-1 | 08:50 |
| Kennan_ | it have output | 08:50 |
| Kennan_ | stack-volumes-lvmdriver-1:10.00:10.00:0:dpkEDv-d7nT-qvKh-R9WX-qYNG-MgDx-BvYfCP | 08:50 |
| Kennan_ | I don't know why cinder-volum run with sudo cinder-rootwrap /etc/cinder/rootwrap.conf | 08:51 |
| Kennan_ | failed | 08:51 |
| Kennan_ | do you know ? | 08:51 |
| *** _cjones_ has joined #openstack-cinder | 08:56 | |
| openstackgerrit | wanghao proposed openstack/cinder: Fix the unicode encode error when create volume https://review.openstack.org/159707 | 08:58 |
| *** briancline has quit IRC | 09:00 | |
| *** nlevinki has quit IRC | 09:01 | |
| *** _cjones_ has quit IRC | 09:02 | |
| *** sdague has quit IRC | 09:04 | |
| *** dobson has quit IRC | 09:04 | |
| *** karimb has joined #openstack-cinder | 09:04 | |
| *** nlevinki has joined #openstack-cinder | 09:04 | |
| *** briancline has joined #openstack-cinder | 09:06 | |
| *** sdague has joined #openstack-cinder | 09:06 | |
| *** dobson has joined #openstack-cinder | 09:06 | |
| wanghao | @kennan, Is there more detial error message about cinder-volume running command? | 09:10 |
| *** jistr has joined #openstack-cinder | 09:13 | |
| *** lpetrut has joined #openstack-cinder | 09:14 | |
| RanZ | Hi. Quick question: is there a reason why "id" is not a valid search_opts when searching for Volumes? I'm referring to it missing here: https://github.com/openstack/cinder/blob/84afca21fd19d5f78259f0a820258645c1780749/cinder/api/v1/volumes.py#L402 | 09:18 |
| *** karimb has quit IRC | 09:25 | |
| *** karimb has joined #openstack-cinder | 09:27 | |
| wanghao | @RanZ, For common user, display_name is more useful for querying, I think. | 09:27 |
| *** Kennan_ has left #openstack-cinder | 09:31 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/cinder: Fix wrong log output in cinder/cinder/volume/drivers/lvm.py https://review.openstack.org/162581 | 09:41 |
| RanZ | @wanghao Is there any specific reason why "id" is not available though? in my use case I often use display_name, but then in other times I'd like to use ID | 09:43 |
| wanghao | @RanZ, It's unkown for me, but I agree with you. It's should be configurable for common user to query volumes by more choice. | 09:49 |
| *** Ilja1 has quit IRC | 09:50 | |
| wanghao | there is a bp about this:'https://blueprints.launchpad.net/cinder/+spec/allow-non-admin-to-query-volume-filter-by-az', I hope it will be more flexibility. | 09:50 |
| RanZ | @wanghao I see that you created this ticket. Did you create one for Nova as well? I've noticed it's the same with querying servers by ID | 09:55 |
| *** Ilja has joined #openstack-cinder | 09:56 | |
| *** _cjones_ has joined #openstack-cinder | 09:59 | |
| *** _cjones_ has quit IRC | 10:09 | |
| *** haomaiwang has quit IRC | 10:09 | |
| wanghao | @RanZ.Not yet.I'am thinking a question,because we already have ability to show the resource by ID. Is it necessary for index or detail query? I mean that filter by az or host is ok, but ID is unique for resource. | 10:11 |
| *** coolsvap has quit IRC | 10:17 | |
| pradip_vedams | hi all, can anyone tell me for VPN as service we need to openstack environment or we can create two diffrent tenant in same environment....???????? | 10:17 |
| pradip_vedams | sorry guys by mistake i post neutron question here.... | 10:19 |
| *** RanZ has quit IRC | 10:20 | |
| *** topshare has quit IRC | 10:24 | |
| *** TobiasE has joined #openstack-cinder | 10:26 | |
| *** TobiasE1 has quit IRC | 10:27 | |
| openstackgerrit | rajiv proposed openstack/python-cinderclient: cinderclient accepts arguments after metadata without -- separator https://review.openstack.org/156499 | 10:29 |
| *** RanZ has joined #openstack-cinder | 10:35 | |
| *** bkopilov has joined #openstack-cinder | 10:38 | |
| openstackgerrit | wanghao proposed openstack/cinder: Fix response when query host detail by host name https://review.openstack.org/162601 | 10:55 |
| *** chlong has joined #openstack-cinder | 11:03 | |
| *** nlevinki has quit IRC | 11:04 | |
| *** _cjones_ has joined #openstack-cinder | 11:05 | |
| openstackgerrit | wanghao proposed openstack/cinder: Implement function of import/export snapshots https://review.openstack.org/144590 | 11:10 |
| *** markvoelker has joined #openstack-cinder | 11:13 | |
| *** nlevinki has joined #openstack-cinder | 11:20 | |
| *** kallebe has joined #openstack-cinder | 11:21 | |
| *** ho has quit IRC | 11:24 | |
| *** IanGovett has joined #openstack-cinder | 11:36 | |
| *** _cjones_ has quit IRC | 11:38 | |
| *** cdelatte has joined #openstack-cinder | 11:44 | |
| *** diegows has joined #openstack-cinder | 11:46 | |
| *** markvoelker has quit IRC | 11:47 | |
| *** markvoelker has joined #openstack-cinder | 11:48 | |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Added provider_id to volume and snapshot object https://review.openstack.org/162611 | 11:51 |
| *** anik80 has quit IRC | 11:51 | |
| *** markvoelker has quit IRC | 11:52 | |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Added provider_id to volume and snapshot object https://review.openstack.org/162611 | 11:54 |
| *** Anticimex has quit IRC | 11:57 | |
| *** Anticimex has joined #openstack-cinder | 11:57 | |
| *** Miouge_ has joined #openstack-cinder | 12:01 | |
| *** Miouge has quit IRC | 12:01 | |
| *** Miouge_ is now known as Miouge | 12:01 | |
| *** ganso_ has joined #openstack-cinder | 12:03 | |
| *** IanGovett has quit IRC | 12:04 | |
| *** Ilja has quit IRC | 12:06 | |
| *** IanGovett has joined #openstack-cinder | 12:10 | |
| *** Ilja has joined #openstack-cinder | 12:14 | |
| *** Ilja1 has joined #openstack-cinder | 12:14 | |
| *** Ilja has quit IRC | 12:14 | |
| *** marcusvrn has joined #openstack-cinder | 12:16 | |
| *** sgotliv has quit IRC | 12:17 | |
| *** bswartz has quit IRC | 12:22 | |
| *** dulek has joined #openstack-cinder | 12:23 | |
| *** TobiasE1 has joined #openstack-cinder | 12:24 | |
| *** [1]Thelo has joined #openstack-cinder | 12:24 | |
| *** TobiasE has quit IRC | 12:25 | |
| *** Thelo has quit IRC | 12:26 | |
| *** [1]Thelo is now known as Thelo | 12:26 | |
| *** topshare has joined #openstack-cinder | 12:30 | |
| *** sgotliv has joined #openstack-cinder | 12:32 | |
| *** marcusvrn has quit IRC | 12:33 | |
| *** marcusvrn has joined #openstack-cinder | 12:35 | |
| *** _cjones_ has joined #openstack-cinder | 12:36 | |
| *** annegentle has joined #openstack-cinder | 12:36 | |
| *** Mandell has joined #openstack-cinder | 12:40 | |
| *** topshare has quit IRC | 12:43 | |
| *** aix has joined #openstack-cinder | 12:43 | |
| *** Mandell has quit IRC | 12:44 | |
| *** Miouge has quit IRC | 12:50 | |
| *** Miouge has joined #openstack-cinder | 12:50 | |
| *** ndipanov has joined #openstack-cinder | 12:53 | |
| *** ndipanov has quit IRC | 12:53 | |
| *** bswartz has joined #openstack-cinder | 12:56 | |
| *** deepakcs has quit IRC | 12:57 | |
| *** Yogi1 has joined #openstack-cinder | 13:00 | |
| *** TobiasE has joined #openstack-cinder | 13:01 | |
| *** akerr has joined #openstack-cinder | 13:01 | |
| *** Yogi1 has left #openstack-cinder | 13:02 | |
| *** TobiasE1 has quit IRC | 13:02 | |
| *** nlevinki has quit IRC | 13:03 | |
| *** chlong has quit IRC | 13:04 | |
| *** Miouge has quit IRC | 13:04 | |
| *** Yogi1 has joined #openstack-cinder | 13:06 | |
| *** topshare has joined #openstack-cinder | 13:08 | |
| *** _cjones_ has quit IRC | 13:09 | |
| *** nlevinki has joined #openstack-cinder | 13:17 | |
| *** chlong has joined #openstack-cinder | 13:17 | |
| *** timcl has joined #openstack-cinder | 13:21 | |
| *** kaufer has joined #openstack-cinder | 13:25 | |
| *** dustins has joined #openstack-cinder | 13:28 | |
| *** superdan is now known as dansmith | 13:34 | |
| *** eharney has quit IRC | 13:42 | |
| *** tbarron has joined #openstack-cinder | 13:43 | |
| *** anki80 has joined #openstack-cinder | 13:48 | |
| *** yamada-h has quit IRC | 13:49 | |
| *** sgotliv_ has joined #openstack-cinder | 13:53 | |
| *** sgotliv has quit IRC | 13:53 | |
| *** Ilja1 has quit IRC | 13:57 | |
| *** topshare has quit IRC | 14:00 | |
| *** gmurphy has left #openstack-cinder | 14:03 | |
| *** topshare has joined #openstack-cinder | 14:03 | |
| *** _cjones_ has joined #openstack-cinder | 14:06 | |
| *** Ilja has joined #openstack-cinder | 14:06 | |
| *** Anticimex has quit IRC | 14:07 | |
| *** marcusvrn1 has joined #openstack-cinder | 14:07 | |
| *** Anticimex has joined #openstack-cinder | 14:08 | |
| *** marcusvrn has quit IRC | 14:09 | |
| *** annegentle has quit IRC | 14:10 | |
| *** markvoelker has joined #openstack-cinder | 14:11 | |
| *** thangp has joined #openstack-cinder | 14:12 | |
| *** annegentle has joined #openstack-cinder | 14:15 | |
| *** jcru has joined #openstack-cinder | 14:17 | |
| *** jcru has quit IRC | 14:17 | |
| *** ebalduf has joined #openstack-cinder | 14:17 | |
| *** jcru has joined #openstack-cinder | 14:17 | |
| *** markvoelker has quit IRC | 14:18 | |
| *** IanGovett has quit IRC | 14:19 | |
| *** markvoelker has joined #openstack-cinder | 14:19 | |
| *** mwichmann has joined #openstack-cinder | 14:22 | |
| *** markvoelker has quit IRC | 14:23 | |
| *** Guest82873 has quit IRC | 14:23 | |
| *** nellysmitt has quit IRC | 14:24 | |
| *** markvoelker has joined #openstack-cinder | 14:24 | |
| *** r-daneel has joined #openstack-cinder | 14:28 | |
| *** xyang has joined #openstack-cinder | 14:30 | |
| *** akerr is now known as akerr_away | 14:31 | |
| *** eharney has joined #openstack-cinder | 14:31 | |
| *** akerr has joined #openstack-cinder | 14:32 | |
| *** akerr is now known as akerr_away | 14:32 | |
| *** akerr_away has quit IRC | 14:33 | |
| *** emagana has joined #openstack-cinder | 14:33 | |
| *** akerr has joined #openstack-cinder | 14:34 | |
| *** alonmarx has quit IRC | 14:36 | |
| *** alonmarx has joined #openstack-cinder | 14:37 | |
| *** ankit8188 has quit IRC | 14:37 | |
| *** _cjones_ has quit IRC | 14:39 | |
| *** mriedem has joined #openstack-cinder | 14:39 | |
| *** mtanino has joined #openstack-cinder | 14:42 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Raise exception for invalid mock assert calls https://review.openstack.org/160208 | 14:44 |
| *** beekneemech is now known as bnemec | 14:49 | |
| *** annegentle has quit IRC | 14:54 | |
| openstackgerrit | Stefan Amann proposed openstack/cinder: Adjust Cinder to support FCP on System z systems https://review.openstack.org/149256 | 14:55 |
| *** ndipanov has joined #openstack-cinder | 14:56 | |
| *** patrickeast has joined #openstack-cinder | 14:59 | |
| *** alonmarx_ has joined #openstack-cinder | 14:59 | |
| *** alonmarx_ has quit IRC | 15:00 | |
| *** alonmarx_ has joined #openstack-cinder | 15:00 | |
| *** alonmarx has quit IRC | 15:01 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/cinder: Fix wrong log output in cinder/cinder/volume/drivers/lvm.py https://review.openstack.org/162581 | 15:01 |
| *** ndipanov has quit IRC | 15:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/157642 | 15:02 |
| openstackgerrit | Kurt Martin proposed openstack/cinder: HP lefthand driver filter and evalautor function https://review.openstack.org/157237 | 15:03 |
| *** topshare has quit IRC | 15:06 | |
| *** asselin_ has joined #openstack-cinder | 15:06 | |
| *** nellysmitt has joined #openstack-cinder | 15:08 | |
| *** asselin_ has quit IRC | 15:08 | |
| *** asselin_ has joined #openstack-cinder | 15:08 | |
| *** Mandell has joined #openstack-cinder | 15:10 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support https://review.openstack.org/85847 | 15:14 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add multiattach capabilities injection https://review.openstack.org/159650 | 15:14 |
| *** ndipanov has joined #openstack-cinder | 15:17 | |
| *** dannywilson has joined #openstack-cinder | 15:20 | |
| *** dannywil_ has joined #openstack-cinder | 15:21 | |
| *** dannywilson has quit IRC | 15:22 | |
| *** rmesta has joined #openstack-cinder | 15:22 | |
| *** hemnafk is now known as hemna | 15:22 | |
| *** annegentle has joined #openstack-cinder | 15:23 | |
| *** afazekas has quit IRC | 15:26 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Switch to oslo_versionedobjects https://review.openstack.org/160209 | 15:26 |
| *** tsekiyama has joined #openstack-cinder | 15:26 | |
| *** emagana has quit IRC | 15:28 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Don't override extra specs with config in VMAX https://review.openstack.org/162658 | 15:28 |
| *** kallebe has quit IRC | 15:30 | |
| *** markvoelker has quit IRC | 15:30 | |
| *** IanGovett has joined #openstack-cinder | 15:31 | |
| *** markvoelker has joined #openstack-cinder | 15:31 | |
| jungleboyj | hemna: Ping. | 15:31 |
| *** emagana has joined #openstack-cinder | 15:31 | |
| *** jdurgin has joined #openstack-cinder | 15:32 | |
| *** harlowja_at_home has joined #openstack-cinder | 15:32 | |
| hemna | hey | 15:35 |
| *** markvoelker has quit IRC | 15:35 | |
| *** _cjones_ has joined #openstack-cinder | 15:35 | |
| *** esker has quit IRC | 15:36 | |
| *** anshul has quit IRC | 15:37 | |
| *** david-lyle_afk is now known as david-lyle | 15:38 | |
| *** markvoelker has joined #openstack-cinder | 15:38 | |
| *** Ilja has quit IRC | 15:41 | |
| *** rwsu-afk is now known as rwsu | 15:41 | |
| *** diegows has quit IRC | 15:42 | |
| *** markvoelker has quit IRC | 15:43 | |
| *** markvoelker has joined #openstack-cinder | 15:44 | |
| *** emagana has quit IRC | 15:44 | |
| *** patrickeast has quit IRC | 15:44 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Switch get_all_snapshots to use objects https://review.openstack.org/161077 | 15:45 |
| *** Mandell has quit IRC | 15:46 | |
| hemna | jungleboyj, ? | 15:48 |
| *** nellysmitt has quit IRC | 15:49 | |
| *** markvoelker has quit IRC | 15:49 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Fixed a concurrency issue in VMAX driver https://review.openstack.org/157683 | 15:49 |
| openstackgerrit | xing-yang proposed openstack/cinder: Fixed a problem in recreating masking view in VMAX https://review.openstack.org/157684 | 15:50 |
| jungleboyj | hemna: Are any of the zone managers able to handle dual fabric environments? | 15:51 |
| hemna | meaning 2 brocade switches ? | 15:51 |
| hemna | or brocade + cisco at the same time ? | 15:51 |
| hemna | afaik brocade and cisco don't play well together | 15:51 |
| hemna | you can define 2 brocade zones and use em in cinder.conf | 15:52 |
| *** asselin_ has quit IRC | 15:52 | |
| *** nellysmitt has joined #openstack-cinder | 15:52 | |
| jungleboyj | hemna: The question was ' can they handle a dual Fabric environment (A and B fabric). | 15:53 |
| hemna | afaik yes | 15:53 |
| jungleboyj | Ok, that was what I had assumed but wanted to check with someone smarter than me. ;-) | 15:53 |
| *** emagana has joined #openstack-cinder | 15:53 | |
| jungleboyj | hemna: Thanks! | 15:55 |
| *** diegows has joined #openstack-cinder | 15:56 | |
| *** sgotliv has joined #openstack-cinder | 15:58 | |
| *** sgotliv_ has quit IRC | 15:58 | |
| *** kallebe has joined #openstack-cinder | 15:58 | |
| *** _cjones_ has quit IRC | 16:01 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/cinder: Adjust Cinder to support FCP on System z systems https://review.openstack.org/149256 | 16:04 |
| *** nlevinki has quit IRC | 16:05 | |
| *** annegentle has quit IRC | 16:06 | |
| *** esker has joined #openstack-cinder | 16:07 | |
| *** TobiasE has quit IRC | 16:11 | |
| *** nellysmitt has quit IRC | 16:11 | |
| *** _cjones_ has joined #openstack-cinder | 16:14 | |
| *** _cjones_ has quit IRC | 16:14 | |
| *** jaypipes has joined #openstack-cinder | 16:14 | |
| *** _cjones_ has joined #openstack-cinder | 16:14 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/cinder: Adjust Cinder to support FCP on System z systems https://review.openstack.org/149256 | 16:14 |
| *** markus_z has joined #openstack-cinder | 16:17 | |
| *** nlevinki has joined #openstack-cinder | 16:19 | |
| *** emagana has quit IRC | 16:20 | |
| *** nellysmitt has joined #openstack-cinder | 16:21 | |
| hemna | line 725 | 16:22 |
| hemna | I didn't touch that | 16:22 |
| *** Guest82873 has joined #openstack-cinder | 16:22 | |
| *** ronis has quit IRC | 16:23 | |
| *** thrawn01 has joined #openstack-cinder | 16:25 | |
| hemna | cinderclient(context).volumes.attach(volume_id, instance_uuid, | 16:26 |
| hemna | mountpoint, mode=mode) | 16:26 |
| hemna | so I tried to fix that by adding the hostname to populate it | 16:27 |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Backup object https://review.openstack.org/157085 | 16:29 |
| *** Longgeek has quit IRC | 16:29 | |
| *** leeantho has joined #openstack-cinder | 16:30 | |
| *** jdurgin has quit IRC | 16:33 | |
| *** RanZ has quit IRC | 16:34 | |
| *** krtaylor has quit IRC | 16:36 | |
| *** harlowja_at_home has quit IRC | 16:39 | |
| openstackgerrit | Jean-Daniel Bonnetot proposed openstack/cinder-specs: Add the possibility for admin to list volume-backend-names declared in cinder.conf. https://review.openstack.org/160416 | 16:41 |
| *** dulek has quit IRC | 16:41 | |
| *** Yogi1 has quit IRC | 16:46 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/os-brick: Adjust os-brick to support FCP on System z systems https://review.openstack.org/162678 | 16:46 |
| *** leeantho has quit IRC | 16:47 | |
| *** leeantho has joined #openstack-cinder | 16:47 | |
| *** nlevinki has quit IRC | 16:47 | |
| *** krtaylor has joined #openstack-cinder | 16:48 | |
| *** lpetrut has quit IRC | 16:48 | |
| hemna | xyang, http://paste.openstack.org/show/191017/ | 16:48 |
| *** leeantho has quit IRC | 16:49 | |
| *** leeantho has joined #openstack-cinder | 16:49 | |
| *** Apoorva has joined #openstack-cinder | 16:51 | |
| *** Krast has quit IRC | 16:55 | |
| *** Krast has joined #openstack-cinder | 16:56 | |
| hemna | so....I'm not sure what I should do | 16:57 |
| *** emagana has joined #openstack-cinder | 17:03 | |
| *** _cjones_ has quit IRC | 17:05 | |
| *** markus_z has quit IRC | 17:06 | |
| *** rmesta has left #openstack-cinder | 17:06 | |
| *** annegentle has joined #openstack-cinder | 17:07 | |
| *** tsekiyama has quit IRC | 17:07 | |
| *** nellysmitt has quit IRC | 17:11 | |
| *** nellysmitt has joined #openstack-cinder | 17:13 | |
| *** nellysmitt has quit IRC | 17:17 | |
| *** _cjones_ has joined #openstack-cinder | 17:24 | |
| *** ebalduf has quit IRC | 17:27 | |
| *** sgotliv has quit IRC | 17:28 | |
| *** ronis has joined #openstack-cinder | 17:28 | |
| *** annashen has joined #openstack-cinder | 17:30 | |
| *** lpetrut has joined #openstack-cinder | 17:30 | |
| *** jdurgin has joined #openstack-cinder | 17:35 | |
| *** harlowja has joined #openstack-cinder | 17:40 | |
| *** vilobhmm has joined #openstack-cinder | 17:41 | |
| *** harlowja_ has joined #openstack-cinder | 17:43 | |
| *** ndipanov has quit IRC | 17:45 | |
| *** harlowja has quit IRC | 17:45 | |
| *** Mandell has joined #openstack-cinder | 17:47 | |
| *** vilobhmm1 has joined #openstack-cinder | 17:48 | |
| *** patrickeast has joined #openstack-cinder | 17:51 | |
| *** enterprisedc has joined #openstack-cinder | 17:51 | |
| *** vilobhmm has quit IRC | 17:52 | |
| openstackgerrit | Patrick East proposed openstack/cinder: PureISCSIDriver consistency group updates. https://review.openstack.org/157637 | 17:54 |
| *** annegentle has quit IRC | 17:55 | |
| *** annegentle has joined #openstack-cinder | 17:55 | |
| patrickeast | jungleboyj: haha thanks for catching that log message typo… i’ve probably looked at it 100 times by now and didn’t notice it was the wrong method name | 17:57 |
| patrickeast | too much copy pasta | 17:57 |
| *** jistr has quit IRC | 17:59 | |
| jungleboyj | patrickeast: Welcome. Was going to ping you when I saw you come on. | 18:01 |
| jungleboyj | Felt bad -1'ing at this point. | 18:01 |
| jungleboyj | hemna: xyang Do you know if things can still be merged tomorrow or is today the last chance? | 18:02 |
| hemna | I'm unclear on that as well | 18:02 |
| hemna | I'm desperately trying to get multi-attach in today | 18:03 |
| hemna | but my manager wants me to work on slides instead. | 18:03 |
| jungleboyj | Yeah, I was going to look at that in a few minutes. | 18:03 |
| *** pradipta has quit IRC | 18:03 | |
| hemna | ugh | 18:05 |
| hemna | yet another rebase....damnit | 18:05 |
| jungleboyj | *Sigh* | 18:05 |
| *** chlong has quit IRC | 18:05 | |
| hemna | I'm in rebase hell | 18:06 |
| jungleboyj | Morphine has made my cat hungry and paranoid. | 18:06 |
| Swanson | Kilo-3 in 10 days, right? RC's start 3 weeks after that? | 18:07 |
| hemna | Swanson, we have a self imposed dealine though | 18:08 |
| *** tsekiyama has joined #openstack-cinder | 18:08 | |
| *** annegentle has quit IRC | 18:08 | |
| Swanson | hemna: I'm just worried about testing timelines. | 18:12 |
| hemna | once our self imposed deadline passes, we are all supposed to be testing. | 18:13 |
| *** tsekiyama has quit IRC | 18:13 | |
| Swanson | we've been testing for a while. I just want to make sure people know the timelines | 18:14 |
| jungleboyj | hemna: They got the updates for System Z pushed up: https://review.openstack.org/#/c/149256/ When ever you have a chance to look. | 18:14 |
| *** lcurtis has joined #openstack-cinder | 18:15 | |
| *** bswartz has quit IRC | 18:16 | |
| *** bswartz has joined #openstack-cinder | 18:22 | |
| hemna | he's been absent a lot due to traveling to conferences doing python presentations and such | 18:26 |
| hemna | I'm not sure where everyone is. | 18:26 |
| hemna | bleh | 18:26 |
| xyang | jungleboyj: I'm not sure if things can still be merged tomorrow. | 18:26 |
| hemna | :( | 18:26 |
| * jungleboyj thinks if we are doing reviews today and asking for changes it should be allowed. | 18:27 | |
| jungleboyj | But that is me. | 18:27 |
| *** karimb has quit IRC | 18:27 | |
| kallebe | Hey, I was trying to find some way to run hacking tests locally but could not find it. Does anyone know how to do it? | 18:27 |
| hemna | I'm sure that'll be meaningless tomorrow. | 18:27 |
| jungleboyj | hemna: Let me know when the multi-attach change is good to look at again. | 18:28 |
| jungleboyj | kallebe: ./runtests.sh -V -p | 18:28 |
| hemna | jungleboyj, ok thanks. just waiting on local tox | 18:28 |
| jungleboyj | It is part of pep8. | 18:28 |
| kallebe | jungleboyj ok. thanks for the help | 18:28 |
| jungleboyj | hemna: Then you can go look at the SystemZ patch while I do that. ;-) | 18:28 |
| hemna | jungleboyj, ok! url ? | 18:29 |
| jungleboyj | https://review.openstack.org/#/c/149256/15 | 18:29 |
| *** jordanP has quit IRC | 18:31 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support https://review.openstack.org/85847 | 18:32 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add multiattach capabilities injection https://review.openstack.org/159650 | 18:32 |
| hemna | xyang, jungleboyj ok I removed the setting of the attached_host. | 18:32 |
| hemna | it now acts as it did previously, which will always have a value of None or Null in the DB column. | 18:32 |
| xyang | hemna: ok, I'll take a look | 18:33 |
| *** tsekiyama has joined #openstack-cinder | 18:33 | |
| mtanino | anish: ping, | 18:34 |
| *** sgotliv has joined #openstack-cinder | 18:38 | |
| hemna | jungleboyj, do we have any cert results for a run on the s390 system? | 18:40 |
| jungleboyj | Yes. | 18:41 |
| jungleboyj | Let me find those. | 18:41 |
| *** mgagne is now known as mgagne_PHL | 18:42 | |
| hemna | jungleboyj, thanks | 18:42 |
| *** _cjones_ has quit IRC | 18:44 | |
| *** rushil has joined #openstack-cinder | 18:44 | |
| jungleboyj | hemna: I think this is the one: https://launchpadlibrarian.net/197841505/tmp.OVpAcYK2Rw | 18:49 |
| jungleboyj | https://bugs.launchpad.net/cinder/+bug/1422423 | 18:49 |
| openstack | Launchpad bug 1422423 in Cinder "Cinder Certification results with zKVM platform support." [Low,Confirmed] | 18:49 |
| hemna | jungleboyj, ok, the issue with that log is that it doesn't show cinder.conf | 18:52 |
| hemna | jungleboyj, how can I tell that this ran on a s390 system ? | 18:52 |
| jungleboyj | Good question. It also probably hasn't been run since their latest update. In fact, I know that. | 18:54 |
| openstackgerrit | Bharat Kumar Kobagana proposed openstack/cinder: GlusterFS: Support over subscription in thin provisioning https://review.openstack.org/162718 | 18:56 |
| xyang | hemna: looks good to me no. just waiting for Jenkins | 18:56 |
| xyang | s/no/now | 18:57 |
| jungleboyj | I am looking right now xyang hemna | 18:57 |
| hemna | thanks guys | 18:58 |
| jungleboyj | hemna: None of the System Z guys are on right now. So I guess we will have to make a comment and hope that we can still merge tomorrow. | 18:59 |
| jungleboyj | Can you explain to them exactly what is missing. | 18:59 |
| hemna | ok I can try. | 18:59 |
| jungleboyj | I guess you are looking for something I haven't worried about before. | 18:59 |
| hemna | most of the cert runs dump the contents of cinder.conf at the top | 18:59 |
| hemna | the upside is that the change isn't breaking our FC 3rd party CI runs | 19:00 |
| hemna | which the patch directly changes in brick | 19:00 |
| hemna | so, I Guess as long as it doesn't break that it's cool. | 19:00 |
| jungleboyj | :-) That is a good sign. | 19:00 |
| *** emagana has quit IRC | 19:00 | |
| hemna | if it's broken on S390, meh | 19:00 |
| *** emagana has joined #openstack-cinder | 19:01 | |
| *** tbarron has quit IRC | 19:01 | |
| *** dustins_ has joined #openstack-cinder | 19:01 | |
| hemna | looking through the tempest logs to see if it even tests copy volume <---> image | 19:01 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Preserve usage and reservations on quota deletion https://review.openstack.org/162722 | 19:02 |
| *** tbarron has joined #openstack-cinder | 19:03 | |
| *** tbarron has quit IRC | 19:05 | |
| *** dustins has quit IRC | 19:05 | |
| openstackgerrit | Kallebe Monteiro proposed openstack/cinder: Replace assertEqual(True, *) -> assertTrue(*) https://review.openstack.org/162725 | 19:05 |
| *** emagana has quit IRC | 19:06 | |
| *** Longgeek has joined #openstack-cinder | 19:08 | |
| anish | mtanino: pong | 19:09 |
| hemna | jungleboyj, crap, it looks like our FC driver CI tests are skipping the test_volume_upload tempest tests | 19:09 |
| mtanino | anish: hi | 19:09 |
| anish | sup | 19:09 |
| hemna | jungleboyj, so I take back what I said about it not breaking FC volume <--> image operations. | 19:09 |
| hemna | jungleboyj, it's unknown now. | 19:10 |
| hemna | jungleboyj, I'm trying to track down why we are skipping those. | 19:10 |
| hemna | jungleboyj, I'll check out the fc storwize output and see if you guys have it | 19:10 |
| mtanino | anish: Could you let me know what the problem happens at https://bugs.launchpad.net/cinder/+bug/1422095 | 19:11 |
| openstack | Launchpad bug 1422095 in Cinder "tgt driver does not handle file open/read errors correctly" [Undecided,In progress] - Assigned to Anish Bhatt (anish7) | 19:11 |
| hemna | jungleboyj, crap, storewize CI is also skipping it. | 19:11 |
| hemna | jungleboyj, so I have no way to verify this hasn't broken FC copy volume<-->image looking at 3rd party CI results | 19:11 |
| mtanino | anish: I'm thinking about your comment on my IET patch, and I couldn't get the reason why we need to handle IOError. | 19:12 |
| *** Longgeek has quit IRC | 19:12 | |
| *** _cjones_ has joined #openstack-cinder | 19:12 | |
| anish | mtanino: if the file exists but open fails, we proceed on assuming file does not exist | 19:12 |
| mtanino | anish: more comments are helpful for my understanding :) | 19:12 |
| *** sgotliv has quit IRC | 19:13 | |
| *** Ilja has joined #openstack-cinder | 19:13 | |
| anish | mtanino: so I hit this issue when I was writing the cxt helper | 19:14 |
| jungleboyj | hemna: :-( Well, lets see if they can run again and get us results. | 19:14 |
| anish | but I do not have a good way to reproduce it (because I am not sure what caused it in the first place) | 19:14 |
| mtanino | anish: permission denied or someting like that? | 19:14 |
| *** BharatK has quit IRC | 19:15 | |
| anish | mtanino: sadly cannot recall :( | 19:15 |
| hemna | jungleboyj, ok | 19:15 |
| mtanino | anish: What happens if we proceed to create new file and new chap auth if open fails? | 19:16 |
| *** sgotliv has joined #openstack-cinder | 19:16 | |
| hemna | jungleboyj, xyang lunch....bbiab. | 19:16 |
| anish | mtanino: well that is the issue | 19:16 |
| anish | if you look at create_iscsi_target, it opens in w+ mode | 19:16 |
| anish | so it will overrite the file if it exists | 19:17 |
| anish | but if open failed because of something like persmissions | 19:17 |
| anish | this will fail as well | 19:17 |
| anish | maybe if the file was just corrupted or something | 19:17 |
| *** bkopilov has quit IRC | 19:17 | |
| anish | it won't | 19:17 |
| anish | kinda makes the behaviour unpredictable | 19:17 |
| anish | so I thought catching it in get_target_chap_auth() makes more sense | 19:17 |
| mtanino | anish: as a result? | 19:17 |
| jungleboyj | hemna: Ok. +2 from me on multi-attach. | 19:18 |
| anish | mtanino: so basically trying to avoid unpredictable behaviour | 19:18 |
| mtanino | anish: hmm | 19:19 |
| mtanino | anish: I understand you intended to change the get_target_chap_auth() behaviour using raise when fails to handle the file. | 19:22 |
| anish | yes | 19:22 |
| eharney | xyang: i thought we were avoiding creating blueprints for each "driver X implements feature Y" | 19:22 |
| mtanino | anish: let me consider. | 19:22 |
| mtanino | anish: thanks | 19:22 |
| anish | anytime ! | 19:23 |
| anish | mtanino: let me know if you come up with a better approach, as https://review.openstack.org/#/c/154713/ is still under review as well | 19:24 |
| xyang | eharney: I think that was changed in Kilo. we have lots of blueprints | 19:26 |
| xyang | eharney: I'm ok with it either way. it is a very small change. but should check with thingee | 19:27 |
| smcginnis | I thought we just didn't need specs for these kinds of things. | 19:27 |
| eharney | xyang: so the expectation is each driver gets its own thin provisioning changes blueprints..? | 19:27 |
| jungleboyj | eharney: Yeah, that was John's approach but not Mike's. | 19:27 |
| eharney | yeah and it was a mess and i thought we decided to do something different... | 19:27 |
| xyang | eharney: so both pure and vnx have blueprints for that | 19:27 |
| xyang | eharney: personally I'm ok with or without blueprint | 19:27 |
| jungleboyj | xyang: +1 | 19:28 |
| eharney | we need to write this stuff down somewhere :) | 19:28 |
| *** BharatK has joined #openstack-cinder | 19:28 | |
| xyang | eharney: +1 | 19:29 |
| kallebe | Hello. So is tomorrow really the last day for patches to be merged? My commit fixes a relatively serious bug in SAN driver. I would appreciate if some other core reviewer gave the other +2 https://review.openstack.org/#/c/162281/ Thanks | 19:29 |
| xyang | kallebe: that is for new features, not for bug fix | 19:29 |
| kallebe | xyang oh, sorry. My bad. Thanks for the info. | 19:30 |
| jungleboyj | :-) Fear not, only part of the sky is falling. | 19:30 |
| hemna | jungleboyj, xyang back | 19:32 |
| jungleboyj | hemna: Front | 19:32 |
| *** tbarron has joined #openstack-cinder | 19:33 | |
| anish | mtanino: interestingly, ietadm is already present in driver.py :) | 19:33 |
| mtanino | anish: so we have to implement it :) | 19:34 |
| anish | hehe | 19:35 |
| *** tbarron has quit IRC | 19:35 | |
| *** e0ne has joined #openstack-cinder | 19:38 | |
| *** IanGovett has quit IRC | 19:39 | |
| *** tbarron has joined #openstack-cinder | 19:41 | |
| xyang | hemna, jungleboyj: still waiting for Jenkins | 19:42 |
| xyang | jungleboyj, hema: about this https://review.openstack.org/#/c/144590/. There's no cinderclient patch yet. I don't how he tested it | 19:43 |
| *** tbarron has quit IRC | 19:43 | |
| *** thingee has joined #openstack-cinder | 19:44 | |
| *** emagana has joined #openstack-cinder | 19:45 | |
| jungleboyj | Yeah, Not sure about that one. | 19:45 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Preserve usage and reservations on quota deletion https://review.openstack.org/162722 | 19:46 |
| hemna | gate-cinder-python27 failed | 19:46 |
| jungleboyj | Just the fact that it doesn't pass unit test at this point is bad. | 19:46 |
| xyang | jungleboyj: I asked about it but he said he doesn't have any. hemna: yes, unit test failed too | 19:46 |
| thingee | eharney, xyang: I asked for bps for each driver feature, because I felt like we were oversubscribing ourselves and not realizing it | 19:46 |
| thingee | there's no tracking otherwise | 19:46 |
| hemna | cinder.tests.api.contrib.test_snapshot_unmanage.SnapshotUnmanageTest.test_unmanage_snapshot_ok | 19:46 |
| hemna | fail | 19:46 |
| eharney | ah, ok | 19:46 |
| *** annegentle has joined #openstack-cinder | 19:46 | |
| hemna | yah that has to get fixed | 19:46 |
| xyang | jungleboyj, hemna: unit test failure was from the new tests he added | 19:47 |
| *** annashen has quit IRC | 19:47 | |
| thingee | eharney: but I don't need a spec. just a simple thing for me to target and keep track of is good enough for me | 19:47 |
| xyang | thingee: ok | 19:47 |
| jungleboyj | There is thingee ! | 19:47 |
| eharney | thingee: ok, thanks | 19:47 |
| hemna | thingee, !! | 19:47 |
| jungleboyj | thingee: Can things still merge tomorrow or today is the last day? | 19:47 |
| thingee | jungleboyj: tomorrow is fine :) | 19:48 |
| hemna | shhh chill guys, dad is back home... | 19:48 |
| xyang | thingee: eharney: I'm fine with the oversubscription one as it is so small | 19:48 |
| thingee | hemna: lol | 19:48 |
| * thingee is at the ops midcycle meetup | 19:48 | |
| jungleboyj | thingee: Excellent. Don't feel bad about the comments I am making today. | 19:48 |
| thingee | I have some good feedback that I would like to share with you all once I have a chance. | 19:48 |
| hemna | sweet | 19:48 |
| jungleboyj | hemna: I picture us all running to thingee ... thingee 's home! | 19:48 |
| hemna | :) | 19:49 |
| xyang | thingee: :) | 19:49 |
| thingee | k3 is looking pretty good. ttx was really happy with how much progress we made. | 19:49 |
| thingee | might be a record :P | 19:49 |
| xyang | thingee: jungleboyj, hemna and I were just talking about the import/export snapshot patch. we don't know how he tested this without cinderclient change | 19:50 |
| hemna | xyang, manually constructed curl calls? | 19:50 |
| xyang | thingee: https://review.openstack.org/#/c/144590/ | 19:50 |
| *** kallebe has left #openstack-cinder | 19:50 | |
| xyang | hemna: that's possible | 19:50 |
| thingee | xyang: is there cinderclient changes proposed? | 19:51 |
| xyang | thingee: there is none. | 19:52 |
| xyang | thingee: I asked for it. He said he will propose it after the server side is merged | 19:52 |
| xyang | thingee: normally people will propose both | 19:52 |
| thingee | ok, yeah curl is all I can think of. Though you shouldn't use curl. that'll hurt your head. I recommend httpie :) https://github.com/jakubroztocil/httpie | 19:52 |
| thingee | xyang: yeah that's weird | 19:53 |
| xyang | thingee: so I'm worried that he didn't really test it | 19:53 |
| jungleboyj | Also kind-of a big change to be dropping right now. | 19:54 |
| thingee | yeah doesn't make much sense. People will unlikely use. I would just ask for the cinderclient stuff now. | 19:54 |
| thingee | it shouldn't be too hard since there's already code for import/export volumes | 19:54 |
| xyang | thingee: sure. | 19:55 |
| openstackgerrit | Brianna Poulos proposed openstack/cinder: Add project_id to barbican keymgr wrapper https://review.openstack.org/155875 | 19:56 |
| xyang | thingee: multiattach looks good now. you want to take a look? https://review.openstack.org/#/c/85847/ | 19:57 |
| *** leeantho_ has joined #openstack-cinder | 19:58 | |
| *** tbarron has joined #openstack-cinder | 19:58 | |
| thingee | xyang: thanks, yeah I haven't looked at it yet. Do we feel really comfortable with this late? | 19:58 |
| thingee | jungleboyj, hemna ^ | 19:59 |
| thingee | as oppose to first thing in L for nova support? | 19:59 |
| jungleboyj | thingee: Which one? Multi-attach? | 19:59 |
| thingee | jungleboyj: yea | 19:59 |
| *** leeantho has quit IRC | 19:59 | |
| jungleboyj | thingee: I am ok with it. Hell of a headache for hemna to keep carrying it. | 20:00 |
| thingee | jungleboyj: understood | 20:00 |
| thingee | is it tested? | 20:00 |
| thingee | I understand there is unmerged nova changes, but it's still possible to test | 20:00 |
| jungleboyj | thingee: The PowerVC team has been working with it. They are going to cherry-pick the pieces and start using it. | 20:00 |
| xyang | thingee: I tested it. It works with the current code | 20:00 |
| hemna | hey jenkins finally came through | 20:01 |
| hemna | phew | 20:01 |
| thingee | xyang: oh tested with an emc driver? | 20:01 |
| xyang | thingee: no, I tested it with lvm driver | 20:01 |
| hemna | it passes the storewize 3rd party CI fwiw | 20:01 |
| *** BharatK has quit IRC | 20:01 | |
| hemna | and the 3par CI | 20:01 |
| thingee | hemna: 3par and storwize have support for it already? | 20:02 |
| thingee | how does it work if the nova changes haven't merged? | 20:02 |
| hemna | I've personally tested against 3par with all of the nova patches and cinderclient patches | 20:02 |
| hemna | to test actual multiple volume attaches | 20:02 |
| hemna | and it works | 20:02 |
| hemna | but we wont' have: nova side, or cinderclient side for Kilo | 20:03 |
| *** Apoorva has quit IRC | 20:03 | |
| jungleboyj | PowerVC has been using it. Pulled the Nova and Cinder patches in and it has been working for their multi-attach needs. | 20:03 |
| hemna | so what we really need to ensure, is that it doesn't break existing paths | 20:03 |
| hemna | my follow up patch adds scheduler changes needed to prevent volume creates for drivers that don't report up multiattach: True | 20:03 |
| hemna | which there will be none for Kilo | 20:04 |
| hemna | it defaults to False | 20:04 |
| hemna | so if someone injects the multiattach flag in the cinder create API, it will report no host found. | 20:04 |
| thingee | hemna: yes, that's what I'm worried about with this being so late. There's not really a gain right now except it being there without a doubt to the nova team. But I think we can commit together to get this in first thing of L to back you up on the nova side. | 20:04 |
| hemna | that's the part that Duncan wanted. | 20:04 |
| hemna | the gain is that I can focus on getting the nova and cinderclient part to land early L | 20:04 |
| hemna | otherwise we are back to ground zero yet again | 20:05 |
| hemna | same issue I've faced the last 3 OpenStack releases. | 20:05 |
| *** tbarron has quit IRC | 20:06 | |
| hemna | the shadow tables patch landing in K is going to cause even more pain with this patch. | 20:06 |
| thingee | to be fair, two releases ago was april. that was also pretty late. Don't remember the history with juno though. | 20:06 |
| *** e0ne has quit IRC | 20:06 | |
| hemna | which is yet another reason I'm trying to get this to land before the shadow tables patch lands | 20:06 |
| *** e0ne has joined #openstack-cinder | 20:06 | |
| hemna | that basically doubles any effort anyone has to do with DB changes. | 20:06 |
| hemna | which completely sucks. | 20:06 |
| thingee | rather, it was submitted in april for icehouse, which was late. | 20:07 |
| thingee | juno I'm not sure what happened. | 20:07 |
| hemna | it's the same thing that happens every release | 20:07 |
| hemna | nova's time schedule is impossible to meet. | 20:07 |
| jungleboyj | thingee: It is always Nova that has held it out. | 20:07 |
| hemna | and cinder patches are held hostage until nova lands | 20:07 |
| hemna | but nova won't land unless cinder lands | 20:07 |
| hemna | rinse, lather, repeat. | 20:07 |
| hemna | 3 releases later... | 20:07 |
| thingee | yeah but we won't. We'll can merge it first thing in L. I'm just really worried about existing stuff still working :( | 20:07 |
| jungleboyj | thingee: My $0.02 is that showing good faith in it now will help the Nova cause. | 20:08 |
| hemna | existing stuff does work | 20:08 |
| hemna | or CI would be failing | 20:08 |
| *** ndipanov has joined #openstack-cinder | 20:08 | |
| *** Apoorva has joined #openstack-cinder | 20:09 | |
| xyang | thingee: so I tested attach volume and launch VM from boot volume works with existing stuff | 20:09 |
| thingee | hemna: you just said earlier "13:03:17 hemna | so what we really need to ensure, is that it doesn't break existing paths" | 20:09 |
| xyang | CI tests them as well | 20:09 |
| hemna | and for the record, it's only "late" because no one has helped me do reviews on it. | 20:09 |
| thingee | hemna: that scares me :) | 20:09 |
| hemna | it's not like the patch hasn't been up for...oh...a year for people to look at. | 20:09 |
| thingee | especially a day and a half before cut | 20:10 |
| hemna | thingee, that's what CI is for no? | 20:10 |
| hemna | and CI is passing | 20:10 |
| *** Lee1092 has quit IRC | 20:10 | |
| hemna | if we don't trust out CI, then we have other problems. | 20:10 |
| thingee | well then why did you say that? It just worried me is all | 20:10 |
| thingee | I'm taking your words :P | 20:10 |
| *** tbarron has joined #openstack-cinder | 20:11 | |
| hemna | It was just a logical explanation of where we are with it, and what the importance of the patch is today. | 20:11 |
| hemna | since we aren't getting the nova side to land and not the cinderclient side to land | 20:11 |
| hemna | hence, the importance on not breaking existing code. | 20:11 |
| hemna | which is why we look at the CI results | 20:11 |
| hemna | if we find issues, I fix them or we revert it. | 20:12 |
| hemna | simple as that. | 20:12 |
| thingee | I get there is a CI hemna. I'm just taking your words of you still wanting to "ensure" that it doesn't break existing paths. | 20:12 |
| hemna | but if your primary concern is the timing of landing patches right now, then all new feature patches should get -2 today then. | 20:12 |
| thingee | hemna: this is a big patch + touches a crucial part of Cinder. | 20:13 |
| thingee | kind of different than import/export snapshots | 20:13 |
| thingee | which is one endpoint and standalone | 20:13 |
| thingee | not attaching | 20:13 |
| hemna | so what do you want me to do then? | 20:13 |
| hemna | I've been very attentive to this patchset trying to get people to review it and land. | 20:14 |
| *** tbarron has quit IRC | 20:14 | |
| smcginnis | Just my 2c, I'd like to see multiattach land now so we have time to work with it right away in L. | 20:14 |
| * smcginnis goes back to his corner. | 20:14 | |
| thingee | hemna: I think you've done everything you can. I think the community needs to make a decision though and it seems like people are ok with this going in regardless and feel comfortable. | 20:14 |
| hemna | if you are worried, pull the patch down and test it yourself against lvm | 20:15 |
| hemna | xying did that | 20:15 |
| hemna | I've done it | 20:15 |
| hemna | I just don't know what else to do, to get a patch to land in Cinder. | 20:15 |
| * hemna is frustrated | 20:15 | |
| thingee | I believe you all tested it. I just haven't looked at the code myself. I know what it touches though, so it was my concern of something big like this might be scary. and again I'll repeat for 1000th time I was taking your own words of how you felt about it | 20:17 |
| thingee | I'm not trying to twist your words. You wanted to ensure exisitng paths still work. | 20:18 |
| hemna | yes of course, I am the first person to tell you I don't want to break anything | 20:18 |
| hemna | but I also don't want to work on this for another 3 releases | 20:18 |
| openstackgerrit | Erlon R. Cruz proposed openstack/cinder: Adds pool aware scheduling for HNAS drivers https://review.openstack.org/142133 | 20:18 |
| hemna | doing the cinder <--> Nova, chicken and egg dance | 20:18 |
| hemna | it's just not worth it at a certain point. | 20:19 |
| *** leeantho_ has quit IRC | 20:19 | |
| *** leeantho has joined #openstack-cinder | 20:19 | |
| thingee | I'll still review it, but it's my recommendation to wait to early L. I don't think the rebase and push immediate in L for testing a how dev cycle is really a bad idea. | 20:19 |
| thingee | testing for a whole* | 20:19 |
| hemna | then, I'm going to -2 the shadow tables patch then | 20:20 |
| hemna | because that causes a lot of problems for devs doing DB work | 20:20 |
| hemna | *sigh* | 20:20 |
| xyang | thingee: I think the problem is people always tend to wait until last minute. so even if you target L-1, it could be pushed to L-3 again | 20:20 |
| thingee | xyang: can we not all commit to making this happen early for hemna ? | 20:21 |
| hemna | the rebase with the shadow tables will be hell. | 20:21 |
| xyang | xyang: I support it, but that is not enought:) | 20:21 |
| hemna | bleh | 20:21 |
| hemna | katco, I have to run to a meeting. you guys decide what you think is right. | 20:22 |
| hemna | gah | 20:22 |
| hemna | s/katco/k | 20:22 |
| thingee | xyang: I really avoid making promises, but I would promise to review it early and get it merged. that would two +2's with the both us. | 20:22 |
| *** hemna is now known as hemnafk | 20:22 | |
| thingee | if people are unsure about shadow tables this late, I agree as core you should say not right now. | 20:23 |
| katco | did i get pinged on mistake? | 20:23 |
| katco | *by mistake? | 20:23 |
| thingee | katco: yea | 20:23 |
| katco | ah ok | 20:23 |
| katco | happy hacking :) | 20:23 |
| thingee | :) | 20:23 |
| e0ne | thingee: the main consern about shadow tables - it makes db migrations more complicated:( | 20:24 |
| thingee | jungleboyj, hemnafk: xyang: that's just my recommendation though. The community doesn't haven't to act on my thoughts and I'll still review this patch today, but I really would rather have us all commit to getting it merged as soon as the cinder version change commit goes through for L. | 20:24 |
| *** rajinir has joined #openstack-cinder | 20:26 | |
| *** tbarron has joined #openstack-cinder | 20:26 | |
| openstackgerrit | Brianna Poulos proposed openstack/cinder: Add project_id to barbican keymgr wrapper https://review.openstack.org/155875 | 20:26 |
| e0ne | i'm ok if we delay my patch for L, but this won't make db migration patches more easy after my patch lands | 20:26 |
| rajinir | Is there a plan to merge pending reviews before code freeze? | 20:26 |
| e0ne | rajinir: what reviews do you mean? | 20:27 |
| rajinir | I want to get mine merged https://review.openstack.org/#/c/161310/ | 20:27 |
| thingee | rajinir: just bug fixes, so that should be fine | 20:27 |
| e0ne | rajinir: it's a bugfix. it will be acceptable after feature code freeze | 20:27 |
| rajinir | ok, thanks | 20:27 |
| thingee | rajinir: see the full announcement here http://lists.openstack.org/pipermail/openstack-dev/2015-February/056964.html | 20:28 |
| jungleboyj | I have to drop for a bit. I am still in support of hemnafk 's patch going in now, but of course will help it go in first thing in L if that is what is decided. | 20:28 |
| jungleboyj | Back in about 30 min. | 20:29 |
| *** tbarron has quit IRC | 20:30 | |
| *** IanGovett has joined #openstack-cinder | 20:30 | |
| *** aix has quit IRC | 20:31 | |
| thingee | jungleboyj, hemnafk, xyang: https://review.openstack.org/#/c/85847/ | 20:33 |
| thingee | I've posted my thoughts, not a review yet. | 20:33 |
| *** jungleboyj has quit IRC | 20:33 | |
| *** annashen has joined #openstack-cinder | 20:35 | |
| *** tbarron has joined #openstack-cinder | 20:35 | |
| thingee | tbarron: you're running out of time with this https://review.openstack.org/#/c/149725/ :) | 20:38 |
| xyang | thingee: ok, thanks. | 20:41 |
| *** Yogi1 has joined #openstack-cinder | 20:42 | |
| *** rlucio has joined #openstack-cinder | 20:45 | |
| *** Mandell has quit IRC | 20:46 | |
| *** akerr has quit IRC | 20:47 | |
| *** bswartz has quit IRC | 20:52 | |
| *** emagana has quit IRC | 21:02 | |
| *** Yogi1 has quit IRC | 21:02 | |
| *** emagana has joined #openstack-cinder | 21:02 | |
| *** jungleboyj has joined #openstack-cinder | 21:03 | |
| thingee | show and tell happening at the ops midcycle meetup. lets see if Cinder gets mentioned =S | 21:04 |
| jungleboyj | thingee: :-) | 21:05 |
| jungleboyj | What else could they talk about? | 21:06 |
| *** emagana has quit IRC | 21:07 | |
| *** lpetrut has quit IRC | 21:10 | |
| jungleboyj | tbarron: How is your refactoring going? | 21:11 |
| *** thangp has quit IRC | 21:14 | |
| *** leeantho_ has joined #openstack-cinder | 21:15 | |
| jungleboyj | hemnafk: When you have a chance, can you look at this again: https://review.openstack.org/#/c/157956/2 | 21:17 |
| *** leeantho has quit IRC | 21:17 | |
| *** dustins_ has quit IRC | 21:27 | |
| *** hodos has joined #openstack-cinder | 21:29 | |
| *** hemnafk is now known as hemna | 21:33 | |
| hemna | so jungleboyj looks like you need to update fileutils.py then and it's ok ? | 21:33 |
| jungleboyj | Yeah. I am testing the patch right now. | 21:33 |
| jungleboyj | For some reason a couple of those oslo.utils were inlcuded in the list of changes but didn't make it to the patch. | 21:34 |
| hemna | e0ne, | 21:36 |
| * e0ne doesn't sleep yet | 21:37 | |
| e0ne | hemna: hi. do you hace question about multi attash or shadow tables? | 21:38 |
| hemna | so, yah the shadow tables thing keeps bugging me | 21:38 |
| e0ne | s/hace/have | 21:38 |
| e0ne | what do you mean? | 21:39 |
| hemna | the entire purpose of it is to allow an admin to offload the 'deleted' rows in the db to other tables | 21:39 |
| hemna | the help performance, indexing etc yah? | 21:39 |
| e0ne | yes | 21:39 |
| hemna | so, is there a way we can do that w/o putting 2x the burden on the cinder devs ? | 21:39 |
| e0ne | and this is needed if admin/operator doesn't want to delete it at all | 21:39 |
| *** hodos|2 has joined #openstack-cinder | 21:39 | |
| hemna | why not a cinder-manage tool that does this in one shot | 21:39 |
| hemna | meaning it basically does this as a one time shot, right now, when an admin asks for it. | 21:40 |
| hemna | have the tool ask for another db instance and then it goes through all the work of creating shadow tables for the existing schema and migrate the data | 21:41 |
| hemna | instead of forcing every cinder patch that touches the DB to always keep 2 copies of everything in sync. | 21:41 |
| hemna | it's going to be hell for patches like multiattach | 21:42 |
| hemna | so, the tool does all the work, when asked to do it | 21:42 |
| hemna | and cinder doesn't actually create any shadow tables, and migration itself. | 21:42 |
| hemna | only the tool does it at the time the admin asks for it. | 21:42 |
| e0ne | personaly, i like the idea to make such changes once per release | 21:42 |
| *** hodos has quit IRC | 21:43 | |
| hemna | then there are no changes to cinder's development cycle, unit tests, db migration, db migration tests, etc. | 21:43 |
| hemna | we could even add a unit test for the shadow table tool | 21:43 |
| jungleboyj | hemna: If there is a way to do that +2 | 21:43 |
| e0ne | i'm not sure that modification production db schema is acceptable for many of operators | 21:43 |
| hemna | I really don't like the idea of forcing cinder dev's to continually maintain cinder tables and shadow tables, schema, data | 21:44 |
| hemna | e0ne, if that's the case, then doing upgrades is also not acceptable | 21:44 |
| hemna | as upgrades do exactly that. | 21:44 |
| e0ne | but you don't do upgrates often | 21:45 |
| * jungleboyj is watching my son trying to learn to dive and can't figure out why kicking his ligs out is so baffling to him. | 21:45 | |
| e0ne | it's a planned maintenance | 21:45 |
| jungleboyj | s/ligs/legs | 21:45 |
| hemna | every time you upgrade a version of cinder. | 21:45 |
| hemna | and that's also to my point. | 21:45 |
| hemna | every upgrade is going to automatically touch their data, and move their data | 21:45 |
| hemna | shouldn't we leave that up to the operator to decide when they want their data moved? | 21:45 |
| e0ne | sure | 21:45 |
| *** chlong has joined #openstack-cinder | 21:46 | |
| hemna | hence the tool | 21:46 |
| hemna | put all the burden on the tool | 21:46 |
| hemna | not on cinder | 21:46 |
| hemna | it seems very strange to force devs to be updating shadow tables | 21:47 |
| hemna | which are really archive tables a the time you archive the data. | 21:47 |
| hemna | because in the case of multiattach | 21:47 |
| hemna | we are creating a new table, and moving data to it. | 21:47 |
| hemna | it doesn't make sense to have to migrate old shadow table data | 21:47 |
| e0ne | +1 | 21:47 |
| hemna | when the new table never existed at the time those rows in the volume table were moved to the volume shadow table. | 21:48 |
| openstackgerrit | Mike Perez proposed openstack/cinder: Update Datera's export to avoid deprecated keys https://review.openstack.org/162774 | 21:48 |
| hemna | that seems wrong to me. | 21:48 |
| *** asselin_ has joined #openstack-cinder | 21:48 | |
| hemna | so a side affect of the tool would be that it only archives the scheme and data that exist in the main cinder db now. | 21:48 |
| hemna | meaning that if you run it today, you get shadow tables for today's schema. | 21:49 |
| *** thingee has quit IRC | 21:49 | |
| hemna | and then when you run it 6 months from now, you get the schema of 6 months from now. | 21:49 |
| openstackgerrit | Jay Bryant proposed openstack/cinder: Namespace updates for _i18n and imageutils & fileutils https://review.openstack.org/157956 | 21:49 |
| hemna | and there is no migration from today's shadow tables to 6+ months now shadow tables. | 21:49 |
| hemna | the tool is crazy simple | 21:49 |
| hemna | it's basically what you have in the patch today. | 21:50 |
| hemna | anyway, I just thought about this today in my frustration about the multiattach patch dying. | 21:50 |
| *** pradip_vedams has quit IRC | 21:51 | |
| smcginnis | hemna: That does seem safer long term. | 21:51 |
| *** kaufer has quit IRC | 21:51 | |
| *** pradip_vedams has joined #openstack-cinder | 21:51 | |
| hemna | yah I think so as well | 21:51 |
| jungleboyj | Yeah, good though and then it is only an impact for those who want to use it. | 21:51 |
| e0ne | i feel like something went wrong with shadow tables | 21:51 |
| hemna | yup | 21:51 |
| hemna | well I think what shadow tables is trying to solve is good | 21:52 |
| *** jdurgin has quit IRC | 21:52 | |
| hemna | help DB performance from deteriorating over time. | 21:52 |
| hemna | no reason to index rows that will never come up | 21:52 |
| jungleboyj | Yeah, it is a good idea. | 21:52 |
| hemna | but adding 2x the burden on devs to maintain it forever forward, is a huge cost IMHO. | 21:52 |
| *** asselin_ has quit IRC | 21:53 | |
| e0ne | hemna: db performance it's consequence rather than a cause | 21:53 |
| e0ne | we've got db purge in master | 21:53 |
| e0ne | as i understand, we need shadow tables for some cinder users who makes any analytics based on db data. e.g for billing | 21:54 |
| hemna | and those same queries can run against the tool created db and tables | 21:55 |
| e0ne | in such case, imo, we don't need uptodate shadow tables | 21:55 |
| hemna | nope | 21:56 |
| jungleboyj | hemna: So you are saying they would go into a separate db?> | 21:56 |
| jungleboyj | I.E. cinder_shadow ? | 21:56 |
| hemna | yah could be | 21:56 |
| hemna | depends on what options you pass into the tool | 21:56 |
| hemna | add db connectivity params and possible table prefix as another option | 21:56 |
| hemna | table_prefix="_walt_sucks_" | 21:57 |
| jungleboyj | Ah, ok, Yeah, give the user flexibility. | 21:57 |
| *** chlong has quit IRC | 21:57 | |
| hemna | so if they really wanted to, they could just use the cinder db, and change their prefix for every run | 21:57 |
| hemna | prefix="_03_2015_" | 21:57 |
| hemna | 6 months from now | 21:58 |
| *** chlong has joined #openstack-cinder | 21:58 | |
| hemna | prefix="_09_2015_" | 21:58 |
| hemna | and the tool ignores any table starting with _ | 21:58 |
| jungleboyj | So, new tables with that prefix would be created as the shadow tables? | 21:59 |
| jungleboyj | In the existing DB. | 21:59 |
| hemna | all existing tables in the current db (at the time of running the tool) would get an equivalent _09_2015_<table name> table | 22:00 |
| jungleboyj | If they don't want to use a different prefix each time, can the data just be appended to existing tables? | 22:00 |
| hemna | and it's archived data | 22:00 |
| hemna | jungleboyj, so no | 22:00 |
| hemna | because the schema changes | 22:00 |
| hemna | and there in lies the rub | 22:00 |
| hemna | and why it sucks to put this on devs now. | 22:00 |
| hemna | in the current patch set for shadow tables | 22:00 |
| hemna | every cinder developer that needs to do db table changes | 22:00 |
| hemna | ALSO has to do shadow table changes | 22:01 |
| hemna | in order for the current patchset's scheme to work. | 22:01 |
| openstackgerrit | Joshua Harlow proposed openstack/cinder: Attempt to see what happens with close-fds patch https://review.openstack.org/162781 | 22:01 |
| hemna | which is very strange | 22:01 |
| jungleboyj | Ah ... gotcha ... So basically turn it into a DB snapshot. | 22:01 |
| hemna | because you are changing a schema for a table who's data has already been archived, and hence it was never in that schema format. | 22:01 |
| hemna | very very strange | 22:01 |
| hemna | jungleboyj, exactly! | 22:01 |
| jungleboyj | hemna: Seems reasonable. One would hope what ever data analysis tooling they have can check more than one set of tables. | 22:02 |
| hemna | yah | 22:02 |
| anish | any chance I get this reviewed pre-cutoff ? https://review.openstack.org/#/c/154713/ | 22:03 |
| anish | (it had 1 +2, but lost it on rebase) | 22:03 |
| jungleboyj | anish: No hurry on that. We aren't cutting off for bugs. | 22:04 |
| *** chlong has quit IRC | 22:04 | |
| jungleboyj | I will take a look later thought. I have to drop of for a bit. | 22:05 |
| *** eharney has quit IRC | 22:06 | |
| e0ne | hemna: i'm almost agree with you | 22:06 |
| anish | aah, cool. makes sense bugs aren't affected by cutoff (I just wasn't aware) | 22:06 |
| hemna | e0ne, :) | 22:06 |
| *** jungleboyj has quit IRC | 22:06 | |
| hemna | anish, no unit tests | 22:06 |
| hemna | yet there are logic changes. | 22:07 |
| hemna | and changes in expected exception behavior | 22:07 |
| anish | erm, this path is already covered by unit tests | 22:07 |
| e0ne | hemna: one more question | 22:07 |
| hemna | the new exceptions being raised where there was none previously? | 22:07 |
| hemna | anish, https://review.openstack.org/#/c/154713/13/cinder/volume/targets/tgt.py | 22:08 |
| hemna | line 143 now raises an exception | 22:08 |
| hemna | where there was none previously | 22:08 |
| anish | I can add a test if you want | 22:08 |
| hemna | yes please | 22:08 |
| anish | but I'm not sure how to fake errors | 22:08 |
| hemna | just need to mock the conditions that lead to those errors | 22:08 |
| e0ne | hemna: did you see https://github.com/openstack/cinder-specs/blame/master/specs/kilo/db-archiving.rst#L61? | 22:08 |
| hemna | that you expect | 22:08 |
| hemna | e0ne, sure | 22:09 |
| e0ne | "Shadow tables could have blob field to store some "deleted" data and to not impose restrictions on database schema changes." | 22:09 |
| hemna | that will get pulled when the tool runs as well. | 22:09 |
| hemna | blobs are ugly for archiving | 22:09 |
| hemna | because they can be very difficult to search/index on | 22:10 |
| anish | hemna: can you point me to an example of such a negative test ? | 22:10 |
| *** gugl has joined #openstack-cinder | 22:10 | |
| hemna | there are all kinds of negative tests in test_volume.py | 22:11 |
| hemna | self.assertRaises(.... | 22:11 |
| e0ne | hemna: agree about index/search in almost all DBs | 22:11 |
| anish | hemna: to make sure I am getting this correctly. The test case would be raise foo error by mocking open, then asserting self.assertRaises(foo) | 22:14 |
| anish | which just seems like a generic way to check that the raise wasn't swallowed somewhere in the call path | 22:14 |
| anish | is that correct ? | 22:14 |
| hemna | there are 2 conditions there | 22:15 |
| hemna | one happens at IOError | 22:15 |
| *** xyang has quit IRC | 22:15 | |
| hemna | if e_fnf.errno != 2 | 22:15 |
| anish | yes. I'll be checking both | 22:15 |
| hemna | and a more general exception | 22:15 |
| hemna | should test for both of those happening. | 22:15 |
| anish | ko ! | 22:15 |
| hemna | a la raise a non IOError | 22:15 |
| hemna | make sure you see that | 22:15 |
| hemna | and then test the != 2 raising of the IOError | 22:16 |
| hemna | good to go | 22:16 |
| *** ganso_ has quit IRC | 22:17 | |
| *** hodos|2 has quit IRC | 22:17 | |
| *** rushiagr_away has quit IRC | 22:18 | |
| *** annegentle has quit IRC | 22:19 | |
| *** annegentle has joined #openstack-cinder | 22:21 | |
| *** theanalyst has quit IRC | 22:21 | |
| e0ne | hemna: i'm almost agree with you about developers impact. it's not a best solution | 22:21 |
| e0ne | from other point of view, 'db snapshot tool' is out of scope of cinder. it should/could be based on oslo.db or be a stand-alone tool | 22:22 |
| e0ne | i need to re-think current implementaion | 22:23 |
| rhagarty | eOne: if you get a chance, could you revisit https://review.openstack.org/#/c/140906/ - you note that you will +2 once the blueprint is approved, which it has | 22:23 |
| *** openstack has joined #openstack-cinder | 22:26 | |
| *** annegentle has quit IRC | 22:26 | |
| *** annegentle has joined #openstack-cinder | 22:27 | |
| *** Thelo has quit IRC | 22:27 | |
| *** [1]Thelo is now known as Thelo | 22:27 | |
| e0ne | rhagarty: hi. i'll take a look on it tomorrow morning | 22:29 |
| rhagarty | Thanks - much appreicated | 22:29 |
| e0ne | hemna: i'll update my patch with comments tomorrow. i can't get better idea now than do something we have for migration tests in the past | 22:33 |
| e0ne | i mean something like https://github.com/openstack/nova/blob/72b2555339e5aa24551e3171134412d8d23a8bff/nova/db/sqlalchemy/migrate_repo/versions/253_add_pci_requests_to_instance_extra_table.py#L28 | 22:34 |
| *** rushil has quit IRC | 22:35 | |
| *** Mandell has joined #openstack-cinder | 22:36 | |
| hemna | e0ne, also, I had just thought of another thing for the tool | 22:40 |
| hemna | at the time you run the tool you know the schema version | 22:40 |
| hemna | you can compare that to the schema version of any existing shadow tables | 22:40 |
| hemna | from the last run | 22:40 |
| hemna | if they are the same, then bingo, you can just reuse the previous run's tables. | 22:41 |
| *** IanGovett has quit IRC | 22:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/157642 | 22:41 |
| *** jcru has quit IRC | 22:42 | |
| e0ne | hemna: i'm so sorry, need to sleep for a while :( | 22:51 |
| hemna | e0ne, no worries. night man! | 22:51 |
| *** lcurtis has quit IRC | 22:51 | |
| e0ne | i'll try to rebase your patch on my one and implement migrations as nova does | 22:51 |
| e0ne | and wee need to think how it could be implemented in oslo.db | 22:52 |
| hemna | yah | 22:52 |
| hemna | ok sounds good. lets think about the tool idea as well | 22:52 |
| e0ne | to try remove developers impact | 22:52 |
| hemna | yah | 22:52 |
| hemna | that's a really big burden | 22:52 |
| e0ne | the tool should be implemented out of scope of cinder, imho | 22:53 |
| hemna | could be | 22:53 |
| e0ne | because we've got the same troubles in other projects with soft deletes | 22:53 |
| hemna | a general purpose tool/solution would be awesome in that case then. | 22:53 |
| e0ne | absolutely agree | 22:54 |
| hemna | I know nova is polluted with shadow_tables | 22:54 |
| hemna | kinda sucks for doing raw db debugging | 22:54 |
| hemna | show tables....100 tables | 22:54 |
| hemna | bleh! | 22:54 |
| *** esker has quit IRC | 22:54 | |
| anish | if I'm mock_foo.side_effect = exception.IOError, anyone know how to set IOError.errno ? | 22:54 |
| anish | *if I'm setting | 22:54 |
| *** bswartz has joined #openstack-cinder | 22:56 | |
| e0ne | hemna: so, is current "nova way" an option for you? | 22:57 |
| hemna | I'm not sure I know what the nova way is | 22:57 |
| hemna | I'd prefer to never see shadow tables in cinder | 22:57 |
| e0ne | :) | 22:57 |
| hemna | and make it an admin thing | 22:57 |
| hemna | but give admins the tools to do it. | 22:57 |
| e0ne | i mean how migrations in nova is implemented | 22:58 |
| hemna | honestly there is nothing from preventing smart admins that care from doing it today manually. | 22:58 |
| hemna | e0ne, I'm not overly familiar with how nova is doing it | 22:58 |
| hemna | is it the same as your current proposal? | 22:58 |
| hemna | putting the changes in each db migration version? | 22:59 |
| e0ne | yes, i've posted a sample: https://github.com/openstack/nova/blob/72b2555339e5aa24551e3171134412d8d23a8bff/nova/db/sqlalchemy/migrate_repo/versions/253_add_pci_requests_to_instance_extra_table.py#L28 | 22:59 |
| hemna | so that's also modifying existing shadow tables | 22:59 |
| hemna | it looks like | 22:59 |
| hemna | which I think is really strange to do | 22:59 |
| hemna | I think of them as snapshot tables | 23:00 |
| hemna | dunno | 23:00 |
| hemna | so that mechanism works if all you are doing is adding a new column | 23:00 |
| hemna | but when you are dropping a column from one table and moving it to another | 23:01 |
| hemna | kinda gets nasty | 23:01 |
| hemna | (which is what I have to do for multiattach) | 23:01 |
| e0ne | understood, i'll test it tomorrow | 23:02 |
| *** ronis has quit IRC | 23:02 | |
| *** annegentle has quit IRC | 23:03 | |
| * e0ne bb in ~10-12 hours | 23:03 | |
| hemna | night! | 23:03 |
| *** Mandell has quit IRC | 23:05 | |
| *** rajinir has quit IRC | 23:07 | |
| *** tbarron has quit IRC | 23:07 | |
| *** hemna is now known as hemnafk | 23:08 | |
| *** e0ne has quit IRC | 23:13 | |
| *** annashen has quit IRC | 23:14 | |
| *** annashen has joined #openstack-cinder | 23:14 | |
| *** Mandell has joined #openstack-cinder | 23:15 | |
| *** openstack has joined #openstack-cinder | 23:25 | |
| vilobhmm1 | thangp : u there ? | 23:34 |
| *** annashen has quit IRC | 23:39 | |
| *** annashen has joined #openstack-cinder | 23:39 | |
| *** Guest82873 has quit IRC | 23:41 | |
| *** chlong has joined #openstack-cinder | 23:43 | |
| *** annashen has quit IRC | 23:44 | |
| *** topshare has joined #openstack-cinder | 23:45 | |
| *** _cjones_ has quit IRC | 23:45 | |
| *** annashen has joined #openstack-cinder | 23:45 | |
| *** _cjones_ has joined #openstack-cinder | 23:48 | |
| *** topshare has quit IRC | 23:52 | |
| *** topshare has joined #openstack-cinder | 23:52 | |
| *** topshare has quit IRC | 23:53 | |
| *** tbarron has joined #openstack-cinder | 23:57 | |
| openstackgerrit | Bob Callaway proposed openstack/cinder: NetApp implement lun and initiator os config options https://review.openstack.org/162376 | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!