Wednesday, 2015-02-25

casusbellijgriffith: Hi! I'm still banging at sos-ci. Just wanted to ask what machine and what images are u using?00:00
jgriffithcasusbelli: I'm running a super-micro box, with Juno deployed on it00:00
mtreinishwhich seems like a big statement00:00
jgriffithmtreinish: yeah, that's why I haven't done it already00:00
casusbellijgriffith: I've serious performance issues, wheel venv buildup takes 1.5 hours...00:00
jgriffithmtreinish: FWIW, do multi-node and these problems "disappear"00:00
jgriffithmtreinish: http://goo.gl/JQ9ots00:01
jgriffithmtreinish: so that's "an" issue00:01
jgriffithmtreinish: the problem is I stopped what I was going to propose because it screws up existing/expected behavior00:01
casusbellijgriffith: are you using ubuntu cloud images on the internal devstack?00:02
jgriffithmtreinish: need to put something together to keep track of the attachment and put it back in place for the user00:02
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick: Fix comments style according to Hacking rules  https://review.openstack.org/15746800:02
jgriffithcasusbelli: yep, ubuntu Trusty00:02
casusbellijgriffith: plain or modified?00:02
jgriffithplain00:03
jgriffithcasusbelli: are you running into an issue?00:03
mtreinishcasusbelli: you're running second level guests with ubuntu?00:03
*** esker has quit IRC00:03
casusbellijgriffith: yeah00:03
jgriffithmtreinish: +100:03
mtreinishs/casusbelli/jgriffith00:03
casusbellijgriffith: x200:03
jgriffithcasusbelli: what's the issue?00:03
casusbellijgriffith: i switched from centos to ubuntu images in order to reduce required changes on the existing sos-ci code00:04
casusbellijgriffith: Issue is primarily performance00:04
mtreinishjgriffith: hmm, ok yeah tracking that would probaly require storing it somewhere. like a new db column or something (without knowing the internals of the rescue operation at all :) )00:04
*** emagana has joined #openstack-cinder00:04
jgriffithcasusbelli: there's no changes... it's just python and ansible00:04
casusbellijgriffith: there's some ansible stuff that expects user 'ubuntu', etc.00:04
casusbellijgriffith: but thath's not the issue00:05
jgriffithmtreinish: yeah... and honestly I thought maybe rather than doing that in Nova (which is *hard* to get in to code) I could create a new cinder API00:05
jgriffithtemporary-detach or something cheesie00:05
jgriffithlike that00:05
*** emagana has quit IRC00:05
casusbellijgriffith: big point is that 2nd level devstack build takes hours, esp. wheel based venv compilation of numpy, etc.00:05
jgriffithso have a special call in Cinder... maybe even rescue00:05
jgriffiththat tells Cinder, detach this... but keep track of it00:05
jgriffithand then an unrescue, that says "put it back the way it was"00:06
mtreinishjgriffith: sure that could work, but we'd need to still teach nova how to do that right?00:06
mtreinishso you'll have to get a nova patch in anyway00:06
jgriffithmtreinish: yeah, but on the nova side it would become a simple method add to nova/volume00:06
*** annashen_ has joined #openstack-cinder00:06
jgriffithmtreinish: but yes, nova patch regardless... but have you seen how difficult it can be to make significant changes to Nova lately :)00:07
casusbellijgriffith: Are you using any special settings for the 1st level devstack VMs? I tried to improve by host-mode'ing the nova vcpus but that did not make much of a difference...00:07
jgriffithcasusbelli: so that has nothing to do with sos, Ubuntu or Cent00:07
jgriffithcasusbelli: sounds like youre network if bad00:07
mtreinishjgriffith: sure, I'm just wondering if we should bully some nova core's like dansmith into helping push this through quickly00:07
casusbellijgriffith: it's on the local machine, devstack in devstack00:07
jgriffithmtreinish: oh... I like that00:07
jgriffithmtreinish: but that means I have to go back to working on it again LOL00:08
jgriffithcasusbelli: does your CPU support nesed virt?00:08
jgriffithcasusbelli: and what I'm saying is this is purely an issue with network time for you to deploy devstack00:09
casusbellijgriffith: Not sure, i7 3770 8 core i think00:09
jgriffithcasusbelli: so the other thing is check out your network on the instance00:09
jgriffithsounds to me like it's painfully slow00:09
mtreinishjgriffith: heh fair point. Tomorrow I can corner dansmith and we can try to get the rescue task force started :)00:09
jgriffithbut if the build is "hours" then you have issues with your VCPU as well.. and perhaps memory00:10
jgriffithhaha... I like that "rescue task force" :)00:10
jgriffithmtreinish: in all seriousness I'm more than happy to work on it00:10
casusbellijgriffith: But e.g. numpy compilation from source takes devstack almost 1 hour, that's while he's compiling the source on 1 to 2 cores, from what i saw00:10
openstackgerritAnish Bhatt proposed openstack/cinder: Add partial unit tests for IET driver  https://review.openstack.org/15892500:10
anishmtanino: ^00:10
jgriffithmtreinish: I'll be offline most of tomorrow but back at it tomorrow night and Thurs00:10
mtaninoanish: hi00:11
jgriffithmtreinish: meanwhile, we seem to have something "bigger" happening in the tempest tests right now00:11
jgriffithso I'll did into that tonight00:11
mtreinishcasusbelli: yeah that sounds like a virt config or other hardware setup issue. It takes me 2-4min to compile it on my desktop00:11
jgriffithI've been hung up for about 8 minutes now.. something died00:11
mtreinishjgriffith: ok, cool. Thanks00:11
*** annashen_ has quit IRC00:11
jgriffithmtreinish: thank you00:11
*** ho__ has joined #openstack-cinder00:13
*** emagana has joined #openstack-cinder00:13
jgriffithcasusbelli: see what I'm saying?00:13
mtaninoanish: nice :)00:14
casusbellijgriffith: hmm, ok. If you're goin' with vanilla ubuntu trusty cloud images, too and the host is not that different it has to be something like that00:14
jgriffithcasusbelli: well.. what i'm saying is that the instance has little to do with what you described00:15
openstackgerritAnish Bhatt proposed openstack/cinder: Simplify cxt test_create_export() unit test  https://review.openstack.org/15892600:15
jgriffithcasusbelli: devstack for the most part is installing a bunch of pip libs and git repos over the network00:15
casusbellijgriffith: Gotta read in more detail about that nested virtualization & co00:15
jgriffithcasusbelli: log on to that instance and do a speed test00:15
casusbellijgriffith: yep, i know. Have been looking over devstacks should for quite some time now. :-D00:15
jgriffithcasusbelli: also... run stack.sh and in another window top00:15
jgriffithcasusbelli: check this guy out: http://goo.gl/cCR8i00:16
jgriffithcasusbelli: also, you never answered, what flavor is your instance?00:16
jgriffithcasusbelli: vcpu cound, mem and disk?00:16
casusbellijgriffith: sry, didn't see that. standard m3 flavor, i think00:17
casusbellijgriffith: but the vm never comes near max RAM or multiple busy vcpus00:17
casusbellijgriffith: it justs dances on 1 or 2 cores and takes hours with the compilation, eventually either timing out or failing to load the sources for one of the wheeled components00:18
anishmtanino: I think you need to manually take back https://bugs.launchpad.net/cinder/+bug/140991800:18
openstackLaunchpad bug 1409918 in Cinder "iet target driver not implemented in new iscsi target driver model" [High,In progress] - Assigned to Anish Bhatt (anish7)00:18
casusbellijgriffith: but i'll check the virt config and thanks for the speed-cli link00:19
mtaninoanish: Ah, if it does not take back after pushing next patch, I will change it. thanks00:22
casusbellijgriffith: Hmm, nested virtualization is definitely something i've been missing out on and that i'm taking a closer look at now00:25
xyang1patrickeast: Hi00:25
*** david-lyle is now known as david-lyle_afk00:25
patrickeastxyang1: hey00:25
xyang1patrickeast: I mixed things up:)00:25
patrickeastxyang1: ahh ok, scared me at first, thought i might have totatlly misunderstood how this was supposed to work :D00:26
xyang1patrickeast: Since used is from ['total'], i used it as denominator00:26
xyang1patrickeast: So it should be 10/100 < 100:27
casusbellijgriffith: ok, the cpu does support this but i've to check if the OS does the ootb00:27
xyang1patrickeast: Provisioned/total < 100:28
patrickeastxyang1: i think the confusing part is the [‘tota’] that comes back from the array is actually our physically used total on the array00:28
patrickeasttotal*00:28
xyang1patrickeast: Ya, that is confusing:)00:28
patrickeastxyang1: ok, cool, so i think we have are doing the right thing, i just confirmed with dannywilson (he sits next to me) and we will go ahead with this algorithm but expand the comments a bit to explain what the fields are00:31
patrickeastxyang1: thanks for all the reviews and support with these changes!00:32
xyang1patrickeast: No problem.  Sorry for the false alarm00:32
*** Apoorva_ has quit IRC00:34
*** Apoorva has joined #openstack-cinder00:35
openstackgerritAnish Bhatt proposed openstack/cinder: Add partial unit tests for IET driver  https://review.openstack.org/15892500:37
casusbellijgriffith: Ok, thanks for the hints, i'm digging into the state of nested virt...00:37
openstackgerritAnish Bhatt proposed openstack/cinder: Simplify cxt test_create_export() unit test  https://review.openstack.org/15892600:40
openstackgerritAnish Bhatt proposed openstack/cinder: Add partial unit tests for IET driver  https://review.openstack.org/15892500:41
anishapologies for the flood00:41
*** timcl has joined #openstack-cinder00:43
jgriffithcasusbelli: I'd recommend just running some tests onyour instance manually first00:45
jgriffithcasusbelli: and I don't know what m.7 translates too at all so I can't offer much there00:45
*** timcl has quit IRC00:45
*** ebalduf has joined #openstack-cinder00:46
*** Ilja has quit IRC00:46
casusbellijgriffith: m.3 is 2vcpus, 4GB RAM and 40GB HD00:48
jgriffithcasusbelli: ok...little light00:49
jgriffithbut should be ok00:49
casusbellijgriffith: and yep, i'll do the manual checks. I helps already that i narrowed it down in this area, previously i did not know if maybe specially prepared images, etc. where  right00:49
casusbellijgriffith: ok :)00:49
*** ebalduf has quit IRC00:50
*** _cjones_ has quit IRC00:51
*** emagana has quit IRC00:53
*** emagana has joined #openstack-cinder00:54
casusbellijgriffith: sry for my rudimentary english, language quality seriously declines after beeing awake and at the desk for almost 20h...00:54
*** emagana has quit IRC00:54
*** emagana has joined #openstack-cinder00:54
casusbellijgriffith: bye00:55
*** casusbelli has quit IRC00:55
*** dannywilson has quit IRC00:56
*** _cjones_ has joined #openstack-cinder00:57
*** Yogi1 has quit IRC01:00
patrickeastso uh, maybe dumb question, are the tests in test_db_api.py using an actual database? is it being cleared out between tests?/should i worry about leaving it dirty?01:03
jgriffithpatrickeast: it runs against sqlite01:05
jgriffithpatrickeast: or at least used to01:05
jgriffithpatrickeast: and it should have cleanup methods01:05
jgriffithwait...01:05
jgriffithpatrickeast: yeah01:05
*** boichev has joined #openstack-cinder01:05
patrickeastjgriffith: ok cool, i don’t see any of the cleanup methods called explicitly by the test cases, so i’m assuming that happens automagically somewhere… that a safe assumption?01:07
*** theanalyst has quit IRC01:07
jgriffithpatrickeast: :)01:07
*** annashen has quit IRC01:08
patrickeastmaybe i’ll just add my tests and not look into it too much01:08
patrickeastthe ol’ toss in in and run away approach01:08
*** boichev2 has quit IRC01:08
*** SergeyLukjanov has quit IRC01:08
*** timcl has joined #openstack-cinder01:08
*** arif-ali has quit IRC01:08
patrickeastit in*01:08
jgriffithpatrickeast: so there used to be a pretty obvious call to fake-db or something along those lines01:08
jgriffithpatrickeast: you *should* be safe :)01:08
jgriffithpatrickeast: but I make no promises or guarantees01:08
patrickeastjgriffith: alright, i’ll play around a little and see if anything breaks, thanks for the info01:09
*** openstack has joined #openstack-cinder01:12
*** SergeyLukjanov has joined #openstack-cinder01:14
*** tsekiyam_ has joined #openstack-cinder01:16
*** _cjones_ has quit IRC01:16
*** kbyrne has quit IRC01:16
jgriffithpatrickeast: that's what i'd recommend :)01:16
jgriffithpatrickeast: just kidding01:16
jgriffithkinda01:16
jgriffithnot really01:16
jgriffithsorta01:16
* jgriffith runs away now01:16
*** delattec has quit IRC01:16
*** sgotliv has quit IRC01:16
*** mdbooth has quit IRC01:16
*** bnemec has quit IRC01:16
*** cburgess has quit IRC01:16
*** lifeless has quit IRC01:16
*** wolsen has quit IRC01:16
*** flip214 has quit IRC01:16
*** tristanC has quit IRC01:16
*** morganfainberg has quit IRC01:16
*** git-harry has quit IRC01:16
*** ondergetekende_ has quit IRC01:16
*** timcl has quit IRC01:16
*** Yogi1 has joined #openstack-cinder01:16
*** thingee has joined #openstack-cinder01:17
*** Longgeek has joined #openstack-cinder01:18
*** Longgeek has quit IRC01:18
*** tsekiyama has quit IRC01:19
*** mtanino has quit IRC01:19
*** arif-ali has joined #openstack-cinder01:20
*** mdbooth has joined #openstack-cinder01:20
*** bnemec has joined #openstack-cinder01:20
*** cburgess has joined #openstack-cinder01:20
*** lifeless has joined #openstack-cinder01:20
*** wolsen has joined #openstack-cinder01:20
*** flip214 has joined #openstack-cinder01:20
*** tristanC has joined #openstack-cinder01:20
*** morganfainberg has joined #openstack-cinder01:20
*** git-harry has joined #openstack-cinder01:20
*** ondergetekende_ has joined #openstack-cinder01:20
*** lifeless has quit IRC01:20
*** tsekiyam_ has quit IRC01:20
*** lifeless has joined #openstack-cinder01:21
*** Manshoon has joined #openstack-cinder01:21
*** sgotliv has joined #openstack-cinder01:25
*** Longgeek has joined #openstack-cinder01:25
*** Manshoon has quit IRC01:26
*** Lee1092 has joined #openstack-cinder01:27
*** sigmavirus24 is now known as sigmavirus24_awa01:31
*** Mandell has quit IRC01:35
*** bswartz has quit IRC01:35
*** jwang_ has quit IRC01:35
*** ozamiatin has quit IRC01:35
*** ekarlso has quit IRC01:35
*** jdurgin has quit IRC01:35
*** dansmith has quit IRC01:35
*** sseverson has quit IRC01:35
*** jgriffith has quit IRC01:35
*** anteaya has quit IRC01:35
*** nibalizer has quit IRC01:35
*** tries has quit IRC01:35
*** leeantho has quit IRC01:35
*** rcallawa has quit IRC01:35
*** greghaynes has quit IRC01:35
*** coolsvap_ has quit IRC01:35
*** j_king_ has quit IRC01:35
*** svasheka has quit IRC01:35
*** dosaboy has quit IRC01:35
*** baffle has quit IRC01:35
*** frakt has quit IRC01:35
*** s0nea has quit IRC01:35
*** naotokl has quit IRC01:35
*** kbyrne has joined #openstack-cinder01:39
*** Mandell has joined #openstack-cinder01:39
*** ozamiatin has joined #openstack-cinder01:39
*** rcallawa has joined #openstack-cinder01:39
*** bswartz has joined #openstack-cinder01:39
*** jwang_ has joined #openstack-cinder01:39
*** ekarlso has joined #openstack-cinder01:39
*** greghaynes has joined #openstack-cinder01:39
*** jdurgin has joined #openstack-cinder01:39
*** dansmith has joined #openstack-cinder01:39
*** sseverson has joined #openstack-cinder01:39
*** coolsvap_ has joined #openstack-cinder01:39
*** j_king_ has joined #openstack-cinder01:39
*** jgriffith has joined #openstack-cinder01:39
*** anteaya has joined #openstack-cinder01:39
*** svasheka has joined #openstack-cinder01:39
*** dosaboy has joined #openstack-cinder01:39
*** nibalizer has joined #openstack-cinder01:39
*** tries has joined #openstack-cinder01:39
*** baffle has joined #openstack-cinder01:39
*** frakt has joined #openstack-cinder01:39
*** s0nea has joined #openstack-cinder01:39
*** naotokl has joined #openstack-cinder01:39
*** timcl has joined #openstack-cinder01:39
*** Mandell has quit IRC01:40
*** bswartz has quit IRC01:40
*** jwang_ has quit IRC01:40
*** ozamiatin has quit IRC01:40
*** ekarlso has quit IRC01:40
*** jdurgin has quit IRC01:40
*** dansmith has quit IRC01:40
*** sseverson has quit IRC01:40
*** jgriffith has quit IRC01:40
*** anteaya has quit IRC01:40
*** nibalizer has quit IRC01:40
*** tries has quit IRC01:40
*** kbyrne has quit IRC01:40
*** rcallawa has quit IRC01:40
*** greghaynes has quit IRC01:40
*** coolsvap_ has quit IRC01:40
*** j_king_ has quit IRC01:40
*** svasheka has quit IRC01:40
*** dosaboy has quit IRC01:40
*** baffle has quit IRC01:40
*** frakt has quit IRC01:40
*** s0nea has quit IRC01:40
*** naotokl has quit IRC01:40
*** Yogi1 has quit IRC01:40
*** amoturi_ has quit IRC01:40
*** fischerw has quit IRC01:40
*** markstur has quit IRC01:40
*** david-lyle_afk has quit IRC01:40
*** delattec has joined #openstack-cinder01:40
*** timcl has quit IRC01:41
*** cdelatte has joined #openstack-cinder01:41
*** kbyrne has joined #openstack-cinder01:41
*** Mandell has joined #openstack-cinder01:41
*** ozamiatin has joined #openstack-cinder01:41
*** rcallawa has joined #openstack-cinder01:41
*** bswartz has joined #openstack-cinder01:41
*** jwang_ has joined #openstack-cinder01:41
*** ekarlso has joined #openstack-cinder01:41
*** greghaynes has joined #openstack-cinder01:41
*** jdurgin has joined #openstack-cinder01:41
*** dansmith has joined #openstack-cinder01:41
*** sseverson has joined #openstack-cinder01:41
*** coolsvap_ has joined #openstack-cinder01:41
*** j_king_ has joined #openstack-cinder01:41
*** jgriffith has joined #openstack-cinder01:41
*** anteaya has joined #openstack-cinder01:41
*** svasheka has joined #openstack-cinder01:41
*** dosaboy has joined #openstack-cinder01:41
*** nibalizer has joined #openstack-cinder01:41
*** tries has joined #openstack-cinder01:41
*** baffle has joined #openstack-cinder01:41
*** frakt has joined #openstack-cinder01:41
*** s0nea has joined #openstack-cinder01:41
*** naotokl has joined #openstack-cinder01:41
*** delattec has quit IRC01:42
*** rushil_ has quit IRC01:43
*** primechuck has joined #openstack-cinder01:44
*** ebalduf has joined #openstack-cinder01:47
*** Longgeek has quit IRC01:49
*** cdelatte has quit IRC01:51
*** Mandell has quit IRC01:51
*** ebalduf has quit IRC01:51
*** Mandell has joined #openstack-cinder01:52
*** timcl has joined #openstack-cinder01:52
*** timcl has quit IRC01:55
*** scottda has joined #openstack-cinder01:57
mfischthingee: thanks for the response today about cinderv201:57
*** jamielennox is now known as jamielennox|away01:58
*** Yogi1 has joined #openstack-cinder01:59
*** fischerw has joined #openstack-cinder01:59
*** markstur has joined #openstack-cinder01:59
*** david-lyle_afk has joined #openstack-cinder01:59
*** scottda has quit IRC02:01
*** IanGovett has quit IRC02:02
*** thingee has quit IRC02:04
*** jamielennox|away is now known as jamielennox02:06
*** harlowja has quit IRC02:07
*** harlowja_ has joined #openstack-cinder02:07
*** Yogi1 has quit IRC02:10
*** fischerw has quit IRC02:10
*** markstur has quit IRC02:10
*** david-lyle_afk has quit IRC02:10
*** esker has joined #openstack-cinder02:10
*** annashen has joined #openstack-cinder02:10
*** Yogi1 has joined #openstack-cinder02:16
*** fischerw has joined #openstack-cinder02:16
*** markstur has joined #openstack-cinder02:16
*** david-lyle_afk has joined #openstack-cinder02:16
*** hemna is now known as hemnafk02:16
*** annashen has quit IRC02:16
*** jamielennox is now known as jamielennox|away02:17
*** theanalyst has joined #openstack-cinder02:17
*** Longgeek has joined #openstack-cinder02:18
*** emagana has quit IRC02:19
*** emagana has joined #openstack-cinder02:20
*** timcl has joined #openstack-cinder02:23
*** cdelatte has joined #openstack-cinder02:23
*** timcl has quit IRC02:24
*** emagana has quit IRC02:24
*** jamielennox|away is now known as jamielennox02:27
*** changbl has joined #openstack-cinder02:27
*** vilobhmm has quit IRC02:28
*** Apoorva_ has joined #openstack-cinder02:31
*** cdelatte has quit IRC02:32
*** timcl has joined #openstack-cinder02:34
*** Apoorva has quit IRC02:34
*** Apoorva_ has quit IRC02:36
*** jungleboyj has quit IRC02:36
*** jamielennox is now known as jamielennox|away02:38
*** kaisers2 has joined #openstack-cinder02:45
*** kaisers3 has joined #openstack-cinder02:45
*** kaisers has quit IRC02:46
*** kaisers1 has quit IRC02:47
*** jamielennox|away is now known as jamielennox02:47
*** ebalduf has joined #openstack-cinder02:47
*** timcl has quit IRC02:49
*** nikesh_vedams has quit IRC02:51
*** Mandell has quit IRC02:51
*** ebalduf has quit IRC02:52
*** nikesh_vedams has joined #openstack-cinder02:54
*** Yogi1 has quit IRC02:55
*** markvoelker has quit IRC02:56
*** markvoelker has joined #openstack-cinder02:57
*** markvoelker has quit IRC03:01
*** bkopilov has quit IRC03:09
*** bkopilov has joined #openstack-cinder03:09
*** devlaps has joined #openstack-cinder03:14
*** akerr is now known as akerr_away03:17
*** jamielennox is now known as jamielennox|away03:22
*** Manshoon has joined #openstack-cinder03:22
*** Manshoon has quit IRC03:27
*** annashen has joined #openstack-cinder03:30
*** jamielennox|away is now known as jamielennox03:33
*** annashen has quit IRC03:37
*** devlaps has quit IRC03:40
openstackgerritxing-yang proposed openstack/python-cinderclient: Add support to incremental backups in cinder  https://review.openstack.org/11210103:47
*** ebalduf has joined #openstack-cinder03:48
openstackgerritrajiv proposed openstack/python-cinderclient: cinderclient accepts arguments after metadata without -- separator  https://review.openstack.org/15649903:48
*** primechuck has quit IRC03:48
*** mtanino has joined #openstack-cinder03:51
openstackgerritPatrick East proposed openstack/cinder: Add CHAP support to PureISCSIDriver  https://review.openstack.org/13717503:51
openstackgerritPatrick East proposed openstack/cinder: Add DB table for driver specific data  https://review.openstack.org/15183703:51
*** Longgeek has quit IRC03:52
*** ebalduf has quit IRC03:52
*** mriedem has quit IRC03:56
*** dannywilson has joined #openstack-cinder03:57
*** fischerw has quit IRC03:58
*** dannywilson has quit IRC04:01
*** asselin_ has joined #openstack-cinder04:02
*** asselin__ has joined #openstack-cinder04:04
*** xyang has joined #openstack-cinder04:04
*** markvoelker has joined #openstack-cinder04:06
*** harlowja_ is now known as harlowja_away04:06
*** asselin_ has quit IRC04:07
*** ho has joined #openstack-cinder04:08
*** ho__ has quit IRC04:08
*** pdeore_ has joined #openstack-cinder04:13
*** coolsvap_ is now known as coolsvap04:16
*** btran has quit IRC04:19
*** annegent_ has joined #openstack-cinder04:20
*** ho__ has joined #openstack-cinder04:28
*** ho has quit IRC04:28
*** Apoorva has joined #openstack-cinder04:30
*** Mandell has joined #openstack-cinder04:40
*** deepakcs has joined #openstack-cinder04:41
*** annashen has joined #openstack-cinder04:41
*** patrickeast has quit IRC04:41
*** BharatK has joined #openstack-cinder04:42
*** rcallawa has quit IRC04:43
*** mtanino has quit IRC04:46
*** Longgeek has joined #openstack-cinder04:46
*** ebalduf has joined #openstack-cinder04:49
*** krtaylor has quit IRC04:51
*** ebalduf has quit IRC04:53
*** tbarron1 has joined #openstack-cinder04:57
*** lpetrut has joined #openstack-cinder04:57
*** tbarron has quit IRC05:01
*** annashen has quit IRC05:03
*** krtaylor has joined #openstack-cinder05:03
*** zhithuang has joined #openstack-cinder05:03
*** krtaylor has quit IRC05:04
openstackgerritxing-yang proposed openstack/cinder: Create Consistency Group from CG Snapshot API  https://review.openstack.org/14595205:06
*** xyang has quit IRC05:06
*** Longgeek has quit IRC05:07
*** Longgeek has joined #openstack-cinder05:07
*** krtaylor has joined #openstack-cinder05:09
*** PaulCuzner has quit IRC05:19
*** pradipta has joined #openstack-cinder05:20
*** Manshoon has joined #openstack-cinder05:23
*** Manshoon has quit IRC05:28
*** PaulCuzner has joined #openstack-cinder05:28
*** vilobhmm has joined #openstack-cinder05:38
*** abehl has joined #openstack-cinder05:43
*** abehl has quit IRC05:43
*** asselin__ has quit IRC05:43
*** rmstar has quit IRC05:46
*** annegent_ has quit IRC05:47
*** Apoorva has quit IRC05:48
*** annegent_ has joined #openstack-cinder05:48
*** Longgeek has quit IRC05:50
*** ebalduf has joined #openstack-cinder05:50
*** Longgeek has joined #openstack-cinder05:52
*** lpetrut has quit IRC05:53
openstackgerritJohn Griffith proposed openstack/cinder: Revert "Remove retry_deactivation directive on lvremove"  https://review.openstack.org/15900305:53
*** annegent_ has quit IRC05:53
*** ebalduf has quit IRC05:54
*** xyang has joined #openstack-cinder05:59
openstackgerritWang Peter proposed openstack/cinder: CG Modification Support in EMC VNX Cinder Driver  https://review.openstack.org/15478406:03
openstackgerritWang Peter proposed openstack/cinder: CG Modification Support in EMC VNX Cinder Driver  https://review.openstack.org/15478406:05
*** BharatK has quit IRC06:05
*** zhithuang has quit IRC06:07
*** jungleboyj has joined #openstack-cinder06:13
*** Longgeek has quit IRC06:19
*** rwsu is now known as rwsu-afk06:25
*** nshaikh has joined #openstack-cinder06:26
*** xyang1 has quit IRC06:27
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex  https://review.openstack.org/15240106:31
*** annashen has joined #openstack-cinder06:31
*** annashen has quit IRC06:42
*** rmstar has joined #openstack-cinder06:42
*** anshul has joined #openstack-cinder06:45
*** ebalduf has joined #openstack-cinder06:51
*** ebalduf has quit IRC06:55
*** nkrinner has joined #openstack-cinder06:56
*** rmstar has quit IRC06:57
*** dannywilson has joined #openstack-cinder06:57
*** lpetrut has joined #openstack-cinder06:57
*** dannywilson has quit IRC07:00
*** dannywilson has joined #openstack-cinder07:01
*** zhithuang has joined #openstack-cinder07:04
*** rmstar has joined #openstack-cinder07:06
*** zhithuang has quit IRC07:09
*** zhithuang has joined #openstack-cinder07:10
*** zhithuan1 has joined #openstack-cinder07:12
*** zhithuan1 is now known as winston-d_07:12
*** zhithuang has quit IRC07:15
*** maike has joined #openstack-cinder07:18
*** TobiasE has joined #openstack-cinder07:20
*** Ilja has joined #openstack-cinder07:23
*** vilobhmm has quit IRC07:26
openstackgerritDanny Wilson proposed openstack/cinder: Over subscription for Pure Storage iSCSI driver.  https://review.openstack.org/15768107:29
*** Miouge has joined #openstack-cinder07:30
*** markvoelker has quit IRC07:32
*** markvoelker has joined #openstack-cinder07:33
*** markvoelker has quit IRC07:37
*** BharatK has joined #openstack-cinder07:39
*** ekarlso has quit IRC07:48
*** nkrinner has quit IRC07:50
*** ebalduf has joined #openstack-cinder07:51
*** nkrinner has joined #openstack-cinder07:52
*** winston-d_ has quit IRC07:56
*** ebalduf has quit IRC07:56
*** e0ne has joined #openstack-cinder07:57
*** winston-d_ has joined #openstack-cinder08:00
*** pwehrle has joined #openstack-cinder08:00
*** ronis has joined #openstack-cinder08:01
*** TobiasE1 has joined #openstack-cinder08:04
*** haomaiw__ has quit IRC08:04
*** TobiasE has quit IRC08:04
*** zhipeng has joined #openstack-cinder08:04
*** dulek has joined #openstack-cinder08:07
*** dannywilson has quit IRC08:07
*** e0ne has quit IRC08:08
*** zhipeng has quit IRC08:09
*** anurag1 has joined #openstack-cinder08:09
*** dalgaaf has joined #openstack-cinder08:23
*** zhipeng has joined #openstack-cinder08:23
*** Ilja has quit IRC08:24
*** afazekas_ has joined #openstack-cinder08:30
*** markvoelker has joined #openstack-cinder08:35
*** winston-d_ has quit IRC08:38
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/15764208:40
*** markvoelker has quit IRC08:40
*** nellysmitt has joined #openstack-cinder08:40
*** ho__ has quit IRC08:41
*** karimb has joined #openstack-cinder08:43
*** Ilja has joined #openstack-cinder08:45
*** e0ne has joined #openstack-cinder08:52
*** ekarlso has joined #openstack-cinder08:52
*** ebalduf has joined #openstack-cinder08:52
*** Mandell has quit IRC08:53
*** jistr has joined #openstack-cinder08:53
*** ebalduf has quit IRC08:57
*** maike has quit IRC09:04
*** maike has joined #openstack-cinder09:04
*** anurag2 has joined #openstack-cinder09:05
*** anurag1 has quit IRC09:06
*** nkrinner has quit IRC09:08
*** Ilja has quit IRC09:08
*** nkrinner has joined #openstack-cinder09:09
*** maike has quit IRC09:09
*** alecv has joined #openstack-cinder09:10
*** lpetrut has quit IRC09:12
*** markvoelker has joined #openstack-cinder09:16
*** nkrinner_ has joined #openstack-cinder09:19
*** markvoelker has quit IRC09:21
*** nkrinner has quit IRC09:22
*** nkrinner_ has quit IRC09:22
*** nkrinner has joined #openstack-cinder09:22
*** nkrinner has quit IRC09:22
*** nkrinner has joined #openstack-cinder09:22
openstackgerritMichal Dulko proposed openstack/cinder: Delay requests in scheduler to wait for metrics  https://review.openstack.org/15621909:30
*** anurag has joined #openstack-cinder09:31
*** anurag2 has quit IRC09:32
*** e0ne has quit IRC09:33
*** emaisne has joined #openstack-cinder09:34
*** e0ne has joined #openstack-cinder09:35
*** Miouge has quit IRC09:35
*** e0ne is now known as e0ne_09:35
*** yuriy_n17 has quit IRC09:38
*** yuriy_n17 has joined #openstack-cinder09:39
*** emaisne_ has joined #openstack-cinder09:39
*** emaisne has quit IRC09:39
*** emaisne__ has joined #openstack-cinder09:40
*** Miouge has joined #openstack-cinder09:42
*** nkrinner_ has joined #openstack-cinder09:43
*** emaisne_ has quit IRC09:43
*** e0ne_ is now known as e0ne09:44
*** nkrinner has quit IRC09:44
*** Ilja has joined #openstack-cinder09:44
*** jordanP has joined #openstack-cinder09:44
*** anurag has left #openstack-cinder09:46
openstackgerritAnton Arefiev proposed openstack/cinder: Import only modules: H302  https://review.openstack.org/14578009:50
*** anuragpalsule has joined #openstack-cinder09:50
*** e0ne has quit IRC09:52
*** ebalduf has joined #openstack-cinder09:53
nikesh_vedamshi09:54
*** TobiasE has joined #openstack-cinder09:57
*** ebalduf has quit IRC09:58
*** TobiasE1 has quit IRC09:59
*** nikesh_vedams has quit IRC10:02
*** anshul has quit IRC10:05
*** emaisne__ has quit IRC10:06
*** anshul has joined #openstack-cinder10:06
*** markvoelker has joined #openstack-cinder10:17
*** Ilja has quit IRC10:19
*** Ilja has joined #openstack-cinder10:20
*** Miouge has quit IRC10:20
*** markvoelker has quit IRC10:22
*** Miouge has joined #openstack-cinder10:27
*** Miouge has quit IRC10:28
openstackgerritAnton Arefiev proposed openstack/cinder: Add entry create and cast tasks to manage workflow  https://review.openstack.org/13907110:34
openstackgerritAnton Arefiev proposed openstack/cinder: Fix lvm manage existing volume  https://review.openstack.org/15693910:34
openstackgerritGorka Eguileor proposed openstack/cinder: Use iscsi_helper instead of target_helper on logs  https://review.openstack.org/15907210:40
*** erlon has joined #openstack-cinder10:45
*** casusbelli has joined #openstack-cinder10:47
*** ebalduf has joined #openstack-cinder10:54
*** TobiasE has quit IRC10:58
*** ebalduf has quit IRC10:58
openstackgerritGorka Eguileor proposed openstack/cinder: Use iscsi_helper instead of target_helper on logs  https://review.openstack.org/15907211:00
*** aix has joined #openstack-cinder11:02
*** lpetrut has joined #openstack-cinder11:06
*** dannywilson has joined #openstack-cinder11:08
*** rushiagr_away is now known as rushiagr11:12
*** dannywilson has quit IRC11:12
*** pradipta has quit IRC11:13
*** asselin has quit IRC11:16
*** mdenny has quit IRC11:16
*** kmartin has quit IRC11:16
openstackgerritAnusha rayani proposed openstack/cinder: Filter cinder volumes by name  https://review.openstack.org/15908111:17
*** markvoelker has joined #openstack-cinder11:18
*** markvoelker has quit IRC11:23
*** zhipeng has quit IRC11:25
*** Manshoon has joined #openstack-cinder11:26
*** Miouge has joined #openstack-cinder11:28
*** Manshoon has quit IRC11:30
*** timcl has joined #openstack-cinder11:32
*** karimb has quit IRC11:33
*** timcl has quit IRC11:36
*** EmilienM is now known as EmilienM|afk11:39
*** mdbooth has quit IRC11:40
*** mdbooth has joined #openstack-cinder11:41
*** nkrinner_ is now known as nkrinner11:46
*** karimb has joined #openstack-cinder11:50
*** Ilja has quit IRC11:51
*** ebalduf has joined #openstack-cinder11:54
*** timcl has joined #openstack-cinder11:56
*** rcallawa has joined #openstack-cinder11:57
*** IanGovett has joined #openstack-cinder11:57
*** ebalduf has quit IRC11:59
*** Miouge has quit IRC12:02
*** nkrinner has quit IRC12:04
*** Miouge has joined #openstack-cinder12:04
*** ganso_ has joined #openstack-cinder12:08
openstackgerritMichal Dulko proposed openstack/cinder: Delay requests in scheduler to wait for metrics  https://review.openstack.org/15621912:09
dulekDuncanT: Hi!12:10
DuncanTdulek: Hi12:10
dulekDuncanT: Can you explain your latest comment on 156219? I'm starting to think I'm missing something.12:11
DuncanTSure, one sec12:11
*** aix has quit IRC12:11
dulekI don't get how we can call self.driver_api.schedule_create_volume every second.12:11
*** e0ne has joined #openstack-cinder12:11
DuncanTBy just calling it... use ether sleep or (better) looping call - it will stop raising an exception if it finds a host12:12
*** nkrinner has joined #openstack-cinder12:13
dulekDuncanT: And I should stop after 60 seconds. Hm, this seem crude.12:13
dulekAlso - it will most probably place the volume on the first host that sent metrics. Scheduler should not schedule when it doesn't know whole situation.12:14
DuncanTWell, 1 second is arbitary, but waiting 60 should usually be unnecessary most of the time with winston's other patch in place12:14
*** timcl has quit IRC12:16
DuncanTIMO it is better to start scheduling once you have a suitable host... the odd volume going to a suitable but not necessarily optimal place is better than random creates stalling for 60 seconds whenever you start a new scheduler (which happens in an active/active scheduler environment at random times)12:16
dulekThat's true, but calling scheduler_driver till it returns without exception seem like a wrong solution.12:18
dulekIn the latest patchset I've modified scheduler.manager to count down the timeout.12:18
*** jaypipes has joined #openstack-cinder12:18
dulekThe delay I mean12:18
*** markvoelker has joined #openstack-cinder12:19
dulekSo requests will wait 60 seconds _at most_.12:19
*** Lee1092 has quit IRC12:20
dulekWe're probably unable to estimate the time needed to collect the metrics even after Winston's patch?12:20
DuncanTYeah, the clean fix is to modify oslo.messaging so that we get the stats updates but not the schedule request until either 60 seconds has passed or else we have heard from everybody in the service table of the db, but that requires some pretty big changes by the looks of things12:23
DuncanTUntil then, it is going to end up being something ugly, we just need to minimise the ugliness12:24
*** markvoelker has quit IRC12:24
*** deepakcs has quit IRC12:25
dulekAgreed, thing is ugliness metric isn't same for everyone. ;)12:25
dulekSo we have two approaches - asking every second till no exception comes or delay passes or to wait 60 or less seconds.12:25
dulekMaybe this is good topic for quick discussion at the tomorrow's meeting?\12:26
*** danieru has quit IRC12:26
*** danieru has joined #openstack-cinder12:27
*** lpetrut has quit IRC12:32
dulekDuncanT: I've added it on the tomorrow's agenda.12:34
dulekDuncanT: Got to go now, thanks for help!12:34
DuncanTErm, the meeting is today12:34
*** timcl has joined #openstack-cinder12:35
DuncanTdulek: Functional uglyness is worse than code uglyness in general12:36
*** dulek has quit IRC12:38
*** timcl1 has joined #openstack-cinder12:39
*** timcl has quit IRC12:39
*** aix has joined #openstack-cinder12:43
*** lpetrut has joined #openstack-cinder12:46
*** sandywalsh has quit IRC12:49
*** lpetrut has quit IRC12:50
*** lpetrut has joined #openstack-cinder12:53
*** ebalduf has joined #openstack-cinder12:55
*** annegent_ has joined #openstack-cinder12:58
*** ebalduf has quit IRC13:00
*** EmilienM|afk is now known as EmilienM13:03
*** annegent_ has quit IRC13:03
*** alecv has quit IRC13:12
*** timcl1 has quit IRC13:12
*** markvoelker has joined #openstack-cinder13:20
aarefievhi, could somebody from cores look at patch https://review.openstack.org/#/c/145780/.  Everyday rebasing is a little tired:), thanks.13:22
*** cdelatte has joined #openstack-cinder13:23
*** tbarron has joined #openstack-cinder13:23
*** akerr_away is now known as akerr13:24
*** Miouge has quit IRC13:25
*** markvoelker has quit IRC13:25
*** rcallawa has quit IRC13:27
*** akerr has quit IRC13:28
*** sandywalsh has joined #openstack-cinder13:28
*** dulek has joined #openstack-cinder13:29
*** Miouge has joined #openstack-cinder13:32
openstackgerritWang Peter proposed openstack/cinder: CG Modification Support in EMC VNX Cinder Driver  https://review.openstack.org/15478413:35
*** bswartz has quit IRC13:44
*** mtanino has joined #openstack-cinder13:45
*** nellysmitt has quit IRC13:48
*** nellysmitt has joined #openstack-cinder13:49
*** nellysmitt has quit IRC13:53
*** ebalduf has joined #openstack-cinder13:56
*** bill_az has joined #openstack-cinder13:57
*** scottda has joined #openstack-cinder13:59
*** eharney has joined #openstack-cinder14:00
*** ebalduf has quit IRC14:01
*** mtanino has quit IRC14:03
*** eharney has quit IRC14:04
*** Miouge has quit IRC14:07
*** tbarron has quit IRC14:07
*** eharney has joined #openstack-cinder14:08
*** lpetrut has quit IRC14:08
*** anuragpalsule has quit IRC14:10
*** timcl has joined #openstack-cinder14:10
*** bswartz has joined #openstack-cinder14:10
*** kaufer has joined #openstack-cinder14:13
*** alecv has joined #openstack-cinder14:13
*** dulek has quit IRC14:15
*** kallebe has joined #openstack-cinder14:17
*** annegent_ has joined #openstack-cinder14:17
*** TobiasE has joined #openstack-cinder14:17
*** markvoelker has joined #openstack-cinder14:21
*** Yogi1 has joined #openstack-cinder14:22
*** lpetrut has joined #openstack-cinder14:22
*** Miouge has joined #openstack-cinder14:22
*** nshaikh has quit IRC14:24
kallebeHello. Does anyone here have experience using SAN generic driver? I tried to find some tutorial to configure cinder in order to use it but did not find anything14:25
*** markvoelker has quit IRC14:26
*** Miouge has quit IRC14:29
*** pdeore_ has quit IRC14:29
*** jungleboyj has quit IRC14:31
*** kvidvans has joined #openstack-cinder14:34
*** timcl has quit IRC14:34
*** nlevinki has joined #openstack-cinder14:35
*** Mandell has joined #openstack-cinder14:35
*** Miouge has joined #openstack-cinder14:41
*** BharatK has quit IRC14:41
*** annegent_ has quit IRC14:42
*** david-lyle_afk is now known as david-lyle14:48
openstackgerritnikeshmahalka proposed openstack/cinder: Add CHAP persistence to SCST target helper  https://review.openstack.org/15735614:49
*** esker has quit IRC14:50
*** Ilja has joined #openstack-cinder14:51
*** nlevinki has quit IRC14:52
*** markvoelker has joined #openstack-cinder14:52
*** markvoelker has quit IRC14:53
*** Manshoon has joined #openstack-cinder14:54
*** Mandell has quit IRC14:56
*** tsekiyama has joined #openstack-cinder14:56
*** ebalduf has joined #openstack-cinder14:57
*** deepakcs has joined #openstack-cinder14:59
*** Mandell has joined #openstack-cinder15:00
*** ebalduf has quit IRC15:01
*** Yogi1 has quit IRC15:02
*** alexpilotti has joined #openstack-cinder15:02
*** BharatK has joined #openstack-cinder15:03
*** xyang1 has joined #openstack-cinder15:05
*** timcl has joined #openstack-cinder15:06
*** jungleboyj has joined #openstack-cinder15:07
DuncanTaarefiev: It is another of the cleanup type patches that doesn't actually fix any bugs or implement any new features, and will cause a rebase hit for just about every open review due to the number of files it touches. I'm really not seeing the big win of merging it15:07
*** Yogi1 has joined #openstack-cinder15:07
*** nkrinner has quit IRC15:08
*** openstackgerrit has quit IRC15:08
*** alexpilotti has quit IRC15:08
*** openstackgerrit has joined #openstack-cinder15:08
DuncanTaarefiev: Most of the code looks less readable to me after your patch, not more15:08
DuncanTaarefiev: I'm not saying you're definitely wrong to want this change, I'm saying convince me as to the benefit15:09
*** rushil has joined #openstack-cinder15:10
jungleboyjxyang: Morning.15:10
*** amoturi has quit IRC15:11
*** amoturi has joined #openstack-cinder15:12
*** thangp has joined #openstack-cinder15:12
*** BharatK has quit IRC15:13
*** primechuck has joined #openstack-cinder15:14
xyangjungleboyj: morning15:15
jungleboyjxyang: Hey, quick question, are there any plans for a vplex cinder driver?15:16
xyangjungleboyj: you are the 2nd person asking me that today:).  no plan15:16
xyangjungleboyj: you can use ViPR driver for that15:17
jungleboyjxyang: Interesting. Who was the other person.15:17
smcginnisDuncanT: in aarefiev's defence, I think this does need to happen at some time. Not sure if there really is a good time for it.15:17
xyangjungleboyj: haiming15:17
smcginnisDuncanT: We do have code reviews that get -1's because of not following this.15:17
smcginnisDuncanT: This would clean it up and enforce it so it's explicit.15:17
smcginnisDuncanT: Just my 2 cents (or pence?) so I'll be quiet now. :)15:18
*** Mandell has quit IRC15:18
*** tbarron has joined #openstack-cinder15:20
openstackgerritnikeshmahalka proposed openstack/cinder: Use Unique SCST Group names in SCST cinder helper driver.  https://review.openstack.org/15915615:23
*** mriedem has joined #openstack-cinder15:24
*** sigmavirus24_awa is now known as sigmavirus2415:24
*** dustins has joined #openstack-cinder15:25
*** BharatK has joined #openstack-cinder15:25
*** annegent_ has joined #openstack-cinder15:28
*** mriedem has quit IRC15:29
*** kallebe has quit IRC15:30
*** esker has joined #openstack-cinder15:35
*** mriedem has joined #openstack-cinder15:37
*** hemnafk is now known as hemna15:38
*** mtanino has joined #openstack-cinder15:38
*** BharatK has quit IRC15:38
jungleboyjxyang: *Sigh*  Ok, same person asking me.15:38
DuncanTsmcginnis: Yeah, I know it gets -1s at review time sometimes... should we just tell people to not do that instead? Is the code really better if you only import modules? Looking at some of the code after that patch is applied, it looks less readable to me, not more, but I'm quite willing to hear arguements15:38
jungleboyjxyang: Thanks for the info.15:39
smcginnisDuncanT: I think we can tell people not to do that, but it still would end up happening.15:39
smcginnisDuncanT: This would enable the pep8 validation to make sure they get that feedback right away.15:40
*** Manshoon has quit IRC15:40
DuncanTsmcginnis: But the new version of the code looks worse to me, not better15:40
smcginnisDuncanT: I somewhat agree with that statement.15:41
DuncanTsmcginnis: Having an arbitrary rule that makes the code less readable seems really, really dumb15:41
*** Manshoon has joined #openstack-cinder15:41
smcginnisDuncanT: Personally I don't have a problem with importing classes instead of modules.15:41
DuncanTsmcginnis: I'd rather get all reference to the rule scrubbed from the docs and educate reviewers than to have worse code15:41
smcginnisDuncanT: But that seems to be something others are enforcing, so I do agree it would be good for consistency.15:41
smcginnisDuncanT: +115:41
smcginnisDuncanT: Good luck with that. :)15:42
DuncanTsmcginnis: I'll start a mailing list thread on the subject, see if anybody has any real justification for the rule15:42
smcginnisDuncanT: Oh, good idea. It would be good to open that up to some discussion to get some view points.15:42
smcginnisDuncanT: I just think if we are going to go with that, then we should enforce it.15:42
xyangjungleboyj: oh, ok:)  He's going to compare the two answers then15:42
DuncanTsmcginnis: I'll start a thread, see what happens15:43
*** tsekiyama has quit IRC15:43
smcginnisDuncanT: Thanks!15:44
*** emagana has joined #openstack-cinder15:45
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: WIP: Remove Brick from cinder codebase  https://review.openstack.org/15555215:45
jungleboyjxyang: Ok.  Thanks for answering.15:45
*** tsekiyam_ has joined #openstack-cinder15:46
*** rushiagr is now known as rushiagr_away15:46
*** rmesta has joined #openstack-cinder15:47
*** thingee has joined #openstack-cinder15:48
*** IanGovett1 has joined #openstack-cinder15:49
*** nellysmitt has joined #openstack-cinder15:49
*** BharatK has joined #openstack-cinder15:51
*** IanGovett has quit IRC15:51
*** Lee1092 has joined #openstack-cinder15:52
*** dulek has joined #openstack-cinder15:54
*** nellysmitt has quit IRC15:54
*** dulek has quit IRC15:54
*** dulek has joined #openstack-cinder15:54
flip214in 3 mins: /join #openstack-meeting15:56
*** MasterPiece has joined #openstack-cinder15:56
*** mdenny has joined #openstack-cinder15:56
*** ronis has quit IRC15:57
*** kallebe has joined #openstack-cinder15:57
*** ebalduf has joined #openstack-cinder15:57
*** TobiasE has quit IRC15:58
flip214 /join #openstack-meeting15:59
*** TobiasE has joined #openstack-cinder15:59
*** asselin has joined #openstack-cinder16:00
*** TobiasE has quit IRC16:01
openstackgerritShay Halsband proposed openstack/cinder: XtreamIO version 4.0 support  https://review.openstack.org/15297316:01
aarefievsmcginnis: thanks for your opinion DuncanT: Why do think it makes code less readable, I think it become more clear? Also as Sean mentioned some developer don't follow style guidelines16:01
*** kmartin has joined #openstack-cinder16:01
*** ebalduf has quit IRC16:02
aarefievI think it's better to automate it16:02
e0neaarefiev, DuncanT: imo, it makes code less readable only if we got a_very_long_modules_names16:03
*** lpetrut has quit IRC16:04
*** annegent_ has quit IRC16:04
*** anshul has quit IRC16:07
DuncanTaarefiev: You're very much right that if we're going to have the rule then it should be automated. I'm just not convinced it is a good rule. I've started a post for the mailing list, with examples, so if you don't mind I'll point you at that once it is up (should be straight after the meeting)16:08
*** cnesa has joined #openstack-cinder16:08
aarefievDuncanT: ok16:09
openstackgerritSean McGinnis proposed openstack/cinder: WIP: Dell Storage Center: Address GetList failure  https://review.openstack.org/15917116:11
*** annegent_ has joined #openstack-cinder16:12
*** annegent_ has quit IRC16:12
sigmavirus24thingee++ on looking to the API-WG for guidance in earnest16:14
*** annegent_ has joined #openstack-cinder16:14
*** dannywilson has joined #openstack-cinder16:16
*** jcru has joined #openstack-cinder16:17
*** jcru has quit IRC16:17
*** jcru has joined #openstack-cinder16:18
*** Mandell has joined #openstack-cinder16:18
openstackgerritMikhail Khodos proposed openstack/cinder: Nexenta Edge iSCSI backend driver.  https://review.openstack.org/15874516:24
*** dannywilson has quit IRC16:26
*** dannywilson has joined #openstack-cinder16:27
*** coolsvap is now known as coolsvap_16:28
*** akerr has joined #openstack-cinder16:30
*** rwsu-afk has quit IRC16:31
*** cpallares has joined #openstack-cinder16:32
*** rushiagr_away is now known as rushiagr16:33
jaypipesDuncanT: lol "The client calls to do multi-attach won't allow multiattach."16:36
jaypipesDuncanT: I don't think that came across quite as you intended :)16:36
DuncanTjaypipes: Possibly not. 'It won't work. Not even a little bit' covered it nicely though, I thought16:38
*** jdurgin1 has joined #openstack-cinder16:38
*** jdurgin1 has quit IRC16:38
jaypipesDuncanT: :) so, my point was that you can't say "we cannot do that cinderclient changes because Nova doesn't support it yet" and at the same time, Nova *needs* the cinderclient changes in order to support multi-attach. :(16:40
DuncanTjaypipes: Nova is definitely not going to do those changes until L16:41
jaypipesDuncanT: yes, agreed.16:41
jaypipesDuncanT: but that is no reason to prevent the Cinder and cinderclient changes from going in.16:41
*** openstackstatus has joined #openstack-cinder16:42
*** ChanServ sets mode: +v openstackstatus16:42
openstackgerritSean McGinnis proposed openstack/cinder: WIP: Dell Storage Center: Address GetList failure  https://review.openstack.org/15917116:43
*** Mandell has quit IRC16:44
anteayathingee: I do have something for open discussion if we get there16:46
DuncanTjaypipes: yes, it is16:48
jaypipesDuncanT: why?16:48
DuncanTjaypipes: Having a feature that doesn't work, because the nova changes aren't merged, in the client, for a release, means people pop up on this channel, oon the mailing list, on ask.openstack, etc, asking how they get multiattach to work16:48
jaypipesDuncanT: so delaying all of this another X months is the solution? :(16:49
jaypipesDuncanT: and, FYI, it's not like the feature itself doesn't work on the Cinder side... it's just the integration of the feature support in Nova isn't ready yet.16:50
DuncanTjaypipes: Put it in the client as soon as the K release is out of the door16:50
DuncanTjaypipes: Then people who just consume the release don't see it16:50
jaypipesmeh, ok16:50
DuncanTjaypipes: Which reduces support load, a lot16:51
DuncanTjaypipes: People who take point releases tend to be more clueful16:51
jaypipesDuncanT: not really :) instead, you just have a shit-ton of people battering down *my* door asking why multi-attach isn't in Kilo. :)16:51
DuncanTjaypipes: We went through this pain point with replication that only worked with one backend...16:51
DuncanTjaypipes: 'Because it doesn't work because nova didn't take the patch'16:51
*** rwsu has joined #openstack-cinder16:52
jaypipesDuncanT: how can nova take a patch without the support in cinder?16:52
DuncanTjaypipes: If we release the client, you still can't attach the volume to two VMs16:52
jaypipesjust seems to me delaying the feature for now particular reason.16:53
DuncanTjaypipes: If nova had any plans over even maybe merging it, I'd be happy to take the support hit, but they aren't. Merge the client support as the first patch in L16:54
DuncanTjaypipes: It is delaying nothing. Nova are definitely not, no way no how, not going to happen, take the patch in Kilo16:54
DuncanTjaypipes: Given we know that, releasing client support for a feature that you can't use, definitely in no way not even a little bit can you use it, is dumb16:55
hemnaDuncanT, FWIW, this is one of the main reasons why multiattach hasn't landed in the previous 3 attempts16:56
jaypipesyes, that ^^16:56
hemnadue to 1) Nova's very limited time window for landing features combined with 2) Cinder's requirement that nova has to use a cinder feature before cinder lands it.  chicken/egg16:56
DuncanThemna: You saw my comment on the server side patch... I'm happy to land that, though I'd rather the  API rejected multiattach=True unless you flip a config option16:56
hemnaso cinder will forever be not allowed to land features that nova wants16:57
jaypipesand with this pushed yet another release, hemna likely won't be able to work on it furtther.16:57
DuncanThemna: Put the patch to get rid of that limitation as soon as the release is out of the way16:57
thingeejaypipes: are you testing this patch as well?16:57
hemnathingee, that's part of the issue16:57
*** annegent_ has quit IRC16:57
hemnathe tempest tests fail, because of the cross project deps16:58
DuncanTjaypipes: Anything that claims that openstack supports multiattach in kilo, even with all the cinder stuff landed, is a lie16:58
hemnacinder has to land first for any of the nova side/tempest tests can possibly pass.16:58
thingeehemna: you can test something in your own lab16:58
DuncanThemna: I though we could stack reviews now?16:58
hemnathingee, well sure.  I have been.16:58
hemnabut any patches in nova in gerrit will always fail16:58
thingeehemna: well that was my question to jaypipes16:58
*** ebalduf has joined #openstack-cinder16:58
hemnaunless cinder lands16:58
hemnachicken/egg16:58
jaypipesright.16:58
hemnaDuncanT, we can do cross project deps16:59
DuncanTLand it as athe first thing in L. It won't get the nova part landed any slower!16:59
hemnabut that doesn't install the new client.16:59
jaypipesbut now that (yet again) we arepast the nova feature freeze, we are going to kill this feature again.16:59
DuncanT(The client part)16:59
hemnathe deps don't work like that unfortunatel.16:59
DuncanTThe server part I'm less bothered by, though I'd far rather the API gave a sensible error for a create with multi-attach=True16:59
hemnaDuncanT, so don't land the client changes ?17:00
hemnaand update the cinder patch to report fail on seeing multiattach flag ?17:00
DuncanTActually Hemna, can we key the API response off the  volume type, and require multi-attach to have it noted in the type? At least then normal deployments will get a 'not supported' response17:00
hemnaugh17:01
DuncanThemna: Then even if they use the new client, they still get a good error17:01
DuncanThemna: We probably need that anyway, right, since many drivers won't do multi-attach?17:01
DuncanTs/many/some maybe17:01
hemnawell the create should always work17:01
DuncanThemna: Create of a multi-attach=true volume in a type that doesn't support it? I think that sould always fail17:02
hemnaif we want to filter on the multiattach capability, then drivers need time to add the capability reporting17:02
hemnaagain delaying the cinder side from landing.17:02
hemnaanyway, I don't know what to do.  I've tried 3 releases now.17:02
* hemna is frustrated17:02
DuncanThemna: We need some way of stopping multi-attach requests going to backends that don't support it17:02
*** ebalduf has quit IRC17:02
thingeeI was already ignored on this, but I will repeat again, I'm not going to approve this if it's not tested. hemna I appreciate you testing your work, but if there are interested parties, I hope they brought all deps in their own test area to play around with it.17:03
hemnaDuncanT, drivers need to report the capability17:03
hemnaand the scheduler honors it.17:03
*** asselin has quit IRC17:03
thingeeI just need a simple sign off from people I trust.17:03
*** pwehrle has quit IRC17:03
hemnathingee, yah that's fine.  it should get tested and gated17:03
hemnabut the gating part is a chicken/egg issue right now.17:04
thingeeI don't need gated right now. just "I played with this, cinder didn't break, it's good!"17:04
DuncanThemna: Right, so if we check the type has some multi-attach flag in it, and if it rejects the create if the type doesn't have that flag, what is the harm?17:04
DuncanThemna: As drivers test multi-attach, then they can add the capability\17:04
hemnawell the flag is on the volume itself, not in the volume type.17:04
openstackgerritBob Callaway proposed openstack/cinder: Add Manage/Unmanage support to NetApp NFS drivers  https://review.openstack.org/15886417:04
DuncanThemna: We just add it to LVM for the gate & for people to play with17:04
hemnawinston-d, can the scheduler look at the volume multiattach flag to compare against reported capabilities?17:05
DuncanThemna: Means the API gives a sensible error unless the admin turned it on, which solves my client complaints17:05
hemnaI can modify every driver to report multiattach=False17:06
*** Yogi1 has quit IRC17:06
hemnaand/or modify our drivers and lvm to report true.17:06
*** atan8 has joined #openstack-cinder17:06
hemnabut the scheduler needs to be able to filter on the capability vs. volume attribute17:07
thingeeDuncanT, dulek, winston-d: can we continue to the scheduler discussion after the multiattach stuff here?17:07
dulekthingee: sure17:07
hemnathat part I'm unsure of17:07
DuncanTthingee: Sure17:07
*** markvoelker has joined #openstack-cinder17:07
dulekthingee: How long will the current one last? I wonder if I can get 30 minutes to drive home.17:07
DuncanThemna: Would require an extra filter in the scheduler I think, but that isn't hard AFIACT17:08
winston-dhemna: yes, that's doable17:08
thingeedulek: not sure. I need to leave soon myself.17:08
winston-d'scheduler look at multi-attach flag'17:08
DuncanThemna: I can try to knock up a patch to your patch now, if you want?17:08
dulekthingee: ok, I'll stay then17:09
hemnaDuncanT, that would be great.17:09
hemnawinston-d, is it a new filter ?17:09
*** atan8 has quit IRC17:09
hemnaI guess that'd have to be enabled by default17:09
winston-dhemna: no, doesn't have to be. just pass that as a 'scheduler_hint'17:09
*** _cjones_ has joined #openstack-cinder17:09
hemnawinston-d, ok that's new to me.17:10
hemnathat can be done automatically in the API -> scheduler message ?17:10
winston-dhemna: 'cinder create --scheduler_hint 'multi-attach_support=true', sth like that17:10
hemnagah17:10
hemnawe already have a multiattach flag on the volume itself.17:10
hemnacan I inject the scheduler hint automatically?17:11
hemnaif the flag is on17:11
winston-dhemna: ah, ok. yes, you can do that in API.17:11
hemnaok that would be better than adding a new filter17:11
hemnaI can research how to do that.17:12
thingeeDuncanT, dulek, winston-d : if you're fine with continuing discussions tomorrow, we can do that too.17:12
hemnaso the follow up, is the drivers aren't reporting up the capability now17:12
hemnaso does that mean it defaults to false ?17:12
hemnaand then the create will fail?17:12
thingeeor...maybe multi-attach is just about done :)17:12
hemnauntil drivers are updated to report the capability as true?17:12
winston-dscheduler hint will eventually be part of 'filter_properties'.17:12
winston-dhemna: you just need to inject a dict to 'filter_properties' and done17:13
dulekthingee, DuncanT, winston-d: I would prefer to do it today as I'm already staying late. ;)17:13
thingeedulek: ok17:13
DuncanThemna: It should default to false and the attach fail if the driver doesn't advertise, yes17:13
dulekthingee, DuncanT, winston-d: Maybe we can meet in one hour?17:13
DuncanTdulek: that's too late for me, sorry, it is already 7:15 pm17:14
jgriffiththingee: yo... what'up17:14
hemnawinston-d, trying to find where we are adding filter_properties in the api17:14
thingeedulek: I need to disappear for a little bit. might not be around. You're all welcome to carry on discussing without me though17:14
winston-dhemna: actuall, put it into request_specs17:15
DuncanTdulek: I vote for the spin/first hit approach and don't care about fairness17:15
hemnawinston-d, can you send me a gist snippet ?17:15
winston-dDuncanT: too late for me too, it's laready 1:15 am17:15
*** Manshoon has quit IRC17:15
winston-ddulek: ^^17:15
DuncanTwinston-d: You're insane ;-)17:15
winston-dhemna: sure, few secs.17:15
hemnawinston-d, thank you.17:15
dulekDuncanT, winston-d, thingee: Cool, let's continue tomorrow morning!17:15
winston-ddulek: which timezone r u in?17:16
*** diemt has joined #openstack-cinder17:16
dulekUTC+117:16
DuncanTdulek: Please. I don't actually see anybody complaining about spin/first hit though17:16
dulekAnd thingee will have the problem solved before his morning17:16
anteayaso what I was thinking was that I could work with about 5 or so people to help them understand how to trace back the jobs listed on cinder repos in zuul/layout.yaml with the agreement that the folks I teach will share with others17:16
dulekDuncanT: Hm, you're right. So you suggest to just propose the patch with your idea and gather reviews?17:17
anteayathen when I ask in cinder, who knows about this job or proposed job, folks will say yes, I know about it17:17
anteayamore welcome but I don't see how I can get everyone together at teh same time17:17
*** Manshoon has joined #openstack-cinder17:17
*** Apoorva has joined #openstack-cinder17:17
*** annegent_ has joined #openstack-cinder17:18
*** Manshoon has quit IRC17:18
cebrunsDuncanT: +1 - I like the idea of finding "good enough" in this situation too.17:18
anteayaso we could work in here or -dev or a meeting channel17:18
anteayawhatever folks want as long as they have scroll back to share with others17:18
*** Manshoon has joined #openstack-cinder17:18
*** annegent_ has quit IRC17:18
dulekthingee, DuncanT, winston-d: Okay, so I'll try to come up with a patch tomorrow.17:19
anteayadoes anyone have an opinion?17:20
*** annegent_ has joined #openstack-cinder17:21
winston-ddulek: thx, looking forward to it.17:21
*** asselin has joined #openstack-cinder17:21
*** ronis has joined #openstack-cinder17:21
*** jamielennox is now known as jamielennox|away17:22
winston-dhemna: https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L47-L448 this is the part, where cinder vol API extracts information that needs to a create request.17:22
*** jistr has quit IRC17:22
hemnawinston-d, looking for the scheduler_hints17:23
anteayabecause I have to admit I do have an expectation when a patch is up for a new job that more than one cinder person knows what is going on with the proposed job17:23
winston-dhemna: for example: this is how 'availablity_zone' is extracted from the original create request.17:23
anteayaso if I have that expectation I am willing to do the work to fill in the gaps to meet that expectation17:23
winston-dhemna: https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L399-L40117:23
hemnawinston-d, but isn't that too late?17:24
*** nellysmitt has joined #openstack-cinder17:24
hemnathis is after the scheduler has picked the host17:24
hemnaoh this is a taskflow on the API side ?17:24
winston-dhemna: nono, this is before the request being sent out to scheduler17:24
hemnaok17:25
*** Manshoon_ has joined #openstack-cinder17:25
winston-dhemna: that's how the request being sent to scheduler is constructed/composed17:25
*** Manshoon_ has quit IRC17:25
hemnaso add a new multiattach: (True/False) to the return of execute?17:25
*** dulek has quit IRC17:25
hemnastill unsure if that's sufficient17:25
hemnaas I don't see any hints in there17:26
*** Manshoon_ has joined #openstack-cinder17:26
winston-dhemna: you can add a static method in this ExtractVolumeRequestTask, say, _extract_multiattach_flag, from vol metadata, and put it into request spec17:26
winston-dhemna: scheduler_hint was extracted even earlier, at C API17:27
winston-dhemna: I suggest do multiattach thing heree, scheduler hint is a bit differnt, it has it's own API extension.17:27
*** Yogi1 has joined #openstack-cinder17:28
*** Apoorva_ has joined #openstack-cinder17:28
hemnaso I'm looking in there to see where the request_spec is used17:28
*** Manshoon has quit IRC17:28
hemnathe VolumeCastTask pulls values from a request_spec dict.17:29
hemna*sigh* taskflow17:29
*** rwsu has quit IRC17:29
*** jamielennox|away is now known as jamielennox17:30
*** Apoorva has quit IRC17:31
hemnaI don't see any request_specs being used or returned in the ExtractVolumeRequestTask17:32
hemnawinston-d, the scheduler_hints are set here: https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L74717:33
hemnacan't I just inject scheduler_hints['multiattach'] = True/False there ?17:34
*** annegent_ has quit IRC17:34
*** rwsu has joined #openstack-cinder17:34
*** annegent_ has joined #openstack-cinder17:35
winston-dhemna: my understanding is every task's output is the next task's input, so what ExtractVolumeRequestTask returns is consumed by EntryCreateTask.17:35
hemnaI see the that VolumeCastTask requires scheduler_hints17:35
hemnathe scheduler_hints must be set somewhere else17:37
e0newinston-d: +117:37
*** Ilja has quit IRC17:37
winston-dhemna: problem with scheduler_hints is it only be consumed in filter, if you put it in there, you will have to add a new Multiattach filter17:38
winston-dhemna: which i guess you don't17:38
hemnaok17:38
hemnathat's what I was trying to avoid17:38
hemnaas the filter can be removed at deployment time no?17:39
hemnaI need to inject something to test against a capability17:39
hemnawhich is what I thought the scheduler_hints did17:39
hemna?17:39
hemnano?17:39
*** dannywilson has quit IRC17:39
winston-dhemna: scheduler_hint relies one an API extension to work, which can also be turned off in a deployment.17:40
hemnasure17:40
*** annegent_ has quit IRC17:40
hemnabut we can also inject it in the API flow if it doesn't exist17:41
*** Manshoon_ has quit IRC17:41
hemnaI guess I'm trying to understand how I can get the volume multiattach flag to be compared to a capability reporting by the drivers17:41
winston-dhemna: ok, let me try again.17:42
hemnawinston-d, so fwiw, here is where the multiattach flag is set https://review.openstack.org/#/c/85847/35/cinder/api/v2/volumes.py17:43
*** annegent_ has joined #openstack-cinder17:43
openstackgerritSteven Kaufer proposed openstack/python-cinderclient: Adopt CLI sorting argument guidelines  https://review.openstack.org/14591317:43
*** leeantho has joined #openstack-cinder17:44
*** btran has joined #openstack-cinder17:46
winston-dhemna: ahha, you already deal with that flag in API create flow: https://review.openstack.org/#/c/85847/35/cinder/volume/flows/api/create_volume.py17:46
*** jordanP has quit IRC17:46
winston-dhemna: which is good17:47
hemnayah, but can the scheduler compare that against capabilities ?17:47
hemnaI think that's just passed through to the manager to set the flag in the DB, currently17:48
*** EmilienM is now known as EmilienM|afk17:49
winston-dhemna: not yet, you forgot the modify the ExtractVolumeReuquestTask to let it return what EntryCreateTask need (the additional multiattach flag).17:49
*** leeantho has quit IRC17:49
hemnawinston-d, it's working though17:49
winston-dhemna: hmm17:50
hemnathat flag is getting set correctly and the volume manager sees it17:50
winston-dhemna: i'm new to taskflow. :)17:50
hemnayah, same here17:50
hemnait's hard to follow17:50
*** karimb has quit IRC17:51
*** leeantho has joined #openstack-cinder17:53
winston-dhemna: sorry, i need some time to check the code to make sure I don't mislead you.17:55
hemnawinston-d, ok np17:55
hemnawinston-d, chew on it while you sleep :)17:55
winston-dhemna: no, i'm pretty close now17:55
*** kallebe has quit IRC17:56
*** jcru has quit IRC17:57
winston-dhemna: first thing, CapablitiesFilter only looks at 'extra_specs' in request_spec['resource_type'], that comes from volume  type extra specs: https://github.com/openstack/cinder/blob/master/cinder/openstack/common/scheduler/filters/capabilities_filter.py#L3317:57
hemnayah17:58
hemnathat's what I was afraid of17:58
winston-dhemna: so in order to make scheduler check multiattach flag against backend capabilities, we need to find a way to inject that into extra specs, which is doable17:58
*** ebalduf has joined #openstack-cinder17:59
winston-dhemna: 'resource_type' was added to 'filter_properties' here: https://github.com/openstack/cinder/blob/master/cinder/scheduler/filter_scheduler.py#L26817:59
winston-dhemna: this can be the point to inject multiattach flag into extra specs18:00
*** cnesa has quit IRC18:00
hemnaso that's just the volume type id no ?18:00
*** annegent_ has quit IRC18:00
hemnanot the extra specs18:00
hemnahuh18:01
hemnaline 267 and 268 do the same thing?18:01
hemnavolume_type and resource_type18:01
winston-dhemna: yeah, that's becasuse Nova uses 'instance_type' insetad of 'volume_type', so to be able to put CapFilter to oslo, I did some dupication here.18:02
hemnaoh I see18:02
hemnagot it18:02
*** jamielennox is now known as jamielennox|away18:02
hemnaso if there is no volume_type specified that will be None18:03
hemnaor it will have the volume_type uuid no ?18:03
hemnaick18:03
*** kallebe has joined #openstack-cinder18:03
hemnaI'm guessing something else extracts extra_specs later on ?18:04
*** ebalduf has quit IRC18:04
*** yuriy_n17 has quit IRC18:04
*** Mandell has joined #openstack-cinder18:04
hemnawinston-d, https://github.com/openstack/cinder/blob/master/cinder/scheduler/filter_scheduler.py#L34018:05
winston-dhemna: volume type was added here: https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L41018:05
hemnadoesn't that look like it's injecting  something into extra specs ?18:05
hemnaxyang,18:05
winston-dhemna: yes, she did18:05
hemnaso can't I just do the same thing there?18:06
winston-dhemna: yes, you can. :)18:06
winston-dhemna: glad you find that out youself.18:07
hemnaresource_type['extra_specs'].update(multiattach='<is> True')18:07
hemna?18:07
hemnaif the multiattach flag is set to true on the volume of course18:07
hemnaI guess I can try that18:08
hemnano driver is reporting that capability today18:08
winston-dhemna: you can do the simliar check like xyang has done, in case some admin put 'multiattach' into type extra sepcs already18:08
hemnaso as soon as I add that, my create requests should fail with no host found right ?18:08
hemnayah18:08
winston-dhemna: yes18:08
hemnaok cool.18:08
hemna:)18:08
hemnawinston-d, thanks for your help.18:08
hemna:)18:08
winston-dhemna: the reporting part can be a separate patch against vol manage and sch host manager18:09
winston-dhemna: let it be a 'standard'/manditory capablities that every backend shouuld report18:09
hemnawhich is just updates to drivers capabilityes right ?18:09
hemnawinston-d, there is something that enforces those 'standard' capabilities ?18:10
winston-dhemna: yes, it can be like that, but since this is a generic enough capabilties, I suggeest adding it to host manager like these: https://github.com/openstack/cinder/blob/master/cinder/scheduler/host_manager.py#L100-L12018:11
*** annashen has joined #openstack-cinder18:11
hemnaok18:12
winston-dhemna: we can take care of that part later.18:12
hemnaok cool :)18:12
*** Anticimex has quit IRC18:12
hemnaso for now I'll update my existing patch to inject the extra spec18:12
*** vilobhmm has joined #openstack-cinder18:12
*** vilobhmm1 has joined #openstack-cinder18:13
hemnahopefully that'll make DuncanT happy18:13
winston-dhemna: yes, correct18:13
winston-dhemna: sorry I havn't reviewed your multiattach patch for quite some time18:13
hemnait's ok.  it hasn't gotten much love from anyone in K.18:13
*** deepakcs has quit IRC18:14
hemnajdg looked at it a few times early on18:14
*** deepakcs has joined #openstack-cinder18:14
*** _cjones_ has quit IRC18:15
winston-dhemna: i have been occupied more than b4 in K, so short on reviews. sorry about that, hopefully can do better in L18:15
*** jamielennox|away is now known as jamielennox18:15
hemnaheh work gets in the way :)18:15
hemnawinston-d, ok I'm off to a meeting.   thanks for the help!18:15
winston-dhemna: ok, let me know if you have any question/issues with scheduler, i'd be happy to help18:16
hemnawinston-d, great.  thanks man.  you rock!18:16
winston-dhemna: take care, i'm getting off to get some sleep now.18:16
*** winston-d is now known as winston-d_zZZ18:16
*** nikesh_vedams has joined #openstack-cinder18:16
nikesh_vedamshi18:17
*** vilobhmm has quit IRC18:17
nikesh_vedamssomething wrong in review.openstack.org18:18
nikesh_vedamsis server down18:18
*** Anticimex has joined #openstack-cinder18:18
*** deepakcs has quit IRC18:18
nikesh_vedamsi was trying to see uploaded cinder patch18:19
nikesh_vedamsbut its not opening from half an hour18:19
e0nenikesh_vedams: hi. it's working for me18:22
*** aix has quit IRC18:25
*** patrickeast has joined #openstack-cinder18:26
nikesh_vedamse0ne: hmm i m getting "The server at review.openstack.org is taking too long to respond."18:27
nikesh_vedamsi m from india18:27
bswartznikesh_vedams: are you using the right port number?18:28
*** Miouge has quit IRC18:28
e0nenikesh_vedams: http://www.downforeveryoneorjustme.com/review.openstack.org18:28
*** alecv has quit IRC18:28
e0nenikesh_vedams: maybe your provider blocks it18:28
bswartzMake sure you're SSHing to port 29418, and make sure there's not a firewall blocking that port18:29
*** _cjones_ has joined #openstack-cinder18:29
bswartzeharney: ping18:29
eharneybswartz: hi18:30
kallebenikesh_vedams you can test if the port is available to you with command18:30
kallebenc -zw3 review.openstack.org 29418 && echo "opened" || echo "closed"18:30
*** Adriano_ has joined #openstack-cinder18:30
bswartzkallebe: +118:32
nikesh_vedamskallebe: i am using windows18:32
nikesh_vedamskallebe : on my linux vm its giving opened18:33
*** MasterPiece has quit IRC18:33
nikesh_vedamskallebe :but my desktop is windows18:33
kallebenikesh_vedams so it is open for you. Maybe the problem is not the port18:33
bswartzmaybe windows is firewalling the outgoing connection?18:34
bswartzsubmit the patch from a linux box18:34
*** MasterPiece has joined #openstack-cinder18:35
bswartznikesh_vedams: one other thing to check is to make sure that you've added you SSH pubkey to gerrit18:35
*** rushiagr is now known as rushiagr_away18:35
bswartzif you forget that step then git review won't work18:36
kallebeyes. you paste your ssh key here https://review.openstack.org/#/settings/ssh-keys18:36
nikesh_vedamsbswartz : hmm i just wanted to see web version of review,i already submiteed patch18:37
nikesh_vedamsssh key added for linux18:37
*** afazekas_ has quit IRC18:40
*** avishay has joined #openstack-cinder18:40
nikesh_vedamsnc -zw3 review.openstack.org 29418 && echo "opened" || echo "closed"18:41
*** BharatK has quit IRC18:42
nikesh_vedamsi tried on another linux desktop ,its giving opened but on browser of linux desktop review.openstack.org not opening18:42
nikesh_vedamswas trying to open "https://review.openstack.org/#/c/159156/" in linux desktop browser18:43
kallebemaybe it is a DNS problem for your browser case?18:45
kallebetry on linux18:45
kallebenslookup review.openstack.org18:45
*** Manshoon has joined #openstack-cinder18:47
nikesh_vedamshmm upto evening everything was working fine18:47
kallebeIf it is a DNS problem, you can try access the IP directly. nslookup returns the direct IP18:47
kallebefor example, here it gives 23.253.232.87 for review.openstack.org18:47
openstackgerritMikhail Khodos proposed openstack/cinder: Nexenta Edge iSCSI backend driver.  https://review.openstack.org/15874518:49
*** dannywilson has joined #openstack-cinder18:49
*** jcru has joined #openstack-cinder18:50
*** jkremer has joined #openstack-cinder18:51
openstackgerritSteven Kaufer proposed openstack/python-cinderclient: Adopt CLI sorting argument guidelines  https://review.openstack.org/14591318:52
*** nellysmitt has quit IRC18:53
*** dannywilson has quit IRC18:54
*** dannywilson has joined #openstack-cinder18:54
*** jgravel_ has joined #openstack-cinder18:57
*** ebalduf has joined #openstack-cinder19:00
*** rhagarty has joined #openstack-cinder19:00
*** annegent_ has joined #openstack-cinder19:01
nikesh_vedamskallebe bswartz : looks like some problem in my ISP19:01
kallebenikesh_vedams yes, maybe it is indeed. Have you tried with the direct IP?19:02
nikesh_vedamsyes19:02
nikesh_vedamsits not pinging continuously19:02
kallebeit must be losing packets then19:03
nikesh_vedamsmight be19:04
nikesh_vedamsi will talk to my network admin19:04
nikesh_vedamsthanks19:04
nikesh_vedamsall19:04
*** ebalduf has quit IRC19:04
bswartznikesh_vedams: from your VM you were able to contact gerrit, so transfer your code to that VM and submit it from there19:05
*** annegent_ has quit IRC19:06
kallebeI agree with bswartz. You can use WinSCP to transfer the files from windows to your VM19:06
bswartzor better yet, commit the changes to a remote git repo from the windows box, and pull them down from the git repo on the other box19:07
bswartzaccounts on github are free...19:07
nikesh_vedamshmm i able to submit patch but to see the reviews19:10
nikesh_vedamsi wanted to open in browser19:11
nikesh_vedams:)19:11
bswartznikesh_vedams: presumably your VM can connect to review.openstack.org19:11
nikesh_vedamsyes19:11
bswartztunnel your browser session over an SSH connection to the VM19:11
nikesh_vedamsok19:11
bswartzssh -D 1080 user@host19:11
*** Manshoon has quit IRC19:11
nikesh_vedamsthanks19:11
bswartzconfigure your browser to use a SOCKS proxy of localhost:108019:11
bswartzand you're good to go19:11
*** Manshoon has joined #openstack-cinder19:12
bswartzif you're on windows and using PuTTY, putty has a feature called "dynamic port forwarding" which does the same thing19:12
nikesh_vedamsok19:13
bswartzI have the opposite situation -- I have Linux on my laptop and I run Windows in a VM for those time when I need to open a powerpoint doc19:14
*** annegent_ has joined #openstack-cinder19:18
*** nikesh_vedams has quit IRC19:18
*** Manshoon_ has joined #openstack-cinder19:18
jgriffithbswartz: what's this "power point" thing that you speak of?19:18
jgriffith:)19:18
*** Manshoon_ has quit IRC19:19
bswartzjgriffith: something I avoid whenever possible19:19
*** Manshoon_ has joined #openstack-cinder19:19
jgriffithbswartz: haha... good answer19:19
bswartzactually I'm pretty happy -- I've only needed to create 1 powerpoint in the last 6 months19:20
*** jcru has quit IRC19:20
*** Mandell has quit IRC19:21
*** timcl has quit IRC19:22
*** Manshoon has quit IRC19:22
*** avishay has quit IRC19:23
*** avishay has joined #openstack-cinder19:24
*** nikesh_vedams has joined #openstack-cinder19:24
*** nikesh_vedams has quit IRC19:24
openstackgerritarkady kanevsky proposed openstack/cinder: fix for infinity capacity reporting in EQL driver  https://review.openstack.org/15923119:24
*** nikesh_vedams has joined #openstack-cinder19:25
*** PaulCuzner has quit IRC19:25
*** timcl has joined #openstack-cinder19:26
*** timcl has quit IRC19:27
*** jcru has joined #openstack-cinder19:27
*** Manshoon has joined #openstack-cinder19:31
*** timcl has joined #openstack-cinder19:31
*** annashen has quit IRC19:32
*** asmith_brcd has joined #openstack-cinder19:32
*** timcl has quit IRC19:33
*** Manshoon has quit IRC19:34
*** Manshoon_ has quit IRC19:34
*** Manshoon has joined #openstack-cinder19:35
*** tsekiyam_ has quit IRC19:35
*** jgravel_ has quit IRC19:36
*** annashen has joined #openstack-cinder19:39
*** annegent_ has quit IRC19:42
nikesh_vedamshttps://review.openstack.org/#/c/157356/19:44
nikesh_vedamshttps://review.openstack.org/#/c/159156/19:44
*** annegent_ has joined #openstack-cinder19:44
nikesh_vedamsplease provide your valuable reviews19:44
nikesh_vedams:)19:44
nikesh_vedamsgoing to bed,19:46
openstackgerritarkady kanevsky proposed openstack/cinder: fix for infinity capacity reporting in EQL driver  https://review.openstack.org/15923119:49
*** e0ne has quit IRC19:50
*** tsekiyama has joined #openstack-cinder19:50
*** tsekiyama has quit IRC19:50
openstackgerritarkady kanevsky proposed openstack/cinder: Fix for infinity capacity reporting in EQL driver  https://review.openstack.org/15923119:51
*** kallebe has left #openstack-cinder19:52
*** tsekiyama has joined #openstack-cinder19:56
*** tsekiyama has quit IRC19:56
*** tsekiyama has joined #openstack-cinder19:57
*** ebalduf has joined #openstack-cinder20:01
*** annegent_ has quit IRC20:01
*** tsekiyama has quit IRC20:01
*** timcl has joined #openstack-cinder20:03
*** ebalduf has quit IRC20:05
*** gugl has joined #openstack-cinder20:06
*** emagana has quit IRC20:08
*** emagana has joined #openstack-cinder20:11
*** annegent_ has joined #openstack-cinder20:13
*** Manshoon has quit IRC20:13
*** mriedem has quit IRC20:14
*** emagana has quit IRC20:16
patrickeastthingee: ping20:18
*** Apoorva_ has quit IRC20:19
*** Apoorva has joined #openstack-cinder20:20
jungleboyjpatrickeast: Sounded like he was going to be away for a while after this morning's meeting.20:20
patrickeastjungleboyj: ok, thanks!20:20
*** annegent_ has quit IRC20:21
jungleboyjpatrickeast: Not my day to watch him, but that was what I got out of discussion this morning.  ;-)20:21
patrickeasthaha20:21
*** annegent_ has joined #openstack-cinder20:21
*** Manshoon has joined #openstack-cinder20:21
*** Manshoon has quit IRC20:24
*** Manshoon has joined #openstack-cinder20:24
*** Mandell has joined #openstack-cinder20:25
*** mriedem has joined #openstack-cinder20:25
*** avishay has quit IRC20:27
*** annegent_ has quit IRC20:27
*** avishay has joined #openstack-cinder20:28
*** diemt has quit IRC20:30
*** emagana has joined #openstack-cinder20:30
*** lpetrut has joined #openstack-cinder20:32
*** cpallares has quit IRC20:32
*** cpallares has joined #openstack-cinder20:32
*** avishay has quit IRC20:35
*** Lee1092 has quit IRC20:40
openstackgerritPatrick East proposed openstack/cinder: PureISCSIDriver consistency group updates.  https://review.openstack.org/15763720:45
*** IanGovett1 has quit IRC20:47
*** PaulCuzner has joined #openstack-cinder20:47
*** IanGovett has joined #openstack-cinder20:49
*** Manshoon_ has joined #openstack-cinder20:50
*** dustins has quit IRC20:51
*** Manshoon has quit IRC20:51
*** MasterPiece has quit IRC20:55
*** IanGovett1 has joined #openstack-cinder20:55
*** IanGovett has quit IRC20:56
*** MasterPiece has joined #openstack-cinder20:57
anishjgriffith: thingee should I be closing this bug out  https://bugs.launchpad.net/cinder/+bug/1417499 ?20:58
openstackLaunchpad bug 1417499 in Cinder "Cert test of devstack setup with LVM and chiscsi iscsi_helper" [Undecided,New]20:58
*** lpetrut has quit IRC20:58
*** timcl has left #openstack-cinder20:59
openstackgerritMitsuhiro Tanino proposed openstack/cinder: Clear migration_status from a destination volume if migration fails  https://review.openstack.org/15473921:01
*** ebalduf has joined #openstack-cinder21:01
*** karimb has joined #openstack-cinder21:02
*** Ilja has joined #openstack-cinder21:04
*** Manshoon has joined #openstack-cinder21:04
*** Manshoon has quit IRC21:05
*** Manshoon has joined #openstack-cinder21:05
*** ebalduf has quit IRC21:06
*** Manshoon_ has quit IRC21:08
*** annashen has quit IRC21:08
openstackgerritBob Callaway proposed openstack/cinder: Add Manage/Unmanage support to NetApp NFS drivers  https://review.openstack.org/15886421:08
*** sseverson has quit IRC21:09
*** nikesh_vedams has quit IRC21:11
*** gugl has quit IRC21:13
*** cdelatte has quit IRC21:15
*** nikesh_vedams has joined #openstack-cinder21:15
*** dannywil_ has joined #openstack-cinder21:19
*** Yogi1 has quit IRC21:22
*** dannywilson has quit IRC21:23
*** takedakn has joined #openstack-cinder21:23
*** annashen has joined #openstack-cinder21:23
*** dannywil_ has quit IRC21:26
*** ronis has quit IRC21:26
*** jcru has quit IRC21:26
*** dannywilson has joined #openstack-cinder21:27
*** tbarron has quit IRC21:30
*** akerr has quit IRC21:31
openstackgerritBob Callaway proposed openstack/cinder: NetApp eseries implementation for manage/unmanage  https://review.openstack.org/13809321:31
*** dannywilson has quit IRC21:31
*** bswartz has quit IRC21:33
*** markvoelker has quit IRC21:35
*** markvoelker has joined #openstack-cinder21:36
*** jcru has joined #openstack-cinder21:39
*** markvoelker has quit IRC21:40
*** markvoelker has joined #openstack-cinder21:42
guitarzanhey folks, does anyone know anything about scheduler hints?21:44
guitarzanI guess it's in the client, just no help text maybe?21:45
*** tbarron has joined #openstack-cinder21:46
openstackgerritThang Pham proposed openstack/cinder: VMware: Add vmware:adapter_type extra spec  https://review.openstack.org/15926021:48
*** takedakn has quit IRC21:48
guitarzannevermind, even simpler than that, have to specify v2 in the client...21:50
openstackgerritThang Pham proposed openstack/cinder: VMware: Add vmware:adapter_type extra spec  https://review.openstack.org/15926021:51
*** thangp has quit IRC21:52
jungleboyjhemna and/or xyang ping21:56
hemnajungleboyj, sup21:56
jungleboyjNeed to run something by you.21:57
*** jcru has quit IRC21:57
jungleboyjhemna: Trying to move over to using the new config generator so we can remove the old oslo-config from oslo-incubator.21:57
hemnak21:57
*** Mandell has quit IRC21:58
jungleboyjThe bad thing, is the new generator uses entry points to get the config options instead of being sent a list of files.21:58
hemnaew21:58
hemnaso the existing file that has our requires doesn't work ?21:59
jungleboyjI am trying to figure out the best way to implement this.  Talked to Doug and he said we can either put the list in the setup.cfg .21:59
jungleboyjhemna: Which file?21:59
hemnaopenstack-common.conf21:59
jungleboyjhemna: Different issue I am talking about.21:59
hemnaoh22:00
* hemna is confused then22:00
jungleboyjhemna: I am talking about telling oslo-config-generator where all our config options are to create a cinder.conf.sample22:00
hemnaoh that.22:00
jungleboyjThere are two ways I can do this.  Like keystone:  https://github.com/openstack/keystone/blob/master/setup.cfg#L6622:01
jungleboyjthough we would have a list of like 70 files in there.22:01
jungleboyjOr, like oslo.concurrency:  https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/opts.py#L2622:01
*** jcru has joined #openstack-cinder22:02
*** jdurgin has quit IRC22:02
jungleboyjWhere I would add an options file that basically pulls all the options out of all of the other files as a single entry point for the config generator.22:02
*** ebalduf has joined #openstack-cinder22:02
jungleboyjEither way, if new files that are adding configuration options come along we need to make sure that whatever place we choose is updated accordingly.22:03
hemnadang22:03
hemnathat really sux22:03
hemnaso we'll have to catch that in reviews.22:03
jungleboyjhemna:  Agreed.  Yes.22:03
hemnaunless we have a hacking check22:03
jungleboyjOooh, Hmmm ...22:03
hemnaputs more of a burden on reviewers22:03
hemnabecause we don't have enough to watch for already.22:04
jungleboyjLets see, I think I could do a hacking check.22:04
jungleboyjIf a file has 'cfg' in it, make sure it is listed where it needs to be.22:04
hemnayah that might be doable22:05
jungleboyjSo, do you think it is better to add cinder/options.py that basically pulls everything in as a single entry point?22:06
jungleboyjThen I just have to check that file to make sure that it has the right module listed if there are opts included?22:06
hemnayah that seems like a simpler thing to manage no?22:07
*** ebalduf has quit IRC22:07
jungleboyjYeah, probably better than a big ugly setup.cfg file.22:07
*** Manshoon has quit IRC22:07
*** jdurgin has joined #openstack-cinder22:07
*** Manshoon has joined #openstack-cinder22:08
*** Manshoon has quit IRC22:08
*** tbarron has quit IRC22:08
*** Manshoon has joined #openstack-cinder22:08
jungleboyjhemna: Thanks for the input.  I will work on getting that coded up.22:09
hemnagood luck :)22:09
jungleboyjSee if I can figure out a way to do the hacking check.22:09
jungleboyjhemna: Bout time I had to write some real code.22:09
hemna:)22:10
*** annashen has quit IRC22:14
*** markstur_ has joined #openstack-cinder22:15
*** markstur_ has quit IRC22:16
*** markstur has quit IRC22:16
*** annashen has joined #openstack-cinder22:17
*** markstur has joined #openstack-cinder22:20
*** mriedem has quit IRC22:26
*** jungleboyj has quit IRC22:26
*** scottda has quit IRC22:27
*** Mandell has joined #openstack-cinder22:28
*** rushil has quit IRC22:30
*** esker has quit IRC22:33
*** amoturi has quit IRC22:36
*** cdelatte has joined #openstack-cinder22:40
*** delattec has joined #openstack-cinder22:40
*** emagana has quit IRC22:40
*** emagana has joined #openstack-cinder22:41
*** karimb has quit IRC22:45
*** emagana has quit IRC22:45
*** bswartz has joined #openstack-cinder22:46
*** eharney has quit IRC22:47
*** Ilja has quit IRC22:48
*** kaufer has quit IRC22:49
*** eharney has joined #openstack-cinder22:50
*** Manshoon has quit IRC22:50
*** jcru has quit IRC22:57
*** Apoorva_ has joined #openstack-cinder22:58
*** asselin_ has joined #openstack-cinder23:00
*** Apoorva has quit IRC23:01
*** Adriano_ has quit IRC23:02
*** ebalduf has joined #openstack-cinder23:03
*** asselin_ has quit IRC23:04
*** dannywilson has joined #openstack-cinder23:05
*** dannywilson has quit IRC23:05
*** dannywilson has joined #openstack-cinder23:06
*** diegows has joined #openstack-cinder23:06
*** ebalduf has quit IRC23:07
*** jcru has joined #openstack-cinder23:09
*** erlon has quit IRC23:11
*** jkremer has quit IRC23:12
*** ganso_ has quit IRC23:17
thingeepatrickeast: hey23:23
thingeeanish: sure23:23
*** jungleboyj has joined #openstack-cinder23:24
thingeejungleboyj: thanks for taking my pings today ;)23:24
patrickeastthingee: hey, just wanted to check in on the initiator data table thing now that the spec is merged if the bp’s https://blueprints.launchpad.net/cinder/+spec/driver-private-data & https://blueprints.launchpad.net/cinder/+spec/pure-iscsi-chap-support should get targeted for k-323:24
anishthingee: ty !23:25
jungleboyjthingee: Welcome.  I think there was just the one.23:25
jungleboyjthingee: Even thought it wasn't my day to watch you.23:26
patrickeastthingee: thanks!23:26
thingeepatrickeast: done and added to https://etherpad.openstack.org/p/cinder-k3-priorities23:28
patrickeastawesome23:28
jungleboyjthingee: Did you see the conversation that hemna and I had about oslo-config-generator earlier?23:28
thingeejungleboyj: it wasn't you're day? are there are other days that you watch me?23:28
thingeeyour*23:28
jungleboyj;-)  I plead the 5th.23:29
thingeeI can't type today23:32
thingeeanyways23:32
thingeejungleboyj: regarding your convo with hemna, either way you're going to have update the setup.cfg entrypoints or thing options.py file with the options it deep copies, right?23:33
*** dannywilson has quit IRC23:33
thingeejungleboyj: I didn't immediately see the benfit of the options.py solution.23:33
thingeerather, I still don't.23:34
thingeeI'm sure I'm missing something though23:34
jungleboyjEither way, yes, we will have to update one of the files.  I think having a giant setup.cfg is ugly and I think it will be easier to write a hacking check against the options.py file.23:37
*** afazekas has quit IRC23:37
jungleboyjthingee: ^^23:37
jungleboyjthingee: Unless you have a strong aversion to that.23:37
*** markvoelker has quit IRC23:42
*** markvoelker has joined #openstack-cinder23:42
*** chlong has quit IRC23:43
*** chlong_ has quit IRC23:44
thingeejungleboyj: Ah I see now. Well configparser should definitely allow you to read the cfg file for hacking purposes.23:46
*** Apoorva_ has quit IRC23:46
* thingee looks through other projects to see what they're doing23:46
*** Apoorva has joined #openstack-cinder23:46
jungleboyjthingee: I looked at Nova and I don't think they have moved yet.  Keystone does the setup.cfg wile oslo uses the options file.23:47
thingeeglance does the same as keystone23:47
thingeesame with heat23:47
*** markvoelker has quit IRC23:47
*** chlong has joined #openstack-cinder23:48
*** jcru has quit IRC23:48
*** asselin_ has joined #openstack-cinder23:48
thingeeceilometer too23:48
jungleboyjOk, so you prefer all the entry points in setup.cfg then?23:48
jungleboyjhemna: Concerns with me going that route?23:49
*** markvoelker has joined #openstack-cinder23:49
thingeeI prefer being consistent. I don't have a strong opinion where it should go myself23:49
hemnawell if others are doing it23:49
hemnathen there is safety in numbers I suppose23:49
hemnait'll suck for all projects equally.23:49
thingeejungleboyj: can you ask in the oslo meeting this friday?23:49
thingeewhat liasons plan to do who haven't moved23:50
jungleboyjthingee: I suppose so.  dhellmann didn't indicate a preference when I talked to him.23:50
thingeeregardless, I trust you to make a good decision. I'd prefer OpenStack projects to be similar with this, but maybe not everyone agrees. if there is no consensus, we can just do our own thing23:51
thingeeof what we think is better looking23:52
hemnathingee, re: _LI, _LW, _LE >23:52
hemna?23:52
hemna:P23:52
hemnaignore me.  I'm just stirring a pot23:52
jungleboyjbrb, need to eat dinner with family.23:52
thingeedoh23:52
hemnaImportError: No module named oslo_vmware23:53
hemnaugh23:53
thingee:(23:53
thingeewhere are you seeing that23:53
hemnamy local dev23:53
hemnarunning tox23:53
hemnamaybe I need to rebase, dunno23:53
thingeeor recreate the environment23:53
thingeetox -r23:54
hemnathingee, so fwiw, I have the scheduler change locally for multiattach23:54
hemnaand it's workin23:54
hemnaso, just going through the motions with tox to ensure no tests break and then I'll push up a new patchset for cinder multiattac23:54
thingeehemna: is jaypipes trying this out at all locally, or any other interested parties23:54
hemnahopefully that'll make Duncan hapy.23:54
hemnaif only I could type23:55
hemnaI think he and Tobias had tested it out locally23:55
hemnaafaik jaypipes wrote the nova tempest tests23:55
thingeeif he can sign off it's working locally with the tempest tests, and you can sign off testing it, that's good to me23:56
thingeejaypipes: ^23:56
hemnabut for K, nova isn't landing so any cinder/cinderclient changes have to work against existing nova.  which it already does afaik.23:56
hemnaI'm just adding in a change to the filter scheduler to allow testing multiattach flag setting against driver capabilities23:56
jaypipesthingee: I have not yet, no :(23:56
hemnadoh23:57
thingeejaypipes: even manually testing works for me. I just need to people to try it. It's pretty late, but I'll review it if people I trust can sign off.23:57
*** tbarron has joined #openstack-cinder23:57
jaypipesthingee: DuncanT was pretty adamant about waiting until L...23:58
openstackgerritAnish Bhatt proposed openstack/cinder: Add partial unit tests for IET driver  https://review.openstack.org/15892523:58
* thingee puts on sunglasses23:58
anishmtanino: done23:58
mtaninoanish: very quick :)23:59
anishit was a one line change :)23:59
mtaninoanish: I need cross review with my coworker :)23:59
*** asmith_brcd has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!