| *** openstack has joined #openstack-cinder | 15:06 | |
| *** lpetrut has quit IRC | 15:10 | |
| *** EduardBiceriMate has quit IRC | 15:12 | |
| *** mdenny has joined #openstack-cinder | 15:13 | |
| *** med_ has quit IRC | 15:13 | |
| *** eharney has joined #openstack-cinder | 15:13 | |
| *** eharney has quit IRC | 15:13 | |
| *** eharney has joined #openstack-cinder | 15:13 | |
| *** med_ has joined #openstack-cinder | 15:13 | |
| *** tristanC_ has joined #openstack-cinder | 15:13 | |
| *** med_ has quit IRC | 15:14 | |
| *** med_ has joined #openstack-cinder | 15:14 | |
| *** tristanC has quit IRC | 15:14 | |
| *** afazekas has quit IRC | 15:21 | |
| *** cl__ has joined #openstack-cinder | 15:26 | |
| *** tsekiyama has joined #openstack-cinder | 15:27 | |
| *** scottda_ has joined #openstack-cinder | 15:27 | |
| *** jungleboyj has joined #openstack-cinder | 15:28 | |
| cl__ | Hi, anyone knows whether creating a boot volume from a raw image will result in a qcow2 format volume? | 15:29 |
|---|---|---|
| *** nellysmitt has joined #openstack-cinder | 15:30 | |
| *** fischerw has joined #openstack-cinder | 15:30 | |
| *** sgotliv has quit IRC | 15:30 | |
| *** mtanino has joined #openstack-cinder | 15:30 | |
| *** scottda_ has quit IRC | 15:32 | |
| *** lpetrut has joined #openstack-cinder | 15:33 | |
| *** mtanino_ has joined #openstack-cinder | 15:33 | |
| *** lpabon has joined #openstack-cinder | 15:34 | |
| *** mtanino has quit IRC | 15:35 | |
| *** nshaikh has quit IRC | 15:35 | |
| *** nlevinki has quit IRC | 15:36 | |
| *** alecv has quit IRC | 15:41 | |
| *** tristanC_ is now known as tristanC | 15:42 | |
| *** mtanino_ has quit IRC | 15:43 | |
| *** sgotliv has joined #openstack-cinder | 15:45 | |
| *** EduardBiceriMate has joined #openstack-cinder | 15:46 | |
| *** Masahiro has joined #openstack-cinder | 15:47 | |
| *** Yogi11 has joined #openstack-cinder | 15:49 | |
| *** bswartz has quit IRC | 15:51 | |
| *** tshefi has quit IRC | 15:51 | |
| *** Yogi1 has quit IRC | 15:51 | |
| *** Masahiro has quit IRC | 15:52 | |
| *** teju has joined #openstack-cinder | 15:52 | |
| *** ryanpetrello_ has joined #openstack-cinder | 15:54 | |
| *** mwichmann has joined #openstack-cinder | 15:55 | |
| *** mudassirlatif has joined #openstack-cinder | 15:56 | |
| *** ryanpetrello has quit IRC | 15:57 | |
| *** ryanpetrello_ is now known as ryanpetrello | 15:57 | |
| *** beekneemech is now known as bnemec | 16:01 | |
| *** mudassirlatif has quit IRC | 16:03 | |
| *** mudassirlatif has joined #openstack-cinder | 16:04 | |
| *** KurtMartin has joined #openstack-cinder | 16:04 | |
| *** openstackgerrit has quit IRC | 16:06 | |
| *** openstackgerrit has joined #openstack-cinder | 16:07 | |
| *** mudassirlatif has quit IRC | 16:12 | |
| *** david-ly_ is now known as david-lyle | 16:13 | |
| *** teju has quit IRC | 16:15 | |
| *** Yogi11 has quit IRC | 16:17 | |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/python-cinderclient: Add command to show pool information for backends https://review.openstack.org/144814 | 16:20 |
| *** mtanino has joined #openstack-cinder | 16:20 | |
| *** Yogi11 has joined #openstack-cinder | 16:20 | |
| *** david-lyle has quit IRC | 16:22 | |
| *** dannywilson has joined #openstack-cinder | 16:22 | |
| *** jwcroppe has joined #openstack-cinder | 16:23 | |
| *** mudassirlatif has joined #openstack-cinder | 16:25 | |
| *** _cjones_ has joined #openstack-cinder | 16:25 | |
| *** nellysmitt has quit IRC | 16:30 | |
| *** lpabon has quit IRC | 16:30 | |
| *** nellysmitt has joined #openstack-cinder | 16:31 | |
| *** rhe00_ has quit IRC | 16:31 | |
| *** jdurgin has joined #openstack-cinder | 16:32 | |
| *** junhongl has quit IRC | 16:34 | |
| *** junhongl has joined #openstack-cinder | 16:35 | |
| *** Longgeek has quit IRC | 16:35 | |
| *** Longgeek has joined #openstack-cinder | 16:35 | |
| *** nellysmitt has quit IRC | 16:35 | |
| *** lcurtis has joined #openstack-cinder | 16:38 | |
| *** rushiagr_away is now known as rushiagr | 16:40 | |
| *** rushiagr is now known as rushiagr_away | 16:42 | |
| *** Mandell has joined #openstack-cinder | 16:44 | |
| *** hemna has joined #openstack-cinder | 16:44 | |
| *** thingee has quit IRC | 16:47 | |
| *** nellysmitt has joined #openstack-cinder | 16:47 | |
| *** gary-smith has joined #openstack-cinder | 16:48 | |
| hemna | and so the break is over. back to work! | 16:48 |
| *** openstackgerrit has quit IRC | 16:51 | |
| *** openstackgerrit has joined #openstack-cinder | 16:51 | |
| *** nuritv has joined #openstack-cinder | 16:52 | |
| *** Mandell_ has joined #openstack-cinder | 16:52 | |
| *** Mandell has quit IRC | 16:55 | |
| *** mudassirlatif has quit IRC | 16:57 | |
| *** openstackgerrit has quit IRC | 17:04 | |
| *** openstackgerrit has joined #openstack-cinder | 17:04 | |
| *** cnesa has quit IRC | 17:05 | |
| *** dulek has quit IRC | 17:06 | |
| *** EmilienM is now known as EmilienM|afk | 17:07 | |
| jungleboyj | hemna: That is the word on the street. | 17:11 |
| *** pwehrle has quit IRC | 17:14 | |
| *** Yogi11 has quit IRC | 17:15 | |
| *** kfox1111 has joined #openstack-cinder | 17:19 | |
| *** KurtMartin has quit IRC | 17:22 | |
| kfox1111 | how do you git update a revew when somene else has posted an updated patch set? | 17:23 |
| jungleboyj | You need to download the review first with the latest patchset. | 17:23 |
| *** mikedillion has quit IRC | 17:24 | |
| jungleboyj | git review -d <review number> | 17:24 |
| *** KurtMartin has joined #openstack-cinder | 17:24 | |
| jungleboyj | kfox1111: ^^ | 17:24 |
| kfox1111 | k. thx. | 17:24 |
| *** KurtMartin has quit IRC | 17:24 | |
| *** KurtMartin has joined #openstack-cinder | 17:25 | |
| *** jistr has quit IRC | 17:25 | |
| kfox1111 | is there a way in the website to show the diff if things between patch sets? I'm interested in only what changed. | 17:27 |
| *** kmartin has quit IRC | 17:27 | |
| *** jpich has quit IRC | 17:28 | |
| jungleboyj | Yes. On the left hand side select the previous patch instead of the base. | 17:28 |
| *** rwsu has joined #openstack-cinder | 17:28 | |
| *** vedams-seeni_ has joined #openstack-cinder | 17:30 | |
| vedams-seeni_ | Hi everyone | 17:30 |
| vedams-seeni_ | anyone did benchmarking I/O ? | 17:31 |
| vedams-seeni_ | help me please | 17:31 |
| kfox1111 | jungleboyj: the review -d keeps updating the branch that depends on it, not the branch that is for that feature. is that expected? is there a way to tell it which branch to update? | 17:31 |
| jungleboyj | kfox1111: Wait, what are you trying to do? | 17:32 |
| jungleboyj | You want to pull down the latest patch, make changes and upload a new patch. Right? | 17:32 |
| kfox1111 | jungleboyj: I see a dropdown saying Reference version: base, and if I switch it to any of the other patches, I see a lot of changes that weren't made I think. | 17:32 |
| *** jdurgin has quit IRC | 17:33 | |
| kfox1111 | jungleboyj: I have two reviews.... 143553 - posix-backup-driver and 139737 - chunked-backup-base-class | 17:33 |
| kfox1111 | 143553 depends on 139737. | 17:33 |
| jungleboyj | Can you provide the links? | 17:33 |
| kfox1111 | I want to work on 139737. | 17:34 |
| kfox1111 | https://review.openstack.org/#/c/139737 | 17:34 |
| kfox1111 | while I was out on vacation, Tom helpfully committed some changes. I need to pull what he did, so I can continue to work. | 17:35 |
| *** Masahiro has joined #openstack-cinder | 17:36 | |
| jungleboyj | kfox1111: So, the easiest thing is just to go to a fresh checkout and then use the git command in the 'Download' section of the review. | 17:37 |
| jungleboyj | That will bring you up to the latest patch is out there. | 17:37 |
| kfox1111 | k. | 17:37 |
| kfox1111 | thx. | 17:37 |
| jungleboyj | Oh, I see why I had confused you. I mean git-review -d , not git -d . | 17:38 |
| jungleboyj | kfox1111: Sorry about that. | 17:39 |
| jungleboyj | git-review -d does basically the same thing as using the command from gerrit. | 17:39 |
| *** Masahiro has quit IRC | 17:41 | |
| vedams-seeni_ | anyone did benchmarking i/o? | 17:42 |
| tbarron | kfox1111: i have some pending changes in chunkeddriver.py. Our internal gerrit wasn't available over the holidays so I haven't got them pushed up yet. | 17:42 |
| tbarron | I'll probably just email them to you if you are planning to push up changes. | 17:43 |
| vedams-seeni_ | hi tbarron | 17:43 |
| vedams-seeni_ | hi junleboyj | 17:43 |
| tbarron | kfox1111: mostly just fixes for some good remarks from e0ne | 17:43 |
| jungleboyj | vedams-seeni_: Hi. No, I have not done benchmarking. | 17:44 |
| vedams-seeni_ | ok, thanks for your reply | 17:44 |
| tbarron | kfox1111: and also one substantive addition, namely an overridable method for getting "extra_metadata" | 17:44 |
| *** leeantho has joined #openstack-cinder | 17:44 | |
| tbarron | default method returns None. But we'll need it for class extensions. | 17:45 |
| tbarron | vedams-seeni_: nor I ... | 17:45 |
| kfox1111 | tbarron: ok. I'll wait until you post then. thanks again for the help. :) | 17:45 |
| dannywilson | ls | 17:45 |
| kfox1111 | cool. yeah. that'll be nice. | 17:45 |
| kfox1111 | thx. tbarron, nah, I was just going to see where things were at and address a couple of the minor comments that were made. but if you already have changes to push, its probably easier for you to do the couple of tweaks. | 17:46 |
| tbarron | kfox1111: either way, if you want to push first, that's fine. | 17:47 |
| kfox1111 | I havent made any changes yet. just trying to figure out how pulling works in gerrit. | 17:47 |
| kfox1111 | doesn't seem like multiple people working on the same feature is a common thing with gerrit. | 17:48 |
| tbarron | kfox1111: yeah, always doing commit --amend with multiple updaters is not the best :-) | 17:49 |
| tbarron | I'll get my stuff up there today and then won't likely be in the way going forwards - can send you remarks/suggestions on the side or in the review itself. | 17:50 |
| kfox1111 | ok. sounds like a plan. thanks. :) | 17:50 |
| *** tries has joined #openstack-cinder | 17:51 | |
| *** tries has joined #openstack-cinder | 17:51 | |
| kfox1111 | have you gotten a chance to look at unit test for the posix driver at all, or should I start working on that? | 17:51 |
| *** mudassirlatif has joined #openstack-cinder | 17:52 | |
| tbarron | kfox1111: I haven't done anything yet. I think we should do UTs for posix in a more contemporary fashion, using mock(), than what we see for Swift. | 17:55 |
| *** nkrinner has quit IRC | 17:55 | |
| tbarron | Just test the actual methods in the posix extension. | 17:55 |
| tbarron | in isolation from the workings of chunking, I/O, etc. | 17:56 |
| *** thingee has joined #openstack-cinder | 17:56 | |
| kfox1111 | yeah. I tried copying swifts unit tests for the previous posix driver, and it was rejected for using old code. :/ | 17:56 |
| tbarron | So it will mostly be testing that os.join() yields the expected results :-) | 17:57 |
| kfox1111 | unformtunatly, I'm not very familior with the new way, so it was REALLY slowing me down. :/ | 17:57 |
| tbarron | I can work on some unit tests for posix if you want. | 17:58 |
| kfox1111 | that would be awesome. | 17:58 |
| *** jordanP has quit IRC | 18:00 | |
| tbarron | kk - look for a swift/chunking update later today, posix tomorrow if I can keep the time clear. In the mean time, maybe think about e0ne's suggestion that you use context handlers for _write_all_to_callback_on_flush(), etc. | 18:01 |
| tbarron | In the changeset I'll push up, I convert that function to a context handler by adding __enter__ and __exit__ methods. | 18:01 |
| tbarron | (You may decide to keep that change or not) but I don't change the caller to do a with ... | 18:02 |
| tbarron | The logical direction of e0ne's suggestion is to dp that as well. Doing something like 'with put_object_writer as writer: ...' | 18:03 |
| tbarron | and 'with get_object_reader as reder: ....' | 18:03 |
| tbarron | But the current get_object_reader is doing StringIO.StringIO(), which isn't a context handler. | 18:04 |
| tbarron | So you may want to push back on the suggestion, reasonable as it is, on the grounds that these methods are meant to be overriden, and we don't want to impose the requirement on all implementations that they be context handlers. | 18:05 |
| tbarron | I dunno what I really think though. | 18:05 |
| *** Longgeek has quit IRC | 18:06 | |
| kfox1111 | k. sounds like a plan. :) | 18:06 |
| tbarron | :-) | 18:06 |
| *** sgotliv has quit IRC | 18:07 | |
| *** ryanpetrello has quit IRC | 18:10 | |
| *** ryanpetrello has joined #openstack-cinder | 18:10 | |
| *** sweston has quit IRC | 18:12 | |
| *** cppforlife has quit IRC | 18:12 | |
| *** mgagne has quit IRC | 18:12 | |
| *** vedams-seeni_ has quit IRC | 18:13 | |
| *** krtaylor has quit IRC | 18:13 | |
| *** spligak has quit IRC | 18:14 | |
| *** jbernard has quit IRC | 18:14 | |
| *** jordandh has quit IRC | 18:14 | |
| *** jbernard has joined #openstack-cinder | 18:16 | |
| *** spligak has joined #openstack-cinder | 18:16 | |
| *** krtaylor has joined #openstack-cinder | 18:17 | |
| *** sweston has joined #openstack-cinder | 18:17 | |
| *** jordandh has joined #openstack-cinder | 18:17 | |
| *** mgagne has joined #openstack-cinder | 18:17 | |
| *** cppforlife has joined #openstack-cinder | 18:17 | |
| *** mgagne is now known as Guest58319 | 18:17 | |
| thingee | anyone in core take a look at https://review.openstack.org/#/c/135139/ | 18:19 |
| thingee | would like to get this through soon | 18:19 |
| *** patrickeast has joined #openstack-cinder | 18:20 | |
| thingee | jungleboyj: question with https://review.openstack.org/#/c/142860/ | 18:21 |
| thingee | is icehouse backports for security only? https://wiki.openstack.org/wiki/Releases | 18:21 |
| jungleboyj | thingee: I am not aware of that restriction being set yet. | 18:21 |
| thingee | ok, was going off that releases page | 18:22 |
| thingee | fine with me otherwise | 18:22 |
| *** nikesh_vedams has joined #openstack-cinder | 18:22 | |
| jungleboyj | thingee: Ok. Yeah, I haven't heard that we are only taking security fixes there. Given that it is a minor change I am not worried about letting it in. | 18:24 |
| thingee | jungleboyj: sounds good, thanks | 18:24 |
| *** rlucio has joined #openstack-cinder | 18:25 | |
| *** annashen has joined #openstack-cinder | 18:27 | |
| flip214 | hemna: https://review.openstack.org/#/c/140451/ is rebased, please remove your -1. thanks. | 18:27 |
| *** EmilienM|afk is now known as EmilienM | 18:28 | |
| hemna | flip214, ok looking | 18:28 |
| *** tries has quit IRC | 18:29 | |
| nikesh_vedams | hi i am running driver_certs/cinder_driver_cert.sh on my cinder driver for dothill array but 2-3 tests cases are failing and these failed cases are passing when running separately | 18:29 |
| *** btran has joined #openstack-cinder | 18:29 | |
| *** e0ne has joined #openstack-cinder | 18:30 | |
| *** e0ne is now known as e0ne_ | 18:30 | |
| *** 64MABL776 has joined #openstack-cinder | 18:30 | |
| flip214 | hemna: thank you. | 18:31 |
| flip214 | No code changes, apart from some whitespace changes that flake8 wanted. | 18:32 |
| nikesh_vedams | do any one have idea of setting up a devstack setup for HPMSA | 18:35 |
| hemna | ok | 18:35 |
| nikesh_vedams | ? | 18:35 |
| hemna | yah looks like it has a dep on jgriffith's target change. I'm reviewing that one first. | 18:36 |
| hemna | maybe I can +A both of them :P | 18:36 |
| flip214 | hemna: you get a medaillon of code-review, +4 health, for that idea ;) | 18:38 |
| *** junhongl has quit IRC | 18:38 | |
| nikesh_vedams | tempest test cases are passing individually but 2-3 test cases are failing on running driver_certs/cinder_driver_cert.sh so driver is failing | 18:39 |
| nikesh_vedams | :( | 18:39 |
| *** e0ne_ has quit IRC | 18:40 | |
| *** tries has joined #openstack-cinder | 18:41 | |
| *** junhongl has joined #openstack-cinder | 18:42 | |
| *** ebalduf has joined #openstack-cinder | 18:43 | |
| *** jdurgin has joined #openstack-cinder | 18:43 | |
| *** nellysmitt has quit IRC | 18:43 | |
| rushil | nikesh_vedams: Set concurrency to 1 in ~/devstack/driver_certs/cinder_driver_cert.sh in line number 97. Or you can keep trying till it passes. | 18:45 |
| thingee | jgriffith: happy day https://review.openstack.org/#/c/135139/25 | 18:47 |
| *** e0ne has joined #openstack-cinder | 18:47 | |
| thingee | jgriffith: now to get through gate | 18:47 |
| thingee | DuncanT: you around today? | 18:48 |
| *** leeantho has quit IRC | 18:49 | |
| jgriffith | thingee: W00T!!!!!!!! | 18:50 |
| jgriffith | thingee: Happy New year!!! | 18:50 |
| e0ne | jungleboyj: hi! are you around? | 18:51 |
| thingee | jgriffith: thanks for your work on it | 18:55 |
| jgriffith | thingee: you bet, thanks for reviewing it and supporting the idea :) Now the "real" work will start | 18:58 |
| thingee | so the cinder object stuff looks pretty cool. have some comments on it...looks like it's breaking some unit tests still though | 19:01 |
| thingee | mostly because there are a lot of fields that are optional that's it's raising keyerrors on. | 19:01 |
| e0ne | jungleboyj: i would like to ask you to take a look on https://review.openstack.org/#/c/144108/ once more. your -2 was too quick there | 19:01 |
| *** EduardBiceriMate has quit IRC | 19:03 | |
| jungleboyj | e0ne: Looking. | 19:06 |
| jungleboyj | e0ne: What am I missing? | 19:06 |
| jungleboyj | e0ne: Oh, I see your comment now. Hold on. | 19:07 |
| e0ne | jungleboyj: it's not syncing with oslo-incubator.. | 19:07 |
| openstackgerrit | Navneet Singh proposed openstack/cinder: Manage/unmanage impl for NetApp ONTAP iscsi driver https://review.openstack.org/138111 | 19:09 |
| *** dustins_ has joined #openstack-cinder | 19:10 | |
| openstackgerrit | Navneet Singh proposed openstack/cinder: Implement Cinder Manage/Unmanage APIs in NFS driver. https://review.openstack.org/138125 | 19:10 |
| *** eharney has quit IRC | 19:10 | |
| *** kfox1111 has quit IRC | 19:11 | |
| *** junhongl has quit IRC | 19:11 | |
| jungleboyj | e0ne: Ah, jeez, I don't know what I was thinking when I looked at that. Thanks e0ne | 19:11 |
| e0ne | jungleboyj: no problem. | 19:12 |
| jungleboyj | e0ne: Fixed my friend. | 19:12 |
| *** dustins has quit IRC | 19:12 | |
| e0ne | jungleboyj: thanks a lot for it! and thanks for reviewing my patch. | 19:13 |
| openstackgerrit | Navneet Singh proposed openstack/cinder: NetApp eseries implementation for manage/unmanage https://review.openstack.org/138093 | 19:13 |
| *** junhongl has joined #openstack-cinder | 19:14 | |
| *** Mandell_ has quit IRC | 19:14 | |
| *** tristanC has quit IRC | 19:20 | |
| *** tristanC has joined #openstack-cinder | 19:20 | |
| *** nellysmitt has joined #openstack-cinder | 19:23 | |
| *** nellysmitt has quit IRC | 19:24 | |
| *** Masahiro has joined #openstack-cinder | 19:25 | |
| *** ebalduf has quit IRC | 19:25 | |
| *** Masahiro has quit IRC | 19:29 | |
| *** nellysmitt has joined #openstack-cinder | 19:30 | |
| jungleboyj | e0ne: No problem. | 19:30 |
| jungleboyj | thingee: Given your earlier question. What is your thought here: https://review.openstack.org/#/c/143536/ | 19:30 |
| *** sgotliv has joined #openstack-cinder | 19:31 | |
| *** btran has quit IRC | 19:32 | |
| *** nellysmitt has quit IRC | 19:34 | |
| *** 64MABL776 has quit IRC | 19:34 | |
| *** markstur has joined #openstack-cinder | 19:53 | |
| openstackgerrit | Corey Bryant proposed openstack/cinder: Pre python 3.2 compatibility for test_srb.py. https://review.openstack.org/145041 | 20:00 |
| *** Yogi1 has joined #openstack-cinder | 20:03 | |
| *** Mandell has joined #openstack-cinder | 20:06 | |
| *** thangp has joined #openstack-cinder | 20:07 | |
| *** xyang has joined #openstack-cinder | 20:11 | |
| *** eharney has joined #openstack-cinder | 20:14 | |
| *** xyang has quit IRC | 20:17 | |
| *** bswartz has joined #openstack-cinder | 20:24 | |
| *** nellysmitt has joined #openstack-cinder | 20:31 | |
| jgriffith | thingee: jungleboyj rushiagr_away FYI: https://review.openstack.org/#/c/143507/ | 20:32 |
| *** sfineberg has joined #openstack-cinder | 20:32 | |
| openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Failover to alternative iSCSI portals on login failure https://review.openstack.org/140877 | 20:35 |
| openstackgerrit | Tomoki Sekiyama proposed openstack/cinder: Enhance iSCSI multipath support https://review.openstack.org/134681 | 20:35 |
| *** nellysmitt has quit IRC | 20:35 | |
| jungleboyj | jgriffith: I am confused. | 20:36 |
| *** leeantho has joined #openstack-cinder | 20:37 | |
| jungleboyj | jgriffith: It looks like sean suggested doing it and then we caught the fact we didn't need to do that. | 20:37 |
| jungleboyj | jgriffith: What am I missing? | 20:37 |
| jgriffith | jungleboyj: huh? | 20:38 |
| *** kvidvans has quit IRC | 20:38 | |
| smcginnis | jgriffith, jungleboyj: Yeah, looks like my mistake. Didn't pay attention that it was a backport. | 20:38 |
| jungleboyj | jgriffith: You noted that it was bad juju to mix using LI and not using it. Ahhhh. | 20:38 |
| *** kvidvans has joined #openstack-cinder | 20:38 | |
| jgriffith | jungleboyj: :) | 20:38 |
| jungleboyj | jgriffith: Ok. And Sean made the opposite mistake earlier. | 20:39 |
| jgriffith | jungleboyj: smcginnis no worries I was just pointing it out so we catch them going forward | 20:39 |
| jgriffith | there are sure to be MANY more | 20:39 |
| jungleboyj | jgriffith: Ok, that is a good point. I will make sure to keep that in mind. | 20:39 |
| smcginnis | Let's just switch everything back. :D | 20:39 |
| jungleboyj | smcginnis: :-p | 20:39 |
| jungleboyj | You are clsoe enough I can come up and give you my thoughts on that. Careful boy. ;-) | 20:40 |
| smcginnis | jungleboyj: Come visit any time! | 20:40 |
| *** xyang has joined #openstack-cinder | 20:40 | |
| jungleboyj | smcginnis: Was up there just a month ago to see Manheim Steamroller at the Orpheum. | 20:40 |
| smcginnis | jungleboyj: You probably make it downtown more than I do. Worked in that area for years. Now I rarely go there. | 20:41 |
| jungleboyj | :-) Yeah, we are up there once a quarter or so. Hells Kitchen was awesome. | 20:41 |
| smcginnis | jungleboyj: Half the time that I actually do go downtown we end up going there. Good place. | 20:42 |
| jungleboyj | smcginnis: Our first trip there last time. Usually do Dakota instead. I think we will do Hells Kitchen again though. My boys liked it. | 20:43 |
| smcginnis | jungleboyj: Yeah, cool vibe my kids like too. | 20:43 |
| *** annashen has quit IRC | 20:44 | |
| jgriffith | smcginnis: +1 :) | 20:45 |
| *** annashen has joined #openstack-cinder | 20:46 | |
| thingee | jungleboyj: I was going to get clarification on the stable branch stuff. | 20:52 |
| thingee | jungleboyj: I would think that we would want to be selective on the older branches | 20:53 |
| jungleboyj | thingee: Agreed. | 20:54 |
| thingee | jgriffith: thanks for the catch | 20:54 |
| *** Yogi11 has joined #openstack-cinder | 20:54 | |
| *** Yogi1 has quit IRC | 20:56 | |
| *** IanGovett has quit IRC | 20:57 | |
| *** Mandell has quit IRC | 20:59 | |
| *** rwsu has quit IRC | 21:00 | |
| *** alexpilotti has quit IRC | 21:00 | |
| *** rwsu has joined #openstack-cinder | 21:04 | |
| *** Mandell has joined #openstack-cinder | 21:04 | |
| *** btran has joined #openstack-cinder | 21:08 | |
| *** IanGovett has joined #openstack-cinder | 21:11 | |
| *** Masahiro has joined #openstack-cinder | 21:14 | |
| openstackgerrit | Corey Bryant proposed openstack/cinder: Use assertRaisesRegexp() in test_srb.py. https://review.openstack.org/145041 | 21:14 |
| jgriffith | thingee: checking out objects :) | 21:16 |
| *** Masahiro has quit IRC | 21:18 | |
| *** e0ne has quit IRC | 21:18 | |
| thingee | jgriffith: nice | 21:19 |
| thingee | jgriffith: like I was saying earlier, these failures http://logs.openstack.org/66/133566/12/check/gate-cinder-python27/75fa551/testr_results.html.gz | 21:22 |
| jgriffith | thingee: hehe | 21:23 |
| *** nellysmitt has joined #openstack-cinder | 21:23 | |
| thingee | jgriffith: I'm guess from maybe things not being properly mocked? | 21:23 |
| jgriffith | thingee: few minor missed from the ref obj | 21:23 |
| jdandrea | DuncanT: yt? | 21:23 |
| jgriffith | thingee: not sure, probably... or they're actually just missing in the new object | 21:24 |
| jdandrea | We have another MIA vol attachment in the wild (even though OS claims its attached). | 21:24 |
| jgriffith | thingee: hmm... they seem to be in the obj | 21:24 |
| thingee | jgriffith: I thought that too. But if you take the first failure for example, volume_type_id...it is defined .,....yeah | 21:24 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/python-cinderclient: Add complementary explanation for <host> format of cinder migrate https://review.openstack.org/145064 | 21:25 |
| *** Yogi1 has joined #openstack-cinder | 21:25 | |
| jgriffith | thingee: oh... hehe | 21:25 |
| jgriffith | thingee: yeah, so this is going to need a good bit of test work I think maybe | 21:25 |
| jgriffith | thingee: one of the things I was thinking about the other day.... | 21:25 |
| jgriffith | thingee: we're really bad in our unit tests about sprinkling fake objects all over | 21:26 |
| jgriffith | thingee: and making them "just what we need" | 21:26 |
| jgriffith | thingee: would be good to have a class with "fake objects" we just call and use everywhere | 21:26 |
| thingee | jgriffith: yeah...so this change will be good all around :) | 21:26 |
| jgriffith | thingee: and have those be full blown fakes | 21:26 |
| jgriffith | thingee: haha... indeed | 21:26 |
| thingee | definitely | 21:26 |
| *** Yogi11 has quit IRC | 21:26 | |
| *** fifieldt_ has quit IRC | 21:27 | |
| jgriffith | maybe I'll try and work some of that up here this week... something like utils.get_fake_volume/snapshot/backup etc | 21:27 |
| jdandrea | DuncanT: I tried instigating a scsi rescan on the VM per our last chat. It doesn't change what's in /proc/partitions. | 21:27 |
| thingee | jgriffith: don't worry about it, you already got the rest of the target work. :) | 21:28 |
| jgriffith | haha | 21:28 |
| jgriffith | thingee: I'm ADD member! | 21:28 |
| *** fifieldt_ has joined #openstack-cinder | 21:28 | |
| jgriffith | thingee: can't work on one thing at a time... that's Crazy talk! | 21:28 |
| *** annashen_ has joined #openstack-cinder | 21:29 | |
| *** annashen has quit IRC | 21:29 | |
| *** jamielennox|away is now known as jamielennox | 21:30 | |
| *** kmartin has joined #openstack-cinder | 21:30 | |
| thingee | morganfainberg: ping | 21:31 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/python-cinderclient: Add command to show pool information for backends https://review.openstack.org/144814 | 21:31 |
| morganfainberg | thingee, pong back in 20mins | 21:31 |
| thingee | morganfainberg: k thanks | 21:31 |
| jdandrea | DuncanT: If I detach and reattach the volume, it apears in the VM! Hmm. | 21:33 |
| *** KurtMartin has quit IRC | 21:33 | |
| *** jamielennox is now known as jamielennox|away | 21:35 | |
| *** nellysmitt has quit IRC | 21:35 | |
| *** jungleboyj has quit IRC | 21:37 | |
| *** akerr has quit IRC | 21:38 | |
| jgriffith | thingee: hey... it merged!! | 21:41 |
| jgriffith | thingee: ok, now to keep an eye on the gate | 21:41 |
| thingee | O_O | 21:41 |
| *** gugl2 has quit IRC | 21:47 | |
| *** dustins_ has quit IRC | 21:48 | |
| *** gugl has joined #openstack-cinder | 21:49 | |
| *** sseverson has joined #openstack-cinder | 21:50 | |
| morganfainberg | thingee, ping - back | 21:50 |
| thingee | morganfainberg: hi, since v1 of cinder will be gone next release, I would like to have the volume service type in keystone to point to the root endpoint for discovery of available versions. I think I remember reading some code in keystone that already supports this, but wanted some direction. | 21:52 |
| *** lpetrut has quit IRC | 21:52 | |
| *** thangp has quit IRC | 21:53 | |
| thingee | currently I have volume and volumev2 that is being created in gate to support both endpoints. | 21:53 |
| thingee | volume and volumev2 service type& | 21:53 |
| thingee | * | 21:53 |
| *** annashen_ has quit IRC | 21:55 | |
| *** bswartz has quit IRC | 21:57 | |
| *** chlong has quit IRC | 21:59 | |
| morganfainberg | thingee, jamielennox|away can give more info | 22:03 |
| morganfainberg | but yes, it should | 22:03 |
| thingee | ok, I'll wait for jamielennox|away | 22:03 |
| thingee | morganfainberg: thank you | 22:03 |
| morganfainberg | thingee, i'll circle back when i'm off the phone, battling with travel :P | 22:03 |
| *** Yogi1 has quit IRC | 22:04 | |
| *** annashen has joined #openstack-cinder | 22:08 | |
| kaufer | thingee: If possible, could you review my comments to your -1 here: https://review.openstack.org/#/c/141964 | 22:15 |
| *** kfox1111 has joined #openstack-cinder | 22:15 | |
| thingee | kaufer: my mistake, thanks for pointing that out | 22:17 |
| kaufer | thingee: No problem | 22:17 |
| *** KurtMartin has joined #openstack-cinder | 22:17 | |
| *** tries is now known as tries__ | 22:20 | |
| *** kmartin has quit IRC | 22:21 | |
| *** jungleboyj has joined #openstack-cinder | 22:29 | |
| *** mwichmann has quit IRC | 22:40 | |
| dannywilson | ls | 22:41 |
| *** xyang has quit IRC | 22:42 | |
| *** ebalduf has joined #openstack-cinder | 22:44 | |
| *** kaufer has quit IRC | 22:46 | |
| jgriffith | thingee: so I'm keeping an eye on status but honestly things are so bad it's hard to really "see" anything :( | 22:47 |
| jgriffith | good thing is it mostly seems to be startup failures more than anything which are easy enough to spot | 22:47 |
| *** btran has quit IRC | 22:48 | |
| *** jamielennox|away is now known as jamielennox | 22:51 | |
| *** chlong has joined #openstack-cinder | 22:57 | |
| *** IanGovett has quit IRC | 22:58 | |
| *** Masahiro has joined #openstack-cinder | 23:02 | |
| *** jcru has quit IRC | 23:03 | |
| *** Masahiro has quit IRC | 23:07 | |
| *** gugl has quit IRC | 23:13 | |
| *** chlong_ has joined #openstack-cinder | 23:14 | |
| morganfainberg | jamielennox, ping re: discoverability and the catalog ^ thingee had a question | 23:16 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder: Add volume multi attach support https://review.openstack.org/85847 | 23:17 |
| *** btran has joined #openstack-cinder | 23:18 | |
| jamielennox | thingee: so the problem we've had in keystone is that there is software out there expecting that the 'identity' service type in the catalog returns the url with a /v2.0 suffix | 23:18 |
| jamielennox | removing that is just going to break stuff | 23:18 |
| jamielennox | so we've hacked around it in the client so that if you ask for a version that > 2 and you see the suffix /v2.0 then just chop it off before we do discovery | 23:19 |
| *** gugl has joined #openstack-cinder | 23:19 | |
| jamielennox | the intention being that in some future release where we've removed the assumption of /v2.0 the switch to the base url will be transparent (the chop just won't find anything and everything will progress as normal) | 23:20 |
| jamielennox | there is support for handling all this within the session object, when making a request you specify version=(2, 0) or whatever you require and that triggers the client to do discovery to determine the URL for the version | 23:21 |
| jamielennox | you will need to add the hack to chop off the cinder suffix - from memory this is hard within cinder because the project_id is a part of the url | 23:22 |
| jamielennox | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/_discover.py#L313 is where we do the hack for keystone | 23:23 |
| jamielennox | we can either make the cinder hack in keystoneclient, or make a public function for add_discover_hack so that it can be controlled from cinderclient | 23:24 |
| *** hemna has quit IRC | 23:24 | |
| thingee | jamielennox: with v1 going away in cinder, I'm using this as an opportunity in Kilo and forward to remove the version suffix from the catalog. So I'm not sure we need the hack | 23:24 |
| thingee | jamielennox: Unless I'm missing something still | 23:25 |
| jamielennox | ok, so we skip that bit and worry about it if there is compatibility problems - you're lucky we never managed to drop the API | 23:25 |
| thingee | :) | 23:25 |
| thingee | I might be an unpopular person next release, regardless of the warnings | 23:26 |
| thingee | but even nova is default to the newer version | 23:26 |
| *** Mandell has quit IRC | 23:26 | |
| thingee | this has been there since G though | 23:26 |
| thingee | :) | 23:26 |
| jamielennox | from memory even in version 2 the catalog provides the project_id right? | 23:26 |
| thingee | jamielennox: yeah | 23:26 |
| jamielennox | thats a pain | 23:27 |
| jamielennox | so what's missing in the session to support your case is adding the project_id to a url | 23:27 |
| *** km has joined #openstack-cinder | 23:27 | |
| *** km has left #openstack-cinder | 23:28 | |
| jamielennox | i've assumed that the URLs you get back from GET / can be used directly | 23:28 |
| jamielennox | however that was expecting nova v3 to happen where they remove that | 23:28 |
| thingee | jamielennox: / GET in can be used directly without a project_id | 23:30 |
| thingee | in cinder* | 23:30 |
| jamielennox | thingee: right - i mean though that it will return http://host:port/v2 | 23:30 |
| jamielennox | which is not the full url for making cinder calls | 23:30 |
| thingee | I see | 23:31 |
| thingee | jamielennox: so what would you recommend for me to move forward in K? | 23:32 |
| openstackgerrit | Mudassir Latif proposed openstack/cinder: add replication and PG setup methods on PureISCSIDriver https://review.openstack.org/145090 | 23:32 |
| jamielennox | thingee: we should be able to hack it in https://github.com/openstack/python-cinderclient/blob/master/cinderclient/client.py#L76 | 23:34 |
| jamielennox | just prepend the project_id to the path that is given | 23:34 |
| jamielennox | then it should be just a case of adding a version=(2, 0) to the requests coming from the v2 client | 23:35 |
| *** scottda_ has joined #openstack-cinder | 23:35 | |
| *** nellysmitt has joined #openstack-cinder | 23:36 | |
| jamielennox | getting the project_id from the plugin is kind of annoying, but i have a review up to allow getting it directly https://review.openstack.org/#/c/118520/ | 23:36 |
| thingee | jamielennox: taking a step back, so my question actually was to start with, how does the discovery work with keystone? | 23:37 |
| jamielennox | thingee: sure, the managers make a request for /users from service_type='identity', version=(3, 0), interface='public' | 23:39 |
| jamielennox | it consults the service catalog and gets the URL for identity service, public interface | 23:39 |
| *** chlong has quit IRC | 23:39 | |
| *** chlong_ has quit IRC | 23:39 | |
| jamielennox | it then queries the URL it retrieves, gets the list of available versions on the server and finds the url matching version=(3, 0) | 23:40 |
| jamielennox | it then prepends /users to make the full URL | 23:40 |
| jamielennox | appends | 23:40 |
| *** nellysmitt has quit IRC | 23:41 | |
| thingee | jamielennox: got it | 23:42 |
| *** jungleboyj has quit IRC | 23:44 | |
| *** chlong_ has joined #openstack-cinder | 23:46 | |
| *** chlong has joined #openstack-cinder | 23:46 | |
| *** chlong_ has quit IRC | 23:46 | |
| openstackgerrit | Mudassir Latif proposed openstack/cinder: add replication and PG setup methods on PureISCSIDriver https://review.openstack.org/145090 | 23:52 |
| mudassirlatif | Hi, anybody familiar with replication … can you please review volume replication WIP for the Pure ISCSI driver ( https://review.openstack.org/#/c/145090 ). Thanks | 23:56 |
| *** lcurtis has quit IRC | 23:56 | |
| *** ho has joined #openstack-cinder | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!