priteau | yoctozepto: Thanks, I also realised they are affecting master, not just your change. | 13:58 |
---|---|---|
priteau | We really need to get it fixed before release. I will see what I can do. | 14:01 |
opendevreview | Pierre Riteau proposed openstack/blazar master: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/blazar/+/856768 | 14:22 |
priteau | yoctozepto: ^^ | 14:23 |
yoctozepto | checking | 14:24 |
yoctozepto | priteau: behaviour fix seems correct but the comment and message seem wrong - please check out my comment on it | 14:26 |
priteau | Replied | 14:29 |
priteau | tox py3 jobs already passed | 14:32 |
yoctozepto | yeah, it's the fix | 14:33 |
yoctozepto | I approve with my CR+1 | 14:33 |
opendevreview | Radosław Piliszek proposed openstack/blazar master: Improve ExternalServiceFilter https://review.opendev.org/c/openstack/blazar/+/856527 | 14:33 |
opendevreview | Merged openstack/blazar master: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/blazar/+/856768 | 15:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!