| opendevreview | Pierre Riteau proposed openstack/blazar master: Update list_allocations in hosts plugin to expose start and end dates https://review.opendev.org/c/openstack/blazar/+/805461 | 14:07 |
|---|---|---|
| opendevreview | Pierre Riteau proposed openstack/blazar-dashboard master: Add a resource availability calendar for hosts https://review.opendev.org/c/openstack/blazar-dashboard/+/805462 | 15:07 |
| priteau | #startmeeting blazar | 16:00 |
| opendevmeet | Meeting started Thu Jan 27 16:00:05 2022 UTC and is due to finish in 60 minutes. The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'blazar' | 16:00 |
| priteau | #topic Roll call | 16:00 |
| mppowers | Hello priteau | 16:00 |
| priteau | Hi Mark | 16:00 |
| priteau | Waiting for Jason | 16:01 |
| mppowers | Yes, he should be here soon | 16:02 |
| diurnalist | o7 | 16:04 |
| priteau | Hi Jason | 16:04 |
| priteau | Let's take a look at our fancy dashboard | 16:05 |
| priteau | https://etherpad.opendev.org/p/blazar-whiteboard | 16:05 |
| priteau | #topic Small patches ready to approve | 16:05 |
| priteau | https://review.opendev.org/c/openstack/blazar/+/825255 | 16:05 |
| priteau | https://review.opendev.org/c/openstack/blazar-tempest-plugin/+/825195 | 16:05 |
| priteau | https://review.opendev.org/c/openstack/blazar-tempest-plugin/+/825415 | 16:05 |
| priteau | I've given +2 already | 16:05 |
| diurnalist | i'm going through them now | 16:07 |
| priteau | Actually I think the tempest one are duplicating a bit | 16:07 |
| priteau | Not sure why this wasn't flagged by gerri | 16:08 |
| priteau | I'll cancel the merge of 825195 | 16:08 |
| opendevreview | Pierre Riteau proposed openstack/blazar-tempest-plugin master: Add stable/xena jobs on master gate https://review.opendev.org/c/openstack/blazar-tempest-plugin/+/825415 | 16:09 |
| opendevreview | Pierre Riteau proposed openstack/blazar-tempest-plugin master: Add stable/xena jobs on master gate https://review.opendev.org/c/openstack/blazar-tempest-plugin/+/825415 | 16:09 |
| priteau | OK, abandoned https://review.opendev.org/c/openstack/blazar-tempest-plugin/+/825415 | 16:10 |
| priteau | I meant cancel the merge of 825415 | 16:10 |
| priteau | I think we're good now | 16:10 |
| priteau | #topic Review priorities for Yoga | 16:11 |
| priteau | Thanks for the review of the blazar-nova preemptible patch, still need to update it. I am working on the service side at the moment | 16:13 |
| priteau | Not yet upstream but hopefully soon, tomorrow maybe? | 16:13 |
| priteau | We have a lot of other patches ready to review, I have focused on two: | 16:13 |
| priteau | 805462: Add a resource availability calendar for hosts | https://review.opendev.org/c/openstack/blazar-dashboard/+/805462 | 16:14 |
| priteau | 805461: Update list_allocations in hosts plugin to expose start and end dates | https://review.opendev.org/c/openstack/blazar/+/805461 | 16:14 |
| priteau | I updated both patches, but changes are minor, so Jason's should be able to give his +2 again | 16:14 |
| priteau | For blazar-dashboard, I updated the vendored apexcharts JS | 16:15 |
| diurnalist | sounds good, will look in to it | 16:15 |
| priteau | mppowers: You didn't use a specific version on purpose? I assumed it was the latest at the time you started working on this | 16:15 |
| mppowers | Yes, it was just latest at the time | 16:15 |
| priteau | I tested the new one, took screenshots of the calendar, couldn't see any difference | 16:16 |
| priteau | The overlay box still displays fine | 16:16 |
| diurnalist | priteau: when i give my +2 on top of yours, it is ok to do the +1 to approved, yes? | 16:16 |
| priteau | Of course, I actually expect you to do so ;-) | 16:17 |
| diurnalist | yes, i thought so, just checking in case there was some other process i was stepping over | 16:17 |
| priteau | Second +2 can request merge, unless there is a reason not to. | 16:17 |
| priteau | For the list allocations patch, I fixed the merge conflict | 16:18 |
| priteau | No functional change there | 16:18 |
| mppowers | thank you for that | 16:18 |
| priteau | Thank YOU | 16:18 |
| priteau | As follow up to the dashboard I have these suggestions | 16:18 |
| priteau | * docs | 16:19 |
| priteau | At the very least we need to document the required policies (calendar doesn't work for non-admin users with default policy) | 16:19 |
| priteau | And describe how to customise the host naming using a property | 16:20 |
| priteau | That should go in https://docs.openstack.org/blazar-dashboard | 16:20 |
| priteau | Does it sound reasonable? | 16:21 |
| mppowers | Yes, that sounds good. Did you want this as a follow up patch? | 16:21 |
| diurnalist | yes, i just approved the current one \o/ | 16:21 |
| mppowers | OK, great | 16:22 |
| priteau | Yes, let's try to merge big patches when we reach a reasonable stopping point | 16:22 |
| priteau | I am afraid trying to get them perfect means they never get merged | 16:22 |
| priteau | As long as what we ship at the end of the release cycle is working and makes sense for operators and users, it's fine if it gets contributed in multiple steps | 16:23 |
| mppowers | Makes sense | 16:24 |
| priteau | My other comment was related to policies again | 16:24 |
| diurnalist | i removed the two patches i just approved from the whiteboard | 16:24 |
| priteau | Of course you need blazar:oshosts:get_allocations | 16:24 |
| priteau | But I discovered you also need blazar:oshosts:get | 16:24 |
| priteau | That's for the hypervisor name lookup | 16:24 |
| priteau | Do you think we could do without as an option? | 16:24 |
| priteau | Either configurable by admins | 16:25 |
| priteau | Or dynamically, try a get-host, if it fails with 401, fall back to display host ID | 16:25 |
| mppowers | Yes, I was thinking of using the fall back | 16:25 |
| priteau | Cool. Do you think you could add this in the next couple of weeks? | 16:26 |
| priteau | We have 4 weeks before feature freeze | 16:26 |
| mppowers | We have a busy schedule, and my blazar-dashboard environment is not in a good state, so I am unsure if there will be time | 16:27 |
| priteau | OK. Maybe for Z then. | 16:28 |
| priteau | As long as we document how to make it work, that's fine. | 16:28 |
| mppowers | OK, sounds good | 16:28 |
| mppowers | I'll be sure to at least get the docs | 16:28 |
| priteau | Thanks! | 16:29 |
| priteau | Next on my review list is all the others in the main priority list | 16:29 |
| priteau | I've not updated the Needs work section, it's possible some are ready to review now | 16:29 |
| priteau | resource properties is | 16:30 |
| mppowers | Yes, those should be ready | 16:30 |
| priteau | RPC layer not passing CI. Maybe this is something we can focus on next release | 16:31 |
| priteau | Same for third-party plugins, unless you think it's getting close? | 16:31 |
| mppowers | The third party plugins is working, but it is dependent on the RPC refactor patch | 16:32 |
| priteau | I see | 16:32 |
| priteau | So that's where the CI failures are coming from? | 16:32 |
| priteau | I've not looked at them to be honest | 16:32 |
| mppowers | Yes. It'll take some time to figure out why the RPC test is failing tempest. I have spent some time debugging without luck | 16:32 |
| priteau | 401 auth failures from Keystone | 16:33 |
| priteau | Maybe something related to context | 16:34 |
| priteau | Related to preemptibles, I submitted this: | 16:35 |
| priteau | 825659: Support running periodic tasks from event loop | https://review.opendev.org/c/openstack/blazar/+/825659 | 16:35 |
| priteau | Fairly small, I use it to run some tasks not related to lease events | 16:35 |
| diurnalist | priteau: where did you see the 401s in these logs? i'm not used to looking at tempest output | 16:35 |
| opendevreview | Merged openstack/blazar-dashboard master: Add a resource availability calendar for hosts https://review.opendev.org/c/openstack/blazar-dashboard/+/805462 | 16:36 |
| priteau | Hum, it was in the third-party plugin patch | 16:36 |
| priteau | I cannot see them in the RPC one | 16:37 |
| mppowers | Hm, maybe I need to debug both changes then | 16:37 |
| mppowers | There is an issue I was seeing in the journal output from tempest, but I could not reproduce | 16:37 |
| priteau | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_eba/820255/9/check/blazar-tempest-plugin-base/eba279b/controller/logs/screen-blazar-m.txt | 16:37 |
| priteau | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_eba/820255/9/check/blazar-tempest-plugin-base/eba279b/controller/logs/screen-blazar-a.txt | 16:37 |
| diurnalist | ah! | 16:37 |
| priteau | These are the logs to watch | 16:37 |
| diurnalist | it looks like it may actually be an assertionerror in the api? | 16:38 |
| diurnalist | this helps, thanks | 16:38 |
| priteau | Ah, in api logs | 16:38 |
| priteau | assert NOTIFIER is not None | 16:38 |
| priteau | Jan 25 18:19:30.372375 ubuntu-focal-ovh-bhs1-0028162968 devstack@blazar-a.service[101462]: File "/opt/stack/blazar/blazar/notification/notifier.py", line 51, in get_notifier | 16:38 |
| priteau | Jan 25 18:19:30.372375 ubuntu-focal-ovh-bhs1-0028162968 devstack@blazar-a.service[101462]: assert NOTIFIER is not None | 16:38 |
| mppowers | Ah that is the issue. I'm not sure why this isn't showing on my dev environment | 16:39 |
| priteau | Maybe the config is different | 16:40 |
| priteau | Do you use devstack to develop locally? | 16:41 |
| diurnalist | can't speak for mark 100%, but we've moved away from devstack and instead work using kolla ansible and dev_mode, b/c it aligns much better w/ our other tooling | 16:42 |
| mppowers | Yes, I was using devstack initially for the RPC patch, but then switched as Jason described | 16:43 |
| diurnalist | so there is some divergence b/w CI and our local envs unfortunately. in practice it rarely comes up, this is the first time i recall. knowing how to debug the logs is a game changer, i was looking in the wrong places | 16:43 |
| priteau | Oh I need to try this dev_mode | 16:44 |
| priteau | Thanks for the tip | 16:44 |
| priteau | I usually use devstack for development and then deploy with kolla | 16:44 |
| diurnalist | not all services support dev_mode and for things like neutron plugins it gets a bit hairy but it's pretty simple to solve in kolla ansible. in general it works pretty well! | 16:45 |
| diurnalist | in fact there is probably a patch we have for blazar dashboard and dev mode... | 16:45 |
| mppowers | I was unable to get dashboard development working 100% with kolla too | 16:45 |
| priteau | Anything else to share today? | 16:46 |
| priteau | #topic AOB | 16:47 |
| priteau | One thing | 16:47 |
| priteau | The Call for Presentations for the next OpenStack Summit is open until February 9 | 16:47 |
| priteau | But not sure if you will be wanting to travel? It's in Berlin. | 16:48 |
| diurnalist | wish i could! | 16:49 |
| priteau | I will probably submit a talk on Blazar related to the developments we are doing (various bits not upstream yet, but hopefully all will eventually be) | 16:50 |
| priteau | And something else | 16:50 |
| priteau | Next PTG is scheduled for April 4 - 8 | 16:50 |
| priteau | Virtual event this one | 16:50 |
| priteau | So please register if you haven't already: https://www.openstack.org/ptg/ | 16:50 |
| priteau | Will you be OK with a ~2 hour meeting like last time? | 16:51 |
| mppowers | That should work for me | 16:51 |
| diurnalist | i will actually be on holiday in australia then, i may not be able to attend | 16:52 |
| priteau | In that case maybe we can hold a meeting before or after the actual event | 16:52 |
| priteau | Let's discuss closer to the date | 16:53 |
| diurnalist | could do -- timing is kind of bad, it's right in the middle of an extended trip for me. yes, let's discuss later! | 16:53 |
| priteau | That's all I had for today! | 16:53 |
| diurnalist | thanks priteau! | 16:53 |
| priteau | Sorry it took a while to review these patches. I have more time for Blazar at the moment so I am trying to make the most of it! | 16:54 |
| mppowers | Thanks again! Talk to you later | 16:54 |
| priteau | #endmeeting | 16:55 |
| opendevmeet | Meeting ended Thu Jan 27 16:55:28 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:55 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/blazar/2022/blazar.2022-01-27-16.00.html | 16:55 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/blazar/2022/blazar.2022-01-27-16.00.txt | 16:55 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/blazar/2022/blazar.2022-01-27-16.00.log.html | 16:55 |
| opendevreview | Merged openstack/blazar-tempest-plugin master: Add stable/xena jobs on master gate https://review.opendev.org/c/openstack/blazar-tempest-plugin/+/825195 | 16:59 |
| opendevreview | Merged openstack/blazar master: Use LOG.warning instead of deprecated LOG.warn https://review.opendev.org/c/openstack/blazar/+/825255 | 16:59 |
| opendevreview | Merged openstack/blazar master: Update list_allocations in hosts plugin to expose start and end dates https://review.opendev.org/c/openstack/blazar/+/805461 | 17:04 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!