*** chlong has quit IRC | 00:59 | |
openstackgerrit | chenyingnan proposed openstack/blazar: Use assertIsNone(...) instead of assertEqual(None, ...) https://review.openstack.org/412684 | 01:50 |
---|---|---|
openstackgerrit | chenyingnan proposed openstack/blazar: Use assertIsNone(...) instead of assertEqual(None, ...) https://review.openstack.org/412684 | 02:16 |
*** r-mibu has quit IRC | 04:12 | |
*** gkadam has joined #openstack-blazar | 04:24 | |
openstackgerrit | Tony Breeds proposed openstack/blazar-nova: Add Constraints support https://review.openstack.org/412741 | 04:36 |
*** r-mibu has joined #openstack-blazar | 05:02 | |
*** gkadam has quit IRC | 05:13 | |
*** gkadam has joined #openstack-blazar | 05:29 | |
*** gkadam has quit IRC | 05:31 | |
*** gkadam has joined #openstack-blazar | 05:34 | |
*** priteau has joined #openstack-blazar | 08:42 | |
*** masahito has joined #openstack-blazar | 08:49 | |
priteau | Good morning | 08:56 |
masahito | priteau: hi | 08:57 |
priteau | Please join #openstack-meeting-alt for our weekly meeting | 09:00 |
priteau | r-mibu: I don't see you in that channel, are you joining us today? | 09:01 |
r-mibu | priteau: will join soon | 09:25 |
priteau | masahito: I am behind on patch review due to work priorities at the moment. I am hoping to catch up after Christmas | 10:02 |
masahito | priteau: ok | 10:02 |
masahito | priteau: r-mibu: but could you have little time to talk about some reviews now? | 10:02 |
priteau | yes I have a little time | 10:03 |
masahito | 2 patches | 10:03 |
masahito | 1. https://review.openstack.org/#/c/405630/1 | 10:03 |
r-mibu | ok | 10:03 |
masahito | 2. https://review.openstack.org/#/c/398716/15 | 10:03 |
priteau | 1. has an extensive reply from Tony. I read it but haven't fully processed what I need to change | 10:04 |
masahito | for 1. I understand Tony's opinion but this patch has been stopping other patches. | 10:04 |
masahito | Do you think we need to update the patch with Tony's suggestion or go to merge with current workaround? | 10:05 |
priteau | I need to check again his reply and see if there is something I can do to address it better. But he says himself he doesn't have a proper solution to the problem. | 10:06 |
masahito | right. | 10:06 |
priteau | 2. needs another review from me, which I hope to have time to do on Friday or sooner | 10:07 |
masahito | IMO, we merge it and then find a proper solution if you don't find right solution. | 10:07 |
priteau | masahito: you're right, even if we have an imperfect solution merged now, we can still fix it properly later | 10:08 |
masahito | priteau: ok, wait your review :-) | 10:09 |
priteau | for 1) I want at least to follow Tony's suggestion of removing only the nova tarball line from test-requirements.txt, rather than bypassing it completely | 10:09 |
priteau | that's the comment he added: https://review.openstack.org/#/c/405630/1/devstack/plugin.sh | 10:10 |
r-mibu | +1 to tony's suggestion | 10:12 |
r-mibu | anyhow, i suppose it'll take a long until devstack is fixed | 10:12 |
masahito | got it. waiting the update. | 10:13 |
r-mibu | for 2. need reviews? | 10:14 |
priteau | I will submit a new patch asap. Sorry for the delay, work commitments take priority | 10:14 |
priteau | r-mibu: reviewing 2. would be great | 10:14 |
masahito | r-mibu: yes. | 10:14 |
r-mibu | ot it | 10:15 |
r-mibu | got it | 10:15 |
masahito | series of 1. and 2. are gate fix patch and devstack installation fix. so I want both to merge asap. | 10:16 |
masahito | thanks both!! | 10:18 |
priteau | thanks masahito | 10:18 |
r-mibu | masahito: np - I'll review tonight | 10:24 |
*** masahito has quit IRC | 10:39 | |
*** gkadam is now known as Guest13716 | 10:42 | |
*** Guest13716 has joined #openstack-blazar | 10:43 | |
*** Guest13716 has quit IRC | 10:44 | |
*** gkadam has joined #openstack-blazar | 10:46 | |
*** gkadam has quit IRC | 10:46 | |
*** gkadam has joined #openstack-blazar | 10:46 | |
*** gkadam has quit IRC | 11:10 | |
*** gkadam has joined #openstack-blazar | 11:43 | |
*** gkadam has quit IRC | 12:14 | |
*** chlong has joined #openstack-blazar | 12:54 | |
*** chlong has quit IRC | 14:16 | |
*** priteau has quit IRC | 14:37 | |
*** chlong has joined #openstack-blazar | 15:54 | |
*** chlong has quit IRC | 16:01 | |
*** chlong has joined #openstack-blazar | 16:17 | |
*** chlong has quit IRC | 16:28 | |
*** chlong has joined #openstack-blazar | 16:43 | |
*** chlong has quit IRC | 18:56 | |
*** chlong has joined #openstack-blazar | 19:13 | |
*** chlong has quit IRC | 20:15 | |
*** chlong has joined #openstack-blazar | 20:27 | |
*** chlong has quit IRC | 21:46 | |
*** chlong has joined #openstack-blazar | 22:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!