*** mhen_ is now known as mhen | 02:11 | |
zigo | tkajinam: Yeah, the function load_der_public_key() and load_pem_public_key() were supposed to be internal private functions of pykmip, and they have been removed from cryptography 42.0.5 (currently in unstable)> | 08:59 |
---|---|---|
zigo | I'm not sure what should be used instead. | 09:00 |
zigo | Unfortunately, pykmip doesn't seem to be a very active project, so I'm not sure what to do. | 09:00 |
zigo | What is it used for in Barbican? | 09:00 |
tkajinam | load_dr|pem_public_key is method not in pykmib but in cryptography | 09:00 |
tkajinam | they should call the methods in cryptography.hazmat.primitives.serialization instead of using default_backend | 09:01 |
zigo | Yep, I know, that's what I (tried to) say. | 09:01 |
zigo | Oh ok. | 09:01 |
zigo | So, basically, just switch the path ... | 09:02 |
zigo | Looks doable. | 09:02 |
zigo | tkajinam: Looks like I was able to fix the problem thanks to you! :) | 09:14 |
zigo | I simply used serialization.load_der_public_key() as you suggested, instead of backend.load_der_public_key(). | 09:14 |
zigo | I still have 2 unit tests errors, but they looked like present with version 41 of python3-cryptography as well. | 09:15 |
tkajinam | https://github.com/OpenKMIP/PyKMIP/pull/714 | 09:18 |
tkajinam | I don't see any failures as long as I replace the removed methods | 09:18 |
zigo | Yeah, I wrote more or less the same thing, thanks for pushing it upstream. | 09:19 |
zigo | tkajinam: I still have these 2: | 09:20 |
zigo | https://paste.opendev.org/show/bW2Zsi0f1EmQ5x21oBxI/ | 09:20 |
tkajinam | zigo, https://github.com/OpenKMIP/PyKMIP/commit/652d5cab | 09:22 |
zigo | Oh, nice ! :) | 09:22 |
tkajinam | you fix it wrongly in your local, I guess | 09:22 |
zigo | No, this patch was just missing. | 09:24 |
zigo | All unit tests are passing! \o/ | 09:26 |
tkajinam | no release has been created since that change was merged | 09:28 |
zigo | Ah no, only with older python3-cryptography. :/ | 09:40 |
zigo | Ok, fixed ! :P | 09:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!