openstackgerrit | Lingyong Xu proposed openstack/barbican master: Trivial: Fix the pep8 warning The yaml should start with "---" https://review.openstack.org/568178 | 03:22 |
---|---|---|
*** toabctl has joined #openstack-barbican | 04:21 | |
*** nix-73W6VSR has joined #openstack-barbican | 04:25 | |
*** nix-73W6VSR has quit IRC | 04:25 | |
openstackgerrit | Ade Lee proposed openstack/barbican master: Castellan based secret store https://review.openstack.org/531241 | 05:44 |
*** pcaruana has joined #openstack-barbican | 06:31 | |
*** annp has joined #openstack-barbican | 06:34 | |
*** annp has quit IRC | 07:57 | |
*** annp has joined #openstack-barbican | 07:58 | |
*** salmankhan has joined #openstack-barbican | 08:12 | |
openstackgerrit | Lingyong Xu proposed openstack/barbican master: Trivial: Fix the pep8 warning https://review.openstack.org/568178 | 08:15 |
openstackgerrit | huangshan proposed openstack/barbican master: Fix docs build in tox.ini https://review.openstack.org/568227 | 08:17 |
*** sapcc-bot4 has joined #openstack-barbican | 09:00 | |
*** annp has quit IRC | 09:04 | |
*** sapcc-bot3 has quit IRC | 09:04 | |
*** annp has joined #openstack-barbican | 09:05 | |
*** salmankhan has quit IRC | 09:25 | |
*** salmankhan has joined #openstack-barbican | 09:31 | |
*** abishop has joined #openstack-barbican | 09:45 | |
*** jaosorior has joined #openstack-barbican | 09:56 | |
*** serlex has joined #openstack-barbican | 10:30 | |
*** abishop has quit IRC | 10:42 | |
*** pbourke has quit IRC | 11:13 | |
*** pbourke has joined #openstack-barbican | 11:14 | |
*** abishop has joined #openstack-barbican | 11:18 | |
*** livelace has joined #openstack-barbican | 11:50 | |
*** raildo has joined #openstack-barbican | 12:02 | |
*** alee has joined #openstack-barbican | 13:39 | |
*** noslzzp has joined #openstack-barbican | 14:45 | |
*** pcaruana has quit IRC | 15:02 | |
jaosorior | alee: https://review.openstack.org/#/c/531241/ LGTM. Although ideally we shouldn't re-define those configuration options | 15:32 |
jaosorior | but we can address that in a separate commit, no biggie | 15:32 |
alee | jaosorior, cool - yeah I tried not to do that in a previous patchset, but folks seemed to prefer that we do it that way | 15:33 |
alee | jaosorior, we can revisit when it all lands | 15:33 |
jaosorior | alee: yeah, that sounds like a good idea | 15:36 |
jaosorior | anyway | 15:37 |
jaosorior | +2 | 15:37 |
alee | jaosorior, thanks :) | 15:37 |
*** rmascena has joined #openstack-barbican | 16:06 | |
*** raildo has quit IRC | 16:08 | |
*** pcaruana has joined #openstack-barbican | 16:20 | |
*** dave-mccowan has joined #openstack-barbican | 16:23 | |
*** dave-mccowan has quit IRC | 16:28 | |
*** jmlowe has quit IRC | 16:29 | |
*** dave-mccowan has joined #openstack-barbican | 16:30 | |
*** salmankhan has quit IRC | 16:31 | |
alee | dave-mccowan, ping -- https://review.openstack.org/531241 when you get a chance please | 16:55 |
dave-mccowan | alee do you want to address juan's comments, or keep it as is? | 16:56 |
alee | dave-mccowan, yeah - we chatted about this - we can fix this in a subsequent commit if we want to | 16:57 |
alee | dave-mccowan, I have not quite figured out how to do it though -- spent a bit of time trying to figure that out | 16:59 |
alee | dave-mccowan, so yeah - defer to later | 16:59 |
*** serlex has quit IRC | 17:05 | |
*** jmlowe has joined #openstack-barbican | 17:56 | |
jaosorior | dave-mccowan: could you check this one out https://review.openstack.org/#/c/563648/ ? | 17:59 |
*** salmankhan has joined #openstack-barbican | 18:33 | |
*** jmlowe has quit IRC | 19:13 | |
*** jmlowe has joined #openstack-barbican | 19:34 | |
*** dave-mccowan has quit IRC | 19:36 | |
openstackgerrit | Merged openstack/barbican master: Enforce usage of oslo.context's project_id https://review.openstack.org/563648 | 19:42 |
*** salmankhan has quit IRC | 19:48 | |
*** dave-mccowan has joined #openstack-barbican | 19:53 | |
*** jmlowe has quit IRC | 20:06 | |
*** jmlowe has joined #openstack-barbican | 20:08 | |
*** alee is now known as alee_afk | 20:17 | |
*** jmlowe has quit IRC | 20:39 | |
*** jmlowe has joined #openstack-barbican | 20:41 | |
*** pcaruana has quit IRC | 20:43 | |
*** livelace has quit IRC | 20:54 | |
*** rmascena has quit IRC | 21:07 | |
*** abishop has quit IRC | 21:20 | |
*** jmlowe has quit IRC | 21:21 | |
*** jmlowe has joined #openstack-barbican | 21:36 | |
*** jmlowe has quit IRC | 21:41 | |
*** abishop has joined #openstack-barbican | 22:29 | |
*** alee_afk is now known as alee | 22:52 | |
*** dave-mccowan has quit IRC | 23:02 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!