*** vivek-ebay has joined #openstack-barbican | 00:01 | |
*** vivek-ebay has quit IRC | 00:02 | |
*** vivek-ebay has joined #openstack-barbican | 00:02 | |
*** dave-mccowan has joined #openstack-barbican | 00:06 | |
*** alee has quit IRC | 00:38 | |
openstackgerrit | Christopher Solis proposed openstack/python-barbicanclient: Add epilog to parser https://review.openstack.org/217938 | 00:39 |
---|---|---|
*** alee has joined #openstack-barbican | 00:40 | |
*** vivek-ebay has quit IRC | 01:08 | |
*** chadlung has joined #openstack-barbican | 01:38 | |
*** woodster_ has quit IRC | 01:39 | |
openstackgerrit | Zhenyu Zheng proposed openstack/barbican: Make alembic used in barbican similar to other openstack projects https://review.openstack.org/217004 | 02:01 |
*** chadlung has quit IRC | 02:10 | |
openstackgerrit | Dave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer https://review.openstack.org/218064 | 02:33 |
*** dave-mccowan has quit IRC | 02:43 | |
*** gyee has quit IRC | 02:51 | |
*** insequent has joined #openstack-barbican | 02:59 | |
*** nelsnels_ has quit IRC | 03:17 | |
*** nelsnelson has joined #openstack-barbican | 03:18 | |
*** rm_work has quit IRC | 03:27 | |
*** hockeynut has quit IRC | 03:27 | |
*** spotz_zzz has quit IRC | 03:28 | |
*** jillysciarilly has quit IRC | 03:28 | |
*** jroll has quit IRC | 03:28 | |
*** zz_dimtruck has quit IRC | 03:28 | |
*** tdink has quit IRC | 03:28 | |
*** alee has quit IRC | 03:28 | |
*** lbragstad has quit IRC | 03:28 | |
*** eglute has quit IRC | 03:28 | |
*** alee has joined #openstack-barbican | 03:29 | |
*** eglute has joined #openstack-barbican | 03:31 | |
*** rm_work has joined #openstack-barbican | 03:31 | |
*** jroll has joined #openstack-barbican | 03:32 | |
*** zz_dimtruck has joined #openstack-barbican | 03:32 | |
*** zz_dimtruck is now known as dimtruck | 03:32 | |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for secrets https://review.openstack.org/213414 | 03:36 |
*** hockeynut has joined #openstack-barbican | 03:36 | |
*** tdink has joined #openstack-barbican | 03:37 | |
*** jillysciarilly has joined #openstack-barbican | 03:37 | |
*** lbragstad has joined #openstack-barbican | 03:37 | |
*** spotz_zzz has joined #openstack-barbican | 03:37 | |
pksingh | rm_work: Hi are you around? | 04:31 |
openstackgerrit | Elvin Tubillara proposed openstack/barbican: WIP Add request ID to worker-side logs https://review.openstack.org/217775 | 04:32 |
openstackgerrit | Motohiro/Yuanying Otsuka proposed openstack/barbican: Set host_href parameter in devstack https://review.openstack.org/218091 | 04:56 |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders https://review.openstack.org/213419 | 04:59 |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders https://review.openstack.org/213419 | 05:08 |
*** nelsnelson has quit IRC | 05:25 | |
rm_work | pksingh: i am NOW | 05:46 |
*** Nirupama has joined #openstack-barbican | 05:47 | |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for containers https://review.openstack.org/213420 | 06:19 |
*** shohel has joined #openstack-barbican | 06:22 | |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders https://review.openstack.org/213419 | 06:27 |
*** ryanpetrello has quit IRC | 06:32 | |
*** mixos has quit IRC | 06:36 | |
*** ryanpetrello has joined #openstack-barbican | 06:40 | |
openstackgerrit | Fernando Diaz proposed openstack/barbican: Add some documentation on running a single functional test case https://review.openstack.org/218117 | 06:42 |
*** Nirupama has quit IRC | 06:50 | |
*** Nirupama has joined #openstack-barbican | 06:53 | |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for secrets smoke tests https://review.openstack.org/217280 | 06:57 |
*** Kevin_Zheng has quit IRC | 07:05 | |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders smoke tests https://review.openstack.org/217298 | 07:21 |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders smoke tests https://review.openstack.org/217298 | 07:23 |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for containers smoke tests https://review.openstack.org/217312 | 07:36 |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for containers https://review.openstack.org/213420 | 07:39 |
*** shohel has quit IRC | 08:22 | |
*** shohel has joined #openstack-barbican | 08:26 | |
*** shohel1 has joined #openstack-barbican | 09:06 | |
*** shohel has quit IRC | 09:07 | |
*** shohel1 has quit IRC | 09:11 | |
*** shohel has joined #openstack-barbican | 09:27 | |
*** dave-mccowan has joined #openstack-barbican | 09:58 | |
*** mmdurrant has quit IRC | 10:09 | |
*** ryanpetrello has quit IRC | 10:27 | |
*** rm_work has quit IRC | 10:27 | |
*** alee has quit IRC | 10:27 | |
*** jamielennox has quit IRC | 10:27 | |
*** everjeje has quit IRC | 10:27 | |
*** rm_you has quit IRC | 10:27 | |
*** d0ugal has quit IRC | 10:27 | |
*** jillysciarilly has quit IRC | 10:27 | |
*** spotz_zzz has quit IRC | 10:27 | |
*** tdink has quit IRC | 10:27 | |
*** lbragstad has quit IRC | 10:27 | |
*** hockeynut has quit IRC | 10:27 | |
*** jroll has quit IRC | 10:27 | |
*** dimtruck has quit IRC | 10:27 | |
*** eglute has quit IRC | 10:27 | |
*** spotz_zzz has joined #openstack-barbican | 10:29 | |
*** lbragstad has joined #openstack-barbican | 10:29 | |
*** jillysciarilly has joined #openstack-barbican | 10:29 | |
*** tdink has joined #openstack-barbican | 10:29 | |
*** hockeynut has joined #openstack-barbican | 10:29 | |
*** dimtruck has joined #openstack-barbican | 10:29 | |
*** jroll has joined #openstack-barbican | 10:29 | |
*** eglute has joined #openstack-barbican | 10:29 | |
*** ryanpetrello has joined #openstack-barbican | 10:30 | |
*** rm_work has joined #openstack-barbican | 10:30 | |
*** alee has joined #openstack-barbican | 10:30 | |
*** jamielennox has joined #openstack-barbican | 10:30 | |
*** everjeje has joined #openstack-barbican | 10:30 | |
*** rm_you has joined #openstack-barbican | 10:30 | |
*** d0ugal has joined #openstack-barbican | 10:30 | |
*** ryanpetrello has quit IRC | 10:30 | |
*** rm_work has quit IRC | 10:30 | |
*** alee has quit IRC | 10:30 | |
*** jamielennox has quit IRC | 10:30 | |
*** everjeje has quit IRC | 10:30 | |
*** rm_you has quit IRC | 10:30 | |
*** d0ugal has quit IRC | 10:30 | |
*** ryanpetrello has joined #openstack-barbican | 10:32 | |
*** rm_work has joined #openstack-barbican | 10:32 | |
*** alee has joined #openstack-barbican | 10:32 | |
*** jamielennox has joined #openstack-barbican | 10:32 | |
*** everjeje has joined #openstack-barbican | 10:32 | |
*** rm_you has joined #openstack-barbican | 10:32 | |
*** d0ugal has joined #openstack-barbican | 10:32 | |
*** shohel has quit IRC | 10:52 | |
*** mmdurrant has joined #openstack-barbican | 11:58 | |
*** Nirupama has quit IRC | 12:07 | |
*** rellerreller has joined #openstack-barbican | 12:20 | |
*** chlong has joined #openstack-barbican | 12:34 | |
*** nelsnelson has joined #openstack-barbican | 12:50 | |
*** woodster_ has joined #openstack-barbican | 12:55 | |
*** kfarr has joined #openstack-barbican | 12:56 | |
*** shohel has joined #openstack-barbican | 13:00 | |
*** darrenmoffat has quit IRC | 13:10 | |
*** darrenmoffat has joined #openstack-barbican | 13:25 | |
*** nelsnelson has quit IRC | 13:27 | |
*** spotz_zzz is now known as spotz | 13:57 | |
*** jaosorior has joined #openstack-barbican | 13:57 | |
*** SheenaG has joined #openstack-barbican | 13:59 | |
*** shohel has quit IRC | 14:02 | |
*** shohel has joined #openstack-barbican | 14:02 | |
*** pglass has joined #openstack-barbican | 14:09 | |
rellerreller | jvrbanac I found this bug, https://bugs.launchpad.net/barbican/+bug/1489900 | 14:12 |
openstack | Launchpad bug 1489900 in Barbican "Test Attributes are Lost" [Undecided,New] - Assigned to Nathan Reller (rellerreller) | 14:12 |
rellerreller | jvrbanac I thought you might be interested in that | 14:13 |
*** silos has joined #openstack-barbican | 14:26 | |
*** SheenaG has quit IRC | 14:29 | |
openstackgerrit | Nathan Reller proposed openstack/barbican: Fixed Testing Attributes Bug https://review.openstack.org/218296 | 14:30 |
*** rellerreller has quit IRC | 14:32 | |
*** everjeje has quit IRC | 14:32 | |
openstackgerrit | chandan kumar proposed openstack/barbican: Removing unused dependency: discover https://review.openstack.org/218300 | 14:33 |
*** xaeth_afk is now known as xaeth | 14:36 | |
*** mixos has joined #openstack-barbican | 14:42 | |
*** rellerreller has joined #openstack-barbican | 14:43 | |
rellerreller | Can we get some eyes on https://review.openstack.org/#/c/212579/ today? Please :-) | 14:43 |
*** jlhinson has joined #openstack-barbican | 14:45 | |
*** shohel has quit IRC | 14:51 | |
*** mixos has quit IRC | 14:57 | |
*** insequent has quit IRC | 14:57 | |
*** dave-mccowan has quit IRC | 15:06 | |
*** ccneill_ has joined #openstack-barbican | 15:12 | |
*** ccneill_ is now known as ccneill | 15:13 | |
*** diazjf has joined #openstack-barbican | 15:16 | |
*** dave-mccowan has joined #openstack-barbican | 15:19 | |
*** mixos has joined #openstack-barbican | 15:20 | |
dave-mccowan | there are three outstanding quota blueprint CRs. start here: https://review.openstack.org/#/c/216253/ then follow the chain for the other two. quotas are functionally complete after these three land. \o/ if you have questions on them, please ask. :-) | 15:25 |
*** edtubill has joined #openstack-barbican | 15:25 | |
rellerreller | ping dave-mccowan | 15:36 |
rellerreller | dave-mccowan ping | 15:37 |
*** chlong has quit IRC | 15:39 | |
*** SheenaG has joined #openstack-barbican | 15:41 | |
elmiko | redrobot, kfarr, i'm trying to setup a sahara patch that will include the first release of castellan. what version might i expect, so that i can add it to my requirements.txt? | 15:58 |
kfarr | elmiko 0.2.0 I believe | 15:58 |
elmiko | kfarr: great, thanks! | 15:59 |
*** xaeth is now known as xaeth_afk | 16:00 | |
kfarr | elmiko, there's already 0.1.0, but that only includes only support for symmetric keys. Code from way back in march | 16:01 |
elmiko | kfarr: yea, although i'm not seeing it on pypi... | 16:01 |
kfarr | elmiko https://pypi.python.org/pypi/castellan | 16:02 |
elmiko | ah, thanks, my search ability failed horribly lol | 16:02 |
*** xaeth_afk is now known as xaeth | 16:02 | |
elmiko | kfarr: really looking forward to the next release. it's been a great effort =) | 16:02 |
kfarr | oh you're right, it doesn't show up from the search bar. that's strange | 16:03 |
kfarr | elmiko, I know! Thanks for all your help with things | 16:03 |
elmiko | kfarr: hey, just glad to be part of the team | 16:03 |
*** vivek-ebay has joined #openstack-barbican | 16:11 | |
kfarr | jaosorior, redrobot, if you get a chance today, please review the latest Castellan patch: https://review.openstack.org/#/c/208569/ Last one before we should have a release! | 16:19 |
*** chlong has joined #openstack-barbican | 16:22 | |
*** insequent has joined #openstack-barbican | 16:23 | |
diazjf | rellerreller, dave-mccowan, making the _delete_all_containers function to a common class in https://review.openstack.org/#/c/213420/7/functionaltests/client/v1/functional/test_containers.py do you suggest I move them to the base test class or make a new file in common that just does cleanup. Thanks!! | 16:23 |
dave-mccowan | diazif a new file for the new base class sounds good to me. that would make it more portable, in case we want to adopt it in another repo. | 16:32 |
dave-mccowan | rellerreller pong | 16:32 |
*** jorgem has joined #openstack-barbican | 16:35 | |
*** vivek-ebay has quit IRC | 16:36 | |
rellerreller | diazjf I concur with dave-mccowan. | 16:41 |
rellerreller | dave-mccowan I had some comments on the quota CR you have, the first one. | 16:41 |
rellerreller | dave-mccowan I left a comment in there about removing the external project ID. I don't know if you saw that. | 16:41 |
dave-mccowan | rellerreller reading it now. | 16:42 |
dave-mccowan | rellerreller my thought was for performance. if i did not store both the internal and external project ids, then i would need two database lookups for every operation. | 16:44 |
*** chlong has quit IRC | 16:45 | |
dave-mccowan | rellerreller, honestly, if anything, i'd like to remove the internal project_id. but, that's the current standard for project foreign keys in the database. | 16:45 |
rellerreller | dave-mccowan I think one FK, and I suggest internal project id since that is what everything else is using | 16:45 |
rellerreller | dave-mccowan I am worried that if have both then can get in weird state. I know that we _should_ not, but it is nice to have the database enforcement. | 16:46 |
dave-mccowan | rellerreller there is only one foreign key and internal_project_id is the required one, because you can only have a foreign key matching the primary key of another table. | 16:47 |
rellerreller | dave-mccowan correct | 16:47 |
rellerreller | dave-mccowan what the two db lookups? | 16:48 |
dave-mccowan | rellerreller yea, i consider the risk of error. but, sided with performance (only one look up) and ease of use (all interactions with PQs start with the external id). | 16:48 |
dave-mccowan | GET /v1/project-quotas/12345 starts with the external id. if i need the internal id, i'll need to lookup it up first. | 16:49 |
rellerreller | dave-mccowan would that be two different statements or one with a join? | 16:50 |
rellerreller | dave-mccowan either way I think the cost of an extra db query or join statement is worth not getting the db in a weird state. | 16:51 |
dave-mccowan | rellerreller i'm not sure. there's probably some SQL foo to do it one. | 16:51 |
diazjf | rellerreller, dave-mccowan, thanks!! Gonna make a new file in /common for the tests. I'll let you know once the patch is up. | 16:52 |
rellerreller | dave-mccowan it should be easy to write a join statement that fetches the project and the quotas in one statement. If we need both or the performance increase. | 16:52 |
*** kebray has joined #openstack-barbican | 16:54 | |
dave-mccowan | rellerreller try this for a sec: pick a controller file, like controller/secrets.py and skim through all the "external_project_id" uses. "external_project_id" seems like Barbican-native. project-quotas would become the exception, i think. | 16:55 |
rellerreller | dave-mccowan which parts are you referring to? | 16:58 |
rellerreller | dave-mccowan I see the log statements are using the external ID. | 16:58 |
rellerreller | dave-mccowan OK, I see it for secret repo as well. | 17:00 |
dave-mccowan | rellerreller and the interfaces to the plugins. all operations deal with external_project_id. the only thing the internal project id is used for is to store it in the database. | 17:00 |
openstackgerrit | Elvin Tubillara proposed openstack/barbican: WIP Add Request ID to worker-side logs in barbican. This can help correlate errors in logs to an incoming request https://review.openstack.org/217775 | 17:00 |
dave-mccowan | rellerreller i agree it's confusing. i got stuck on a validator bug last cycle when i mixed up internal/external project ids in the orders api. | 17:01 |
rellerreller | dave-mccowan If the interface wants to use external id then that is not as big of a deal to me. | 17:02 |
rellerreller | dave-mccowan I think the important thing is that the db model references the FK to project. | 17:03 |
rellerreller | dave-mccowan look at secret for example. | 17:03 |
*** silos has left #openstack-barbican | 17:03 | |
rellerreller | dave-mccowan the store method takes a project model. That is another option if you do not want to choose between internal and external project id. | 17:04 |
rellerreller | dave-mccowan you could pass the referenced project object to the quota driver. Then the quota driver can easily get the project and external project ID from that without having to query the db. | 17:05 |
rellerreller | dave-mccowan I think of it like this. Should secret, container, consumer, order, and quota all have two columns for project ID and external project ID or should they have a FK relationship to project that stores the external project id? | 17:07 |
dave-mccowan | rellerreller the difference between the secret/container/consumer/etc. is that they all have their own ref. the external_project_id happens to also be the ref for the project-quotas record. | 17:09 |
rellerreller | dave-mccowan I don't quite understand why the external ref matters for your point? | 17:11 |
arunkant | dave-mccowan : agree with rellerreller. For looking quotas record based on keystone project_id, table join with projects table can be used to look (assuming foreign key is defined on internal project_id) | 17:12 |
dave-mccowan | rellerreller the external ref is everything. it is the value that is used in get, set, and delete. | 17:12 |
rellerreller | dave-mccowan so the external ref is used to find a resource. You can map external id to internal id to quotas. | 17:14 |
rellerreller | dave-mccowan the internal ID for the quotas table could be anything. We could make it a random number that is assigned with the table row is created. | 17:14 |
openstackgerrit | Fernando Diaz proposed openstack/barbican: Add some documentation on running a single functional test case https://review.openstack.org/218117 | 17:15 |
rellerreller | dave-mccowan the important part is that ref can be mapped to a row, and that can happen. The other important part is to make sure that mappings only occur once. | 17:15 |
dave-mccowan | rellerreller. hmmm.... ok, are you suggesting to leave the controller and driver code alone. then in repo code, have the same API, but get rid of the external_proejct_id column and use join instead of a simple look up? | 17:16 |
rellerreller | dave-mccowan in this case the mapping from external_id->internal_id. If you have it defined more than once then chances are that data will be out of sync. | 17:16 |
rellerreller | dave-mccowan right now my only suggestion is that quotas model only has FK reference to project and external id is removed. | 17:17 |
rellerreller | dave-mccowan I would have to think more about the quota API. My first reaction would be that it takes a project model. | 17:18 |
rellerreller | dave-mccowan but I can leave that up to you | 17:19 |
dave-mccowan | rellerreller OK. i agree with that concept. i think i can make that happen, while still allowing the controller and driver to only deal with the external_project_id which is the one that is used outside of the repo code. | 17:19 |
rellerreller | dave-mccowan yes, I think the controller should take the external ID because that will make sense to the user. | 17:19 |
rellerreller | dave-mccowan then either the controller or the quota driver needs to map that to quota table objects. | 17:20 |
*** chadlung has joined #openstack-barbican | 17:21 | |
dave-mccowan | rellerreller i'd like to make the repo code do that. there's no need for code outside the repo to even know the internal project id. | 17:22 |
rellerreller | dave-mccowan what is the PK on the quotas table? | 17:23 |
rellerreller | dave-mccowan when you retrieve a project it should retrieve its quotas correct? | 17:24 |
dave-mccowan | the "internal_project_quota_id" a value that is never referenced in any code. | 17:24 |
rellerreller | dave-mccowan that relationship is setup in the project model, I believe. | 17:24 |
rellerreller | dave-mccowan If that is the case then you could pass the Quota model to the quota driver by retrieving it from the Project model. | 17:25 |
rellerreller | dave-mccowan then update the Quota instance as needed and call save on the repo. Would that work? | 17:25 |
dave-mccowan | rellerreller i don't understand. what do you mean by: when you retrieve a project it should retrieve its quotas correct? | 17:27 |
dave-mccowan | rellerreller the only information in the project table is the internal id and the external id. | 17:28 |
rellerreller | dave-mccowan After you retrieve a Project from project repo you should be able to do `project.quotas` to get the Quotas model associated with the project. | 17:28 |
dave-mccowan | rellerreller really? is that SQL magic from the orm.relationship() method? | 17:29 |
rellerreller | dave-mccowan I'm not as familiar with sqlalchemy, but in Hibernate you can retrieve an object like Project and it would automatically retrieve its Quota associated with it. | 17:29 |
rellerreller | dave-mccowan I think so, but I do not know for sure. | 17:29 |
*** vivek-ebay has joined #openstack-barbican | 17:29 | |
rellerreller | dave-mccowan I think it would be worth a test. | 17:30 |
dave-mccowan | rellerreller that'd be like retrieving every secret in a project when you got a project. | 17:30 |
rellerreller | dave-mccowan I do not know the configurations for how the properties are retrieved, but it would not surprise me. | 17:31 |
rellerreller | dave-mccowan in Hibernate you can mark certain relationships as "eager" or "lazy". Eager relationships mean that every time the object is retrieved the dependent object is also retrieved. | 17:32 |
rellerreller | dave-mccowan I do not know if sqlalchemy has that type of mapping or not. It seems like quota could be a good candidate because very little data and 1-1 mapping. | 17:32 |
dave-mccowan | rellerreller i'll take a look. between that and join, there should be answer that addresses the concern of having two project IDs in the quotas table. | 17:33 |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Create Common functions used for cleaning up items used for testing https://review.openstack.org/218396 | 17:34 |
diazjf | ^^ rellerreller, dave-mccowan: added the patch seen above, let me know what you think and to make my other patches dependant on it, do I just need to add the ChangeId? | 17:36 |
dave-mccowan | diazjf did you see my suggestion for a class with delete_all_the_things()? | 17:38 |
openstackgerrit | Kaitlin Farr proposed openstack/castellan: Update Barbican wrapper https://review.openstack.org/208569 | 17:40 |
dave-mccowan | diazjf thinking ahead, the behaviors code that you're replacing dealt with unauth tests, rbac tests, and automatically adding/removing items from the clean up list. these are all things that this testing framework will do eventually. i'd like to see them all built in upfront. it will make all the rest of the changes easier. | 17:40 |
dave-mccowan | diazjf like here: the clean-up code knows which user credentials to use when cleaning up. https://github.com/openstack/barbican/blob/master/functionaltests/api/v1/behaviors/secret_behaviors.py#L171 | 17:43 |
dave-mccowan | diajzf you could extend that concept and have this code know also which barbicanclient class to use for delete. then you can have just one clean-up list for all things. | 17:45 |
dave-mccowan | diajzf also give the test code a method to add and remove things from the clean-up list, instead of have each test case manage its own list. | 17:46 |
diazjf | dave-mccowan, thanks for all the input. Items were however seperated by different behaviors, so shouldn't we have different cleanup methods?, rather than a cleanup all. Seems like more checks, if you are just cleaning secrets, why check for containers, etc. I guess it makes sense to cleanup items from a list, but it would have to be a dictionary containing lists of different item types so I know what function to run. | 17:48 |
diazjf | The tests you have shown me are for barbican, but with barbican-client it always uses the user in /etc/functional-tests.conf, so no need to | 17:48 |
diazjf | add rbac control like in https://github.com/openstack/barbican/blob/master/functionaltests/api/v1/behaviors/secret_behaviors.py#L171 | 17:48 |
dave-mccowan | diazjf the user who creates a secret, may not have permissions to delete a secret. | 17:50 |
dave-mccowan | diazjf someday, someone might want to add rbac testing to barbican client. it would be nice if the test framework had support for it, or at least a roadmap to add support for it. | 17:51 |
diazjf | dave-mccowan, that sounds good. I would like to work on it after the test behaviors are removed so its not so messy. Appreciate all your input!! Gonna try and make it one class that handles all item cleanup | 17:54 |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Create Common functions used for cleaning up items used for testing https://review.openstack.org/218396 | 17:58 |
diazjf | dave-mccowan, also what do I need to do to make all my patches dependant on ^^ | 17:59 |
dave-mccowan | diazjf cool. you might find it easier to do the foundation first. then you won't have so much custom code to write for each test case. | 18:00 |
dave-mccowan | diazjf git review -d PARENT_CHANGE_ID | 18:01 |
dave-mccowan | git review -x CHILD_CHANGE_ID | 18:01 |
dave-mccowan | git review | 18:01 |
diazjf | dave-mccowan, awesome!! much appreciated :) | 18:02 |
rellerreller | dave-mccowan diazjf I did not know about the git review -x and -d options. Thanks for sharing. I always put the commits on the same branch and did git review for multiple commits. | 18:20 |
rellerreller | It would add the dependencies for me automatically. | 18:20 |
dave-mccowan | rellerreller sure. gerrit has some neat features, but they're hard to find sometimes since google always returns git native solutions first. | 18:22 |
*** jaosorior has quit IRC | 18:25 | |
arunkant | jaosorior: ping | 18:26 |
*** spotz is now known as spotz_zzz | 18:27 | |
arunkant | rellerreller, kfarr : Can you please look into ACL barbican client changes when you have some time . https://review.openstack.org/#/c/206699/ (2 patches are linked to it). Looking for review as it has been pending for a while | 18:29 |
kfarr | ok arunkant, I will try to take a look in a little bit | 18:30 |
*** insequent has quit IRC | 18:34 | |
*** ccneill has quit IRC | 18:52 | |
openstackgerrit | Fernando Diaz proposed openstack/python-barbicanclient: Create Common functions used for cleaning up items used for testing https://review.openstack.org/218396 | 18:53 |
openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs https://review.openstack.org/208343 | 19:03 |
openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 3: Adding ACL functional tests. https://review.openstack.org/208344 | 19:03 |
*** diazjf has quit IRC | 19:05 | |
*** diazjf has joined #openstack-barbican | 19:06 | |
*** silos has joined #openstack-barbican | 19:08 | |
silos | easy patch up for review: https://review.openstack.org/#/c/217938/2 if anyone has time. | 19:11 |
*** SheenaG has quit IRC | 19:12 | |
*** SheenaG has joined #openstack-barbican | 19:13 | |
*** dave-mccowan has quit IRC | 19:16 | |
*** ccneill has joined #openstack-barbican | 19:20 | |
*** silos has left #openstack-barbican | 19:37 | |
*** vivek-ebay has quit IRC | 19:39 | |
*** vivek-ebay has joined #openstack-barbican | 19:40 | |
*** diazjf has quit IRC | 19:45 | |
*** dave-mccowan has joined #openstack-barbican | 19:47 | |
*** vivek-ebay has quit IRC | 19:51 | |
*** rellerreller has quit IRC | 20:02 | |
*** spotz_zzz is now known as spotz | 20:13 | |
woodster_ | alee: kfarr dave-mccowan arunkant jvrbanac redrobot Please take a look at comments on this CR when you can: https://review.openstack.org/#/c/208343 | 20:13 |
*** spotz is now known as spotz_zzz | 20:24 | |
*** insequent has joined #openstack-barbican | 20:43 | |
*** spotz_zzz is now known as spotz | 20:44 | |
*** diazjf has joined #openstack-barbican | 20:47 | |
*** vivek-ebay has joined #openstack-barbican | 20:49 | |
arunkant | woodster_, get ACL is the only call which works of resource URI. All other server operations works on acl entity. Do you think providing /acl URI for get will be confusing to client when its requesting ACL data? | 20:51 |
*** edtubill has left #openstack-barbican | 20:51 | |
*** spotz has quit IRC | 21:04 | |
*** spotz has joined #openstack-barbican | 21:05 | |
*** spotz has quit IRC | 21:09 | |
*** spotz_zzz has joined #openstack-barbican | 21:09 | |
*** spotz_zzz is now known as spotz | 21:09 | |
*** chadlung has quit IRC | 21:12 | |
*** diazjf has left #openstack-barbican | 21:13 | |
*** kebray has quit IRC | 21:35 | |
woodster_ | arunkant: I think so, since I'd think folks are thinking of marking acls on a secret/container (so starting with secret/container refs) rather than on a sub-resource off of the secret/container. Perhaps if there is an alternate way to get the acl, say from the secret/container or their refs, that could work too. So maybe a 'parent_ref' kwarg option for the | 21:38 |
woodster_ | barbican.acls.get() call? | 21:38 |
*** kebray has joined #openstack-barbican | 21:43 | |
arunkant | woodster_, Okay. Let me change it to require secret or container ref instead. | 21:46 |
*** xaeth is now known as xaeth_afk | 22:01 | |
*** everjeje has joined #openstack-barbican | 22:05 | |
*** vivek-ebay has quit IRC | 22:05 | |
*** vivek-ebay has joined #openstack-barbican | 22:05 | |
woodster_ | arunkant: I wish more folks would weigh in on this one, but it makes more sense to me from a usability perspective to centralize on the secret/container ref. | 22:12 |
*** chadlung has joined #openstack-barbican | 22:12 | |
*** dimtruck is now known as zz_dimtruck | 22:14 | |
*** pglass has quit IRC | 22:15 | |
*** kfarr has quit IRC | 22:16 | |
*** chadlung has quit IRC | 22:17 | |
*** kebray has quit IRC | 22:18 | |
*** kebray has joined #openstack-barbican | 22:19 | |
*** jlhinson has quit IRC | 22:29 | |
*** spotz is now known as spotz_zzz | 22:30 | |
openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 1: Adding ACL support for Client API. https://review.openstack.org/206699 | 22:30 |
openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs https://review.openstack.org/208343 | 22:31 |
openstackgerrit | Arun Kant proposed openstack/python-barbicanclient: Part 3: Adding ACL functional tests. https://review.openstack.org/208344 | 22:31 |
*** mixos has quit IRC | 22:33 | |
*** jlhinson has joined #openstack-barbican | 22:50 | |
*** jamielennox is now known as jamielennox|away | 23:00 | |
*** chadlung has joined #openstack-barbican | 23:01 | |
*** chadlung has quit IRC | 23:03 | |
*** SheenaG has quit IRC | 23:19 | |
*** david-lyle has quit IRC | 23:24 | |
*** kebray has quit IRC | 23:28 | |
*** vivek-ebay has quit IRC | 23:58 | |
*** vivek-ebay has joined #openstack-barbican | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!