Friday, 2015-08-28

*** vivek-ebay has joined #openstack-barbican00:01
*** vivek-ebay has quit IRC00:02
*** vivek-ebay has joined #openstack-barbican00:02
*** dave-mccowan has joined #openstack-barbican00:06
*** alee has quit IRC00:38
openstackgerritChristopher Solis proposed openstack/python-barbicanclient: Add epilog to parser  https://review.openstack.org/21793800:39
*** alee has joined #openstack-barbican00:40
*** vivek-ebay has quit IRC01:08
*** chadlung has joined #openstack-barbican01:38
*** woodster_ has quit IRC01:39
openstackgerritZhenyu Zheng proposed openstack/barbican: Make alembic used in barbican similar to other openstack projects  https://review.openstack.org/21700402:01
*** chadlung has quit IRC02:10
openstackgerritDave McCowan proposed openstack/barbican: Implement Enforce Method for QuotaEnforcer  https://review.openstack.org/21806402:33
*** dave-mccowan has quit IRC02:43
*** gyee has quit IRC02:51
*** insequent has joined #openstack-barbican02:59
*** nelsnels_ has quit IRC03:17
*** nelsnelson has joined #openstack-barbican03:18
*** rm_work has quit IRC03:27
*** hockeynut has quit IRC03:27
*** spotz_zzz has quit IRC03:28
*** jillysciarilly has quit IRC03:28
*** jroll has quit IRC03:28
*** zz_dimtruck has quit IRC03:28
*** tdink has quit IRC03:28
*** alee has quit IRC03:28
*** lbragstad has quit IRC03:28
*** eglute has quit IRC03:28
*** alee has joined #openstack-barbican03:29
*** eglute has joined #openstack-barbican03:31
*** rm_work has joined #openstack-barbican03:31
*** jroll has joined #openstack-barbican03:32
*** zz_dimtruck has joined #openstack-barbican03:32
*** zz_dimtruck is now known as dimtruck03:32
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for secrets  https://review.openstack.org/21341403:36
*** hockeynut has joined #openstack-barbican03:36
*** tdink has joined #openstack-barbican03:37
*** jillysciarilly has joined #openstack-barbican03:37
*** lbragstad has joined #openstack-barbican03:37
*** spotz_zzz has joined #openstack-barbican03:37
pksinghrm_work: Hi are you around?04:31
openstackgerritElvin Tubillara proposed openstack/barbican: WIP Add request ID to worker-side logs  https://review.openstack.org/21777504:32
openstackgerritMotohiro/Yuanying Otsuka proposed openstack/barbican: Set host_href parameter in devstack  https://review.openstack.org/21809104:56
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders  https://review.openstack.org/21341904:59
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders  https://review.openstack.org/21341905:08
*** nelsnelson has quit IRC05:25
rm_workpksingh: i am NOW05:46
*** Nirupama has joined #openstack-barbican05:47
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for containers  https://review.openstack.org/21342006:19
*** shohel has joined #openstack-barbican06:22
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders  https://review.openstack.org/21341906:27
*** ryanpetrello has quit IRC06:32
*** mixos has quit IRC06:36
*** ryanpetrello has joined #openstack-barbican06:40
openstackgerritFernando Diaz proposed openstack/barbican: Add some documentation on running a single functional test case  https://review.openstack.org/21811706:42
*** Nirupama has quit IRC06:50
*** Nirupama has joined #openstack-barbican06:53
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for secrets smoke tests  https://review.openstack.org/21728006:57
*** Kevin_Zheng has quit IRC07:05
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders smoke tests  https://review.openstack.org/21729807:21
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for orders smoke tests  https://review.openstack.org/21729807:23
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for containers smoke tests  https://review.openstack.org/21731207:36
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Remove test behaviors abstraction for containers  https://review.openstack.org/21342007:39
*** shohel has quit IRC08:22
*** shohel has joined #openstack-barbican08:26
*** shohel1 has joined #openstack-barbican09:06
*** shohel has quit IRC09:07
*** shohel1 has quit IRC09:11
*** shohel has joined #openstack-barbican09:27
*** dave-mccowan has joined #openstack-barbican09:58
*** mmdurrant has quit IRC10:09
*** ryanpetrello has quit IRC10:27
*** rm_work has quit IRC10:27
*** alee has quit IRC10:27
*** jamielennox has quit IRC10:27
*** everjeje has quit IRC10:27
*** rm_you has quit IRC10:27
*** d0ugal has quit IRC10:27
*** jillysciarilly has quit IRC10:27
*** spotz_zzz has quit IRC10:27
*** tdink has quit IRC10:27
*** lbragstad has quit IRC10:27
*** hockeynut has quit IRC10:27
*** jroll has quit IRC10:27
*** dimtruck has quit IRC10:27
*** eglute has quit IRC10:27
*** spotz_zzz has joined #openstack-barbican10:29
*** lbragstad has joined #openstack-barbican10:29
*** jillysciarilly has joined #openstack-barbican10:29
*** tdink has joined #openstack-barbican10:29
*** hockeynut has joined #openstack-barbican10:29
*** dimtruck has joined #openstack-barbican10:29
*** jroll has joined #openstack-barbican10:29
*** eglute has joined #openstack-barbican10:29
*** ryanpetrello has joined #openstack-barbican10:30
*** rm_work has joined #openstack-barbican10:30
*** alee has joined #openstack-barbican10:30
*** jamielennox has joined #openstack-barbican10:30
*** everjeje has joined #openstack-barbican10:30
*** rm_you has joined #openstack-barbican10:30
*** d0ugal has joined #openstack-barbican10:30
*** ryanpetrello has quit IRC10:30
*** rm_work has quit IRC10:30
*** alee has quit IRC10:30
*** jamielennox has quit IRC10:30
*** everjeje has quit IRC10:30
*** rm_you has quit IRC10:30
*** d0ugal has quit IRC10:30
*** ryanpetrello has joined #openstack-barbican10:32
*** rm_work has joined #openstack-barbican10:32
*** alee has joined #openstack-barbican10:32
*** jamielennox has joined #openstack-barbican10:32
*** everjeje has joined #openstack-barbican10:32
*** rm_you has joined #openstack-barbican10:32
*** d0ugal has joined #openstack-barbican10:32
*** shohel has quit IRC10:52
*** mmdurrant has joined #openstack-barbican11:58
*** Nirupama has quit IRC12:07
*** rellerreller has joined #openstack-barbican12:20
*** chlong has joined #openstack-barbican12:34
*** nelsnelson has joined #openstack-barbican12:50
*** woodster_ has joined #openstack-barbican12:55
*** kfarr has joined #openstack-barbican12:56
*** shohel has joined #openstack-barbican13:00
*** darrenmoffat has quit IRC13:10
*** darrenmoffat has joined #openstack-barbican13:25
*** nelsnelson has quit IRC13:27
*** spotz_zzz is now known as spotz13:57
*** jaosorior has joined #openstack-barbican13:57
*** SheenaG has joined #openstack-barbican13:59
*** shohel has quit IRC14:02
*** shohel has joined #openstack-barbican14:02
*** pglass has joined #openstack-barbican14:09
rellerrellerjvrbanac I found this bug, https://bugs.launchpad.net/barbican/+bug/148990014:12
openstackLaunchpad bug 1489900 in Barbican "Test Attributes are Lost" [Undecided,New] - Assigned to Nathan Reller (rellerreller)14:12
rellerrellerjvrbanac I thought you might be interested in that14:13
*** silos has joined #openstack-barbican14:26
*** SheenaG has quit IRC14:29
openstackgerritNathan Reller proposed openstack/barbican: Fixed Testing Attributes Bug  https://review.openstack.org/21829614:30
*** rellerreller has quit IRC14:32
*** everjeje has quit IRC14:32
openstackgerritchandan kumar proposed openstack/barbican: Removing unused dependency: discover  https://review.openstack.org/21830014:33
*** xaeth_afk is now known as xaeth14:36
*** mixos has joined #openstack-barbican14:42
*** rellerreller has joined #openstack-barbican14:43
rellerrellerCan we get some eyes on https://review.openstack.org/#/c/212579/ today? Please :-)14:43
*** jlhinson has joined #openstack-barbican14:45
*** shohel has quit IRC14:51
*** mixos has quit IRC14:57
*** insequent has quit IRC14:57
*** dave-mccowan has quit IRC15:06
*** ccneill_ has joined #openstack-barbican15:12
*** ccneill_ is now known as ccneill15:13
*** diazjf has joined #openstack-barbican15:16
*** dave-mccowan has joined #openstack-barbican15:19
*** mixos has joined #openstack-barbican15:20
dave-mccowanthere are three outstanding quota blueprint CRs. start here: https://review.openstack.org/#/c/216253/  then follow the chain for the other two.  quotas are functionally complete after these three land. \o/   if you have questions on them, please ask. :-)15:25
*** edtubill has joined #openstack-barbican15:25
rellerrellerping dave-mccowan15:36
rellerrellerdave-mccowan ping15:37
*** chlong has quit IRC15:39
*** SheenaG has joined #openstack-barbican15:41
elmikoredrobot, kfarr, i'm trying to setup a sahara patch that will include the first release of castellan. what version might i expect, so that i can add it to my requirements.txt?15:58
kfarrelmiko 0.2.0 I believe15:58
elmikokfarr: great, thanks!15:59
*** xaeth is now known as xaeth_afk16:00
kfarrelmiko, there's already 0.1.0, but that only includes only support for symmetric keys.  Code from way back in march16:01
elmikokfarr: yea, although i'm not seeing it on pypi...16:01
kfarrelmiko https://pypi.python.org/pypi/castellan16:02
elmikoah, thanks, my search ability failed horribly lol16:02
*** xaeth_afk is now known as xaeth16:02
elmikokfarr: really looking forward to the next release. it's been a great effort =)16:02
kfarroh you're right, it doesn't show up from the search bar.  that's strange16:03
kfarrelmiko, I know!  Thanks for all your help with things16:03
elmikokfarr: hey, just glad to be part of the team16:03
*** vivek-ebay has joined #openstack-barbican16:11
kfarrjaosorior, redrobot, if you get a chance today, please review the latest Castellan patch: https://review.openstack.org/#/c/208569/ Last one before we should have a release!16:19
*** chlong has joined #openstack-barbican16:22
*** insequent has joined #openstack-barbican16:23
diazjfrellerreller, dave-mccowan, making the _delete_all_containers function to a common class in https://review.openstack.org/#/c/213420/7/functionaltests/client/v1/functional/test_containers.py do you suggest I move them to the base test class or make a new file in common that just does cleanup. Thanks!!16:23
dave-mccowandiazif a new file for the new base class sounds good to me.  that would make it more portable, in case we want to adopt it in another repo.16:32
dave-mccowanrellerreller pong16:32
*** jorgem has joined #openstack-barbican16:35
*** vivek-ebay has quit IRC16:36
rellerrellerdiazjf I concur with dave-mccowan.16:41
rellerrellerdave-mccowan I had some comments on the quota CR you have, the first one.16:41
rellerrellerdave-mccowan I left a comment in there about removing the external project ID. I don't know if you saw that.16:41
dave-mccowanrellerreller reading it now.16:42
dave-mccowanrellerreller my thought was for performance.  if i did not store both the internal and external project ids, then i would need two database lookups for every operation.16:44
*** chlong has quit IRC16:45
dave-mccowanrellerreller, honestly, if anything, i'd like to remove the internal project_id.  but, that's the current standard for project foreign keys in the database.16:45
rellerrellerdave-mccowan I think one FK, and I suggest internal project id since that is what everything else is using16:45
rellerrellerdave-mccowan I am worried that if have both then can get in weird state. I know that we _should_ not, but it is nice to have the database enforcement.16:46
dave-mccowanrellerreller there is only one foreign key and internal_project_id is the required one, because you can only have a foreign key matching the primary key of another table.16:47
rellerrellerdave-mccowan correct16:47
rellerrellerdave-mccowan what the two db lookups?16:48
dave-mccowanrellerreller yea, i consider the risk of error.  but, sided with performance (only one look up) and ease of use (all interactions with PQs start with the external id).16:48
dave-mccowanGET /v1/project-quotas/12345    starts with the external id.  if i need the internal id, i'll need to lookup it up first.16:49
rellerrellerdave-mccowan would that be two different statements or one with a join?16:50
rellerrellerdave-mccowan either way I think the cost of an extra db query or join statement is worth not getting the db in a weird state.16:51
dave-mccowanrellerreller i'm not sure.  there's probably some SQL foo to do it one.16:51
diazjfrellerreller, dave-mccowan, thanks!! Gonna make a new file in /common for the tests. I'll let you know once the patch is up.16:52
rellerrellerdave-mccowan it should be easy to write a join statement that fetches the project and the quotas in one statement. If we need both or the performance increase.16:52
*** kebray has joined #openstack-barbican16:54
dave-mccowanrellerreller try this for a sec:  pick a controller file, like controller/secrets.py and skim through all the "external_project_id" uses.  "external_project_id" seems like Barbican-native.  project-quotas would become the exception, i think.16:55
rellerrellerdave-mccowan which parts are you referring to?16:58
rellerrellerdave-mccowan I see the log statements are using the external ID.16:58
rellerrellerdave-mccowan OK, I see it for secret repo as well.17:00
dave-mccowanrellerreller and the interfaces to the plugins.  all operations deal with external_project_id.  the only thing the internal project id is used for is to store it in the database.17:00
openstackgerritElvin Tubillara proposed openstack/barbican: WIP Add Request ID to worker-side logs in barbican. This can help correlate errors in logs to an incoming request  https://review.openstack.org/21777517:00
dave-mccowanrellerreller i agree it's confusing.  i got stuck on a validator bug last cycle when i mixed up internal/external project ids in the orders api.17:01
rellerrellerdave-mccowan If the interface wants to use external id then that is not as big of a deal to me.17:02
rellerrellerdave-mccowan I think the important thing is that the db model references the FK to project.17:03
rellerrellerdave-mccowan look at secret for example.17:03
*** silos has left #openstack-barbican17:03
rellerrellerdave-mccowan the store method takes a project model. That is another option if you do not want to choose between internal and external project id.17:04
rellerrellerdave-mccowan you could pass the referenced project object to the quota driver. Then the quota driver can easily get the project and external project ID from that without having to query the db.17:05
rellerrellerdave-mccowan I think of it like this. Should secret, container, consumer, order, and quota all have two columns for project ID and external project ID or should they have a FK relationship to project that stores the external project id?17:07
dave-mccowanrellerreller the difference between the secret/container/consumer/etc.  is that they all have their own ref.   the external_project_id happens to also be the ref for the project-quotas record.17:09
rellerrellerdave-mccowan I don't quite understand why the external ref matters for your point?17:11
arunkantdave-mccowan : agree with rellerreller. For looking quotas record based on keystone project_id, table join with projects table can be used to look (assuming foreign key is defined on internal project_id)17:12
dave-mccowanrellerreller the external ref is everything.  it is the value that is used in get, set, and delete.17:12
rellerrellerdave-mccowan so the external ref is used to find a resource. You can map external id to internal id to quotas.17:14
rellerrellerdave-mccowan the internal ID for the quotas table could be anything. We could make it a random number that is assigned with the table row is created.17:14
openstackgerritFernando Diaz proposed openstack/barbican: Add some documentation on running a single functional test case  https://review.openstack.org/21811717:15
rellerrellerdave-mccowan the important part is that ref can be mapped to a row, and that can happen. The other important part is to make sure that mappings only occur once.17:15
dave-mccowanrellerreller.   hmmm.... ok, are you suggesting to leave the controller and driver code alone.  then in repo code, have the same API, but get rid of the external_proejct_id column and use join instead of a simple look up?17:16
rellerrellerdave-mccowan in this case the mapping from external_id->internal_id. If you have it defined more than once then chances are that data will be out of sync.17:16
rellerrellerdave-mccowan right now my only suggestion is that quotas model only has FK reference to project and external id is removed.17:17
rellerrellerdave-mccowan I would have to think more about the quota API. My first reaction would be that it takes a project model.17:18
rellerrellerdave-mccowan but I can leave that up to you17:19
dave-mccowanrellerreller  OK.  i agree with that concept.  i think i can make that happen, while still allowing the controller and driver to only deal with the external_project_id which is the one that is used outside of the repo code.17:19
rellerrellerdave-mccowan yes, I think the controller should take the external ID because that will make sense to the user.17:19
rellerrellerdave-mccowan then either the controller or the quota driver needs to map that to quota table objects.17:20
*** chadlung has joined #openstack-barbican17:21
dave-mccowanrellerreller i'd like to make the repo code do that.  there's no need for code outside the repo to even know the internal project id.17:22
rellerrellerdave-mccowan what is the PK on the quotas table?17:23
rellerrellerdave-mccowan when you retrieve a project it should retrieve its quotas correct?17:24
dave-mccowanthe "internal_project_quota_id"  a value that is never referenced in any code.17:24
rellerrellerdave-mccowan that relationship is setup in the project model, I believe.17:24
rellerrellerdave-mccowan If that is the case then you could pass the Quota model to the quota driver by retrieving it from the Project model.17:25
rellerrellerdave-mccowan then update the Quota instance as needed and call save on the repo. Would that work?17:25
dave-mccowanrellerreller i don't understand.  what do you mean by: when you retrieve a project it should retrieve its quotas correct?17:27
dave-mccowanrellerreller the only information in the project table is the internal id and the external id.17:28
rellerrellerdave-mccowan After you retrieve a Project from project repo you should be able to do `project.quotas` to get the Quotas model associated with the project.17:28
dave-mccowanrellerreller really?  is that SQL magic from the orm.relationship() method?17:29
rellerrellerdave-mccowan I'm not as familiar with sqlalchemy, but in Hibernate you can retrieve an object like Project and it would automatically retrieve its Quota associated with it.17:29
rellerrellerdave-mccowan I think so, but I do not know for sure.17:29
*** vivek-ebay has joined #openstack-barbican17:29
rellerrellerdave-mccowan I think it would be worth a test.17:30
dave-mccowanrellerreller that'd be like retrieving every secret in a project when you got a project.17:30
rellerrellerdave-mccowan I do not know the configurations for how the properties are retrieved, but it would not surprise me.17:31
rellerrellerdave-mccowan in Hibernate you can mark certain relationships as "eager" or "lazy". Eager relationships mean that every time the object is retrieved the dependent object is also retrieved.17:32
rellerrellerdave-mccowan I do not know if sqlalchemy has that type of mapping or not. It seems like quota could be a good candidate because very little data and 1-1 mapping.17:32
dave-mccowanrellerreller i'll take a look.  between that and join, there should be answer that addresses the concern of having two project IDs in the quotas table.17:33
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Create Common functions used for cleaning up items used for testing  https://review.openstack.org/21839617:34
diazjf^^ rellerreller, dave-mccowan: added the patch seen above, let me know what you think and to make my other patches dependant on it, do I just need to add the ChangeId?17:36
dave-mccowandiazjf did you see my suggestion for a class with delete_all_the_things()?17:38
openstackgerritKaitlin Farr proposed openstack/castellan: Update Barbican wrapper  https://review.openstack.org/20856917:40
dave-mccowandiazjf thinking ahead, the behaviors code that you're replacing dealt with unauth tests, rbac tests, and automatically adding/removing items from the clean up list.   these are all things that this testing framework will do eventually.  i'd like to see them all built in upfront.  it will make all the rest of the changes easier.17:40
dave-mccowandiazjf like here: the clean-up code knows which user credentials to use when cleaning up. https://github.com/openstack/barbican/blob/master/functionaltests/api/v1/behaviors/secret_behaviors.py#L17117:43
dave-mccowandiajzf you could extend that concept and have this code know also which barbicanclient class to use for delete.  then you can have just one clean-up list for all things.17:45
dave-mccowandiajzf also give the test code a method to add and remove things from the clean-up list, instead of have each test case manage its own list.17:46
diazjfdave-mccowan, thanks for all the input.  Items were however seperated by different behaviors, so shouldn't we have different cleanup methods?, rather than a cleanup all. Seems like more checks, if you are just cleaning secrets, why check for containers, etc.  I guess it makes sense to cleanup items from a list, but it would have to be a dictionary containing lists of different item types so I know what function to run.17:48
diazjfThe tests you have shown me are for barbican, but with barbican-client it always uses the user in /etc/functional-tests.conf, so no need to17:48
diazjfadd rbac control like in https://github.com/openstack/barbican/blob/master/functionaltests/api/v1/behaviors/secret_behaviors.py#L17117:48
dave-mccowandiazjf  the user who creates a secret, may not have permissions to delete a secret.17:50
dave-mccowandiazjf someday, someone might want to add rbac testing to barbican client.  it would be nice if the test framework had support for it, or at least a roadmap to add support for it.17:51
diazjfdave-mccowan, that sounds good. I would like to work on it after the test behaviors are removed so its not so messy. Appreciate all your input!! Gonna try and make it one class that handles all item cleanup17:54
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Create Common functions used for cleaning up items used for testing  https://review.openstack.org/21839617:58
diazjfdave-mccowan, also what do I need to do to make all my patches dependant on ^^17:59
dave-mccowandiazjf cool.  you might find it easier to do the foundation first.  then you won't have so much custom code to write for each test case.18:00
dave-mccowandiazjf git review -d PARENT_CHANGE_ID18:01
dave-mccowangit review -x CHILD_CHANGE_ID18:01
dave-mccowangit review18:01
diazjfdave-mccowan, awesome!! much appreciated :)18:02
rellerrellerdave-mccowan diazjf I did not know about the git review -x and -d options. Thanks for sharing. I always put the commits on the same branch and did git review for multiple commits.18:20
rellerrellerIt would add the dependencies for me automatically.18:20
dave-mccowanrellerreller sure.  gerrit has some neat features, but they're hard to find sometimes since google always returns git native solutions first.18:22
*** jaosorior has quit IRC18:25
arunkantjaosorior: ping18:26
*** spotz is now known as spotz_zzz18:27
arunkantrellerreller, kfarr : Can you please look into ACL barbican client changes when you have some time . https://review.openstack.org/#/c/206699/ (2 patches are linked to it). Looking for review as it has been pending for a while18:29
kfarrok arunkant, I will try to take a look in a little bit18:30
*** insequent has quit IRC18:34
*** ccneill has quit IRC18:52
openstackgerritFernando Diaz proposed openstack/python-barbicanclient: Create Common functions used for cleaning up items used for testing  https://review.openstack.org/21839618:53
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs  https://review.openstack.org/20834319:03
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 3: Adding ACL functional tests.  https://review.openstack.org/20834419:03
*** diazjf has quit IRC19:05
*** diazjf has joined #openstack-barbican19:06
*** silos has joined #openstack-barbican19:08
siloseasy patch up for review: https://review.openstack.org/#/c/217938/2 if anyone has time.19:11
*** SheenaG has quit IRC19:12
*** SheenaG has joined #openstack-barbican19:13
*** dave-mccowan has quit IRC19:16
*** ccneill has joined #openstack-barbican19:20
*** silos has left #openstack-barbican19:37
*** vivek-ebay has quit IRC19:39
*** vivek-ebay has joined #openstack-barbican19:40
*** diazjf has quit IRC19:45
*** dave-mccowan has joined #openstack-barbican19:47
*** vivek-ebay has quit IRC19:51
*** rellerreller has quit IRC20:02
*** spotz_zzz is now known as spotz20:13
woodster_alee: kfarr dave-mccowan arunkant jvrbanac redrobot Please take a look at comments on this CR when you can: https://review.openstack.org/#/c/20834320:13
*** spotz is now known as spotz_zzz20:24
*** insequent has joined #openstack-barbican20:43
*** spotz_zzz is now known as spotz20:44
*** diazjf has joined #openstack-barbican20:47
*** vivek-ebay has joined #openstack-barbican20:49
arunkantwoodster_, get ACL is the only call which works of resource URI. All other server operations works on acl entity. Do you think providing /acl URI for get will be confusing to client when its requesting ACL data?20:51
*** edtubill has left #openstack-barbican20:51
*** spotz has quit IRC21:04
*** spotz has joined #openstack-barbican21:05
*** spotz has quit IRC21:09
*** spotz_zzz has joined #openstack-barbican21:09
*** spotz_zzz is now known as spotz21:09
*** chadlung has quit IRC21:12
*** diazjf has left #openstack-barbican21:13
*** kebray has quit IRC21:35
woodster_arunkant: I think so, since I'd think folks are thinking of marking acls on a secret/container (so starting with secret/container refs) rather than on a sub-resource off of the secret/container. Perhaps if there is an alternate way to get the acl, say from the secret/container or their refs, that could work too. So maybe a 'parent_ref' kwarg option for the21:38
woodster_barbican.acls.get() call?21:38
*** kebray has joined #openstack-barbican21:43
arunkantwoodster_, Okay. Let me change it to require secret or container ref instead.21:46
*** xaeth is now known as xaeth_afk22:01
*** everjeje has joined #openstack-barbican22:05
*** vivek-ebay has quit IRC22:05
*** vivek-ebay has joined #openstack-barbican22:05
woodster_arunkant: I wish more folks would weigh in on this one, but it makes more sense to me from a usability perspective to centralize on the secret/container ref.22:12
*** chadlung has joined #openstack-barbican22:12
*** dimtruck is now known as zz_dimtruck22:14
*** pglass has quit IRC22:15
*** kfarr has quit IRC22:16
*** chadlung has quit IRC22:17
*** kebray has quit IRC22:18
*** kebray has joined #openstack-barbican22:19
*** jlhinson has quit IRC22:29
*** spotz is now known as spotz_zzz22:30
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 1: Adding ACL support for Client API.  https://review.openstack.org/20669922:30
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs  https://review.openstack.org/20834322:31
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 3: Adding ACL functional tests.  https://review.openstack.org/20834422:31
*** mixos has quit IRC22:33
*** jlhinson has joined #openstack-barbican22:50
*** jamielennox is now known as jamielennox|away23:00
*** chadlung has joined #openstack-barbican23:01
*** chadlung has quit IRC23:03
*** SheenaG has quit IRC23:19
*** david-lyle has quit IRC23:24
*** kebray has quit IRC23:28
*** vivek-ebay has quit IRC23:58
*** vivek-ebay has joined #openstack-barbican23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!