*** kgriffs is now known as kgriffs|afk | 00:24 | |
*** SheenaG has joined #openstack-barbican | 00:42 | |
*** gyee has quit IRC | 00:48 | |
*** zz_dimtruck is now known as dimtruck | 00:56 | |
*** SheenaG has quit IRC | 01:34 | |
*** dimtruck is now known as zz_dimtruck | 02:00 | |
*** SheenaG has joined #openstack-barbican | 02:03 | |
*** alee_afk has quit IRC | 02:57 | |
*** xaeth_afk is now known as xaeth | 03:08 | |
*** alee_afk has joined #openstack-barbican | 03:10 | |
*** xaeth is now known as xaeth_afk | 03:10 | |
*** xaeth_afk is now known as xaeth | 03:10 | |
*** xaeth is now known as xaeth_afk | 03:11 | |
openstackgerrit | Arun Kant proposed openstack/barbican: For per secret ACL support, adding db layer changes (Part 1) https://review.openstack.org/164334 | 03:13 |
---|---|---|
openstackgerrit | Arun Kant proposed openstack/barbican: Adding Secret ACL controller layer changes (Part 2) https://review.openstack.org/164335 | 03:14 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding Container ACL controller layer changes (Part 3) https://review.openstack.org/165205 | 03:14 |
*** alee_afk has quit IRC | 03:14 | |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding policy layer changes for ACL support (Part 4) https://review.openstack.org/165207 | 03:14 |
*** alee_afk has joined #openstack-barbican | 03:16 | |
*** alee_afk has quit IRC | 03:20 | |
*** SheenaG1 has joined #openstack-barbican | 03:26 | |
*** SheenaG has quit IRC | 03:28 | |
*** kebray has joined #openstack-barbican | 03:34 | |
*** SheenaG1 has quit IRC | 03:38 | |
openstackgerrit | Dave McCowan proposed openstack/barbican: Fix string formatting for a secret store exception message https://review.openstack.org/167484 | 03:52 |
*** tkelsey has joined #openstack-barbican | 03:53 | |
*** tkelsey has quit IRC | 03:57 | |
*** rm_you| has joined #openstack-barbican | 04:03 | |
*** rm_you|wtf has quit IRC | 04:05 | |
*** woodster_ has quit IRC | 04:10 | |
openstackgerrit | Dave McCowan proposed openstack/barbican: Fix string formatting for a secret store exception message https://review.openstack.org/167484 | 04:16 |
*** kebray has quit IRC | 04:19 | |
*** alee_afk has joined #openstack-barbican | 05:32 | |
openstackgerrit | Dave McCowan proposed openstack/barbican: Implement validators and tests for stored key certificate orders https://review.openstack.org/167291 | 05:45 |
*** dave-mccowan has quit IRC | 05:46 | |
*** jamielennox is now known as jamielennox|away | 05:49 | |
*** tkelsey has joined #openstack-barbican | 05:54 | |
*** tkelsey has quit IRC | 05:59 | |
*** chlong has quit IRC | 07:52 | |
*** tkelsey has joined #openstack-barbican | 08:09 | |
*** gitorres has joined #openstack-barbican | 09:08 | |
*** gitorres has left #openstack-barbican | 09:36 | |
*** SheenaG has joined #openstack-barbican | 09:44 | |
*** SheenaG has quit IRC | 09:48 | |
*** gitorres has joined #openstack-barbican | 10:40 | |
*** woodster_ has joined #openstack-barbican | 11:50 | |
*** chlong has joined #openstack-barbican | 11:51 | |
*** openstackgerrit has quit IRC | 12:06 | |
*** openstackgerrit has joined #openstack-barbican | 12:06 | |
*** jaosorior has joined #openstack-barbican | 12:08 | |
jaosorior | hockeynut, rellerreller: ping | 12:08 |
openstackgerrit | Arun Kant proposed openstack/barbican: For per secret ACL support, adding db layer changes (Part 1) https://review.openstack.org/164334 | 13:03 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding Secret ACL controller layer changes (Part 2) https://review.openstack.org/164335 | 13:03 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding Container ACL controller layer changes (Part 3) https://review.openstack.org/165205 | 13:03 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding policy layer changes for ACL support (Part 4) https://review.openstack.org/165207 | 13:03 |
*** gitorres has left #openstack-barbican | 13:17 | |
*** joesavak has joined #openstack-barbican | 13:21 | |
*** everjeje has joined #openstack-barbican | 13:27 | |
*** joesavak has quit IRC | 13:27 | |
*** alee_afk is now known as alee | 13:34 | |
*** openstackgerrit has quit IRC | 13:36 | |
*** openstackgerrit has joined #openstack-barbican | 13:36 | |
arunkant | alee, redrobot, jaosorior, woodster_: For ACL stuff, I have added changes related to new user tables in first patch. There are 3 more acl related patches..will be helpful if it can be reviewed as well. | 13:50 |
openstackgerrit | Ade Lee proposed openstack/barbican: Fix CA related exceptions, and unskip relevant tests https://review.openstack.org/166316 | 13:54 |
alee | arunkant, ok | 13:55 |
alee | woodster_, jvrbanac , hockeynut , jaosorior, https://review.openstack.org/166316 - made the small change requested. please review and approve. | 13:57 |
*** paul_glass has joined #openstack-barbican | 14:03 | |
*** atiwari has joined #openstack-barbican | 14:17 | |
openstackgerrit | Ade Lee proposed openstack/barbican: Fix some ca_id related bugs, add more functional test code https://review.openstack.org/166839 | 14:22 |
openstackgerrit | Ade Lee proposed openstack/barbican: Changes to get Dogtag related functional tests working https://review.openstack.org/167604 | 14:22 |
*** zz_dimtruck is now known as dimtruck | 14:23 | |
alee | woodster_, jvrbanac , hockeynut , jaosorior, ^^ more reviews for cert api please. | 14:23 |
*** kfarr has joined #openstack-barbican | 14:48 | |
*** atiwari has quit IRC | 14:51 | |
*** xaeth_afk is now known as xaeth | 14:52 | |
*** kebray has joined #openstack-barbican | 14:58 | |
*** kebray has quit IRC | 15:07 | |
*** openstackgerrit has quit IRC | 15:08 | |
*** openstackgerrit has joined #openstack-barbican | 15:09 | |
alee | redrobot, jvrbanac https://review.openstack.org/#/c/166316/5 just needs a workflow please | 15:31 |
alee | jaosorior, hockeynut , jvrbanac - and after that one -- one of ya'll want to add workflow to https://review.openstack.org/#/c/166839/4 ? its got 3 +2s | 15:33 |
alee | jaosorior, hockeynut , jvrbanac , kfarr thanks for reviews. | 15:33 |
hockeynut | alee done | 15:33 |
jaosorior | hockeynut: you were too fast :P | 15:34 |
alee | thanks ya'll -- although we might need to quickly workflow https://review.openstack.org/#/c/166316/5 | 15:34 |
hockeynut | jaosorior <snicker> | 15:34 |
alee | coz the one that was workflowed depends on the former | 15:34 |
alee | maybe gerrit will be smart about it | 15:35 |
alee | redrobot, don't you owe me some workflows? | 15:35 |
*** kgriffs|afk is now known as kgriffs | 15:36 | |
redrobot | alee I do :( ... Looking at 166316 right now | 15:36 |
jaosorior | arunkant: hopefully will start reviewing the ACL stuff today (after climbing) | 15:37 |
alee | jaosorior, hockeynut , jvrbanac , redrobot , woodster_ don't forget https://review.openstack.org/#/c/167604/1 please | 15:38 |
jaosorior | alee: can you add me as a reviewer there? I'll read that after climbing. | 15:40 |
alee | jaosorior, will do thanks | 15:41 |
alee | looks like we have some workflows -- thanks redrobot | 15:41 |
alee | redrobot, don't stop now though - take a look at https://review.openstack.org/#/c/167604/1 :) | 15:41 |
arunkant | redrobot, just confirming that changes which are getting merged are still part of kilo..correct? Earlier, I have rebased per secret patches with latest master. | 15:42 |
redrobot | arunkant correct! the master branch is still tracking Kilo, and will continue to track Kilo until RC1 is tagged. At that point master will turn into Liberty and any release-critical bugs for Kilo will have to be fixed in a new branch off the RC1 tag. | 15:44 |
arunkant | jaosorior, thanks looking forward to review comments | 15:45 |
arunkant | redrobot, ok. | 15:45 |
*** dabukalam_ is now known as dabukalam | 15:52 | |
*** dabukalam has quit IRC | 15:52 | |
*** dabukalam has joined #openstack-barbican | 15:52 | |
openstackgerrit | Merged openstack/barbican: Fix CA related exceptions, and unskip relevant tests https://review.openstack.org/166316 | 16:04 |
openstackgerrit | Merged openstack/barbican: Fix some ca_id related bugs, add more functional test code https://review.openstack.org/166839 | 16:04 |
*** xaeth is now known as xaeth_afk | 16:14 | |
*** kebray has joined #openstack-barbican | 16:18 | |
*** chlong has quit IRC | 16:22 | |
*** kebray has quit IRC | 16:23 | |
*** jkf has joined #openstack-barbican | 16:26 | |
*** kebray has joined #openstack-barbican | 16:30 | |
*** kebray has quit IRC | 16:31 | |
*** kebray has joined #openstack-barbican | 16:31 | |
*** chlong has joined #openstack-barbican | 16:33 | |
*** chlong has quit IRC | 16:39 | |
*** gyee has joined #openstack-barbican | 16:49 | |
alee | woodster_, ping | 16:49 |
alee | woodster_, when you get a chance, lets discuss your retry/cert retry CRs. I'm reviewing them and trying them out, but I think we need to co-ordinate and discuss. | 16:54 |
alee | hey all - so if I'm looking at a series of CRs -- for example - https://review.openstack.org/#/c/167110/2 - how do I know the order in which to apply the updates? | 16:58 |
*** kebray has quit IRC | 17:05 | |
*** darrenmoffat has quit IRC | 17:14 | |
*** darrenmoffat has joined #openstack-barbican | 17:14 | |
*** kebray has joined #openstack-barbican | 17:25 | |
kfarr | alee, I usually look at the Dependencies section. You can tell which one is the first because it will be listed as dependent on a patch that is (MERGED) or (None) | 17:28 |
alee | kfarr, yeah - I remember siomething like that being around. | 17:31 |
alee | kfarr, I dont see it anymore though | 17:32 |
alee | kfarr, maybe my settings have changed | 17:32 |
kfarr | alee on mine, it's right below "Add Reviewer" button, above the list of all the patchsets | 17:34 |
kfarr | I don't know why yours would be different :( | 17:35 |
alee | kfarr, check your preferences -- you are using what is called "old screen" -- I was using "new screen" | 17:36 |
openstackgerrit | Arun Kant proposed openstack/barbican: For per secret ACL support, adding db model changes (Part 1) https://review.openstack.org/164334 | 17:36 |
openstackgerrit | Arun Kant proposed openstack/barbican: For per secret ACL support, adding db repository changes (Part 2) https://review.openstack.org/167712 | 17:37 |
alee | kfarr, when I switch to "old screen" , I see the dependencies | 17:37 |
kfarr | alee there's a new screen?!? | 17:37 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding Secret ACL controller layer changes (Part 3) https://review.openstack.org/164335 | 17:37 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding Container ACL controller layer changes (Part 4) https://review.openstack.org/165205 | 17:37 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding policy layer changes for ACL support (Part 5) https://review.openstack.org/165207 | 17:38 |
kfarr | Well, this is different. | 17:38 |
arunkant | For ACL changes, I have to split patch 1 into 2 as it has gone bigger. So now there are total 5 dependent patches. | 17:39 |
*** kebray has quit IRC | 17:40 | |
*** kebray has joined #openstack-barbican | 17:40 | |
alee | kfarr, looks like if you used "New screen" and set to disply changes in reverse order, then the related changes area lists them in order | 17:43 |
alee | kfarr, first one in chain at the bottom | 17:43 |
kfarr | alee, yes, I came to that conclusion, too | 17:43 |
alee | kfarr, yeah - wasn't obvious | 17:44 |
*** crc32 has joined #openstack-barbican | 18:03 | |
*** xaeth_afk is now known as xaeth | 18:10 | |
*** kfarr has quit IRC | 18:38 | |
*** kfarr has joined #openstack-barbican | 18:43 | |
*** tkelsey has quit IRC | 19:20 | |
*** dimtruck is now known as zz_dimtruck | 19:21 | |
*** alee is now known as alee_afk | 19:30 | |
openstackgerrit | John Vrbanac proposed openstack/barbican: Switching how we handle sessions in p11_crypto https://review.openstack.org/167749 | 19:35 |
*** zz_dimtruck is now known as dimtruck | 19:36 | |
woodster_ | alee, sorry, back for a bit between meetings | 19:50 |
*** tkelsey has joined #openstack-barbican | 20:09 | |
jvrbanac | reaperhulk, woodster_, redrobot, hockeynut, could y'all review and approve a fix to the p11 plugin? https://review.openstack.org/#/c/167749 | 20:10 |
*** tkelsey has quit IRC | 20:13 | |
*** xaeth is now known as xaeth_afk | 20:14 | |
woodster_ | jvrbanac, I asked a question on the CR just now... | 20:20 |
*** alee has joined #openstack-barbican | 20:23 | |
*** xaeth_afk is now known as xaeth | 20:24 | |
jvrbanac | woodster_, replied | 20:27 |
jvrbanac | woodster_, TL;DR: not right now | 20:28 |
redrobot | greghaynes hi! are you still going to try to land this https://review.openstack.org/#/c/140575/ for Kilo? | 20:30 |
*** gyee has quit IRC | 20:30 | |
greghaynes | redrobot: Hey. Sorry but I dont think I have time to mess with it (given recent HP changes) | 20:32 |
greghaynes | I can WIP it or abandon or somesuch? | 20:33 |
redrobot | greghaynes WIP would work. | 20:33 |
greghaynes | ok, done. ty for the ping | 20:33 |
greghaynes | ill leave a note on the review too | 20:33 |
redrobot | greghaynes awesome, thanks! | 20:35 |
alee | woodster_, redrobot hockeynut thanks for review and workflow! | 20:37 |
redrobot | alee 👍 | 20:39 |
hockeynut | we aim to please :-) | 20:39 |
alee | woodster_, I just workflowed your first retry patch | 20:40 |
redrobot | hockeynut that saying always reminds me of a sign at this bar I used to go to in college. It was in the restroom and it said "We aim to please, you aim too, please!" | 20:40 |
hockeynut | redrobot absolutely - we had the same sign! | 20:41 |
openstackgerrit | Merged openstack/barbican: Changes to get Dogtag related functional tests working https://review.openstack.org/167604 | 20:51 |
openstackgerrit | Merged openstack/barbican: Switching how we handle sessions in p11_crypto https://review.openstack.org/167749 | 20:53 |
*** xaeth is now known as xaeth_afk | 20:57 | |
openstackgerrit | Merged openstack/barbican: Add retry periodic task and worker-client logic https://review.openstack.org/164947 | 21:00 |
*** jaosorior has quit IRC | 21:02 | |
openstackgerrit | Charles Neill proposed openstack/barbican: Security tests for Consumer resources https://review.openstack.org/167018 | 21:14 |
*** alee has quit IRC | 21:41 | |
*** mdarby has joined #openstack-barbican | 21:43 | |
*** mdarby has quit IRC | 21:44 | |
*** xaeth_afk is now known as xaeth | 21:45 | |
openstackgerrit | Charles Neill proposed openstack/barbican: Security tests for Container resources https://review.openstack.org/164875 | 21:46 |
*** everjeje has quit IRC | 21:56 | |
openstackgerrit | Chelsea Winfree proposed openstack/barbican: Adding more detail to the secrets quickstart guide https://review.openstack.org/167029 | 22:00 |
*** xaeth is now known as xaeth_afk | 22:01 | |
*** jamielennox|away is now known as jamielennox | 22:08 | |
*** crc32 has quit IRC | 22:11 | |
arunkant | kfarr, ping | 22:18 |
kfarr | arunkant pong | 22:18 |
arunkant | kfarr, question on review comment https://review.openstack.org/#/c/164334/14 | 22:19 |
arunkant | kfarr, creator_id is not something which is provided as part of the incoming request data. Its derived from token's user. So does it still need to be added in validator? | 22:20 |
kfarr | Oh, I guess not, then. I misunderstood | 22:21 |
openstackgerrit | Chelsea Winfree proposed openstack/barbican: Completing secret reference documentation https://review.openstack.org/167820 | 22:22 |
arunkant | Actually the related change is in other patches..so hard to know from this patch. I will clarify in commit comment about this. Thanks for your review. | 22:22 |
*** paul_glass has quit IRC | 22:35 | |
*** kfarr has quit IRC | 22:37 | |
*** dimtruck is now known as zz_dimtruck | 22:38 | |
*** alee has joined #openstack-barbican | 22:41 | |
*** jkf has quit IRC | 22:41 | |
*** gyee has joined #openstack-barbican | 22:54 | |
*** chlong has joined #openstack-barbican | 23:10 | |
*** chlong has quit IRC | 23:37 | |
*** chlong has joined #openstack-barbican | 23:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!