*** kgriffs is now known as kgriffs|afk | 00:05 | |
*** david-lyle_afk has quit IRC | 00:34 | |
openstackgerrit | John Vrbanac proposed openstack/barbican: Replacing functional test authentication hookup https://review.openstack.org/163229 | 00:39 |
---|---|---|
openstackgerrit | Arun Kant proposed openstack/barbican: Adding per secret ACL support https://review.openstack.org/161620 | 01:01 |
*** zz_dimtruck is now known as dimtruck | 01:18 | |
*** crc32 has joined #openstack-barbican | 01:20 | |
*** crc32 has quit IRC | 01:20 | |
*** david-lyle_afk has joined #openstack-barbican | 01:21 | |
*** crc32 has joined #openstack-barbican | 01:22 | |
*** kebray has quit IRC | 01:28 | |
*** woodster_ has quit IRC | 02:00 | |
*** SheenaG1 has joined #openstack-barbican | 02:28 | |
*** david-lyle_afk has quit IRC | 02:36 | |
*** alee has quit IRC | 02:37 | |
*** kfarr has quit IRC | 02:40 | |
*** SheenaG1 has quit IRC | 02:46 | |
*** alee has joined #openstack-barbican | 02:50 | |
*** alee has quit IRC | 02:55 | |
*** alee has joined #openstack-barbican | 02:56 | |
*** kebray has joined #openstack-barbican | 02:58 | |
*** alee has quit IRC | 03:00 | |
*** alee has joined #openstack-barbican | 03:13 | |
*** david-lyle_afk has joined #openstack-barbican | 03:17 | |
*** alee has quit IRC | 03:22 | |
*** alee has joined #openstack-barbican | 03:23 | |
*** alee has quit IRC | 03:28 | |
*** alee has joined #openstack-barbican | 03:29 | |
*** alee has quit IRC | 03:34 | |
*** alee has joined #openstack-barbican | 03:46 | |
*** alee has quit IRC | 03:51 | |
*** alee has joined #openstack-barbican | 04:02 | |
*** alee has quit IRC | 04:07 | |
*** dimtruck is now known as zz_dimtruck | 04:10 | |
*** crc32 has quit IRC | 04:39 | |
*** alee has joined #openstack-barbican | 06:19 | |
*** kebray has quit IRC | 06:27 | |
*** rm_you has quit IRC | 06:41 | |
*** gitorres has joined #openstack-barbican | 06:46 | |
openstackgerrit | John Vrbanac proposed openstack/barbican: Replacing functional test authentication hookup https://review.openstack.org/163229 | 06:52 |
* jvrbanac crosses fingers | 06:53 | |
*** gitorres has quit IRC | 07:11 | |
*** gitorres has joined #openstack-barbican | 07:11 | |
openstackgerrit | John Vrbanac proposed openstack/barbican: Replacing functional test authentication hookup https://review.openstack.org/163229 | 07:39 |
* jvrbanac double crosses fingers | 07:40 | |
*** chlong has quit IRC | 08:01 | |
jvrbanac | w00t! | 08:03 |
*** gitorres has quit IRC | 08:08 | |
*** chlong has joined #openstack-barbican | 10:23 | |
*** gitorres has joined #openstack-barbican | 11:18 | |
*** darrenmoffat has quit IRC | 11:45 | |
*** darrenmoffat has joined #openstack-barbican | 11:46 | |
openstackgerrit | Merged openstack/python-barbicanclient: Fix when submitting with empty string, none and zero https://review.openstack.org/162751 | 11:48 |
*** dave-mccowan has joined #openstack-barbican | 12:40 | |
*** dave-mccowan has quit IRC | 13:06 | |
*** dave-mccowan has joined #openstack-barbican | 13:07 | |
*** rellerreller has joined #openstack-barbican | 13:13 | |
*** dave-mccowan has quit IRC | 13:20 | |
*** dave-mccowan has joined #openstack-barbican | 13:32 | |
*** rellerreller has quit IRC | 13:40 | |
*** SheenaG1 has joined #openstack-barbican | 13:47 | |
*** ametts has joined #openstack-barbican | 13:52 | |
*** SheenaG1 has quit IRC | 13:59 | |
*** dave-mccowan has quit IRC | 14:02 | |
*** dhellmann has joined #openstack-barbican | 14:39 | |
dhellmann | dougwig: are you still having trouble with tempest and oslo.log? | 14:39 |
*** jorge_munoz has joined #openstack-barbican | 14:42 | |
jvrbanac | redrobot, ^^ | 14:51 |
*** kebray has joined #openstack-barbican | 14:55 | |
*** paul_glass has joined #openstack-barbican | 14:58 | |
*** kebray has quit IRC | 15:01 | |
*** rellerreller has joined #openstack-barbican | 15:05 | |
*** SheenaG1 has joined #openstack-barbican | 15:06 | |
*** rellerreller has quit IRC | 15:11 | |
*** rellerreller has joined #openstack-barbican | 15:12 | |
rellerreller | jvrbanac | 15:12 |
rellerreller | jvrbanac What was the link to the test CR you had? | 15:13 |
*** kgriffs|afk is now known as kgriffs | 15:18 | |
openstackgerrit | Nathan Reller proposed openstack/barbican: Standardized Secret Encoding https://review.openstack.org/160444 | 15:22 |
*** rellerreller has quit IRC | 15:22 | |
*** rellerreller has joined #openstack-barbican | 15:22 | |
*** zz_dimtruck is now known as dimtruck | 15:24 | |
*** alee has quit IRC | 15:26 | |
*** david-lyle_afk is now known as david-lyle | 15:28 | |
openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: First set of negative functional test for secrets https://review.openstack.org/163156 | 15:30 |
redrobot | hi dhellmann! Yeah, we spent some time trying to figure out the right fix for the tempest/oslo issue, then decided to drop tempest in favor of tempest-lib and keystoneclient: https://review.openstack.org/#/c/162777/ | 15:33 |
*** igueths has joined #openstack-barbican | 15:47 | |
igueths | Hi all. | 16:03 |
*** tdink has quit IRC | 16:12 | |
*** kgriffs has quit IRC | 16:13 | |
*** jvrbanac has quit IRC | 16:13 | |
*** eglute has quit IRC | 16:13 | |
*** codekobe has quit IRC | 16:13 | |
*** briancurtin has quit IRC | 16:13 | |
*** chellygel has quit IRC | 16:14 | |
*** lbragstad has quit IRC | 16:14 | |
*** reaperhulk has quit IRC | 16:14 | |
*** jroll has quit IRC | 16:14 | |
*** russell_h has quit IRC | 16:14 | |
*** eglute has joined #openstack-barbican | 16:15 | |
*** kgriffs has joined #openstack-barbican | 16:15 | |
*** tdink has joined #openstack-barbican | 16:15 | |
*** jroll has joined #openstack-barbican | 16:15 | |
*** russell_h has joined #openstack-barbican | 16:15 | |
*** reaperhulk has joined #openstack-barbican | 16:15 | |
*** lbragstad has joined #openstack-barbican | 16:15 | |
*** russell_h has quit IRC | 16:15 | |
*** russell_h has joined #openstack-barbican | 16:15 | |
*** chellygel has joined #openstack-barbican | 16:15 | |
*** bdpayne has joined #openstack-barbican | 16:16 | |
*** jvrbanac has joined #openstack-barbican | 16:16 | |
*** jroll has quit IRC | 16:16 | |
*** jroll has joined #openstack-barbican | 16:16 | |
*** briancurtin has joined #openstack-barbican | 16:19 | |
*** codekobe has joined #openstack-barbican | 16:20 | |
rellerreller | jvrbanac Could you send me the link to your testing CR again? | 16:21 |
chellygel | rellerreller, do you mean the refactor work? | 16:33 |
chellygel | rellerreller, https://review.openstack.org/#/c/162441/ is for orders | 16:33 |
chellygel | rellerreller, https://review.openstack.org/#/c/162795/ is for secrets | 16:33 |
rellerreller | chellygel Perhaps. I'm not sure. jvrbanac said he was working on some ideas for refactoring the tests. | 16:34 |
rellerreller | chellygel It looks like the functional tests but running in unit tests. Is that the idea? | 16:37 |
chellygel | rellerreller, yes, using the mocks was not showing that other pieces were actually breaking other changes | 16:37 |
chellygel | rellerreller, the concept of doing the pieces in the chain on multiple levels rather than just only independent blocks. (if this doesnt sound too ambiguous) | 16:38 |
rellerreller | chellygel I found that out the hard way with content types. I have a 180 line patch but required 1100 loc because of all the testing. | 16:38 |
rellerreller | I would be in favor of these changes. Changing all of the mock stuff was quite a lot of work. | 16:40 |
chellygel | rellerreller, yeah -- its intense! But i had an extensive discussion with jvrbanac and reaperhulk over these things | 16:40 |
chellygel | rellerreller, yes indeed. this is going to cause more tests to fail when something breaks -- but it will be more explicit and obvious as to what you did wrong | 16:40 |
rellerreller | chellygel My only concern would be to reduce the duplicate code. It seems like the new code will be very similar to the functional tests. It would be nice to define the tests once and reuse for both. | 16:41 |
*** kebray has joined #openstack-barbican | 16:41 | |
chellygel | rellerreller, i think that may be a future step for sure. it was discussed | 16:41 |
chellygel | rellerreller, to use the functions outside of the app to replicate a real functional test, that sort of thing | 16:42 |
rellerreller | yes | 16:42 |
openstackgerrit | Merged openstack/barbican: Replacing functional test authentication hookup https://review.openstack.org/163229 | 16:46 |
openstackgerrit | Michael McCune proposed openstack/barbican: Moving containers tests to separate module https://review.openstack.org/162504 | 16:50 |
*** openstack has joined #openstack-barbican | 16:54 | |
*** jkf has joined #openstack-barbican | 16:54 | |
*** kebray has quit IRC | 17:06 | |
*** dimtruck is now known as zz_dimtruck | 17:14 | |
*** zz_dimtruck is now known as dimtruck | 17:17 | |
*** chlong has quit IRC | 17:21 | |
*** dimtruck is now known as zz_dimtruck | 17:27 | |
*** zz_dimtruck is now known as dimtruck | 17:40 | |
*** kfox1111 has joined #openstack-barbican | 17:41 | |
kfox1111 | Well, sounds like I may be able to get to the summit after all. :) | 17:45 |
kfox1111 | still a lot of paper work, but seems doable now. | 17:45 |
*** kebray has joined #openstack-barbican | 18:00 | |
*** woodster_ has joined #openstack-barbican | 18:07 | |
*** alee has joined #openstack-barbican | 18:08 | |
alee | redrobot, whats going on with the dogtag gate scripts? | 18:08 |
redrobot | alee so, I had to refactor into a separate script so we can sudo install_dogtag.sh | 18:09 |
redrobot | alee it works in a vagrant machine, but the gate seems to fail | 18:09 |
redrobot | alee https://review.openstack.org/#/c/161935/ | 18:09 |
redrobot | alee click through the gate failure there to see the logs | 18:09 |
redrobot | kfox1111 woot! | 18:09 |
*** gyee has joined #openstack-barbican | 18:17 | |
openstackgerrit | John Vrbanac proposed openstack/barbican: hide the eggs https://review.openstack.org/162741 | 18:23 |
alee | redrobot, any way we can get debug logs? | 18:24 |
openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Second set of negative secrets tests. https://review.openstack.org/163556 | 18:24 |
alee | redrobot, or log onto the machine and see what failed? | 18:24 |
*** dave-mccowan has joined #openstack-barbican | 18:24 | |
openstackgerrit | Chelsea Winfree proposed openstack/barbican: Split out and refactored more secret tests https://review.openstack.org/162795 | 18:24 |
alee | redrobot, it looks like the kra installation failed but without the debug log - its not clear why | 18:24 |
redrobot | alee the box gets destroyed after the run... we _might_ be able to ship out more logs, but we'll have to look into how the logs get shipped out. Or we can maybe recreate a gate vm in the cloud somewhere to see if it fails there too. | 18:25 |
redrobot | alee what's the log locations that we're interested in? | 18:26 |
alee | redrobot, we need to look at /var/log/pki/pki-tomcat | 18:26 |
alee | subdirectories under there | 18:26 |
alee | if we can tar up that directory - that would help | 18:27 |
alee | redrobot, if not a directory, then we need /var/log/pki/pki-tomcat/kra/debug | 18:28 |
redrobot | alee k, I'll see if I can get some time to look at that today. | 18:31 |
alee | redrobot, thanks | 18:31 |
rellerreller | Has anyone seen the devstack gate failing? I noticed that my CR failed those tests, but the functional tests all pass for me. | 18:38 |
rellerreller | ImportError: Failed to import test module: api.v1.functional.test_containers | 18:38 |
elmiko | rellerreller: mine failed earlier, but i just rebased and pushed again | 18:43 |
rellerreller | elmiko Thanks. I'm in the process of doing that now. I hope that works. | 18:44 |
elmiko | rellerreller: cool, looks like my review is still waiting for CI | 18:44 |
rellerreller | elmiko I ran the functional tests on my machine after rebasing and all of them failed there too. | 18:50 |
rellerreller | "keystoneclient.openstack.common.apiclient.exceptions.Unauthorized: Invalid username or password (Disable debug mode to suppress these details.) (HTTP 401)" | 18:50 |
elmiko | rellerreller: boo =( | 18:50 |
rellerreller | My rebase only had one commit to rebase onto. | 18:51 |
elmiko | is that with jvrbanac's update? | 18:51 |
rellerreller | commit 2a4fb02bb303c5a05e8a944705f21c15ffbb2bc2 | 18:51 |
rellerreller | elmiko Yes | 18:51 |
elmiko | huh... | 18:52 |
elmiko | seems like everyone's CI is blowing up | 18:52 |
rellerreller | Aargh! | 18:52 |
rellerreller | jvrbanac ping | 18:53 |
*** kebray has quit IRC | 18:58 | |
openstackgerrit | Steve Heyman proposed openstack/barbican: Refactor secrets functional tests for readability https://review.openstack.org/163564 | 19:02 |
*** paul_glass has quit IRC | 19:02 | |
rellerreller | hockeynut have you seen the CI errors? | 19:06 |
hockeynut | rellerreller there were issues that jvrbanac has fixed - do you have latest code? | 19:07 |
rellerreller | hockeynut yes, I rebased barbican and devstack | 19:09 |
*** paul_glass has joined #openstack-barbican | 19:10 | |
hockeynut | rellerreller what are you seeing now? | 19:14 |
rellerreller | hockeynut keystoneclient.openstack.common.apiclient.exceptions.Unauthorized: Invalid username or password (Disable debug mode to suppress these details.) (HTTP 401) | 19:15 |
hockeynut | running functional tests? | 19:15 |
rellerreller | hockeynut yes | 19:15 |
hockeynut | you need to look at the new conf file - etc/barbican/barbican-functional.conf | 19:15 |
rellerreller | I pulled the latest for devstack and updated extras.d/*barbican and lib/barbican | 19:15 |
hockeynut | it replaces etc/dev_tempest.conf | 19:15 |
rellerreller | OK, I think kfarr may know what this is | 19:16 |
rellerreller | I think we need to copy that file you just mentioned | 19:16 |
hockeynut | yep - that will become your best friend | 19:17 |
rellerreller | hockeynut So I cp etc/barbican/barbican-functional.conf to /etc/ or /etc/barbican/? Is there anything else I need to copy? | 19:21 |
hockeynut | rellerreller don't copy it anywhere - just update it like you used to do for etc/dev_tempest.conf. Its the replacement for etc/dev_tempest.conf | 19:21 |
hockeynut | when you look at it its *almost* the same as dev_tempest.conf used to be - but now a bit simpler | 19:22 |
rellerreller | hockeynut Thanks! I have it working now. | 19:23 |
hockeynut | awesome! | 19:24 |
rm_work | heads up, I think there's an issue with the newest sphinx==1.3 released yesterday and the latest pbr, if barbican's doc-reqs for sphinx aren't pinned to 1.2.3 it might break the doc gate | 19:33 |
rm_work | ^^ noticed this per octavia's docs job failing | 19:34 |
*** kebray has joined #openstack-barbican | 19:36 | |
*** rellerreller has quit IRC | 19:42 | |
*** kgriffs is now known as kgriffs|afk | 19:48 | |
alee | redrobot, jvrbanac any idea how to find out what the latest version of the db is -- ie.the latest version for alembic migrations? | 19:54 |
reaperhulk | alee: it's in an alembic version table I believe. | 19:55 |
alee | reaperhulk, thanks - let me look for that .. | 19:55 |
*** kgriffs|afk is now known as kgriffs | 20:02 | |
alee | redrobot, ping | 20:12 |
redrobot | alee pong ? | 20:13 |
alee | so I'm looking at the alembic migrations | 20:13 |
alee | I am putting together a patch for the ca related tables | 20:13 |
alee | which I had checked in earlier but had forgotten to provide alembic migrations for | 20:14 |
alee | so trying to get the right versioning | 20:14 |
alee | the latest version of the db is .. | 20:14 |
alee | 1c0f328bfce0 | 20:14 |
alee | which I would ordinarily take as the starting point for my alembic script | 20:15 |
alee | but -- | 20:15 |
alee | that particular migration adds a bunch of indexes | 20:15 |
alee | some of which are on the tables I am adding with my alembic migration | 20:16 |
alee | so really my alembic migration should go right before this one. | 20:17 |
redrobot | you can specify the uprevision and downrevision for any migration. You should be able to wedge it in before that particular version | 20:17 |
alee | yeah -- ok - just making sure that made sense to you | 20:18 |
redrobot | alee yeah, you can change http://git.openstack.org/cgit/openstack/barbican/tree/barbican/model/migration/alembic_migrations/versions/1c0f328bfce0_fixing_composite_primary_keys_and_.py#n11 to whatever the version you make is | 20:18 |
alee | not sure what monkeying around with the versions does to migrating existing dbs | 20:19 |
redrobot | alee on your new one set downrevision to 3d36a26b88af | 20:19 |
redrobot | alee I doubt we'll brake anyone... if anything, this latest one would have broken stuff since it's adding indexes to a non-existent table | 20:20 |
alee | yup -- and then upversion to X | 20:20 |
alee | and then use X for downversion on the "fixing .. indexes " one ? | 20:20 |
openstackgerrit | Steve Heyman proposed openstack/barbican: Remove extra v1 from override uri https://review.openstack.org/163595 | 20:21 |
redrobot | alee yep. Alembic builds the revision tree by following downversions before applying anything. | 20:23 |
woodster_ | I'm spotty for cell coverage but currently the db is started from scratch in the devstack gate...it syncs to sqlalchemy models directly. Grenade tests will eventually test migration scripts. | 20:24 |
alee | woodster_, so we wont break anyone just yet :) | 20:24 |
alee | or at least the gate wont complain about it yet | 20:25 |
alee | better get my changes in quick then .. | 20:25 |
woodster_ | Yeah...unfortunately:) | 20:25 |
*** igueths has quit IRC | 20:29 | |
*** igueths has joined #openstack-barbican | 20:37 | |
*** rellerreller has joined #openstack-barbican | 20:47 | |
*** SheenaG1 has quit IRC | 20:53 | |
openstackgerrit | Ade Lee proposed openstack/barbican: Add missing alembic migration script for CA tables https://review.openstack.org/163607 | 20:53 |
alee | redrobot, jvrbanac , hockeynut ^^ trivial one to review | 20:54 |
rellerreller | redrobot alee woodster_ I have updated the content types CR, https://review.openstack.org/#/c/160444/ Any feedback would be appreciated. I don't anticipate too many from this. | 20:55 |
*** kebray has quit IRC | 20:56 | |
alee | rellerreller, I'm finally back from my excursion to pointer land -- I'll get you feedback in the morning (I promise this time) | 20:56 |
rellerreller | alee Thanks! | 20:56 |
*** paul_glass has quit IRC | 21:01 | |
*** paul_glass has joined #openstack-barbican | 21:02 | |
openstackgerrit | Merged openstack/barbican: hide the eggs https://review.openstack.org/162741 | 21:13 |
openstackgerrit | Steve Heyman proposed openstack/barbican: Cleanup and renaming within secrets smoke tests https://review.openstack.org/163615 | 21:16 |
*** rellerreller has quit IRC | 21:17 | |
*** dimtruck is now known as zz_dimtruck | 21:19 | |
redrobot | tdink or hockeynut ping? | 21:36 |
*** igueths has quit IRC | 21:42 | |
*** zz_dimtruck is now known as dimtruck | 21:46 | |
*** dimtruck is now known as zz_dimtruck | 21:51 | |
*** zz_dimtruck is now known as dimtruck | 21:52 | |
openstackgerrit | Douglas Mendizábal proposed openstack/python-barbicanclient: Use functional_test.conf for devstack gate https://review.openstack.org/161466 | 21:56 |
*** paul_glass has quit IRC | 21:59 | |
openstackgerrit | Paul Kehrer proposed openstack/barbican: check some responses in functional tests before using the resp https://review.openstack.org/163628 | 22:09 |
openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Standardized Secret Encoding https://review.openstack.org/160444 | 22:16 |
openstackgerrit | Douglas Mendizábal proposed openstack/barbican: Test functionality of generated asymmetric keys https://review.openstack.org/162425 | 22:16 |
*** movielovers has joined #openstack-barbican | 22:24 | |
*** movielovers has left #openstack-barbican | 22:25 | |
*** jorge_munoz has quit IRC | 22:27 | |
openstackgerrit | Steve Heyman proposed openstack/barbican: Refactor secrets functional tests for readability https://review.openstack.org/163564 | 22:36 |
openstackgerrit | John Vrbanac proposed openstack/barbican: Making the tox -e functional tests run faster https://review.openstack.org/163635 | 22:40 |
openstackgerrit | Douglas Mendizábal proposed openstack/python-barbicanclient: Deprecate setting the payload type and encoding https://review.openstack.org/162777 | 22:46 |
openstackgerrit | Paul Kehrer proposed openstack/barbican: Fix create orders functional tests for asynchronous order processing https://review.openstack.org/163638 | 23:04 |
*** dave-mccowan has quit IRC | 23:14 | |
openstackgerrit | Paul Kehrer proposed openstack/barbican: check some responses in functional tests before using the resp https://review.openstack.org/163628 | 23:19 |
*** woodster_ has quit IRC | 23:20 | |
openstackgerrit | Paul Kehrer proposed openstack/barbican: check some responses in functional tests before using the resp https://review.openstack.org/163628 | 23:24 |
openstackgerrit | Arun Kant proposed openstack/barbican: Adding per secret ACL support https://review.openstack.org/161620 | 23:38 |
*** chlong has joined #openstack-barbican | 23:42 | |
*** jkf has quit IRC | 23:42 | |
arunkant | alee, as FYI..per secret is ready for review. https://review.openstack.org/#/c/161620/ | 23:46 |
*** rm_you has joined #openstack-barbican | 23:48 | |
*** rm_you has quit IRC | 23:48 | |
*** rm_you has joined #openstack-barbican | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!