| *** dimtruck is now known as zz_dimtruck | 00:58 | |
| hockeynut | woodster_ for https://review.openstack.org/#/c/159991/ would you be interested in changing your +2 to a workflow? | 02:56 |
|---|---|---|
| hockeynut | woodster_ also see comments added to https://review.openstack.org/#/c/160016/ | 02:57 |
| woodster_ | Ha, done | 02:59 |
| woodster_ | hockeynut, that makes sense, changed to +2 | 03:01 |
| reaperhulk | For those who've been waiting, RSA private key serialization landed in cryptography this morning after 167 comments, several months, and at least 3 major changes to the API proposal :) https://github.com/pyca/cryptography/pull/1503 | 03:02 |
| reaperhulk | EC, DSA, and public key work is frantically being written now so I can get 0.8 out the door this upcoming week :p | 03:03 |
| hockeynut | thx woodster_ ! | 03:29 |
| mjg59 | \o/ | 03:38 |
| *** nkinder has joined #openstack-barbican | 03:38 | |
| woodster_ | reaperhulk, that's good news! | 03:38 |
| *** dave-mccowan has quit IRC | 03:50 | |
| *** david-lyle_afk has quit IRC | 04:02 | |
| openstackgerrit | Merged openstack/python-barbicanclient: Update functionaltests to be able to run tox -e functional https://review.openstack.org/159991 | 04:04 |
| *** kebray has joined #openstack-barbican | 05:01 | |
| *** kebray has quit IRC | 05:03 | |
| *** kebray has joined #openstack-barbican | 05:07 | |
| *** kebray_ has joined #openstack-barbican | 06:27 | |
| *** kebray has quit IRC | 06:29 | |
| *** kebray_ has quit IRC | 06:59 | |
| *** jaosorior has joined #openstack-barbican | 07:31 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Use urljoin instead of os.path.join https://review.openstack.org/160250 | 07:48 |
| *** woodster_ has quit IRC | 07:50 | |
| *** chlong has quit IRC | 08:02 | |
| *** Guest78669 is now known as d0ugal | 08:20 | |
| *** d0ugal has joined #openstack-barbican | 08:21 | |
| *** tkelsey has joined #openstack-barbican | 09:05 | |
| *** darrenmoffat has quit IRC | 10:07 | |
| *** darrenmoffat has joined #openstack-barbican | 10:08 | |
| *** dave-mccowan has joined #openstack-barbican | 12:21 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Get rid of Repositories class https://review.openstack.org/160329 | 12:52 |
| *** woodster_ has joined #openstack-barbican | 12:59 | |
| jaosorior | woodster_: are you around? | 13:58 |
| woodster_ | jaosorior: heading to gym shortly but can IRC by phone | 13:59 |
| jaosorior | oh, alright | 13:59 |
| jaosorior | I'm just getting a weird error in the functional tests | 13:59 |
| jaosorior | something about get_auth_provider not being in the Manager class | 13:59 |
| jaosorior | http://logs.openstack.org/29/160329/1/check/gate-barbican-devstack-dsvm/56efcd4/console.html | 14:00 |
| woodster_ | jaosorior Hmm there was a commit to the functional tests last night | 14:04 |
| jaosorior | ok, let me pull it | 14:04 |
| woodster_ | jaosorior: or maybe that is a Barbican client test, so a recent change to client? | 14:05 |
| jaosorior | nope, I have already pulled the latewst | 14:05 |
| *** SheenaG1 has quit IRC | 14:05 | |
| *** lisaclark1 has joined #openstack-barbican | 14:17 | |
| *** nkinder has quit IRC | 14:19 | |
| woodster_ | jaosorior: I think those latest changes might be borking things somehow? | 14:19 |
| dave-mccowan | jaosorior: are you using override_url in the config file? i made a change to split the override url into two parts (base and version). make sure your local changes didn't overwrite that. override_url=http://localhost:9311 | 14:29 |
| dave-mccowan | override_url_version=v1 | 14:29 |
| jaosorior | dave-moccowan: that commit doesn't touch the configuration :/ | 14:30 |
| jaosorior | I didn't touch a single file in functionaltests/ | 14:34 |
| *** lisaclark1 has quit IRC | 14:41 | |
| *** lisaclark1 has joined #openstack-barbican | 14:42 | |
| jaosorior | dave-mccowan: as a matter of fact, it seems that the version is not being included somehow | 14:48 |
| jaosorior | I see a similar problem in two different commits | 14:48 |
| *** SheenaG1 has joined #openstack-barbican | 14:56 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Use urljoin instead of os.path.join https://review.openstack.org/160250 | 15:03 |
| *** rm_work has quit IRC | 15:05 | |
| *** rm_work|away has joined #openstack-barbican | 15:07 | |
| *** rm_work|away is now known as rm_work | 15:07 | |
| *** rm_work has quit IRC | 15:07 | |
| *** rm_work has joined #openstack-barbican | 15:07 | |
| *** rm_work has quit IRC | 15:12 | |
| *** nkinder has joined #openstack-barbican | 15:13 | |
| *** kfarr has joined #openstack-barbican | 15:14 | |
| *** rm_work|away has joined #openstack-barbican | 15:15 | |
| *** rm_work|away is now known as rm_work | 15:15 | |
| *** rm_work has joined #openstack-barbican | 15:15 | |
| *** paul_glass has joined #openstack-barbican | 15:17 | |
| jaosorior | dave-mccowan: seems your commit did not pass the gate because of the same issue: http://logs.openstack.org/72/160172/1/gate/gate-barbican-devstack-dsvm/eeaf39f/console.html | 15:17 |
| jaosorior | trying to debug it | 15:18 |
| *** ametts has joined #openstack-barbican | 15:22 | |
| *** lisaclark1 has quit IRC | 15:22 | |
| *** lisaclark1 has joined #openstack-barbican | 15:27 | |
| *** lisaclark1 has quit IRC | 15:28 | |
| *** xaeth_afk is now known as xaeth | 15:36 | |
| *** zz_dimtruck is now known as dimtruck | 15:38 | |
| *** jorge_munoz has joined #openstack-barbican | 15:46 | |
| *** paul_glass has quit IRC | 15:47 | |
| *** lisaclark1 has joined #openstack-barbican | 16:02 | |
| *** dave-mccowan has quit IRC | 16:08 | |
| woodster_ | hockeynut: have you seen the issue above before? | 16:08 |
| *** kfox1111 has joined #openstack-barbican | 16:21 | |
| jvrbanac | woodster_, jaosorior, I'm guessing something changed with tempest | 16:22 |
| jaosorior | jvrbanac: would appear so, since it's a client coming from it | 16:23 |
| jaosorior | Didn't get to figure out what it was since ib had to catch a train | 16:23 |
| *** lisaclark1 has quit IRC | 16:27 | |
| *** dave-mccowan has joined #openstack-barbican | 16:28 | |
| *** lisaclark1 has joined #openstack-barbican | 16:28 | |
| *** gyee has joined #openstack-barbican | 16:42 | |
| *** paul_glass has joined #openstack-barbican | 16:50 | |
| *** lisaclark1 has quit IRC | 16:53 | |
| *** lisaclark1 has joined #openstack-barbican | 16:57 | |
| *** bdpayne has joined #openstack-barbican | 17:04 | |
| *** arunkant has joined #openstack-barbican | 17:12 | |
| *** rellerreller has joined #openstack-barbican | 17:20 | |
| *** kebray has joined #openstack-barbican | 17:23 | |
| *** lisaclark1 has quit IRC | 17:34 | |
| *** lisaclark1 has joined #openstack-barbican | 17:38 | |
| openstackgerrit | Arun Kant proposed openstack/barbican-specs: Spec for adding audit capability using CADF specification. https://review.openstack.org/159938 | 17:56 |
| *** kebray has quit IRC | 17:59 | |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Adds positive orders functional tests https://review.openstack.org/158454 | 18:00 |
| *** lisaclark1 has quit IRC | 18:00 | |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Adds positive orders functional tests https://review.openstack.org/158454 | 18:01 |
| *** jkf has joined #openstack-barbican | 18:04 | |
| *** kebray has joined #openstack-barbican | 18:04 | |
| *** igueths has joined #openstack-barbican | 18:16 | |
| igueths | Hello. | 18:16 |
| openstackgerrit | greghaynes proposed openstack/barbican: Create snakeoil certificate plugin https://review.openstack.org/140575 | 18:22 |
| openstackgerrit | Nathan Reller proposed openstack/barbican: Fixed Binary Encoding to Secret Stores https://review.openstack.org/157410 | 18:22 |
| openstackgerrit | Nathan Reller proposed openstack/barbican: Standardized Secret Encoding https://review.openstack.org/160444 | 18:22 |
| openstackgerrit | Nathan Reller proposed openstack/barbican-specs: Add Asymmetric Key Support to KMIPSecretStore https://review.openstack.org/160449 | 18:30 |
| arunkant | woodster_, Have question on Line 167 comment of https://review.openstack.org/#/c/159938/2/specs/kilo/audit-cadf-events.rst,cm . Please ping me when you have time | 18:42 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: Fix functional tests to use new auth provider interface https://review.openstack.org/160455 | 18:45 |
| jvrbanac | redrobot, ^^ | 18:45 |
| jaosorior | jvrbanac, woodster_: Found the cause of the error. | 18:47 |
| redrobot | jaosorior nice | 18:48 |
| jvrbanac | jaosorior, I'll +2 that sucker as soon as the gates pass | 18:48 |
| woodster_ | jaosorior, nice! just +2-ed it. jvrbanac had it right...dern > signs in requirements.txt :) | 18:48 |
| *** kebray has quit IRC | 18:49 | |
| jvrbanac | woodster_, requirements? | 18:49 |
| jaosorior | too bad it's gonna take a long time since there's a huge queue on the gate | 18:49 |
| jaosorior | but oh well | 18:49 |
| woodster_ | jvrbanac, well test-requirements.txt | 18:49 |
| jvrbanac | woodster_, It's not in test-requirements https://github.com/cloudkeep/barbican/blob/master/tox.ini#L51 | 18:50 |
| jvrbanac | woodster_, woops wrong link | 18:50 |
| jvrbanac | woodster_, however, I believe the devstack setup does the same thing | 18:50 |
| jaosorior | jvrbanac: indeed it isn't | 18:50 |
| *** kfarr has quit IRC | 18:50 | |
| woodster_ | jvrbanac, ah, direct to master, I didn't realize that | 18:51 |
| jaosorior | anyway, it seems the commit has been in for 5 days, and we hadn't had a problem: https://github.com/openstack/tempest/commit/90012355b4ea24a7321f66b329b543f306d2cefe | 18:51 |
| jvrbanac | woodster_, interesting | 18:52 |
| jaosorior | aaah no, authored 5 days ago | 18:52 |
| jaosorior | dunno when it was merged | 18:52 |
| jvrbanac | jaosorior, interesting | 18:52 |
| jvrbanac | https://review.openstack.org/#/c/159267/ | 18:52 |
| jaosorior | I see, merged today | 18:52 |
| woodster_ | seems like a significant change to make in between releases | 18:52 |
| woodster_ | might be other projects affected by that one | 18:53 |
| jaosorior | yeah, that's what I was thinking | 18:54 |
| *** crc32 has joined #openstack-barbican | 18:55 | |
| jvrbanac | jaosorior, woodster_, probably only incubated projects that wrote some functional tests that use some tempest stuff | 18:55 |
| jaosorior | jvrbanac: So... did we do this the wrong way? | 18:55 |
| woodster_ | The plan is to move away from project things being in the tempest repository...so the call back hook sort of approach we use is where things are going, if that's what you mean | 18:57 |
| redrobot | jaosorior most projects keep their functional tests in the Tempest tree, so they probably were not affected. | 18:58 |
| openstackgerrit | Kevin Fox proposed openstack/barbican: VM Integration https://review.openstack.org/159573 | 19:00 |
| *** rellerreller has quit IRC | 19:02 | |
| jaosorior | OK, that makes sense | 19:02 |
| *** crc32 has quit IRC | 19:03 | |
| *** rellerreller has joined #openstack-barbican | 19:04 | |
| *** kfox1111 has quit IRC | 19:09 | |
| *** kfox1111 has joined #openstack-barbican | 19:12 | |
| *** crc32 has joined #openstack-barbican | 19:12 | |
| kfox1111 | https://review.openstack.org/#/c/159571/ <- I can't seem to figure out how to mark shell/json in the .rst file in a way it will like. any ideas? | 19:22 |
| woodster_ | kfox1111, check out https://review.openstack.org/#/c/127353/5/specs/kilo/add-creator-only-option.rst,cm line 104...that double colon and the json indention and line spaces thereafetr | 19:28 |
| woodster_ | kfox1111, the result is rendered here: http://specs.openstack.org/openstack/barbican-specs/specs/kilo/add-creator-only-option.html | 19:28 |
| *** shakamunyi has joined #openstack-barbican | 19:32 | |
| *** dimtruck is now known as zz_dimtruck | 19:32 | |
| kfox1111 | yeah. thats what I was trying to do. thanks. :) | 19:32 |
| kfox1111 | oh. so they don't support the types for making it pretty. ok. | 19:33 |
| *** tkelsey has quit IRC | 19:33 | |
| openstackgerrit | Kevin Fox proposed openstack/barbican-specs: Spec for vm-integration https://review.openstack.org/159571 | 19:35 |
| *** kfox1111 has quit IRC | 19:36 | |
| *** kfox1111 has joined #openstack-barbican | 19:36 | |
| kfox1111 | arg... its anoying I have to switch networks to commit at work. :/ | 19:37 |
| jvrbanac | kfox1111, if you noticed, I WIP'ed your CR. I want to make sure people give their feedback and review your spec first, so you're not making tons of random changes on something that can't be merged yet. Might as well, get people looking at your spec instead. :) | 19:39 |
| kfox1111 | thats fine. | 19:39 |
| kfox1111 | I usually figure, that the bikeshedding of the code takes... a while.... so I usually do it in parallel just to speed it up. ;) | 19:40 |
| kfox1111 | but have gotten good feedback on this one. :) | 19:40 |
| jvrbanac | :) | 19:41 |
| *** lisaclark1 has joined #openstack-barbican | 19:42 | |
| woodster_ | arunkant, I noticed your IRC above there | 19:45 |
| *** lisaclark1 has quit IRC | 19:46 | |
| arunkant | woodster_, Pinged you to understand the concern in Line 167 of cadf audit spec: https://review.openstack.org/#/c/159938/2/specs/kilo/audit-cadf-events.rst,cm | 19:48 |
| reaperhulk | look, a meeting invite from redrobot | 19:48 |
| woodster_ | arunkant, I was concerned that we would have to wait for CRs to pyCADF before we could implement events in Barbican. | 19:48 |
| arunkant | woodster_, I have uploaded new patch to address the others comments | 19:48 |
| reaperhulk | now we know he opened his calendar | 19:48 |
| *** kgriffs|afk is now known as kgriffs | 19:50 | |
| arunkant | woodster, Yes...Its a simple change in pycadf..already reached out to stevemar (steve from IBM) . Can work on it quickly..once there is agreement on barbican resource type names | 19:51 |
| *** zz_dimtruck is now known as dimtruck | 19:51 | |
| arunkant | woodster, Also highlighted the change in patch 3 ..what needs to be changed. | 19:52 |
| arunkant | woodster_, ^^^ | 19:52 |
| redrobot | reaperhulk dafuq? I swear I haven't touched my calendar today... | 19:55 |
| *** crc32 has quit IRC | 19:56 | |
| reaperhulk | Calendar knows what you want though http://cl.ly/a1Cx | 19:57 |
| rm_work | lol | 19:57 |
| *** kfarr has joined #openstack-barbican | 20:00 | |
| *** rellerreller has quit IRC | 20:01 | |
| woodster_ | arunkant, so if we need to add events later (I'm thinking of the certificate workflow events for example) that should be fairly simple to add to the pyCADF side then? If so, we could get rid of our certificate event plugin stuff (https://github.com/openstack/barbican/blob/master/barbican/plugin/interface/certificate_manager.py#L171) | 20:01 |
| redrobot | weekly meeting is starting now in #openstack-meeting-alt | 20:01 |
| kfox1111 | oh really? | 20:04 |
| kfox1111 | the timifier thingy told me 1:00 last week. :/ | 20:04 |
| arunkant | woodster_, Is not purpose (and may be data sent) of certificate event plugin is different than audit? Are you thinking of using CADF event structure for them? | 20:05 |
| woodster_ | arunkant, we certainly could, but that's what I'm curious about | 20:05 |
| arunkant | woodster_, I am not too aware what is the usage of certificate event plugin..but it seems limited to certificate aspect only. | 20:08 |
| *** rm_you has quit IRC | 20:08 | |
| woodster_ | arunkant, the main purpose is to surface cert events that can be used to drive customer ticketing/tracking processes around those | 20:09 |
| woodster_ | arunkant, so it seems pyCADF could be used for that same purpose | 20:13 |
| *** lisaclark1 has joined #openstack-barbican | 20:13 | |
| woodster_ | arunkant, since it sends events to queues. We can just have a specialized consumer dealing with tracking | 20:14 |
| arunkant | woodster_, yes. pyCADF allows extension..so whatever additional is needed..can be captured as part of audit event | 20:14 |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Fixes launchpad bug 1420868 https://review.openstack.org/160490 | 20:34 |
| openstack | Launchpad bug 1420868 in python-barbicanclient "functional tests - remove datadriven tests from smoke tests" [Medium,Confirmed] https://launchpad.net/bugs/1420868 - Assigned to Thomas Dinkjian (thomas-dinkjian) | 20:34 |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Closes-Bug: #1420868 https://review.openstack.org/160490 | 20:39 |
| openstack | bug 1420868 in python-barbicanclient "functional tests - remove datadriven tests from smoke tests" [Medium,Confirmed] https://launchpad.net/bugs/1420868 - Assigned to Thomas Dinkjian (thomas-dinkjian) | 20:39 |
| *** igueths has quit IRC | 20:43 | |
| *** igueths has joined #openstack-barbican | 20:46 | |
| *** lisaclark1 has quit IRC | 20:48 | |
| *** kfarr has quit IRC | 21:02 | |
| *** lisaclark1 has joined #openstack-barbican | 21:07 | |
| *** shakamunyi has quit IRC | 21:07 | |
| *** shakamunyi has joined #openstack-barbican | 21:08 | |
| *** rm_work is now known as rm_work|away | 21:14 | |
| *** rm_work|away is now known as rm_work | 21:23 | |
| *** chlong has joined #openstack-barbican | 21:24 | |
| *** igueths has quit IRC | 21:33 | |
| *** igueths has joined #openstack-barbican | 21:41 | |
| *** dave-mccowan has quit IRC | 21:47 | |
| *** chlong has quit IRC | 21:51 | |
| *** shakamunyi_ has joined #openstack-barbican | 21:53 | |
| *** shakamunyi has quit IRC | 21:54 | |
| woodster_ | jvrbanac, I'm back now | 21:58 |
| *** nkinder has quit IRC | 22:01 | |
| *** lisaclark1 has quit IRC | 22:01 | |
| *** jaosorior has quit IRC | 22:02 | |
| *** dave-mccowan has joined #openstack-barbican | 22:04 | |
| jvrbanac | woodster_, sooo I figured out the problem with the workers processing orders | 22:06 |
| jvrbanac | woodster_, we have a race condition in the order saving process. | 22:06 |
| woodster_ | jvrbanac between worker and api nodes, or within the worker itself? | 22:07 |
| jvrbanac | Essentially, we're relying on the transaction hook to do the db commit, but we push to the queue prior to that | 22:07 |
| jvrbanac | woodster_, The problem is actually with the API node | 22:07 |
| woodster_ | jvrbanac, oh that makes sense! So the api trans is not completed before the worker picks it up then? | 22:08 |
| jvrbanac | woodster_, yeah | 22:08 |
| jvrbanac | woodster_, I was wondering about the history around the transaction hook. Do you remember why we started using it? | 22:08 |
| woodster_ | jvrbanac, well we weren't really managing the sqlalchemy transactions before, and noticed that (or ryanpetrello mentioned) that Pecan had transaction lifecycle support keyed to the requests. | 22:10 |
| woodster_ | jvrbanac, I believe that is the correct way to handle transactions but our async behaviors are not synced to that :\ | 22:11 |
| *** igueths has quit IRC | 22:11 | |
| woodster_ | jvrbanac, so it seems we need to defer sending to the queue until the transaction commits...I wonder if there is a way to register a transaction call back with sqlalchemy to make that happen at the right time? | 22:12 |
| jvrbanac | woodster_, is that the right answer though? That feels like we're working around an issue rather than building the right solution | 22:13 |
| woodster_ | jvrbanac, well I think it is clean for the container (Pecan) to manage our transactions, rather than the app/controllers to have to manage that themselves | 22:14 |
| woodster_ | jvrbanac, it would be good to know how this is solved in other projects for sure | 22:17 |
| jvrbanac | woodster_, Yeah. Hmmm... I don't know. we're having to manually commit and rollback anyhow in quite a few cases. It feels like it would be cleaner to specify db behavior (which is kind of what the repositories are) and manage the transactions from there | 22:19 |
| woodster_ | jvrbanac, the issue is that repositories are at a lower level of abstraction...almost one to one to models. The transactions need to span the controller/orchestration calls though. The @transaction decorator could work at this level, but there are some cases where one controller calls another controller's methods so then transaction nesting semantics become | 22:22 |
| woodster_ | an issue. | 22:22 |
| woodster_ | jvrbanac, not a show stopper, but just a bit more to manage | 22:22 |
| woodster_ | jvrbanac, so a call in the middle of orchestration that enqueues something, but under the hood defer that until after the db transaction commits, would keep the current orchestration in the controllers programmatically straightforward | 22:24 |
| jvrbanac | woodster_, am I the only person that gets the Heebie-jeebies when code actually doesn't execute when you tell it to? | 22:26 |
| woodster_ | jvrbanac, none of those repository/sqlalchemy calls actually does anything until you commit() ;) | 22:27 |
| jvrbanac | woodster_, that's a little different as you're building state to make a single call. However, I'm not a big fan of that either. | 22:28 |
| *** SheenaG1 has quit IRC | 22:31 | |
| jvrbanac | woodster_, however, that atleast has a very explicit beginning and end. We're talking about deferring something so that it executes at a different time than specified in the code. | 22:34 |
| jvrbanac | woodster_, unless i'm misunderstanding | 22:35 |
| woodster_ | jvrbanac, the code run in the controllers is not actually affecting the database until Pecan's commit phase runs, after that code is executed. So it is still deferred steps in the orchestration. I would grant you that the queue step is not really sequential to the other steps in the controller though | 22:36 |
| woodster_ | jvrbanac, if the alternative is try/except blocks though, or sub-methods with trans decorators called from other methods, I'd say you are not helping the cause :) | 22:40 |
| jvrbanac | Sooo I'm thinking this whole thing is a little misunderstood. I've been in this section of the code a bit over the past few days and I'm still trying to figure out what this stuff is actually doing and when. Perhaps it's just my ignorance, but I think there is some value in taking a look at making it more explicit. | 22:47 |
| woodster_ | jvrbanac, this all might be moot though if there isn't a clean way to defer the queuing until after the transaction commit. This looks ugly: http://docs.sqlalchemy.org/en/latest/orm/events.html#sqlalchemy.orm.events.SessionEvents.after_transaction_end | 22:48 |
| *** xaeth is now known as xaeth_afk | 22:50 | |
| * kfox1111 doesn't like meeting day. :/ | 22:50 | |
| jvrbanac | woodster_, I don't think we could use that anyhow as we don't actually have the session context at that the point we branch to the queue | 22:51 |
| jvrbanac | woodster_, https://github.com/openstack/barbican/blob/master/barbican/api/controllers/orders.py#L199 | 22:52 |
| woodster_ | jvrbanac, well, it is available via the get_session() call (it will return the thread's session). So we *could* (not necessarily want to) put that line #199 code in a call back function, that is registered with the session's transaction end event. | 22:54 |
| * jvrbanac shivers | 22:55 | |
| woodster_ | jvrbanac, another option for line #199 to defer the actual queue call, and then have the Pecan lifecycle commit call (https://github.com/openstack/barbican/blob/master/barbican/model/repositories.py#L129) make a call to self.queue.flush() or some such to actually enqueue the RPC call | 22:56 |
| woodster_ | jvrbanac so the current controller code would not change, bug the self.queue.process_xxxx() implementations would | 22:57 |
| jvrbanac | woodster_, hmmm... I think I just need to sit down and map out some of these workflows and think about it some. | 22:57 |
| woodster_ | jvrbanac, yeah. The functional sequence I think we need though is https://github.com/openstack/barbican/blob/master/barbican/model/repositories.py#L134 followed by enqueuing any RPC calls needed | 22:58 |
| woodster_ | jvrbanac, how did you notice this though, once you pushed a lot of data through? Is that why you were seeing those rollbacks in newrelic? | 23:00 |
| jvrbanac | woodster_, it's quite easy to replicate right now in a full Barbican setup. I noticed it when I had added more logging with the newrelic CR | 23:01 |
| jvrbanac | woodster_, I'll add a patch to fix the issue for now, but I want to sit down and think about this a bit. Try to find a "less dirty" feeling solution lol | 23:02 |
| jvrbanac | s/Try/I want to try/ | 23:02 |
| woodster_ | jvrbanac, so are you fixing by making these calls explicit (or at least the order POST one)? | 23:03 |
| woodster_ | jvrbanac, or just making a commit() call before the queue call? | 23:03 |
| jvrbanac | woodster_, I'm just gonna force a commit on the order save. nothing more. | 23:04 |
| jvrbanac | woodster_, It'll fix the problem for now, but I would like to explore some more longer time solutions | 23:04 |
| woodster_ | jvrbanac, that might not be horrible way to handle this...it is explicit, and if that db write fails, you wouldn't want to do the queue or response logic anyway | 23:05 |
| woodster_ | jvrbanac, for sure | 23:05 |
| *** kebray has joined #openstack-barbican | 23:05 | |
| jvrbanac | woodster_, might thought exactly | 23:05 |
| *** igueths has joined #openstack-barbican | 23:05 | |
| *** nkinder has joined #openstack-barbican | 23:05 | |
| woodster_ | jvrbanac, and it doesn't require tearing up a bunch of code out there :) | 23:06 |
| *** shakamunyi_ has quit IRC | 23:06 | |
| jvrbanac | woodster_, yeah... this would add 1 line lol | 23:06 |
| *** kfox1111 has quit IRC | 23:10 | |
| *** kebray has quit IRC | 23:12 | |
| *** kebray has joined #openstack-barbican | 23:15 | |
| *** dimtruck is now known as zz_dimtruck | 23:18 | |
| elmiko | hey, i'm having trouble finding some information about barbican in the cloud | 23:20 |
| elmiko | does it register service/endpoints in keystone? | 23:20 |
| elmiko | or, i should say, do they need to be registered? | 23:20 |
| elmiko | think i might have found it... | 23:22 |
| *** kebray has quit IRC | 23:23 | |
| *** rm_work is now known as rm_work|away | 23:24 | |
| igueths | elmiko: Did you find what you were looking for? | 23:29 |
| elmiko | igueths: yea, was trying to figure out the service name. it eluded me, but only for a short while =) | 23:31 |
| *** jorge_munoz has quit IRC | 23:32 | |
| igueths | elmiko: Ah...Cool that you figured it out. | 23:32 |
| elmiko | igueths: might be something to add for the installation docs | 23:33 |
| *** chlong has joined #openstack-barbican | 23:33 | |
| elmiko | or maybe i just missed it in there | 23:34 |
| *** openstackgerrit has quit IRC | 23:38 | |
| *** rm_work|away is now known as rm_work | 23:38 | |
| *** openstackgerrit has joined #openstack-barbican | 23:39 | |
| *** paul_glass has quit IRC | 23:40 | |
| *** kgriffs is now known as kgriffs|afk | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!