Tuesday, 2014-08-19

« Monday, 2014-08-18 Index Wednesday, 2014-08-20 »
*** AndChat|173801 has joined #openstack-barbican00:21
*** kaitlin-farr has quit IRC00:22
*** kaitlin-farr has joined #openstack-barbican00:22
*** AndChat-173801 has joined #openstack-barbican00:25
*** kaitlin-farr has quit IRC00:25
*** AndChat|173801 has quit IRC00:25
*** kaitlin-farr has joined #openstack-barbican00:26
*** AndChat-173801 has quit IRC00:29
*** crc32 has quit IRC00:40
*** ayoung has quit IRC00:49
*** ayoung has joined #openstack-barbican00:49
*** kaitlin-farr has quit IRC00:55
*** uberj has quit IRC01:15
*** kebray has joined #openstack-barbican01:28
*** kebray has quit IRC02:11
*** kebray has joined #openstack-barbican02:12
*** kebray_ has joined #openstack-barbican02:34
*** kebray has quit IRC02:36
*** kebray_ has quit IRC02:36
*** woodster_ has quit IRC02:45
*** bdpayne has joined #openstack-barbican03:03
*** bdpayne has quit IRC03:17
*** bdpayne has joined #openstack-barbican03:30
*** gyee_ has quit IRC03:32
*** bdpayne has quit IRC03:41
*** juantwo_ has joined #openstack-barbican03:44
*** juantwo has quit IRC03:48
*** juantwo_ has quit IRC03:56
*** juantwo has joined #openstack-barbican03:57
*** xianghuihui has quit IRC04:03
*** xianghuihui has joined #openstack-barbican04:04
*** juantwo has quit IRC04:08
*** xianghuihui has quit IRC04:18
*** xianghui has joined #openstack-barbican04:21
*** kebray has joined #openstack-barbican04:26
*** ayoung has quit IRC04:41
*** bdpayne has joined #openstack-barbican05:02
*** kebray has quit IRC05:35
*** bdpayne has quit IRC06:08
*** bdpayne has joined #openstack-barbican06:20
*** bdpayne has quit IRC07:15
slddoes anyone know of a better way to find what specific file relates to a live page than to do a grep for a text fragment? (that is what i normally do, which works fine, but looking for a more official / streamlined way ;-) )08:47
*** alee has quit IRC11:25
*** juantwo has joined #openstack-barbican11:58
*** SheenaG1 has joined #openstack-barbican12:32
*** SheenaG11 has joined #openstack-barbican12:34
*** SheenaG1 has quit IRC12:36
*** SheenaG11 has quit IRC12:48
*** akoneru has joined #openstack-barbican13:04
*** alee has joined #openstack-barbican13:12
*** woodster_ has joined #openstack-barbican13:15
*** SheenaG1 has joined #openstack-barbican13:24
*** paul_glass has joined #openstack-barbican13:47
*** ayoung has joined #openstack-barbican13:52
*** SheenaG1 has quit IRC13:58
*** dmakogon_ is now known as denis_makogon14:08
*** rellerreller has joined #openstack-barbican14:19
*** SheenaG1 has joined #openstack-barbican14:28
openstackgerritJohn Wood proposed a change to openstack/barbican: Add initial files for certificate event handling  https://review.openstack.org/11530114:28
woodster_alee: that CR ^^^^ has some initlal eventing structure for certs to consider.14:42
aleewoodster_, yup - will look14:43
woodster_rellerreller: fyi for you as well ^^^^14:46
*** atiwari has joined #openstack-barbican14:46
rellerrellerwoodster_: thanks, I'll take a look at this later. Working on atiwari's CR at the moment14:48
openstackgerritA change was merged to openstack/barbican: Install of a Barbican RPM fails due to missing keystonemiddleware  https://review.openstack.org/11402215:07
*** ayoung has quit IRC15:10
redrobotsld not sure I understand your question?15:10
*** ayoung has joined #openstack-barbican15:10
*** SheenaG11 has joined #openstack-barbican15:15
*** SheenaG1 has quit IRC15:17
aleerellerreller, woodster_ the kmip cr looks good to me.  unless there are any objections - going to workflow it ..15:20
rm_workredrobot: please re-review https://review.openstack.org/#/c/114677/ :P15:21
redrobotrm_work steal my bp and then make me review it?15:21
redrobotrm_work fine!15:21
redrobotrm_work looks pretty good...  It sucks jaosorio is on vacation though.  I really wanted to get his input on it15:25
redrobotrm_work I think we should sort out the save() vs store() for secrets15:25
redrobotrm_work and save() vs submit() for orders15:25
rm_workyeah15:26
rm_worki thought you wanted to go with submit() for orders for sure15:26
rm_workand were ok with save or submit for secrets15:26
rm_worki could always make the official one "save" and alias in submit/store :P15:26
redrobotrm_work I do.15:26
redrobotugh... no aliases15:27
rm_workdef submit(self): self.save()15:27
rm_work:P15:27
redrobotrm_work >> There should be one-- and preferably only one --obvious way to do it.15:27
rm_workyou know it's easier15:27
rm_workfor the user15:27
rm_workwell anyway, I am in favor of the consistency15:28
rm_workand we either can't have it both ways, or we CAN :P15:28
redrobotconsistency for the sake of consistency is not worth it IMO15:28
rm_workalright, then I'll do store/submit15:29
redrobotconcensus here by devs not paying attention to IRC is store/submit15:30
rm_workk15:30
*** atiwari has quit IRC15:32
rellerrelleratiwari woodster_: I reviewed CR 87405. The validator was the biggest issue. It is validating that algorithm and mode must be supplied and in an enum. The NewSecretValidator is not doing that I believe.15:34
rellerrellerwoodster_ should we remove those validation checks for atiwari CR?15:35
openstackgerritAdam Harwell proposed a change to openstack/barbican-specs: Refactor Client Entity Models  https://review.openstack.org/11467715:35
aleerellerreller, just responding to that comment ..15:35
rm_workredrobot: updated, go +2 :P15:35
rm_workwoodster_: sorry, had to wipe your +2 to make redrobot happy15:35
rellerrelleralee it seems like a relevant topic since woodster_ brought up validation yesterday. This seems related in my mind.15:37
openstackgerritA change was merged to openstack/barbican: Replacing backslashes  https://review.openstack.org/11514015:37
aleerellerreller, its definitely relevant, and something that should be fixed.  but maybe not in arvind's CR15:38
aleerellerreller,  in any case, I think as a result of our validator discussion - those types of validations will go away15:38
aleerellerreller, the old validator is also doing the same types of valdations15:39
aleeso Arvind did not change that behavior15:39
rellerrelleralee, ya I was not sure what to do. I did not know if better to remove completely or what. I think the mode should be removed because that is optional.15:39
aleerellerreller, yeah - so lets defer this to a separate CR15:40
openstackgerritA change was merged to openstack/barbican: Adds KMIPSecretStore and unit tests  https://review.openstack.org/10158215:40
rellerrelleralee which old validator? I was looking at NewSecretValidator, and I did not see it checking alg, mode, etc. But maybe I missed that.15:40
aleeNewOrderValidator15:41
*** gyee has joined #openstack-barbican15:41
aleerellerreller, ^^15:41
rellerrelleralee thanks15:42
aleerellerreller, not particularly happy about the repeated code -- but as its code we plan to ax anyways, we can let that slide.15:42
rellerrelleralee it seems like the validation should be the same (or nearly the same) for order and new secret generation.15:42
rellerrelleralee ok, I think that was my biggest comment.15:43
aleerellerreller, yes -- I agree now with woodster_ that the validation is a big mess and we need to fix it.15:44
woodster_alee, rellerreller, atiwari: I added comments to yours out on this CR: https://review.openstack.org/#/c/8740515:58
*** paul_glass1 has joined #openstack-barbican15:59
*** kebray has joined #openstack-barbican16:00
*** kebray has quit IRC16:01
rm_workredrobot: i'm heading in, you have lunch plans today? still need to hit erick's16:03
*** paul_glass has quit IRC16:04
*** paul_glass has joined #openstack-barbican16:07
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Add more type in order post  https://review.openstack.org/8740516:08
*** atiwari has joined #openstack-barbican16:09
*** paul_glass1 has quit IRC16:11
redrobotrm_work probalby just trucks... I'm in sprint planning all day16:21
rm_workredrobot: ah T_T16:30
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix all the log statments to use %s fomatting  https://review.openstack.org/11534516:57
*** paul_glass has quit IRC16:59
*** bdpayne has joined #openstack-barbican17:17
*** bdpayne has quit IRC17:20
*** bdpayne has joined #openstack-barbican17:22
rm_workredrobot / woodster_ / jvrbanac / hockeynut / anyone: does the python barbican client need to support 2-stage secret creation? I am not sure that it ever has?17:40
openstackgerritA change was merged to openstack/barbican: Add more type in order post  https://review.openstack.org/8740517:46
*** crc32 has joined #openstack-barbican17:47
woodster_rm_work: it might never have worked, but you have to make it work now:)  I'd say the first CR could skip this feature17:52
rm_worklol k17:52
*** atiwari has quit IRC17:55
*** paul_glass has joined #openstack-barbican17:55
*** kebray has joined #openstack-barbican18:01
*** bdpayne has quit IRC18:03
*** bdpayne has joined #openstack-barbican18:21
openstackgerritConstanze Kratel proposed a change to openstack/barbican: Removed references to  tenant id/project id from docs and samples  https://review.openstack.org/10548818:25
*** bdpayne has quit IRC18:27
*** bdpayne has joined #openstack-barbican18:28
*** bdpayne has quit IRC18:29
*** bdpayne has joined #openstack-barbican18:33
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Reorganize code to use store crypto plug-in  https://review.openstack.org/11141218:38
*** kebray has quit IRC18:48
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix all the log statments to use %s fomatting  https://review.openstack.org/11534518:53
*** kebray has joined #openstack-barbican18:55
*** kebray_ has joined #openstack-barbican18:56
*** atiwari has joined #openstack-barbican18:58
*** kebray_ has quit IRC18:59
*** kebray has quit IRC18:59
*** paul_glass has quit IRC19:01
*** kebray has joined #openstack-barbican19:05
*** gyee has quit IRC19:08
*** kebray has joined #openstack-barbican19:10
*** paul_glass has joined #openstack-barbican19:15
openstackgerritArvind Tiwari proposed a change to openstack/barbican: fix all the log statments to use %s fomatting  https://review.openstack.org/11534519:20
openstackgerritJohn Vrbanac proposed a change to openstack/barbican: Minor cleanup and moving around code for clarity  https://review.openstack.org/11538719:38
*** kebray has quit IRC19:45
rm_workanyone have a recommendation for what Exception to raise when a Secret/Order is Immutable? I made my own "ImmutableException" class, but I feel like it might be better to use a built-in if there's something reasonable?19:50
rm_worksomething like IOError("This object is immutable") maybe?19:51
rm_workIOError -> because it is read-only?19:51
rm_workand you said I couldn't touch anything under common/ right?19:52
rm_workmaybe I could put my ImmutableException in base.py19:53
redrobotrm_work IOError doesn't seem right https://docs.python.org/2/library/exceptions.html#exceptions.IOError19:53
rm_workredrobot: i mean yeah, i'm TRYING to make something fit19:53
rm_workbut I might should just use my custom one19:53
openstackgerritSheena Gregson proposed a change to openstack/barbican: Edited docs to improve context  https://review.openstack.org/11466519:59
SheenaG11Fixed!  BRING ME YOUR +2s!20:01
openstackgerritSheena Gregson proposed a change to openstack/barbican: Edited docs to improve context  https://review.openstack.org/11466520:03
openstackgerritA change was merged to openstack/barbican: Update versionbuild script to handle setup.cfg version  https://review.openstack.org/11514920:04
*** paul_glass has quit IRC20:06
*** kebray has joined #openstack-barbican20:08
*** bdpayne has quit IRC20:12
*** paul_glass has joined #openstack-barbican20:13
openstackgerritArvind Tiwari proposed a change to openstack/barbican-specs: Split validator module in to smaller modules  https://review.openstack.org/11539420:15
*** paul_glass has quit IRC20:22
openstackgerritSheena Gregson proposed a change to openstack/barbican: Edited docs to improve context  https://review.openstack.org/11466520:26
SheenaG11Patch set 5...20:26
*** paul_glass has joined #openstack-barbican20:27
*** paul_glass1 has joined #openstack-barbican20:28
*** atiwari has quit IRC20:28
*** paul_glass has quit IRC20:31
*** gyee has joined #openstack-barbican20:36
*** SheenaG11 has quit IRC20:40
hockeynutSheenaG11 5 is a lucky number.20:44
*** kebray has quit IRC20:49
*** atiwari has joined #openstack-barbican20:50
atiwarihockeynut, yt?20:56
*** bdpayne has joined #openstack-barbican20:56
hockeynutatiwari yes but just about heading into a meeting :-(20:59
*** bdpayne has quit IRC21:00
*** bdpayne has joined #openstack-barbican21:03
*** SheenaG1 has joined #openstack-barbican21:04
*** juantwo has quit IRC21:09
*** SheenaG1 has quit IRC21:26
*** crc32 has quit IRC21:31
*** SheenaG1 has joined #openstack-barbican21:32
rm_workumm, what are Verifications? >_>21:35
*** crc32 has joined #openstack-barbican21:35
*** crc32 has quit IRC21:35
SheenaG1rm_work: where are you seeing Verifications?21:36
rm_workthe client21:37
SheenaG1It's an old branch of code that we (mostly) scrubbed from our OpenStack stuff21:37
rm_workPython Barbican Client has a verifications.py that looks very much like the orders.py and secrets.py resources >_>21:37
rm_workok so...21:37
SheenaG1We're still working on removing skeletons AFAIK21:37
*** rellerreller has quit IRC21:38
rm_workshould that be REMOVED from PBC?21:38
SheenaG1I think so - woodster_?21:38
SheenaG1Or redrobot?21:38
SheenaG1I can't imagine why we would keep any of the verifications stuff21:38
rm_workand more importantly, can i remove it *in this CR* :P21:38
rm_workor do I need a new BP/CR combo for it, lol21:38
woodster_verifications should be removed from the openstack branch for sure21:38
SheenaG1I can't imagine you'd need a new BP to do cleanup21:38
woodster_I wouldn't think so either21:39
SheenaG1KILL IT WITH FIRE21:39
rm_worklol k21:39
rm_workwoo21:39
SheenaG1Thanks Adam21:39
woodster_now it might make sense to do that in a separate CR though21:39
woodster_bigger CR = longer to review21:39
woodster_if it's just a few lines though, probably no big deal21:40
rm_workheh21:40
rm_workjust two files *disappear*21:40
rm_workand one import gets cut21:40
SheenaG1Nobody's going to miss them21:42
SheenaG1fact.21:42
woodster_KILL THEM WITH FIRE21:43
rm_work:P21:43
rm_workfinished orders, added some tests, removed verifications -- submitting a new patchset21:43
rm_workoh and cleaned up some of the ugly in Secrets too21:43
SheenaG1I'd say our baby isn't ugly21:44
SheenaG1But I know there's a little in there21:45
rm_workwoodster_: I didn't even realize dictionary-comprehensions were a thing too :P that's awesome\21:45
rm_workI love the list-comp syntax / magic21:45
*** crc32 has joined #openstack-barbican21:45
rm_work(one of my favorite Python features)21:46
woodster_yep, similar to magical21:46
*** alee is now known as alee_on_way_home21:46
*** paul_glass has joined #openstack-barbican21:48
*** paul_glass1 has quit IRC21:52
*** alee_on_way_home has quit IRC21:52
*** paul_glass has quit IRC21:52
*** bdpayne has quit IRC21:58
*** bdpayne has joined #openstack-barbican22:00
*** SheenaG1 has quit IRC22:05
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient  https://review.openstack.org/11508022:05
rm_workwoodster_ / redrobot: ^^ ready for review, if you're not braindead from sprint planning <_<22:06
rm_workah, I guess I may need to revisit the actual "CLI" part... not sure if that works still <_<22:13
rm_workwhoops22:13
rm_workand I've already got a couple of other changes, but a general review is still totally great if you're feelin' it22:18
*** nkinder has quit IRC22:18
*** nkinder has joined #openstack-barbican22:20
redrobot-1 per IRC.  /done22:21
redrobotrm_work https://gist.github.com/dmend/670987422:27
*** akoneru has quit IRC22:36
*** bdpayne has quit IRC22:44
*** juantwo has joined #openstack-barbican22:51
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Refactor client models in python-barbicanclient  https://review.openstack.org/11508023:29
*** atiwari has quit IRC23:31
rm_worksubmitting WITH working CLI :)23:33
rm_work*submitted23:33
*** alee_on_way_home has joined #openstack-barbican23:49
*** crc32 has quit IRC23:49
openstackgerritJohn Wood proposed a change to openstack/barbican: Add initial files for certificate event handling  https://review.openstack.org/11530123:56
openstackgerritArun Kant proposed a change to openstack/barbican-specs: Blueprint for supporting binary secret retrival in text format  https://review.openstack.org/11543523:56
openstackgerritArun Kant proposed a change to openstack/barbican-specs: Blueprint for supporting binary secret retrival in text format  https://review.openstack.org/11543523:58
« Monday, 2014-08-18 Index Wednesday, 2014-08-20 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!