*** rhagarty__ has quit IRC | 00:00 | |
*** rhagarty__ has joined #openstack-app-catalog | 00:00 | |
*** rhagarty__ has quit IRC | 00:00 | |
*** rhagarty__ has joined #openstack-app-catalog | 00:00 | |
*** rhagarty__ has quit IRC | 00:01 | |
*** rhagarty__ has joined #openstack-app-catalog | 00:01 | |
*** rhagarty__ has quit IRC | 00:01 | |
*** rhagarty__ has joined #openstack-app-catalog | 00:01 | |
*** rhagarty__ has quit IRC | 00:02 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:02 | |
*** rhagarty_ has quit IRC | 00:02 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:02 | |
*** rhagarty_ has quit IRC | 00:03 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:03 | |
*** rhagarty_ has quit IRC | 00:03 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:03 | |
*** rhagarty_ has quit IRC | 00:04 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:04 | |
*** rhagarty_ has quit IRC | 00:04 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:04 | |
*** rhagarty_ has quit IRC | 00:05 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:05 | |
*** rhagarty_ has quit IRC | 00:05 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:05 | |
*** rhagarty_ has quit IRC | 00:06 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:06 | |
*** rhagarty_ has quit IRC | 00:06 | |
*** rhagarty_ has joined #openstack-app-catalog | 00:06 | |
*** rhagarty__ has joined #openstack-app-catalog | 00:07 | |
*** rhagarty_ has quit IRC | 00:07 | |
*** rhagarty__ has quit IRC | 00:07 | |
*** rhagarty__ has joined #openstack-app-catalog | 00:07 | |
*** rhagarty__ has quit IRC | 00:08 | |
*** toddjohn_ has joined #openstack-app-catalog | 01:11 | |
*** toddjohn_ has quit IRC | 01:11 | |
openstackgerrit | Merged openstack/app-catalog: Add TOSCA assets https://review.openstack.org/289132 | 02:54 |
---|---|---|
openstackgerrit | OpenStack Proposal Bot proposed openstack/app-catalog: Detect dead links https://review.openstack.org/290292 | 06:18 |
*** kzaitsev_mb has joined #openstack-app-catalog | 07:48 | |
*** toddjohn_ has joined #openstack-app-catalog | 08:00 | |
*** toddjohn_ has quit IRC | 08:05 | |
*** kzaitsev_mb has quit IRC | 08:32 | |
*** openstackgerrit has quit IRC | 08:47 | |
*** openstackgerrit has joined #openstack-app-catalog | 08:48 | |
*** dfflanders has joined #openstack-app-catalog | 09:44 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 09:56 | |
*** dfflanders has quit IRC | 10:04 | |
*** toddjohn_ has joined #openstack-app-catalog | 11:54 | |
*** toddjohn_ has quit IRC | 12:00 | |
*** toddjohn_ has joined #openstack-app-catalog | 12:01 | |
*** toddjohn_ has quit IRC | 12:05 | |
*** ativelkov has quit IRC | 13:41 | |
*** kzaitsev_ws has quit IRC | 13:41 | |
*** kzaitsev_mb has quit IRC | 13:41 | |
*** ativelkov has joined #openstack-app-catalog | 14:15 | |
*** toddjohn_ has joined #openstack-app-catalog | 14:56 | |
*** toddjohn_ has quit IRC | 15:01 | |
*** toddjohn_ has joined #openstack-app-catalog | 15:02 | |
*** toddjohn_ has quit IRC | 15:07 | |
openstackgerrit | Mark Vanderwiel proposed openstack/app-catalog: Add lbaas v2 template example https://review.openstack.org/290121 | 15:10 |
openstackgerrit | Omar Shykhkerimov proposed openstack/app-catalog: Create form for making assets. https://review.openstack.org/288055 | 15:18 |
*** toddjohn_ has joined #openstack-app-catalog | 15:31 | |
*** spzala has joined #openstack-app-catalog | 15:33 | |
*** toddjohn_ has quit IRC | 15:35 | |
*** toddjohn_ has joined #openstack-app-catalog | 15:40 | |
kfox1111 | docaedo: there's more and more effort being spent on that python form. its really really the wrong aproach. :/ | 16:44 |
docaedo | add it to the agenda for this week and we can hash it out Thursday. I agree, don't see that it has utility beyond the glance PoC. | 16:45 |
docaedo | It's possible (likely?) this is expected to just be used for that, and would never expect to be merged | 16:46 |
kfox1111 | thats fine, but why bother to code review it then? | 16:47 |
kfox1111 | kzaitsev did mention its an a student doing it if I remember correctly. | 16:47 |
kfox1111 | which is great. | 16:48 |
kfox1111 | but if that is true, its better for the student to learn to do it right. | 16:48 |
kfox1111 | learning how to write this code in angular will be good too. | 16:48 |
*** kzaitsev_mb has joined #openstack-app-catalog | 17:05 | |
*** kzaitsev_ws has joined #openstack-app-catalog | 17:07 | |
kfox1111 | kzaitsev_mb: alive? | 17:08 |
kzaitsev_mb | yep, was about to write you a message | 17:08 |
kfox1111 | k. | 17:08 |
kzaitsev_mb | kfox1111: do I understand correctly, that your biggest concern about the form was that it's being implemented in python? =) | 17:08 |
docaedo | kzaitsev_mb: welcome to core BTW :) probably long overdue | 17:08 |
kzaitsev_mb | thanks =) | 17:09 |
kfox1111 | oh, yeah. congrats kzaitsev! :) | 17:09 |
*** toddjohn_ has quit IRC | 17:09 | |
kfox1111 | yeah. we weren't going to do any python ui code. | 17:09 |
kfox1111 | python coding html ui's is really painful. :/ | 17:10 |
kzaitsev_mb | and that would probably make the code more portable and a lot easier to include in the -ui | 17:10 |
kfox1111 | yeah. | 17:10 |
kzaitsev_mb | I think, that I see your point, yes. | 17:11 |
kfox1111 | if you used angular, it would be almost entirely html, with really just a few lines of js for the post. | 17:11 |
kfox1111 | like 20, tops. | 17:11 |
kfox1111 | see: http://www.w3schools.com/angular/tryit.asp?filename=try_ng_form | 17:11 |
kzaitsev_mb | probably my bad for not communicating that thing earlier, yeah | 17:12 |
kzaitsev_mb | I've tried angular a couple of times and every time I have to re-learn it a bit. it's learning curve is a bit too steep. =) | 17:14 |
kfox1111 | depends on if your a html guy or a python guy I guess. :) | 17:17 |
kfox1111 | Angular seems way more natural to me (with my webdev hat on). it uses html as intended rather then trying to generate html in languages not suited to it. | 17:18 |
kfox1111 | yeah, there's some weird magic stuff that is under the hood that is a bit painful to learn sometimes. | 17:19 |
kfox1111 | but stuff like this form is soooo much easier in it. | 17:19 |
kfox1111 | you could almost get away with no code at all for this use case. | 17:19 |
kfox1111 | with rest becoming more and more standard, I'd expect in a future version of angular, you wouldn't need any code at all for doing this kind of form thing. | 17:21 |
*** toddjohn_ has joined #openstack-app-catalog | 17:28 | |
*** toddjohn_ has quit IRC | 17:34 | |
*** toddjohn_ has joined #openstack-app-catalog | 17:38 | |
*** kzaitsev_mb has quit IRC | 17:45 | |
*** toddjohn_ has quit IRC | 18:03 | |
*** toddjohn_ has joined #openstack-app-catalog | 18:03 | |
*** spzala has quit IRC | 18:11 | |
*** spzala has joined #openstack-app-catalog | 18:11 | |
openstackgerrit | Mark Vanderwiel proposed openstack/app-catalog-ui: Lint cleanups https://review.openstack.org/289586 | 18:15 |
*** spzala has quit IRC | 18:16 | |
*** spzala has joined #openstack-app-catalog | 18:25 | |
markvan | docaedo: just tried image create in master devstack, looks broken again, similar to https://bugs.launchpad.net/horizon/+bug/1503396 | 18:25 |
openstack | Launchpad bug 1503396 in OpenStack Dashboard (Horizon) "glance wizard form var passing broken" [Critical,Fix released] - Assigned to Richard Jones (r1chardj0n3s) | 18:25 |
kfox1111 | :/ | 18:26 |
docaedo | markvan: ah jeez .. I'll update my devstack too and see if I can recreate | 18:26 |
kfox1111 | yeah. if its a bug we need to get it filed with horizon asap. :/ | 18:26 |
markvan | docaedo: yeah, just noticed it, double checking I don't have messy env. | 18:27 |
kfox1111 | I hope to meet with the horizon folks this coming summit (if I can make it) and discuss how we might make an angular api they can provide us, that they can test, that makes sure they don't break things again. | 18:28 |
markvan | kfox1111: yup, from our side, i'm trying to add a couple more tests that would at least click the create/launch button, then validate the image/heat forms are filled in properly. But that only shows us when horizon is broken, does not prevent them from breaking us. | 18:31 |
kfox1111 | yeah. | 18:31 |
kfox1111 | and I expect as they move more stuff from python to angular, it will break over and over. | 18:31 |
kfox1111 | with an angular api, it would let them change the internals without breaking the contract. | 18:31 |
markvan | agreed | 18:32 |
kfox1111 | but, yeah, having those click tests at minimum would allow us to gate their changes to help them not break it so easily. | 18:32 |
*** toddjoh__ has joined #openstack-app-catalog | 18:36 | |
*** toddjo___ has joined #openstack-app-catalog | 18:37 | |
*** toddjohn_ has quit IRC | 18:39 | |
*** toddjohn_ has joined #openstack-app-catalog | 18:39 | |
*** toddjoh__ has quit IRC | 18:40 | |
*** toddjoh__ has joined #openstack-app-catalog | 18:41 | |
kfox1111 | so, as for the app-catalog-common merge with app-catalog-ui, I'm thinking we should probably do that first thing in Newton. it will require package changes to add the new package and make the other depend on it, so that can take a long time. :/ | 18:41 |
kfox1111 | if we start at the begining of Newton, we have 6 months to get it into rdo/debian/ubuntu before the dust settles. | 18:41 |
*** toddjo___ has quit IRC | 18:43 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 18:43 | |
*** toddjohn_ has quit IRC | 18:44 | |
docaedo | haha sounds like a good plan. Debian/ubuntu will be fast. The painful part is the *absurdity* around building deb packages. | 18:44 |
docaedo | RDO .. well, I'll try to make some friends in Austin, maybe it won't be so bad next time around | 18:44 |
kfox1111 | I hope so. | 18:45 |
*** toddjoh__ has quit IRC | 18:54 | |
*** toddjohn_ has joined #openstack-app-catalog | 18:55 | |
docaedo | the devstack instance I just kicked off for latest everything worked for passing the variables. Tested with glance image and heat template, did not confirm with murano | 19:00 |
docaedo | but the earlier problem was with glance, so I don't think the bug is back? | 19:00 |
*** kzaitsev_mb has quit IRC | 19:09 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 19:15 | |
markvan | docaedo: humm, I just respun my devstack as well, but still see the issue. will dig a bit more | 19:32 |
docaedo | markvan: huh that's surprising - the issue you're seeing, to be clear, is that the glance image location is not pre-filled right? | 19:32 |
markvan | oh, sorry, it's slightly different, that field is filled in, but the kernel and ramdisk fields are there for a qcow2. Looks like an image bug | 19:36 |
markvan | I recall from before that these fields caused it to fail without valid values, but now, looks like even tho there are not filled in, the image creates, very ugly | 19:37 |
markvan | wow, try clicking on the "Public" checkbox at the bottom, then it will fail. Looks like something is wrong here | 19:40 |
markvan | Looks like the Edit version of that dialog works properly by greying out the kernel/ramdisk/arch fields when dealing with qcow2. | 19:44 |
docaedo | hmm .. TBH I have NOT played too much with it, basically ignored those issues because I could click "install" and get the image :) | 19:46 |
markvan | docaedo: yeah, so I guess if I get my testcase working, we would not see this as bugs, yeh!? | 19:48 |
docaedo | haha yep | 19:56 |
docaedo | So when I just click "create image" from horizon, I see the same fields, nothing is greyed out (also public works for me) | 19:59 |
docaedo | if kernel and ramdisk are not supposed to be there in some cases, not sure what's going on | 20:00 |
*** rhagarty has joined #openstack-app-catalog | 20:01 | |
*** toddjohn_ has quit IRC | 20:18 | |
*** toddjohn_ has joined #openstack-app-catalog | 20:53 | |
*** toddjohn_ has quit IRC | 20:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!