*** toddjohn_ has joined #openstack-app-catalog | 00:01 | |
kfox1111 | docaedo: why was the scripts moved? | 01:01 |
---|---|---|
docaedo | kfox1111: what do you mean? | 01:05 |
kfox1111 | in the index.html file, a bunch of code was shifted upwards in the patch. | 01:05 |
kfox1111 | seems needless? | 01:06 |
docaedo | oh lemme take a look, that's probably a mistake from when I was playing with an earlier version | 01:06 |
docaedo | oops yeah, moved it around a bit at one point and didn't put it back where it was meant to be, will fix after I help with dinner :) | 01:07 |
kfox1111 | k. :) | 01:07 |
kfox1111 | looks nice though. :) | 01:07 |
docaedo | thnx | 01:08 |
*** toddjohn_ has quit IRC | 01:09 | |
openstackgerrit | Christopher Aedo proposed openstack/app-catalog: Rotate recently added apps https://review.openstack.org/286927 | 01:11 |
kfox1111 | space got deleted on line 241 | 01:13 |
kfox1111 | not sure what changed between 357->320 | 01:13 |
docaedo | ah I'll patch again after dinner (should have just checked out from head :) ) | 01:14 |
kfox1111 | rest looks ok. | 01:15 |
*** kzaitsev_mb has quit IRC | 01:22 | |
openstackgerrit | Christopher Aedo proposed openstack/app-catalog: Rotate recently added apps https://review.openstack.org/286927 | 01:51 |
*** rhagarty_ has quit IRC | 02:04 | |
*** rhagarty has joined #openstack-app-catalog | 02:12 | |
*** rhagarty has quit IRC | 02:36 | |
*** openstack has joined #openstack-app-catalog | 14:09 | |
*** openstackgerrit_ has quit IRC | 14:36 | |
*** openstackgerrit_ has joined #openstack-app-catalog | 14:37 | |
*** rhagarty has joined #openstack-app-catalog | 14:45 | |
*** rhagarty_ has joined #openstack-app-catalog | 14:46 | |
*** rhagarty has quit IRC | 14:48 | |
*** spzala has joined #openstack-app-catalog | 14:50 | |
*** kzaitsev_mb has quit IRC | 15:26 | |
*** rhagarty_ has quit IRC | 15:36 | |
*** rhagarty has joined #openstack-app-catalog | 15:51 | |
*** rhagarty_ has joined #openstack-app-catalog | 15:52 | |
*** rhagarty has quit IRC | 15:56 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 16:23 | |
*** rhagarty has joined #openstack-app-catalog | 16:28 | |
*** rhagarty_ has quit IRC | 16:30 | |
*** kzaitsev_mb has quit IRC | 16:30 | |
*** spzala has quit IRC | 16:44 | |
*** spzala has joined #openstack-app-catalog | 16:44 | |
*** rhagarty_ has joined #openstack-app-catalog | 16:45 | |
*** rhagarty has quit IRC | 16:47 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 16:55 | |
*** kzaitsev_mb has quit IRC | 17:40 | |
openstackgerrit | Christopher Aedo proposed openstack/app-catalog: Rotate recently added apps https://review.openstack.org/286927 | 17:47 |
kfox1111 | docaedo: last one I promice... :) can you please put ';'s on the vars your just added? It really really shoudn't matter, but I've seen compressors screw that up one too many times. :/ | 18:17 |
docaedo | ah yes, I meant to do that too! thanks for the reminder, one sec... | 18:18 |
openstackgerrit | Christopher Aedo proposed openstack/app-catalog: Rotate recently added apps https://review.openstack.org/286927 | 18:19 |
kfox1111 | thx. :) | 18:20 |
docaedo | no prob, thanks for the feedback. also huge points to you for pulling that last modified info out of git and putting it where we can use it :) | 18:24 |
kfox1111 | thanks. and thanks for finishing the feature. I've been wanting to do that for a while now. :) | 18:25 |
docaedo | same here, had been on my mind for weeks but kept getting pushed off, then finally figured I'd find the time to do it | 18:25 |
*** pcaruana has quit IRC | 18:41 | |
*** spzala has quit IRC | 18:48 | |
*** spzala has joined #openstack-app-catalog | 18:48 | |
openstackgerrit | Christopher Aedo proposed openstack/app-catalog: Rotate recently added apps https://review.openstack.org/286927 | 19:18 |
*** kzaitsev_mb has joined #openstack-app-catalog | 19:32 | |
*** kzaitsev_mb has quit IRC | 19:47 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 19:47 | |
*** kzaitsev_mb has quit IRC | 20:15 | |
*** rhagarty_ has quit IRC | 21:07 | |
*** rhagarty_ has joined #openstack-app-catalog | 21:07 | |
*** pcaruana has joined #openstack-app-catalog | 21:58 | |
*** spzala has quit IRC | 22:01 | |
*** spzala has joined #openstack-app-catalog | 22:01 | |
*** spzala has quit IRC | 22:06 | |
*** spzala has joined #openstack-app-catalog | 22:15 | |
*** spzala has quit IRC | 23:24 | |
*** spzala has joined #openstack-app-catalog | 23:24 | |
*** spzala has quit IRC | 23:29 | |
*** spzala has joined #openstack-app-catalog | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!