*** tej has quit IRC | 02:03 | |
*** tej has joined #openstack-app-catalog | 02:03 | |
*** tej has quit IRC | 02:08 | |
*** kebray has quit IRC | 03:48 | |
*** kebray has joined #openstack-app-catalog | 03:54 | |
*** kebray has quit IRC | 04:36 | |
*** kebray has joined #openstack-app-catalog | 04:37 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 04:46 | |
*** kzaitsev_mb has quit IRC | 05:00 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/app-catalog: Detect dead links https://review.openstack.org/282197 | 06:22 |
---|---|---|
*** kzaitsev_mb has joined #openstack-app-catalog | 06:56 | |
*** pcaruana has joined #openstack-app-catalog | 07:45 | |
*** kzaitsev_mb has quit IRC | 07:47 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 09:36 | |
*** kzaitsev_mb has quit IRC | 09:44 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 09:49 | |
*** kzaitsev_mb has quit IRC | 09:55 | |
*** tej has joined #openstack-app-catalog | 10:41 | |
*** tej has quit IRC | 10:45 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 11:02 | |
*** kzaitsev_mb has quit IRC | 11:07 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 11:39 | |
*** kzaitsev_mb has quit IRC | 12:27 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 12:41 | |
openstackgerrit | Kirill Zaitsev proposed openstack/app-catalog: glare artifacts plugin for app-catalog asset types https://review.openstack.org/276857 | 12:56 |
*** tej has joined #openstack-app-catalog | 13:23 | |
openstackgerrit | Dmytro Dovbii proposed openstack/app-catalog: [WIP] add script to upload assets to glare https://review.openstack.org/281602 | 13:54 |
openstackgerrit | Kirill Zaitsev proposed openstack/app-catalog: glare artifacts plugin for app-catalog asset types https://review.openstack.org/276857 | 14:23 |
*** openstackgerrit_ has quit IRC | 14:43 | |
kzaitsev_mb | I'm installing glare on a clean ubuntu and oh boy, it requires a bunch of things to just run tox =/ | 14:52 |
kzaitsev_mb | I've been promised to have a public IP next week, btw =) | 14:53 |
*** openstackgerrit_ has joined #openstack-app-catalog | 15:00 | |
markvan | docaedo: the infra side of the integration test patch is ready (+2's) but it's waiting on the app-cat side (https://review.openstack.org/#/c/276440/) and https://review.openstack.org/#/c/276438/ | 15:19 |
kzaitsev_mb | markvan: as far as I see it only has 1 test case — just goes to the app-cat page and checks that it's there, right? | 15:21 |
markvan | yeah, just a place holder to get this started. It's non-voting so no harm. Then I can dig deeper into adding more tests | 15:22 |
kzaitsev_mb | markvan: also is there any need for so many different requirements added (Babel for instance is a 6mb package, that's not used anywhere) | 15:22 |
kzaitsev_mb | actually this made me realise, that we need to add app-cat-ui to projects, that are being updated by proposal bot | 15:23 |
markvan | That could probably be narrowed, was just basing off what is done in other projects to get this going. | 15:24 |
markvan | I can pull out Babel | 15:25 |
kzaitsev_mb | we've just removed babel from murano-agent, since it's now installable through cloud-init. and 6mb might sometimes get dowloaded for some noticable amount of time. | 15:27 |
kzaitsev_mb | anyway no one seem to use it directly, it's a dependency of oslo.i18n though | 15:28 |
markvan | Humm, and since this is a plugin to Horizon, wouldn't it already be there for it's reqirement? | 15:31 |
openstackgerrit | Mark Vanderwiel proposed openstack/app-catalog-ui: Adding integration test support https://review.openstack.org/276438 | 15:34 |
*** spzala has joined #openstack-app-catalog | 15:35 | |
markvan | kzaitsev_mb: and I think we should also add pep8 and eslint jobs at some point | 15:38 |
kzaitsev_mb | markvan: yep, eslint =) I've added the basic framework a while ago, but for some reason there was a separate commit and I thought it hadn't landed %) | 15:39 |
kzaitsev_mb | with eslint we should only enable js-lint jobs, I don't think there are any js unit-tests and the job might fail | 15:40 |
markvan | sure | 15:42 |
markvan | something like gate-app-catalog-ui-npm-run-lint should do the trick | 15:46 |
markvan | kzaitsev_mb: I have patches for js-lint and pep8 ready, but will wait for integration dust to settle to push them | 16:08 |
*** pcaruana has quit IRC | 16:10 | |
*** kebray has quit IRC | 16:32 | |
*** kebray has joined #openstack-app-catalog | 16:38 | |
openstackgerrit | Merged openstack/app-catalog: Detect dead links https://review.openstack.org/282197 | 16:45 |
*** kzaitsev_mb has quit IRC | 16:50 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 16:53 | |
*** kzaitsev_mb has quit IRC | 16:59 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 17:03 | |
*** kzaitsev_mb has quit IRC | 17:10 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 17:33 | |
*** kzaitsev_mb has quit IRC | 17:43 | |
*** kebray has quit IRC | 17:45 | |
*** kebray has joined #openstack-app-catalog | 18:51 | |
*** spzala has quit IRC | 18:59 | |
*** kebray has quit IRC | 19:41 | |
*** kebray has joined #openstack-app-catalog | 19:42 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 20:22 | |
*** kzaitsev_mb has quit IRC | 20:26 | |
*** markvan has quit IRC | 21:04 | |
*** markvan has joined #openstack-app-catalog | 21:05 | |
*** kebray has quit IRC | 21:26 | |
*** kebray has joined #openstack-app-catalog | 21:40 | |
*** kebray has quit IRC | 22:29 | |
*** kebray has joined #openstack-app-catalog | 22:34 | |
*** tej has quit IRC | 23:18 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!