| kfox1111 | cool. | 00:15 |
|---|---|---|
| kfox1111 | hmm.... I was considering it a cache... but the assets stuff is already a cache... so I could just move the code inside the other conditional... | 00:20 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog: Derive asset last modified date/time from git logs https://review.openstack.org/267087 | 00:28 |
| docaedo | I was about to ask what you mean but now I get it :) | 00:28 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog: Derive asset last modified date/time from git logs https://review.openstack.org/267087 | 00:29 |
| kfox1111 | missed a pep8 thing. :/ | 00:29 |
| kfox1111 | that one should do it I think. | 00:29 |
| kfox1111 | I probably shouldn't do any more braining today... its not working so good anymore. :/ | 00:29 |
| docaedo | haha | 00:30 |
| docaedo | I like that last one, except for that missing blank line (srsly, you need TWO blanks there!) | 00:30 |
| docaedo | but agree this one makes the most sense since we would want that info updated each time the assets json is created | 00:30 |
| docaedo | then once a day we can check for dead links, which will probably result in VERY few PRs from proposal_bot | 00:31 |
| docaedo | but you should kick back and relax, braining overload is good for no one! | 00:31 |
| kfox1111 | nice. Will be happy not to have to review spurrious PR's. :) | 00:33 |
| *** tej has joined #openstack-app-catalog | 00:33 | |
| kfox1111 | heh. too much work not to work. at the moment. :/ | 00:33 |
| kfox1111 | oh. I think I can simplify the update_assets.sh a tad more. | 00:34 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog: Derive asset last modified date/time from git logs https://review.openstack.org/267087 | 00:35 |
| kfox1111 | There we go. | 00:35 |
| kfox1111 | I added a few comments to the crazy shell script just to make it a bit easier to read. | 00:36 |
| docaedo | nice, that one took me a while to tear apart | 00:36 |
| kfox1111 | for the assets_dead.yaml, you can touch the file in the if conditional, and then always merge it in I think? | 00:36 |
| kfox1111 | then the dead link checker can just write into it. | 00:36 |
| kfox1111 | oh. or is that going into git? | 00:37 |
| docaedo | yeah I want it in git so it only runs sometimes (but continues to run if the repo isn't touched for days or weeks), but also has human approval | 00:38 |
| kfox1111 | ah. k. | 00:38 |
| docaedo | I fear that edge case of it checking links when thier hosting provider is under a DDoS and deciding everything in the catalog is unreachable :) | 00:38 |
| docaedo | or some other scenario where it's just plain wrong and wants to junk the catalog | 00:38 |
| kfox1111 | thats a good point. | 00:40 |
| kfox1111 | could add a quick check in the link checker too. if it wants to mark more then x assets as offline in a given pass, dont and email or something? | 00:40 |
| kfox1111 | though if its gerrit reviewing, probably ok without. | 00:41 |
| docaedo | I was thinking about that but figured rather than try to wrap up a bunch of logic, we can just keep an eye on it via review - yeah | 00:41 |
| docaedo | honestly if proposal_bot becomes a burdon and does crazy stuff all the time, we stop that periodic job | 00:41 |
| docaedo | but I think it will run once, find the two dead links (AeroFS and .. something else I forgot), and probably won't propose anything else :) | 00:42 |
| docaedo | thanks for circling back, I'll review tonight | 00:43 |
| kfox1111 | one more thing... | 00:43 |
| kfox1111 | we're doing the merges with yaml, but I'm not really tied to it... | 00:43 |
| kfox1111 | if your putting stuff in gerrit, ordering would be useful again for reviews, | 00:44 |
| kfox1111 | and its way easier to do a json.dumps(j, indent=4, sort_keys=True) | 00:44 |
| kfox1111 | then try and get the order consistent with yaml. | 00:44 |
| docaedo | yes and no - TBH if the number of dead links found creeps really high, something else is wrong. Normally it should find a dead link, and we chase it down - fix or remove - then it's gone. so assets_dead.yaml shouldn't be a big file ever | 00:45 |
| kfox1111 | so if you want to switch it over to json instead to save a bunch of code, thats cool with me. | 00:45 |
| docaedo | but yeah, yaml vs. json doesn't really matter to me | 00:45 |
| kfox1111 | yeah. agreed. just thinking it will be more obvious when you remove a single line, or adding a new line, and the whole file doesn't change. but true. the whole file is probably easily person parsable at a glance anyway. | 00:46 |
| docaedo | I'm looking forward to making the "recently added apps" more dynamic, this will be a nice change. | 00:49 |
| docaedo | stepping out now but will be back later, hopefully you're not working too late making all the things HA! | 00:49 |
| kfox1111 | have a good one. :) | 00:50 |
| docaedo | you too | 00:50 |
| *** tej has quit IRC | 01:14 | |
| *** kebray has joined #openstack-app-catalog | 01:15 | |
| *** ativelkov has quit IRC | 01:40 | |
| *** ativelkov has joined #openstack-app-catalog | 01:40 | |
| *** kebray has quit IRC | 02:14 | |
| *** tej has joined #openstack-app-catalog | 02:15 | |
| *** tej has quit IRC | 02:19 | |
| openstackgerrit | Merged openstack/app-catalog: Derive asset last modified date/time from git logs https://review.openstack.org/267087 | 02:37 |
| openstackgerrit | Christopher Aedo proposed openstack/app-catalog: Include assets_dead.yaml in asset merge https://review.openstack.org/270579 | 02:46 |
| *** tej has joined #openstack-app-catalog | 04:16 | |
| *** tej has quit IRC | 04:22 | |
| *** rhagarty_ has quit IRC | 04:24 | |
| *** rhagarty_ has joined #openstack-app-catalog | 04:24 | |
| *** tej has joined #openstack-app-catalog | 05:19 | |
| *** tej has quit IRC | 05:24 | |
| *** tej has joined #openstack-app-catalog | 06:20 | |
| *** tej has quit IRC | 06:24 | |
| *** tej has joined #openstack-app-catalog | 08:21 | |
| *** tej has quit IRC | 08:25 | |
| *** tej has joined #openstack-app-catalog | 09:22 | |
| *** tej has quit IRC | 09:26 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #openstack-app-catalog | 10:03 | |
| *** tej has joined #openstack-app-catalog | 10:23 | |
| *** tej has quit IRC | 10:28 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 10:35 | |
| *** kzaitsev_mb has quit IRC | 11:14 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 11:19 | |
| *** tej has joined #openstack-app-catalog | 11:24 | |
| *** tej has quit IRC | 11:28 | |
| *** kzaitsev_mb has quit IRC | 11:34 | |
| *** tej has joined #openstack-app-catalog | 12:24 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 12:25 | |
| *** tej has quit IRC | 12:29 | |
| *** tej has joined #openstack-app-catalog | 13:25 | |
| *** tej has quit IRC | 13:25 | |
| *** tej has joined #openstack-app-catalog | 13:26 | |
| *** kzaitsev_mb has quit IRC | 13:38 | |
| *** kzaitsev1ws is now known as kzaitsev_ws | 13:41 | |
| *** tej has quit IRC | 13:54 | |
| *** tej has joined #openstack-app-catalog | 13:54 | |
| *** tej has quit IRC | 13:59 | |
| *** tej has joined #openstack-app-catalog | 14:43 | |
| *** kebray has joined #openstack-app-catalog | 15:54 | |
| *** rmoe has quit IRC | 16:02 | |
| *** rmoe has joined #openstack-app-catalog | 16:03 | |
| *** spzala has joined #openstack-app-catalog | 16:14 | |
| spzala | docaedo: Hi, gm. | 16:15 |
| docaedo | spzala: morning! | 16:23 |
| docaedo | spzala: will you be able to make the meeting in about half an hour? | 16:23 |
| spzala | docaedo: for today's meeting I need to leave early for another meeting but hopefully we can cover TOSCA in first half of the meeting. | 16:23 |
| docaedo | sure, we'll do that first up | 16:23 |
| spzala | docedo: :-) you read my mind.. half an hour is perfect | 16:24 |
| spzala | Thanks!! | 16:24 |
| docaedo | no prob! | 16:24 |
| *** kebray has quit IRC | 16:35 | |
| spzala | is meeting not yet started? | 17:01 |
| spzala | well, we are there now :) | 17:02 |
| *** kzaitsev_mb has joined #openstack-app-catalog | 17:02 | |
| *** tej has quit IRC | 17:13 | |
| *** tej has joined #openstack-app-catalog | 17:13 | |
| *** tej has quit IRC | 17:17 | |
| *** spzala has quit IRC | 17:22 | |
| *** spzala has joined #openstack-app-catalog | 17:22 | |
| *** spzala_ has joined #openstack-app-catalog | 17:23 | |
| *** spzala has quit IRC | 17:27 | |
| *** spzala_ has quit IRC | 17:28 | |
| *** tej has joined #openstack-app-catalog | 17:29 | |
| *** kzaitsev_mb has quit IRC | 17:51 | |
| *** kebray has joined #openstack-app-catalog | 18:20 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 18:43 | |
| *** tej has quit IRC | 19:01 | |
| *** tej has joined #openstack-app-catalog | 19:02 | |
| *** tej has quit IRC | 19:02 | |
| *** tej has joined #openstack-app-catalog | 19:02 | |
| *** kebray has quit IRC | 19:31 | |
| *** spzala has joined #openstack-app-catalog | 19:35 | |
| *** kebray has joined #openstack-app-catalog | 20:07 | |
| *** kebray has quit IRC | 20:32 | |
| *** kzaitsev_mb has quit IRC | 20:33 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 20:43 | |
| *** tej has quit IRC | 21:01 | |
| *** tej has joined #openstack-app-catalog | 21:02 | |
| *** tej has quit IRC | 21:06 | |
| *** spzala has quit IRC | 21:18 | |
| *** spzala has joined #openstack-app-catalog | 21:18 | |
| *** spzala_ has joined #openstack-app-catalog | 21:22 | |
| *** spzala_ has quit IRC | 21:24 | |
| *** spzala_ has joined #openstack-app-catalog | 21:24 | |
| *** spzala has quit IRC | 21:24 | |
| *** spzala_ has quit IRC | 21:26 | |
| *** kebray has joined #openstack-app-catalog | 21:46 | |
| *** kebray has quit IRC | 22:38 | |
| *** tej has joined #openstack-app-catalog | 23:18 | |
| *** tej has quit IRC | 23:21 | |
| *** tej has joined #openstack-app-catalog | 23:21 | |
| *** tej has quit IRC | 23:28 | |
| *** tej has joined #openstack-app-catalog | 23:29 | |
| *** tej has quit IRC | 23:33 | |
| *** spzala has joined #openstack-app-catalog | 23:47 | |
| *** spzala has quit IRC | 23:51 | |
| *** kzaitsev_mb has quit IRC | 23:54 | |
| *** spzala has joined #openstack-app-catalog | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!