| openstackgerrit | Kevin Fox proposed openstack/app-catalog: WIP - Remove js yaml https://review.openstack.org/239539 | 00:20 |
|---|---|---|
| kfox1111 | docaedo: we need to fix this: | 00:24 |
| kfox1111 | You're seeing this error because you have DEBUG = True in your Django settings file. Change that to False, and Django will display a standard 404 page. | 00:24 |
| *** kebray has quit IRC | 00:24 | |
| docaedo | oops .. easiest fix is to set that false in settings.py (and we can modify when testing locally) | 00:25 |
| docaedo | I was just rebasing the unyaml one | 00:25 |
| docaedo | unless you want to | 00:26 |
| kfox1111 | I'm almost done rebasing. | 00:26 |
| kfox1111 | probably better to do it in local_settings.py | 00:27 |
| kfox1111 | thought that will take an infra patch. | 00:27 |
| docaedo | ok go ahead with your rebase | 00:27 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog: Cleanup - Remove js yaml, old index.html https://review.openstack.org/239539 | 00:27 |
| docaedo | and yeah, at this point in the day we're not going to get anyone to look at it, but it's not critical so it can get into the queue for next week (or the week after actually, considering the holidays and the backlog) | 00:27 |
| kfox1111 | yeah. I don't think having it wait till next week will be a problem. | 00:28 |
| kfox1111 | we don't have anything autenticated yet, so its all just read only anyway. | 00:28 |
| kfox1111 | k. I think the remove yaml/index one's ready. | 00:29 |
| docaedo | true | 00:30 |
| docaedo | I'll hold off on that debug patch for a little bit, see if we find any new excitement when we merge stuff | 00:30 |
| kfox1111 | k. | 00:30 |
| * docaedo looks at the yaml patch right now | 00:30 | |
| kfox1111 | thx | 00:31 |
| docaedo | looks like it works as expected! "GET /api/v1/assets" | 00:36 |
| kfox1111 | cool. | 00:37 |
| docaedo | so once that merges, we can also shut off the "build assets" trigger right? | 00:37 |
| kfox1111 | hmm... | 00:37 |
| docaedo | oh no, not yet - need to update app-catalog-ui to fix that right? | 00:37 |
| docaedo | update app-catalog-ui first I mean | 00:37 |
| kfox1111 | no, I think its opening the json file and just passing the raw bits through currently? | 00:38 |
| kfox1111 | we could parse the yaml and convert to json on the fly, but that woudl take up more processor at each request. | 00:38 |
| docaedo | true | 00:38 |
| kfox1111 | I think the current hook is probably the most efficient way. | 00:39 |
| docaedo | agreed, but now I am pretty sure we need to update tools/update_assets.sh then | 00:40 |
| openstackgerrit | Merged openstack/app-catalog: Cleanup - Remove js yaml, old index.html https://review.openstack.org/239539 | 00:41 |
| docaedo | oh no .. hmm, | 00:41 |
| kfox1111 | we could get rid of the gzip stuff out of it, or better, we could add support to the api to pass back the gzip'ed files if the headers say its gzip compatible. | 00:41 |
| kfox1111 | though as we add v2 support, we may revert gzip support then anyway.... | 00:42 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog: WIP - Pythonserver cleanup #1 https://review.openstack.org/239560 | 00:43 |
| docaedo | [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/openstack_catalog//web/static/scss | 00:51 |
| docaedo | sorry, that was not meaninful .. | 00:52 |
| docaedo | *meaningful | 00:52 |
| docaedo | seems like scss did not get copied when pip install ran, will see if I can figure out why | 00:53 |
| kfox1111 | on which command? | 00:54 |
| kfox1111 | the compress? | 00:55 |
| docaedo | yeah the compress command fails, but the issue is that scss directory exists in the repo as checked out, but when puppet runs pip install . in /opt/apps_site that directory does not get copied, seems like pip believes app_catalog v0.0.1 is already instealled | 00:56 |
| *** kzaitsev_mb has joined #openstack-app-catalog | 00:56 | |
| kfox1111 | ah... yeah... | 00:57 |
| docaedo | yeah I think the command in the puppet manifest should be pip install --upgrade . | 00:57 |
| kfox1111 | either we need... | 00:57 |
| kfox1111 | yeah, that would work. | 00:57 |
| kfox1111 | or we can bump the version. | 00:57 |
| kfox1111 | but we would have to remember to bump it each time. | 00:57 |
| kfox1111 | maybe we do both for now. bump for testing, and in the infra patch for debug=false, we change it to --upgrade too. | 00:58 |
| docaedo | wait a minute | 00:58 |
| docaedo | it's totally ignoring that scss directory even when I run pip uninstall openstack_catalog; pip install --upgrade . | 00:58 |
| kfox1111 | hmm... | 00:58 |
| docaedo | that doesn't make any sense .. will see what happens in venv | 00:59 |
| kfox1111 | I don't think I've tried an install of it before... just the testserver... | 00:59 |
| kfox1111 | usually that's a MANIFEST.in issue. | 00:59 |
| kfox1111 | but the rest of the files are getting copied I think, so I'm not sure why it would not those. | 00:59 |
| docaedo | yeah exactly, everything underneath that is getting installed so shouldn't need to specify that one diectory | 01:00 |
| docaedo | but confirmed, even in venv it does not grab that directory | 01:01 |
| docaedo | however, I need to step away probably for the night, will keep looking at it though next opportunity | 01:01 |
| kfox1111 | k. thanks. I'll try if I can get a few minutes too. | 01:01 |
| kfox1111 | have a good one. :) | 01:01 |
| docaedo | np you too | 01:01 |
| kfox1111 | scss is an empty directory on my host... | 01:02 |
| kfox1111 | compress is generating it maybe? | 01:02 |
| docaedo | oh! that would make sense maybe, if something is trying to create it and doesn't have permission | 01:04 |
| docaedo | (but now I'm really running, will be back later tonight though!) | 01:04 |
| kfox1111 | hmm... I guess I've never tried the code with a compress | 01:05 |
| kfox1111 | so there may be a bug there. | 01:05 |
| kfox1111 | so on my checkout, setting: | 01:08 |
| kfox1111 | COMPRESS_ENABLED = True | 01:08 |
| kfox1111 | COMPRESS_OFFLINE = True | 01:08 |
| kfox1111 | python manage.py compress | 01:08 |
| kfox1111 | seemes to work. | 01:08 |
| *** kzaitsev_mb has quit IRC | 01:39 | |
| *** j_king_ has joined #openstack-app-catalog | 02:18 | |
| *** reed has quit IRC | 02:18 | |
| *** j_king has quit IRC | 02:19 | |
| *** reed has joined #openstack-app-catalog | 02:19 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!