| kzaitsev_mb | kfox1111: sure, will do =) | 01:34 |
|---|---|---|
| *** kzaitsev_mb has quit IRC | 01:38 | |
| *** kebray has joined #openstack-app-catalog | 01:56 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 02:35 | |
| *** kzaitsev_mb has quit IRC | 02:39 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 03:36 | |
| *** kebray has quit IRC | 03:49 | |
| *** kzaitsev_mb has quit IRC | 04:05 | |
| docaedo | kfox1111: am alive, was on the move all day today, will test 226578 tomorrow morning. | 04:51 |
| docaedo | Also should have SSL sorted probably tomorrow | 04:52 |
| docaedo | and have been playing with flask, RAML and Ramses, looks like getting the first pass of the API stuff up and running won't be terribly difficult | 04:53 |
| docaedo | Was encouraged yesterday to take a look at how the OpenStack marketplace has integrated openstack ID stuff (so more homework for me :) ) | 04:54 |
| *** docaedo has quit IRC | 06:37 | |
| *** docaedo has joined #openstack-app-catalog | 06:43 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 07:47 | |
| *** kzaitsev_mb has quit IRC | 07:51 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 08:31 | |
| *** kzaitsev_mb has quit IRC | 09:10 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 10:30 | |
| *** kzaitsev_mb has quit IRC | 12:39 | |
| kfox1111 | docaedo: awesome. thanks. | 13:13 |
| *** kzaitsev_mb has joined #openstack-app-catalog | 13:35 | |
| docaedo | kfox1111: np, also will put in request for common elements repo today | 14:42 |
| *** kebray has joined #openstack-app-catalog | 15:26 | |
| kfox1111 | docaedo: awesome. thanks. | 15:30 |
| *** kebray has quit IRC | 15:30 | |
| kfox1111 | yeah, if we could reuse openstack id's that would be awesome. | 15:31 |
| kfox1111 | looks like the horizon heat env patch made it through. | 15:32 |
| kfox1111 | so we can do those features when we get a chance. | 15:32 |
| *** kebray has joined #openstack-app-catalog | 15:45 | |
| *** kebray has quit IRC | 15:46 | |
| *** kebray has joined #openstack-app-catalog | 15:50 | |
| *** kebray has quit IRC | 16:11 | |
| *** kebray has joined #openstack-app-catalog | 16:12 | |
| *** kebray has quit IRC | 16:35 | |
| *** kebray has joined #openstack-app-catalog | 16:40 | |
| *** kzaitsev_mb has quit IRC | 17:13 | |
| kfox1111 | docaedo: ok, so... I'm thinking that I want to add a new schema field at the root of an asset. asset_version. If it doesn't exist, its assumed to be 1. If greater then 1, then that specific asset will be marked as unsupported in horizon. | 17:33 |
| kfox1111 | so, say we don't support heat environments... (we don't at present). | 17:34 |
| kfox1111 | if we released our horizon plugin as it was today, then if we added a heat asset that required an environment to function properly, the asset would be broken in horizon. | 17:34 |
| kfox1111 | by saying asset_version: 2, then that heat resource would work on plugins that knew that schema, and exclude those that don't. | 17:35 |
| kfox1111 | we wouldn't need a whole new api version then each time we want to add a feature that required something of the plugin. | 17:36 |
| kfox1111 | what do you think? | 17:36 |
| * docaedo ponders | 17:46 | |
| kfox1111 | kind of a schema version per asset, rather hten on the whole asset file itself. | 17:47 |
| kfox1111 | fields that are added that arn't required will just kind of work. things that are added that are required to work, but horizon may not support in a given version bump the version so horizon plugin knows its not supported. | 17:48 |
| docaedo | I would say it couldn't hurt to add that, and it would definitely be helpful for the case you state | 17:49 |
| kfox1111 | k. let me code something up real quick for review. | 17:50 |
| docaedo | ok | 17:59 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog-ui: Handle an asset service schema version https://review.openstack.org/226920 | 18:24 |
| kfox1111 | k. I think that will do what we want. it will allow any asset to have a service.version to specify the supported schema version for that particular asset. | 18:26 |
| docaedo | nice, I'll take a look in the next few hours | 18:27 |
| kfox1111 | if its anything other then 1, then the horizon plugin marks it as unsupported. | 18:27 |
| kfox1111 | did you get a chance to look at the code cleanup review? | 18:28 |
| docaedo | no not yet but I will - stepping out for a minute, but will do that as soon as I get back | 18:38 |
| kfox1111 | k. thanks. | 18:41 |
| kfox1111 | I want to try and land basic heat environment support for 1.0 which shouldn't take long, and I'd like to add some minimum supported engine feature, but that may be too complicated... | 18:43 |
| *** kebray has quit IRC | 18:52 | |
| *** kebray has joined #openstack-app-catalog | 19:46 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 20:09 | |
| *** kzaitsev_mb has quit IRC | 20:18 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 20:23 | |
| *** kzaitsev_mb has quit IRC | 20:30 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 20:32 | |
| kfox1111 | really stuck on rdo doing things with my package submission request. :_( | 20:44 |
| docaedo | I am not sure I have any help to offer on that front unfortunately | 20:59 |
| docaedo | But SSL stuff is in progress at least: https://review.openstack.org/#/c/226984/ | 21:00 |
| kfox1111 | nice. thanks. | 21:10 |
| docaedo | Request for additional repo: https://review.openstack.org/#/c/226999/ | 21:13 |
| docaedo | I'll respond to your comments when I'm back from a late lunch, but the empty string sections were copied from the gerrit example (so might be OK that it's failing gate) | 21:18 |
| docaedo | and same goes for port 80 vs 443 - in my local test environment, it sets up both of them and listens on both of them. I'm not sure about the port line though, maybe I can specify both (but TBH the other examples I saw showed only one port, but web sites listening on both) | 21:19 |
| docaedo | oh man 0 for 2, second commit failed gate too! | 21:20 |
| kfox1111 | did you start with a fresh test server? for the port 80 vs 443 thing? (Not sure how that workflow works. never done it) | 21:22 |
| docaedo | damn confusing alphabet :/ Additional repo request should pass gate now. | 21:23 |
| docaedo | kfox1111: did not start with a fresh server, will verify that shortly | 21:24 |
| kfox1111 | I'm guessing it will work until its fresh, then it might break. | 21:24 |
| *** kzaitsev_mb has quit IRC | 21:30 | |
| *** kebray has quit IRC | 21:34 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 21:34 | |
| kzaitsev_mb | I have a commit ready, that adds elint checks to app-catalog-ui, but... my mac has updated xcode and npm install now fails with ugly errors =) I guess I'm about to recompile some stuff | 21:35 |
| kzaitsev_mb | I've also noticed, that we don't have any tests in app catalog-ui =) doesn't look good. might dive in that sometime in the future. anyway I wanted to dive into tox magic a bit more | 21:37 |
| kfox1111 | awesome, sucks about the errors, and awesome. :) | 21:40 |
| kfox1111 | docaedo: have any of the frameworks you've looked at do js compression and scss? | 21:56 |
| openstackgerrit | Kirill Zaitsev proposed openstack/app-catalog-ui: Add eslint checking machinery https://review.openstack.org/227026 | 21:57 |
| kfox1111 | kzaitsev_ws: commented in the review. | 22:02 |
| kzaitsev_mb | sure =) | 22:04 |
| kzaitsev_mb | Not really sure if that would ever break anything, since it's unlikely anyone would install app-catalog npm package and app-catalog-ui npm package in the same env =)) but nice to be consistent there =) | 22:05 |
| openstackgerrit | Kirill Zaitsev proposed openstack/app-catalog-ui: Add eslint checking machinery https://review.openstack.org/227026 | 22:06 |
| kfox1111 | sure. :) | 22:06 |
| kfox1111 | docaedo: kind of wondering if we should just use django for the root of the apps site so that we can share all the compress/xstatic stuff with horizon. might make things easier? we could still use flask for /api, and django would just be handing out the static files it generated? | 22:12 |
| kzaitsev_mb | ok, since you've +A'ed it I can continue with infra commit | 22:13 |
| kzaitsev_mb | or we can 1st fix the issues, to make the job voting outright | 22:13 |
| kzaitsev_mb | I think I like the 2d idea — fix the issues, since there's only 1 file and like 30 something errors | 22:14 |
| kfox1111 | all the issues I ran into were fixme's that were things I want to fix at some point, but aren't like a 10 minute thing. nothing broken exactly, just less then ideal. | 22:15 |
| kfox1111 | so if we can ignore the fixme's I think we're really close. | 22:15 |
| kzaitsev_mb | those would be warnings — should be ok now | 22:15 |
| kzaitsev_mb | eslint would print them, but would exit with 0 code if there are no erros | 22:16 |
| *** openstackgerrit has quit IRC | 22:16 | |
| *** openstackgerrit has joined #openstack-app-catalog | 22:16 | |
| kfox1111 | yeah. at least on version of eslint I'm running, they are all warnings now. | 22:21 |
| kfox1111 | I was using horizon's eslint config though. | 22:22 |
| kzaitsev_mb | I see some camelcase and for-in errors. should be rather trivial to change | 22:22 |
| kfox1111 | I thought I fixed all of those... | 22:23 |
| kfox1111 | are you running from the the eslint fix all errors review? | 22:23 |
| kfox1111 | https://review.openstack.org/#/c/226578/ | 22:24 |
| kfox1111 | I'm waiting for someone with a working murano-dashboard/engine to verify it doesn't break anything. | 22:24 |
| kfox1111 | it seemes to be happy on my box but I did touch an aweful lot of code, which could break something unexpectedly. | 22:24 |
| kzaitsev_mb | It just struck me, that I didn't update my dahsboard after project rename | 22:25 |
| kzaitsev_mb | dang | 22:25 |
| kfox1111 | doh. :) | 22:25 |
| kfox1111 | do you have murano-dashboard and the ui plugin installed still? | 22:27 |
| kzaitsev_mb | yep | 22:27 |
| kfox1111 | could you give that review a try? | 22:28 |
| kzaitsev_mb | you mean 226578 — to check against murano dashboard? | 22:28 |
| kzaitsev_mb | sure. just only need to re-enable the plugin | 22:29 |
| kfox1111 | yeah. | 22:29 |
| kfox1111 | thx. | 22:31 |
| kzaitsev_mb | oh damn. I need to reconfigure my vpn first =( | 22:32 |
| kfox1111 | :/ | 22:32 |
| kzaitsev_mb | security guys enabled 2-factor auth recently ) | 22:32 |
| kzaitsev_mb | and I'm used to using remote cloud =) | 22:33 |
| kfox1111 | ah. fun. yeah, I've got a securid around my neck... | 22:33 |
| *** kebray has joined #openstack-app-catalog | 22:38 | |
| kzaitsev_mb | hm. it's stuck in checking for murano packages. the status I mean | 22:46 |
| kzaitsev_mb | and works on master just fine | 22:47 |
| kfox1111 | do you have a fairly new murano-dashboard? | 22:48 |
| kzaitsev_mb | yep | 22:48 |
| kfox1111 | is this in the history: https://review.openstack.org/#/c/218515/ | 22:51 |
| kzaitsev_mb | sure, it would say Unsupported, if there were no api | 22:52 |
| kzaitsev_mb | as far as I remember | 22:52 |
| kfox1111 | I would think... | 22:54 |
| kfox1111 | if you hit f12 and refresh, do you see an error code back from the murano packages call? | 22:55 |
| kfox1111 | or not see that call at all? | 22:55 |
| kzaitsev_mb | I think I do not see the call at all. (checking browser logs) | 22:56 |
| kfox1111 | On my box, I see the rest call/response, I can click install on the artifact, and it pops up the murano wizard with the correct package name. | 22:58 |
| kfox1111 | are you getting that far? | 22:58 |
| kfox1111 | if I try and load it, I get: Can't find Package name from repository. | 22:59 |
| kfox1111 | though I'm running a pretty old murano at this point. | 23:00 |
| kzaitsev_mb | huh =) that's strange =) | 23:00 |
| kzaitsev_mb | with master everything works fine, when I rebase on linted commit I get | 23:01 |
| kfox1111 | hmm.... If I remember correctly, murano had an updated enable file to make rest work. did you install that? | 23:01 |
| kfox1111 | murano-dashboard I mean. | 23:01 |
| kzaitsev_mb | https://www.dropbox.com/s/d0ujjxk48yzwzrb/Screenshot%202015-09-24%2002.02.15.png?dl=0 | 23:02 |
| kzaitsev_mb | sure, Like I said — with master I'm able to download asset and install it normally | 23:02 |
| kfox1111 | yeah... seems like the rest call. interesting. | 23:02 |
| kzaitsev_mb | wait, do you use master horizon? | 23:04 |
| kfox1111 | yeah. | 23:04 |
| kfox1111 | they've done a huge amount of refactoring in liberty to get angular working more smoothly. | 23:04 |
| kfox1111 | so has_murano will only be set if something's defining horizon.app.core.openstack-service-api.murano | 23:05 |
| kfox1111 | if has_murano's defined, then it calls getPackages on that module... which does the rest call.. | 23:07 |
| kfox1111 | I'm not sure why you would ever see the checking without seeing a murano package call. | 23:08 |
| kzaitsev_mb | I think I've found the error | 23:08 |
| kfox1111 | cool. whatcha thinking? | 23:08 |
| docaedo | regarding app catalog SSL - I wiped everything and ran puppet apply, works great :) also verified a few other sites that only note port 443 also listen on 80 (because whats in the template matters the most) | 23:08 |
| kfox1111 | odd. ok. | 23:09 |
| kzaitsev_mb | https://review.openstack.org/#/c/226578/1/app_catalog/static/dashboard/project/app_catalog/app_catalog.js take a look | 23:09 |
| kfox1111 | I wonder what that code does then. | 23:09 |
| kfox1111 | kzaitsev_mb: around where? :) | 23:10 |
| kzaitsev_mb | angular.forEach(definitions, function(definition) | 23:10 |
| kzaitsev_mb | 268 line =) | 23:10 |
| kzaitsev_mb | sry for not pointing | 23:10 |
| kfox1111 | nm. I see your comment. | 23:10 |
| kfox1111 | sec. | 23:10 |
| kzaitsev_mb | eslint doesn't catch all after all =( | 23:11 |
| kfox1111 | yeah.... | 23:14 |
| kfox1111 | it wanted me to pull d out, before I fixed the for in errors, then didn't complain when it was orphaned.... | 23:14 |
| kfox1111 | lame. | 23:14 |
| kzaitsev_mb | strange. I thought the default configuration would complain about orphaned variables. or maybe I'm already used to openstack-eslint-conf | 23:15 |
| kfox1111 | yeah. good catch. let me fix that error... | 23:16 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog-ui: Fix all lint errors https://review.openstack.org/226578 | 23:17 |
| kfox1111 | have a look at that one. | 23:17 |
| kfox1111 | ah... I think I didn't hit that because I don't have any packages defined at the moment. | 23:18 |
| kfox1111 | we're going to have to write angular tests at some point too... | 23:19 |
| kzaitsev_mb | or maybe I'm thinging about shellcheck... | 23:20 |
| kzaitsev_mb | yep, seems to work now | 23:21 |
| kfox1111 | awesome. thanks. :) | 23:23 |
| docaedo | I'm running devstack with murano and the patch from 226578 (and will share the script I have that gives you devstack with murano and app-catalog-ui in one sec) | 23:25 |
| *** kebray has quit IRC | 23:25 | |
| kfox1111 | docaedo: cool. thanks. | 23:27 |
| docaedo | This is pretty handy, gets you devstack, neutron, murano, app-catalog-ui in a single-nic VM - http://paste.openstack.org/show/473814/ | 23:27 |
| kfox1111 | nice. :) | 23:27 |
| docaedo | (I should put that up on github somewhere really, since I have to tweak it now and then when something changes in devstack) | 23:27 |
| kfox1111 | ok... ok... now, stick the contents of that pastebin into a heat template, and contribute it to the app catalog please. :) | 23:28 |
| docaedo | hahaha, not a half bad idea :D | 23:28 |
| kfox1111 | self hosting! :) | 23:28 |
| docaedo | ah see, already noticed my paste has a mistake :( Should have FLOATING_RANGE="$NET.0/24" near the bottom. Still works as-is but technically it's not correct | 23:31 |
| kfox1111 | still testing? | 23:36 |
| docaedo | oh I think you might have pushed an update after I kicked it off, let me see which ref I used | 23:38 |
| kfox1111 | k. | 23:38 |
| docaedo | yep, but this one should come up faster since most everything is cached. So running that again... | 23:40 |
| kfox1111 | yay/nay? :) | 23:51 |
| docaedo | yay! | 23:51 |
| docaedo | just tried it, works great! | 23:51 |
| kfox1111 | awesome. thanks. :) | 23:51 |
| docaedo | OK for me to +2? | 23:51 |
| kfox1111 | yes please. | 23:52 |
| docaedo | er, +2 and workflow I mean | 23:52 |
| docaedo | I'm on it, nice work | 23:52 |
| kfox1111 | still a long way to go, but starting to clean up a bit. | 23:52 |
| openstackgerrit | Merged openstack/app-catalog-ui: Fix all lint errors https://review.openstack.org/226578 | 23:53 |
| kfox1111 | arg... how strange gerrit doesn't rebase automatically for trivial things... | 23:54 |
| kfox1111 | oh well. here comes the rebase dance... :) | 23:54 |
| kfox1111 | at least that is a button press in that case... | 23:55 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog-ui: Use protocol used for horizon to get assets https://review.openstack.org/226590 | 23:55 |
| openstackgerrit | Merged openstack/app-catalog-ui: Use protocol used for horizon to get assets https://review.openstack.org/226590 | 23:56 |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog-ui: Add missing images https://review.openstack.org/226593 | 23:57 |
| openstackgerrit | Merged openstack/app-catalog-ui: Add missing images https://review.openstack.org/226593 | 23:58 |
| kfox1111 | ok. that gets us most of the way caught up. | 23:58 |
| kfox1111 | docaedo: how about: https://review.openstack.org/#/c/226920/ | 23:58 |
| docaedo | kfox1111: happen to be re-running devstack right this instant to validate that | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
