| *** kzaitsev_mb has joined #openstack-app-catalog | 00:10 | |
| *** kzaitsev_mb has quit IRC | 00:26 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 01:22 | |
| *** kzaitsev_mb has quit IRC | 01:27 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 06:13 | |
| *** kzaitsev_mb has quit IRC | 07:11 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 07:11 | |
| *** kzaitsev_mb has quit IRC | 08:38 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 08:44 | |
| *** kzaitsev_mb has quit IRC | 08:49 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 09:56 | |
| *** kzaitsev_mb has quit IRC | 10:36 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 10:41 | |
| *** kzaitsev_mb has quit IRC | 11:37 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 12:33 | |
| kzaitsev_mb | hm, what did we decide about murano bundles? | 12:56 |
|---|---|---|
| kzaitsev_mb | sorting is currently broken for format, as far as I see | 12:57 |
| docaedo | AFAIK we were not going to change/impact Murano bundles, | 13:02 |
| docaedo | when you say sorting it broken, do you mean as rendered on th web page? | 13:02 |
| kzaitsev_mb | yep | 13:02 |
| kzaitsev_mb | It seems that the same is true for all Format columns | 13:02 |
| kzaitsev_mb | I'll propose a fix for both issues shortly ) | 13:03 |
| docaedo | ah I see what you mean | 13:04 |
| docaedo | thanks for working on a fix | 13:04 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/apps-catalog: Restore sorting by format for murano packages https://review.openstack.org/215615 | 13:08 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/apps-catalog: Restore format sorting for glance/heat https://review.openstack.org/215619 | 13:13 |
| kzaitsev_mb | murano sorting is a bit trickier, since kevin wanted bundles to be top-level. So I had to restore the property in the yaml | 13:13 |
| kzaitsev_mb | heat/glance is a really simple fix | 13:14 |
| kzaitsev_mb | wonder if there's a way to pass a callable there, will take a look | 13:18 |
| docaedo | kzaitsev_mb: thanks for those fixes, I took a look and I think they're good, gave them my +2. Want kfox1111 to take a quick look too though | 13:42 |
| docaedo | (but it's simple, and restores what used to work, so I can't imagine there will be an issue) | 13:42 |
| docaedo | I think you brought this up the other day but I don't recall what resolution there was - with the schema changes that have been made, was the wiki page with examples updated to be consistent? | 13:43 |
| kzaitsev_mb | I imagine he might be opposed to murano commit, since it restores a property in the yaml | 13:43 |
| kzaitsev_mb | docaedo: not yet, was planning to attend it today though | 13:43 |
| docaedo | kzaitsev_mb: nice, thanks! | 13:44 |
| kzaitsev_mb | I'm still looking into the js code. I imagine there might be a way to make it a bit more universal, without restoring the yaml property | 13:44 |
| kzaitsev_mb | but can't find it yet | 13:44 |
| kfox1111 | morning. | 14:40 |
| openstackgerrit | Merged stackforge/apps-catalog: Restore format sorting for glance/heat https://review.openstack.org/215619 | 14:50 |
| kzaitsev_mb | kfox1111: nice idea with patching. I've been trying to deal with js, but your idea feels easier to implement | 15:01 |
| kfox1111 | the code in that position would be the same if it was json or yaml. everything in js is json. :) | 15:02 |
| kfox1111 | should be fairly simple to just walk the list at that point and if the service.type is 'bundle' then add the service.format='bundle' thing. | 15:03 |
| kfox1111 | would be nice to remove the jsyaml stuff and switch the ajax call to just hit the json files too. save on using a non native parser. | 15:04 |
| *** kzaitsev_mb has quit IRC | 15:12 | |
| kfox1111 | I think I fixed up the murano wiki entry. | 15:19 |
| *** kzaitsev_mb has joined #openstack-app-catalog | 15:29 | |
| openstackgerrit | Kirill Zaitsev proposed stackforge/apps-catalog: Restore sorting by format for murano packages https://review.openstack.org/215615 | 15:46 |
| kfox1111 | kzaitsev_mb: looks good. thanks. :) | 15:59 |
| kzaitsev_mb | =) | 16:02 |
| openstackgerrit | Merged stackforge/apps-catalog: Restore sorting by format for murano packages https://review.openstack.org/215615 | 16:40 |
| *** kzaitsev_mb has quit IRC | 16:56 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 16:59 | |
| *** kzaitsev_mb has quit IRC | 17:05 | |
| *** kebray has joined #openstack-app-catalog | 18:58 | |
| *** kebray has quit IRC | 19:10 | |
| *** kebray has joined #openstack-app-catalog | 19:11 | |
| *** kebray_ has joined #openstack-app-catalog | 19:19 | |
| *** kebray has quit IRC | 19:19 | |
| *** kebray_ has quit IRC | 20:56 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 21:04 | |
| *** kzaitsev_mb has quit IRC | 22:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!