| *** kzaitsev_mb has joined #openstack-app-catalog | 07:14 | |
| *** kzaitsev_mb has quit IRC | 07:53 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 07:53 | |
| kzaitsev_mb | kfox1111: docaedo: hm seems, that we haven't kept https://wiki.openstack.org/wiki/App-Catalog#How_to_contribute up to date in regards of schema files. Are you guys watching the changes on the page? (Just want to be sure, that my changes would get some review) | 07:56 |
|---|---|---|
| kzaitsev_mb | also looks like we can safely remove the extra .schema.yaml files, so they would not lie around and confuse folks | 07:57 |
| *** kzaitsev_mb has quit IRC | 08:35 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 10:26 | |
| kzaitsev_mb | kfox1111: If I were you I would change the 1st line of the commit message to horizon | 10:58 |
| kzaitsev_mb | "A few tweaks to make the App Catalog plugin work." sounds like a hack to me. And most likely Cores would ignore this commit for a long time (and FF is 2 weeks away) | 10:59 |
| kzaitsev_mb | Maybe we should go with something like "Allow passing parameters to forms through GET-parameters" | 11:04 |
| *** kzaitsev_mb has quit IRC | 11:42 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 12:02 | |
| kfox1111 | kzaitsev_mb: sure. not sure what to call it though. | 12:48 |
| kfox1111 | open to suggestions. | 12:48 |
| kzaitsev_mb | well I like to refer to https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages | 12:50 |
| kzaitsev_mb | when I'm in doubt | 12:50 |
| kzaitsev_mb | I feel, that something like "Allow passing parameters to forms through request-parameters" mostly explains what's happening | 12:51 |
| kzaitsev_mb | maybe just "Pass request-parameters to forms initials" | 12:54 |
| kfox1111 | it also adds a heat resource too. | 12:55 |
| kzaitsev_mb | yep, and we don't want to split the commit, since it would take another eternity to make it land 0 | 12:56 |
| kzaitsev_mb | ) | 12:56 |
| kfox1111 | Pass request params to initial forms and add initial HeatAPI? | 12:56 |
| kfox1111 | yeah. | 12:56 |
| kzaitsev_mb | no, If I were a core I would tell you to split, after reading that line ) | 12:57 |
| kfox1111 | I have at least one core on board. | 12:58 |
| kfox1111 | as is. | 12:58 |
| kzaitsev_mb | =) | 12:58 |
| kzaitsev_mb | yeah, the change seems generally good, even not regarding the app-catalog | 12:58 |
| kfox1111 | so whats a short enough description that would fit in the short line, but also not imply wanting to split the patch? | 13:02 |
| kzaitsev_mb | Why do we need heat-service, btw? | 13:02 |
| kzaitsev_mb | to validate templates before launching them, right? | 13:03 |
| kfox1111 | it checks the heat templates against the heat engine to see if they will work on the specific cloud. It changes the Launch button to "Unsupported" | 13:04 |
| kfox1111 | Could be used to hide the entry entirely too. | 13:04 |
| kzaitsev_mb | dang, yep, does look like 2 unrelated changes in that commit ) | 13:04 |
| kzaitsev_mb | We could go with "Allow passing parameters to forms" and mention Heat inside the commit message itself | 13:05 |
| kzaitsev_mb | I guess | 13:06 |
| kfox1111 | I was hoping to get it though quickly, so it would't be an issue. but it seems nothing in openstack goes quickly. :/ | 13:06 |
| kzaitsev_mb | not in horizon anyway, yeah | 13:06 |
| kfox1111 | the code refactoring really really slowed things down. | 13:07 |
| kfox1111 | I was rebasing several times a day for a while. :/ | 13:07 |
| kzaitsev_mb | unless it is aligned with https://etherpad.openstack.org/p/YVR-horizon-liberty-priorities | 13:07 |
| kfox1111 | yeah. | 13:07 |
| kzaitsev_mb | so maybe splitting is a fine idea then? | 13:08 |
| kfox1111 | on the fence on that. Is it easier to attract core reviewers on two seperate reviews? :/ | 13:08 |
| kfox1111 | or does that make it harder? | 13:08 |
| kzaitsev_mb | not really sure | 13:09 |
| kzaitsev_mb | would be away for some time now | 13:10 |
| kfox1111 | kzaitsev_mb: I just changed the word tweak to fixes. maybe that's good enough? | 13:34 |
| kfox1111 | david-lyle said its probably fine having the two things in one patch. | 13:34 |
| kfox1111 | he also just bumped the priority of it. so feeling a little better about it. | 13:50 |
| kzaitsev_mb | kfox1111: great! =) twas smart of you to ask in around in horizon, too! let's hope this would get the patch some traction ) | 14:12 |
| kzaitsev_mb | docaedo: we should configure openstackgerrit to spam this channel with apps-catalog-ui commits +) | 14:12 |
| kzaitsev_mb | oh wait it's horizon | 14:13 |
| kfox1111 | yeah. we do get notifications for apps-catalog-ui. | 15:27 |
| kfox1111 | I've got one more bug in horizon to fix and then I think the new grid view's ready to merge. | 16:20 |
| kfox1111 | https://youtu.be/7cOVCCjYjJs | 16:20 |
| kfox1111 | docaedo: Can you research how to do proper releases in openstack? | 16:23 |
| kfox1111 | docaedo: also, http://docs.openstack.org/developer/horizon/plugins.html :) | 16:26 |
| *** kzaitsev_mb has quit IRC | 16:37 | |
| *** rhagarty has quit IRC | 17:03 | |
| *** rhagarty_ has quit IRC | 17:04 | |
| *** rhagarty_ has joined #openstack-app-catalog | 17:04 | |
| *** rhagarty has joined #openstack-app-catalog | 17:04 | |
| *** rhagarty has quit IRC | 17:10 | |
| *** rhagarty has joined #openstack-app-catalog | 17:10 | |
| kfox1111 | rhagarty: I see http://docs.openstack.org/developer/horizon/plugins.html is alive. | 17:24 |
| kfox1111 | probably should submit a patch for your plugin? | 17:24 |
| kfox1111 | well, looking more and more like I'll be able to get to Tokyo. :) | 17:35 |
| rhagarty | kfox1111: thanks for that link - do you know if I need to move my package into openstack or stackforge (which seems to be the standard)? Mine is currently in hp-storage | 18:16 |
| kfox1111 | no clue. depends on how you want to run the project I guess. | 18:17 |
| rhagarty | kfox1111: ok - thanks | 18:17 |
| *** kebray has joined #openstack-app-catalog | 18:46 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 19:54 | |
| *** kzaitsev_mb has quit IRC | 23:29 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 23:32 | |
| docaedo | kfox1111: will do some learning about releases, I assume for the UI plugin. | 23:35 |
| docaedo | great news to hear there's a good chance for Tokyo too! | 23:35 |
| docaedo | I'll have .. limited time for probably the next week, but will squeeze in research and such as much as possible | 23:35 |
| *** kzaitsev_mb has quit IRC | 23:38 | |
| *** kebray has quit IRC | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!