| *** Apoorva has quit IRC | 00:26 | |
| openstackgerrit | Merged openstack/api-wg: Add the description of GET method https://review.openstack.org/185180 | 00:52 |
|---|---|---|
| *** salv-orlando has quit IRC | 01:03 | |
| *** shangxdy has joined #openstack-api | 01:58 | |
| *** salv-orlando has joined #openstack-api | 02:04 | |
| *** salv-orlando has quit IRC | 02:16 | |
| *** annegentle has quit IRC | 02:28 | |
| *** annegentle has joined #openstack-api | 02:33 | |
| *** shangxdy has quit IRC | 03:16 | |
| *** annegentle has quit IRC | 03:17 | |
| *** Apoorva has joined #openstack-api | 03:21 | |
| *** salv-orlando has joined #openstack-api | 03:28 | |
| *** salv-orlando has quit IRC | 03:38 | |
| *** annegentle has joined #openstack-api | 03:48 | |
| *** annegentle has quit IRC | 04:09 | |
| *** HenryG has quit IRC | 04:09 | |
| *** HenryG has joined #openstack-api | 04:12 | |
| *** etoews has quit IRC | 04:17 | |
| *** Apoorva has quit IRC | 04:26 | |
| *** vishwana_ has quit IRC | 04:45 | |
| *** terrylhowe has quit IRC | 05:42 | |
| *** salv-orlando has joined #openstack-api | 05:43 | |
| *** salv-orlando has quit IRC | 05:48 | |
| *** Apoorva has joined #openstack-api | 05:51 | |
| *** woodster_ has quit IRC | 06:22 | |
| *** fzdarsky|afk has joined #openstack-api | 06:34 | |
| *** fzdarsky|afk is now known as fzdarsky | 06:37 | |
| *** Apoorva has quit IRC | 06:51 | |
| *** salv-orlando has joined #openstack-api | 06:56 | |
| *** e0ne has joined #openstack-api | 07:14 | |
| *** subscope has quit IRC | 07:41 | |
| *** alex_klimov has joined #openstack-api | 07:46 | |
| *** cdent has joined #openstack-api | 07:48 | |
| *** subscope has joined #openstack-api | 07:56 | |
| openstackgerrit | Chris Dent proposed openstack/api-wg: Add advice on when to use POST or PUT in create https://review.openstack.org/181912 | 08:08 |
| * cdent smh | 08:08 | |
| *** subscope has quit IRC | 08:09 | |
| *** lucasagomes has joined #openstack-api | 08:11 | |
| *** subscope has joined #openstack-api | 08:25 | |
| *** alex_klimov has quit IRC | 08:26 | |
| *** alex_klimov has joined #openstack-api | 08:37 | |
| *** fzdarsky_ has joined #openstack-api | 10:32 | |
| *** fzdarsky has quit IRC | 10:35 | |
| *** terrylhowe has joined #openstack-api | 11:50 | |
| *** jaypipes has joined #openstack-api | 11:56 | |
| *** annegentle has joined #openstack-api | 13:14 | |
| *** annegentle has quit IRC | 13:36 | |
| *** annegentle has joined #openstack-api | 13:36 | |
| *** jaypipes has quit IRC | 13:37 | |
| *** woodster_ has joined #openstack-api | 13:55 | |
| *** jaypipes has joined #openstack-api | 13:56 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:08 | |
| sigmavirus24 | psssst | 14:31 |
| *** terrylhowe has left #openstack-api | 14:31 | |
| *** briancurtin has quit IRC | 14:31 | |
| *** briancurtin has joined #openstack-api | 14:31 | |
| sigmavirus24 | Currently if you make a GET request to glance with a body, it returns a 500. Would y'all say that Glance should instead return 400 (Bad Request) or 200 OK with the regular body for a GET to that endpoint | 14:31 |
| sigmavirus24 | e.g., GET /v2/images (with a body) => 500 currently. Would you instead prefer GET /v2/images (with a body) => 400 or GET /v2/images (with a body) => 200 (with images listed) | 14:32 |
| ryansb | I'd say 400 | 14:34 |
| ryansb | since GET isn't allowed to have a body | 14:34 |
| ryansb | weird that the wsgi framework doesn't auto-400 in that case | 14:35 |
| kragniz | ryansb: where is GET disallowed a body? | 14:36 |
| * ryansb digs | 14:37 | |
| sigmavirus24 | ryansb: spoiler, it isn't disallowed | 14:37 |
| sigmavirus24 | ryansb: GETs with a body are semantically meaningless | 14:37 |
| sigmavirus24 | GETs are allowed a body by the RFCs | 14:37 |
| sigmavirus24 | In fact, every method *may* have a body. The body may just be semantically meaningless | 14:37 |
| ryansb | argh, yeah that's what I'm gleaning from 7231 | 14:39 |
| sigmavirus24 | It's been that way since at least 2616 | 14:39 |
| sigmavirus24 | This is why elasticsearch can use bodies on a GET | 14:39 |
| sigmavirus24 | They define the semantics for their server | 14:39 |
| sigmavirus24 | *their application | 14:40 |
| ryansb | https://tools.ietf.org/html/rfc7231#section-4.3.1 | 14:40 |
| sigmavirus24 | ryansb: right, and given the behaviour of load balancers/proxies (which often strip out bodies from GETs) I would say this should be a 200, no? | 14:40 |
| ryansb | yeah. Well there's no RFC that says I can't grumble about GETs with bodies being wrong | 14:40 |
| ryansb | I want to still vote 400, but I'm only about a 3/10 on strength-of-opinion | 14:41 |
| sigmavirus24 | Yeah | 14:41 |
| sigmavirus24 | I feel both responses are correct | 14:41 |
| ryansb | I'd be against projects defining their own GET-with-body semantics, so having them hard-400 would be a better disincentive to stuffing meaning into them | 14:42 |
| sigmavirus24 | it's up to the service but I think that having different behaviour based on how youv'e deployed your application is wrong | 14:42 |
| ryansb | +1 | 14:42 |
| sigmavirus24 | ryansb: or just saying "GETs with a body should ignore the body and do what they would without it" | 14:42 |
| ryansb | yeah, or that | 14:43 |
| sigmavirus24 | So the caveat here is that openstack/searchlight is building atop elasticsearch =P | 14:43 |
| kragniz | some proxies will also strip the body | 14:43 |
| kragniz | sigmavirus24: shhhh | 14:43 |
| * sigmavirus24 enjoys throwing monkey-wrenches into discussions | 14:43 | |
| * sigmavirus24 is a troll | 14:43 | |
| ryansb | why can't everything be glorious and standardized, so we can go to the beach? | 14:44 |
| sigmavirus24 | ryansb: because RFCs are simply requests for comments, not standards that people enforce =P | 14:44 |
| sigmavirus24 | I want to be an RFC Cop | 14:44 |
| sigmavirus24 | Someone hire me as an RFC Cop kthnxbai | 14:44 |
| *** vishwanathj has joined #openstack-api | 14:44 | |
| ryansb | lol sigmavirus24++ | 14:45 |
| kragniz | something something the sigmavirus24 we deserve | 14:45 |
| sigmavirus24 | "The virus we deserve" | 14:46 |
| ryansb | if you ever start an infosec company, that should be on the biz cards | 14:46 |
| sigmavirus24 | lol | 14:49 |
| elmiko | i vote 400 on a get with body, since the client could change their behavior to stop the error | 14:53 |
| *** annegentle has quit IRC | 14:56 | |
| *** alex_klimov has quit IRC | 15:00 | |
| *** alex_xu has quit IRC | 15:10 | |
| *** alex_xu has joined #openstack-api | 15:11 | |
| *** annegentle has joined #openstack-api | 15:18 | |
| *** annegentle has quit IRC | 15:18 | |
| *** annegentle has joined #openstack-api | 15:19 | |
| *** sdague has quit IRC | 15:26 | |
| *** sdague has joined #openstack-api | 15:30 | |
| *** ameade has quit IRC | 16:08 | |
| *** ameade has joined #openstack-api | 16:08 | |
| *** Apoorva has joined #openstack-api | 16:14 | |
| *** e0ne has quit IRC | 16:53 | |
| *** lucasagomes has quit IRC | 17:07 | |
| *** vishwanathj has quit IRC | 17:15 | |
| *** e0ne has joined #openstack-api | 17:35 | |
| *** vishwanathj has joined #openstack-api | 17:51 | |
| *** e0ne has quit IRC | 17:51 | |
| *** e0ne has joined #openstack-api | 18:42 | |
| *** jaypipes has quit IRC | 18:44 | |
| *** fzdarsky_ has quit IRC | 18:44 | |
| *** bitblt has joined #openstack-api | 18:55 | |
| *** bitblt has quit IRC | 18:58 | |
| *** cdent has quit IRC | 18:59 | |
| *** jaypipes has joined #openstack-api | 19:16 | |
| *** jaypipes has quit IRC | 19:16 | |
| *** annegentle has quit IRC | 19:37 | |
| *** e0ne has quit IRC | 20:04 | |
| *** annegentle has joined #openstack-api | 20:09 | |
| *** annegentle has quit IRC | 20:11 | |
| *** annegentle has joined #openstack-api | 20:12 | |
| *** annegentle has quit IRC | 20:13 | |
| *** annegentle has joined #openstack-api | 20:13 | |
| *** Apoorva has quit IRC | 20:37 | |
| *** Apoorva has joined #openstack-api | 20:50 | |
| *** e0ne has joined #openstack-api | 20:51 | |
| *** e0ne has quit IRC | 20:55 | |
| *** annegent_ has joined #openstack-api | 21:02 | |
| *** annegentle has quit IRC | 21:05 | |
| *** e0ne has joined #openstack-api | 21:12 | |
| *** e0ne has quit IRC | 21:38 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 21:43 | |
| *** etoews has joined #openstack-api | 21:54 | |
| *** annegent_ has quit IRC | 22:47 | |
| *** Apoorva has quit IRC | 23:43 | |
| *** salv-orlando has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!