| f0o | Very stupid question; how can I reset my gerrit credentials? | 07:07 |
|---|---|---|
| f0o | I'm almost through with all the sysctl changes and would like to post those patches | 07:07 |
| f0o | or can I just post them to GH and offload that burden to you? haha | 07:12 |
| frickler | f0o: no, submissions can only be accepted via gerrit. that said, the credentials are actually managed via your ubuntu one account. what exactly is your issue? | 07:30 |
| f0o | oh then I must've been a doofus | 07:32 |
| f0o | nvmd | 07:32 |
| frickler | (except if you are submitting via https, then it is a mixed situation, but I wouldn't recommend that) | 07:33 |
| f0o | I also noticed that a lot of 3rd party modules dont allow setting custom sysctl_file parameters... like ansible-hardening, keepalived, haproxy - while others like ceph actually does it by default which is great! | 07:33 |
| f0o | but I patched swift, hosts, horizon modules to allow openstack_sysctl_file parameters | 07:33 |
| f0o | gonna post the patches to those three after the coffee hits and I become less doofus | 07:34 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-os_horizon master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-os_horizon/+/939599 | 08:09 |
| f0o | I did a thing! | 08:09 |
| opendevreview | Daniel Preussker proposed openstack/ansible-hardening master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/ansible-hardening/+/939600 | 08:10 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-haproxy_server master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/939601 | 08:11 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-openstack_hosts master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/939602 | 08:11 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-os_swift master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/939603 | 08:12 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-lxc_hosts master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/939604 | 08:14 |
| f0o | I left out systemd_networkd as it seem reasonable enough to keep in /etc/sysctl.conf (enable forwarding) to override everything in /etc/sysctl.d/* | 08:15 |
| f0o | unfortunately keepalived will add 2 lines (non-local bind) to etc/sysctl.conf as well because its a 3rd party module (or I cant find it on gitea) - but that's reasonably safe too | 08:16 |
| f0o | Tested against one of our hosts and it does create whatever I set in user_variables as openstack_sysctl_file (/etc/sysctl.d/99-osa.conf in my case) | 08:17 |
| f0o | lxc_container_create has a test case for a sysctl value but it doesnt set it anywhere which is odd; so I didnt alter it | 08:19 |
| jrosser | f0o: thanks for the patches | 08:40 |
| jrosser | it would be good to follow the existing style in your defaults/main.yml where all vars defined there are prefixed with the role name | 08:41 |
| jrosser | the vars which are prefixed only with openstack_ are usually defined in the openstack-ansible group_vars and serve to “wire together” similar settings across multiple roles - we need to pay attention to naming and variable precedence here to avoid unexpected results. | 08:47 |
| noonedeadpunk | f0o: like - `horizon_sysctl_file: "{{ openstack_sysctl_file | default('/etc/sysctl.conf') }}" | 08:47 |
| noonedeadpunk | so you can control each role independently, but also have a mean to set different path globally | 08:49 |
| f0o | oh that makes sense | 08:56 |
| f0o | let me fix that | 08:56 |
| opendevreview | Daniel Preussker proposed openstack/ansible-hardening master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/ansible-hardening/+/939600 | 08:58 |
| f0o | ^ so like this one ? | 08:58 |
| noonedeadpunk | yah, looks good to me | 08:59 |
| f0o | ok will change the rest to be like this as well :) | 08:59 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-haproxy_server master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/939601 | 09:00 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-lxc_hosts master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/939604 | 09:01 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-openstack_hosts master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/939602 | 09:02 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-os_horizon master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-os_horizon/+/939599 | 09:03 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-openstack_hosts master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/939602 | 09:03 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-os_swift master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/939603 | 09:04 |
| f0o | ok thats all; had to repush hosts because I forgot the tests/test.yml | 09:04 |
| noonedeadpunk | actually, tests/test.yml won;'t know about role defaults | 09:05 |
| f0o | hrm | 09:06 |
| noonedeadpunk | so it didn't need a change | 09:06 |
| f0o | will revert that then | 09:07 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-openstack_hosts master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/939602 | 09:07 |
| f0o | I assumed since the openstack_module_file is also a variable - but I guess that comes from common/setting-nodepool-variables.yml then | 09:08 |
| f0o | either way as it defaults to /etc/sysctl.conf it should be safe to keep | 09:09 |
| f0o | productive sunday | 09:09 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-haproxy_server master: Remove extra whitespace delimiter to satisfy ansible-lint https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/939606 | 14:22 |
| opendevreview | Daniel Preussker proposed openstack/openstack-ansible-haproxy_server master: Make sysctl configuration path configurable Defaults to /etc/sysctl.conf to retain current behavior https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/939601 | 14:22 |
| noonedeadpunk | I wonder if this https://review.opendev.org/c/openstack/ansible-role-systemd_networkd/+/938560 is somehow related to failure in https://zuul.opendev.org/t/openstack/build/b21622226ea9412e9cc53bc099bf874b | 14:26 |
| jrosser | this looks related https://zuul.opendev.org/t/openstack/build/b21622226ea9412e9cc53bc099bf874b/log/job-output.txt#19168-19178 | 17:00 |
| jrosser | which suggests this is false https://opendev.org/openstack/ansible-role-systemd_networkd/src/branch/master/tasks/main.yml#L34 | 17:02 |
| jrosser | also this feels wrong https://github.com/openstack/ansible-role-systemd_networkd/blob/master/tasks/main.yml#L28 | 17:05 |
| jrosser | we want that to fail on os with missing vars surely | 17:05 |
| noonedeadpunk | I think we had that to "support" unsupported distros https://github.com/openstack/ansible-role-systemd_networkd/blob/master/tasks/main.yml#L28 | 19:21 |
| noonedeadpunk | there were folks who wnated to use the role outside of osa on weird distros | 19:21 |
| noonedeadpunk | so they wanted to jsut override vars locally instead of failing on include | 19:21 |
| noonedeadpunk | I'd say I'm a bit more surprised by molecule passing... | 19:22 |
| noonedeadpunk | as we cover all distros now, don't we? | 19:22 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: [doc] Add multi-AZ deployment configuration sample https://review.opendev.org/c/openstack/openstack-ansible/+/939609 | 19:38 |
| jrosser | but for us on jammy those tasaks should not be skipped so there is something strange happening | 20:04 |
| jrosser | we should be using vars/debian.yml on ubuntu 22.04? | 20:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!