| jrosser | noonedeadpunk: `"{{ one | intersect(two) }}"` -> random order | 08:07 |
|---|---|---|
| jrosser | `"{{ one | select('in', two) }}"` -> original order | 08:07 |
| * jrosser away | 08:08 | |
| noonedeadpunk | aha | 08:24 |
| noonedeadpunk | I can push patches then | 08:24 |
| noonedeadpunk | damiandabrowski: we likely need to also review our internal stuff regarding this thingy ^ | 08:36 |
| noonedeadpunk | for the context - it's about https://github.com/ansible/ansible/issues/82554 | 08:42 |
| damiandabrowski | ouh :/ | 08:58 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_keystone master: Ensure that first/last host detection is deterministic https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/924474 | 09:01 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-repo_server master: Ensure python3-setuptools is present on debian/ubuntu systems. https://review.opendev.org/c/openstack/openstack-ansible-repo_server/+/924393 | 09:02 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-rabbitmq_server master: Add support for Ubuntu Noble https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/924390 | 09:02 |
| opendevreview | Merged openstack/openstack-ansible-os_nova master: Install architecture specific efi firmware for qemu https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/924396 | 09:13 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-galera_server master: Remove installation of libaio1 https://review.opendev.org/c/openstack/openstack-ansible-galera_server/+/924355 | 12:23 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-galera_server master: Update to version 10.11.8 https://review.opendev.org/c/openstack/openstack-ansible-galera_server/+/924357 | 12:23 |
| jrosser | noonedeadpunk: i just looked at two corner cases, rally and trove look like source install even for `install_method: distro` | 12:35 |
| jrosser | there are probably more as well | 12:35 |
| noonedeadpunk | but we have really quite some role that does not have distro method at all | 12:36 |
| noonedeadpunk | be we should not run distro jobs for thwem | 12:36 |
| jrosser | but it does mean for the healthcheck playbook it does need to check that the infra things are setup properly for parts of the install actually being source | 12:37 |
| jrosser | even when the deployment method is "distro" | 12:37 |
| jrosser | this would be why we always have the repo server i guess | 12:37 |
| jrosser | this is about https://review.opendev.org/c/openstack/openstack-ansible/+/924384 | 12:38 |
| noonedeadpunk | but it the will fail without openstack_repo_url anyway? | 12:39 |
| noonedeadpunk | o nthe same place healthcehck-infra fails | 12:39 |
| noonedeadpunk | as we have these only for source: https://opendev.org/openstack/openstack-ansible-plugins/src/branch/master/roles/install_defaults/defaults/source.yml#L25-L27 | 12:39 |
| noonedeadpunk | but they are simply absent for distro | 12:39 |
| noonedeadpunk | and openstack_repo_url is used for python_venv_build | 12:40 |
| jrosser | https://github.com/openstack/openstack-ansible/blob/stable/2024.1/playbooks/healthcheck-infrastructure.yml#L90 | 12:40 |
| noonedeadpunk | are you sure that was correct ? :D | 12:41 |
| noonedeadpunk | so imo, either we should not pretend we're checking this for distro, or if we want for distro to pass for roles that does not support distro - we should define required vars | 12:42 |
| noonedeadpunk | and https://github.com/openstack/openstack-ansible/blob/stable/2024.1/playbooks/healthcheck-infrastructure.yml#L90 is kind of confusing as gives kind of false results, which you won't see in field | 12:42 |
| noonedeadpunk | to have that said, I'm not sure at all if openstack_repo_url would be enough, as I'd guess more things for repo might be borked... | 12:43 |
| noonedeadpunk | ideal situation would be to fail for roles not supporting distro install when distro method is set... | 12:44 |
| noonedeadpunk | with meaningful output, but that quite some work | 12:44 |
| noonedeadpunk | and then skip repo_server role as a whole for distor | 12:44 |
| noonedeadpunk | But if you think that we should just revert to previous state - we can do that as well ofc... | 14:07 |
| jrosser | noonedeadpunk: perhaps fixing up distro stuff is for other patches… scope gets out of hand otherwise | 14:33 |
| noonedeadpunk | yes, but here is kinda question what to patch better. As other way around would be to add `openstack_repo_url` here https://opendev.org/openstack/openstack-ansible-plugins/src/branch/master/roles/install_defaults/defaults/distro.yml#L31 | 14:38 |
| noonedeadpunk | or just skip checking for u-c on repo when it's distro | 14:38 |
| noonedeadpunk | and any of these are less confusing, imo | 14:39 |
| jrosser | noonedeadpunk: I kind of don’t mind - if you pick one and update the patch? I just really don’t want to get dragged into making a ton more changes on top of what is already in progress | 15:37 |
| jrosser | putting openstack_repo_url in distro vars is kind of odd imho | 15:38 |
| noonedeadpunk | it kinda depends if distro supposed to build services that are not supporting distro | 15:44 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Skip repo verification for distro install https://review.opendev.org/c/openstack/openstack-ansible/+/924384 | 15:51 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-rabbitmq_server master: Add support for Ubuntu Noble https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/924390 | 19:08 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-lxc_hosts master: Fix incorrect copying of sources.list.d to container image https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/924309 | 19:09 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-lxc_hosts master: Add libpython entry for Ubuntu Noble https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/924310 | 19:10 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-lxc_hosts master: Install systemd-resolved into container base image for Ubuntu Noble https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/924339 | 19:10 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-lxc_hosts master: Use generated apparmor profile by default in lxc base config https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/924340 | 19:10 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-haproxy_server master: Combine debian and ubuntu vars, adding support for Ubuntu Noble https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/924345 | 19:11 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-memcached_server master: Use the netcat-openbsd package on Ubuntu Noble https://review.opendev.org/c/openstack/openstack-ansible-memcached_server/+/924350 | 19:11 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-plugins master: Add infrastructure playbooks to openstack-ansible-plugins collection https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/924171 | 19:12 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-plugins master: Add haproxy-install playbook https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/924156 | 19:12 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-plugins master: Add infrastructure playbooks to openstack-ansible-plugins collection https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/924171 | 19:17 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible master: Use infrastructure playbooks from openstack-ansible-plugins repo https://review.opendev.org/c/openstack/openstack-ansible/+/924253 | 19:19 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible master: Use infrastructure playbooks from openstack-ansible-plugins repo https://review.opendev.org/c/openstack/openstack-ansible/+/924253 | 19:19 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible master: Use haproxy_install playbook from openstack-ansible-plugins repo https://review.opendev.org/c/openstack/openstack-ansible/+/924168 | 19:21 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible master: Skip repo verification for distro install https://review.opendev.org/c/openstack/openstack-ansible/+/924384 | 20:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!