Tuesday, 2022-01-11

noonedeadpunkI'm not sure this ^ will survive till release and won't be replaced by proxysql. I hope I will have time this month to finish work on it (as I've dropped almost ready role with misclick)08:18
opendevreviewJonathan Rosser proposed openstack/ansible-role-systemd_service master: Suppress 'Service' directive if ListenStream is specified  https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/82404108:27
opendevreviewJonathan Rosser proposed openstack/ansible-role-systemd_service master: Add 'load' boolean for services.  https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/82409608:27
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-galera_server master: Convert xinetd clustercheck to systemd socket service  https://review.opendev.org/c/openstack/openstack-ansible-galera_server/+/82404208:30
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-galera_server master: DNM - Add support for centos-9  https://review.opendev.org/c/openstack/openstack-ansible-galera_server/+/82398308:30
jrosser_noonedeadpunk: yes thats fine if it doesnt survive - i learned some more systemd on the way so thats cool :)08:30
noonedeadpunkBut I'd rather merge it anyway jsut in case :P08:31
jrosser_useful notes here https://mgdm.net/weblog/systemd/ and https://mgdm.net/weblog/systemd-socket-activation/08:31
noonedeadpunkjrosser_: once you're in systemd, can we discuss if https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/816531 should be jsut abandoned due to complexity it brings?08:32
noonedeadpunkas while it's very handy, I agree it brings weirdness because of extra level of iteration08:32
noonedeadpunkor I just don't see more obvious and easy way08:33
jrosser_interesting - the @ notation is also used for socket activated services08:36
jrosser_btw08:37
jrosser_have you seen systemd.path?08:37
jrosser_i was going to see how much work it would be to convert using lsyncd to systemd.path + rsync08:37
noonedeadpunkI think I'm not08:37
noonedeadpunkwell about lsyncd I think we need to review our whole concept... As currently multi-OS support is really broken :(08:38
jrosser_indeed08:38
jrosser_sort of similar problem to xinetd08:38
noonedeadpunkAnd I don't see obvious way to fix that except using shared FS (like cephfs) or haproxy acls...08:38
jrosser_it's kind of legacy and not supported on all OS (centos in particular)08:39
jrosser_so in the short term, keeping the existing behaviour with more universal tools is good08:39
jrosser_but agreed in the long term something better is needed for multi OS / multi arch08:39
noonedeadpunkwell, considering systemd bits are coming from EPEL - what is universal ƪ(˘⌣˘)ʃ08:40
noonedeadpunkbut yeah, it's better then lsyncd that hasn't any release for years now08:40
noonedeadpunkwith super complicated config08:41
jrosser_what we need for multi os / multi arch is for each repo server to report back what OS / arch it is building for08:41
jrosser_in the haproxy healthcheck08:41
jrosser_i think we can probably make that drive an ACL or a map file08:42
jrosser_sort of autodiscovery rather than trying to work it all out at deploy time in the ansible08:42
noonedeadpunkor we can jsut re-run haproxy after re-deployment and make that hardcoded into config. So when you re-setup controller, you anyway run containers creation before haproxy role. So haproxy knows which distro each backend is running08:43
jrosser_true08:43
jrosser_its there in the facts08:44
noonedeadpunkbut autodiscovery sounds nicer indeed. I dunno which option would require smaller changes to haproxy role itself, so not to make it opionated, but limit changes to service description08:44
noonedeadpunkBut ACL we can generate in group_vars I believe?08:46
jrosser_super ugly would be to make each repo server redirect to the next one if the thing you want isnt present08:46
noonedeadpunkI wonder if we will get redirect loop in corner cases :p08:46
jrosser_absolutely08:47
noonedeadpunkwell, we can actually sync in other direction as well - ie sync to repo_all[0] for all others, but then it's no HA or you need +1 controller for multi-os deployment08:50
noonedeadpunk*from all others08:50
noonedeadpunkactually ACL is also no-HA solution. And even when you have 2 repo hosts of other OS (which is not repo_all[0]) things will break, as they won't be synced08:51
jrosser_it is a shame there are no trivial shared FS08:52
noonedeadpunkit is :(08:53
noonedeadpunkSo what we did in R - we were building dynamic groups - https://opendev.org/openstack/openstack-ansible/src/branch/stable/rocky/playbooks/repo-build.yml#L3308:53
noonedeadpunkWe likely need to return to that then08:54
jrosser_i never tried drbd which seems about as simple as can be done08:55
noonedeadpunkI have vague bud memories about it's reliablility and recovery process. It was about a decade ago though hehe08:56
noonedeadpunkit also requires smth like glusterfs I guess?08:57
noonedeadpunknah, it's jsut different thing :)08:58
jrosser_we were also part way through converting the plugins repo to a collection09:01
jrosser_i had a POC patch for keystone to show that it worked09:02
noonedeadpunkah, yes09:02
jrosser_this one https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82099909:02
noonedeadpunkI think I'm the blocker here with descision on how to release it now?09:02
jrosser_something like that09:02
jrosser_we can just keep it 'internal' for now and install from git09:03
noonedeadpunkbtw, returning to previous topic - have you heard anything about https://github.com/bcpierce00/unison ?09:03
noonedeadpunk`Unlike simple mirroring or backup utilities, Unison can deal with updates to both replicas of a distributed directory structure.`09:05
jrosser_its not clear if that can go >2 nodes09:05
noonedeadpunkwell, in doc it says it can, but in star topology :(09:06
noonedeadpunkok, so, plugins.09:14
noonedeadpunklooking at what I've approved now - are we sure we want to spawn this namespace? https://opendev.org/openstack/openstack-ansible-plugins/src/branch/master/galaxy.yml#L209:16
noonedeadpunkand not make it in openstack namespace?09:18
noonedeadpunkalso I think it makes sense to make plugins repo release-independent. Maybe ops repo as well?09:23
noonedeadpunk(unison is probably not what we want indeed)09:27
jrosser_sure we can change the namespace, if we make it in openstack we do not collide with anything else09:31
jrosser_i guess really the patches currently are to show that it will work09:32
noonedeadpunkcurrentlly in openstack namespace there's cloud and config_template only afaik09:33
noonedeadpunkwe can make it openstack.osa for example?09:33
jrosser_that depends if you want to keep it called plugins09:35
jrosser_currently the roles there can be used with "osa.plugins.db_setup" for example09:35
noonedeadpunkit's always a torture to pick up a name for smth 09:35
jrosser_becasue the namespace is osa but the collection name is plugins09:35
jrosser_it's always going to be namespace.collection-name.role-name09:36
noonedeadpunkyes, totally09:36
noonedeadpunkwell, you can define collection in meta and jsut use role name as well :p09:37
jrosser_so openstack.osa.db_setup ?09:37
noonedeadpunklike https://opendev.org/openstack/openstack-ansible-os_tempest/src/branch/master/meta/main.yml#L4509:37
noonedeadpunkbut yeah, I was thinking about openstack.osa.db_setup. We can do openstack.openstack-ansible.db_setup as well I guess, but it's too long ?09:38
jrosser_yes too much typing09:38
noonedeadpunkAlso I'm really open to re-name or create new repo for that, but we failed to find name for it last time09:38
noonedeadpunkas ansible-collections-openstack vs openstack-ansible-collection is confusing a bit...09:39
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-plugins master: Remove incorrect comment about role synchronisation  https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/82410909:39
noonedeadpunkmaybe it's not that bad...09:42
jrosser_currently the collection name and repo name don't need to be coupled09:43
jrosser_it's more important to decide on what should be in the meta file09:43
noonedeadpunkyes, true09:43
noonedeadpunkopenstack.osa.db_setup looks good te me tbh09:44
noonedeadpunk*to09:44
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-plugins master: Switch collection to openstack namespace, rename to 'osa'  https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/82411509:45
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_keystone master: Use common service setup tasks from a collection rather than in-role  https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82099909:46
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_keystone master: Use common service setup tasks from a collection rather than in-role  https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82099910:53
*** dviroel|out is now known as dviroel11:23
jrosser_interesting job failure here https://zuul.opendev.org/t/openstack/build/f7abc6add81d4ad1a779b91cc6ac5eea/log/logs/host/haproxy.service.journal-10-58-10.log.txt#2554-255611:38
jrosser_galera backend goes bad -> keystone 504 -> tempest fail11:38
opendevreviewMerged openstack/openstack-ansible master: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82397111:44
noonedeadpunkI'd suggest oom, but we have set -1000 score for galera?12:00
noonedeadpunk`aio1 mariadbd[74212]: 2022-01-11 10:49:36 376 [Warning] Aborted connection 376 to db: 'nova' user: 'nova' host: 'aio1.openstack.local' (Got timeout reading communication packets)`12:04
noonedeadpunkhuh12:04
noonedeadpunkoh, btw, in local aio I see issue with keystone apache pooling12:05
noonedeadpunkit runs out of available connections becuase of keeping or not re-using them...12:05
noonedeadpunkand specifically for keystone actually12:06
noonedeadpunkit's not the case here though12:06
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible stable/xena: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82402612:12
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible stable/wallaby: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82402712:12
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible stable/victoria: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82402812:12
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible stable/ussuri: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82402912:13
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible stable/train: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82415012:13
jrosser_its like the networking just went bad12:16
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_keystone master: Use common service setup tasks from a collection rather than in-role  https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82099912:17
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Make plugins usable as part of collection  https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/82414812:18
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Make plugins usable as part of collection  https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/82414812:18
opendevreviewJonathan Rosser proposed openstack/openstack-ansible master: Do not duplicate packages installed with the venv build role  https://review.opendev.org/c/openstack/openstack-ansible/+/82417913:22
opendevreviewJonathan Rosser proposed openstack/ansible-role-python_venv_build master: Add per-distro vars files  https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/82418013:28
opendevreviewMerged openstack/openstack-ansible-plugins master: Remove incorrect comment about role synchronisation  https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/82410913:29
opendevreviewMerged openstack/openstack-ansible-plugins master: Switch collection to openstack namespace, rename to 'osa'  https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/82411513:29
opendevreviewJonathan Rosser proposed openstack/openstack-ansible master: Use local repositories for ansible collections in CI  https://review.opendev.org/c/openstack/openstack-ansible/+/82109313:44
jrosser_noonedeadpunk: ^ the old var name now holds the initial collection list - if you have a better idea then we can change it13:45
noonedeadpunkum, I think I jsut don't understand what `galaxy_collections_list_ci` does13:46
jrosser_it's the original list `galaxy_collections_list` with each element either as it was, or replaced with the local zuul repo13:47
noonedeadpunkI  see what it is, but not see where it's used?13:48
jrosser_right down the bottom of the file13:48
jrosser_in the definition of `galaxy_collections`13:48
noonedeadpunkum... But aren't these vars only passed to the play?13:49
noonedeadpunkor you mean galaxy_collections are not renderred yet? So it respects the set_fact inside the play while renderring galaxy_collections?13:49
jrosser_it's used in the copy module content, and lazy evaluation means it's only determined when the copy module is run13:50
jrosser_i can make this less horrible i think13:50
noonedeadpunkI guess at least `galaxy_collections_list_ci: []` made me even more confused13:51
noonedeadpunkwhy can't we set `galaxy_collections` jsut with set_fact inside the play?13:52
opendevreviewJonathan Rosser proposed openstack/openstack-ansible master: Use local repositories for ansible collections in CI  https://review.opendev.org/c/openstack/openstack-ansible/+/82109313:52
jrosser_perhaps i miss something easy13:53
noonedeadpunkyeah, it's way better ow :)13:53
jrosser_but looping over foo.bar.some_list[] to append to the list is hard13:54
noonedeadpunkyep, fair13:55
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_keystone master: Use memcached plugin from collection  https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82418313:57
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible master: [WIP] Use plugins as collection  https://review.opendev.org/c/openstack/openstack-ansible/+/82418414:01
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible master: [WIP] Use plugins as collection  https://review.opendev.org/c/openstack/openstack-ansible/+/82418414:01
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_keystone master: Use memcached plugin from collection  https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82418314:03
opendevreviewJonathan Rosser proposed openstack/ansible-role-systemd_networkd master: Add centos-9 support  https://review.opendev.org/c/openstack/ansible-role-systemd_networkd/+/82341914:14
opendevreviewJonathan Rosser proposed openstack/ansible-role-python_venv_build master: Fix conditional for installing required wheel build packages  https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/82418914:28
opendevreviewJonathan Rosser proposed openstack/openstack-ansible master: Do not duplicate packages installed with the venv build role  https://review.opendev.org/c/openstack/openstack-ansible/+/82417914:29
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-lxc_container_create master: Drop plugins from role requirements  https://review.opendev.org/c/openstack/openstack-ansible-lxc_container_create/+/82419514:44
opendevreviewDmitriy Rabotyagov proposed openstack/ansible-role-systemd_mount master: Drop plugins from role requirements  https://review.opendev.org/c/openstack/ansible-role-systemd_mount/+/82419614:56
opendevreviewDmitriy Rabotyagov proposed openstack/ansible-role-systemd_service master: Drop plugins from role requirements  https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/82419714:57
opendevreviewDmitriy Rabotyagov proposed openstack/ansible-role-systemd_networkd master: Drop plugins from role requirements  https://review.opendev.org/c/openstack/ansible-role-systemd_networkd/+/82419814:58
opendevreviewJames Denton proposed openstack/openstack-ansible master: Add Ironic-related bridges to AIO  https://review.opendev.org/c/openstack/openstack-ansible/+/82342615:00
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible master: [WIP] Use plugins as collection  https://review.opendev.org/c/openstack/openstack-ansible/+/82418415:00
noonedeadpunk#startmeeting openstack_ansible_meeting15:00
opendevmeetMeeting started Tue Jan 11 15:00:16 2022 UTC and is due to finish in 60 minutes.  The chair is noonedeadpunk. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
opendevmeetThe meeting name has been set to 'openstack_ansible_meeting'15:00
noonedeadpunko/15:00
noonedeadpunk#topic rollcall15:00
jamesdentono/15:02
jrosser_o/ hello15:02
jrosser_we should be unblocked on master with the linters trouble now i think15:03
jamesdentondid the second one merge?15:04
damiandabrowski[m]hey!15:04
jamesdentonor does it matter?15:04
noonedeadpunk#topic office hours15:04
noonedeadpunkSo this is first meeting 2022 and we have plenty stuff to discuss I bet :)15:04
noonedeadpunkI guess first thing is probably Rocky Linux support raised by NeilHanlon last week15:05
jrosser_there is a patch now i think15:05
noonedeadpunkhttps://review.opendev.org/c/openstack/openstack-ansible/+/82357315:06
NeilHanloni'm still poking at the DIB build root, too. double booked this morning but i'll try and respond here, too15:06
jrosser_NeilHanlon: i guess there is kind of intersection also with this https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/82418915:06
noonedeadpunkI will try to look into this patch and why zuul is unhappy15:06
jrosser_oh15:06
jrosser_wrong link15:06
jrosser_this https://review.opendev.org/c/openstack/openstack-ansible/+/82085415:07
noonedeadpunkactually I looked through ^ and didn't find anything that would hurt Rocky much.15:07
jrosser_noonedeadpunk: i think there is no rocky image in CI yet15:08
NeilHanloni believe zuul is unhappy b/c of the missing jobs, yea15:08
jrosser_which is why the many zuul errors15:08
noonedeadpunkbtw, NeilHanlon, maybe you know out of top of your brain - does ansible detect that it's Rocky for operating system? And family is still redhat?15:08
NeilHanlonversions >2.10 i think should. and yea, family rh15:09
noonedeadpunkbecause we're carrying some nasty stuff for centos 8 (non-stream) which is eoled by now15:09
NeilHanlonwe *try* to be as close to RHEL as we can15:09
jrosser_detecting stream vs. non-stream for 8 is nasty15:09
NeilHanloni bet :( 15:09
NeilHanlondo you know if there's any reliance on the centos advanced virtualiation sigs? or other SIGs15:10
noonedeadpunkanother more general question - is there any chances that Rocky will ship python38 selinux bindings? As CentOS does not which is a bit frustrating15:10
noonedeadpunkWe rely on RDO15:10
jrosser_sort of https://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/vars/redhat-8.yml#L91-L10615:10
noonedeadpunkfor some packages15:10
noonedeadpunkah, yes...15:11
jrosser_but "it depends" - there needs to be somewhere that the relevant versions of libvirt and whatever come from15:11
jrosser_and if they are there in the distro with no extra repo, then thats fine15:12
jrosser_so the long answer is we take RDO / distro / advanced virt / ... as necessary, and it can be a per distro choice15:12
NeilHanlonadv virt might be problematic.. i may need to pick that up from CentOS and start building it15:13
noonedeadpunkI think nova requirement has libvirt >= 6.0.0 now15:13
jrosser_we should have logs of this15:13
andrewbonneyhttps://docs.openstack.org/nova/latest/reference/libvirt-distro-support-matrix.html15:14
noonedeadpunkjrosser_: btw why do we have advanced-virtualization in openstack_hosts.... Isn't it smth that should be only for nova-computes?15:14
jrosser_very good question15:14
jrosser_NeilHanlon: in the CI logs you can see what got installed https://zuul.opendev.org/t/openstack/build/4bbcf2f1b948415bba2c20acd6a29c5d/log/logs/redhat-rpm-list-installed-host-20-31-15.txt15:15
jrosser_it may be that repo is not required at all15:16
NeilHanloni'll give it a check/test. that repo is going away a/o jan 31st when CentOS rips the 8 content off the mirror15:17
NeilHanlonhttps://lists.centos.org/pipermail/centos-devel/2021-December/098779.html15:17
noonedeadpunk[h]I believe I got disconnected :(15:18
noonedeadpunk[h]Ok, so for Rocky I think we're fine to add it's support considering it shouldn't really take much effort to support it comparing to CentOS and NeilHanlon is around hopefully to help out with some distro-specific questions :)15:19
noonedeadpunkAnother topic then.15:20
noonedeadpunkI was wondering if we should add Backport_candidate label for our projects in gerrit?15:20
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-openstack_hosts master: Remove use of advanced-virtualisation repo for centos  https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/82420215:20
jrosser_that would be a good idea15:21
jrosser_it is really easy to forget which things need to be backported15:21
noonedeadpunkthis would add nasty column, but I belkieve benefit is worth it. 15:22
noonedeadpunkWill figure out how to make this if no objections15:22
noonedeadpunkas we really loose what needs to be backported15:22
jrosser_we need an update to the dashboard too15:23
jrosser_there is a bunch of other collection stuff getting in there15:23
noonedeadpunkah, I see now15:23
jrosser_i did read the zuul docs and was not sure what 'parent project' meant - if that was a useful construct to define "only openstack-ansible repos" to make the dashboard expressions much simpler15:24
jrosser_zuul/gerrit15:24
noonedeadpunkum, I'm not sure that our projects are parented in gerrit15:25
jrosser_no they are not15:25
noonedeadpunkand I haven't saw how to do that in project-config tbh15:27
noonedeadpunkWell, it would require update as we would need to see backport label as separate table anyway, so will imporve regexp as well15:27
noonedeadpunkdashboards in gerrit is nasty beast :(15:28
*** dviroel is now known as dviroel|lunch|errand15:29
noonedeadpunkok, one more thing from me. We want to re-use journald-remote internally. But currently it's a playbook that hard to be re-used15:29
noonedeadpunkWdyt about making it an independent role?15:29
noonedeadpunkOr maybe we should put it just to ops?15:30
noonedeadpunkor as role to plugins repo (to be installable with collection)15:30
jrosser_i was just going to say that last one15:30
jrosser_neat thing with that is we can use it as a kind of staging area for things like this15:30
jrosser_and if it works out then it's little effort15:31
damiandabrowski[m]but the one disadvantage i see, is that deprecated rsyslog would have a separate role and remote_journald won't15:32
damiandabrowski[m]i'm not sure how important it is for You though15:32
noonedeadpunkwe should finally drop rsyslog roles :p15:32
jrosser_^ this15:33
noonedeadpunkThey're still used for ceph I guess though?15:33
noonedeadpunkworth having another look on that15:33
jrosser_becasue ceph writes it's own logs?15:34
noonedeadpunkMy concern was that outside of osa bringing in plugins collection is... a bit unclean, but we likely can survive that15:34
noonedeadpunkWell last time I checked (which was several years ago) it wasn't able to fully leverage journald15:34
noonedeadpunkIt's anyway better then current playbook, and as you said - small effort to move to independent role if needed15:35
noonedeadpunkI'm not sure how we will test role though, but we don't do it now as well, so...15:35
noonedeadpunkI'm fine with adding it to plugins15:36
damiandabrowski[m]maybe let's wait with the decision till February, when I'll put some effort to improve remote_journald playbook?15:37
jrosser_thats an easy first step agreed15:37
damiandabrowski[m]after it's done, we can decide where we want to put it15:37
jrosser_if it's going to become a role, then things change a bit15:37
noonedeadpunkdamiandabrowski[m]: Erik already doing some work on it jsut in case15:37
jrosser_we have really nice patterns on python_venv_build / pki for this kind of utility role15:37
damiandabrowski[m]ouh, didn't know about it, thanks15:37
opendevreviewMerged openstack/openstack-ansible master: Add openstack-ansible-plugins as a collection  https://review.opendev.org/c/openstack/openstack-ansible/+/82099815:39
jrosser_another topic - what do we do with the etcd role?15:40
jrosser_that is blocking centos-8 cleanup atm15:40
noonedeadpunkto have this logged - I'm about to move openstack-ansible-plugins to release independent, which means it won't branch, but we will be creating tags for it. but eventually, we can leave things as is and just switch branches for ansible-collection-requirements...15:41
noonedeadpunkI'm about to either fork it or move to opendev15:42
noonedeadpunknot sure15:42
jamesdentoni believe the etcd role is also being leveraged by OVN15:42
jrosser_does anyone see why the linters fix fails on victoria?15:49
jrosser_oh, we want <11.0.015:50
jrosser_but we have ended up with rich==11.0.015:51
noonedeadpunkoh, weird15:53
noonedeadpunkah, we use functional test there, damn15:54
jrosser_yeah, it's tox installing things and not what the patch changes15:54
noonedeadpunkbut I'm not sure how that worked as we have ansible-lint in https://opendev.org/openstack/openstack-ansible/src/branch/stable/victoria/test-requirements.txt#L1415:55
jrosser_comes from here eventually? https://opendev.org/openstack/openstack-ansible/src/branch/master/tox.ini#L14015:57
noonedeadpunkand for U that passes because there's no such requirement I guess15:57
jrosser_which starts out at https://opendev.org/openstack/openstack-ansible/src/branch/master/tox.ini#L12-L1415:57
noonedeadpunkyeah, I guess you're right. But we kind of need to fix that for functional repo as well I guess?15:58
jrosser_can we add it go global pins and then it does both together?15:59
jrosser_*to15:59
noonedeadpunkyep, we can15:59
noonedeadpunkit's probably not best place but considering it's only for V....16:00
noonedeadpunkbut it will work, yes16:00
noonedeadpunk#endmeeting16:01
opendevmeetMeeting ended Tue Jan 11 16:01:19 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:01
opendevmeetMinutes:        https://meetings.opendev.org/meetings/openstack_ansible_meeting/2022/openstack_ansible_meeting.2022-01-11-15.00.html16:01
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/openstack_ansible_meeting/2022/openstack_ansible_meeting.2022-01-11-15.00.txt16:01
opendevmeetLog:            https://meetings.opendev.org/meetings/openstack_ansible_meeting/2022/openstack_ansible_meeting.2022-01-11-15.00.log.html16:01
jrosser_it may be a good compromise - making the integrated linter work for V might be difficult16:02
noonedeadpunkyeah, agree16:10
opendevreviewJonathan Rosser proposed openstack/openstack-ansible stable/ussuri: Remove opensuse jobs  https://review.opendev.org/c/openstack/openstack-ansible/+/82420616:21
*** sshnaidm is now known as sshnaidm|afk16:23
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-tests stable/ussuri: Remove opensuse jobs  https://review.opendev.org/c/openstack/openstack-ansible-tests/+/82420716:24
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_keystone master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82420916:31
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_barbican master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/82421016:32
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_gnocchi master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_gnocchi/+/82421116:33
jamesdentonjrosser_ you mentioned yesterday something about the ironic role using openstack-ansible-tests? is that deprecated? Wondering how much cruft in the role could be cleaned up16:33
jamesdentonlike, is https://github.com/openstack/openstack-ansible-os_ironic/blob/master/tests/test.yml still relevant at all?16:33
jrosser_i think that the old patch you looked at the other day may have used openstack-ansible-tests16:33
jamesdentonhttps://github.com/openstack/openstack-ansible-os_ironic/blob/master/manual-test.rc16:34
jamesdentoni think that's what i referenced, can't recall16:34
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_gnocchi master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_gnocchi/+/82421116:34
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_keystone master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82420916:35
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_barbican master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/82421016:36
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_magnum master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/82421216:37
jamesdentonahh yes, this guy https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/38104916:38
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_rally master: Do not install python development packages  https://review.opendev.org/c/openstack/openstack-ansible-os_rally/+/82421316:38
jrosser_jamesdenton: i think in the new world it's all set up here https://github.com/openstack/openstack-ansible/blob/master/tests/roles/bootstrap-host/templates/user_variables_ironic.yml.j216:39
jrosser_it should do an AIO deployment including ironic by parsing the job name, and use whatever you put in there ^^ as extra user_variables16:40
jamesdentonright, yes. 16:40
jamesdentonso this is prob outdated? https://github.com/openstack/openstack-ansible-os_ironic/blob/master/local_install.sh16:40
jrosser_almost certainly yes16:41
jamesdentonok - i'm just gonna purge a few things and see what happens :D16:41
jrosser_go for it16:41
jrosser_i expect there is cruft like this in all the roles16:42
opendevreviewJames Denton proposed openstack/openstack-ansible-os_ironic master: [DNM] Delete Test Cruft  https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/82421416:45
jrosser_does anyone know what we use kmod-devel for?16:51
jrosser_https://codesearch.opendev.org/?q=kmod-devel16:52
spatelkmod-devel is used by NFS i believe 16:55
jamesdentonbut only for redhat?16:56
jrosser_aparrently so16:58
jrosser_i wonder how this has ever worked becasue it has to come from the powertools repo on centos-8-stream17:01
damiandabrowski[m]guys, i think we need to always add recursive=True to the combine() filter when we work on systemd configs, as they often contain nested structure. What do You think? I can prepare fixes17:03
damiandabrowski[m]https://paste.openstack.org/show/812036/17:03
jrosser_damiandabrowski[m]: that does look broken doesnt it17:11
opendevreviewMerged openstack/openstack-ansible-os_ironic master: Update Ironic Documentation  https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/82220317:13
opendevreviewJonathan Rosser proposed openstack/openstack-ansible-os_nova master: Replace genisoimage with xorriso for centos-9  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/82421717:15
*** dviroel|lunch|errand is now known as dviroel17:18
damiandabrowski[m]jrosser_: currently yes, at least in my opinion 17:19
opendevreviewMerged openstack/openstack-ansible stable/wallaby: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82402717:25
spatelI am getting error numatopologyfilter returned 0 hosts. question can i see numatoplogy in placement resources? 17:28
spateldoes placement has any info related numatopology ?17:28
jrosser_noonedeadpunk: do you remember why this happens? https://paste.opendev.org/show/812038/17:32
jrosser_os_nova role calls the uwsgi role, but the uwsgi role loads the vars from os_nova, not its own17:32
opendevreviewMerged openstack/openstack-ansible master: Fix additional facts gathering in ceph-install.yml  https://review.opendev.org/c/openstack/openstack-ansible/+/82379617:42
opendevreviewMerged openstack/openstack-ansible master: Update ansible-lint version  https://review.opendev.org/c/openstack/openstack-ansible/+/82397917:42
noonedeadpunkjrosser_: um, what... was it always like that? And how it worked then....17:57
jrosser_i am really confused17:58
jrosser_theres the same thing in all the roles before nova17:58
noonedeadpunkah, when it can't find any local variable I guees17:58
jrosser_oh!17:58
noonedeadpunkand it was smth realted to imports17:58
jrosser_i think what i mean is this has worked as i expect right up till the nova role18:01
noonedeadpunkAnd you had created redhat-9 there?18:02
jrosser_no, i did not18:02
jrosser_i expected this to pick up redhat.yml https://github.com/openstack/ansible-role-uwsgi/blob/master/tasks/main.yml#L2518:03
noonedeadpunkHm... So I think what happens is that for https://opendev.org/openstack/ansible-role-uwsgi/src/branch/master/tasks/main.yml#L20-L25 it checks all paths, with priority to current role but also including the one where it's included from18:03
jrosser_urgh18:04
jrosser_becasue you are right, i just have made a redhat-9.yml file and it does what we want18:04
noonedeadpunkSo if nova has redhat-9.yml, it's before "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml18:04
jrosser_ /o\18:04
noonedeadpunkso it picks up first available and not goes down to "{{ ansible_facts['os_family'] | lower }}.yml"18:04
jrosser_thats very strange behaviour18:04
noonedeadpunkdoes import/include_role breaks the same way?18:05
noonedeadpunkAlso I guess that's kind of reason why we have https://opendev.org/openstack/ansible-role-uwsgi/src/branch/master/vars for each ubuntu/debian18:06
noonedeadpunkas "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml" is second in the list18:06
noonedeadpunknot sure though18:06
noonedeadpunkmaybe because of libpython3.8 as well:)18:07
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_zun master: Ansible's combine() filter needs recursive=True parameter in order to recursively merge nested hashes.  https://review.opendev.org/c/openstack/openstack-ansible-os_zun/+/82421918:15
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_zun master: Ansible's combine() filter needs recursive=True parameter in order to recursively merge nested hashes.  https://review.opendev.org/c/openstack/openstack-ansible-os_zun/+/82421918:15
jrosser_damiandabrowski[m]: try to keep the first line of the commit message short18:16
damiandabrowski[m]ah it's a mistake, thanks18:17
damiandabrowski[m]will fix it and continue adding changes18:17
jrosser_https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure18:17
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_zun master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/openstack-ansible-os_zun/+/82421918:19
opendevreviewMerged openstack/openstack-ansible stable/xena: Fix rich version for ansible-lint  https://review.opendev.org/c/openstack/openstack-ansible/+/82402618:20
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/82422018:21
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_swift master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/82422118:21
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_nova master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/82422218:22
jrosser_noonedeadpunk: surprisingly, this fixes it https://paste.opendev.org/show/812043/18:22
noonedeadpunkoh18:22
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_neutron master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/82422318:23
noonedeadpunkIt feels like we need to do that for all roles that are being included?18:23
jrosser_first_found has a bunch more functionality than we normally use18:23
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-os_cinder master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/82422418:23
jrosser_but you don't seem to be able to pass those things when using it like we do18:23
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-galera_server master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/openstack-ansible-galera_server/+/82422518:24
opendevreviewDamian Dąbrowski proposed openstack/ansible-role-uwsgi master: Enable recursion in combine() filter  https://review.opendev.org/c/openstack/ansible-role-uwsgi/+/82422618:24
noonedeadpunkwell, fair, we haven't touched that bit for ages18:24
jrosser_it's the last example here https://docs.ansible.com/ansible/latest/collections/ansible/builtin/first_found_lookup.html18:25
damiandabrowski[m]https://review.opendev.org/q/topic:%22combine-filter-recursion%22 is ready for review 18:26
jrosser_i will make patches for this tomorrow becasue its total banana skin18:26
noonedeadpunkI think {{ role_path }} is really vital there18:26
jrosser_oh yes, without that it still takes the os_nova vars18:27
noonedeadpunkI'd say it's worth backporting https://review.opendev.org/q/topic:%22combine-filter-recursion%22 at least to X?18:27
jrosser_probably as far as we can given how its just broken?18:28
jrosser_my centos-9 AIO has got to neutron now18:29
jrosser_feels like this is going to work18:29
jrosser_maybe a few more package names to adjust but hopefully nothing more serious18:29
noonedeadpunksounds really promising!18:30
jrosser_we need to wait for real mariadb and rabbit packages18:30
jrosser_and no lxc yet either18:30
jrosser_i have hacks to use the distro mariadb and rabbit just now18:31
jrosser_so the version is not what we want18:31
jrosser_it's been good through, i have flushed out a whole load of legacy stuff doing this18:31
jamesdentonif anyone has a sec to check this out, i'd appreciate it. https://review.opendev.org/c/openstack/openstack-ansible/+/82342618:47
mgariepyjamesdenton, looks good but i would like a small nit ;)18:55
jamesdenton:D19:04
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-plugins master: Make plugins usable as part of collection  https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/82414819:15
noonedeadpunkyeah, ideally 172.29.228.100 should be first, but well...19:18
noonedeadpunkjamesdenton: feel free to self+W if you ok to leave as is19:19
jrosser_oh cool this passed https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82099919:22
jrosser_it proves the depends-on are working for plugins collection19:22
noonedeadpunkyep, that's really good proof19:24
noonedeadpunkWhat's not good - functional tests here https://opendev.org/openstack/openstack-ansible-lxc_container_create/src/branch/master/zuul.d/project.yaml#L25 :(19:24
noonedeadpunkthey make me sad19:24
jrosser_I expect an infra job is fairly close to those19:30
noonedeadpunkjust matter of defined variable I guess... so adding btrfs/zfs scenarios will be needed19:33
noonedeadpunkI really love that https://review.opendev.org/c/openstack/openstack-ansible-os_keystone/+/82099919:37
noonedeadpunkIts so clean easy and neat....19:38
noonedeadpunkjrosser_: still around?:)19:54
jrosser_yeah :)19:55
noonedeadpunkRegarding backport label 19:55
noonedeadpunkI'm not sure if we should create +2 for it?19:56
noonedeadpunkOr just have +1 and -1 for all users?19:56
noonedeadpunk-2 is fully useless here imo, regarding +2....19:57
jrosser_hmm19:57
jrosser_feels. but more like a flag than a vote19:58
noonedeadpunkI'd say I'd be fine that such review appear on board if any registered user marks it for backporting... At least it needs verification I'd say19:58
noonedeadpunkyep, exactly19:58
opendevreviewJames Denton proposed openstack/openstack-ansible-os_ironic master: Update Ironic Inspector for Metal Deployments  https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/82150319:59
noonedeadpunkI'm jsut thinking -1 might be useful if we want to drop some patch from the board, we set -1 to it19:59
jrosser_we have 0 as well?20:00
noonedeadpunkyep20:00
noonedeadpunk0 is default20:00
jrosser_simple sounds good for now20:01
noonedeadpunkwe can add extra if needed indeed20:01
noonedeadpunkactually we can limit this only to cores and don't allow users to set it 20:02
noonedeadpunk(so +1 will be available only to cores)20:03
jrosser_let’s do that20:11
noonedeadpunkdoh.... its' functional dir job for lxc_containers https://zuul.opendev.org/t/openstack/build/b1224f5aff5840448b08841f1ebdc65e/log/logs/host/lxc-cache-prep-commands.log.txt 20:33
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-lxc_container_create master: Use only supported functional jobs  https://review.opendev.org/c/openstack/openstack-ansible-lxc_container_create/+/82423420:47
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-lxc_container_create master: Drop plugins from role requirements  https://review.opendev.org/c/openstack/openstack-ansible-lxc_container_create/+/82419520:47
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible master: [WIP] Use plugins as collection  https://review.opendev.org/c/openstack/openstack-ansible/+/82418420:56
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible master: Use plugins repo as collection  https://review.opendev.org/c/openstack/openstack-ansible/+/82418420:57
*** dviroel is now known as dviroel|afk21:15
opendevreviewJames Denton proposed openstack/openstack-ansible-os_ironic master: [DNM] Delete Test Cruft  https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/82421422:44
opendevreviewMerged openstack/openstack-ansible-haproxy_server master: Add default CA store to use when haproxy_backend_ca is true  https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/82184722:54
*** dviroel|afk is now known as dviroel23:05
*** dviroel is now known as dviroel|out23:10
opendevreviewMerged openstack/openstack-ansible-os_nova master: Reinstate ssh key distribution for all nova deployments  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/82378523:41
opendevreviewMerged openstack/openstack-ansible-os_nova master: Revert "Disable shell for nova when tunneled migration not used"  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/82378623:41

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!