Saturday, 2018-03-24

prometheanfirecloudnull: do you create netdev files for things like eth0?00:01
prometheanfireor rely on the system to do so for you00:01
cloudnullnope no need. physical interfaces should already be present.00:02
prometheanfireah, guess you wouldn't00:02
cloudnullyou can create netdev for physical devices to change the properties of the device itself00:02
cloudnullbut that's not required.00:02
*** lhinds has quit IRC00:02
prometheanfireI'm tempted to just go ahead and do that00:03
*** portante has quit IRC00:03
*** pabelanger has quit IRC00:04
*** pabelanger has joined #openstack-ansible00:05
*** lhinds has joined #openstack-ansible00:06
*** portante has joined #openstack-ansible00:06
*** masber has joined #openstack-ansible00:19
*** masber has quit IRC00:23
*** masber has joined #openstack-ansible00:23
*** dave-mccowan has joined #openstack-ansible00:41
logan-quick question for you on https://review.openstack.org/#/c/554389/3 cloudnull00:45
cloudnullanswered00:47
cloudnulllogan-: mind having a look at https://review.openstack.org/#/c/555910 if you have a free moment00:48
logan-yup will do00:49
cloudnullalso http://logs.openstack.org/79/466179/24/check/openstack-ansible-upgrade-ubuntu-xenial/143b1de/job-output.txt.gz#_2018-03-24_00_44_36_740767 -- is this something we're aware of00:49
cloudnulllooks like cell mapping is failing in nova?00:50
cloudnullfor the upgrade job that is00:50
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-os_barbican master: Convert role to use a common systemd service role  https://review.openstack.org/55207100:54
logan-have not seen that yet00:55
logan-do you think it is something base image related like keystone was?00:55
*** odyssey4me has quit IRC00:55
*** odyssey4me has joined #openstack-ansible00:56
logan-well nevermind00:57
logan-just read thru the traceback00:57
logan-""Unknown column 'disabled' in 'field list'\""00:57
logan-https://github.com/openstack/openstack-ansible/blob/62bbe0f38e04864e3e669fb0871ddacefca79814/playbooks/defaults/repo_packages/openstack_services.yml#L167-L16900:58
logan-wow none of the shas have been bumped in master since 2/16?00:58
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-lxc_container_create master: Add container journal linking  https://review.openstack.org/55370701:09
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-lxc_container_create master: Add container journal linking  https://review.openstack.org/55370701:10
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-lxc_container_create master: Allow deployers to define the container type  https://review.openstack.org/55438901:18
cloudnullI think the role tests are using the head of master.01:19
cloudnullwhile the integrated gate is behind01:19
cloudnullunless the tests repo is reading that in somewhere01:20
openstackgerritLogan V proposed openstack/openstack-ansible-openstack_hosts master: Revert "Ensure the /etc/pki/rpm-gpg directory exists"  https://review.openstack.org/55584501:20
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: Add tests for MultiStringOp  https://review.openstack.org/55508601:21
openstackgerritMerged openstack/ansible-role-systemd_mount master: Add basic tests  https://review.openstack.org/55591001:21
logan-oh that log is a role test? gotcha01:21
logan-some stuff related to this field just merged in the last day or so https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/cell-disable01:23
logan-https://github.com/openstack/nova/commit/9377127eb887d263ba1c80990f93329fda3c19bc and https://github.com/openstack/nova/commit/a26ad9f9a82dfb5210e4a979e67e000989d7ff91 etc01:24
logan-and still 3-4 patches still open for that bp01:25
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-lxc_container_create master: Add container journal linking  https://review.openstack.org/55370701:28
*** flemingo_ has quit IRC01:28
cloudnulllogan-: :(01:28
cloudnullwe might need to pin the nova role test.01:28
cloudnullor just let them finish working on it01:28
logan-yea idk if it is only affecting upgrades and the regular tests are passing maybe its something worth pinging them about in case its not something addressed by the pending patches01:30
logan-or.. you know.. we could do a depends-on with all of the patches still open01:30
logan-and see if it passes01:30
cloudnullthat might be worth a try01:31
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: Add tests for MultiStringOp  https://review.openstack.org/55508601:39
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-lxc_hosts master: Copy the "locale" into base container image  https://review.openstack.org/55597101:43
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-lxc_container_create master: Add container journal linking  https://review.openstack.org/55370701:45
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-os_barbican master: Convert role to use a common systemd service role  https://review.openstack.org/55207101:47
cloudnullso with the linked journals we can do things like `journalctl --follow --file=/var/log/journal/$(lxc-attach -n aio1_utility_container-21e9790d -- cat /etc/machine-id)/system.journal` on the host which how i found the locales issue01:50
cloudnullhttps://review.openstack.org/55597101:50
cloudnullbut we can also use journald to ship the journals elsewhere.01:51
cloudnulllike https://cloudnull.io/2018/02/journaling-remotely/01:52
* cloudnull shameless plug01:52
*** fatdragon has quit IRC01:54
logan-:)01:55
*** ryan_ has quit IRC02:07
openstackgerritMerged openstack/openstack-ansible-plugins master: Add tests for MultiStringOp  https://review.openstack.org/55508602:27
openstackgerritBjoern Teipel proposed openstack/openstack-ansible-ops master: Adding mnaio qemu file backends  https://review.openstack.org/54909702:29
*** dave-mccowan has quit IRC03:08
*** masuberu has joined #openstack-ansible03:09
*** masuberu has quit IRC03:11
*** masber has quit IRC03:11
*** masuberu has joined #openstack-ansible03:11
*** masuberu has quit IRC03:14
*** masuberu has joined #openstack-ansible03:15
*** savvas has joined #openstack-ansible03:16
*** savvas has joined #openstack-ansible03:17
*** cjloader has joined #openstack-ansible03:29
*** cjloader has quit IRC03:30
*** cjloader has joined #openstack-ansible03:31
*** savvas_ has joined #openstack-ansible03:34
*** savvas has quit IRC03:35
*** masuberu has quit IRC03:39
*** savvas has joined #openstack-ansible03:56
openstackgerritLogan V proposed openstack/openstack-ansible-os_keystone master: Re-cache venv if extracted venv is missing  https://review.openstack.org/55598103:56
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible master: Add playbook to ship journals from hosts  https://review.openstack.org/55598203:59
*** savvas has quit IRC04:00
*** cjloader has quit IRC04:01
*** cjloader has joined #openstack-ansible04:01
*** cjloader has quit IRC04:02
*** cjloader has joined #openstack-ansible04:03
*** cjloader has quit IRC04:13
*** cjloader has joined #openstack-ansible04:13
openstackgerritLogan V proposed openstack/openstack-ansible-os_keystone master: Rebuild venv if missing  https://review.openstack.org/55598104:32
*** djdule has joined #openstack-ansible04:33
djduleHello04:33
djduleI need some help with a setup04:33
djduleI do have OpenStack installed with Ansible of course, latest version, Pike04:34
djduleAnd everything works except connectivity from cloud to rest of the world04:34
*** cjloader has quit IRC04:34
djduleI created external provider network04:34
djdulebut it is still not working. And I am stuck now, no idea what went wrong04:35
*** cjloader has joined #openstack-ansible04:35
*** cjloader has quit IRC04:37
*** cjloader has joined #openstack-ansible04:37
*** cjloader has quit IRC04:38
*** cjloader has joined #openstack-ansible04:39
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible master: Add playbook to ship journals from hosts  https://review.openstack.org/55598204:39
cloudnulldjdule: I assume the external router has a gateway on it ?04:40
djduleYou mean external router on OpenStack ?04:40
cloudnulland that the network being used as the gateway is routable ?04:40
cloudnullyes, you'll have two network interfaces on your router. one being the gateway.04:41
cloudnullthe other being your tenant network04:41
djduleYes, that is correct04:42
cloudnullin most cases the first network (GATEWAY_NET) is has something off when it was created.04:42
*** cjloader has quit IRC04:42
djduleWhat do you mean by "first network (GATEWAY_NET) is has something off when it was created" ?04:44
cloudnullthis is an old post but still relevant https://developer.rackspace.com/blog/neutron-networking-l3-agent04:44
cloudnullthere are a couple flag you have to pass in when the network was created04:45
cloudnull's/router/network/04:45
djdulei created network using command: neutron net-create external-net --router:external --provider:physical_network flat --provider:network_type flat04:45
cloudnullok.04:45
djduleand then subnet neutron subnet-create --name external-subnet --allocation-pool start=139.25.25.200,end=139.25.25.254 --disable-dhcp --gateway 139.25.25.193 external-net 139.25.25.192/2604:45
cloudnullok.04:46
cloudnulland that gateway is routable ?04:46
cloudnullcan you ping that address within the instance?04:46
cloudnulland are the instances getting DHCP04:46
djduleI can ping and connect to gateway 139.25.25.193 from controller, but not from instance04:47
djduleYes, instances get DHCP04:47
djduleand I can also associate floating IPs to them04:47
djduleinstance to instance works04:47
cloudnullgreat!04:47
djduleonly thing that is not working is connecting to rest of the world from instance04:47
cloudnullis this an AIO04:47
djduleno, I do have separate cloud controller and compute nodes04:48
cloudnullok.04:48
djduleone cloud controller, not HA04:48
cloudnullcool, that'll work fine.04:48
cloudnullcan you assign a float to more than one vm and ping the floats from the vms ?04:49
djduleyes, and I can also SSH to float, tried that already04:49
cloudnullcool!04:49
cloudnullsounds like we're really close04:50
djduleI really hope so, since I already wasted 2 days trying to resolve it :)04:50
cloudnullwhat's the default gateway on the VM04:50
cloudnulland do you have a gateway set on the router?04:50
cloudnullneutron router-list , router-show $UUID04:51
djdulei have private net 192.168.2.0/24, and default gateway is 192.168.2.1 from within the VM04:51
cloudnulland you can ping 192.168.2.104:51
djduleroutes                  | {"destination": "139.25.25.192/26", "nexthop": "139.25.25.193"}04:52
djdulelet me check ping04:52
cloudnullok.04:53
cloudnullI assume you ran "neutron router-gateway-set ..."04:53
djduleI am not 100% sure04:54
djdulewhat should be whole command, just to check04:54
cloudnull`neutron router-gateway-set $ROUTER_NAME $NET_NAME`04:54
djdule$ROUTER_NAME is my router, $NET_NAME is external network ?04:55
djdulelet me try it04:55
cloudnullyes04:55
cloudnullalso `neutron router-interface-add $ROUTER_UUID $NETWORK_SUBNET_UUID`04:56
* cloudnull is tired and going from memory04:56
cloudnullbut those should be close to the commands you need to run to setup a router once the router is created04:57
cloudnulli gotta run .04:59
cloudnulllet us know how it goes04:59
cloudnullhope you make it all work soon djdule04:59
djdulethanks a lot !05:00
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598705:02
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598705:06
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598705:08
*** djdule has quit IRC05:13
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598705:20
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598705:32
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598705:50
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_cinder master: Followning the same logic as https://review.openstack.org/#/c/555981/ Making the respective changes to the os_cinder role.  https://review.openstack.org/55599906:29
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible master: Add playbook to ship journals from hosts  https://review.openstack.org/55598206:32
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible-os_barbican master: Convert role to use a common systemd service role  https://review.openstack.org/55207106:35
openstackgerritKevin Carter (cloudnull) proposed openstack/openstack-ansible master: [WIP] Disable global rsyslog  https://review.openstack.org/55600206:53
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_nova master: Propagate https://review.openstack.org/#/c/555981/  https://review.openstack.org/55600306:57
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_glance master: Propagate https://review.openstack.org/#/c/555981/  https://review.openstack.org/55600507:16
*** djdule has joined #openstack-ansible07:22
djduleHi, I have a question about setting up external connectivity07:23
djduleI do have Pike, latest version of openstack-ansible07:23
djdulebut I do not understand how to setup mapping between external network and interface07:24
djduleas far as I understand provider network interface should be defined in neutron ml2_conf.ini07:24
djdulebut in mine, that is generated by Ansible, I do have07:25
djdule[ml2_type_flat] flat_networks = flat07:25
djduleI do no not understand how that maps to my physical network interface07:25
djdulebecause when I create net07:25
djduleopenstack network create --external --share --provider-physical-network flat --provider-network-type flat provider107:25
djduleand all other steps07:25
djduletraffic is not getting out07:26
djduleso it seems to me there is no mapping between network in openstack and my physical interface07:26
djduleany idea ?07:26
*** jwitko has quit IRC07:27
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_neutron master: Propagate https://review.openstack.org/#/c/555981/  https://review.openstack.org/55601307:31
*** chhagarw has joined #openstack-ansible07:31
djduleany help please ?07:33
xdfildjdule: bridge_mappings =07:38
djdulefrom what file ?07:38
djduleif you ask about ml2_conf.ini, no such line07:39
djdulethat file is auto generated by ansible07:39
djduleopenstack-ansible, to be precise07:39
xdfildjdule: bridge_mappings = <name_of network_you_create>:<physical_nic_on_host>07:39
xdfilso like vlan:bond007:40
xdfilor vlan:eth007:40
xdfiland yeah it gets generated by OSA07:40
djdulebut in what file I shall look for that line ?07:40
xdfili think ml207:41
xdfilbut one sec07:41
djduleno such line there07:41
xdfilhttps://docs.openstack.org/project-deploy-guide/openstack-ansible/pike/app-config-test.html07:42
xdfilnet-name07:42
xdfilnet-name is the first part of the mapping07:42
xdfiland the bridge interface is usually the second part07:43
xdfildepends on how you set it up but thats the easiest way (assuming you created linux bridges on your hosts manually)07:43
djduleok this is how my deployment file looks like, specifically that part related to bridge07:44
djdule    - network:         container_bridge: "br-vlan"         container_type: "veth"         container_interface: "eth12"         host_bind_override: "eth12"         type: "flat"         net_name: "flat"         group_binds:           - neutron_linuxbridge_agent07:44
djduleso it is exactly the same as example you pointed out07:45
djduleso if I understand properly, that should map flat network to eth12 ?07:45
djdulebut it is not reflected in ml2 config file07:46
xdfilI personally dont use flat07:46
*** gkadam_ has joined #openstack-ansible07:46
xdfilso like07:46
xdfilit could be the linux bridge agent conf07:47
xdfil~ /etc/neutron/plugins/ml2/linux-bri*~~07:47
djduleok, but that file does not exist on my deployment07:48
xdfilwhat host are you on?07:48
djduleon controller07:49
xdfilis it an AIO?07:49
djduleno, not AIO07:49
djduleseparated one controller, multiple compute nodes07:49
xdfilneutron_agents container?07:49
djduleah, sorry, there it is07:50
xdfilactually it might be on neutron_server also07:50
djdulephysical_interface_mappings = flat:eth12,vlan:eth1107:50
djduleit is not on neutron server, it is in agents container07:50
xdfilthe agents container is where all the magic happens07:50
djduleok, there is that line07:51
xdfilalthough in Queens i think they got rid of it07:51
djduleand if I understand it properly it is saying that flat network is mapped to eth1207:51
xdfilyes07:51
xdfilinside the container07:51
djdulethere is eth1207:51
djdulecreated from /etc/network/interfaces07:52
djduleon controller node07:52
djduleit is veth par leading to br-vlan07:52
xdfilyep ^^ that sounds good07:52
djdulebr-vlan is created manually, as per OSA documentation07:52
djdulebut when I create networks and everything, I cannot go out from OpenStack07:53
xdfilyou configure security group?07:53
djdulewhich, for VMs ?07:53
djduleyes, VM connectivity works inside cloud07:53
djduleand floating IPs07:54
xdfil99% of all network problems in openstack are because you forgot to set the security group07:54
djdulebut from qrouter name space I cannot ping gateway07:54
*** gkadam has joined #openstack-ansible07:54
xdfilinside cant hit google..  ok07:54
xdfilis inside RFC1918?07:55
djduleso I do have security group that allows ICMP and ping07:55
djduleyes, inside is 192.168.2.10.....07:55
xdfilyeah outbound you should be fine07:55
djdulethere is gateway, router, etc,07:55
djduleand everything looks ok07:55
djduleand internaly it works07:55
djdulei can go between VMs using internal and floating IPs07:56
djdulebut I cannot go out07:56
djduleso I am looking into qrouter name space on controller, inside agent container07:56
xdfilso SNAT might be disabled on that subnet07:56
*** gkadam_ has quit IRC07:56
xdfilbut by default it should be on07:57
xdfilpretty sure07:57
djduleit is on07:57
djduleroot@infra1-neutron-agents-container-e800e983:/# ip netns list qrouter-41eae7b4-333b-4a46-babb-bf7b713b95e1 (id: 1) qdhcp-9757992a-c357-49c9-9d49-1e7fbf87aa3f (id: 2) r07:57
djduleso docs says that I should be able to ping my gateway from qrouter namespace07:57
djdulebut I cannot07:57
xdfilyeah you should...07:58
xdfilthis sounds familiar07:58
xdfilyou have l3 agents running where?08:00
djdulein container on controller node08:01
xdfilwhat about computes?08:01
djdulethey are on separate servers08:01
xdfilnot saying you should, but is the neutron-l3 agent running on computes?08:01
djdulelet me check, but it should08:02
xdfiland is neutron linux-bridge agent running everywhere08:02
djdulelinux-bridge agent is running, ye08:03
djdulel3 no08:03
djdulel3 not on compute node08:03
xdfilok thats probably fine08:03
xdfilsorry i'm temporarily out of ideas08:05
djduleme too, and I am scratching my head for 2 days08:06
xdfili should have been in bed hours ago08:06
xdfilhehe ya08:06
djdulegood night and thanks :)08:06
xdfilbeen there08:06
xdfilyou'll get it you seem to have a good grasp on these things08:06
*** hamza21 has joined #openstack-ansible08:13
*** chhagarw has quit IRC08:16
xdfildjdule: hey08:17
djduleyes08:17
xdfilget rid of that host_bind_override: "eth12"08:17
djduleand rerun which part ?08:17
djdulewhen I say rerun, what playbooks to re-apply ?08:18
xdfilthe key in neutron linux bridge conf should be "bridge mappings i think08:18
xdfilum... lxc stuff i think08:18
xdfiland then neutron08:19
xdfilso i think the reson you have physical-interface-mappings instead is because of that bind-override08:19
djduleok, let me try and see08:20
xdfilwhich you don't need probably and " eth12 " is certainly not the name of the physical interface08:20
xdfildo you have "br-vlan" configured on the compute?08:20
*** spinoshi has joined #openstack-ansible08:20
djduleyes, there is br-vlan on compute08:21
xdfilif that works, thank Pablo Escobar08:21
xdfilok good08:21
xdfilwatching him on TV and that thought just came to me lol08:22
djduleLOL08:22
xdfilhe's so determined. its inspiring08:22
djduleok, reapplying stuff now, let's see if it will help08:24
djduleit will take some time I think08:25
djduleso I will go to sort out some other things and let you know later how it went08:25
djdulebut thanks for help08:25
xdfilone thing08:25
xdfilphysical_interface_mappings08:25
xdfilwhat does it say on your compute host08:25
xdfillinux-bridge-agent conf08:26
djdulelet me see08:26
xdfilor does it say bridge_mappings08:26
djdulephysical_interface_mappings = flat:eth12,vlan:eth1108:26
xdfiltheres your problem08:26
xdfilthe plays should fix that08:27
*** spinoshi has quit IRC08:27
djdulewhat it should say ?08:27
xdfilit should say br-vlan08:27
djduleok, great, thanks. let me re run stuff and see if it performs08:28
xdfilnn08:28
*** djdule has quit IRC08:34
*** sep has quit IRC09:15
*** sep has joined #openstack-ansible09:15
*** yolanda has quit IRC09:43
*** masber has joined #openstack-ansible09:50
*** yolanda has joined #openstack-ansible10:00
*** chhagarw has joined #openstack-ansible10:30
*** sep has quit IRC11:19
*** sep has joined #openstack-ansible11:20
*** masber is now known as masuberu11:32
*** masuberu is now known as masber11:35
*** masber has quit IRC11:41
*** masber has joined #openstack-ansible11:42
*** masber has quit IRC11:45
*** masber has joined #openstack-ansible11:47
*** odyssey4me has quit IRC12:07
*** odyssey4me has joined #openstack-ansible12:08
*** init has joined #openstack-ansible12:19
*** Kande has joined #openstack-ansible12:26
KandeHello!12:26
*** savvas has joined #openstack-ansible12:32
*** savvas has joined #openstack-ansible12:32
KandeHello! Yesterday i exectuded 3 playbooks. In the yml file (openstack_user_config.yml) i defined cidr_networks:   container: 172.18.1.0/24   tunnel: 10.0.1.0/24   storage: 10.0.2.0/24 used_ips:   - "172.18.1.99,172.18.1.254"   - "10.0.1.100,10.0.1.254"   - "10.0.2.1,10.0.2.10"   - "10.0.2.100,10.0.2.254".  But somehow if I execute lxc-info <container> the ip is 10.0.3.0/24. Am I missing something?12:38
*** savvas_ has joined #openstack-ansible12:38
*** chhagarw has quit IRC12:40
*** savvas_ has quit IRC12:40
*** savvas has quit IRC12:42
*** radeks has joined #openstack-ansible12:52
*** 07IACPO2U has joined #openstack-ansible12:58
*** dave-mccowan has joined #openstack-ansible13:10
*** dave-mcc_ has joined #openstack-ansible13:14
*** dave-mccowan has quit IRC13:16
*** madhu has quit IRC13:20
*** init has quit IRC13:20
*** Kande has quit IRC13:21
*** nyloc has quit IRC13:25
*** nyloc has joined #openstack-ansible13:27
*** radeks has quit IRC13:42
*** savvas has joined #openstack-ansible14:15
*** savvas has quit IRC14:22
*** savvas has joined #openstack-ansible14:22
*** savvas_ has joined #openstack-ansible14:32
d34dh0r53Kande: The 10.0.3.x network is the LXC internal network (https://docs.openstack.org/project-deploy-guide/openstack-ansible/pike/overview-network-arch.html) the networks defined in openstack_user_config are attached to the br-{mgmt, storage, vxlan, vlan} networks that openstack uses14:34
*** savvas has quit IRC14:35
*** savvas has joined #openstack-ansible14:37
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598714:38
*** savvas_ has quit IRC14:41
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598714:41
openstackgerritDoug Hellmann proposed openstack/openstack-ansible master: add lower-constraints job  https://review.openstack.org/55602614:45
openstackgerritMerged openstack/openstack-ansible-lxc_hosts master: Copy the "locale" into base container image  https://review.openstack.org/55597114:46
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-apt_package_pinning master: add lower-constraints job  https://review.openstack.org/55602714:46
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-ceph_client master: add lower-constraints job  https://review.openstack.org/55602814:46
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-galera_client master: add lower-constraints job  https://review.openstack.org/55602914:46
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-galera_server master: add lower-constraints job  https://review.openstack.org/55603014:46
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-haproxy_server master: add lower-constraints job  https://review.openstack.org/55603114:46
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-lxc_container_create master: add lower-constraints job  https://review.openstack.org/55603214:47
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-lxc_hosts master: add lower-constraints job  https://review.openstack.org/55603314:47
openstackgerritDoug Hellmann proposed openstack/openstack-ansible-memcached_server master: add lower-constraints job  https://review.openstack.org/55603414:47
*** savvas has quit IRC14:48
openstackgerritMerged openstack/openstack-ansible-lxc_container_create master: Allow deployers to define the container type  https://review.openstack.org/55438914:52
*** 07IACPO2U has quit IRC14:53
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598714:54
*** savvas has joined #openstack-ansible14:56
openstackgerritMerged openstack/openstack-ansible-lxc_container_create master: Add container journal linking  https://review.openstack.org/55370714:58
*** savvas has quit IRC15:00
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598715:06
*** savvas has joined #openstack-ansible15:09
*** savvas has quit IRC15:14
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598715:14
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_cinder master: Execute cinder_backends on the last API server  https://review.openstack.org/55604615:15
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_cinder master: Execute cinder_backends on the last API server  https://review.openstack.org/55604615:20
odyssey4meevrardjp jmccrory hwoarang logan- I think https://review.openstack.org/556046 may be the simplest way of solving that cinder API LB issue.15:23
*** radeks has joined #openstack-ansible15:31
*** masber has quit IRC15:32
*** masuberu has joined #openstack-ansible15:32
*** savvas has joined #openstack-ansible15:36
*** savvas has quit IRC15:41
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598715:44
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598715:53
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598716:03
*** sawblade_ has quit IRC16:08
evrardjphey odyssey4me16:12
evrardjphow are you today?16:12
evrardjpI will check very quick16:12
evrardjpodyssey4me: it looks good to me indeed16:14
evrardjpdepends on the rise time though16:14
logan-there are a lot of retries on the task16:15
logan-so hopefully that wont be an issue16:15
logan-also assuming a 3 node infra you get 2 role runs (api1 and then api2) for the endpoint to come up16:18
*** openstackgerrit has quit IRC16:18
evrardjp2 role runs?16:18
evrardjpYou mean the serialization steps in?16:18
evrardjpnot so sure to understand16:19
logan-yeah it is in serial, so it deploys api1, brings api1 endpoint up, deploys api2, api2 endpoint up, and then api3 runs and you get most of api3's run before it will ever try to use the LB endpoint16:19
evrardjpI think it's worth merging if it's not breaking anything, it can't do worse than what it is right now16:19
evrardjpyeah if it's serialized enough we should be fine16:19
logan-++ hope so16:20
evrardjpbut the serialization should have the same order as the inventory, which is the case by default16:20
evrardjpit's just a more hidden thing :)16:20
evrardjpI voted positively, I have to go for now16:21
evrardjpI've checked experimental16:21
evrardjpif it's not merged when I come back and the integrated role passes, I'll merge itby then16:21
evrardjpttyl16:22
logan-ok.just fyi experimental won't tell us anything about the fix because all lb management tasks skip in the gate due to only 1 cinder-api being present16:22
*** savvas has joined #openstack-ansible16:26
*** savvas has quit IRC16:30
*** openstackgerrit has joined #openstack-ansible16:39
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598716:39
*** savvas has joined #openstack-ansible16:43
*** cjloader has joined #openstack-ansible16:45
*** cjloader has quit IRC16:46
*** cjloader has joined #openstack-ansible16:47
*** cjloader has quit IRC16:52
*** cjloader has joined #openstack-ansible16:53
*** savvas has quit IRC17:00
*** savvas has joined #openstack-ansible17:00
*** gkadam has quit IRC17:01
*** savvas has quit IRC17:07
*** savvas has joined #openstack-ansible17:07
*** savvas has quit IRC17:22
*** cjloader has quit IRC17:24
*** radeks_ has joined #openstack-ansible17:27
*** radeks has quit IRC17:27
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598717:31
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: Only su within container if container_user is provided  https://review.openstack.org/55604917:31
evrardjplogan-: I know that part, but at least it won't break things.17:31
logan-yeah17:31
evrardjpthat's all I wanted to test on this patch :)17:31
logan-gotcha17:31
*** savvas has joined #openstack-ansible17:31
evrardjpfirst no regressions, then hoping it would fix things until we have real multi nodes in gates :)17:31
evrardjplogan-: what's the reason for the sudden docker love?17:32
evrardjpI am not against, I am just curious about the use case17:32
logan-idk just felt like adding it last night because it is a very small change. didnt realize getting testing working was going to be 1/2 day17:32
evrardjp:D17:33
logan-it is handy for me to be able to connect to docker remotely too17:33
*** radeks_ has quit IRC17:33
logan-the docker connection plugin that exists is like the upstream lxc plugin, it can only work on localhost containers17:33
evrardjpdoesn't ansible ship already something for docker connections?17:33
logan-yep ^17:33
evrardjpok17:33
*** savvas has quit IRC17:33
logan-i think we should try to upstream the connection plugin once it is uncoupled from the strategy plugin in 2.517:34
*** savvas has joined #openstack-ansible17:34
evrardjpI agree17:38
logan-its an excellent plugin but requires a lot of upkeep. if we can get wider usage on it, it might help with that.17:39
evrardjpagreed once more17:39
*** savvas has quit IRC17:39
*** savvas has joined #openstack-ansible17:40
evrardjpansible will strip a lot of things from the core, but I think it would be good to have this included into some kind of agreement with the cores of ansible17:40
evrardjpmutual agreement of shared ownership17:41
*** savvas has quit IRC17:41
evrardjp(because we won't be able to just dump it I think)17:41
logan-yeah they have some kind of thing implemented for community maintained modules that allows external maintenance17:41
*** savvas has joined #openstack-ansible17:41
evrardjpI meant ofc simply rely on them to do the right thing17:41
logan-so i wouldn't expect it'll replace ssh.py but you could have a community module ssh_container.py maybe, where OSA has the ability to merge PRs via ansibot17:42
evrardjpyeah17:42
evrardjpI am fine with pushing that more17:44
evrardjpI will discuss that next week17:44
evrardjpthanks for the reminder17:44
logan-cool. no prob.17:44
evrardjpin the meantime, thanks for the patches on docker support :)17:45
evrardjpand for improvement of the testing!17:45
logan-it is easy thanks to cloudnull's nsenter stuff17:45
evrardjpI have yet to check what's the real difference with a nsenter -a -t and the lxc-attach17:46
evrardjpI expect the env var cleanup doesn't happen17:46
evrardjpbut I will read the code17:46
*** savvas has quit IRC17:46
logan-yea thats a good question. ansible runs in a /bin/sh wrapper so id think we have a clear env there17:47
logan-in a /bin/sh wrapper inside the container*17:48
*** savvas has joined #openstack-ansible17:49
*** savvas has quit IRC17:51
openstackgerritLogan V proposed openstack/openstack-ansible-plugins master: [WIP] Docker support in ssh connection plugin  https://review.openstack.org/55598717:51
*** gkadam has joined #openstack-ansible17:52
*** savvas has joined #openstack-ansible17:52
*** masuberu has quit IRC17:54
*** gkadam has quit IRC17:55
*** savvas has quit IRC17:59
*** savvas has joined #openstack-ansible18:01
*** savvas has quit IRC18:03
*** savvas has joined #openstack-ansible18:13
*** savvas has quit IRC18:13
*** savvas has joined #openstack-ansible18:15
d34dh0r53https://review.openstack.org/#/c/556046 looks good to me, are we good to merge?18:15
logan-seems fine to me, can always iterate from here if the problem persists18:16
d34dh0r53cool18:16
*** savvas has quit IRC18:17
*** savvas has joined #openstack-ansible18:25
*** savvas has quit IRC18:29
*** savvas has joined #openstack-ansible18:29
*** haad1 has joined #openstack-ansible18:37
*** savvas has quit IRC18:39
*** savvas has joined #openstack-ansible18:44
*** savvas has quit IRC18:49
*** savvas has joined #openstack-ansible18:49
*** epalper has joined #openstack-ansible18:49
*** savvas has quit IRC18:53
*** savvas has joined #openstack-ansible18:59
*** savvas has quit IRC19:04
*** savvas has joined #openstack-ansible19:04
xdfilI'm trying to migrate a cinder volume backed VM (iscsi) from a local disk compute host, to a rbd compute host, and getting incompatability response...19:06
xdfilhttp://libvirt.org/html/libvirt-libvirt-host.html#virCPUCompareResult19:06
xdfilIt shouldn't really matter though right?19:06
*** epalper has quit IRC19:06
xdfilthe VM has no dependency on the compute hosts instance storage... or does it?19:07
*** savvas has quit IRC19:10
logan-xdfil: probably unrelated to storage19:12
xdfilits the only difference though19:13
logan-are you trying to live migrate a long running instance where the src/dest hosts have different versions of libvirt packages19:13
logan-libvirt/qemu packages*19:13
logan-or rather, the instance was started when older packages were installed19:13
xdfilnope these were all update in the last 24 hours19:13
xdfiland i can migrate rbd backed between rbd backed hosts19:14
xdfiland non-rbd backed between all the other hosts19:14
logan-usually ill see this when the machine type has changed19:14
xdfiljust cant do non-rbd backed VM >> rbd host19:14
logan-can you hard reboot it and then migrate19:14
xdfilya, hard reboot?19:15
logan-to force regen of the instance xml19:15
xdfilsame issue19:18
*** savvas has joined #openstack-ansible19:18
logan-odd19:19
xdfilusually when its a libvirt version difference the error will be about a certain CPU feature being missing19:20
xdfilthis time the error is InvalidCPUInfo: Unacceptable CPU info: CPU doesn't have compatibility.  019:21
xdfilits a different message19:21
logan-identical /proc/cpuinfo in src/dest?19:22
xdfilyup exact same19:22
logan-:/19:23
*** savvas has quit IRC19:23
xdfileh, its a lower priority issue for me right now19:23
xdfilI have enough of both types of computes. I just wont change all of them to rbd just yet19:24
*** savvas has joined #openstack-ansible19:25
openstackgerritMerged openstack/openstack-ansible-os_cinder master: Execute cinder_backends on the last API server  https://review.openstack.org/55604619:29
openstackgerritLogan V proposed openstack/openstack-ansible-os_cinder stable/queens: Execute cinder_backends on the last API server  https://review.openstack.org/55605219:30
logan-does that need a backport to pike also ^19:31
*** savvas has quit IRC19:33
*** savvas has joined #openstack-ansible19:38
*** savvas has quit IRC19:48
xdfil"flavor" is a terrible word19:51
*** savvas has joined #openstack-ansible19:55
openstackgerritMerged openstack/openstack-ansible-ops master: Adding mnaio qemu file backends  https://review.openstack.org/54909719:56
*** savvas has quit IRC20:08
*** savvas has joined #openstack-ansible20:08
*** haad1 has quit IRC20:08
*** savvas has quit IRC20:17
*** savvas has joined #openstack-ansible20:17
*** savvas has quit IRC20:21
*** hamza21 has quit IRC20:23
*** savvas has joined #openstack-ansible20:38
*** savvas has quit IRC20:43
*** savvas has joined #openstack-ansible20:44
*** savvas has quit IRC20:50
*** savvas has joined #openstack-ansible20:50
*** savvas has quit IRC20:54
*** savvas has joined #openstack-ansible20:56
*** savvas has quit IRC20:59
*** savvas has joined #openstack-ansible21:01
*** savvas has quit IRC21:03
*** savvas has joined #openstack-ansible21:08
*** savvas has quit IRC21:11
*** savvas has joined #openstack-ansible21:14
*** savvas has quit IRC21:15
*** savvas has joined #openstack-ansible21:15
xdfilodyssey4me:  I wrote comments on https://review.openstack.org/#/c/555981/ but I'm not sure if i'm saving them right heh21:17
*** savvas has quit IRC21:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_cinder stable/pike: Execute cinder_backends on the last API server  https://review.openstack.org/55607221:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_cinder stable/pike: Execute cinder_backends on the last API server  https://review.openstack.org/55607221:22
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_cinder stable/ocata: Execute cinder_backends on the last API server  https://review.openstack.org/55607321:24
*** savvas has joined #openstack-ansible21:24
*** sawblade6 has joined #openstack-ansible21:26
*** savvas has quit IRC21:30
odyssey4mexdfil if you've added comments, you need to submit a 'reply' for them to actually be submitted21:30
xdfilAhh yes! there we go21:30
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_nova master: Rebuild venv if missing  https://review.openstack.org/55600321:35
*** savvas has joined #openstack-ansible21:39
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_glance master: Rebuild venv if missing  https://review.openstack.org/55600521:40
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_neutron master: Rebuild venv if missing  https://review.openstack.org/55601321:41
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_cinder master: Rebuild venv if missing  https://review.openstack.org/55599921:42
*** savvas has quit IRC21:44
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607421:46
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607421:50
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607421:51
*** savvas has joined #openstack-ansible21:54
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607422:03
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607422:03
*** savvas has quit IRC22:05
xdfilI'm playing with Gerrit, long overdue....22:05
xdfillook what I made though!22:05
xdfilhttps://review.openstack.org/#/q/projects:openstack%252Fopenstack-ansible22:05
xdfila URL that shows me all the OSA (and roles) changes... thats crazy22:06
odyssey4mexdfil ;) https://review.openstack.org/#/q/project:%22%255E(openstack%257Copenstack-infra)/(monitorstack%257Copenstack-ansible%257Cansible-%257Cdevstack-gate).*%22+status:open22:06
odyssey4mewell, here's a shorter one without the devstack thing: https://review.openstack.org/#/q/project:%22%255Eopenstack/(monitorstack%257Copenstack-ansible%257Cansible-).*%22+status:open22:07
xdfilYeah, this is cool heh22:07
xdfilI already like it better than jira lol22:08
odyssey4mehaha, it's purpose specific - whereas jira is a bit more generalist22:08
*** prometheanfire has quit IRC22:10
xdfilyeah issue statuses in Jira have bugged me when people have their own opinion of what the status means22:13
*** savvas has joined #openstack-ansible22:14
*** savvas has quit IRC22:16
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607422:16
*** savvas has joined #openstack-ansible22:16
*** sawblade_ has joined #openstack-ansible22:24
xdfilodyssey4me:  So this is an example of the new role structure ? https://review.openstack.org/#/projects/openstack/ansible-role-python_venv_build,dashboards/default22:27
*** sawblade6 has quit IRC22:27
xdfilis there something I can read that has an overview of the structure in general ?22:28
*** sawblade6 has joined #openstack-ansible22:30
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607422:33
*** sawblade_ has quit IRC22:33
*** savvas has quit IRC22:34
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add OpenStack CI and docs/releasenotes scaffolding  https://review.openstack.org/55607422:34
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add CI/docs/releasenotes scaffolding and basic test  https://review.openstack.org/55607422:35
odyssey4melogan- there's an improvement suggestion in https://review.openstack.org/555981 which simplifies how that's all done22:38
*** prometheanfire has joined #openstack-ansible22:38
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-role-python_venv_build master: Add CI/docs/releasenotes scaffolding and basic test  https://review.openstack.org/55607422:42
xdfilodyssey4me:  on https://review.openstack.org/555981 doesn't your suggestion conflict with the non-prebuilt venvs?22:50
odyssey4mexdfil whether using developer mode or not - that folder must exist, so there's no need for the folder creation task to have a conditional22:50
xdfilagree, but later on we are also going to unarchive the venv based on if we made the directory22:51
odyssey4mebut that's only one of the conditionals22:52
xdfiloh wait is there another conditional22:52
xdfildang ya22:52
xdfilyou right22:52
xdfilSee thats what i said to logan-  last night lol22:52
odyssey4meyep, it's either if the extract happened OR the directory got created22:52
odyssey4meif both happened, it still activates the task22:52
xdfilyeah when I saw that var I thought to myself that when it was made the author probably had that intent and then forgot22:53
xdfilI was really stuck on that issue lol22:54
xdfilI didn't notice it was the existence of the cached image that was making it skip it was driving me nuts22:55
odyssey4meyeah, it's a good bug to catch that one - a simple oversight, really22:58
odyssey4mewith thanks to your report, someone else won't find themselves in the same predicament22:58
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_glance master: Rebuild venv if missingIf a deployer removes a venv from /openstack/venvs and runs the role in an attempt to re-deploy the venv from the same tag, the role will fail. This is because the venv archive in /var/cache is still present with the same checksum,   https://review.openstack.org/55609123:09
xdfildamin i did it wrong23:10
xdfilI was trying to update my previous change not submit a new one :)23:11
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_glance master: Rebuild venv if missing  https://review.openstack.org/55609123:12
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_glance master: Rebuild venv if missing  https://review.openstack.org/55609123:14
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_keystone master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609223:17
odyssey4mexdfil you need to 'git commit --amend' to ensure that they're all in one commit23:17
xdfilyeah I was being lazy and trying to do it with VScode23:18
odyssey4mepatch storm coming in - apologies23:18
odyssey4meyou should be able to amend a commit with VScode23:18
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_almanach master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609323:18
xdfilyou're going to wake the baby!23:18
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_aodh master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609423:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_barbican master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609523:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_ceilometer master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609623:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_cinder master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609723:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_cloudkitty master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609823:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_congress master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55609923:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_designate master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610023:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_gnocchi master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610123:19
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_heat master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610223:20
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_horizon master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610323:20
evrardjpthanks for the spam odyssey4me !23:20
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_ironic master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610423:20
evrardjpit woke me up! :p23:20
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_magnum master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610523:20
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_monasca master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610623:20
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_neutron master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610723:20
evrardjpthanks for the patches :)23:20
logan-thanks @ the notes xdfil odyssey4me will fix that up23:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_nova master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610823:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_octavia master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55610923:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_rally master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611023:21
logan-odyssey4me just to understand better if you have a sec I'd like to know what broke between pike and queens here https://review.openstack.org/#/c/556072/23:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_sahara master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611123:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_searchlight master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611223:21
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_cinder master: Rebuild venv if missing  https://review.openstack.org/55599923:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_swift master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611323:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_tacker master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611423:21
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_tempest master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611523:22
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_trove master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611623:22
*** dave-mcc_ has quit IRC23:22
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_watcher master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611723:22
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-os_zaqar master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611823:22
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-tests master: ansible-role-requirements: Add common python_venv_build role  https://review.openstack.org/55611923:22
odyssey4melogan- pike has a different service setup order to queens, thanks to a patch from jmccrory - I'm not sure if there was intent to backport it to pike and older23:23
odyssey4memaster/queens uses the cinder-api group here: https://github.com/openstack/openstack-ansible-os_cinder/blob/master/tasks/main.yml#L9923:24
odyssey4mepike and older use the cinder_volume group: https://github.com/openstack/openstack-ansible-os_cinder/blob/stable/pike/tasks/main.yml#L9923:24
odyssey4memaster/queens orders the play with scheduler, volume, backup, api: https://github.com/openstack/openstack-ansible/blob/master/playbooks/os-cinder-install.yml#L60-L8823:25
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_nova master: Rebuild venv if missing  https://review.openstack.org/55600323:25
odyssey4mepike and older does api, scheduler, volume, backup: https://github.com/openstack/openstack-ansible/blob/stable/pike/playbooks/os-cinder-install.yml#L61-L8923:25
odyssey4melogan- does all that make sense, and highlight why pike's working ok - but queens is not?23:27
odyssey4mejmccrory so I guess something we should follow up on is whether https://review.openstack.org/528140 should be ported back to pike/ocata/newton?23:28
odyssey4meit doesn't seem necessary - perhaps it's more optimal, but perhaps the resulting pain isn't really worth it23:28
openstackgerritFilippo DiNoto proposed openstack/openstack-ansible-os_neutron master: Rebuild venv if missing  https://review.openstack.org/55601323:29
logan-yeah that makes sense23:29
logan-why it broke makes sense i mean23:29
logan-but it seems like running cinder_backends scoped to cinder_volume makes more sense23:30
logan-because that is where the backends are configured23:30
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/openstack-ansible-tests master: Add common python_venv_build role  https://review.openstack.org/55611923:30
odyssey4melogan- yep, and it was previously - until jmccrory submitted https://github.com/openstack/openstack-ansible-os_cinder/commit/6c976e5077b03066f26f8b9d65c9071828419d9f#diff-2444ad0870f91f17ca6c2a5e96b2682323:31
logan-yea23:31
odyssey4megiven the ordering change, it makes sense23:32
logan-ah23:32
logan-yeah since api is deployed last now23:32
odyssey4meyup, it's an odd ordering - but apparently that's what cinder docs suggest as ordering, so meh23:33
odyssey4meI guess it makes sense to implement back-end services, then the API which contacts them.23:33
openstackgerritMerged openstack/openstack-ansible master: Disable ceph-ansible NTP installation  https://review.openstack.org/54963823:34
openstackgerritMerged openstack/openstack-ansible master: [Docs] Include OpenStack-Ansible Manifesto  https://review.openstack.org/55590323:34
logan-yeah ¯\_(ツ)_/¯... thanks for explaining why it broke though23:35
odyssey4meevrardjp sorry for waking you up!23:35
odyssey4melogan- oh, it's my pleasure23:35
*** prometheanfire has quit IRC23:36
odyssey4meapologies for not realising all that sooner - I know that a bunch of people were trying to figure out a way around the problem.23:36
odyssey4meBut meh, at least we found a way to solve it. :)23:37
*** prometheanfire has joined #openstack-ansible23:37
odyssey4mexdfil could you do one more thing in those reviews to help make it easier to work through them in one go?23:38
xdfilwhatsup23:38
odyssey4meset the 'topic' (or git branch) to the same as the one in https://review.openstack.org/55598123:38
odyssey4methat way it's really easy in gerrit to find all the same patches across the roles and work through them in one go :)23:38
odyssey4meright now they're likely to get lost in the woods of all other patches going on23:39
odyssey4mexdfil make sense?23:41
xdfilodyssey4me:  yes, done (i think)23:41
odyssey4methanks23:42
odyssey4melet's get one of those merged to finalise the pattern - reviewing now23:42
xdfilodyssey4me:  was the topic there on the logans original submit or did you add that or?23:42
xdfilor in other words, should I be setting topics all the time lol23:43
odyssey4mexdfil the topic comes from the git branch you use, and typically in a git workflow you would checkout master, update it, then create the new branch which describes what you're going to do briefly23:44
odyssey4methat becomes your 'bug' or 'feature' branch23:44
odyssey4megerrit takes the branch name and makes it the 'topic'23:45
xdfilso the topic is just make beleive23:45
odyssey4melogan- added that topic for his original patch23:45
xdfilI mean23:45
odyssey4mea topic's a really good way of relating patches23:45
odyssey4meso, for example, if you want to see all the patches that's been done in the python build simplificattion work, you can just use the topic: https://review.openstack.org/#/q/topic:bp/python-build-install-simplification+(status:open+OR+status:merged)23:46
xdfilyeah looks that way23:46
odyssey4meso, generally, if you're doing a one-off patch then a topic isn't necessary23:47
xdfilbut within git, the topic is just more characters appended to an existing branch name, to create a new branch23:47
odyssey4mebut if you're making a related set of changes across multiple repositories, then the topic is super-handy for reviewers because they can see all the related patches very quickly and easily23:48
odyssey4menope, in git there is no such thing as a topic - the branch name is translated by gerrit into the topic23:48
openstackgerritLogan V proposed openstack/openstack-ansible-os_keystone master: Rebuild venv if missing  https://review.openstack.org/55598123:48
xdfilbut/and since we're using git-review we don't have to make new branches in git because gerrit23:49
xdfilok i think you made me a little smarter today23:50
openstackgerritLogan V proposed openstack/openstack-ansible-os_keystone master: Rebuild venv if missing  https://review.openstack.org/55598123:50
odyssey4melogan- tbh I think I like the approach done by xdfil in https://review.openstack.org/#/c/555999/3/tasks/cinder_install.yml - it's just ever so slightly easier to follow23:52
odyssey4mehmm, the use of block works too23:53
logan-im going to move the block above the install task23:53
xdfilblocks are just like nesting if statements ?23:53
logan-so it is less broken up23:54
odyssey4melogan- yeah, makes sense23:54
xdfilI've never used a block before hehe23:54
odyssey4mexdfil sort of http://docs.ansible.com/ansible/latest/playbooks_blocks.html23:54
openstackgerritLogan V proposed openstack/openstack-ansible-os_keystone master: Rebuild venv if missing  https://review.openstack.org/55598123:54
logan-you can do other stuff with blocks but yeah one thing is applying the same condition to multiple tasks23:55
logan-there hows that look ^23:55
odyssey4melogan- not sure if we want to apply this pattern generally, but I find https://github.com/openstack/ansible-role-python_venv_build/blob/master/tasks/python_venv_build.yml#L65-L67 a way to more easily get to grips with a block/conditional23:56
odyssey4meI often find that the conditional gets lost when using it for a block.23:56
logan-so put it at the beginning23:56
logan-i like that23:56
odyssey4meunfortunately that doesn't work with ansible 2.1, because it doesn't support naming blocks - but meh, that's newton :p23:57
openstackgerritLogan V proposed openstack/openstack-ansible-os_keystone master: Rebuild venv if missing  https://review.openstack.org/55598123:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!