Wednesday, 2016-01-13

*** apuimedo has quit IRC00:00
*** raddaoui has quit IRC00:01
*** apuimedo has joined #openstack-ansible00:02
*** jmccrory has quit IRC00:04
*** jmccrory- is now known as jmccrory00:04
*** apuimedo has quit IRC00:10
*** apuimedo has joined #openstack-ansible00:11
*** cemmason has joined #openstack-ansible00:14
*** cemmason1 has quit IRC00:15
*** sigmavirus24 is now known as sigmavirus24_awa00:21
*** sdake has joined #openstack-ansible00:24
*** apuimedo has quit IRC00:30
*** cemmason has quit IRC00:31
*** apuimedo has joined #openstack-ansible00:31
*** cemmason has joined #openstack-ansible00:31
*** cemmason1 has joined #openstack-ansible00:35
*** cemmason has quit IRC00:36
*** apuimedo has quit IRC00:36
jmccroryodyssey4me cloudnull could gate-openstack-ansible-dsvm-commit be added to the independent roles' merge gate list?00:37
*** apuimedo has joined #openstack-ansible00:37
*** Mudpuppy has joined #openstack-ansible00:41
*** Mudpuppy has quit IRC00:42
*** apuimedo has quit IRC00:42
*** Mudpuppy has joined #openstack-ansible00:42
*** apuimedo has joined #openstack-ansible00:43
*** Mudpuppy has quit IRC00:43
*** Mudpuppy has joined #openstack-ansible00:44
*** spotz_zzz is now known as spotz00:50
*** Mudpuppy has quit IRC00:50
*** Mudpuppy has joined #openstack-ansible00:50
*** apuimedo has quit IRC00:52
*** apuimedo has joined #openstack-ansible00:52
*** cemmason1 has quit IRC00:56
*** cemmason has joined #openstack-ansible00:56
*** tlian has quit IRC00:57
*** apuimedo has quit IRC00:57
*** apuimedo has joined #openstack-ansible00:58
*** cemmason1 has joined #openstack-ansible00:59
*** cemmason has quit IRC00:59
*** eil397 has quit IRC01:02
*** apuimedo has quit IRC01:03
*** Mudpuppy has quit IRC01:04
*** tlian has joined #openstack-ansible01:04
*** apuimedo has joined #openstack-ansible01:04
*** Mudpuppy has joined #openstack-ansible01:04
*** Mudpuppy has quit IRC01:05
*** Mudpuppy has joined #openstack-ansible01:10
*** apuimedo has quit IRC01:11
*** apuimedo has joined #openstack-ansible01:12
*** jguy_ has joined #openstack-ansible01:12
*** tlian has quit IRC01:13
*** tlian has joined #openstack-ansible01:13
*** cemmason has joined #openstack-ansible01:15
*** cemmason1 has quit IRC01:15
*** cemmason has quit IRC01:18
*** cemmason has joined #openstack-ansible01:18
*** apuimedo has quit IRC01:19
*** apuimedo has joined #openstack-ansible01:20
openstackgerritwangyouwei proposed openstack/openstack-ansible: Trivial: Remove vim header from source files  https://review.openstack.org/26662401:23
*** eil397 has joined #openstack-ansible01:23
*** apuimedo has quit IRC01:24
*** apuimedo has joined #openstack-ansible01:25
*** CheKoLyN has joined #openstack-ansible01:29
*** tlian has quit IRC01:30
*** apuimedo has quit IRC01:34
*** apuimedo has joined #openstack-ansible01:36
*** baker_ has quit IRC01:37
openstackgerritNolan Brubaker proposed openstack/openstack-ansible: Add testing for dynamic_inventory.py  https://review.openstack.org/24222501:38
*** apuimedo has quit IRC01:41
*** apuimedo has joined #openstack-ansible01:41
openstackgerritNolan Brubaker proposed openstack/openstack-ansible: Add testing for dynamic_inventory.py  https://review.openstack.org/24222501:42
*** cemmason has quit IRC01:44
*** cemmason has joined #openstack-ansible01:45
Mudpuppystand back, I'm bashing a bug lol01:57
spotzI apologize in advance for mudpuppy's bashing:)01:58
*** eil397 has quit IRC01:59
openstackgerritNolan Brubaker proposed openstack/openstack-ansible: Add testing for dynamic_inventory.py  https://review.openstack.org/24222501:59
*** apuimedo has quit IRC02:00
*** apuimedo has joined #openstack-ansible02:01
openstackgerritNolan Brubaker proposed openstack/openstack-ansible: Add testing for dynamic_inventory.py  https://review.openstack.org/24222502:04
palendae4th time's the charm02:04
spotzof 5th or 6th...:)02:06
*** apuimedo has quit IRC02:08
*** apuimedo has joined #openstack-ansible02:10
*** weezS has quit IRC02:11
*** cemmason has quit IRC02:14
*** cemmason has joined #openstack-ansible02:14
*** apuimedo has quit IRC02:16
*** apuimedo has joined #openstack-ansible02:17
*** apuimedo has quit IRC02:22
*** apuimedo has joined #openstack-ansible02:22
*** apuimedo has quit IRC02:27
*** apuimedo has joined #openstack-ansible02:27
*** jguy_ has quit IRC02:29
openstackgerritDennis DeMarco proposed openstack/openstack-ansible: Correct CLI command for install verification  https://review.openstack.org/26664102:33
MudpuppyYESSSS02:34
spotzI need a drink.... :)02:35
*** cemmason has quit IRC02:42
*** Mudpuppy has quit IRC02:42
*** cemmason has joined #openstack-ansible02:43
*** apuimedo has quit IRC02:44
*** spotz is now known as spotz_zzz02:44
*** apuimedo has joined #openstack-ansible02:45
*** cemmason1 has joined #openstack-ansible02:46
*** cemmason has quit IRC02:47
*** cemmason1 has quit IRC02:49
*** cemmason has joined #openstack-ansible02:49
*** cemmason1 has joined #openstack-ansible02:53
*** cemmason has quit IRC02:53
*** apuimedo has quit IRC03:01
*** sigmavirus24_awa is now known as sigmavirus2403:02
*** apuimedo has joined #openstack-ansible03:02
*** cemmason1 has quit IRC03:05
*** apuimedo has quit IRC03:07
*** apuimedo has joined #openstack-ansible03:08
*** cemmason has joined #openstack-ansible03:08
*** apuimedo has quit IRC03:15
*** apuimedo has joined #openstack-ansible03:16
*** woodard has quit IRC03:22
*** jguy_ has joined #openstack-ansible03:23
*** baker has joined #openstack-ansible03:28
*** apuimedo has quit IRC03:30
*** apuimedo has joined #openstack-ansible03:31
*** sigmavirus24 is now known as sigmavirus24_awa03:32
*** apuimedo has quit IRC03:35
*** apuimedo has joined #openstack-ansible03:36
*** baker_ has joined #openstack-ansible03:36
*** baker has quit IRC03:39
*** apuimedo has quit IRC03:43
*** apuimedo has joined #openstack-ansible03:44
*** apuimedo has quit IRC03:49
*** apuimedo has joined #openstack-ansible03:50
*** apuimedo has quit IRC03:57
*** apuimedo has joined #openstack-ansible03:57
*** apuimedo has quit IRC04:02
*** apuimedo has joined #openstack-ansible04:03
*** jguy_ has quit IRC04:05
*** apuimedo has quit IRC04:08
*** apuimedo has joined #openstack-ansible04:09
*** baker_ has quit IRC04:12
*** metral is now known as metral_zzz04:12
*** apuimedo has quit IRC04:18
*** apuimedo has joined #openstack-ansible04:19
*** apuimedo has quit IRC04:23
*** woodard has joined #openstack-ansible04:24
*** apuimedo has joined #openstack-ansible04:24
*** woodard has quit IRC04:28
*** apuimedo has quit IRC04:29
*** apuimedo has joined #openstack-ansible04:30
*** prometheanfire has quit IRC04:32
*** shausy has joined #openstack-ansible04:32
*** prometheanfire has joined #openstack-ansible04:33
*** apuimedo has quit IRC04:42
*** apuimedo has joined #openstack-ansible04:42
*** sdake_ has joined #openstack-ansible04:47
*** apuimedo has quit IRC04:47
*** apuimedo has joined #openstack-ansible04:48
*** sdake has quit IRC04:48
*** woodard has joined #openstack-ansible04:49
*** apuimedo has quit IRC04:52
*** sdake_ has quit IRC04:53
*** apuimedo has joined #openstack-ansible04:53
*** sdake has joined #openstack-ansible04:55
*** apuimedo has quit IRC05:04
*** apuimedo has joined #openstack-ansible05:05
*** raddaoui has joined #openstack-ansible05:06
*** apuimedo has quit IRC05:10
*** apuimedo has joined #openstack-ansible05:11
*** sdake has quit IRC05:16
*** apuimedo has quit IRC05:23
*** apuimedo has joined #openstack-ansible05:24
*** apuimedo has quit IRC05:28
*** apuimedo has joined #openstack-ansible05:30
*** metral_zzz is now known as metral05:33
*** shausy has quit IRC05:37
*** apuimedo has quit IRC05:37
*** apuimedo has joined #openstack-ansible05:38
*** apuimedo has quit IRC05:45
*** apuimedo has joined #openstack-ansible05:45
*** apuimedo has quit IRC05:56
*** apuimedo has joined #openstack-ansible05:56
*** apuimedo has quit IRC06:01
*** apuimedo has joined #openstack-ansible06:01
*** apuimedo has quit IRC06:06
*** apuimedo has joined #openstack-ansible06:08
*** javeriak has joined #openstack-ansible06:08
*** javeriak has quit IRC06:10
*** javeriak has joined #openstack-ansible06:10
*** apuimedo has quit IRC06:13
*** apuimedo has joined #openstack-ansible06:14
*** michaelgugino has quit IRC06:14
*** javeriak_ has joined #openstack-ansible06:14
*** CheKoLyN has quit IRC06:15
*** javeriak has quit IRC06:15
*** apuimedo has quit IRC06:18
*** apuimedo has joined #openstack-ansible06:20
*** apuimedo has quit IRC06:24
*** apuimedo has joined #openstack-ansible06:25
*** markvoelker has quit IRC06:27
*** apuimedo has quit IRC06:30
*** apuimedo has joined #openstack-ansible06:30
*** raddaoui has quit IRC06:31
*** apuimedo has quit IRC06:35
*** apuimedo has joined #openstack-ansible06:37
*** apuimedo has quit IRC06:41
*** apuimedo has joined #openstack-ansible06:41
*** phiche has joined #openstack-ansible06:45
*** apuimedo has quit IRC06:52
*** apuimedo has joined #openstack-ansible06:53
*** apuimedo has quit IRC07:03
*** apuimedo has joined #openstack-ansible07:03
*** robot_ has joined #openstack-ansible07:06
robot_Hi All07:06
*** robot_ is now known as Guest5285507:06
*** phiche1 has joined #openstack-ansible07:06
Guest52855if i create virtualenv inside any ansible container,  and inn I connct it with other containers?stall some packages there, how ca07:07
Guest52855if i create virtualenv inside any ansible container,  and install some packages there, how can I connct it with other containers?07:07
*** apuimedo has quit IRC07:08
*** apuimedo has joined #openstack-ansible07:08
*** phiche has quit IRC07:09
*** Guest52855 has quit IRC07:12
*** apuimedo has quit IRC07:25
*** apuimedo has joined #openstack-ansible07:26
*** markvoelker has joined #openstack-ansible07:28
*** apuimedo has quit IRC07:30
*** apuimedo has joined #openstack-ansible07:31
*** markvoelker has quit IRC07:33
*** apuimedo has quit IRC07:35
*** apuimedo has joined #openstack-ansible07:36
*** apuimedo has quit IRC07:47
*** woodard has quit IRC07:49
*** apuimedo has joined #openstack-ansible07:49
*** apuimedo has quit IRC07:53
*** apuimedo has joined #openstack-ansible07:54
*** mpavone has joined #openstack-ansible07:57
*** apuimedo has quit IRC07:59
*** adac has joined #openstack-ansible07:59
*** apuimedo has joined #openstack-ansible08:00
*** apuimedo has quit IRC08:05
*** apuimedo has joined #openstack-ansible08:06
*** apuimedo has quit IRC08:10
*** apuimedo has joined #openstack-ansible08:11
*** apuimedo has quit IRC08:20
*** apuimedo has joined #openstack-ansible08:21
*** apuimedo has quit IRC08:26
*** apuimedo has joined #openstack-ansible08:27
*** admin0 has joined #openstack-ansible08:29
*** apuimedo has quit IRC08:31
*** apuimedo has joined #openstack-ansible08:32
*** apuimedo has quit IRC08:36
*** apuimedo has joined #openstack-ansible08:37
*** apuimedo has quit IRC08:42
*** apuimedo has joined #openstack-ansible08:43
*** javeriak_ has quit IRC08:51
*** markvoelker has joined #openstack-ansible08:54
*** markvoelker has quit IRC08:59
*** apuimedo has quit IRC09:02
*** apuimedo has joined #openstack-ansible09:02
evrardjphello everyone09:21
*** apuimedo has quit IRC09:22
*** apuimedo has joined #openstack-ansible09:23
odyssey4mejmccrory it could, but that's not desirable - the whole point of the independent gating per role is for quicker turnaround... the parent repo with the plays in it will have multiple use-case tests which do integration of the roles and test that they all work together, whereas the role functional test is a minimal functional test09:30
*** javeriak has joined #openstack-ansible09:31
*** apuimedo has quit IRC09:33
*** apuimedo has joined #openstack-ansible09:34
*** apuimedo has quit IRC09:38
*** apuimedo has joined #openstack-ansible09:40
*** electrofelix has joined #openstack-ansible09:41
odyssey4memattt hughsaunders what do you think about the approach in https://review.openstack.org/266530 - it's either that concise approach, or adding two tasks for the module load and load at boot09:47
odyssey4meI've prepped a revised patch, but I don't want to push it unless the current patch isn't accepted09:47
*** apuimedo has quit IRC09:49
matttodyssey4me: why would you have a kernel 3.18?09:49
javeriakhey odyssey4me09:49
odyssey4memattt kernel >3.18 is the new defaults for Ubuntu 14.04 and is therefore popping up all over the place09:51
*** apuimedo has joined #openstack-ansible09:51
odyssey4mewithout that kernel module, stuff doesn't work09:51
hughsaundersodyssey4me: that template may leave you with an empty list item, will that cause problems?09:51
javeriakpep8 seems to have failed on my commit; cant really see anything in the pipeline output, https://review.openstack.org/#/c/265946/09:51
odyssey4mehughsaunders it seems to work just fine, even if it does create a blank line in /etc/modules09:52
hughsaundersodyssey4me: ok09:52
odyssey4memattt hughsaunders the explanation for why br_netfilter is needed is in https://review.openstack.org/266021 - my patch is to cater for cases where the kernel is <3.1809:52
odyssey4mejaveriak that's odd - it's throwing errors in the playbooks/library/* files - I wonder why it's suddenly starting to do that09:54
javeriakodyssey4me  maybe its a one off thing? dont know why pep8 would do that, anyway should i recheck?09:55
odyssey4mejaveriak it's odd because that should be happening for every single review09:55
javeriakyes it should; but i cant really tell what exactly its throwing the error on from the output09:56
odyssey4mejaveriak ah, it appears that it is happening for all reviews09:56
odyssey4mejaveriak here's an example of the error: http://logs.openstack.org/46/265946/1/gate/gate-openstack-ansible-pep8/54c9c1c/console.html#_2016-01-12_21_24_21_24709:57
odyssey4meie W503 line break before binary operator09:57
odyssey4methere are several e402's too09:57
javeriakah okay09:57
javeriakdo you guys use any pep8 checking scripts on your commits? otherwise i can share mine if you like09:58
openstackgerritHugh Saunders proposed openstack/openstack-ansible-openstack_hosts: Only implement br_netfilter module for kernels above version 3.18  https://review.openstack.org/26653009:58
javeriakfor the good of the community :)09:58
odyssey4mejaveriak the pep8 check can be done by executing 'tox -e pep8' on your workstation - that'll execute exactly the same check as in the gate09:59
javeriakalso odyssey4me, let me know when u have a few minutes, id like to discuss a package versioning strategy i need to implement for our bits in OSAD09:59
javeriakoh okay cool, looks like some patch missed doing that check09:59
odyssey4mejaveriak I think flake8 might have been updated, let me check10:00
matttodyssey4me: yeah not sure of a better approach really10:00
odyssey4mejaveriak pep8 went from 1.5.7 -> 1.7.0, that's why this is suddenly coming up10:02
odyssey4memattt so the only other approach is to add two tasks that are specifically catering for that module, each with their own 'when' statement10:03
odyssey4memattt hughsaunders well, that's the only other approach I can think of10:04
javeriakand the newer version implements stricter checks? that should be effecting a whole lot of stuff i imagine; do we need to comply with the new checks? do you need my help cleaning it up?10:04
odyssey4mejaveriak yeah, we'll need to either decide that the checks aren't relevant to us and therefore skip them, or we need to clean up the code10:04
odyssey4mejaveriak if you could help clean up that'd be fantastic - it'll all have to be done in one patch though10:05
javeriaksure, i can take a stab at it tonight; will tox -e pep8 only run on unmerged changes or the whole directory?10:06
javeriakyou can decide meanwhile whats relevent or not?10:06
hughsaundersodyssey4me: could make it a list of dicts, with a name and min_version key. But seems overkill for one item10:07
odyssey4metox -e pep8 will run whatever you have10:07
odyssey4mehughsaunders yeah, I thought of creating a dict with a module, and a condition for it being loaded... but it is very heavy handed for one item10:07
odyssey4mejaveriak I'll do a clean up patch now quickly10:08
javeriakalright thanks10:08
hughsaundersodyssey4me: I agree. I fixed the commit message and +2d #rebel10:09
odyssey4methanks hughsaunders - now we just need mattt to make a call :)10:09
matttcan you use {{ item }} in when?10:10
matttif so you could guard against it being an empty list item10:10
*** electrofelix has quit IRC10:13
odyssey4memattt it appears not10:13
odyssey4memattt the only issue with the blank line is that it carries into /etc/modules... it doesn't seem to have any side effects10:13
*** apuimedo has quit IRC10:14
*** apuimedo has joined #openstack-ansible10:15
odyssey4mehmm, maybe a ternery on state would work10:15
*** electrofelix has joined #openstack-ansible10:20
odyssey4memattt if I add the following to the lineinfile then it won't end up adding a blank line10:23
odyssey4mestate: "{{ (item == '') | ternary('absent','present') }}"10:23
odyssey4memattt hughsaunders thoughts on that idea?10:23
matttodyssey4me: dunno, maybe it's not worht it for a blank line, i don't think that file cares about whitespace10:26
*** apuimedo has quit IRC10:32
*** apuimedo has joined #openstack-ansible10:32
hughsaundersodyssey4me: I'm ok with either10:35
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26683210:41
*** apuimedo has quit IRC10:44
openstackgerritJesse Pretorius proposed openstack/openstack-ansible-galera_server: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26683410:44
*** apuimedo has joined #openstack-ansible10:45
*** permalac has joined #openstack-ansible10:46
*** apuimedo has quit IRC10:52
odyssey4memattt https://review.openstack.org/266530 is a gate unblocker - should we revert the patch that broke it, or vote this patch through?10:53
*** apuimedo has joined #openstack-ansible10:53
*** markvoelker has joined #openstack-ansible10:55
openstackgerritHugh Saunders proposed openstack/openstack-ansible: Use http request to check cinder api availability  https://review.openstack.org/25641410:57
jmccroryodyssey4me when: item != '' seems to work10:58
*** markvoelker has quit IRC11:00
odyssey4mejmccrory oh? can you pastebin your tasks that work? it didn't work for me11:01
matttodyssey4me: how did that other commit gate then?11:03
matttodyssey4me: i don't think it's worth reverting the other patch, since that just breaks stuff for others :)11:03
odyssey4memattt it used a nodepool image which had the right kernel version11:03
matttoh man infra need some consistency :(11:03
odyssey4meunfortunately it seems that not all nodepool images are created equal11:03
jmccroryhttp://paste.openstack.org/show/483728/11:05
*** apuimedo has quit IRC11:05
*** apuimedo has joined #openstack-ansible11:07
openstackgerritMerged openstack/openstack-ansible-openstack_hosts: Only implement br_netfilter module for kernels above version 3.18  https://review.openstack.org/26653011:09
*** alextricity25 has quit IRC11:09
*** hughsaunders has quit IRC11:10
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the nova ssh keys  https://review.openstack.org/26683911:10
odyssey4meheh, nice jmccrory :)11:11
*** alextricity25 has joined #openstack-ansible11:11
*** apuimedo has quit IRC11:11
*** apuimedo has joined #openstack-ansible11:12
*** hughsaunders has joined #openstack-ansible11:12
*** apuimedo has quit IRC11:16
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the swift ssh keys  https://review.openstack.org/26684011:16
*** apuimedo has joined #openstack-ansible11:17
openstackgerritMatt Thompson proposed openstack/openstack-ansible: [WIP] Redeploy venvs  https://review.openstack.org/26129311:20
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the keystone ssh keys  https://review.openstack.org/26684211:20
*** apuimedo has quit IRC11:22
*** apuimedo has joined #openstack-ansible11:22
odyssey4mejmccrory ping? is Michael around, or are you burning the midnight oil alone?11:26
matttodyssey4me: hopefully the change to https://review.openstack.org/261293 is what you had in mind :)11:26
jmccrory3:30 am here, having trouble sleeping. i think 6:30 for michael so he might be on with an hour or two11:27
*** apuimedo has quit IRC11:27
*** apuimedo has joined #openstack-ansible11:28
*** sdake has joined #openstack-ansible11:29
*** jguy_ has joined #openstack-ansible11:29
odyssey4mejmccrory I'm just thinking that the module backport is important, otherwise new deployments on updated kernels will fail... but obviously the backport is a combo of two patches so it's a little complex.11:31
odyssey4mejmccrory but we can wait for michael - he can learn how best to do it :)11:32
jmccrorywouldn't it just be your most recent patch that gets backported?11:32
odyssey4mejmccrory ah, you're quite right... although it won't be a clean pick11:33
odyssey4meideally I think I'd like the change content from https://review.openstack.org/266530 but with more of the commit message content from https://review.openstack.org/26602111:33
*** sdake has quit IRC11:34
odyssey4memattt I've commented in the patch.11:34
jmccroryhmm well i'll shoot him an email to get on it on as soon as he does get in the office there :)11:34
odyssey4memattt essentially if you do a sha256sum on the repo server, instead of a sha1sum, then you have direct content to feed to the get_url module instead of jumping through the hoops of doing a local sum manually11:35
odyssey4mehughsaunders mattt can we get votes through on https://review.openstack.org/266834 please to unblock that role's gate11:36
hughsaunderslgtm11:37
matttodyssey4me: updated the review, but basically if we use get_url's sha256sum then we end up downloading the venv, which is precisely what we're trying to avoid11:38
matttodyssey4me: passing sha256sum is to verify integrity of the downloaded file, which is not what we want (tho could do)11:39
odyssey4memattt but if there is already a file, doesn't it check the existing file against the sha256sum?11:42
odyssey4meand then download a fresh one if it doesn't match11:42
matttodyssey4me: no11:43
mattt"If a SHA-256 checksum is passed to this parameter, the digest of the destination file will be calculated after it is downloaded to ensure its integrity and verify that the transfer completed successfully. This option is deprecated. Use 'checksum'."11:43
matttodyssey4me: you're not passing sha256sum to see if the file has chaned, but to ensure what is downloaded is valid11:44
mattt*changed11:44
matttso with sha256sum you cannot avoid the download which will happen every time11:44
*** apuimedo has quit IRC11:44
matttunless i'm reading this doc incorrectly :)11:45
*** apuimedo has joined #openstack-ansible11:45
odyssey4memattt I'm not convinced that the doc is right, as we use the sha256sum for the rabbit downloads and I'm fairly certain that it does a local sha256sum if the dest file is present already and only downloads if the sha256sum doesn't match the value its given11:48
*** apuimedo has quit IRC11:50
*** apuimedo has joined #openstack-ansible11:50
*** jguy_ has quit IRC11:54
*** markvoelker has joined #openstack-ansible11:56
*** apuimedo has quit IRC11:59
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26683212:00
*** apuimedo has joined #openstack-ansible12:00
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the keystone ssh keys  https://review.openstack.org/26684212:00
*** markvoelker has quit IRC12:00
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the swift ssh keys  https://review.openstack.org/26684012:01
matttodyssey4me: i think it downloads it every time, see https://gist.githubusercontent.com/mattt416/8010b18ad02d2e43164c/raw/43a3fdeb4f2a3d4d6d6622314a3b5753f52c3156/gistfile1.txt12:01
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the nova ssh keys  https://review.openstack.org/26683912:02
matttodyssey4me: specifically, look at the "src"12:02
*** javeriak has quit IRC12:04
odyssey4memattt if that is true, then it's pathetic... I do notice that 'attempts: 0' though12:04
odyssey4melemme try something12:05
odyssey4memattt heh, the rabbitmq play deletes the local deb every time it runs :/12:09
*** mlima_ has joined #openstack-ansible12:10
mlima_Hello12:10
mlima_I ran ansible-playbook -i inventory/all-in-one -e @/etc/kolla/globals.yml -e @/etc/kolla/passwords.yml site.yml and I have this output now   TASK [memcached : Starting memcached container] fatal: [localhost]: FAILED! => {"changed": false, "changes": ["{\"status\":\"Pulling repository localhost:5010/kollaglue/centos-source-memcached\"}\r\n", "{\"errorDetail\":{\"message\":\"Error while pulling image. Somebody knows why it ha12:10
matttmlima_: are you in the right channel?  :)12:12
matttodyssey4me: well jeez :P12:12
odyssey4memlima_ I think you'll need to visit #kolla :)12:12
mlima_Ok12:13
mlima_Sorry12:13
*** mlima_ has left #openstack-ansible12:13
*** mlima_ has quit IRC12:13
*** apuimedo has quit IRC12:16
*** apuimedo has joined #openstack-ansible12:18
matttodyssey4me: let me test that w/ a standalone test to be sure12:19
odyssey4memattt yeah, I'm doing the same12:20
*** admin0 has quit IRC12:21
matttodyssey4me: yeah, if you specify sha256sum it still seems to download it12:26
*** sdake has joined #openstack-ansible12:27
odyssey4memattt worse, regardless of whether the local file matches the checksum or not, if there's a local file with the dest name, it doesn't bother doing anything at all12:28
matttodyssey4me: hence me adding force: true :)12:29
odyssey4meforce: true was exactly what I was hoping to avoid12:30
matttif you add force: true it will compare checksums of the downloaded file to what is already there, and replaces if different12:30
*** apuimedo has quit IRC12:30
odyssey4mebecause force: true does definitely always re-download the file12:30
matttodyssey4me: right, but did you see the conditions i added to the task?12:30
matttthe task doesn't get run unless the local and remote checksums differ12:30
odyssey4meok, let me do a fresh review pass now that I'm more certain of the behaviour here12:30
matttokee12:30
matttodyssey4me: also if you are busy this doesn't need to be done now12:31
*** apuimedo has joined #openstack-ansible12:31
odyssey4memattt I'll trade you - if you can review https://review.openstack.org/266834 and https://review.openstack.org/266832 then I'll review https://review.openstack.org/261293 :)12:33
matttsure :)12:34
*** apuimedo has quit IRC12:43
*** woodard has joined #openstack-ansible12:43
*** apuimedo has joined #openstack-ansible12:44
odyssey4memattt I think that's good to go. I'd suggest changing the subject line, rebasing it on top of https://review.openstack.org/266832 (so that it passes all gate checks) then we can get some more feedback before you do the same for the other roles.12:44
odyssey4meI'd like to actually submit a patch upstream to Ansible to change this behaviour. If the local file checksum and the provided checksum don't match, it should automatically download a replacement.12:45
odyssey4memattt ah, in fact if I read the 'checksum' (v2.0+) description correctly, it does what I want it to do12:46
matttodyssey4me: in those reviews, why did we put the ansible imports at the bottom of the file?12:47
odyssey4memattt I have no idea12:48
*** admin0 has joined #openstack-ansible12:48
odyssey4meI think that's a pattern provided in some of the examples ansible provides12:48
matttodyssey4me: yeah that new functionality sounds right12:48
*** apuimedo has quit IRC12:49
*** woodard has quit IRC12:49
matttodyssey4me: going to add a TODO also to remind us to change that when we move to ansible 212:49
*** apuimedo has joined #openstack-ansible12:51
odyssey4memattt good plan12:51
*** jguy_ has joined #openstack-ansible12:53
odyssey4meblast, there's one I haven't seen with ansible > 1.6: http://logs.openstack.org/34/266834/1/gate/gate-openstack-ansible-galera_server-dsvm-ansible-functional-trusty/bdecaf6/console.html#_2016-01-13_12_51_03_07112:54
mattt:(12:55
*** apuimedo has quit IRC12:55
*** jguy_ has quit IRC12:56
*** apuimedo has joined #openstack-ansible12:56
*** markvoelker has joined #openstack-ansible12:57
*** admin0 has quit IRC12:58
openstackgerritJesse Pretorius proposed openstack/openstack-ansible-galera_server: Ensure that ansible_processor_vcpus always has a default value  https://review.openstack.org/26689712:58
matttblah looks like there are more neutron db migration issues :-/13:01
*** markvoelker has quit IRC13:02
openstackgerritMatt Thompson proposed openstack/openstack-ansible: Allow re-deployment of venvs  https://review.openstack.org/26129313:07
*** jguy_ has joined #openstack-ansible13:09
*** mgoddard has quit IRC13:12
*** mgoddard has joined #openstack-ansible13:13
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the keystone ssh keys  https://review.openstack.org/26684213:14
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the nova ssh keys  https://review.openstack.org/26683913:15
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Use slurp to collect the swift ssh keys  https://review.openstack.org/26684013:16
openstackgerritJesse Pretorius proposed openstack/openstack-ansible-galera_server: Ensure that ansible_processor_vcpus always has a default value  https://review.openstack.org/26689713:17
*** admin0 has joined #openstack-ansible13:21
*** javeriak has joined #openstack-ansible13:23
*** javeriak has quit IRC13:23
*** javeriak has joined #openstack-ansible13:24
*** pbelamge_ has joined #openstack-ansible13:26
*** dslev has joined #openstack-ansible13:27
*** javeriak_ has joined #openstack-ansible13:30
*** javeriak has quit IRC13:31
*** markvoelker has joined #openstack-ansible13:31
*** apuimedo has quit IRC13:31
mhaydenmornin'13:32
*** apuimedo has joined #openstack-ansible13:33
odyssey4memattt I assume that you're talking about http://logs.openstack.org/32/266832/2/check/gate-openstack-ansible-dsvm-commit/21613fb/console.html#_2016-01-13_13_26_06_765 ?13:35
*** admin0 has quit IRC13:37
matttodyssey4me: yeah :(13:40
*** javeriak has joined #openstack-ansible13:40
*** metral is now known as metral_zzz13:40
matttodyssey4me: bit confused why we're hitting a bug there tho, has anything changed w/ neutron in the last 24 hours ?13:40
*** javeriak_ has quit IRC13:41
*** MCoLo has joined #openstack-ansible13:41
*** admin0 has joined #openstack-ansible13:41
odyssey4memattt I've rechecked to see if it pops up again. We're still at the same SHA, so we shouldn't be hitting any issues related to upstream changes.13:42
matttodyssey4me: yah and we had stuff passing yesterday ... i have an AIO booted yesterday which runs fine13:42
matttgoing to spin up an AIO now to check13:42
*** apuimedo has quit IRC13:47
*** apuimedo has joined #openstack-ansible13:48
*** apuimedo has quit IRC13:55
*** MCoLo has quit IRC13:55
*** dslev has quit IRC13:55
*** apuimedo has joined #openstack-ansible13:56
*** javeriak_ has joined #openstack-ansible13:57
*** javeriak has quit IRC13:59
*** tlian has joined #openstack-ansible14:00
evrardjphello again14:02
*** apuimedo has quit IRC14:05
*** apuimedo has joined #openstack-ansible14:06
*** admin0 has quit IRC14:08
openstackgerritMerged openstack/openstack-ansible-galera_server: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26683414:08
*** dslev has joined #openstack-ansible14:10
*** apuimedo has quit IRC14:12
*** apuimedo has joined #openstack-ansible14:13
*** woodard has joined #openstack-ansible14:15
*** woodard has quit IRC14:16
*** woodard has joined #openstack-ansible14:16
*** pai15 has joined #openstack-ansible14:17
*** apuimedo has quit IRC14:25
*** apuimedo has joined #openstack-ansible14:26
*** dslev has quit IRC14:29
*** admin0 has joined #openstack-ansible14:33
odyssey4memattt hughsaunders can we get this reviewed to further reduce gate failures: https://review.openstack.org/26689714:38
odyssey4meo/ evrardjp14:38
* mhayden ventures back over to the security midcycle14:39
*** apuimedo has quit IRC14:39
*** apuimedo has joined #openstack-ansible14:41
evrardjpmhayden: that seems interesting :p14:43
odyssey4memattt you're right, we now have a new neutron migration problem - https://review.openstack.org/266839 , https://review.openstack.org/266840 and https://review.openstack.org/266842 all failed as a results of it14:45
matttodyssey4me: yeah got an instance here that failed also, troubleshooting now14:45
*** apuimedo has quit IRC14:45
*** apuimedo has joined #openstack-ansible14:47
openstackgerritTravis McPeak proposed openstack/openstack-ansible-security: Adding Vagrant setup for deploying security-ansible  https://review.openstack.org/26695414:47
openstackgerritTravis McPeak proposed openstack/openstack-ansible-security: Adding Vagrant setup for deploying security-ansible  https://review.openstack.org/26695414:50
openstackgerritTravis McPeak proposed openstack/openstack-ansible-security: Adding Vagrant setup for deploying security-ansible  https://review.openstack.org/26695414:51
*** apuimedo has quit IRC14:52
matttodyssey4me: ah!14:52
mhaydenuh oh, the security folks are in our midst14:52
odyssey4memattt ?14:52
odyssey4memhayden everyone is welcome :)14:53
matttodyssey4me: it's breaking on something plumgrid related14:53
*** apuimedo has joined #openstack-ansible14:53
odyssey4memattt ah, I recall javeriak_ mentioning something about packages installing that perhaps shouldn't be14:53
matttodyssey4me: yeah i think that's it14:54
matttodyssey4me: it breaks neutron migrations, has nothing to do w/ the neutron migrations module thankfully14:54
javeriak_odyssey4me the networking-plumgrid seems to be going into the venv regardless of plumgrid being enabled or not14:54
javeriak_and if that gets installed when the venv is extracted the it will replace the ml2 totally14:55
odyssey4methanks javeriak_ - it's time we figured out why :)14:55
javeriak_odyssey4me on a similar note; i wanted to ask how i can manage the versions for it if wanted the version to be configurable through an extrenal parameter?14:56
odyssey4mejaveriak_ as-in you'd like a more up to date version of the package on the repo server?14:57
matttjaveriak_: it makes sense we install it in the venv14:57
javeriak_odyssey4me the easiest solution i can think of atm is taking it out from the venv enviroment entirely and installing from a particular upstream everytime14:57
matttjaveriak_: because the venvs are pre-built right, so they have to cater to all deployment scenarios14:57
odyssey4mejaveriak_ yes, but that breaks the concept of repeatability and reliability - you never know which package you're getting14:58
openstackgerritTravis McPeak proposed openstack/openstack-ansible-security: Adding Vagrant setup for deploying security-ansible  https://review.openstack.org/26695414:58
odyssey4mejaveriak_ this is why wheel versions are fixed per tag14:58
odyssey4memattt yes, but it should only install into the venv if the plumgrid bits are enabled14:58
matttodyssey4me: that doesn't make sense14:58
*** michaelgugino has joined #openstack-ansible14:58
odyssey4memattt in this special case, it does - the plumgrid package overwrites parts of the neutron package14:59
matttodyssey4me: so a plumgrid deploy cannot use the rpc-mirror for venvs?14:59
matttjaveriak_: on a side note, how come that package doesn't work with migrations?14:59
*** Mudpuppy has joined #openstack-ansible14:59
*** Mudpuppy has quit IRC15:00
odyssey4me^ yeah, javeriak_ that will actually cause reliability issues too15:00
*** Mudpuppy has joined #openstack-ansible15:00
odyssey4memattt my suggestion is that the plumgrid wheel is installed into the venv on-demand if it exists, over the top of whatever came from the repo venv package15:01
javeriak_odyssey4me mattt; i understand guys; the resoning for venvs does make sense; but heres my scenario. i now have different versions of this package for kilo/liberty etc; we release minor versions every 2-3 weeks that go with a platform release; so i would typically want to be able to use a particular OSAD tag with any version of this package that i parameterize?15:01
matttodyssey4me: that's messy, does the repo building stuff have the ability to not install those bits ?15:02
odyssey4mejaveriak_ we typically tag every 2 weeks anyway, so if a consumer wishes the newer package, they just need to update to the later tag15:02
odyssey4mejaveriak_ the only reason we haven't tagged for a month now is due to the holidays15:03
*** alextricity_h has joined #openstack-ansible15:03
*** alextricity_h has quit IRC15:03
odyssey4memattt that's what I'm checking now - I have the feeling that it installs ".*_pip_packages"15:03
matttme too :(15:03
matttbut if we lock down that version it should help?  since this gated fine which means we have a working version of it somewhere :)15:03
javeriak_mattt it does work with migrations15:04
odyssey4mejaveriak_ I have the feeling that it may work for migrations of all stable releases of openstack, but not for Mitaka just yet... and we're gating on Mitaka15:04
javeriak_guys question; will the rpc-mirror keep all versions of an upstream package?15:04
odyssey4methat's where we're seeing the breakdown15:05
javeriak_yea we dont have a mitaka upgrade path yet15:05
odyssey4mejaveriak_ the rpc-mirror keeps all versions of packages included in each release15:05
matttjaveriak_: we'll figure this out, it's no worries :)15:05
odyssey4mejaveriak_ the mirror has package versions going back to icehouse :p15:05
javeriak_mattt  sure, let me knw if i can help look15:06
matttjaveriak_: on liberty/mitaka there should be two migration branches, "expand" and "contract" ... it looks like this plugin's migrations aren't separated15:06
matttjaveriak_: so when you run neutron-db-manage upgrade, it fails to find the necessary migration branch directories15:07
michaelguginojoining the convo late here, but the default rpc mirror in the docs does not have many of the point releases.  This seems to work fine for everything but the pip wheel packages.15:07
javeriak_matt right; can you guys disable including this package into the mitaka venev until i get that sorted?15:08
michaelguginoliberty is currently pointing to 12.0.3 (or was yesterday), and there is only 12.0.0 in the mirror.15:08
matttjaveriak_: look at https://github.com/openstack/neutron-lbaas/tree/master/neutron_lbaas/db/migration/alembic_migrations/versions versus https://github.com/openstack/networking-plumgrid/tree/master/networking_plumgrid/neutron/plugins/db/migration/alembic_migrations/versions15:08
openstackgerritTravis McPeak proposed openstack/openstack-ansible-security: Adding Vagrant setup for deploying security-ansible  https://review.openstack.org/26695415:08
matttjaveriak_: yeah sure15:09
matttjaveriak_: i am confused how this gated successfully tho15:09
*** CheKoLyN has joined #openstack-ansible15:10
javeriak_matt yea i see what you mean15:10
openstackgerritTravis McPeak proposed openstack/openstack-ansible-security: Adding Vagrant setup for deploying security-ansible  https://review.openstack.org/26695415:11
javeriak_and yes when enabled; it should have stopped all your neutron calls15:11
openstackgerritDennis DeMarco proposed openstack/openstack-ansible: Fixed output to match updated command  https://review.openstack.org/26697115:11
odyssey4memichaelgugino yes, none of the liberty tags are on the mirror as RPC does not yet deploy Liberty... I'm looking at trying to publish OSA packages/venvs onto tarballs.openstack.org as part of the automated gating process so that the project has a place to publish and so that all publishing is automated15:12
michaelguginosounds good.15:13
*** gparaskevas has joined #openstack-ansible15:13
odyssey4mejaveriak_ the inclusion of that package in the venv is a mistake anyway, so I'd like to ensure that it's not included by default and that it's only included when plumgrid config options are enabled15:13
*** apuimedo has quit IRC15:14
*** apuimedo has joined #openstack-ansible15:16
matttbrb for a few minutes15:16
javeriak_odyssey4me, are you seeing this in all branches? or just master15:17
javeriak_i looked through the recent venv changes and didnt see any check for inclusion on kilo15:17
odyssey4mejaveriak_ the failure is only in master - but the inclusion of the package in the venv by default is likely in both master and liberty15:17
odyssey4mewe only have venvs in master/liberty15:18
javeriak_odyssey4me sorry, yea i meant liberty*15:18
openstackgerritTravis McPeak proposed openstack/openstack-ansible-security: Adding Vagrant setup for deploying security-ansible  https://review.openstack.org/26695415:18
javeriak_odyssey4me, so make it include only a specific version of this package in the venv, where do i specify it, in the requirements file?15:19
javeriak_to * make it inlcude15:19
*** baker has joined #openstack-ansible15:19
javeriak_and i assume that the rpc-mirror keeps them all from upstream15:20
odyssey4mejaveriak_ for a particular environment you shouldn't have to do anything - if you repo-build it'll grab the latest allowed15:20
*** spotz_zzz is now known as spotz15:20
odyssey4meRPC uses the repo-clone and does not do a repo-build for production environments, so RPC always gets a static set of packages15:20
javeriak_odyssey4me, nope but i dont want latest; id like a specific liberty version depending on a parameter i define in my external playbooks, is that possible?15:21
*** KLevenstein has joined #openstack-ansible15:21
*** yaya has joined #openstack-ansible15:22
javeriak_like for example ive got 2.3, 2.4 and 2.5 up on pypi and id like my deployment to install any one of these with RPC 12 depending on what a parameter i choose15:22
odyssey4mejaveriak_ ah, if you specifically want to cap it then you can change https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_neutron/defaults/main.yml#L348 to look something like https://github.com/openstack/openstack-ansible/blob/12.0.0/playbooks/roles/os_horizon/defaults/main.yml#L16215:22
odyssey4mewell, that'll work for any normal pip requirements parameters15:23
odyssey4mecloudnull ping?15:24
javeriak_odyssey4me can i do this: http://pastebin.com/9eeYyfFY15:25
*** apuimedo has quit IRC15:26
javeriak_odyssey4me, with "version" coming from somewhere else15:26
*** pbelamge_ has quit IRC15:26
*** apuimedo has joined #openstack-ansible15:27
odyssey4mejaveriak_ it'll need to be something more like http://pastebin.com/bVE4ZgjJ15:28
openstackgerritDennis DeMarco proposed openstack/openstack-ansible: Correct CLI command for install verification  https://review.openstack.org/26664115:28
odyssey4mejaveriak_ the variable will need to be namespaced, and you need to cater for the potential of there being no variable15:28
javeriak_odyssey4me yea perfect thats what i had in mind. so can plumgrid_package_version come from a external yml and then that effects what it build into the venv15:30
odyssey4mejaveriak_ correct15:30
odyssey4mebut if that value is not provided, it'll just grab whatever version is available on pypi15:31
*** galstrom_zzz is now known as galstrom15:31
javeriak_odyssey4me  cool, let me give that a try15:31
matttjaveriak_ odyssey4me : why wouldn't we just lock down the version with the rest of the software we build?15:31
*** apuimedo has quit IRC15:32
matttbecause we're inevitably going to run into further issues leaving networking-plumgrid uncapped15:32
odyssey4mejaveriak_ another option is to place the package with its constraints into global-requirement-pins.txt15:33
javeriak_guys afk, brb in a bit15:33
odyssey4mebut that would require a requirements.txt format, and it seems to me that you're wanting to specify a package version per install15:33
*** apuimedo has joined #openstack-ansible15:33
*** pegmanm has quit IRC15:33
*** pegmanm_ has joined #openstack-ansible15:34
odyssey4memattt I can't seem to find out why it is that the venv has the package15:34
odyssey4memattt the package ony gets installed https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_neutron/tasks/plumgrid_config.yml#L26-L4115:34
matttodyssey4me: i would have thought we'd cap it in https://github.com/openstack/openstack-ansible/blob/master/playbooks/defaults/repo_packages/openstack_services.yml with the other neutron plugins?15:35
odyssey4methat task list only happens from here: https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_neutron/tasks/neutron_post_install.yml#L143-L14515:35
odyssey4memattt it seems that plumgrid wants the control of the version in their hands, rather than whatever's current15:36
*** pai15 has quit IRC15:36
*** phalmos has joined #openstack-ansible15:36
*** pai15 has joined #openstack-ansible15:36
matttodyssey4me: yeah that makes sense15:37
matttodyssey4me: maybe change the neutron_plumgrid_pip_packages var so it doesn't get slurped up by the venv builder15:37
mattt?15:37
odyssey4memattt I can't seem to find how it gets slurped by the venv builder15:37
*** pegmanm has joined #openstack-ansible15:38
odyssey4memattt as far as I can see, the reference from which to build the package list comes from https://github.com/openstack/openstack-ansible/blob/master/playbooks/repo-build.yml#L24-L2715:38
*** pegmanm_ has quit IRC15:38
odyssey4methat uses the lookup that looks for these variable names: https://github.com/openstack/openstack-ansible/blob/master/playbooks/plugins/lookups/py_pkgs.py#L42-L4915:39
*** pegmanm has quit IRC15:39
spotzIf anyone gets a chance look at https://review.openstack.org/#/c/266641/. It's a quicky I don't want to review as I helped with it15:39
odyssey4mewhich then builds a package list like so: https://github.com/openstack/openstack-ansible/blob/master/playbooks/plugins/lookups/py_pkgs.py#L350-L36515:39
*** pai15 has quit IRC15:39
*** pai15 has joined #openstack-ansible15:40
matttyep15:40
matttso we just have to change the variable so it doesn't get picked up15:40
matttbut then the package won't be on the repo server, which would be a problem15:40
*** fawadkhaliq has joined #openstack-ansible15:40
*** pegmanm has joined #openstack-ansible15:41
odyssey4memattt but neutron_plumgrid_pip_packages is not included as a key15:41
odyssey4meso I'm guessing that it uses a wildcard somehow, which I'm not seeing15:42
matttyeah wildcard15:42
matttsince each role has different vards15:42
mattt*vars15:42
*** yaya has quit IRC15:42
javeriak_fawadkhaliq ping15:42
matttodyssey4me: what about changing var namespace to not include neutron?15:43
matttthat way it will end up repo server but hopefully not get installed into venv?15:43
mattt(where's cloudnull when you need him :P )15:43
*** mgoddard_ has joined #openstack-ansible15:45
odyssey4memattt I'm thinking more along the lines of the package list collection resulting in a flat list, but also a list which only has the <servicename>_pip_packages list15:45
fawadkhaliqhola javeriak_15:46
fawadkhaliqwhatsup15:46
odyssey4methe flat list should be used for the repo build, but the smaller list should be used for the venv15:46
*** mgoddard has quit IRC15:48
matttodyssey4me: yeah that sounds sensible15:49
*** alextricity25 has quit IRC15:51
javeriak_hey fawadkhaliq matt had a point about the plumgrid plugin migrations not being separated; was hoping you could shed some light; we are running into problems with neutron-db-manage upgrade, it fails to find the necessary migration branch directories15:52
*** alextricity25 has joined #openstack-ansible15:52
cloudnullmorning15:52
cloudnullmattt: whats up ?15:53
fawadkhaliqthat's weird. anything different we are doing in osad than DevStack script for same migration? All seems to work and pass testing and the gate.15:53
cloudnullodyssey4me: pong15:53
odyssey4meo/ cloudnull15:53
*** alextricity25 has quit IRC15:54
odyssey4mewe have a special case which we need to find a suitable solution to15:54
matttfawadkhaliq: don't think so, it's the upstream neutron-db-manage command that's failing on networking-plumgrid15:54
*** alextricity25 has joined #openstack-ansible15:54
*** alextricty25 has joined #openstack-ansible15:54
fawadkhaliqmattt: can you please point me to the failure you are looking at?15:54
matttfawadkhaliq: sure thing15:54
fawadkhaliqmattt: thanks!15:55
odyssey4mecloudnull https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_neutron/defaults/main.yml#L347 is being included in the os_neutron venv... and that package overwrites some of the contents of the neutron wheel15:55
matttfawadkhaliq: https://gist.github.com/mattt416/812c7fe2c14458eae66f15:55
fawadkhaliqmattt: thanks, looking at it15:56
*** alextricty25 has quit IRC15:56
odyssey4mecloudnull the problem is, of course, that the venv package install list is basically all ".*_pip_packages" found in the role, rather than just 'neutron_pip_packages'15:56
cloudnullcorrect15:56
fawadkhaliqmattt: javeriak_: question, why run PLUMgrid plugin migration with ML2? --config-file /etc/neutron/plugins/ml2/ml2_conf.ini15:56
cloudnullits pulls in everything _pip_packages15:56
matttfawadkhaliq: look at https://github.com/openstack/neutron-lbaas/tree/master/neutron_lbaas/db/migration/alembic_migrations/versions versus https://github.com/openstack/networking-plumgrid/tree/master/networking_plumgrid/neutron/plugins/db/migration/alembic_migrations/versions15:56
odyssey4mecloudnull so I was about to look into how we could effectively have the list of packages to build on the repo server, and the venv package list being made of just the <role>_pip_package lists15:57
odyssey4mecloudnull I figure that it needs an update to the py_pkgs lookup, so I was about to give that a go15:57
fawadkhaliqmattt: yup, having expand/contract is not a requirement AFAIK. But let's narrow down the issue.15:57
cloudnullwould you want that plumgrid package when using plumgrid within the venv ?15:57
matttfawadkhaliq: yeah, that's a side issue we're cleaning up now, the package should not be installed at the moment15:57
*** alextricity_h has joined #openstack-ansible15:57
odyssey4mecloudnull my thinking is that if plumgrid is enabled, then the package can be installed into the venv after the pact15:58
odyssey4me*fact15:58
fawadkhaliqmattt: the package to supposed to be installed when we have core_plugin as PLUMgrid.15:58
javeriak_odyssey4me  cloudnull, like i see, it extracts and installs everything in the venv, and you would only want that plumgrid package when plumgrid is enabled otherwise its going to replace ml2 entirely15:58
fawadkhaliqmattt: definitely not with Ml215:58
fawadkhaliqs/package to/package is/15:59
matttfawadkhaliq: sure, but the migrations should run either way right?15:59
cloudnullcouldnt you simply do a conditional include like we've proposed with the kernel modiule here: https://review.openstack.org/#/c/266530/5/defaults/main.yml15:59
*** gparaskevas has quit IRC15:59
matttcloudnull: and if someone uses rpc-repo ?15:59
alextricity_hHey..does anybody use the ZNC IRC bouncer? It should allow you to connect from multiple clients, right?16:01
fawadkhaliqmattt: not necessarily, one of the points of plugin decomposition is that this is all separate. In the run you shared, we have conflicts and seems like Ml2 conf has some requirement that is not there.16:01
odyssey4mecloudnull yeah, the package always needs to be on the repo, but it mustn't always be in the venv16:01
alextricity_hI left my client connected back at work, and am having trouble connecting to the bouncer from home.16:02
cloudnullthe package will be there. being that its been built, however so long as we're carrying the package within the role, and the package cant coexist with neutron in a normal deployment, we're always going to have an issue like this16:02
fawadkhaliqmattt: so no there is no guarantee that plumgrid packaging will work and migration will work with a conf file from a different plugin.16:02
matttfawadkhaliq: i see!16:02
fawadkhaliqmattt: javeriak_: it should fail in a better way.16:02
openstackgerritDennis DeMarco proposed openstack/openstack-ansible: Correct CLI command for install verification  https://review.openstack.org/26664116:03
matttfawadkhaliq: so getting that package removed from the venv is all that way need to do for now16:03
javeriak_cloudnull correct, the package cannot coexist in an ml2 installation16:03
odyssey4mecloudnull yep, which is why I thought it better that the packages installed into the venv should be more selective16:03
fawadkhaliqmattt: yes, go for it. having in the venv *only* when testing plumgrid bits makes sense to me.16:03
cloudnullthats fair.16:03
*** apuimedo has quit IRC16:03
fawadkhaliqmattt: you might run into the same issue with other plugins.16:04
cloudnullim missing some context here though, what causes this to break ?16:04
odyssey4mecloudnull with the plumgrid networking package in the venv, it overwrites some of the standard neutron stuff, which in turn causes the migrations to break16:04
cloudnullso the plumgrid package replaces files within neutron16:05
odyssey4mecloudnull yes16:05
fawadkhaliqodyssey4me: cloudnull: no :-)16:05
fawadkhaliqodyssey4me: cloudnull: let me elaborate a bit16:05
*** apuimedo has joined #openstack-ansible16:05
fawadkhaliqodyssey4me: cloudnull: neutron-db-manage when run with specific plugin configuration, it would be required to run DB migration for that OR the ones which are installed in the python entry points for db migrations. there could be multiple. Now, having a core plugin A and then using DB migration from core plugin B will break things.16:07
odyssey4mecloudnull ok, to be clearer, it causing http://logs.openstack.org/32/266832/2/check/gate-openstack-ansible-dsvm-commit/025f25e/console.html#_2016-01-13_14_45_07_805 currently16:07
*** sigmavirus24_awa is now known as sigmavirus2416:07
*** admin0 has quit IRC16:07
odyssey4mefawadkhaliq mattt cloudnull oh, does that mean then that out neutron db migration is perhaps a little too eager in collecting potential migrations to be done?16:08
cloudnullso is this being caused because we are not being specific enough when we do the db migration ?16:08
*** ddaskal has joined #openstack-ansible16:08
fawadkhaliqodyssey4me: not really. cloudnull: that's correct.16:08
cloudnullso sounds like we need to fix https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_neutron/tasks/neutron_db_setup.yml#L57-L6816:09
MudpuppyThis white space is my moby whale16:09
odyssey4mehow can we be more specific to avoid this issue then?16:09
cloudnullto assume less16:09
matttodyssey4me: yeah i'm confused here16:09
matttcloudnull: "assume less"?16:10
matttwe're running migrations as you should16:10
fawadkhaliqcloudnull: odyssey4me mattt javeriak_. so the command to migrate16:10
cloudnullwe're running [u'/openstack/venvs/neutron-master/bin/neutron-db-manage', u'--config-file', u'/etc/neutron/neutron.conf', u'--config-file', u'/etc/neutron/plugins/ml2/ml2_conf.ini', u'upgrade', u'--expand']16:10
*** weezS has joined #openstack-ansible16:10
cloudnullsounds like we're missing something16:10
fawadkhaliqcloudnull: odyssey4me mattt javeriak_. has two issues: one if ml2 conf and the other is it is specifically asking for the expand migration.16:10
fawadkhaliqs/one if/one is/16:10
*** yaya has joined #openstack-ansible16:11
matttbut all neutron and subprojest use expand/contract16:11
matttwhy would we do it differently?16:11
javeriak_cloudnull odyssey4me matt fawadkhaliq; issues remains, we shouldn't be packaging and installing the plumgrid package everytime16:12
matttjaveriak_: that to me sounds like the issue :P16:12
matttbut i'm not sure what happens when i actually deploy plumgrid, i have no idea if migrations will run, i'm guessing not ?16:12
fawadkhaliqmattt: neutron subprojects implement both, expand/contract and older one16:12
matttfawadkhaliq: OH16:12
matttfawadkhaliq: yeah, we do expand and contract, just at different times16:12
matttfawadkhaliq: we do expand, shut down neutron-server, do contract, then bring it back up16:13
fawadkhaliqmattt: i am wondering explicit expand will not call the older implementations.16:13
javeriak_mattt true, in that case; maybe we could disable migrations if plumgrid is enabled? fawadkhaliq16:13
fawadkhaliqjaveriak_: disable migrations? where will my DBs go :-(16:13
mattthehe16:13
odyssey4mejaveriak_ ick, not good - the expand/contract actions are to handle db changes needed when moving between versions16:13
cloudnullmaybe we go to the old method if plumgrid is enabled16:14
fawadkhaliqcloudnull: thats one option16:14
javeriak_oh... :)... odyssey4me mattt so this is only problematic with mitaka16:14
matttjaveriak_: liberty also iirc16:14
*** metral_zzz is now known as metral16:14
cloudnullmy guess would be that other neutron subprojects will have the same issues16:14
odyssey4mejaveriak_ for now, it might come up in other versions at a later stage16:14
matttcloudnull: they don't16:14
matttcloudnull: we have no issues w/ fwaas, lbaas, etc.16:14
cloudnullare you sure16:14
matttyes i'm sure16:14
cloudnulllike mediocura16:14
fawadkhaliqcloudnull: javeriak_ mattt. does only upgrade not trigger expand/contracts as well? I am not sure about it, I will have to check16:14
odyssey4meyeah, I'm not fond of putting a conditional in based on which plugin is used - that'll end up with a mess16:14
cloudnullcisco nexus16:14
cloudnulletc16:14
mattti don't even knopw what mediocura is16:15
matttfawadkhaliq: i think it does both yeah16:15
cloudnullmattt: http://www.midokura.com/midonet/openstack/16:15
matttcloudnull: do we deploy any of those other bits?  i've not tested those at any point16:15
cloudnull*midokura16:15
odyssey4meit seems to me that we should be more selective in installing the packages in the first place16:15
fawadkhaliqmattt: so any specific reason for doing it explicitly?16:15
matttfawadkhaliq: contract migrations should happen when your neutron-server is offline, so splitting them allows you to shut down neutron-server for only the contract migrations16:16
cloudnullmattt:  point being that plumgrid is a neutron plugin and subproject and id suspect that other plugins and providers will have the same issues.16:16
matttcloudnull: it's possible but i can only comment on stuff i've worked on16:16
cloudnullso have a framework to handle that would make sense16:16
fawadkhaliqmattt: thats right.16:17
matttcloudnull: i'm not sure i understand16:17
matttcloudnull: it's neutron-db-manage that is failing, that's now something we write16:17
odyssey4meI would agree on that, but it seems to be that we now have unnecessary db tables being created and contracted/expanded just because we have the packages installed... is that right?16:17
openstackgerritDennis DeMarco proposed openstack/openstack-ansible: Correct CLI command for install verification  https://review.openstack.org/26664116:17
matttcloudnull: if it was our custom neutron module failing then i'd certainly think we'd need to fix16:17
Mudpuppydie white space die16:17
fawadkhaliqodyssey4me: I agree with you16:17
odyssey4mefawadkhaliq in that case, we need to ensure that the package is only installed when required - not always installed16:18
fawadkhaliqodyssey4me: absolutely16:18
javeriak_odyssey4me, also we not enabling plumgrid in our current osa gates, there is no CI for it16:19
odyssey4mejaveriak_ yes16:19
matttfawadkhaliq: so neutron-db-manage upgrade heads works16:19
javeriak_so you guys shouldnt see any issue, beause you're not testing enabling it16:19
fawadkhaliqodyssey4me: also that fixes the issue we are seeing. For PLUMgrid plugin, you will have something like neutron-db-manage upgrade heads --conf neutron.conf16:19
odyssey4methis is why I'm in favour of ensuring that the venv only has what it needs16:19
cloudnullmattt: the problem im trying to point out is, if we enable plumgrid the db wont migrate with our current tasks16:19
fawadkhaliqmattt: that's correct. same as DevStack16:19
openstackgerritEric Brown proposed openstack/openstack-ansible-security: Bump minimum required version of Ansible  https://review.openstack.org/26700916:20
cloudnullso simply removing the package from the base install wont "fix" the problem.16:20
matttcloudnull: it won't no16:20
odyssey4mecloudnull that may be true, but it will unblock the gate and the subsequent issue can be worked out afterwards16:21
fawadkhaliqcloudnull: if we still do not have a solution, we could explore migrating to expand/contract but would need some time and backporting to Liberty :-(16:21
odyssey4meunless the suggestion here is to have a fallback task that tries the old migration method if the newer methods fail?16:22
matttcloudnull fawadkhaliq : we could do a upgrade heads if database is empty16:22
matttcloudnull fawadkhaliq : but not sure how future migrations would get applied if they're not in contract/expand branches :(16:22
*** sdake_ has joined #openstack-ansible16:22
odyssey4mebut cloudnull with the package installed in the venv, we have unused db tables around... so that's also a problem16:22
cloudnulli'd be against simply unblocking the gate and "getting to it later". odyssey4me i think we need to work out how we migrate when these other plugins are being used.16:22
cloudnullodyssey4me:  agreeded16:23
matttcloudnull: yeah we will need to solve both16:23
odyssey4meso we effectivelyhave two issues - one is the unused tables being created due to the package being in the venv unnecessarily, the other is that the db migrations don't all work using the new method16:23
cloudnullit should be extracted. but we've also found an issue with a plugin we want to have support for16:23
* odyssey4me nods16:23
fawadkhaliqmattt: cloudnull: okay guys, let me explore migrating to expand/contract.16:24
fawadkhaliqmattt: for future, it should not break but it you never know what combination we are trying later.16:24
matttfawadkhaliq: if there is something easier for us to implement i'm all ears16:24
*** sdake has quit IRC16:25
cloudnullfawadkhaliq:  I'd suggest that, however i dont think your the only provider not using expand/contract so as a deployment project we need to work out how to deploy in this scenario.16:25
*** sdake_ is now known as sdake16:25
fawadkhaliqmattt: for now, would be great if we have db-manage for plumgrid specified as supported with the current version and in parallel, the expand/contract schema can be worked on. Dont want to block javeriak_ here16:26
fawadkhaliqcloudnull: exactly16:26
odyssey4meso mattt will you figure out how to also include the old migration method16:26
fawadkhaliqmattt: one more thing I noticed..16:27
fawadkhaliqmattt: https://github.com/openstack/neutron-lbaas/tree/master/neutron_lbaas/db/migration/alembic_migrations/versions here, the migration scripts outside expand directory16:28
fawadkhaliqmattt: does the current db-manage command does the db migration for them?16:28
fawadkhaliqmattt: with the expand/contract flag16:29
matttfawadkhaliq: yeah i was thinking of that earlier16:29
fawadkhaliqmattt: I have not tried that. If you could send me over the exact commands you use, I could give it a try and share results.16:30
matttfawadkhaliq: i want to make sure we are applying all the right migrations, i know i looked at this in detail a while back but it's been a while16:30
fawadkhaliqmattt: makes sense. Maybe you or javeriak_ could point me to the db migration commands we use, I can give it a shot on my dev env and see if the migrations under questions get picked up16:32
*** jthorne has joined #openstack-ansible16:32
*** galstrom is now known as galstrom_zzz16:33
openstackgerritMichael Gugino proposed openstack/openstack-ansible: Add missing kernel module br_netfilter to openstack_hosts role  https://review.openstack.org/26701316:33
*** apuimedo has quit IRC16:33
michaelguginoback porting br_netfilter change to liberty16:34
*** mpavone has quit IRC16:35
*** apuimedo has joined #openstack-ansible16:35
*** pai15 has quit IRC16:36
cloudnullodyssey4me: fawadkhaliq mattt is there an issue for this ?16:37
cloudnullin launchpad ?16:37
odyssey4mecloudnull nope, it only hit us midday and we've been trying to triage it16:37
matttfawadkhaliq: it looks like running --expand runs all the old pre-liberty migrations16:37
javeriak_odyssey4me coming back to my original versioning question, yes im looking to specify a package version per install, and a requirements file only allows you to specify ranges;16:38
fawadkhaliqmattt: okay, and misses everything post liberty which does not fall under expand?16:38
*** pai15 has joined #openstack-ansible16:39
spotzOh that's the one mudpuppy ran into when we were building test environments16:39
javeriak_odyssey4me so i'd like to parameterize the definition like showed and then hopefully that works for venv packaging as well;16:39
fawadkhaliqmattt: if it does not miss the newer ones as well, I could trick db-migration my adding a placeholder in the expand and keep the existing ones as is.16:40
openstackgerritKevin Carter proposed openstack/openstack-ansible: [WIP] Fix neutron migrations with optional providers  https://review.openstack.org/26701916:40
cloudnullodyssey4me fawadkhaliq mattt ^16:40
fawadkhaliqmattt: that would be quicker and will work without any issues and future migration would go into expand16:40
javeriak_fawadkhaliq  https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_neutron/tasks/neutron_db_setup.yml16:41
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Add missing kernel module br_netfilter to openstack_hosts role  https://review.openstack.org/26701316:41
odyssey4memichaelgugino thanks - I modified the commit message slightly16:41
michaelguginosounds good.16:41
fawadkhaliqjaveriak_: thanks. got it. I will give it a shot now. Stay tuned.16:42
javeriak_cloudnull your patch takes the plumgrid out of the venv entirely?16:43
palendaemichaelgugino: Were you seeing failures against master? I've got a gate test failing on getting br_netfilter because it was on 3.1316:43
javeriak_plumgrid* package16:43
cloudnulljaveriak_:  yes16:43
cloudnullbut will install it in the venv if the plumgrid provider is used16:43
cloudnulland will index / build the package within the base repo16:44
michaelguginoI didn't see any failures here16:44
javeriak_cloudnull i dont see that bit? as in where does the 'neutron_optional_plumgrid_pip_packages' become a part iof the main neutron-pip-packages for plugin=plumgrid?16:45
*** adac has quit IRC16:45
javeriak_cloudnull, oh you mean it wont be packaged within the venv at alll from now on, only get installed if enabled16:45
cloudnullyes16:46
cloudnullhttps://review.openstack.org/#/c/267019/1/playbooks/roles/os_neutron/tasks/plumgrid_config.yml16:46
cloudnullbut the package will be available in the repo-server16:46
cloudnullregardless16:46
javeriak_cloudnull right, ive been proposing that all along :), it makes things easier for me to manage versioning wise16:46
* cloudnull high-fives javeriak_ :)16:46
odyssey4mecloudnull feedback on https://review.openstack.org/26701916:46
javeriak_cloudnull perfect!16:46
odyssey4mepalendae how old was your clone?16:47
palendaeodyssey4me: I had updated it last night. I'll double check16:47
matttfawadkhaliq: sorry just looking at this here16:48
palendaeBut the patch was ancient, something I started in November and just recently picked back up16:48
odyssey4mepalendae if you cloned master, and cloned before https://review.openstack.org/266530 merged, then I would suggest rebootstrapping ansible to pick up the newer roles16:48
palendae6 hours ago, so yeah :p16:48
palendaeThanks16:48
palendaeI'll rebase16:48
matttfawadkhaliq: i'm seeing a slight discrepancy, but it looks like all old migrations are run when you --contract16:49
odyssey4mepalendae if it's master, rebasing won't work - the role concerned is not in git - you need to bootstrap-ansible to collect the updated roles16:49
palendaeAh, right, reading comprehension. So just a recheck16:49
*** phiche has joined #openstack-ansible16:49
palendaeAnd I have another change that needs to be pushed anyway16:49
*** yatin has joined #openstack-ansible16:50
palendaeBasically dsvm-commit on https://review.openstack.org/#/c/242225/8 failed16:50
palendaeBut I need to remove some of my vim cruft from the tox.ini16:50
matttfawadkhaliq: sorry, --expand not --contract16:50
*** phiche1 has quit IRC16:51
fawadkhaliqmattt: cool. Let me know if I can pull something quick. Thanks. I will update.16:51
openstackgerritKevin Carter proposed openstack/openstack-ansible: [WIP] Fix neutron migrations with optional providers  https://review.openstack.org/26701916:51
fawadkhaliqjaveriak_: can you make progress in the meantime?16:51
*** weezS has quit IRC16:51
fawadkhaliqmattt: javeriak_ I will feel bad if you guys blocked because of me :-(16:52
matttfawadkhaliq: don't worry, we're blocked pretty much every other day by something16:53
cloudnull++ :)16:53
javeriak_fawadkhaliq im good, cloudnull's patch for removing our package from venv will take care of the current issues in the gate.16:53
fawadkhaliqmattt: lol16:54
matttcloudnull: sweet, that patch looks good at 30,000 feet16:56
*** yatin has quit IRC16:57
*** mgoddard_ has quit IRC16:57
*** mgoddard has joined #openstack-ansible16:57
*** woodard has quit IRC16:57
matttfawadkhaliq: had a look at some other provider plugins, they all seem to have contract/expand dirs, but not tested them obviously16:58
matttfawadkhaliq: and by all i mean the three random ones i chose :P16:58
*** woodard has joined #openstack-ansible16:58
matttfawadkhaliq: actually found one that doesn't17:00
fawadkhaliqmattt: :-) I will move expand/contract very soon, sir!17:00
javeriak_yea mattt, that one would be us.. :)17:01
matttjaveriak_: nah another one!  :)17:01
*** jthorne has quit IRC17:01
matttfawadkhaliq: i'm heading out shortly ... i'll be back online tomorrow God willing to look at this further :)  if you can think of anything we can implement on this side to better guard us against this i'm all ears17:02
matttbut i think separating out migrations gives us more flexibility and allows us to shorten the time that neutron-server has to be down for running migrations17:02
*** CheKoLyN has quit IRC17:02
fawadkhaliqmattt: sure. will think about it and let you know. agree on the benefits. anyway, i will drop a note. later!17:04
odyssey4mecloudnull last tweak on https://review.openstack.org/267019 then I think the WIP can come out and we can see if it gates17:05
*** Nepoc has quit IRC17:06
openstackgerritKevin Carter proposed openstack/openstack-ansible: [WIP] Fix neutron migrations with optional providers  https://review.openstack.org/26701917:07
*** galstrom_zzz is now known as galstrom17:07
cloudnullodyssey4me: done17:07
*** woodard has quit IRC17:07
*** woodard has joined #openstack-ansible17:07
*** Nepoc has joined #openstack-ansible17:07
odyssey4mecloudnull mattt ok, so we have 3 issues to resolve here - one is the new pep8 violations (solved by https://review.openstack.org/266832 ), another is the incorrect venv package inclusion (solved by https://review.openstack.org/267019 ) and the other is the fixing up of the db migrations (fix ongoing)17:10
odyssey4mein order to get https://review.openstack.org/267019 merged we need https://review.openstack.org/266832, but they both need each other17:10
odyssey4meshould we perhaps temporarily cap the pep8 version to allow https://review.openstack.org/267019 to pass, then uncap it in https://review.openstack.org/266832 ?17:11
*** permalac has quit IRC17:12
*** apuimedo has quit IRC17:19
*** apuimedo has joined #openstack-ansible17:20
*** yatin has joined #openstack-ansible17:20
*** CheKoLyN has joined #openstack-ansible17:21
*** phiche has quit IRC17:22
*** yatin has quit IRC17:25
*** phiche has joined #openstack-ansible17:28
*** javeriak_ has quit IRC17:29
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Gate: Temporarily fix pep8 version to unblock gate checks  https://review.openstack.org/26705317:31
*** michaelgugino has quit IRC17:31
openstackgerritTom Cameron proposed openstack/openstack-ansible: set unique galera server-id  https://review.openstack.org/26705417:32
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Fix neutron migrations with optional providers  https://review.openstack.org/26701917:32
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Fix neutron migrations with optional providers  https://review.openstack.org/26701917:33
*** phiche1 has joined #openstack-ansible17:34
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26683217:34
*** phiche has quit IRC17:35
*** galstrom is now known as galstrom_zzz17:35
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Revert "Gate: Temporarily fix pep8 version to unblock gate checks"  https://review.openstack.org/26705717:36
*** adac has joined #openstack-ansible17:39
*** apuimedo has quit IRC17:41
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Re-deploy the Horizon venv if it mismatches the repo  https://review.openstack.org/26129317:42
*** apuimedo has joined #openstack-ansible17:43
stevelleodyssey4me: sorry, thought things were further unwound than they actually are, scrollback is catching me up17:46
odyssey4mestevelle yeah, I think we've managed to get it right - waiting for a positive gate result17:47
spotzOnly half following the channel today, any of those coming through need reviewing?17:47
stevelleodyssey4me: I believe I have all the relevant reviews up now to monitor17:47
*** apuimedo has quit IRC17:47
*** pai15 has quit IRC17:48
*** apuimedo has joined #openstack-ansible17:48
odyssey4mespotz not to my knowledge17:49
*** jthorne has joined #openstack-ansible17:51
*** javeriak has joined #openstack-ansible17:51
*** apuimedo has quit IRC17:53
*** electrofelix has quit IRC17:53
*** pai15 has joined #openstack-ansible17:54
*** apuimedo has joined #openstack-ansible17:54
openstackgerritJesse Pretorius proposed openstack/openstack-ansible-security: Cap ansible < 2.0 for ansible-lint compatibility  https://review.openstack.org/26706717:57
*** apuimedo has quit IRC18:01
*** KLevenstein has quit IRC18:01
*** apuimedo has joined #openstack-ansible18:02
*** KLevenstein has joined #openstack-ansible18:06
*** maximov has quit IRC18:08
*** meteorfox has quit IRC18:08
*** etoews has quit IRC18:08
*** serverascode has quit IRC18:08
*** rackertom has quit IRC18:08
*** apuimedo has quit IRC18:09
*** apuimedo has joined #openstack-ansible18:09
*** rackertom has joined #openstack-ansible18:10
*** yaya has quit IRC18:11
*** serverascode has joined #openstack-ansible18:16
*** admin0 has joined #openstack-ansible18:19
*** meteorfox has joined #openstack-ansible18:20
*** etoews has joined #openstack-ansible18:21
*** maximov has joined #openstack-ansible18:23
*** javeriak_ has joined #openstack-ansible18:29
*** ddaskal has quit IRC18:30
*** mgagne has quit IRC18:30
*** ddaskal has joined #openstack-ansible18:30
*** javeriak has quit IRC18:31
*** Guest82803 has joined #openstack-ansible18:31
*** Guest82803 is now known as mgagne18:32
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Set tox pep8 environment to use test-requirements.txt  https://review.openstack.org/26708318:32
*** mgagne has quit IRC18:33
*** mgagne has joined #openstack-ansible18:33
*** apuimedo has quit IRC18:33
*** apuimedo has joined #openstack-ansible18:33
*** ddaskal has quit IRC18:34
*** apuimedo has quit IRC18:40
*** jaypipes has quit IRC18:41
*** apuimedo has joined #openstack-ansible18:42
*** ig0r_ has joined #openstack-ansible18:43
*** jaypipes has joined #openstack-ansible18:44
*** jthorne has quit IRC18:44
*** pai15 has quit IRC18:45
*** apuimedo has quit IRC18:49
*** javeriak has joined #openstack-ansible18:49
*** apuimedo has joined #openstack-ansible18:51
*** javeriak_ has quit IRC18:51
*** cemmason1 has joined #openstack-ansible18:54
*** cemmason has quit IRC18:57
*** mgoddard_ has joined #openstack-ansible19:01
*** mgoddard has quit IRC19:04
*** galstrom_zzz is now known as galstrom19:08
*** apuimedo has quit IRC19:10
*** apuimedo has joined #openstack-ansible19:11
openstackgerritMiguel Alex Cantu (alextricity25) proposed openstack/openstack-ansible: Tidy up notification_driver implementation across projects  https://review.openstack.org/26631819:12
openstackgerritJimmy McCrory proposed openstack/openstack-ansible: Default values for enabling services in ceilometer  https://review.openstack.org/26711219:15
*** apuimedo has quit IRC19:15
*** apuimedo has joined #openstack-ansible19:16
*** javeriak_ has joined #openstack-ansible19:19
*** scarlisle has joined #openstack-ansible19:19
*** javeriak has quit IRC19:20
*** yaya has joined #openstack-ansible19:23
*** ddaskal has joined #openstack-ansible19:24
openstackgerritJimmy McCrory proposed openstack/openstack-ansible: Default values for enabling services in ceilometer  https://review.openstack.org/26711219:25
*** apuimedo has quit IRC19:25
*** apuimedo has joined #openstack-ansible19:27
openstackgerritMichael Gugino proposed openstack/openstack-ansible: Remove unwanted veth pair creation from lxc_container_create role  https://review.openstack.org/26712619:30
*** fawadkhaliq has quit IRC19:30
*** admin0 has quit IRC19:31
*** phiche1 has quit IRC19:32
*** michaelgugino has joined #openstack-ansible19:32
*** phiche has joined #openstack-ansible19:32
*** apuimedo has quit IRC19:34
*** CheKoLyN has quit IRC19:35
*** apuimedo has joined #openstack-ansible19:36
*** raddaoui has joined #openstack-ansible19:37
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Remove unwanted veth pair creation from lxc_container_create role  https://review.openstack.org/26712619:38
mhaydeni might update my spec around SSL to use anchor19:41
*** ssl_ has joined #openstack-ansible19:51
*** apuimedo has quit IRC19:55
*** mpavone has joined #openstack-ansible19:55
*** apuimedo has joined #openstack-ansible19:56
*** mpavone has quit IRC19:59
*** CheKoLyN has joined #openstack-ansible19:59
*** Bjoern has joined #openstack-ansible19:59
*** Mudpuppy has quit IRC20:00
*** Mudpuppy_ has joined #openstack-ansible20:00
*** Mudpuppy_ has quit IRC20:01
*** admin0 has joined #openstack-ansible20:02
*** Mudpuppy has joined #openstack-ansible20:02
*** mgoddard_ has quit IRC20:06
*** Bjoern has quit IRC20:06
openstackgerritKevin Carter proposed openstack/openstack-ansible: Added extra variable for upgrade  https://review.openstack.org/26713520:07
*** apuimedo has quit IRC20:07
*** apuimedo has joined #openstack-ansible20:08
openstackgerritJaveria Khan proposed openstack/openstack-ansible: networking-plumgrid package version fix  https://review.openstack.org/26713620:09
ssl_new to lxc and osad.. how do i restart the openstack service (e.g. nova scheduler) in AIO20:13
palendaessl_: lxc-stop -n <container> && lxc-start -n <container>20:14
palendaeOr accessing the container with SSH/lxc-attach and restarting the service like normal20:14
*** apuimedo has quit IRC20:15
openstackgerritMerged openstack/openstack-ansible-security: Cap ansible < 2.0 for ansible-lint compatibility  https://review.openstack.org/26706720:15
*** apuimedo has joined #openstack-ansible20:16
openstackgerritMajor Hayden proposed openstack/openstack-ansible: Docs: overview cleanup  https://review.openstack.org/26530320:18
cloudnullssl_:  all of the openstack services had upstart init scripts20:25
openstackgerritJaveria Khan proposed openstack/openstack-ansible: networking-plumgrid package version fix  https://review.openstack.org/26714620:25
cloudnullso if your on a compute node you can do `service nova-compute restart`20:25
*** apuimedo has quit IRC20:26
*** apuimedo has joined #openstack-ansible20:27
cloudnulljaveriak_:  this PR https://review.openstack.org/#/c/267136/ conflicts with https://review.openstack.org/#/c/267019/5 , can you make this a dependency  ?20:27
javeriak_cloudnull yep was just doing that20:27
cloudnullha :)20:27
* cloudnull goes back to my hole20:28
*** CheKoLyN has quit IRC20:30
odyssey4mejaveriak_ is it possible to set a range for each branch - eg for kilo it should be networking-plumgrid>=2015.1,<2016 ?20:31
odyssey4meor is it static for the entire lifespan of the kilo branch?20:31
javeriak_odyssey4me it's going to be static versions that map between our platform releases : kilo/liberty etc20:32
javeriak_odyssey4me im going to push the exact the versions through the plumgrid playbooks that run before neutron20:33
odyssey4meok, in that case I've added a comment20:34
odyssey4mefor the repo to have the right version, the package list should have the constraints20:34
odyssey4meif you want to override the constraints for an install, you simply override the package list in user_variables20:34
odyssey4meotherwise the install will fail because the repo doesn't have the right version20:35
*** apuimedo has quit IRC20:36
javeriak_odyssey4me sure, how about i just do this networking-plumgrid=="{{networking_plumgrid_version}}"20:36
javeriak_then i could change networking_plumgrid_version in my user vars20:36
javeriak_let me test this though first20:36
odyssey4mejaveriak_  the quotes will need to be on the outside, ie - "networking-plumgrid=={{networking_plumgrid_version}}"20:37
javeriak_odyssey4me okay thanks20:37
odyssey4methat said, I'm not fond of creating yet another var20:37
*** Mudpuppy has quit IRC20:38
*** apuimedo has joined #openstack-ansible20:38
javeriak_oh hmm... well then i could use the static name networking-plumgrid==2015.1.1.1 and then just override this in my user vars?20:38
javeriak_odyssey4me does that look better?20:39
*** Mudpuppy has joined #openstack-ansible20:40
openstackgerritEric Brown proposed openstack/openstack-ansible-security: Bump minimum required version of Ansible  https://review.openstack.org/26700920:41
*** Mudpuppy_ has joined #openstack-ansible20:41
*** Mudpuppy has quit IRC20:42
*** apuimedo has quit IRC20:42
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Fix neutron migrations with optional providers  https://review.openstack.org/26701920:43
openstackgerritKevin Carter proposed openstack/openstack-ansible: Add template option for the default horizon panel  https://review.openstack.org/26715520:43
*** apuimedo has joined #openstack-ansible20:44
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26683220:45
*** ddaskal has quit IRC20:48
*** apuimedo has quit IRC20:48
*** ddaskal has joined #openstack-ansible20:49
*** CheKoLyN has joined #openstack-ansible20:49
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Revert the temp tox config change  https://review.openstack.org/26716320:49
*** apuimedo has joined #openstack-ansible20:50
*** ddaskal has quit IRC20:53
*** apuimedo has quit IRC20:54
*** apuimedo has joined #openstack-ansible20:55
openstackgerritJaveria Khan proposed openstack/openstack-ansible: Fix neutron migrations with optional providers  https://review.openstack.org/26701920:55
openstackgerritJaveria Khan proposed openstack/openstack-ansible: networking-plumgrid package version fix  https://review.openstack.org/26713620:55
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Fix neutron migrations with optional providers  https://review.openstack.org/26701920:58
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: networking-plumgrid package version fix  https://review.openstack.org/26713620:59
*** raddaoui has quit IRC21:00
*** apuimedo has quit IRC21:00
*** raddaoui has joined #openstack-ansible21:00
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26683221:01
*** apuimedo has joined #openstack-ansible21:01
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Revert the temp tox config change  https://review.openstack.org/26716321:01
*** adac has quit IRC21:02
*** apuimedo has quit IRC21:06
*** apuimedo has joined #openstack-ansible21:08
*** raddaoui has quit IRC21:11
*** ig0r_ has quit IRC21:14
*** apuimedo has quit IRC21:17
*** apuimedo has joined #openstack-ansible21:18
openstackgerritJaveria Khan proposed openstack/openstack-ansible: networking-plumgrid package version fix  https://review.openstack.org/26714621:21
*** apuimedo has quit IRC21:22
*** apuimedo has joined #openstack-ansible21:23
*** ig0r_ has joined #openstack-ansible21:23
*** Mudpuppy_ is now known as Mudpuppy21:26
*** sdake has quit IRC21:26
jmccroryhas anyone see failures like this before? ERROR! failed to resolve remote temporary directory from ansible-tmp-1452720259.32-22120987011435121:27
jmccroryintermittent on template tasks21:27
*** apuimedo has quit IRC21:27
*** admin0 has quit IRC21:28
*** apuimedo has joined #openstack-ansible21:28
*** admin0 has joined #openstack-ansible21:28
*** raddaoui has joined #openstack-ansible21:31
*** ig0r_ has quit IRC21:31
*** javeriak_ has quit IRC21:32
mhaydeni have seen that happen from time to time21:34
mhaydeni've usually specified -> remote_tmp = ../someplace21:34
*** apuimedo has quit IRC21:40
*** apuimedo has joined #openstack-ansible21:42
*** jguy_ has quit IRC21:43
*** ig0r_ has joined #openstack-ansible21:44
*** ig0r_ has quit IRC21:45
*** apuimedo has quit IRC21:46
*** apuimedo has joined #openstack-ansible21:47
*** sdake has joined #openstack-ansible21:53
*** alextricity_h has quit IRC21:56
*** sdake_ has joined #openstack-ansible21:56
d34dh0r53can we get reviews on https://review.openstack.org/#/c/267135?21:56
*** sdake has quit IRC21:57
*** ddaskal has joined #openstack-ansible21:58
*** raddaoui has quit IRC22:00
odyssey4med34dh0r53 does it work?22:06
*** apuimedo has quit IRC22:06
*** apuimedo has joined #openstack-ansible22:07
*** Mudpuppy has quit IRC22:09
odyssey4meandymccr FYI, these patches came in yesterday and merged into master today: https://review.openstack.org/264936 / https://review.openstack.org/26602122:09
odyssey4meandymccr we then needed to do https://review.openstack.org/266530 as a follow up22:10
odyssey4meandymccr then finally, to get master working - https://review.openstack.org/26701922:10
odyssey4methat last one's in the gate currently (the gate has a lng queue)22:10
andymccrodyssey4me: yeh i saw that PR I +2'd it but i figured it'd get changed anyway. i had just removed the br_netfilter bit to get it to work in the meantime22:10
mhaydenthat neutron one dinged me good22:10
andymccri'll take a look at that last PR 26701922:11
*** apuimedo has quit IRC22:12
d34dh0r53odyssey4me: yeah22:13
*** apuimedo has joined #openstack-ansible22:13
odyssey4med34dh0r53 I've added my vote +w, the gate is grumpy though22:14
odyssey4mehopefully we gat unwedge the gate in master today, then backport all the bits22:14
*** galstrom is now known as galstrom_zzz22:14
d34dh0r53odyssey4me: thanks man! :)  I'll keep an eye on the gate22:14
odyssey4med34dh0r53 if you can review https://review.openstack.org/267019 and https://review.openstack.org/267136 to help that process, then that'll help22:15
d34dh0r53yep, in a meeting but I'll look at them after22:15
odyssey4meI don't know if the first will need to go back all the way to kilo, but the second will22:15
odyssey4meurgh, the second review number was wrong - this is the one: https://review.openstack.org/26683222:17
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26720022:18
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26720022:20
*** apuimedo has quit IRC22:20
*** apuimedo has joined #openstack-ansible22:21
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26720022:23
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26720322:24
*** apuimedo has quit IRC22:25
*** apuimedo has joined #openstack-ansible22:26
*** mattronix has quit IRC22:34
*** apuimedo has quit IRC22:35
*** apuimedo has joined #openstack-ansible22:37
*** jguy_ has joined #openstack-ansible22:40
*** mattronix has joined #openstack-ansible22:41
*** apuimedo has quit IRC22:41
*** apuimedo has joined #openstack-ansible22:43
*** apuimedo has quit IRC22:50
*** apuimedo has joined #openstack-ansible22:51
*** jguy_ has quit IRC22:52
stevellegogo 26683222:53
*** hybridpollo has joined #openstack-ansible22:54
*** sigmavirus24 is now known as sigmavirus24_awa22:55
*** yaya has left #openstack-ansible22:56
odyssey4mestevelle yep, that and https://review.openstack.org/267019 are the ticket :)22:56
*** jeh has quit IRC22:59
*** apuimedo has quit IRC23:03
*** apuimedo has joined #openstack-ansible23:04
*** spotz is now known as spotz_zzz23:04
odyssey4mestevelle and we have success: https://review.openstack.org/26683223:07
odyssey4mecare to add your vote?23:07
stevelle266832 through gate, just workflowed23:07
stevelle267019 in smoketests23:07
odyssey4mestevelle done, my vote is in23:09
stevelleditto23:10
odyssey4methanks stevelle23:10
stevellewill let them merge and we can look at getting the backports through23:10
*** CheKoLyN has quit IRC23:11
*** evanston_ has quit IRC23:14
*** michaelgugino has quit IRC23:16
*** phiche has quit IRC23:19
*** evanstoner has joined #openstack-ansible23:22
odyssey4mestevelle can we also get this one through? https://review.openstack.org/26716323:22
odyssey4meandymccr ^23:22
andymccrlooking23:22
stevelleodyssey4me: was watching it, ready to push the butan23:22
andymccrmake it so.23:24
*** baker has quit IRC23:29
odyssey4methanks andymccr23:29
*** apuimedo has quit IRC23:30
*** ddaskal has quit IRC23:31
openstackgerritJesse Pretorius proposed openstack/openstack-ansible-galera_server: Merge bashate/pep8 lint jobs in common job  https://review.openstack.org/25775523:31
*** apuimedo has joined #openstack-ansible23:31
*** ddaskal has joined #openstack-ansible23:32
*** baker has joined #openstack-ansible23:32
*** phalmos has quit IRC23:33
*** baker has quit IRC23:33
odyssey4meif anyone has a gap to look into it, https://review.openstack.org/267200 is failing the ansible-lint test23:34
*** spotz_zzz is now known as spotz23:34
*** ddaskal has quit IRC23:36
*** scarlisle has quit IRC23:37
*** baker has joined #openstack-ansible23:37
*** spotz is now known as spotz_zzz23:37
*** apuimedo has quit IRC23:38
*** KLevenstein has quit IRC23:39
*** apuimedo has joined #openstack-ansible23:39
jmccroryodyssey4me looks like it installed ansible223:42
jmccrorywhich doesn't have ansible.util.parse_yaml23:43
jmccroryutils*23:43
*** apuimedo has quit IRC23:44
*** apuimedo has joined #openstack-ansible23:45
odyssey4mejmccrory and so it does seem, how the heck did it do that?23:49
*** apuimedo has quit IRC23:49
*** apuimedo has joined #openstack-ansible23:50
*** baker has quit IRC23:52
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Fix neutron migrations with optional providers  https://review.openstack.org/26723323:53
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Resolve pep8 violations caught by pep8 v1.7.0  https://review.openstack.org/26720323:56
openstackgerritJesse Pretorius proposed openstack/openstack-ansible: Revert the temp tox config change  https://review.openstack.org/26723423:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!