*** markvoelker has quit IRC | 00:03 | |
*** javeriak has quit IRC | 00:26 | |
*** javeriak has joined #openstack-ansible | 00:52 | |
*** markvoelker has joined #openstack-ansible | 01:00 | |
*** markvoelker has quit IRC | 01:04 | |
*** markvoelker has joined #openstack-ansible | 02:00 | |
*** markvoelker has quit IRC | 02:05 | |
*** javeriak has quit IRC | 02:31 | |
*** markvoelker has joined #openstack-ansible | 03:01 | |
*** markvoelker has quit IRC | 03:06 | |
*** cbaesema has quit IRC | 03:45 | |
*** cbaesema has joined #openstack-ansible | 03:47 | |
*** markvoelker has joined #openstack-ansible | 04:02 | |
*** markvoelker has quit IRC | 04:07 | |
*** daneyon has quit IRC | 05:01 | |
*** daneyon has joined #openstack-ansible | 05:02 | |
*** markvoelker has joined #openstack-ansible | 05:03 | |
*** cbaesema_ has joined #openstack-ansible | 05:10 | |
*** cbaesema has quit IRC | 05:13 | |
*** cbaesema_ is now known as cbaesema | 05:13 | |
*** javeriak has joined #openstack-ansible | 06:10 | |
*** markvoelker has quit IRC | 07:04 | |
*** markvoelker has joined #openstack-ansible | 08:03 | |
*** markvoelker has quit IRC | 08:08 | |
*** javeriak has quit IRC | 08:42 | |
*** markvoelker has joined #openstack-ansible | 09:04 | |
*** markvoelker has quit IRC | 09:08 | |
*** markvoelker has joined #openstack-ansible | 10:04 | |
*** markvoelker has quit IRC | 10:09 | |
*** markvoelker has joined #openstack-ansible | 11:05 | |
*** markvoelker has quit IRC | 11:10 | |
*** markvoelker has joined #openstack-ansible | 12:06 | |
*** markvoelker has quit IRC | 12:10 | |
*** markvoelker has joined #openstack-ansible | 12:24 | |
*** sdake has joined #openstack-ansible | 12:58 | |
*** sdake_ has joined #openstack-ansible | 12:59 | |
*** sdake has quit IRC | 13:03 | |
*** britthou_ has joined #openstack-ansible | 13:06 | |
*** britthouser has quit IRC | 13:09 | |
*** britthou_ has quit IRC | 13:37 | |
*** markvoelker has quit IRC | 13:53 | |
*** cbaesema has quit IRC | 13:53 | |
*** palendae has quit IRC | 13:53 | |
*** froots has quit IRC | 13:53 | |
*** raginbajin has quit IRC | 13:53 | |
*** Sam-I-Am has quit IRC | 13:53 | |
*** jwagner_away has quit IRC | 13:53 | |
*** Apsu has quit IRC | 13:53 | |
*** mordred has quit IRC | 13:53 | |
*** jmeridth has quit IRC | 13:53 | |
*** aslaen has quit IRC | 13:53 | |
*** lbragstad has quit IRC | 13:53 | |
*** bgmccollum has quit IRC | 13:53 | |
*** mattoliverau has quit IRC | 13:53 | |
*** jroll has quit IRC | 13:53 | |
*** dolphm has quit IRC | 13:53 | |
*** eglute has quit IRC | 13:53 | |
*** d34dh0r53 has quit IRC | 13:53 | |
*** mattt has quit IRC | 13:53 | |
*** toddnni has quit IRC | 13:53 | |
*** docaedo has quit IRC | 13:53 | |
*** jbweber has quit IRC | 13:53 | |
*** SpamapS has quit IRC | 13:53 | |
*** galstrom_zzz has quit IRC | 13:53 | |
*** miguelgrinberg has quit IRC | 13:53 | |
*** sdake_ has quit IRC | 13:53 | |
*** ccrouch has quit IRC | 13:53 | |
*** sc has quit IRC | 13:53 | |
*** ctgriffiths has quit IRC | 13:53 | |
*** britthouser has joined #openstack-ansible | 13:55 | |
*** mordred has joined #openstack-ansible | 13:55 | |
*** jmeridth has joined #openstack-ansible | 13:55 | |
*** lbragstad has joined #openstack-ansible | 13:55 | |
*** aslaen has joined #openstack-ansible | 13:55 | |
*** bgmccollum has joined #openstack-ansible | 13:55 | |
*** mattoliverau has joined #openstack-ansible | 13:55 | |
*** eglute has joined #openstack-ansible | 13:55 | |
*** dolphm has joined #openstack-ansible | 13:55 | |
*** jroll has joined #openstack-ansible | 13:55 | |
*** d34dh0r53 has joined #openstack-ansible | 13:55 | |
*** mattt has joined #openstack-ansible | 13:55 | |
*** toddnni has joined #openstack-ansible | 13:56 | |
*** docaedo has joined #openstack-ansible | 13:56 | |
*** jbweber has joined #openstack-ansible | 13:56 | |
*** SpamapS has joined #openstack-ansible | 13:56 | |
*** galstrom_zzz has joined #openstack-ansible | 13:56 | |
*** miguelgrinberg has joined #openstack-ansible | 13:56 | |
*** Mudpuppy has joined #openstack-ansible | 13:57 | |
*** markvoelker has joined #openstack-ansible | 13:58 | |
*** cbaesema has joined #openstack-ansible | 13:58 | |
*** palendae has joined #openstack-ansible | 13:58 | |
*** froots has joined #openstack-ansible | 13:58 | |
*** raginbajin has joined #openstack-ansible | 13:58 | |
*** jwagner_away has joined #openstack-ansible | 13:58 | |
*** Sam-I-Am has joined #openstack-ansible | 13:58 | |
*** Apsu has joined #openstack-ansible | 13:58 | |
*** sdake_ has joined #openstack-ansible | 13:58 | |
*** ccrouch has joined #openstack-ansible | 13:58 | |
*** sc has joined #openstack-ansible | 13:58 | |
*** ctgriffiths has joined #openstack-ansible | 13:58 | |
*** Mudpuppy has quit IRC | 13:58 | |
*** Mudpuppy has joined #openstack-ansible | 13:59 | |
*** sc has quit IRC | 13:59 | |
*** Mudpuppy has quit IRC | 14:00 | |
*** markvoelker has quit IRC | 14:00 | |
*** cbaesema has quit IRC | 14:00 | |
*** palendae has quit IRC | 14:00 | |
*** Mudpuppy has joined #openstack-ansible | 14:01 | |
*** markvoelker has joined #openstack-ansible | 14:01 | |
*** cbaesema has joined #openstack-ansible | 14:01 | |
*** palendae has joined #openstack-ansible | 14:01 | |
*** sc has joined #openstack-ansible | 14:01 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:08 | |
*** IRTermite has quit IRC | 14:23 | |
*** jwagner_away is now known as jwagner | 14:26 | |
*** cbaesema has quit IRC | 14:39 | |
*** KLevenstein has joined #openstack-ansible | 14:43 | |
sigmavirus24 | So here's a question for the channel: Since commits themselves describe what's changed very well, should commit messages track everything changed or just why? | 14:57 |
---|---|---|
alextricity | I think they should just describe the "why". I agree with the commits being enough of a description of what changed. | 14:58 |
Sam-I-Am | i'd say more why unless the code isnt obvious | 14:58 |
alextricity | Otherwise you get these commit messages that are novels lol | 14:58 |
Sam-I-Am | in the case of config changes, the changes should be pretty obvious, but need a "why" sometimes | 14:59 |
*** jwagner is now known as jwagner[away] | 15:00 | |
*** jwagner[away] is now known as jwagner | 15:03 | |
*** jwagner is now known as jwagner[away] | 15:03 | |
*** jwagner[away] is now known as jwagner | 15:04 | |
*** jwagner is now known as jwagner[away] | 15:04 | |
*** jwagner[away] is now known as jwagner | 15:09 | |
cloudnull | sigmavirus24 I think that it should just be the "why". | 15:19 |
* sigmavirus24 agrees | 15:19 | |
cloudnull | if more data is provided it should only be done to support the "why" | 15:19 |
cloudnull | as reviewers, it is my assumption that we can read a diff. | 15:20 |
*** sdake has joined #openstack-ansible | 15:20 | |
alextricity | A reasonable assumption | 15:20 |
alextricity | lol | 15:20 |
sigmavirus24 | cloudnull: exactly my point. I'll add some why's to my keystone review but I'm not going to add a detailed description of the diff as some have asked =P | 15:21 |
sigmavirus24 | We should probably add that to our documentation about contributions/reviewing | 15:21 |
cloudnull | sigmavirus24 that might be a good add. but i also think that at some point having too much data in the guidelines just means that nobody will read it. | 15:22 |
*** sdake_ has quit IRC | 15:24 | |
Sam-I-Am | sigmavirus24: this reminds me of docs. make so many needless conventions that people stop contriburing. | 15:29 |
sigmavirus24 | Fair. I think making things clear for reviewers about what's reasonable and what's unreasonable is also worthwhile though | 15:30 |
Sam-I-Am | openstack has a pretty clear description of what goes into commit messages | 15:31 |
sigmavirus24 | Sam-I-Am: yep | 15:31 |
sigmavirus24 | making sure we're following that is good | 15:31 |
Sam-I-Am | somuchworktodosolittletime | 15:31 |
openstackgerrit | Kevin Carter proposed stackforge/os-ansible-deployment: Updating CONTRIBUTING for commit messages https://review.openstack.org/170899 | 15:41 |
cloudnull | sigmavirus24 ^ | 15:41 |
openstackgerrit | Kevin Carter proposed stackforge/os-ansible-deployment: Update to readme to reference doc source more generally https://review.openstack.org/169358 | 15:50 |
*** sacharya has joined #openstack-ansible | 15:57 | |
*** stevemar has joined #openstack-ansible | 16:02 | |
*** dweaver has joined #openstack-ansible | 16:06 | |
*** dweaver has quit IRC | 16:24 | |
*** sdake_ has joined #openstack-ansible | 17:20 | |
*** sdake has quit IRC | 17:23 | |
*** stevemar has quit IRC | 17:30 | |
*** stevemar has joined #openstack-ansible | 17:31 | |
*** sacharya1 has joined #openstack-ansible | 17:44 | |
*** sacharya has quit IRC | 17:47 | |
*** cbaesema has joined #openstack-ansible | 17:48 | |
openstackgerrit | Matthew Kassawara proposed stackforge/os-ansible-deployment: Update keystone middleware in glance for Kilo https://review.openstack.org/170695 | 17:58 |
*** sdake has joined #openstack-ansible | 18:05 | |
*** javeriak has joined #openstack-ansible | 18:06 | |
stevelle | http://paste.openstack.org/show/uE7qMmQAhSbyhGYfIfsj/ seems to be occurring because we are now following masters upstream | 18:06 |
stevelle | anyone else looking at this yet? | 18:06 |
Sam-I-Am | stevelle: yeah, i was working on that with cloudnull | 18:07 |
Sam-I-Am | seems like upstream changed | 18:07 |
stevelle | yeah, that was what I was digging into, realized I should check in on it | 18:07 |
*** sdake_ has quit IRC | 18:09 | |
*** javeriak_ has joined #openstack-ansible | 18:25 | |
*** javeriak has quit IRC | 18:27 | |
*** javeriak has joined #openstack-ansible | 18:28 | |
*** javeriak_ has quit IRC | 18:31 | |
*** javeriak_ has joined #openstack-ansible | 18:33 | |
*** javeriak has quit IRC | 18:35 | |
*** javeriak has joined #openstack-ansible | 18:36 | |
*** javeriak_ has quit IRC | 18:39 | |
openstackgerrit | David Wilde proposed stackforge/os-ansible-deployment: Nova Kilofication Work - API deprecation and addition https://review.openstack.org/170952 | 18:45 |
openstackgerrit | Ian Cordasco proposed stackforge/os-ansible-deployment: Update Keystone config and policy for Kilo https://review.openstack.org/167475 | 18:52 |
sigmavirus24 | ^ is r4r | 18:52 |
*** javeriak has quit IRC | 18:55 | |
*** javeriak_ has joined #openstack-ansible | 18:56 | |
alextricity | How does OSAD build out my addiontal user configs into the inventory? In other words, if I had this user_config for ceilo, how would I refernce the variables in a template? http://pastebin.com/4mHczwRp | 19:05 |
alextricity | It doesn't look like they get built into inventory | 19:06 |
alextricity | nvm I see them now :) | 19:06 |
alextricity | So i would reference db_type like so? {{ ceilometer.db_type }}? | 19:07 |
openstackgerrit | David Wilde proposed stackforge/os-ansible-deployment: Nova Kilofication Work - API deprecation and addition https://review.openstack.org/170952 | 19:12 |
cloudnull | alextricity that'd be one way. however we've stayed away from hashes and hash merging. imo it would be better to move that data into the role as a default which can be overriden | 19:15 |
cloudnull | in that way a user can override it in `user_variables` which can be encrypted using ansible vault. while inventory can not be encrypted. | 19:15 |
alextricity | I see. Okay will do! Thanks cloudnull | 19:16 |
*** uschreiber_ has joined #openstack-ansible | 19:18 | |
*** uschreiber_ has quit IRC | 19:23 | |
openstackgerrit | Ian Cordasco proposed stackforge/os-ansible-deployment: Horizon config changes for kilo https://review.openstack.org/167460 | 19:44 |
sigmavirus24 | ^^ I haven't tested that but I'm going to | 19:44 |
sigmavirus24 | Figured it'd be better to just push what I had (which looks 99.99% complete) | 19:44 |
cloudnull | sigmavirus24: "#HORIZON_CONFIG["disable_password_reveal"] = False" is still commented out. | 19:51 |
* sigmavirus24 missed that | 19:52 | |
cloudnull | it happens :) | 19:52 |
cloudnull | can you do "# ENFORCE_PASSWORD_CHECK = False" also ? | 19:52 |
cloudnull | :) | 19:52 |
sigmavirus24 | weird. I could have sworn I did that one | 19:54 |
*** sdake_ has joined #openstack-ansible | 19:54 | |
* sigmavirus24 is imagining things I guess | 19:54 | |
openstackgerrit | David Wilde proposed stackforge/os-ansible-deployment: Nova Kilofication Work - API deprecation and addition https://review.openstack.org/170952 | 19:57 |
*** sdake has quit IRC | 19:58 | |
*** sacharya1 has quit IRC | 20:12 | |
*** sacharya has joined #openstack-ansible | 20:13 | |
openstackgerrit | Ian Cordasco proposed stackforge/os-ansible-deployment: Horizon config changes for kilo https://review.openstack.org/167460 | 20:18 |
sigmavirus24 | Sam-I-Am: ^ | 20:19 |
* sigmavirus24 is still building ^ btw | 20:23 | |
Sam-I-Am | sigmavirus24: da | 20:23 |
Sam-I-Am | looks better, sir | 20:23 |
Sam-I-Am | sigmavirus24: building locally? | 20:23 |
sigmavirus24 | no on a cloudserver | 20:23 |
Sam-I-Am | errr, not in the gate, rather | 20:24 |
sigmavirus24 | yes | 20:24 |
sigmavirus24 | mine should finish first | 20:24 |
cloudnull | sigmavirus24: https://review.openstack.org/#/c/167460/10/playbooks/roles/os_horizon/defaults/main.yml | 20:42 |
*** sdake_ has quit IRC | 20:44 | |
openstackgerrit | Ian Cordasco proposed stackforge/os-ansible-deployment: Horizon config changes for kilo https://review.openstack.org/167460 | 20:54 |
palendae | cloudnull: My proposal would be to enable linting checks as non-voting first then fix the issues | 21:18 |
palendae | But I'm not super tied to that | 21:18 |
palendae | Basically I wanted to write that down so I didn't forget it :) | 21:18 |
palendae | I think someone had mentioned it at some point as "that'd be a good idea, huh?" | 21:19 |
cloudnull | for sure. i think we `partal-bug` the fixes one by one and then add it to our current lint check as voting. | 21:19 |
palendae | +1 | 21:19 |
cloudnull | in this way we dont have to bother infra . | 21:19 |
cloudnull | which i think we've bothered enough for the next few months. | 21:20 |
cloudnull | :) | 21:20 |
palendae | Yep, fair | 21:21 |
palendae | Yeah, if we just modify the current job we could fix stuff beforehand, then add the line | 21:21 |
palendae | Probably also have to install flake8 | 21:21 |
openstackgerrit | David Wilde proposed stackforge/os-ansible-deployment: Nova Kilofication Work - API deprecation and addition https://review.openstack.org/170952 | 21:26 |
*** sdake has joined #openstack-ansible | 21:29 | |
openstackgerrit | David Wilde proposed stackforge/os-ansible-deployment: Nova Kilofication Work - API deprecation and addition https://review.openstack.org/170952 | 21:30 |
*** sdake_ has joined #openstack-ansible | 21:33 | |
*** sdake has quit IRC | 21:34 | |
*** Mudpuppy_ has joined #openstack-ansible | 21:45 | |
*** Mudpuppy has quit IRC | 21:48 | |
*** Mudpuppy_ has quit IRC | 21:49 | |
sigmavirus24 | palendae: installing flake8 is soooo hard ;) | 21:52 |
Apsu | Just put a pre-commit hook in the git repo to run flake8 | 21:53 |
Apsu | And fail if it's not installed | 21:53 |
Apsu | Then it'll unkindly remind devs to install it themselves :P | 21:53 |
*** BjoernT has joined #openstack-ansible | 22:02 | |
*** BjoernT has quit IRC | 22:04 | |
*** BjoernT has joined #openstack-ansible | 22:04 | |
openstackgerrit | David Wilde proposed stackforge/os-ansible-deployment: Nova Kilofication Work - API deprecation and addition https://review.openstack.org/170952 | 22:09 |
palendae | sigmavirus24: Didn't say it was, just something we need to remember when adding its checks to the lint job | 22:09 |
*** sacharya has quit IRC | 22:19 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:22 | |
*** BjoernT has quit IRC | 22:24 | |
*** KLevenstein has quit IRC | 22:25 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 22:45 | |
*** markvoelker has quit IRC | 22:52 | |
*** devlaps has joined #openstack-ansible | 22:59 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:21 | |
*** markvoelker has joined #openstack-ansible | 23:27 | |
*** sdake has joined #openstack-ansible | 23:42 | |
*** sdake_ has quit IRC | 23:45 | |
*** markvoelker has quit IRC | 23:53 | |
openstackgerrit | Miguel Grinberg proposed stackforge/os-ansible-deployment: Horizon config changes for kilo https://review.openstack.org/167460 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!