| jm1 | gtema: moin :) what do you think about https://review.opendev.org/c/openstack/ansible-collections-openstack/+/844559/comments/f59e1517_cb1257de ? | 07:30 |
|---|---|---|
| gtema | moin jm1, since I am the initial author of it I am surely ok with it ;-) | 07:35 |
| jm1 | gtema: what is the point in having four levels? the patch only implements debug yes or no | 07:40 |
| gtema | ah, that is what you mean | 07:41 |
| gtema | you are right - it is not really properly implemented. Sadly I am on a business trip and cant access SSH what literally means I can't update the change until I come back to the office | 07:42 |
| jm1 | gtema: ack, we have other patches to work on 🙈 | 07:44 |
| gtema | sure, will try to update it in next days once I have a stable wifi in the train (better then in office) | 07:45 |
| jm1 | gtema: great 👍 | 07:47 |
| jm1 | sshnaidm, rcastillo: ^ | 07:50 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update subnet module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/845183 | 08:10 |
| *** rlandy|out is now known as rlandy | 09:33 | |
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Move keypair module to proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847960 | 10:28 |
| *** dviroel|out is now known as dviroel | 11:20 | |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update subnet module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/845183 | 12:38 |
| jm1 | rcastillo: reviewed and updated your subnet fix, please have a look :) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/845183/19..20 | 12:46 |
| rcastillo | jm1: ack, looking | 12:55 |
| jm1 | rcastillo: fixing the linting errror right now | 13:00 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update subnet module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/845183 | 13:00 |
| jm1 | rcastillo: any idea what it could be? | 13:02 |
| jm1 | rcastillo: submitted a new revision but i doubt that fixes it | 13:03 |
| rcastillo | jm1: the linting error? I think you got it | 13:03 |
| jm1 | rcastillo: ^^ ok then lets see what ci says | 13:03 |
| jm1 | rcastillo: btw that was a huge refactoring you did. great work! | 13:04 |
| rcastillo | yup, it's a big one | 13:10 |
| rcastillo | hopefully ci agrees | 13:10 |
| rcastillo | brb | 13:10 |
| jm1 | rcastillo: ok linting errors fixed | 13:20 |
| jm1 | rcastillo: patch merge in progress | 14:59 |
| *** dviroel is now known as dviroel|lunch | 15:24 | |
| opendevreview | Merged openstack/ansible-collections-openstack master: Update subnet module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/845183 | 15:27 |
| *** rlandy is now known as rlandy|biab | 15:51 | |
| *** rlandy|biab is now known as rlandy | 16:27 | |
| *** dviroel|lunch is now known as dviroel | 16:37 | |
| *** undefined_ is now known as Guest3684 | 17:55 | |
| *** Guest3684 is now known as rcastillo_ | 17:55 | |
| *** rcastillo_ is now known as rcastillo | 17:57 | |
| *** dviroel is now known as dviroel|biab | 20:30 | |
| *** dviroel|biab is now known as dviroel | 22:09 | |
| *** rlandy is now known as rlandy|bbl | 22:25 | |
| *** dviroel is now known as dviroel|out | 22:28 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!