| *** ysandeep|out is now known as ysandeep | 02:04 | |
| *** ysandeep is now known as ysandeep|afk | 05:15 | |
| *** ysandeep|afk is now known as ysandeep | 05:56 | |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Make publish_collection more universal https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847659 | 07:11 |
|---|---|---|
| *** frenzyfriday|PTO is now known as frenzy_friday | 07:13 | |
| jm1 | dtantsur, sshnaidm: Hello :) Functionality in IronicModule (auth_type and ironic_url) had originally been introduced with shade library in 2016 [1]. This code has been kept for backward compat, i guess. [1] https://github.com/ansible/ansible/commit/011267c04edefa912b4915ed2026a3d46f128cf1 | 07:55 |
| jm1 | dtantsur, sshnaidm: Since we have openstacksdk and auth/cloud in OpenStackModule now, can we drop this old code in master? This would help us because we would have only a single base class OpenStackModule and save us from rebasing/reparenting IronicModule. | 07:55 |
| sshnaidm | jm1, I think Ironic should have functionality to auth w/o keystone, they use it standalone | 07:56 |
| sshnaidm | but let dtantsur to confirm | 07:57 |
| jm1 | sshnaidm: which should be possible without ironic_url, since this is used to set auth.endpoint only https://opendev.org/openstack/ansible-collections-openstack/src/commit/c6c1c6a0708cd9efa7400c8c22322a77076d466d/plugins/module_utils/ironic.py#L67 | 07:59 |
| jm1 | sshnaidm: 'auth_type' is supported by OpenStackModule as well, so client code would have to switch from ironic_url to auth.endpoint only | 08:00 |
| sshnaidm | jm1, idk if it's possible tbh and if it will work | 08:01 |
| sshnaidm | we need to inherit ironic module from openstack I think | 08:01 |
| sshnaidm | and then to make required changes in it | 08:01 |
| sshnaidm | so that we don't change things in multiple places | 08:01 |
| sshnaidm | but we can't really test ironic changes in CI which makes things more fragile | 08:02 |
| jm1 | sshnaidm: lets first wait for dtantsur to confirm that no functionality is lost when removing ironic_url (the latter is not used within openstacksdk). then there is nothing left in IronicModule and we can just drop it | 08:03 |
| sshnaidm | Ironic wasn't affected by SDK changes, isn't it? | 08:06 |
| jm1 | sshnaidm: it is affected | 08:08 |
| *** rlandy|out is now known as rlandy | 09:29 | |
| *** ysandeep is now known as ysandeep|afk | 09:50 | |
| *** ysandeep|afk is now known as ysandeep | 10:38 | |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored endpoint module and explained region attribute https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847293 | 11:34 |
| *** dviroel|out is now known as dviroel | 12:01 | |
| *** arxcruz is now known as arxcruz|brb | 12:42 | |
| opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Make publish_collection more universal https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847659 | 12:48 |
| *** arxcruz|brb is now known as arxcruz | 13:48 | |
| opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves security_group_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840660 | 13:56 |
| opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves security_group_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840660 | 14:05 |
| *** dviroel is now known as dviroel|lunch | 15:27 | |
| *** ysandeep is now known as ysandeep|PTO | 16:09 | |
| *** dviroel|lunch is now known as dviroel | 16:37 | |
| *** Guest3279 is now known as rcastillo | 17:20 | |
| *** rlandy is now known as rlandy|afk | 18:40 | |
| *** rlandy|afk is now known as rlandy | 19:23 | |
| *** dviroel is now known as dviroel|out | 21:40 | |
| opendevreview | Merged openstack/ansible-collections-openstack master: Update project_info module to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837276 | 21:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!