| *** rlandy|bbl is now known as rlandy | 00:57 | |
| *** rlandy is now known as rlandy|out | 01:45 | |
| *** ysandeep|sick is now known as ysandeep | 04:37 | |
| *** ysandeep is now known as ysandeep|lunch | 07:45 | |
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update role_assignment to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843830 | 09:04 |
|---|---|---|
| *** ysandeep|lunch is now known as ysandeep | 09:14 | |
| *** rlandy|out is now known as rlandy | 10:23 | |
| *** dviroel|out is now known as dviroel | 11:22 | |
| *** rlandy is now known as rlandy|mtg | 11:55 | |
| *** ysandeep is now known as ysandeep|afk | 12:15 | |
| sshnaidm | arxcruz, can you please fix a nit in followup? https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 I'd like to merge it | 12:25 |
| arxcruz | sshnaidm sure, give me one sec | 12:26 |
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | 12:27 |
| arxcruz | sshnaidm done ^ | 12:27 |
| *** ysandeep|afk is now known as ysandeep | 12:30 | |
| sshnaidm | arxcruz, ++ | 12:38 |
| *** rlandy|mtg is now known as rlandy | 13:30 | |
| *** ysandeep is now known as ysandeep|out | 14:25 | |
| gtema | guys, question about search_ list_ interface of the SDK (with name_or_id and filters) | 14:58 |
| gtema | I have some conceptual problems | 14:58 |
| gtema | you say your can't properly pass id as name_or_id | 14:59 |
| gtema | so I started to make some rework and faced following question: | 14:59 |
| gtema | what should sdk return if name_or_id is passed as ID, but resource is not matching filters? | 14:59 |
| opendevreview | Merged openstack/ansible-collections-openstack master: Update catalog service for the new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839352 | 15:14 |
| rcastillo | gtema: it would make more sense to me to not return the resource in that case | 15:18 |
| rcastillo | ie you're filtering by domain and you ask for a resource in another domain | 15:19 |
| rcastillo | would be weird to get a result | 15:19 |
| gtema | tja, it seems logical, but pretty complex to implement (especially globally). Point is that we can use ID as query param | 15:19 |
| gtema | so I need to check previously if there is resource by ID | 15:20 |
| gtema | and this is completely separate branch of code, compared to go list and filter | 15:20 |
| gtema | on the other side | 15:20 |
| gtema | when user uses Ansible I can't imagine usecase of trying to pass ID (which is a unique instance) and try to further filter | 15:21 |
| rcastillo | you're right about that | 15:22 |
| rcastillo | even though it'd be surprising when that happens, I wouldn't be opposed to ignoring the filters when an ID is passed | 15:23 |
| rcastillo | especially if it makes the implementation significantly simpler | 15:23 |
| gtema | that's pretty much what I have now | 15:24 |
| gtema | https://review.opendev.org/c/openstack/openstacksdk/+/845726 implements basic filtering | 15:24 |
| rcastillo | I can't seem to think of any use case that would *break* from this behavior | 15:24 |
| gtema | and now I am trying to update list_projects (not the search_projects) to this way | 15:24 |
| gtema | pretty much: https://review.opendev.org/c/openstack/openstacksdk/+/845776 | 15:26 |
| gtema | so pls have a look whether you would be ok with that. If yes - I will work on updating remaining methods so that we can further align the interface for Ansible | 15:27 |
| rcastillo | ahh, this is for adding filtering back to the client side | 15:28 |
| rcastillo | looks solid to me, should work for us | 15:28 |
| gtema | yes, that is precisely the scope | 15:28 |
| gtema | just want to avoid doing huge work again without consensus | 15:29 |
| gtema | there are now jobs checking with Depends-On of SDK, right? | 15:30 |
| gtema | I can try playing with project_info module for that case | 15:30 |
| opendevreview | Merged openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | 15:32 |
| rcastillo | gtema: I believe so. Let me know if that doesn't work for you | 15:34 |
| gtema | oki, thks | 15:34 |
| opendevreview | Merged openstack/ansible-collections-openstack master: Update role_assignment to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843830 | 15:39 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Moves keypair_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/827274 | 15:55 |
| *** dviroel is now known as dviroel|lunch | 15:58 | |
| opendevreview | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch project_info to new SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/845782 | 16:02 |
| *** dviroel|lunch is now known as dviroel | 17:17 | |
| *** rlandy is now known as rlandy|mtg | 18:15 | |
| *** rlandy|mtg is now known as rlandy | 19:01 | |
| *** dviroel is now known as dviroel|afk | 20:46 | |
| *** rlandy is now known as rlandy|bbl | 21:58 | |
| *** rlandy|bbl is now known as rlandy | 23:59 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!