| holtgrewe | Hello. Following the earlier discussion, I have added a feature to add a "files" argument to the openstack.cloud.server module. I did not know how to update the patch set so there are now 819657 and 819811 in Gerrit. How do we proceed here? Cleanup my redundant patch sets or could we discuss the problem of JSON serializability of io.open() result? (CC sshnaidm ) | 07:50 |
|---|---|---|
| jrosser | holtgrewe: your patch is uniquely identified in gerrit by the 'change-id' in gerrit | 08:00 |
| jrosser | so if you had 'git commit --amend' your fixes into the original patch, and re-run git review it would have created a new revision of the original patch | 08:00 |
| jrosser | you can still do that to the original one, and abandon the second one in the gerrit UI if you like | 08:01 |
| holtgrewe | OK, I had two change-id's in there. | 08:01 |
| jrosser | right, but i think the thing here is you've got to iterate on the first patch to get it to pass the tests, you can't put those fixes in a follow up as each patch has to pass in it's own right | 08:02 |
| jrosser | i would do some local git stuff to combine 819811 into 819657, and push up a new revision of the original | 08:04 |
| opendevreview | Manuel Holtgrewe proposed openstack/ansible-collections-openstack master: Adding "files/config_drive_files" to server module. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/819657 | 08:04 |
| holtgrewe | jrosser, thanks, abandoned the second one | 08:05 |
| *** priteau is now known as Guest7388 | 16:38 | |
| *** priteau_ is now known as priteau | 16:38 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!