| *** spatel has quit IRC | 00:03 | |
| *** openstackgerrit has quit IRC | 00:58 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-ansible-sig | 05:33 | |
| *** gtema has joined #openstack-ansible-sig | 07:48 | |
| *** openstackgerrit has joined #openstack-ansible-sig | 07:48 | |
| openstackgerrit | Polina Gubina proposed openstack/ansible-collections-openstack master: Enabling update for recordset https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765913 | 07:48 |
|---|---|---|
| *** tremble has joined #openstack-ansible-sig | 08:28 | |
| openstackgerrit | Tino Schreiber proposed openstack/ansible-collections-openstack master: Add security_group_rule_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765580 | 09:55 |
| sshnaidm | I'm going to fix CI linter jobs | 09:59 |
| sshnaidm | now 2.10 and devel fails because of docs-args mismatch | 09:59 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Fix docs-args mismatch in modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765960 | 10:06 |
| *** tosin has joined #openstack-ansible-sig | 10:53 | |
| *** tosin has quit IRC | 11:50 | |
| *** frenzyfriday has joined #openstack-ansible-sig | 12:38 | |
| *** frenzyfriday has quit IRC | 12:38 | |
| *** tosin has joined #openstack-ansible-sig | 12:58 | |
| *** spatel has joined #openstack-ansible-sig | 13:19 | |
| *** owalsh has quit IRC | 13:20 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Fix docs-args mismatch in modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765960 | 13:26 |
| openstackgerrit | Polina Gubina proposed openstack/ansible-collections-openstack master: Enabling update for recordset https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765913 | 13:58 |
| *** tosin has quit IRC | 14:38 | |
| *** tosin61 has joined #openstack-ansible-sig | 14:38 | |
| *** tosin61 has quit IRC | 14:38 | |
| *** tosin has joined #openstack-ansible-sig | 14:38 | |
| *** tosin has quit IRC | 14:52 | |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Add security_group_rule_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765580 | 14:52 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Migrating network from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764411 | 14:56 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: WIP add network tests for versioned args https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766013 | 15:05 |
| sshnaidm | frenzy_friday, ^^ | 15:06 |
| frenzy_friday | sshnaidm, thanks for the tests. I would like to add to it. How do I make a task with a particular ansible version, say < 0.18.0 , to check that parameters like mtu_size do not work | 15:20 |
| sshnaidm | frenzy_friday, it's SDK version, not ansible | 15:20 |
| frenzy_friday | ohh! | 15:21 |
| sshnaidm | frenzy_friday, we run jobs on various branches, starting from rocky | 15:21 |
| sshnaidm | frenzy_friday, for checking which release in which branch, need to go to https://releases.openstack.org/ | 15:22 |
| sshnaidm | frenzy_friday, for example, find there rocky branch: https://releases.openstack.org/rocky/index.html | 15:23 |
| sshnaidm | frenzy_friday, and sdk version in it: https://releases.openstack.org/rocky/index.html#rocky-openstacksdk | 15:23 |
| sshnaidm | latest is 0.17.3 | 15:23 |
| sshnaidm | so tests on rocky branch will run with SDK version 0.17.3 | 15:24 |
| sshnaidm | gtema, correct me if I'm wrong ^ | 15:24 |
| gtema | yes, should be correct | 15:25 |
| frenzy_friday | cool, then can I tag a task to run on branch rocky and assert failure, and assert pass on a higher branch? | 15:25 |
| gtema | there's also now rocky-em branch (current state same as 0.17.3) | 15:25 |
| sshnaidm | frenzy_friday, task shouldn't fail on any branch, check_versioned function should take care of it and not to pass arguments from later versions | 15:26 |
| frenzy_friday | ohh, got it now | 15:27 |
| sshnaidm | frenzy_friday, so if you have min_ver=0.18 for mtu, the mtu shouldn't be passed to kwargs in rocky | 15:27 |
| sshnaidm | frenzy_friday, all magic is here: https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/module_utils/openstack.py#L376 | 15:28 |
| frenzy_friday | yeah, i didnt check the method, sorry | 15:28 |
| frenzy_friday | Shall I add port_security_enabled param also to the task Create network with new SDK params ? And add another info task to assert the new values are reflected? | 15:30 |
| sshnaidm | frenzy_friday, yeah, feel free to improve this patch | 15:34 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Migrating volume from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/765542 | 16:05 |
| openstackgerrit | Will Tome proposed openstack/ansible-collections-openstack master: add option to exclude legacy groups https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766047 | 16:54 |
| *** owalsh has joined #openstack-ansible-sig | 17:13 | |
| *** tremble has quit IRC | 17:34 | |
| *** gtema has quit IRC | 17:41 | |
| openstackgerrit | Ananya proposed openstack/ansible-collections-openstack master: WIP add network tests for versioned args https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766013 | 18:05 |
| *** tremble has joined #openstack-ansible-sig | 19:18 | |
| *** spatel has quit IRC | 22:19 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!