| *** qur70 has quit IRC | 00:03 | |
| *** spatel has joined #openstack-ansible-sig | 00:30 | |
| *** spatel has quit IRC | 00:35 | |
| *** spatel has joined #openstack-ansible-sig | 01:06 | |
| *** spatel has quit IRC | 02:01 | |
| *** iurygregory has quit IRC | 02:25 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-ansible-sig | 05:33 | |
| *** iurygregory has joined #openstack-ansible-sig | 07:02 | |
| *** spatel has joined #openstack-ansible-sig | 07:31 | |
| *** gtema has joined #openstack-ansible-sig | 07:32 | |
| *** spatel has quit IRC | 07:35 | |
| *** openstackgerrit has joined #openstack-ansible-sig | 08:57 | |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: volume_type https://review.opendev.org/c/openstack/ansible-collections-openstack/+/757562 | 08:57 |
|---|---|---|
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: volume_type https://review.opendev.org/c/openstack/ansible-collections-openstack/+/757562 | 08:59 |
| sshnaidm | gtema, tremble please review, moving to 2.10 as main release: https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763838 | 09:21 |
| gtema | ok | 09:22 |
| * tremble has a look | 09:23 | |
| sshnaidm | for ansible devel 2.11 will fix later | 09:25 |
| tremble | sshnaidm, Dumb question why do the queens tests run against openstacksdk master, and the rocky-ussuri tests run against the relevant stable branches? That's going to block testing things based on new features of the SDK is it not? | 09:31 |
| sshnaidm | queens is a special because ansible modules don't support SDK of queens branch | 09:32 |
| sshnaidm | we support from sdk .12, and it's after queens iirc | 09:32 |
| sshnaidm | new features of sdk should check sdk version | 09:33 |
| tremble | Oh and skip the tests if the SDK version is unsupported? | 09:34 |
| tremble | ok, that makes more sense. | 09:34 |
| sshnaidm | https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/module_utils/openstack.py#L320-L340 | 09:35 |
| sshnaidm | yep ^ | 09:35 |
| sshnaidm | tremble, because some users use old version of sdk that is delivered together with old version of openstack | 09:35 |
| sshnaidm | it's very difficult to explain that sdk of latest version can be used with older openstack versions | 09:36 |
| tremble | So we need to make sure that existing things don't break, while still providing a mechanism for folks to test against master | 09:36 |
| tremble | Ok, that makes sense | 09:36 |
| sshnaidm | maybe because of that openstack SDK should be just branchless? :) | 09:36 |
| sshnaidm | gtema, ^ | 09:37 |
| *** iurygregory has quit IRC | 09:37 | |
| gtema | well, we can't simply go branchless | 09:37 |
| sshnaidm | if latest version is supposed to work with all versions below, why to use stable branches for it? | 09:37 |
| gtema | one reason is that some components use SDK inside (nova, ironic) | 09:37 |
| gtema | I would tend to say - we can stop testing those | 09:38 |
| * tremble wishes the SDK was more complete, but from experience so far that's not going to be a small task | 09:38 | |
| gtema | with 0.8 guys working on it - sure | 09:39 |
| tremble | Ouch, not even 1 FTE | 09:39 |
| gtema | working hard from my side | 09:39 |
| gtema | surely not | 09:39 |
| gtema | myself I do this also not as a dedicated person | 09:39 |
| gtema | hopefully this cycle we will get 100% nova coverage | 09:40 |
| tremble | Well I'll continue to throw things over when I need them. It's good having a boss who lets me spend time on things like that rather than adding hacky shell scripts | 09:40 |
| gtema | at least this is a target to achieve for OSC, but it depends on SDK | 09:40 |
| gtema | yeah, how right you are | 09:41 |
| gtema | hacking bash scripts is not cool | 09:41 |
| tremble | gtema, Any chance you could take a look at https://review.opendev.org/c/openstack/openstacksdk/+/756655 and https://review.opendev.org/c/openstack/openstacksdk/+/757891 I've tested them with https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763838 and the unit tests are there, I have no idea where to start with any SDK functional tests | 09:42 |
| gtema | yes, I am trying | 09:43 |
| gtema | I didn't forget those | 09:43 |
| tremble | :) | 09:43 |
| *** iurygregory has joined #openstack-ansible-sig | 09:43 | |
| tremble | Took me a while to realize what the unit tests were doing under the hood and how that interacted with the particular non-normal API I needed to interact with | 09:44 |
| gtema | once zuul verifies them I will proceed | 09:44 |
| tremble | That's fair enough | 09:44 |
| gtema | yes, SDK tests are interesting. As the SDK as such | 09:44 |
| tremble | ./openstack/tests/unit/block_storage/v3/test_proxy.py:92:80: E501 line too long (80 > 79 characters | 10:27 |
| tremble | self._verify2("openstack.block_storage.v3.type.Type.delete_extra_specs", | 10:27 |
| tremble | Bah! | 10:27 |
| *** spatel has joined #openstack-ansible-sig | 10:31 | |
| *** spatel has quit IRC | 10:36 | |
| *** SiavashSardari has joined #openstack-ansible-sig | 10:59 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Move CI jobs to base on Ansible 2.10 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763838 | 11:06 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Add victoria stable branch job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763962 | 11:20 |
| *** gtema has quit IRC | 11:29 | |
| SiavashSardari | hey guys, I have a question about subnet plugin in ansible collections. these lines here https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/subnet.py#L349-L350 cause me error for updating subnets, I wanted to create a story and upload a patch to resolve my issue, but I'd appreciate your input on this, | 11:51 |
| SiavashSardari | maybe there are use cases here that I don't see | 11:51 |
| sshnaidm | SiavashSardari, we don't know what is the error you have, so better I think is to create a story | 11:53 |
| sshnaidm | SiavashSardari, https://storyboard.openstack.org/#!/project/openstack/ansible-collections-openstack | 11:54 |
| SiavashSardari | Thanks | 11:54 |
| *** gtema has joined #openstack-ansible-sig | 12:09 | |
| sshnaidm | SiavashSardari, commented on bug | 12:10 |
| sshnaidm | you can't just remove lines because they throw an error.. | 12:11 |
| sshnaidm | it's not really how things are being fixed | 12:11 |
| SiavashSardari | sshnaidm you are absolutely right, I will provide more info asap | 12:15 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: WIP fix Ansible devel jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763966 | 12:28 |
| SiavashSardari | sshnaidm I updated the bug description. | 12:34 |
| sshnaidm | SiavashSardari, sorry, it doesn't male things more clear, you have only variables there and no any value. Can you please replace "item.." with real values? | 12:55 |
| sshnaidm | SiavashSardari, for reproducing it we need something real | 12:56 |
| sshnaidm | SiavashSardari, easy playbook for reproducing would be very appreciated | 12:58 |
| SiavashSardari | sshnaidm ok I will update the description, sorry for the inconvenience, I'm new here. but let me explain here too, the subnet module code will add new allocation pool to the old allocation pool, which is against the descriptive nature of ansible. | 13:02 |
| sshnaidm | SiavashSardari, what are pools you have before task? | 13:02 |
| sshnaidm | SiavashSardari, you are running subnet task on existing subnet, right? | 13:03 |
| SiavashSardari | sshnaidm I had 172.16.16.65,172.16.16.254 and I didn't change it. I just wanted to enable dhcp on my subnet. yep I'm running the task on an existing subnet which was created by the same task, before | 13:05 |
| sshnaidm | SiavashSardari, cool | 13:05 |
| sshnaidm | SiavashSardari, and is this new task exactly same as one that created subnet? | 13:05 |
| sshnaidm | I see that "need_update" is true, so I suppose something is changing..? | 13:06 |
| SiavashSardari | sshnaidm yes it is, only change is enable_dhcp | 13:06 |
| sshnaidm | SiavashSardari, great, can you please paste this task? But with real values, not variables | 13:07 |
| sshnaidm | I'll try to reproduce it | 13:07 |
| SiavashSardari | will do | 13:07 |
| SiavashSardari | sshnaidm now that I'm writing it more simply, I remembered that I had the same issue with updating dns_nameservers on subnets too. | 13:16 |
| sshnaidm | SiavashSardari, ok | 13:16 |
| sshnaidm | SiavashSardari, add dns case as well | 13:17 |
| SiavashSardari | ok | 13:18 |
| SiavashSardari | sshnaidm the description is updated. shall I go on and upload a patch regarding this issue? | 13:27 |
| sshnaidm | SiavashSardari, thanks I've reproduced it, I'm working on a fix | 13:28 |
| sshnaidm | SiavashSardari, can you add same for dns case? | 13:28 |
| SiavashSardari | sshnaidm I tried to explain how to reproduce the dns case in the description as well. | 13:29 |
| openstackgerrit | Siavash Sardari proposed openstack/ansible-collections-openstack master: Remove adding allocation pool to existing allocation pool. updating subnet info should take care of allocation pools too, this will cause conflict exception and is against the descriptive nature of ansible, thus there is no need toadding new pool to the existing pool. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763974 | 13:30 |
| sshnaidm | SiavashSardari, thanks | 13:30 |
| sshnaidm | SiavashSardari, please add empty line after first line in commit message | 13:59 |
| SiavashSardari | ok | 14:00 |
| openstackgerrit | Siavash Sardari proposed openstack/ansible-collections-openstack master: Remove adding allocation pool to existing allocation pool. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763974 | 14:02 |
| *** SiavashSardari has quit IRC | 14:37 | |
| -openstackstatus- NOTICE: The Gerrit service on review.opendev.org is being restarted quickly to troubleshoot an SMTP queuing backlog, downtime should be less than 5 minutes | 16:41 | |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Fix subnets update and idempotency https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764043 | 17:37 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Fix volume_info arguments for SDK 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764046 | 17:49 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Add tests for volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/746413 | 17:52 |
| *** iurygregory has quit IRC | 17:59 | |
| *** gtema has quit IRC | 18:26 | |
| *** iurygregory has joined #openstack-ansible-sig | 18:27 | |
| *** gtema has joined #openstack-ansible-sig | 18:32 | |
| *** gtema has quit IRC | 18:34 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Add victoria stable branch job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763962 | 18:56 |
| *** qur70 has joined #openstack-ansible-sig | 20:10 | |
| *** qur70 has quit IRC | 20:15 | |
| openstackgerrit | Ananya Banerjee proposed openstack/ansible-collections-openstack master: Migrating server_volume from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764060 | 20:36 |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Fix Ansible devel jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763966 | 20:40 |
| openstackgerrit | Ananya Banerjee proposed openstack/ansible-collections-openstack master: Migrating networks_info from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/763543 | 21:01 |
| openstackgerrit | Ananya Banerjee proposed openstack/ansible-collections-openstack master: Migrating server_volume from AnsibleModule to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/764060 | 21:15 |
| *** frenzy_friday has quit IRC | 23:04 | |
| openstackgerrit | Shnaidman Sagi proposed openstack/ansible-collections-openstack master: Add tests for volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/746413 | 23:55 |
| *** openstackgerrit has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!