| *** iurygregory has quit IRC | 02:07 | |
| *** dmsimard has quit IRC | 02:49 | |
| *** dmsimard has joined #openstack-ansible-sig | 02:50 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-ansible-sig | 05:33 | |
| *** iurygregory has joined #openstack-ansible-sig | 07:29 | |
| *** sshnaidm|off is now known as sshnaidm | 07:46 | |
| *** gtema has joined #openstack-ansible-sig | 08:13 | |
| noonedeadpunk | Hi everyone! How do you think - should we fail here https://opendev.org/openstack/ansible-collections-openstack/src/tag/1.0.0/plugins/modules/endpoint.py#L161-L162if endpoint state is set to absent? | 08:20 |
|---|---|---|
| *** gtema has quit IRC | 08:27 | |
| *** gtema has joined #openstack-ansible-sig | 08:31 | |
| openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/ansible-collections-openstack master: Do not fail when endpoint state is absent https://review.opendev.org/762798 | 08:35 |
| noonedeadpunk | ie ^ | 08:35 |
| tremble | noonedeadpunk, Trying to ensure that something you want to be gone is gone should return "result is not changed" rather than throwing an exception, this is the standard Ansible module behaviour. | 10:13 |
| sshnaidm | +1 ^^ | 10:16 |
| tremble | If the service is gone, then the endpoint should be gone, so changed=False feels like the right behaviour to me... | 10:16 |
| noonedeadpunk | ok, thanks for the feedback :) I t felt right to me as well, but was not sure 100% so decided to ask as well | 10:18 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Do not fail when endpoint state is absent https://review.opendev.org/762798 | 11:48 |
| *** frenzy_friday has joined #openstack-ansible-sig | 12:17 | |
| *** redrobot has quit IRC | 15:35 | |
| *** Guest64097 has joined #openstack-ansible-sig | 15:51 | |
| *** Guest64097 is now known as redrobot | 15:53 | |
| *** gtema has quit IRC | 16:03 | |
| *** gtema has joined #openstack-ansible-sig | 16:03 | |
| *** gtema has quit IRC | 17:32 | |
| *** gtema has joined #openstack-ansible-sig | 18:04 | |
| *** gtema has quit IRC | 18:10 | |
| *** gtema has joined #openstack-ansible-sig | 19:23 | |
| *** gtema has quit IRC | 19:39 | |
| *** iurygregory has quit IRC | 20:40 | |
| *** iurygregory has joined #openstack-ansible-sig | 20:43 | |
| *** zeestrat has quit IRC | 21:12 | |
| *** zeestrat has joined #openstack-ansible-sig | 21:13 | |
| *** gtema has joined #openstack-ansible-sig | 21:40 | |
| *** gtema has quit IRC | 21:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!