| *** holser has joined #openstack-ansible-sig | 07:23 | |
| *** holser_ has joined #openstack-ansible-sig | 07:39 | |
| *** holser__ has joined #openstack-ansible-sig | 07:40 | |
| *** holser has quit IRC | 07:41 | |
| *** holser has joined #openstack-ansible-sig | 07:44 | |
| *** holser_ has quit IRC | 07:44 | |
| *** holser__ has quit IRC | 07:45 | |
| *** dtantsur|afk is now known as dtantsur | 08:05 | |
| dtantsur | sshnaidm: hey! do I recall it right that you have your own version of https://opendev.org/openstack/bifrost/src/branch/master/playbooks/library/os_ironic_node_info.py ? | 08:23 |
|---|---|---|
| dtantsur | now that we've migrated bifrost to the collection, we're looking for a home for it | 08:23 |
| sshnaidm | dtantsur, yep, https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/modules/os_baremetal_node_info.py | 08:24 |
| sshnaidm | dtantsur, you mean to remove info module form your collection? | 08:24 |
| *** gtema has joined #openstack-ansible-sig | 08:24 | |
| dtantsur | sshnaidm: sweeet, it looks a superset of what we have, except for the legacy ironic_url support | 08:24 |
| dtantsur | yeah, I want to get rid of the bifrost version | 08:25 |
| dtantsur | sshnaidm: I'd be really happy if you could propose your thing upstream | 08:26 |
| sshnaidm | dtantsur, yeah, was going to do this, but when you start to use it - need to check its output is compatible with your code | 08:26 |
| dtantsur | sshnaidm: well, we'll need to fix it to have a normal return instead of returning a fact | 08:28 |
| sshnaidm | dtantsur, like I return list "baremetal_nodes' and your module returns dict "node" | 08:28 |
| sshnaidm | dtantsur, yeah, facts is a deprecated way | 08:28 |
| dtantsur | ah, no, it's a normal return, just the docs are misleading | 08:28 |
| dtantsur | these small differences are fine, we'll anyway go through deprecation of the old module | 08:29 |
| dtantsur | we'll need to be able to optionally fetch 'nics', bifrost relies on it | 08:29 |
| dtantsur | sshnaidm: re 'baremetal_nodes' vs 'nodes', what's the standard approach in ansible? | 08:29 |
| sshnaidm | dtantsur, it depend on us how to name it, but because I do multiple nodes info, I need to return a list | 08:30 |
| sshnaidm | dtantsur, so I need to add call cloud.list_nics_for_machine for nics as I see | 08:31 |
| *** gtema has quit IRC | 08:32 | |
| dtantsur | sshnaidm: it seems that other info modules return openstack_<resource>, so openstack_baremetal_nodes in our case | 08:32 |
| dtantsur | you also need to make sure it's always a list, I guess? | 08:32 |
| sshnaidm | dtantsur, yeah, but I get list from sdk | 08:33 |
| sshnaidm | I think in any case | 08:33 |
| dtantsur | not for get_machine though? | 08:33 |
| sshnaidm | hmm.. good question | 08:35 |
| *** holser_ has joined #openstack-ansible-sig | 08:39 | |
| *** holser has quit IRC | 08:40 | |
| sshnaidm | dtantsur, seems like a list: https://github.com/openstack/openstacksdk/blob/7e2a51aefffdcb0913ff8254d25fb5216c02cb18/openstack/cloud/_normalize.py#L1168-L1173 | 08:40 |
| *** holser_ has quit IRC | 08:40 | |
| sshnaidm | dtantsur, oops, wrong function.. yeah, it's a dict | 08:41 |
| *** holser has joined #openstack-ansible-sig | 08:42 | |
| sshnaidm | not sure what is the best tbh, seems logical to return a dict when requesting info for one node and list when multiple nodes | 08:42 |
| sshnaidm | but it's not really compliant with ansible, it requires a specific type for all modules cases | 08:42 |
| dtantsur | sshnaidm: well, flavor_info always returns a list | 08:45 |
| dtantsur | I guess we could use this example | 08:46 |
| dtantsur | unless we want to have different modules for "get one node" and "get many nodes" | 08:46 |
| *** holser_ has joined #openstack-ansible-sig | 08:47 | |
| sshnaidm | dtantsur, yeah, I'll make it return a list always | 08:49 |
| sshnaidm | actually it's not so complex to make another module | 08:50 |
| dtantsur | yeah, I wonder what the ansible way is | 08:50 |
| *** holser has quit IRC | 08:50 | |
| *** holser_ has quit IRC | 08:52 | |
| sshnaidm | I saw very different ways in ansible modules, so not sure there is a "ansible way" at all | 08:54 |
| *** holser has joined #openstack-ansible-sig | 08:57 | |
| sshnaidm | I'd use baremetal_node module for return a dict for one node, then would make action plugin that runs multiple instances of baremetal_node for multople nodes and returns a list | 08:57 |
| *** holser has quit IRC | 09:01 | |
| *** holser has joined #openstack-ansible-sig | 09:02 | |
| sshnaidm | dtantsur, I think I'll move it as is and we can move on later, also about ironic url and auth there | 09:02 |
| dtantsur | sshnaidm: changing a dict to a list later would be a breaking change though. agree about everything else | 09:06 |
| sshnaidm | dtantsur, yeah, this I can change right now | 09:06 |
| sshnaidm | dtantsur, where is your bifrost collection hosted? | 09:07 |
| *** holser has quit IRC | 09:09 | |
| *** holser has joined #openstack-ansible-sig | 09:09 | |
| sshnaidm | I mean in which repo | 09:10 |
| dtantsur | sshnaidm: openstack/bifrost: https://opendev.org/openstack/bifrost/src/branch/master/playbooks/library/os_ironic_node_info.py | 09:16 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ansible-collections-openstack master: Add non-voting bifrost jobs https://review.opendev.org/743176 | 09:37 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ansible-collections-openstack master: DNM try breaking ironic https://review.opendev.org/743177 | 09:40 |
| sshnaidm | dtantsur, does symlinking work well? | 10:23 |
| dtantsur | sshnaidm: yep | 10:34 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ansible-collections-openstack master: Add non-voting bifrost jobs https://review.opendev.org/743176 | 10:47 |
| * tremble thanks sshnaidm for the merge on 740948 | 10:48 | |
| sshnaidm | tremble, you're welcome, we wait for another patches from you :) | 10:49 |
| sshnaidm | (and tests :D ) | 10:49 |
| * tremble has been trying to stabilize the Ansible AWS tests recently | 10:50 | |
| tremble | sshnaidm, Don't know how you'd want to deal with the workflow on https://storyboard.openstack.org/#!/story/2007922 | 10:55 |
| sshnaidm | tremble, it's "merged" now | 10:57 |
| sshnaidm | https://storyboard.openstack.org/#!/project/openstack/ansible-collections-openstack | 10:57 |
| sshnaidm | in "merged" tab | 10:57 |
| sshnaidm | btw, I made a dashboard to track the project, so we don't miss anything: http://dashboard-ci.tripleo.org/d/ilRDx9nMk/openstack-ansible-collections?orgId=1 | 10:59 |
| tremble | Nice :) | 10:59 |
| *** iurygregory has quit IRC | 10:59 | |
| sshnaidm | need to show only active issues there.. | 11:00 |
| sshnaidm | and will add a bot to post here new issues.. | 11:00 |
| *** iurygregory has joined #openstack-ansible-sig | 11:01 | |
| * tremble goes back to lurking and watching paint dry^W^W his lab cluster rebuild. | 11:01 | |
| *** evrardjp has quit IRC | 12:32 | |
| *** evrardjp has joined #openstack-ansible-sig | 12:32 | |
| *** evrardjp has quit IRC | 12:32 | |
| *** evrardjp has joined #openstack-ansible-sig | 12:33 | |
| *** dtantsur is now known as dtantsur|brb | 13:22 | |
| sshnaidm | dtantsur|brb, can we talk about testing ironic modules in CI in your time? | 13:46 |
| sshnaidm | I'm barely familiar with ironic CI, need to know more | 13:46 |
| *** dtantsur|brb is now known as dtantsur | 15:06 | |
| dtantsur | sshnaidm: yep | 15:07 |
| *** dtantsur is now known as dtantsur|afk | 16:59 | |
| *** evrardjp has quit IRC | 18:21 | |
| *** evrardjp has joined #openstack-ansible-sig | 18:24 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Add non-voting bifrost jobs https://review.opendev.org/743176 | 18:34 |
| *** holser has quit IRC | 23:30 | |
| *** holser has joined #openstack-ansible-sig | 23:34 | |
| *** spatel has joined #openstack-ansible-sig | 23:46 | |
| *** spatel has quit IRC | 23:50 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!