*** spatel has joined #openstack-ansible-sig | 00:33 | |
*** holser_ has joined #openstack-ansible-sig | 01:03 | |
*** holser has quit IRC | 01:05 | |
*** ysandeep is now known as ysandeep|away | 02:03 | |
*** ysandeep|away is now known as ysandeep | 04:17 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-ansible-sig | 04:33 | |
*** spatel has quit IRC | 05:23 | |
*** gtema has joined #openstack-ansible-sig | 06:08 | |
*** spatel has joined #openstack-ansible-sig | 06:15 | |
*** spatel has quit IRC | 06:19 | |
*** rpittau|afk is now known as rpittau | 06:57 | |
*** dtantsur|afk is now known as dtantsur | 07:41 | |
*** priteau has joined #openstack-ansible-sig | 08:45 | |
*** ysandeep is now known as ysandeep|lunch | 08:46 | |
*** gshippey has joined #openstack-ansible-sig | 09:30 | |
sshnaidm | folks, please review/merge https://review.opendev.org/#/c/721746/ | 09:33 |
---|---|---|
sshnaidm | dtantsur, gtema odyssey4me ^^ | 09:42 |
odyssey4me | sshnaidm: looking | 09:43 |
odyssey4me | sshnaidm: just one question there | 09:49 |
sshnaidm | odyssey4me, replied | 09:52 |
sshnaidm | actually I had to remove "version_added" from other modules as well, because ansible-test saw it as errors | 09:53 |
odyssey4me | sshnaidm: in a collection context I guess it doesn't make sense any more - we might have to implement our own docs plugin for something like that to indicate which collection version something was added in | 09:54 |
odyssey4me | anyway, nice to see tests getting added and better uniformity with the base class being used | 09:55 |
sshnaidm | odyssey4me, thanks! | 09:57 |
*** gtema has quit IRC | 09:57 | |
*** gtema has joined #openstack-ansible-sig | 09:58 | |
*** baptistemm has joined #openstack-ansible-sig | 10:02 | |
baptistemm | Hello, looking the openstack modules I cannot find a module to gather all volumes (something like os_volume_info), is it just that no one developped it, or there is no use for it ? | 10:03 |
baptistemm | for instance I want to find all volumes unattached. | 10:03 |
baptistemm | I'm not openstack admim, I've been granted a project so I can automate labs lifecylecc | 10:04 |
*** ysandeep|lunch is now known as ysandeep | 10:05 | |
baptistemm | jrosser: sshnaidm: so you told me there is such module, but just wanted to know why. | 10:05 |
sshnaidm | baptistemm, I think because nobody wrote it yet..? :) | 10:06 |
baptistemm | ok | 10:06 |
baptistemm | but it would make sense | 10:06 |
*** dmellado has quit IRC | 10:18 | |
*** rpittau is now known as rpittau|bbl | 10:34 | |
*** dmellado has joined #openstack-ansible-sig | 10:41 | |
*** gtema has quit IRC | 10:43 | |
*** sshnaidm is now known as sshnaidm|afk | 10:45 | |
*** gtema has joined #openstack-ansible-sig | 10:57 | |
*** sshnaidm|afk is now known as sshnaidm | 11:40 | |
*** priteau has quit IRC | 11:47 | |
*** gtema has quit IRC | 11:48 | |
*** gtema has joined #openstack-ansible-sig | 11:48 | |
baptistemm | as I'm here, it seems there is a bug in os_server module, deleting a node does not trigger a change | 12:08 |
*** spatel has joined #openstack-ansible-sig | 12:25 | |
*** rpittau|bbl is now known as rpittau | 12:28 | |
*** spatel has quit IRC | 12:30 | |
*** ysandeep is now known as ysandeep|afk | 12:51 | |
*** gtema has quit IRC | 12:58 | |
*** spatel has joined #openstack-ansible-sig | 13:01 | |
*** spatel has quit IRC | 13:04 | |
*** gtema has joined #openstack-ansible-sig | 13:22 | |
*** ysandeep|afk is now known as ysandeep | 13:27 | |
*** gtema has quit IRC | 13:32 | |
*** gtema has joined #openstack-ansible-sig | 13:54 | |
*** dmellado_ has joined #openstack-ansible-sig | 14:12 | |
*** mnaser has quit IRC | 14:14 | |
*** zbr_ has joined #openstack-ansible-sig | 14:14 | |
*** dmellado has quit IRC | 14:16 | |
*** zbr has quit IRC | 14:16 | |
*** dmellado_ is now known as dmellado | 14:16 | |
*** zbr_ is now known as zbr | 14:16 | |
*** mnaser has joined #openstack-ansible-sig | 14:16 | |
*** holser_ has quit IRC | 14:18 | |
*** holser has joined #openstack-ansible-sig | 14:22 | |
baptistemm | I wanted to open a issue on https://storyboard.openstack.org but using ubuntuone for login... | 15:35 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949 | 15:46 |
sshnaidm | baptistemm, ^ | 15:46 |
sshnaidm | baptistemm, if you have trouble with ubuntu login, just open the issue in github and paste here, we'll copy it to storyboard | 15:46 |
*** ysandeep is now known as ysandeep|brb | 15:51 | |
*** gtema_ has joined #openstack-ansible-sig | 15:58 | |
*** gtema has quit IRC | 16:01 | |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | 16:05 |
*** rpittau is now known as rpittau|afk | 16:12 | |
*** dtantsur is now known as dtantsur|afk | 16:14 | |
*** gtema_ has quit IRC | 16:14 | |
*** ysandeep|brb is now known as ysandeep | 16:23 | |
baptistemm | sshnaidm: I've actually an account :) but that's not the most usual id provider | 16:28 |
sshnaidm | baptistemm, yeah, login via github is in progress | 16:29 |
sshnaidm | hope we'll have it soon | 16:29 |
mordred | baptistemm: hysterical raisins - we're actually working on an SSO system update | 16:29 |
baptistemm | hysterical ? | 16:29 |
baptistemm | :) | 16:29 |
mordred | (historical reasons -> hysterical raisins) | 16:30 |
baptistemm | got it | 16:30 |
*** ysandeep is now known as ysandeep|away | 16:30 | |
baptistemm | sshnaidm: wow you wrote the volume_info module yet ? | 16:30 |
sshnaidm | baptistemm, yep, it's easy now: https://github.com/openstack/ansible-collections-openstack/blob/master/contrib/generate_module.sh#L5 | 16:31 |
baptistemm | ah so this is not compatible with the 2.8 openstack module ? | 16:31 |
sshnaidm | baptistemm, it's only in collection, you can install it and use with ansible 2.8 | 16:32 |
baptistemm | ho great | 16:32 |
sshnaidm | ansible-galaxy collection install openstack.cloud | 16:32 |
sshnaidm | and then: openstack.cloud.volume_info: ... | 16:32 |
sshnaidm | baptistemm, after it will be merged and release, of course :) | 16:32 |
sshnaidm | or just take it from a patch and copy to your collection folder | 16:33 |
baptistemm | ok | 16:35 |
baptistemm | thanks you | 16:36 |
-openstackstatus- NOTICE: Zuul is being restarted for an urgent configuration change and may be offline for 15-30 minutes. Patches uploaded or approved during that time will need to be rechecked. | 16:37 | |
sshnaidm | mordred, seems like pip 2.7 is not installed in tox jobs anymore.. | 16:38 |
sshnaidm | :( | 16:39 |
mordred | sshnaidm: that is right - we don't pre-install pip or virtualenv anymore - because the situation is an acutal nightmare. the tox jobs run ensure-tox which runs ensure-pip which will install pip3 on recent nodes | 16:39 |
sshnaidm | mordred, is it possible to install pip2 as well? | 16:40 |
mordred | but also - why is ansible-test trying to do something with python2.7? | 16:40 |
sshnaidm | mordred, because it can! :D | 16:40 |
mordred | sshnaidm: I'd prefer if we got ansible-test to not be stupid here - we do not support ptyhon2 | 16:40 |
mordred | but we don't support it | 16:40 |
mordred | liek - at all | 16:40 |
mordred | zero support | 16:41 |
mordred | we should not be running python2 anything on this repo | 16:41 |
mordred | for any reason | 16:41 |
sshnaidm | yeah, it tries to test with everything it finds, and apparently there is still python2 in this jobs available | 16:41 |
sshnaidm | ok, will try to limit it to one python version | 16:41 |
mordred | yeah- this is where I really wish ansible-test and tox didn't fight | 16:41 |
mordred | running ansible-test in a tox environment and having it do somethign with a different version of python is very unexpected | 16:42 |
mordred | but - shrug | 16:42 |
mordred | I do unexpected things all the time :) | 16:42 |
sshnaidm | mordred, what is the default python in jobs now? 3.6? | 16:44 |
sshnaidm | or 3.7 | 16:44 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949 | 16:50 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968 | 16:55 |
baptistemm | sshnaidm: does the new volumes depends on a minimal openstacksdk version ? | 16:56 |
mordred | sshnaidm: 3.6 is the min | 16:57 |
sshnaidm | baptistemm, no, should work with all from rocky for sure | 16:58 |
baptistemm | I drop the patch in the openstack collection and did a test and I got this error: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: UnboundLocalError: local variable 'result' referenced before assignment | 16:59 |
baptistemm | sorry, rather AttributeError: 'VolumeInfoModule' object has no attribute 'results | 17:00 |
sshnaidm | baptistemm, I think you need to take a new file too: https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/module_utils/openstack.py | 17:03 |
sshnaidm | baptistemm, drop it in module_utils in collection | 17:04 |
sshnaidm | we didn't release with it yet | 17:04 |
baptistemm | ok thanks | 17:06 |
baptistemm | great that's working | 17:08 |
sshnaidm | cool | 17:12 |
baptistemm | 🙏🏻🙏🏻 | 17:16 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977 | 17:27 |
*** holser has quit IRC | 17:46 | |
*** holser has joined #openstack-ansible-sig | 17:47 | |
jrosser | baptistemm: this is sooooo much better than having to wait for a new ansible release, or an ansible PR to ever get merged :) | 17:53 |
-openstackstatus- NOTICE: Zuul is back online; changes uploaded or approved between 16:40 and 18:00 will need to be rechecked. | 18:06 | |
*** holser has quit IRC | 18:07 | |
*** holser has joined #openstack-ansible-sig | 18:07 | |
*** iurygregory has quit IRC | 18:33 | |
baptistemm | jrosser: lookig for the new openstack release to have the reviewed fix | 19:50 |
baptistemm | I doubted how the split of ansible into sets of collections could improve the situation, at least developers seems happy | 19:51 |
baptistemm | at least | 19:51 |
*** iurygregory has joined #openstack-ansible-sig | 19:59 | |
mordred | sshnaidm: I haz questions on https://review.opendev.org/735968 ... | 20:59 |
mordred | sshnaidm: is the author: field required? if so - do we have to reference a github id? it's actually completely reasonable that a human can contribute to openstack without a github id. but to the first point - we don't really tend to have individual ownership around here, as opposed to team/group ownership | 21:00 |
mordred | sshnaidm: so I'd love if we could just omit that - and in fact remove the author: line from all of our modules | 21:00 |
sshnaidm | mordred, I think we can add like "Openstack Team" as an author | 21:04 |
sshnaidm | mordred, ansible-test objects if we omit: "invalid-documentation: DOCUMENTATION.author: required key not provided @ data['author']. Got None" | 21:06 |
mordred | sshnaidm: ok. so we do need author | 21:08 |
mordred | sshnaidm: let's change it to "OpenStack Ansible SIG https://wiki.openstack.org/wiki/Ansible_SIG" :) | 21:08 |
mordred | (I think that's the best url for the sig I can find) | 21:08 |
sshnaidm | mordred, we can do "Openstack Team (@openstack)", github nickname is still required :) | 21:13 |
sshnaidm | urls will break test I think | 21:13 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968 | 21:19 |
sshnaidm | mordred, ^ | 21:19 |
*** holser has quit IRC | 21:24 | |
sshnaidm | mordred, ansible-test wants to know what is exactly removal_date of os_* modules.. | 21:26 |
sshnaidm | let's say 1 year..? | 21:26 |
mordred | sshnaidm: ansible-test is nosy | 21:34 |
mordred | sshnaidm: I'm going to submit a patch to ansible-test to remove the requirement for the github nickname | 21:34 |
sshnaidm | https://github.com/ansible/ansible/blob/fc448ea54f1595e8d24e72abd9b5245ec6165842/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/schema.py#L29 | 21:35 |
sshnaidm | we can use that, but it's very ugly in docs | 21:35 |
mordred | I'm gonna try something | 21:36 |
mordred | sshnaidm: https://github.com/ansible/ansible/pull/70105 | 21:41 |
mordred | let's see where that goes - I'm willing to tilt at a windmill here for a bit | 21:41 |
mordred | sshnaidm: \o/ | 21:48 |
sshnaidm | mordred, ++ | 21:56 |
*** dtantsur|afk has quit IRC | 22:04 | |
*** tobberydberg has quit IRC | 22:08 | |
*** tobberydberg has joined #openstack-ansible-sig | 22:09 | |
*** dtantsur has joined #openstack-ansible-sig | 22:12 | |
*** dtantsur has quit IRC | 22:18 | |
*** dtantsur has joined #openstack-ansible-sig | 22:18 | |
*** gshippey has quit IRC | 22:31 | |
*** holser has joined #openstack-ansible-sig | 22:31 | |
*** iurygregory has quit IRC | 22:33 | |
*** dmsimard has quit IRC | 22:33 | |
*** ysandeep|away has quit IRC | 22:33 | |
*** mwhahaha has quit IRC | 22:33 | |
*** owalsh has quit IRC | 22:33 | |
*** mnaser has quit IRC | 22:33 | |
*** holser has quit IRC | 22:33 | |
*** dmellado has quit IRC | 22:33 | |
*** redrobot has quit IRC | 22:33 | |
*** logan- has quit IRC | 22:33 | |
*** EmilienM has quit IRC | 22:33 | |
*** johanssone has quit IRC | 22:33 | |
*** tobberydberg has quit IRC | 22:33 | |
*** gundalow has quit IRC | 22:33 | |
*** ChanServ has quit IRC | 22:33 | |
*** odyssey4me has quit IRC | 22:33 | |
*** sshnaidm has quit IRC | 22:33 | |
*** openstackgerrit has quit IRC | 22:33 | |
*** dtantsur has quit IRC | 22:33 | |
*** zbr has quit IRC | 22:33 | |
*** evrardjp has quit IRC | 22:33 | |
*** jrosser has quit IRC | 22:33 | |
*** noonedeadpunk has quit IRC | 22:33 | |
*** rpittau|afk has quit IRC | 22:33 | |
*** cyberpear has quit IRC | 22:33 | |
*** mordred has quit IRC | 22:33 | |
*** trident has quit IRC | 22:33 | |
*** baptistemm has quit IRC | 22:33 | |
*** ysandeep|away has joined #openstack-ansible-sig | 22:37 | |
*** redrobot has joined #openstack-ansible-sig | 22:37 | |
*** dmellado has joined #openstack-ansible-sig | 22:37 | |
*** holser has joined #openstack-ansible-sig | 22:37 | |
*** mwhahaha has joined #openstack-ansible-sig | 22:37 | |
*** johanssone has joined #openstack-ansible-sig | 22:37 | |
*** EmilienM has joined #openstack-ansible-sig | 22:37 | |
*** mordred has joined #openstack-ansible-sig | 22:37 | |
*** cyberpear has joined #openstack-ansible-sig | 22:37 | |
*** rpittau|afk has joined #openstack-ansible-sig | 22:37 | |
*** noonedeadpunk has joined #openstack-ansible-sig | 22:37 | |
*** jrosser has joined #openstack-ansible-sig | 22:37 | |
*** evrardjp has joined #openstack-ansible-sig | 22:37 | |
*** zbr has joined #openstack-ansible-sig | 22:37 | |
*** dtantsur has joined #openstack-ansible-sig | 22:37 | |
*** logan- has joined #openstack-ansible-sig | 22:37 | |
*** owalsh has joined #openstack-ansible-sig | 22:37 | |
*** trident has joined #openstack-ansible-sig | 22:37 | |
*** baptistemm has joined #openstack-ansible-sig | 22:37 | |
*** ChanServ has joined #openstack-ansible-sig | 22:37 | |
*** dmsimard has joined #openstack-ansible-sig | 22:37 | |
*** tepper.freenode.net sets mode: +o ChanServ | 22:37 | |
*** iurygregory has joined #openstack-ansible-sig | 22:37 | |
*** sshnaidm has joined #openstack-ansible-sig | 22:38 | |
*** openstackgerrit has joined #openstack-ansible-sig | 22:38 | |
*** cyberpear has quit IRC | 22:38 | |
*** odyssey4me has joined #openstack-ansible-sig | 22:38 | |
*** tobberydberg has joined #openstack-ansible-sig | 22:38 | |
*** gundalow has joined #openstack-ansible-sig | 22:38 | |
*** mnaser has joined #openstack-ansible-sig | 22:39 | |
*** holser has quit IRC | 22:39 | |
*** mwhahaha has quit IRC | 22:39 | |
*** jrosser has quit IRC | 22:40 | |
*** gundalow has quit IRC | 22:41 | |
*** mnaser has quit IRC | 22:41 | |
*** mwhahaha has joined #openstack-ansible-sig | 22:43 | |
*** gundalow has joined #openstack-ansible-sig | 22:43 | |
*** jrosser has joined #openstack-ansible-sig | 22:43 | |
*** holser has joined #openstack-ansible-sig | 22:44 | |
*** cyberpear has joined #openstack-ansible-sig | 22:47 | |
*** mnaser has joined #openstack-ansible-sig | 22:48 | |
*** cyberpear has quit IRC | 22:49 | |
*** cyberpear has joined #openstack-ansible-sig | 22:49 | |
sshnaidm | ci/run-ansible-tests-collection.sh: line 101: tox: command not found | 22:59 |
sshnaidm | mordred, tox is not included as well in tox jobs? | 23:00 |
sshnaidm | for some reason it's only for branchful jobs | 23:04 |
mordred | sshnaidm: we might need to add ensure-tox role -- but I think I've seen sdk functional tests pass today - so I'm not sure what's wrong there | 23:07 |
sshnaidm | master job pass.. | 23:10 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add tox to requirements https://review.opendev.org/736062 | 23:12 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: DNM test jobs https://review.opendev.org/732100 | 23:13 |
mordred | sshnaidm: oh - are all of those things using devstack from a stable branch? | 23:20 |
sshnaidm | mordred, yes | 23:21 |
mordred | there's some issues with devstack on stable branches atm | 23:21 |
sshnaidm | mordred, devstack installs finally, but job fails when trying "tox -ebuild" for building collection | 23:22 |
mordred | yeah | 23:22 |
mordred | so - base images in opendev changed and tox, pip and virtualenv are no longer installed by default | 23:22 |
mordred | jobs need to add the ensure-tox role in a pre playbook if they need them | 23:22 |
mordred | so somewhere in our chain we're likely missing that | 23:23 |
mordred | sshnaidm: clarkb confirms there are fixes up for devstack that have died in the gate for other reasons ... so there may just be a thing we need to untangle that's related to all of this | 23:23 |
sshnaidm | mordred, ack, then I'll let it fix itself :) | 23:24 |
mordred | sshnaidm: we may still have to do something - but we should likely let the dust settle before we dig _too_ much :) | 23:24 |
*** spatel has joined #openstack-ansible-sig | 23:52 | |
*** spatel has quit IRC | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!