| *** spatel has joined #openstack-ansible-sig | 01:28 | |
| *** spatel has quit IRC | 01:32 | |
| *** spatel has joined #openstack-ansible-sig | 03:02 | |
| *** spatel has quit IRC | 03:13 | |
| *** evrardjp has quit IRC | 05:35 | |
| *** evrardjp has joined #openstack-ansible-sig | 05:36 | |
| *** gtema has joined #openstack-ansible-sig | 07:30 | |
| *** gtema has quit IRC | 07:46 | |
| *** openstackgerrit has joined #openstack-ansible-sig | 11:50 | |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: os_nova_host_aggregate: Fixup sanity test failures https://review.opendev.org/712917 | 11:50 |
|---|---|---|
| gundalow | hum, there appear to be a load of OpenStack modules left in `community.general` https://github.com/ansible-collections/community.general/tree/master/plugins/modules/cloud/openstack | 14:09 |
| gundalow | Are they all in the OpenStack collection? | 14:09 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Remove MANIFEST.json before building https://review.opendev.org/712970 | 15:15 |
| mordred | gundalow: looking | 15:25 |
| mordred | gundalow: nope! looks like all of the facts and info modules | 15:26 |
| mordred | gundalow: let me suck them over real quick | 15:26 |
| mordred | gundalow: and thanks! | 15:29 |
| gundalow | woot, thanks | 15:31 |
| gundalow | mordred: Can you please raise a PR to update BOTMETA & routing,.yml in ansible/ansible as well so the collection name is correct | 15:32 |
| mordred | gundalow: yes indeed | 15:34 |
| gundalow | Thank you :) | 15:35 |
| mordred | gundalow: I don't see a routing.yml in ansible/ansible | 15:36 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: os_nova_host_aggregate: Add support for not 'purging' missing hosts https://review.opendev.org/712979 | 15:37 |
| *** tremble has joined #openstack-ansible-sig | 15:39 | |
| tremble | Is there an interest in a batch of sanity test cleanup PRs? If so would you prefer them as a handful of big PRs or ~60 little PRs? | 15:42 |
| mordred | gundalow: https://github.com/ansible/ansible/pull/68215 | 15:43 |
| gundalow | mordred: oh temp-2.10-devel branch | 15:43 |
| mordred | tremble: handful of big is probably fine - what sort of cleanups? | 15:43 |
| mordred | gundalow: ah - should I be submitting that there instead? | 15:43 |
| tremble | mordred, Mostly cleaning out tests/sanity/ignore-2.10.txt and tests/sanity/ignore-2.9.txt | 15:44 |
| gundalow | mordred: yup, (sorry, we are in a strange place till the end of the month) .If you click `edit` on the top of GitHub PR you can change the destination branch | 15:44 |
| tremble | mordred, So ensuring the docs are complete, adding the boilerplate, things like that | 15:45 |
| mordred | yeah. sounds great - but don't add the metaclass of from future boilerplate | 15:45 |
| mordred | we just deleted all of that :) | 15:46 |
| * tremble laughs | 15:46 | |
| tremble | ok | 15:46 |
| tremble | Why? | 15:46 |
| mordred | we're python3 only - it's useless noise | 15:46 |
| tremble | Ah ok | 15:46 |
| mordred | but - otherwise - yes, that sounds great! | 15:47 |
| mordred | gundalow: those missing modules were symlinks | 15:47 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: os_nova_host_aggregate: Fixup sanity test failures https://review.opendev.org/712917 | 15:49 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: os_nova_host_aggregate: Add support for not 'purging' missing hosts https://review.opendev.org/712979 | 15:49 |
| * tremble re-removes that boilerplate :) | 15:50 | |
| gundalow | mordred: ah, OK | 15:52 |
| mordred | gundalow: so - I assume collections support _ prefixed symlinks for backwards compat still? | 15:54 |
| mordred | gundalow: I fixed https://github.com/ansible/ansible/pull/68215 to do what I think would be the right thing - since those were backwards compat symlinks, I made routing point them to the new link target - does that make sense? | 16:02 |
| gundalow | mordred: yup, pointing to $new_name is good | 16:04 |
| mordred | cool | 16:04 |
| mordred | gundalow: also - do we have any clarity yet on whether that routing file means I could rename things in the collection, update the routing file and have ACD work "right" ? | 16:05 |
| gundalow | mordred: to answer your first question, nop `_` will not be used by Collections. A different method of deprecation will be implemented in https://github.com/ansible/ansible/pull/67684 if you want to know more about that ask sivel in #ansible-devel | 16:06 |
| gundalow | This page talks about moving content between collections https://github.com/ansible-collections/overview/blob/master/README.rst#q-what-should-i-do-to-move-plugins-across-collections-during-migration | 16:06 |
| mordred | gundalow: ah cool! (to first thing) | 16:06 |
| mordred | gundalow: ok. so it seems like routing.yml is going to be the source of truth for redirecting old names to new names | 16:07 |
| mordred | based on that | 16:07 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Add option for modules_default groups https://review.opendev.org/712057 | 16:19 |
| *** openstackgerrit has quit IRC | 16:31 | |
| gundalow | mordred: correct routing.yml is source of truth | 16:40 |
| mordred | gundalow: cool. I'm gonna make a big rename patch then | 16:42 |
| mordred | tremble: how much will is break your cleanups if I do a giant rename patch? should I wait for more patches from you? | 16:42 |
| tremble | mordred, I've not started yet, so go for it | 16:44 |
| tremble | mordred, it'll be an evening-while-i-watch-something effort | 16:45 |
| tremble | But may be there on Monday | 16:46 |
| mordred | cool. I can get mine done real quick | 16:50 |
| *** openstackgerrit has joined #openstack-ansible-sig | 17:14 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Remove MANIFEST.json before building https://review.opendev.org/712970 | 17:14 |
| *** evrardjp has quit IRC | 17:35 | |
| *** evrardjp has joined #openstack-ansible-sig | 17:36 | |
| *** sshnaidm|afk has quit IRC | 17:37 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: os_nova_host_aggregate: Fixup sanity test failures https://review.opendev.org/712917 | 17:37 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: os_nova_host_aggregate: Add support for not 'purging' missing hosts https://review.opendev.org/712979 | 17:43 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056 | 19:51 |
| mordred | mnaser: ^^ | 21:52 |
| * mnaser click | 21:52 | |
| mnaser | mordred: i like how you even went as far out as renaming files | 21:53 |
| mnaser | :P | 21:53 |
| mordred | mnaser: I go all the way | 21:54 |
| mnaser | wonder why it's failing with `os-client-config is required for this module` | 21:55 |
| mnaser | OH | 21:56 |
| mnaser | mordred: https://review.opendev.org/#/c/713056/1/plugins/modules/client_config.py you really did go all the way | 21:56 |
| mordred | mnaser: whoops! | 22:01 |
| mordred | mnaser: well - we should fix that ... it should be importing from openstack.config anyway | 22:01 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056 | 22:05 |
| mordred | mnaser: that should do the trick | 22:05 |
| mnaser | mordred: ya seems reasonable | 22:06 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!