*** sergmelikyan has joined #murano | 00:00 | |
*** ducttape_ has quit IRC | 00:01 | |
*** sergmelikyan has quit IRC | 00:04 | |
*** ducttape_ has joined #murano | 00:32 | |
*** sergmelikyan has joined #murano | 00:43 | |
*** sergmelikyan has quit IRC | 01:04 | |
*** ducttape_ has quit IRC | 01:10 | |
*** ducttape_ has joined #murano | 01:11 | |
*** ducttape_ has quit IRC | 01:15 | |
*** ducttape_ has joined #murano | 01:37 | |
*** ducttape_ has quit IRC | 01:56 | |
*** ducttape_ has joined #murano | 01:57 | |
*** ducttape_ has quit IRC | 02:17 | |
*** Zer0Byte__ has quit IRC | 02:20 | |
*** pooja has quit IRC | 02:46 | |
*** sergmelikyan has joined #murano | 02:49 | |
*** kzaitsev_mb has joined #murano | 02:51 | |
*** sergmelikyan has quit IRC | 02:54 | |
*** ducttape_ has joined #murano | 03:18 | |
*** ducttape_ has quit IRC | 03:23 | |
*** yamamot__ has joined #murano | 03:40 | |
*** kzaitsev_mb has quit IRC | 03:43 | |
*** sergmelikyan has joined #murano | 03:48 | |
*** sergmelikyan has quit IRC | 03:53 | |
*** sergmelikyan has joined #murano | 03:53 | |
*** sergmelikyan has quit IRC | 03:54 | |
*** fragatina has joined #murano | 03:56 | |
*** kzaitsev_mb has joined #murano | 04:19 | |
*** kzaitsev_mb has quit IRC | 04:24 | |
*** ducttape_ has joined #murano | 04:49 | |
*** ducttape_ has quit IRC | 04:53 | |
*** kzaitsev_mb has joined #murano | 05:21 | |
*** zhurong_phone has joined #murano | 06:06 | |
*** kzaitsev_mb has quit IRC | 06:10 | |
*** ducttape_ has joined #murano | 06:19 | |
*** ducttape_ has quit IRC | 06:24 | |
*** Serlex has joined #murano | 06:28 | |
openstackgerrit | Stan Lagun proposed openstack/murano: Developing Murano Packages 101 https://review.openstack.org/381983 | 06:57 |
---|---|---|
*** kzaitsev_mb has joined #murano | 07:05 | |
*** openstackgerrit has quit IRC | 07:48 | |
*** ducttape_ has joined #murano | 07:50 | |
*** ducttape_ has quit IRC | 07:54 | |
*** zhurong_phone has quit IRC | 08:19 | |
*** openstackgerrit has joined #murano | 08:45 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/murano-dashboard: Imported Translations from Zanata https://review.openstack.org/413510 | 08:45 |
*** ducttape_ has joined #murano | 08:50 | |
*** ducttape_ has quit IRC | 08:55 | |
*** StanLagun has quit IRC | 08:55 | |
*** zhurong_phone has joined #murano | 08:57 | |
*** StanLagun has joined #murano | 08:57 | |
*** ducttape_ has joined #murano | 09:00 | |
*** ducttape_ has quit IRC | 09:05 | |
*** kzaitsev_mb has quit IRC | 09:07 | |
*** kzaitsev_mb has joined #murano | 09:49 | |
*** ducttape_ has joined #murano | 10:02 | |
*** StanLagun has quit IRC | 10:05 | |
*** ducttape_ has quit IRC | 10:07 | |
*** zhurong_phone has quit IRC | 10:59 | |
*** ducttape_ has joined #murano | 11:02 | |
*** ducttape_ has quit IRC | 11:07 | |
openstackgerrit | Merged openstack/python-muranoclient: Fix Murano client to use V3 and MultiDomain Authentication https://review.openstack.org/412790 | 11:19 |
*** ducttape_ has joined #murano | 12:03 | |
*** ducttape_ has quit IRC | 12:08 | |
*** Zer0Byte__ has joined #murano | 12:21 | |
*** kzaitsev_mb has quit IRC | 12:32 | |
*** zimboboyd has joined #murano | 12:44 | |
Zer0Byte__ | someone alive | 12:48 |
Zer0Byte__ | ? | 12:48 |
*** ducttape_ has joined #murano | 13:04 | |
*** ducttape_ has quit IRC | 13:06 | |
*** ducttape_ has joined #murano | 13:06 | |
*** ducttape_ has quit IRC | 13:07 | |
*** sergmelikyan has joined #murano | 13:13 | |
*** sergmelikyan has quit IRC | 13:18 | |
*** kzaitsev_mb has joined #murano | 13:20 | |
*** sergmelikyan has joined #murano | 13:22 | |
*** ducttape_ has joined #murano | 13:23 | |
*** cleong has joined #murano | 13:33 | |
*** ducttape_ has quit IRC | 13:51 | |
*** caowei has joined #murano | 13:55 | |
*** Zer0Byte__ has quit IRC | 14:02 | |
*** Zer0Byte__ has joined #murano | 14:24 | |
openstackgerrit | Merged openstack/murano-dashboard: Imported Translations from Zanata https://review.openstack.org/413510 | 14:41 |
*** caowei has quit IRC | 14:57 | |
Zer0Byte__ | kzaitsev_mb heey | 15:05 |
Zer0Byte__ | how are you | 15:05 |
*** yamamot__ has quit IRC | 15:23 | |
*** yamamoto has joined #murano | 15:41 | |
*** felipemonteiro has joined #murano | 15:42 | |
*** openstackgerrit_ has joined #murano | 15:47 | |
*** openstackgerrit_ has quit IRC | 15:49 | |
openstackgerrit | Samantha Blanco proposed openstack/murano: Update response codes in API spec https://review.openstack.org/413694 | 15:53 |
*** StanLagun has joined #murano | 15:55 | |
*** fragatina has quit IRC | 15:57 | |
*** fragatina has joined #murano | 15:57 | |
openstackgerrit | Jose Phillips proposed openstack/python-muranoclient: Return error code when a error occurred during package-import https://review.openstack.org/413702 | 16:14 |
openstackgerrit | Felipe Monteiro proposed openstack/murano: Fixes TypeError thrown by parallel_select in DSL Helpers. https://review.openstack.org/413703 | 16:14 |
*** Zer0Byt__ has joined #murano | 16:17 | |
*** Zer0Byt__ has quit IRC | 16:18 | |
*** Zer0Byte__ has quit IRC | 16:19 | |
*** ducttape_ has joined #murano | 16:23 | |
*** ducttape_ has quit IRC | 16:27 | |
*** kzaitsev_mb has quit IRC | 16:40 | |
*** yamamoto has quit IRC | 16:41 | |
*** openstackstatus has joined #murano | 16:59 | |
*** ChanServ sets mode: +v openstackstatus | 16:59 | |
*** sergmelikyan has quit IRC | 16:59 | |
*** sergmelikyan has joined #murano | 16:59 | |
*** sergmeli_ has joined #murano | 17:00 | |
-openstackstatus- NOTICE: Gerrit is restarting to address performance issues | 17:02 | |
*** openstackstatus has quit IRC | 17:02 | |
*** openstack has quit IRC | 17:02 | |
*** openstack has joined #murano | 17:03 | |
*** openstackstatus has joined #murano | 17:03 | |
*** ChanServ sets mode: +v openstackstatus | 17:03 | |
*** sergmelikyan has quit IRC | 17:04 | |
*** Zer0Byte__ has joined #murano | 17:10 | |
*** yamamoto has joined #murano | 17:12 | |
*** yamamoto has quit IRC | 17:21 | |
*** ducttape_ has joined #murano | 17:23 | |
*** ducttape_ has quit IRC | 17:36 | |
*** kzaitsev_mb has joined #murano | 17:39 | |
*** ducttape_ has joined #murano | 17:44 | |
Zer0Byte__ | StanLagun | 17:45 |
Zer0Byte__ | hey | 17:45 |
Zer0Byte__ | morning | 17:45 |
*** sergmeli_ has quit IRC | 17:50 | |
*** sergmelikyan has joined #murano | 17:54 | |
*** sergmelikyan has quit IRC | 17:54 | |
*** ducttape_ has quit IRC | 17:57 | |
-openstackstatus- NOTICE: Gerrit is being restarted to update its OpenID SSO configuration | 17:57 | |
*** ducttape_ has joined #murano | 18:00 | |
*** kzaitsev_mb has quit IRC | 18:05 | |
*** ducttape_ has quit IRC | 18:18 | |
*** ducttape_ has joined #murano | 18:30 | |
*** bmace has joined #murano | 18:42 | |
openstackgerrit | Felipe Monteiro proposed openstack/murano: Increase unit test coverage for DSL Helpers. https://review.openstack.org/413268 | 18:43 |
*** fragatina has quit IRC | 18:51 | |
StanLagun | Zer0Byte__ hi | 18:58 |
*** ducttape_ has quit IRC | 19:00 | |
*** Serlex has left #murano | 19:00 | |
*** Serlex has quit IRC | 19:00 | |
*** DavidPurcell has joined #murano | 19:06 | |
felipemonteiro | According to very recent logs--http://logs.openstack.org/48/411448/1/check/gate-tempest-dsvm-murano-api-ubuntu-xenial/39eb075/--the gate check is still using out-of-date code to run the Tempest tests. | 19:26 |
*** ducttape_ has joined #murano | 19:35 | |
*** ducttape_ has quit IRC | 19:48 | |
*** ducttape_ has joined #murano | 19:52 | |
Zer0Byte__ | hi StanLagun sorry i was in lunch | 19:54 |
Zer0Byte__ | do you have 3 minutes of your time? | 19:54 |
StanLagun | sure | 19:57 |
Zer0Byte__ | i alrady do this commit | 19:57 |
Zer0Byte__ | https://review.openstack.org/#/c/413702/ | 19:57 |
Zer0Byte__ | already do | 19:57 |
Zer0Byte__ | the question is | 19:58 |
Zer0Byte__ | did you think is okay warn the user some package import failed after the imported_list | 19:58 |
Zer0Byte__ | or just leave the error up these imported_list | 19:59 |
*** yamamoto has joined #murano | 19:59 | |
StanLagun | All errors are printed at the moment the error happens. It's okay to print 'something went wrong' in the very end to remind of them. Also it is right to exit(1). But I don't see any reason to be more detailed since the right error messages should be printed already by that moment | 20:02 |
Zer0Byte__ | i leave these error | 20:03 |
Zer0Byte__ | because if you export 3 4 5 packages | 20:03 |
Zer0Byte__ | at the same time | 20:03 |
Zer0Byte__ | maybe you can see a long line with the package can imported succefully | 20:03 |
Zer0Byte__ | and dont see what happened up these lines | 20:03 |
*** yamamoto has quit IRC | 20:04 | |
Zer0Byte__ | i already fix the test so is just know if we need that or not | 20:05 |
StanLagun | I like your commit, except for the last change. I think, if there were any errors anywhere, you should print the reminder and exit(1), not raise the exception and do not check if the error was during import or somewhere else | 20:05 |
StanLagun | you should print something like 'Warning: there were some errors during the operation' | 20:06 |
Zer0Byte__ | ok | 20:06 |
Zer0Byte__ | well i change the message then :) and change raise to sys.exit(1) | 20:07 |
StanLagun | thanx! | 20:09 |
Zer0Byte__ | Btw exist any documentation for development in murano i mean like the error messages have a standard like "Warning" | 20:09 |
Zer0Byte__ | for don't ask any time i have a doubt | 20:09 |
Zer0Byte__ | or if exist a standard for each thing. | 20:09 |
StanLagun | there might be something like this for the whole OpenStack somewhere. No such docs in murano | 20:10 |
*** ducttape_ has quit IRC | 20:12 | |
felipemonteiro | StanLagun Does recheck run a given patchset against the latest upstream code? | 20:21 |
StanLagun | recheck runs the tests that are present in that very same git revision | 20:22 |
StanLagun | to use newer tests you should rebase your commit onto current master | 20:23 |
StanLagun | there is a "Rebase" button in gerrit that does it | 20:24 |
felipemonteiro | StanLagun: Yeah, I just wanted to confirm with you. Didn't want to wipe away 2 +2's without first confirming my suspicion. | 20:33 |
felipemonteiro | Thanks | 20:33 |
Zer0Byte__ | hi felipemonteiro | 20:38 |
felipemonteiro | Zer0Byte__ Hi | 20:38 |
Zer0Byte__ | talking about your comment | 20:38 |
Zer0Byte__ | https://review.openstack.org/#/c/413702/1/muranoclient/v1/shell.py | 20:38 |
Zer0Byte__ | i can use raise because this is a loop | 20:39 |
Zer0Byte__ | if i do raise i will stop the other packages to import if exists on quere | 20:39 |
Zer0Byte__ | queue | 20:39 |
felipemonteiro | I thought it was at the same level of indentation as the for loop, thus outside it. | 20:42 |
Zer0Byte__ | i already fix the test | 20:43 |
Zer0Byte__ | thas just fail when exist a error | 20:43 |
Zer0Byte__ | to import a package | 20:43 |
felipemonteiro | I see, then just re-commit, although I would probably capitalize your error message :) | 20:47 |
Zer0Byte__ | lol why felipemonteiro | 20:48 |
Zer0Byte__ | ? | 20:48 |
felipemonteiro | "some errors occurred during import" should be "Some errors..." | 20:49 |
Zer0Byte__ | oh well i already changed t | 20:49 |
Zer0Byte__ | Warning: there were some errors during the operation. | 20:49 |
Zer0Byte__ | like stan said | 20:49 |
felipemonteiro | Ok, it prefixes it with Warning, great. | 20:53 |
openstackgerrit | Felipe Monteiro proposed openstack/murano: Increase unit test coverage for DSL Helpers. https://review.openstack.org/413268 | 20:54 |
openstackgerrit | Jose Phillips proposed openstack/python-muranoclient: Return error code when a error occurred during package-import https://review.openstack.org/413702 | 21:01 |
*** yamamoto has joined #murano | 21:04 | |
*** ducttape_ has joined #murano | 21:12 | |
*** yamamoto has quit IRC | 21:13 | |
*** ducttape_ has quit IRC | 21:17 | |
*** Zer0Byte__ has quit IRC | 21:22 | |
*** Zer0Byte__ has joined #murano | 21:24 | |
Zer0Byte__ | question guys jenkin is broken? | 21:44 |
Zer0Byte__ | jenkins | 21:44 |
*** cleong has quit IRC | 22:03 | |
*** DavidPurcell has quit IRC | 22:13 | |
openstackgerrit | Felipe Monteiro proposed openstack/murano: [WIP] Increase unit test coverage for Common Auth Utils. https://review.openstack.org/413794 | 22:19 |
*** felipemonteiro has quit IRC | 22:23 | |
*** ducttape_ has joined #murano | 22:43 | |
*** ducttape_ has quit IRC | 22:48 | |
openstackgerrit | Stan Lagun proposed openstack/murano: Developing Murano Packages 101 https://review.openstack.org/381983 | 23:00 |
*** srwilkers_ has joined #murano | 23:22 | |
*** catintheroof has joined #murano | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!