Friday, 2014-12-12

« Thursday, 2014-12-11 Index Saturday, 2014-12-13 »
*** serg_melikyan has quit IRC00:00
*** serg_melikyan has joined #murano00:01
*** serg_melikyan has quit IRC00:19
*** serg_melikyan has joined #murano00:25
*** IlyaE has joined #murano00:30
*** IlyaE has quit IRC00:33
*** IlyaE has joined #murano00:33
*** IlyaE has quit IRC00:35
*** IlyaE has joined #murano00:36
*** IlyaE has quit IRC00:48
*** serg_melikyan has quit IRC00:55
*** serg_melikyan has joined #murano01:10
*** serg_melikyan has quit IRC01:10
*** serg_melikyan has joined #murano01:10
*** serg_melikyan has quit IRC01:32
*** serg_melikyan has joined #murano01:37
*** serg_melikyan has quit IRC02:47
*** serg_melikyan has joined #murano02:47
*** serg_mel_ has joined #murano02:49
*** serg_mel_ has quit IRC02:49
*** serg_mel_ has joined #murano02:49
*** serg_melikyan has quit IRC02:52
*** serg_mel_ has quit IRC02:54
*** serg_melikyan has joined #murano03:21
*** serg_melikyan has quit IRC03:51
*** serg_melikyan has joined #murano03:54
*** serg_melikyan has quit IRC04:05
*** IlyaE has joined #murano05:05
*** drupalmonkey has quit IRC05:06
*** killer_prince is now known as lazy_prince05:36
*** IlyaE has quit IRC07:04
*** IlyaE has joined #murano07:05
*** serg_melikyan has joined #murano07:06
*** IlyaE has quit IRC07:10
*** serg_melikyan has quit IRC07:10
*** serg_melikyan has joined #murano07:20
*** serg_melikyan has quit IRC07:32
*** serg_melikyan has joined #murano07:33
*** serg_melikyan has quit IRC08:03
*** henarmunoz has joined #murano08:17
*** lazy_prince has quit IRC08:59
*** henarmunoz has quit IRC09:09
openstackgerritOndrej Vojta proposed stackforge/murano: Test commit  https://review.openstack.org/14131209:40
*** Flcn has joined #murano09:47
*** killer_prince has joined #murano10:00
*** killer_prince is now known as lazy_prince10:00
openstackgerritRadek Pospisil proposed stackforge/murano-specs: Policy Rules Attachment in Murano  https://review.openstack.org/14039610:08
*** katyafervent is now known as katyafervent_awa10:09
*** isviridov_away is now known as isviridov10:10
*** katyafervent_awa is now known as katyafervent10:11
*** henarmunoz has joined #murano10:24
openstackgerritMerged stackforge/murano-agent: Workflow documentation is now in infra-manual  https://review.openstack.org/13947710:31
*** ddovbii_ has joined #murano10:43
*** asalkeld has quit IRC10:48
*** serg_melikyan has joined #murano11:03
*** serg_melikyan has quit IRC11:08
*** lazy_prince has quit IRC11:23
openstackgerritHenar Muñoz proposed stackforge/murano-specs: Spec Initial structure  https://review.openstack.org/14133411:26
openstackgerritHenar Muñoz proposed stackforge/murano-specs: Initial contribution for Support Configuration Language spec  https://review.openstack.org/14133511:26
openstackgerritHenar Muñoz proposed stackforge/murano-specs: identation correction  https://review.openstack.org/14133611:26
*** serg_melikyan has joined #murano12:03
openstackgerritHenar Muñoz proposed stackforge/murano-specs: rename spec file and correct identation problem  https://review.openstack.org/14134312:05
openstackgerritHenar Muñoz proposed stackforge/murano-specs: delete file  https://review.openstack.org/14134412:05
*** serg_melikyan has quit IRC12:08
*** henarmunoz has quit IRC12:21
ruheslagun: can you please review https://review.openstack.org/#/c/139067/ ? - this is a fix to stable branch12:33
slagunruhe: okay12:34
slagunruhe: do you know why I can't say +2 anymore?12:37
slagunin this branch12:37
ruhehmm12:37
ruhelet me check12:37
ruheslagun: can you check it now?12:38
slagundo i need to sign out first?12:39
ruheslagun: i don't think so12:39
slagunI still cannot do it (even with sign out - sign in)12:40
ruheok, let me try another thing :)12:41
ruheaha! found it! i had to add you to https://review.openstack.org/#/admin/groups/181,members12:44
ruhei've added Serg too12:44
slagunnow it works!12:44
openstackgerritStan Lagun proposed stackforge/murano: Adds per-class configs  https://review.openstack.org/13418313:20
*** k4n0 has quit IRC14:17
*** Flcn has quit IRC14:19
*** Flcn has joined #murano14:19
openstackgerritRadek Pospisil proposed stackforge/murano-specs: Murano Data Schema in Congress  https://review.openstack.org/14039814:47
*** serg_melikyan has joined #murano15:00
*** drupalmonkey has joined #murano15:07
openstackgerritRadek Pospisil proposed stackforge/murano-specs: Congress Support in Murano  https://review.openstack.org/14039715:23
*** killer_prince has joined #murano15:26
*** killer_prince is now known as lazy_prince15:27
openstackgerritRadek Pospisil proposed stackforge/murano-specs: Policy Enforcement Point  https://review.openstack.org/14039515:41
*** serg_melikyan has quit IRC15:41
*** serg_melikyan has joined #murano15:59
*** serg_melikyan has quit IRC16:01
*** serg_melikyan has joined #murano16:17
*** IlyaE has joined #murano16:25
*** IlyaE has quit IRC16:26
*** IlyaE has joined #murano16:29
*** serg_melikyan has quit IRC16:37
*** ddovbii_ has quit IRC16:54
*** serg_melikyan has joined #murano17:31
*** serg_melikyan has quit IRC17:31
*** serg_melikyan has joined #murano17:31
*** openstackgerrit has quit IRC17:34
*** openstackgerrit has joined #murano17:34
serg_melikyanruhe, what do you think about this change? https://review.openstack.org/#/c/136323/17:38
serg_melikyanslagun: please, take a look at https://review.openstack.org/#/c/137877/17:39
serg_melikyanslagun: and this https://review.openstack.org/#/c/137866/17:39
openstackgerritEkaterina Chernova proposed stackforge/murano-dashboard: Fix UI issues  https://review.openstack.org/14144017:39
ruheserg_melikyan: that's a nice improvement (Make category selection a separate step). it's a shame we don't have screenshots of that page17:40
ruhei mean, CI doesn't post screenshots if tests are passed17:40
ruhehttps://review.openstack.org/#/c/136323/6/muranodashboard/packages/views.py line 47. isn't this a bug?17:41
serg_melikyanIt's kind of strange peace of code17:43
ruhei guess we can't merge this patch yet17:45
ruheserg_melikyan: now, when https://review.openstack.org/#/c/137868/ and https://review.openstack.org/#/c/137876/ have several +1 and +2 from, i'm going to self-approve these really simple changes, if you don't mind17:47
serg_melikyannp17:47
slagunregarding https://review.openstack.org/#/c/137866/ I agree with Georgy17:48
*** openstackgerrit has quit IRC17:49
*** openstackgerrit has joined #murano17:49
serg_melikyanslagun: we need to stay always up-to-date with global requirements, otherwise we will have troubles with packaging17:50
ruheactually, we're already using new version of oslo.db in dsvm, murano-ci and to run unit/functional tests17:53
ruhewe're always using the latest release because there is no cap for upper version of dependency17:54
serg_melikyanslagun: can you take a look at https://review.openstack.org/13560817:54
ruhei think slagun just needs to rebase on HEAD of stable/juno once https://review.openstack.org/#/c/139067/ is merged17:55
slagunserg_melikyan: don't get me wrong. I'm not arguing with that. The point is that "oslo.db>=1.1.0" is narrowing of previous "oslo.db>=1.0.0". 1.1.0 complies with both. And there is no code change that requires >1.1.0. There is nothing that doesn't work with 1.0.0. So changing this requirement changes nothing but except for breaking requirements compatibility with old systems17:55
serg_melikyanslagun: https://github.com/openstack/requirements/commit/a1310f395a6697e47034f20b1783b1d86f68c09817:57
serg_melikyanthat's why do we need this change17:57
slagunI know that we n need to be compatible with global requirements. But being compatible != being equal to. We already compatible17:58
serg_melikyanAs oslo.db 1.1.0 contains fix of bug 1376211 which affects Neutron, requirements should be updated.18:00
slagunhttps://review.openstack.org/#/c/135608/  : test_mysql_opportunistically - No tables found. Wrong schema? WTF?18:00
slagunserg_melikyan: we are okay with 1.1.0. It satisfies our requirements18:01
serg_melikyan?18:01
serg_melikyanslagun: sorry didn't get your last sentence18:02
openstackgerritMerged stackforge/murano-dashboard: Improve component details page  https://review.openstack.org/12043518:02
openstackgerritMerged stackforge/murano-dashboard: Remove unused openstack common modules  https://review.openstack.org/13964418:02
openstackgerritMerged stackforge/murano-dashboard: Add selenium package to test-requirements  https://review.openstack.org/13760318:02
openstackgerritMerged stackforge/murano: Update information about murano sample config file  https://review.openstack.org/13707618:02
openstackgerritMerged stackforge/python-muranoclient: Add keystone v3 support to client  https://review.openstack.org/11111718:02
slagunoslo.db>1.0.0 2 thigs: "take latest release" and "we don't work with <1.0.0". version 1.1.0 satisfies both statements. Murano with existing requirements.txt file will install the same version it will with this commit18:03
*** Flcn has quit IRC18:04
serg_melikyanslagun: they do have 1.0.1 & 1.0.2 which are should not be used18:05
ruhebut the fact is - we'18:07
ruhesorry18:07
slagunthey wouldn't be installed either because 1.0.0 > 1.0.1 Because there is no upper limmit the latest version will be installed and the only thing that >=1.1.0 says that Murano cannot work with 1.0.0 which is not true18:07
ruhebut the fact is - murano is tested on 1.1.018:07
openstackgerritMerged stackforge/murano: Added generated sample config to gitignore  https://review.openstack.org/13787618:07
openstackgerritMerged stackforge/murano: Remove py26 from tox targets  https://review.openstack.org/13786818:08
slagunruhe: DB code was also tested on 1.0.0 and there are no changes to the code. I'm not against changing requirements but it seems wrong to narrow them without any code changes that explain why we need to narrow them18:09
slagun* 1.1.0 > 1.0.118:10
*** serg_melikyan has quit IRC18:10
ruheslagun: let me show how it works for integrated projects - https://review.openstack.org/#/c/140960/ ; imagine murano was already integrated, there wouldn't be any option to update requirements partially18:11
*** IlyaE has quit IRC18:12
ruheassuming, murano is being targeted to become integrated (or whatever it'll be called in future), i'd prefer to follow all the same procedures18:12
ruheimportant note about https://review.openstack.org/#/c/140960/ - it is submitted by bot, an automated system18:13
slagunruhe: so you're say that every integrated project has requirements.txt that is 100% identical to global requirements no matter if it needs those libraries or not?18:13
ruheslagun: yes18:13
ruheit's not identical18:14
ruheit's a subset of global-requirements18:14
*** serg_melikyan has joined #murano18:20
slagunruhe: I guess it doesn't worth arguing, but do you see any use case that our current requirements can break any deployment?  I tend to agree to day +2 not because I'm wrong but because it is OpenStack18:20
slagun*to say18:21
ruhe:)18:21
ruheslagun: well, at this point of time current murano/requirements.txt should not break anything. but someday we need to update all the requirements. i don't want that day to be somewhere close to release date of Kilo18:23
slagunruhe: I is good to test on latest requirement. I believe we already testing on 1.1.0 because it is  ">=1.0.0", not ">1.0.0<1.1.0"18:24
slagunSo this commit changes absolutely nothing to any existing environment18:25
slagun+2/+118:26
*** serg_melikyan has quit IRC18:29
*** serg_melikyan has joined #murano18:31
ruhethank you :)18:32
serg_melikyanslagun: https://review.openstack.org/13787518:32
serg_melikyanslagun: https://review.openstack.org/13787818:32
openstackgerritStan Lagun proposed stackforge/murano: Adds per-class configs  https://review.openstack.org/13418318:33
serg_melikyanslagun: https://review.openstack.org/#/c/137873/18:34
slagunruhe: https://review.openstack.org/#/c/137878/3/murano/engine/auth_utils.py how is this related to oslo.serialization?18:34
*** Flcn has joined #murano18:35
ruhehmm... yeah. i should've done it in a patch for oslo.utils18:36
slagunand btw why do we use xmlutils at all? Do we support XML anywhere?18:36
serg_melikyanin API18:37
slagunruhe: Are you going to split this commit or we just accept it as is?18:37
*** IlyaE has joined #murano18:37
slagunserg_melikyan: why, not where18:37
serg_melikyan>Do we support XML anywhere? / Yes, in API18:38
ruhemurano/common/wsgi.py uses xmlutils18:38
slagunDo you say that REST API accepts XML?18:39
ruhebtw, XML support is about to be dropped in most of openstack projects18:39
slagun+1 to drop it18:39
ruhebut, at this moment we cannot drop xmlutils because wsgi.py uses it18:40
ruhewsgi.py is a copy-paste from oslo-incubator. it was removed from oslo-incubator but murano still uses it18:40
*** IlyaE has quit IRC18:42
*** serg_melikyan has quit IRC18:42
openstackgerritMerged stackforge/murano: Update from global-requirements  https://review.openstack.org/13786618:43
slagunruhe: are you willing to update https://review.openstack.org/#/c/137878/ ? I don't really care if we merge it as is18:44
ruheslagun: i would update it, but the patch where i should've make this change is about to be merged. so, let's merge it as is18:45
slaguncan someone help me with https://review.openstack.org/#/c/135608/ ?18:49
*** serg_melikyan has joined #murano18:49
*** serg_melikyan has quit IRC18:49
*** serg_melikyan has joined #murano18:50
slagunit seems that we broke stable/juno18:50
ruheslagun: is this change based on my latest commit to stable/juno?18:52
slagunyes. Just rebased it18:52
ruheslagun: did you check logs from murano-ci?18:54
openstackgerritMerged stackforge/murano: Update from oslo incubator  https://review.openstack.org/13787318:54
openstackgerritMerged stackforge/murano: Remove unused imports from genconfig  https://review.openstack.org/13787518:54
openstackgerritMerged stackforge/murano: Use oslo.utils  https://review.openstack.org/13787718:54
ruheslagun: what do you think happened there?18:55
slagun <title>415 Unsupported Media Type</title>18:55
*** serg_melikyan has quit IRC18:55
slagunI know for sure that us us not because of this commit so I assume that CI is already broken18:56
slagunprobably it relates to io.murano.databases.PostgreSql.zip18:57
*** serg_melikyan has joined #murano18:58
*** IlyaE has joined #murano19:01
ruhetwo options: 1) CI is broken 2) we merged something bad19:02
*** serg_melikyan has quit IRC19:09
slagunUnrecognized Content-Type provided in request: Invalid content type application/octet-stream19:09
openstackgerritMerged stackforge/murano: Use oslo.serialization  https://review.openstack.org/13787819:09
ruheit fails the same way on both master and stable/juno which makes me think that our CI went south19:14
*** serg_melikyan has joined #murano19:18
openstackgerritRuslan Kamaldinov proposed stackforge/murano: DO NOT LOOK AT ME  https://review.openstack.org/14147119:18
*** serg_melikyan has left #murano19:19
*** serg_melikyan has joined #murano19:19
serg_melikyanruhe: Are you testing master or juno CI?19:20
slagunneed to go. Be back later today19:21
*** IlyaE has quit IRC19:25
serg_melikyanruhe: I think this staff https://github.com/stackforge/murano/commit/8480bac9b91a24ded9377da949a98ea104198a60 broke CI19:25
openstackgerritSerg Melikyan proposed stackforge/murano: Revert "Use oslo.serialization"  https://review.openstack.org/14147319:26
serg_melikyanhttps://review.openstack.org/#/c/141473/ - will check my thoughts19:26
*** drupalmonkey has quit IRC19:27
*** IlyaE has joined #murano19:27
*** drupalmonkey has joined #murano19:28
ruheserg_melikyan: but it passed CI in the first place. also we don't use oslo.serialization in stable/juno19:29
serg_melikyanruhe: so our CI is not passing on Juno or master?19:31
ruheon both19:31
serg_melikyanruhe: did you found where this bloody exception is thrown?19:35
ruheno19:35
ruhenot yet19:35
serg_melikyanhttps://github.com/stackforge/murano/blob/master/murano/common/wsgi.py#L36619:36
ruhehttps://murano-ci.mirantis.com/logs/73/141473/1/check/gate-murano-integration/00274ee/artifacts/screen-murano-api.2014-12-12-222746.log blames murano/common/wsgi.py:67119:40
serg_melikyanit's where it throws InvalidContentType and it's handled in 366 line and rethrown as unsupported media19:42
ruheok19:42
serg_melikyanbut this line was not changed by recent commits %(19:43
ruheand murano-ci voted -1 on https://review.openstack.org/#/c/141473/ which reverts oslo.serialization commit19:43
ruhe... with the same error19:44
serg_melikyanI am running out of ideas... other changes look much more harmless19:46
ruhewell, we can revert all the changes we made today19:46
*** tnurlygayanov has quit IRC19:47
ruheand see how it goes19:47
ruhewhat's the command to make a commit with revert of several commits? :)19:48
serg_melikyanI don't know such command %)19:54
serg_melikyanruhe: http://stackoverflow.com/questions/1463340/revert-multiple-git-commits19:55
serg_melikyanruhe: i will do that19:56
ruheserg_melikyan: there is a simpler solution :)19:56
ruhegit reset --soft COMMIT_ID19:56
ruhemerge it and send on review19:57
ruheoh, and do 'git reset' before doing the commit19:58
ruheor maybe i'm wrong19:58
ruhewe need one commit with all the changes reverted19:58
ruhethat's crazy :)20:00
serg_melikyan%)20:01
serg_melikyanI think i'll better will take debugger in my hands and will found root cause20:02
ruheyeah, good idea20:03
ruheone more observation. dsvm job still passes. i belive the same code is triggered in dsvm job too20:04
ruheby "the same code" i mean those lines from wsgi.py20:04
*** murano_zabbix has joined #murano20:07
murano_zabbixPROBLEM: murano-engine is broken (3+ test runs during last 4 hours have failed, see https://murano-ci.mirantis.com/jenkins/)20:07
*** murano_zabbix has quit IRC20:07
ruheha ha. murano_zabbix knows something :)20:09
serg_melikyanonly integration tests are failing20:09
serg_melikyanDo we run them on DSVM?20:09
ruheserg_melikyan: no, we don't20:09
serg_melikyanI think it is something related to package uploading20:09
ruhebut look at this http://git.openstack.org/cgit/stackforge/murano/tree/murano/tests/functional/api/base.py#n17720:10
ruhethis is the code we execute in dsvm job20:10
*** murano_zabbix has joined #murano20:11
murano_zabbixPROBLEM: murano-dashboard is broken (3+ test runs during last 4 hours have failed, see https://murano-ci.mirantis.com/jenkins/)20:11
*** murano_zabbix has quit IRC20:11
ruheserg_melikyan: slagun: i'm leaving now. will be back in an hour or 1.520:21
serg_melikyanruhe: heh...20:22
ruhewhat? :)20:22
*** sergmelikyan has joined #murano20:25
*** IlyaE has quit IRC20:41
*** Flcn has quit IRC20:51
serg_melikyanruhe: I can't reproduce issue :(21:01
serg_melikyanPackages are uploaded sucessfully21:01
*** drupalmonkey has quit IRC21:10
*** drupalmonkey has joined #murano21:12
ruheserg_melikyan: that means murano-ci went south21:31
serg_melikyanyeah21:31
serg_melikyanI found root cause actually21:31
serg_melikyanhttps://github.com/stackforge/murano/blob/master/murano/tests/functional/engine/base.py#L7921:32
serg_melikyanpackage files are not found on the disk21:32
ruheshould we expect ci to create these files?21:34
*** serg_melikyan has quit IRC21:37
*** serg_melikyan has joined #murano21:40
serg_melikyanIt should download them21:40
ruhelemme check21:41
openstackgerritRuslan Kamaldinov proposed stackforge/murano: [DONT MERGE] Remove postgres app tests  https://review.openstack.org/14149921:46
*** stan_lagun has joined #murano21:54
*** slagun has quit IRC21:57
ruheit actually creates these files21:57
ruheat least logs say so21:58
ruheserg_melikyan: couldn't this be caused by https://review.openstack.org/#/c/111117/ ?22:00
ruhemurano-ci installs client from master22:01
ruheand we (what a shame) do not run murano-ci on changes in python-muranoclient22:01
serg_melikyanwe did sometime ago though22:02
ruhecan you test this change locally?22:03
serg_melikyanruhe, sure22:03
*** serg_melikyan has quit IRC22:16
*** drupalmonkey has quit IRC22:21
*** drupalmonkey has joined #murano22:21
*** serg_melikyan has joined #murano22:22
ruheserg_melikyan: any updates?22:32
serg_melikyanruhe: sorry, get distracted by issues with murano manifests22:36
serg_melikyan*got22:41
*** IlyaE has joined #murano23:07
serg_melikyanruhe: was not able to reproduce using latest muranoclient23:08
ruheeverything works ok with the latest python-muranoclient?23:10
openstackgerritRuslan Kamaldinov proposed stackforge/murano: [WIP] debugging CI  https://review.openstack.org/14152023:34
ruheserg_melikyan: check out my patch and results from murano-ci ^23:42
ruhethe problem is not with ci23:42
serg_melikyanruhe: I am already close, reproduced with latest client. Indeed issues is with https://review.openstack.org/#/c/111117/23:43
serg_melikyanruhe: https://review.openstack.org/#/c/111117/16/muranoclient/v1/packages.py23:44
serg_melikyanthis is what cause this issue.23:45
serg_melikyanWe used requests directly to do POST with multi-part/data23:45
ruhedo you know how to fix it?23:47
serg_melikyannot yet - easiest way - revert this particular change.23:51
serg_melikyanBut I think it is better to fix bug23:52
serg_melikyanrevert change in packages.py, I mean23:52
ruheserg_melikyan: i'd prefer to revert the whole commit23:53
ruheit's safer and granular23:53
serg_melikyanBut it was really usefull feature :(23:54
ruheyeah, sure. we'll revert it to unblock CI, find out a way to fix it and merge it back23:58
« Thursday, 2014-12-11 Index Saturday, 2014-12-13 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!