| *** IlyaE has quit IRC | 00:12 | |
| *** gokrokve_ has quit IRC | 01:13 | |
| *** gokrokve has joined #murano | 02:25 | |
| *** gokrokve has quit IRC | 02:41 | |
| *** gokrokve has joined #murano | 02:41 | |
| *** gokrokve has quit IRC | 02:46 | |
| *** lecalcot has joined #murano | 03:04 | |
| *** lecalcot has quit IRC | 03:04 | |
| *** lecalcot has joined #murano | 03:04 | |
| openstackgerrit | Serg Melikyan proposed a change to stackforge/murano: Delete Heat stack when environment is deleted https://review.openstack.org/102810 | 04:00 |
|---|---|---|
| *** chandan_kumar has joined #murano | 05:34 | |
| *** killer_prince is now known as lazy_prince | 05:35 | |
| *** IlyaE has joined #murano | 05:37 | |
| *** lazy_prince is now known as killer_prince | 06:06 | |
| *** IlyaE has quit IRC | 06:41 | |
| *** killer_prince is now known as lazy_prince | 06:43 | |
| *** IlyaE has joined #murano | 07:02 | |
| *** chandan_kumar is now known as chandankumar | 07:23 | |
| *** IlyaE has quit IRC | 07:46 | |
| openstackgerrit | Serg Melikyan proposed a change to stackforge/murano: Delete Heat stack when environment is deleted https://review.openstack.org/102810 | 08:17 |
| *** slagun has joined #murano | 08:17 | |
| *** stan_lagun has quit IRC | 08:20 | |
| *** DaveJ__ has joined #murano | 09:03 | |
| *** lazy_prince is now known as killer_prince | 09:12 | |
| openstackgerrit | Serg Melikyan proposed a change to stackforge/murano: Delete Heat stack when environment is deleted https://review.openstack.org/102810 | 09:14 |
| *** killer_prince is now known as lazy_prince | 09:32 | |
| *** lazy_prince has quit IRC | 09:52 | |
| *** lazy_prince has joined #murano | 10:38 | |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for engine's YAQL functions https://review.openstack.org/104959 | 10:43 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Use random name for Heat stack name instead of environment's name https://review.openstack.org/105117 | 11:02 |
| openstackgerrit | A change was merged to stackforge/murano: Add articles about Automated Tests https://review.openstack.org/102500 | 11:37 |
| *** lecalcot has quit IRC | 11:50 | |
| sergmelikyan | sjmc7: finally I have finished that damn test :) Take a look please https://review.openstack.org/102810 | 12:06 |
| sergmelikyan | :) | 12:06 |
| slagun | I see -1 there without explanation | 12:11 |
| openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Use testtools insted af unitest2 https://review.openstack.org/105140 | 12:13 |
| openstackgerrit | A change was merged to stackforge/murano: Use random name for Heat stack name instead of environment's name https://review.openstack.org/105117 | 12:21 |
| *** akuznetsova has quit IRC | 12:31 | |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: YAQL version updated to 0.2.3 https://review.openstack.org/104881 | 12:31 |
| *** akuznetsova has joined #murano | 12:33 | |
| ruhe | slagun: (cc sergmelikyan) https://review.openstack.org/#/c/104721/ and https://review.openstack.org/#/c/104959/ didn't get +1 from murano-ci. please make sure they have +1 from murano-ci before merging/approving/+2ing these patches | 12:33 |
| openstackgerrit | A change was merged to stackforge/murano: YAQL version updated to 0.2.3 https://review.openstack.org/104846 | 12:35 |
| *** gokrokve has joined #murano | 12:37 | |
| *** gokrokve has quit IRC | 12:38 | |
| *** gokrokve has joined #murano | 12:39 | |
| *** gokrokve has quit IRC | 12:43 | |
| *** chandan_kumar has joined #murano | 13:10 | |
| *** chandankumar has quit IRC | 13:15 | |
| *** chandan_kumar is now known as chandankumar | 13:15 | |
| sergmelikyan | ruhe, murano-ci fails randomly on test_deploy_tomcat test :( | 13:19 |
| * sergmelikyan have no clue why it is happening, but it is known issue since last week | 13:20 | |
| *** drupalmonkey has joined #murano | 13:39 | |
| ruhe | sergmelikyan: well, you have igorY and dmitryT in the same room with you :) what do they think about these random failures? maybe there is smth wrong with the infrastructure? | 13:40 |
| *** sjmc7 has joined #murano | 14:10 | |
| sjmc7 | morning. i don't think https://review.openstack.org/#/c/105117/ is a good idea - it means a user is going to see heat stacks with random names under their account and not understand where they came from | 14:15 |
| ruhe | ativelkov: sergmelikyan: why was it merged so fast? | 14:18 |
| sergmelikyan | ruhe, I believe we agreed on this change, and it is how it was before. | 14:19 |
| sergmelikyan | This change returned behavior prior 0.5 release | 14:19 |
| sjmc7 | what was the reason for reverting the behavior? | 14:20 |
| sergmelikyan | sjmc7, what is you suggestion? We can prefix name with some 'murano_' prefix | 14:20 |
| sergmelikyan | sjmc7, issue with duplicated names of stacks | 14:20 |
| sjmc7 | environment names are unique now, aren't they? | 14:20 |
| sjmc7 | if that is a problem, my suggestion would be a couple of random characters after the env name, or to use the stack id internally | 14:22 |
| sergmelikyan | I am not sure, this change looked quite natural. Btw, this change does not change actual heat stack name | 14:23 |
| sergmelikyan | only agentListener name | 14:23 |
| sergmelikyan | Maybe this is also bug | 14:24 |
| sjmc7 | "Use random name for Heat stack name" | 14:24 |
| sergmelikyan | my apologies :( Missed many pitfails with this patch | 14:24 |
| sergmelikyan | Let's revert it? | 14:24 |
| *** gokrokve has joined #murano | 14:27 | |
| sjmc7 | it sounds like it's not doing what it's supposed to, so it should be reverted; i also don't like the behavior it's trying to do | 14:28 |
| ruhe | we should not rush with any changes. i believe there was no reason to merge it so fast | 14:28 |
| sergmelikyan | agree | 14:30 |
| sergmelikyan | sjmc7, ruhe I am sorry :( | 14:30 |
| sjmc7 | no worries | 14:30 |
| openstackgerrit | Serg Melikyan proposed a change to stackforge/murano: Revert "Use random name for Heat stack name instead of environment's name" https://review.openstack.org/105188 | 14:31 |
| sjmc7 | things that change external behavior i'd prefer to discuss first though | 14:31 |
| *** lazy_prince has quit IRC | 14:37 | |
| *** chandankumar has quit IRC | 14:51 | |
| openstackgerrit | Serg Melikyan proposed a change to stackforge/murano: Revert "Use random name for Heat stack name" https://review.openstack.org/105188 | 14:53 |
| *** stanlagun has joined #murano | 14:55 | |
| *** slagun has quit IRC | 14:57 | |
| *** gokrokve has quit IRC | 14:57 | |
| *** IlyaE has joined #murano | 14:58 | |
| *** gokrokve has joined #murano | 14:58 | |
| *** gokrokve_ has joined #murano | 15:00 | |
| *** gokrokve has quit IRC | 15:02 | |
| katyafervent | Hi sjmc7! | 15:04 |
| sjmc7 | hi | 15:04 |
| katyafervent | I finished with test for https://review.openstack.org/102162 Could you please take a look? | 15:05 |
| sjmc7 | yes, will do | 15:05 |
| katyafervent | and I meant this https://review.openstack.org/#/c/99177/ :) | 15:05 |
| katyafervent | Thanks in advance! | 15:05 |
| *** chandan_kumar has joined #murano | 15:06 | |
| *** gokrokve_ has quit IRC | 15:06 | |
| *** gokrokve has joined #murano | 15:07 | |
| *** gokrokve has quit IRC | 15:11 | |
| *** killer_prince has joined #murano | 15:13 | |
| *** killer_prince is now known as lazy_prince | 15:14 | |
| openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state https://review.openstack.org/104801 | 15:21 |
| drupalmonkey | katyafervent: your comment on https://review.openstack.org/#/c/103990/, it looks like that function is already in python-muranoclient: https://github.com/stackforge/python-muranoclient/blob/master/muranoclient/v1/packages.py#L145 | 15:26 |
| katyafervent | drupalmonkey, oh, I have the obsolete client. sorry | 15:28 |
| stanlagun | sjmc7: hi! | 15:29 |
| katyafervent | I checked opened review for python-muranoclient and didn't find :) | 15:29 |
| *** IlyaE has quit IRC | 15:44 | |
| sjmc7 | hi stan | 15:44 |
| stanlagun | sjmc7: I'm sorry for guys merging https://review.openstack.org/#/c/105117/ too soon | 15:45 |
| sjmc7 | no harm done | 15:45 |
| stanlagun | And if you take a look in changes in that commit it dies not what it says in commit message :) | 15:46 |
| stanlagun | Actually it changes only queue name | 15:46 |
| sjmc7 | yeah - which is probably ok | 15:48 |
| stanlagun | So the question now is how to fix this better - make it also the name of the stack, just rename heatStackName -> queueName or something else\ | 15:48 |
| *** TravT has joined #murano | 15:49 | |
| stanlagun | I think it would be right to make stack name random | 15:52 |
| *** IlyaE has joined #murano | 15:52 | |
| *** IlyaE has quit IRC | 16:03 | |
| sjmc7 | i think that'll be very confusing for users | 16:03 |
| openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: [WIP] Setup base for DB related unit tests https://review.openstack.org/105221 | 16:07 |
| ruhe | +1 to sjmc7 ; horizon is a user facing part and everything we display there should have a meaningful name | 16:07 |
| stanlagun | My point is that end users are not aware of heat. They don't understand what are the constraints for environment name. They may not have direct access to Heat. And even if they do they should not do anything with our stacks bypassing Murano. User can accidentally call they environment with the name of existing stack causing undetermined behavior and destroying that stack | 16:12 |
| *** gokrokve has joined #murano | 16:14 | |
| stanlagun | ruhe, It may be not a good idea to have a human readable name for things that are not supposed to be accessed by human | 16:16 |
| stanlagun | I'd prefer to extend Horizon with ability to hide certain things | 16:17 |
| sjmc7 | that may be a good long term goal, but it is long term | 16:18 |
| sjmc7 | as a user, i'm much more likely to delete something that shows up in a heat stack list and is costing me money if i don't know what it is | 16:18 |
| stanlagun | extend horizon or what? | 16:18 |
| stanlagun | The problem is that even it has readable name you may still don't know what it is. It may be just created by another user in your tenant | 16:20 |
| ruhe | well, if heat stack if prefixed with "murano" and postfixed with somthing random, that would be a good message to users that they shouldn't delete these things | 16:21 |
| stanlagun | It is ok for Heat because users explicitly create stacks. But in Murano stacks are generated and user may not even be aware of it | 16:21 |
| sjmc7 | you could argue the same for nova resources | 16:22 |
| sjmc7 | a cloud admin could choose to hide dashboard panels from certain users if they want | 16:22 |
| stanlagun | yes. We do generate instance names either | 16:22 |
| sjmc7 | but obfuscating names is not the answer | 16:22 |
| stanlagun | ruhe's suggestion seems like a good solution to me | 16:23 |
| stanlagun | just use some prefix | 16:23 |
| sjmc7 | yes, i would prefer something like that | 16:23 |
| stanlagun | ok. So let me fix that commit by another commit and I ask both of you to review it prior to approval :) | 16:24 |
| sjmc7 | what are you going to change the behavior to? | 16:24 |
| stanlagun | queueName = randomName(), heatStackName = 'murano_' + queueName | 16:25 |
| sjmc7 | i'm still not clear why we need random names | 16:25 |
| stanlagun | instead of what? | 16:25 |
| sjmc7 | environment name, plus a couple of random suffix characters if it really needs randomziing | 16:26 |
| stanlagun | This ties environment name with Heat restrictions. If user is not aware of Heat he doesn't understand why he cannot call environment "My IT department" | 16:27 |
| sjmc7 | i agree he should be able to call it whatever he wants. why not slugify the name though? | 16:30 |
| sjmc7 | randomizing is one solution, but i think it leads to other problems | 16:30 |
| stanlagun | how do you suggest to do it? | 16:32 |
| stanlagun | also don't forget about national characters. I can call my env name in Chinese | 16:33 |
| sjmc7 | murano-my-it-department ? | 16:33 |
| stanlagun | there are other illegal characters besides space. It may be hard to implement proper generation. Especially in MuranoPL | 16:35 |
| *** TravT has quit IRC | 16:41 | |
| sjmc7 | ok. so there will be no way, as a user, for me to know that a heat stack corresponds to a murano environment? | 16:41 |
| *** IlyaE has joined #murano | 16:41 | |
| stanlagun | We could make it as an environment's out property and display this information to user the same way we display other service information (when we implement it). But I'm not sure this a good idea. If user is not aware of Heat having cryptic name in UI may be not good. Maybe there it is possible to tag Heat stack somehow. So that Murano env name will be shown somewhere in stack details. HOT templates have author attribute. If Heat preserves it maybe we | 16:53 |
| stanlagun | can set stack author to environment name or something like that | 16:53 |
| stanlagun | This is also a problem with nova instances - how do you determine which generated instance belongs to which environment? | 16:55 |
| *** IlyaE has quit IRC | 16:58 | |
| sjmc7 | because heat prefixes instance names | 17:05 |
| *** ankurrr has joined #murano | 17:07 | |
| *** IlyaE has joined #murano | 17:13 | |
| *** lazy_prince is now known as killer_prince | 17:19 | |
| *** IlyaE has quit IRC | 17:27 | |
| *** btully has joined #murano | 17:28 | |
| *** IlyaE has joined #murano | 17:37 | |
| *** asalkeld has joined #murano | 17:39 | |
| *** IlyaE has quit IRC | 17:56 | |
| *** IlyaE has joined #murano | 18:20 | |
| *** lecalcot has joined #murano | 18:37 | |
| *** lecalcot has quit IRC | 18:38 | |
| *** lecalcot has joined #murano | 18:38 | |
| *** DaveJ__ has quit IRC | 18:48 | |
| *** IlyaE has quit IRC | 18:52 | |
| *** IlyaE has joined #murano | 19:04 | |
| *** chandan_kumar has quit IRC | 19:06 | |
| *** IlyaE has quit IRC | 19:31 | |
| *** asalkeld has quit IRC | 19:32 | |
| stanlagun | sjmc7: so did we agree on something? | 20:09 |
| *** asalkeld has joined #murano | 20:10 | |
| *** asalkeld has quit IRC | 20:10 | |
| sjmc7 | i would still prefer the stack name to be connected to the environment name but if you're set on randomizing it then go for it | 20:14 |
| sjmc7 | at the very least there should be a prefix for resources created from murano | 20:14 |
| stanlagun | I prefer it too. It just a matter of having a good algorithm to do so. I don't have one at the moment. Anyway lets start with prefix+random and improve it later. I will also research if there is a way to preserve environment name/id somewhere inside HOT template | 20:18 |
| openstackgerrit | Ankur Rishi proposed a change to stackforge/murano: Add optional fields to packages for supplier info https://review.openstack.org/99465 | 20:20 |
| sjmc7 | templates can have descriptions | 20:29 |
| *** IlyaE has joined #murano | 21:14 | |
| sjmc7 | stanlagun - are you modifying the change from this morning that got merged, or creating a new one? serg proposed https://review.openstack.org/#/c/105188/ to revert the original one | 21:32 |
| sjmc7 | but we can kill it if you're going to add another one based on the first | 21:32 |
| stanlagun | I think there is no point for reverse commit. Those changes were right. What was wrong is the commit message and local variable name. It is not worth reverting | 21:54 |
| sjmc7 | ok | 21:55 |
| *** btully has quit IRC | 22:22 | |
| *** IlyaE has quit IRC | 22:31 | |
| *** IlyaE has joined #murano | 22:52 | |
| *** IlyaE has quit IRC | 23:05 | |
| *** IlyaE has joined #murano | 23:10 | |
| *** lecalcot has quit IRC | 23:12 | |
| *** IlyaE has quit IRC | 23:20 | |
| *** IlyaE has joined #murano | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!