*** IlyaE has quit IRC | 00:09 | |
btully | the errors i get relate to 2 fields | 00:12 |
---|---|---|
btully | class_definition.name and package.fully_qualified_name were both set to 512 chars and index=True | 00:12 |
btully | which results in mysql giving an error and stops the migration | 00:12 |
btully | OperationalError: (OperationalError) (1071, 'Specified key was too long; max key length is 767 bytes') 'CREATE INDEX ix_class_definition_name ON class_definition (name) | 00:13 |
btully | OperationalError: (OperationalError) (1071, 'Specified key was too long; max key length is 767 bytes') 'CREATE INDEX ix_package_fully_qualified_name ON package (fully_qualified_name)' | 00:13 |
btully | any advice would be appreciated | 00:13 |
btully | i could go into 001_initial_version.py and set those fields to index=False | 00:14 |
btully | but not sure if that will break things down the road | 00:14 |
btully | is there some required my.cnf setting that would allow this to work? | 00:15 |
*** ankurrr has quit IRC | 00:16 | |
openstackgerrit | Georgy Okrokvertskhov proposed a change to stackforge/murano-dashboard: Fix topology page issue with dependencies https://review.openstack.org/104030 | 00:22 |
*** gokrokve has quit IRC | 00:24 | |
*** TravT|2 has quit IRC | 00:57 | |
*** gokrokve has joined #murano | 01:49 | |
*** killer_prince is now known as lazy_prince | 02:59 | |
*** lazy_prince is now known as killer_prince | 03:00 | |
*** TravT has joined #murano | 03:45 | |
*** TravT has quit IRC | 04:03 | |
openstackgerrit | Georgy Okrokvertskhov proposed a change to stackforge/murano-dashboard: Add app images to topology page https://review.openstack.org/104064 | 04:16 |
*** drupalmonkey has quit IRC | 04:24 | |
*** lazy_prince has joined #murano | 04:25 | |
*** IlyaE has joined #murano | 04:42 | |
*** lazy_prince has quit IRC | 04:46 | |
*** killer_prince is now known as lazy_prince | 04:47 | |
*** chandan_kumar has joined #murano | 05:38 | |
*** IlyaE has quit IRC | 06:03 | |
*** gokrokve has quit IRC | 06:29 | |
stan_lagun | btully, I've seen that before. The solution is to use ASCII collation (instead of UTF) | 06:44 |
*** gokrokve has joined #murano | 07:00 | |
*** gokrokve_ has joined #murano | 07:02 | |
*** gokrokv__ has joined #murano | 07:04 | |
*** gokrokve has quit IRC | 07:04 | |
*** gokrokve_ has quit IRC | 07:07 | |
*** gokrokv__ has quit IRC | 07:08 | |
openstackgerrit | Dmitry Teselkin proposed a change to stackforge/murano: Sync Global Requirements (Juno) https://review.openstack.org/104105 | 08:01 |
*** gokrokve has joined #murano | 08:04 | |
*** gokrokve has quit IRC | 08:09 | |
*** slagun has joined #murano | 08:14 | |
*** stan_lagun has quit IRC | 08:17 | |
*** gokrokve has joined #murano | 08:30 | |
*** gokrokve has quit IRC | 08:34 | |
*** gokrokve has joined #murano | 09:02 | |
*** gokrokve has quit IRC | 09:03 | |
*** gokrokve has joined #murano | 09:04 | |
*** gokrokve has quit IRC | 09:09 | |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 09:18 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 09:18 |
katyafervent__ | Please https://review.openstack.org/#/c/101578/ | 09:18 |
*** gokrokve has joined #murano | 10:02 | |
*** gokrokve has quit IRC | 10:07 | |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 10:32 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 10:32 |
*** gokrokve has joined #murano | 11:02 | |
*** gokrokve has quit IRC | 11:08 | |
*** gokrokve has joined #murano | 12:02 | |
*** gokrokve has quit IRC | 12:07 | |
*** gokrokve has joined #murano | 13:02 | |
*** chandan_kumar is now known as chandankumar | 13:03 | |
*** gokrokve has quit IRC | 13:07 | |
btully | @slagun - i'll give the ASCII collation a try. However the migration file/schema explicitly sets it to utf8. Does this mean it's a bug and that the 001_initial_version.py file should be updated to change MYSQL_CHARSET = 'utf8' to MYSQL_CHARSET = 'ascii' ? | 13:21 |
slagun | collation of that column, not entire table | 13:22 |
slagun | FQN is ASCII | 13:22 |
btully | FQN? | 13:23 |
slagun | fully_qualified_name | 13:24 |
btully | i don't see ascii specified anywhere in 001_intial_version.py | 13:25 |
btully | and it looks like the sqlalchemy commands for MYSQL_CHARSET are applied at the table level, not the column level | 13:26 |
slagun | it is a bug. There was similar problem when it was sqlalchemy-migrate. If you see older revision in git there was similar migration 004 with String(512) and there was the same problem that was fixed by collation='ascii_general_ci' | 13:27 |
slagun | Not sure about alembic, but MySQL and sqlalchemy-migrate support this on column level | 13:28 |
btully | i see. ok. thanks! so is there is this line: | 13:29 |
btully | sa.Column('fully_qualified_name', sa.String(length=512), | 13:29 |
btully | nullable=False, index=False), | 13:29 |
btully | well i changed index to false | 13:29 |
slagun | index is required | 13:29 |
btully | but you're saying i should be able to specify the charset or collation in that line as well? | 13:30 |
slagun | there are limitations on maximum column length that MySQL can index. 512 *unicode* chars is more then that limit. But 512 ASCII chars = 512 bytes is less. If you change column collation then index will work fine. And we do need that index | 13:31 |
btully | right i understand that | 13:32 |
btully | not being familiar with alembic or sqlalchemy i was just wondering how i'd alter that line in defining the column. no worries, i'll do some googling | 13:33 |
slagun | I'm sure that can be done. And because alembic was introduce after J1 it is acceptable (although not a good practice) to patch existing migration | 13:34 |
ruhe | btully: hi! can you give more details on mysql you're using (OS, mysql package and version)? | 13:39 |
btully | mysql Ver 14.14 Distrib 5.6.17, for osx10.8 (x86_64) | 13:39 |
*** drupalmonkey has joined #murano | 13:45 | |
*** lazy_prince is now known as killer_prince | 13:45 | |
ruhe | i'm developing on mysql too. there must be some specific details in the mysql config | 13:51 |
ruhe | btully: did you install it from brew? | 13:51 |
ruhe | * i'm developing on osx too | 13:52 |
btully | i believe so, yes | 13:52 |
btully | using python-mysql | 13:52 |
btully | sorry mysql-python | 13:54 |
btully | and yes, mysql installed via homebrew | 13:56 |
btully | what slagun said makes sense | 13:56 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 13:57 |
ruhe | yes, patching migration 001 is ok now | 13:57 |
btully | if the collation of the DB and table is utf8 and the columns we want to index are 512 chars, it is too big for the index since the max key length is 767 bytes | 13:57 |
btully | can anyone familiar with alembic or sqlalchemy show me how I would patch the command? I've been googling and haven't found an example of setting the column collation | 13:59 |
ruhe | btully: sure. just one moment :) | 14:00 |
btully | many thanks | 14:00 |
*** IlyaE has joined #murano | 14:02 | |
*** gokrokve has joined #murano | 14:02 | |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Code refactoring and improvements for MuranoPL testing mini-framework https://review.openstack.org/104199 | 14:05 |
*** gokrokve has quit IRC | 14:07 | |
ativelkov | slagun: could ypu please check this commit in yaql? https://github.com/ativelkov/yaql/commit/5f1e32b96443a494e50e0cc53e0d33e7aad91a3e | 14:17 |
ativelkov | If it is fine I'll publish a new version on PyPi | 14:18 |
slagun | sure | 14:18 |
slagun | +1 | 14:19 |
slagun | but you also need to change version sting in another file | 14:19 |
ativelkov | It is already changed to 0.2.3 | 14:24 |
ativelkov | but this version has never been published | 14:25 |
ativelkov | so we can publish it now | 14:25 |
*** gokrokve has joined #murano | 14:26 | |
*** gokrokve_ has joined #murano | 14:27 | |
ativelkov | https://pypi.python.org/pypi/yaql/0.2.3 | 14:27 |
slagun | what other changes does it contain? | 14:27 |
ativelkov | get function | 14:27 |
slagun | so we can remove one from engine? | 14:28 |
ativelkov | Lets check if it works - and then remove, yes | 14:28 |
slagun | context.register_function(yaql_builtin.dict_attribution, 'get') | 14:28 |
slagun | thats 'get'? | 14:29 |
*** gokrokve has quit IRC | 14:31 | |
ativelkov | yes | 14:32 |
ativelkov | yaql> dict(a=>1, b=>2, c=>3).get(a) | 14:33 |
ativelkov | works at my yaql console | 14:33 |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: [WIP] Fix DB migration scripts https://review.openstack.org/104205 | 14:40 |
ruhe | btully: can you please apply this patch ^^ and check if it works for you? | 14:40 |
ruhe | btully: i did the fix the other way. i've used prefix indexes | 14:41 |
*** gokrokve_ has quit IRC | 14:43 | |
*** gokrokve has joined #murano | 14:47 | |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Code refactoring and improvements for MuranoPL testing mini-framework https://review.openstack.org/104199 | 14:59 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 15:03 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 15:03 |
*** gokrokve has quit IRC | 15:10 | |
*** gokrokve has joined #murano | 15:11 | |
openstackgerrit | Ryan Peters proposed a change to stackforge/murano-dashboard: Displays supplier info fields on Application Details page https://review.openstack.org/103990 | 15:12 |
drupalmonkey | did yaql just disappear? http://pypi.openstack.org/simple/yaql/ | 15:19 |
drupalmonkey | all the tests are failing because it can't find yaql | 15:19 |
ruhe | drupalmonkey: hi. yeah, there is some problem and we're all trying to find what's the reason for that | 15:20 |
ruhe | i don't know yet whether it's a problem with pypi, openstack infra, or something else | 15:22 |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: DO NOT MERGE https://review.openstack.org/104232 | 15:25 |
*** gokrokve has quit IRC | 15:25 | |
openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Enhance versionutils.deprecated to work with classes https://review.openstack.org/103502 | 15:39 |
*** chandankumar has quit IRC | 15:44 | |
btully | ruhe: that patch seemed to work | 15:52 |
btully | thanks so much!!! | 15:52 |
btully | in a related question. i noticed that manage.py db-sync no longer works | 15:53 |
ruhe | btully: np. sorry that you've been block for so long | 15:53 |
btully | and was told to use PYTHONPATH=. ./tools/with_venv.sh .venv/bin/murano-db-manage --config-file etc/murano/murano.conf downgrade | 15:53 |
btully | PYTHONPATH | 15:53 |
ruhe | btully: yes, manage.py db-sync is superseded by murano-db-manage | 15:53 |
ruhe | usually i use tox to manage virtual environments | 15:54 |
btully | right, so i needed to run setup.py first | 15:54 |
ruhe | http://murano.readthedocs.org/en/latest/install/manual.html#installing-the-api-service-and-engine | 15:54 |
ruhe | tox -e venv -- murano-db-manage --config-file /etc/murano/murano.conf upgrade | 15:54 |
btully | ooh nice | 15:54 |
btully | :D | 15:54 |
btully | do i need to install tox separately? | 15:57 |
ruhe | btully: yep. i suggest to use tov 1.6.1 | 15:58 |
ruhe | pip install tox==1.6.1 | 15:58 |
*** killer_prince is now known as lazy_prince | 16:05 | |
*** gokrokve has joined #murano | 16:06 | |
*** IlyaE has quit IRC | 16:16 | |
ruhe | drupalmonkey: it's seems that yaql problem is caused by recent changes in the infra configs. we're trying to find how to fix that | 16:29 |
*** lazy_prince is now known as killer_prince | 16:34 | |
*** bharath has joined #murano | 16:36 | |
bharath | can invisible_to_admin deploy the environment? | 16:37 |
*** IlyaE has joined #murano | 16:55 | |
slagun | bharath, sorry, didn't get you | 17:10 |
bharath | slagun: we have user called "invisible to admin" in openstack right? | 17:11 |
slagun | didn't knew that :) | 17:12 |
bharath | slagun: when we login as demo tenant, we have two users demo and "invisible to admin" | 17:13 |
*** IlyaE has quit IRC | 17:17 | |
slagun | anyway Murano doesn't constraint users. If user has enough permissions to access Neutron and create Heat stack he can deploy environment | 17:18 |
bharath | slagun: oh okay and one more question, can we select existing networks while deploying instead of creating our own network? | 17:19 |
slagun | not sure. I think it is possible with current core library design (e.g. if you provide correct object model to engine) but may not be exposed in dashboard | 17:22 |
slagun | katyafervent__, probably you know it better than me | 17:22 |
openstackgerrit | Ryan Peters proposed a change to stackforge/murano: Add optional fields to packages for supplier info https://review.openstack.org/99465 | 17:27 |
ruhe | #info failing jobs with errors about inability to install yaql are caused by recent changes in openstack-infra. no ETA on resolution yet. we're discussing this issue at #openstack-infra | 17:28 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Code refactoring and improvements for MuranoPL testing mini-framework https://review.openstack.org/104199 | 17:35 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Code refactoring and improvements for MuranoPL testing mini-framework https://review.openstack.org/104199 | 17:39 |
ruhe | #info yaql issue is resolved. in case if your patch was affected by it, please add a comment "recheck no bug" in your patch. it'll re-trigger jenkins jobs | 17:43 |
ruhe | * comment should be added in the gerrit UI | 17:44 |
ruhe | * see https://review.openstack.org/#/c/103502/ for example | 17:45 |
*** openstackgerrit has quit IRC | 17:49 | |
*** openstackgerrit has joined #murano | 17:49 | |
openstackgerrit | Ryan Peters proposed a change to stackforge/murano: Add optional fields to packages for supplier info https://review.openstack.org/99465 | 17:49 |
slagun | May I ask you to review https://review.openstack.org/#/c/104199/ out of order? I need to make list of commits that all depend on this | 17:57 |
*** bharath has quit IRC | 17:58 | |
*** IlyaE has joined #murano | 18:10 | |
ruhe | slagun: sure. we just need to get +1 from murano-ci. i understand problems aren't caused by your patch (it's again a problem in murano-ci infrastructure), but we can't merge this patch until we make sure that it passes real deployment tests | 18:16 |
slagun | ruhe, how long may it take? And what will you suggest - wait for ci or make all dependent commits right away? | 18:19 |
ruhe | slagun: you can send all dependent commit right now. we need to fix murano-ci tomorrow, we don't have any other options | 18:22 |
slagun | anyway, you can do code review on that commit | 18:23 |
ruhe | slagun: sure. i will | 18:23 |
slagun | ruhe: thanks! | 18:25 |
openstackgerrit | Ryan Peters proposed a change to stackforge/murano-dashboard: Displays supplier info fields on Application Details page https://review.openstack.org/103990 | 18:27 |
*** IlyaE has quit IRC | 18:44 | |
*** IlyaE has joined #murano | 19:23 | |
*** IlyaE has quit IRC | 19:57 | |
*** IlyaE has joined #murano | 20:05 | |
*** IlyaE has quit IRC | 20:52 | |
*** IlyaE has joined #murano | 20:54 | |
*** gokrokve has quit IRC | 21:06 | |
*** gokrokve has joined #murano | 21:08 | |
*** IlyaE has quit IRC | 21:14 | |
*** IlyaE has joined #murano | 21:18 | |
*** IlyaE has quit IRC | 21:29 | |
*** IlyaE has joined #murano | 21:33 | |
*** btully has quit IRC | 22:23 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!