| kata-irc-bot | <liubin0329> Hi, you can use annotations I think. | 02:40 |
|---|---|---|
| kata-irc-bot | <liubin0329> The ``io.katacontainers.config_path`` in https://github.com/kata-containers/kata-containers/blob/baf4784a297fedfb7ed56b67657eef8b6df78195/docs/how-to/how-to-set-sandbox-config-kata.md let you to set config file path for different contaienrs. | 02:42 |
| kata-irc-bot | <liubin0329> And there are also individual config items you can pass by annotations. | 02:48 |
| kata-irc-bot | <liubin0329> to override the default configs | 02:49 |
| kata-irc-bot | <sebastian.hasler> I don't want per-Pod configuration. I just want a single drop-in file that applies to all Pods. Reason: I don't want to maintain a full config where the default changes with every Kata release. | 07:43 |
| kata-irc-bot | <liubin0329> I got it, I think you want something like containerd has done. Users can run contained by a minimum config file, but if wanted, they can use `containerd config` to generate a full config file and edit it. I think it maybe a new feature. | 08:23 |
| kata-irc-bot | <eric.ernst> Yeah, there's a way for drop in override for specific fields. Let me see if I can find docs…. | 14:42 |
| kata-irc-bot | <eric.ernst> See https://github.com/containerd/containerd/blob/main/docs/man/containerd-config.toml.5.md#format | 14:47 |
| kata-irc-bot | <eric.ernst> Look at “imports” | 14:47 |
| kata-irc-bot | <eric.ernst> What I’d do is import a kata-runtime.toml | 14:47 |
| kata-irc-bot | <eric.ernst> Then you only need to update your original config.toml to include imports of something like /path/to/runtime*.toml. | 14:48 |
| kata-irc-bot | <eric.ernst> If you have a /path/to/runtime*.toml for kata stuff, it is applied. | 14:49 |
| kata-irc-bot | <eric.ernst> This fit your need @sebastian.hasler? | 14:49 |
| kata-irc-bot | <eric.ernst> (sorry for the delay!) | 14:50 |
| kata-irc-bot | <sebastian.hasler> @eric.ernst I think imports is for splitting the containerd config into multiple files. Not for splitting the kata config into multiple files. With a single kata config file, the containerd config contains this: ``` ["plugins"."io.containerd.grpc.v1.cri"."containerd"."runtimes"."untrusted"."options"] "ConfigPath" = "/opt/kata/share/defaults/kata-containers/configuration.toml"``` | 15:04 |
| kata-irc-bot | <eric.ernst> Correct it is. Perhaps I’m misunderstanding the goal. | 15:05 |
| kata-irc-bot | <eric.ernst> Aaah, I thought you were asking wrt containerd itself, not the Kata toml, mea culpa | 15:07 |
| kata-irc-bot | <eric.ernst> You want that containerd feature, but for Kata perhaps. | 15:07 |
| kata-irc-bot | <sebastian.hasler> Maybe it didn't mention it clearly, but that's why I asked in the Kata Slack | 15:07 |
| kata-irc-bot | <eric.ernst> Would something like “imports,” but within the kata toml, meet your need? | 15:10 |
| kata-irc-bot | <eric.ernst> (off to commute now). If this is something that you’d like, if you can open a GH issue for ‘feature’ for the ask? I imagine we can follow a similar pattern, even looking @ containerd for reference ion implementation. | 15:13 |
| kata-irc-bot | <eric.ernst> May be a good “first contribution” for anyone, even! | 15:13 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!