| kata-irc-bot | <fidencio> Okay, 2.2.0 and 2.3.0-alpha0 are out! :slightly_smiling_face: | 08:57 |
|---|---|---|
| kata-irc-bot | <fidencio> We're still working on the last release of the stable-2.1 branch, and that should happen soon. | 08:57 |
| kata-irc-bot | <samuel.ortiz> Thanks a lot @fidencio! | 09:30 |
| kata-irc-bot | <feng.wang> Hi team, I’m getting a golang field alignment error in the PR static check because of a new bool field I added. I can move the field around to fix the field alignment error but then the order of the fields will be disrupted. What’s the preferred way to handle this? | 16:33 |
| kata-irc-bot | <feng.wang> @julio.montes @eric.ernst Any opinion? | 16:40 |
| devimc | @feng.wang just group bools with bools, ints with ints and so on.. | 16:51 |
| kata-irc-bot | <julio.montes> just group bools with bools, ints with ints and so on. | 16:52 |
| kata-irc-bot | <feng.wang> Then how to handle the field alignment error? | 16:53 |
| kata-irc-bot | <feng.wang> ```config.go:75:17: fieldalignment: struct of size 648 could be 640 (govet) type hypervisor struct { make: *** [Makefile:34: static-checks] Error 1 Error: Process completed with exit code 2.``` | 16:54 |
| kata-irc-bot | <feng.wang> @julio.montes Thanks! Can you kick off the CI again? https://github.com/kata-containers/kata-containers/pull/2432 https://github.com/kata-containers/kata-containers/pull/2546 | 18:28 |
| kata-irc-bot | <julio.montes> done | 18:38 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!