| kata-irc-bot | <feng.wang> Is it by design that the whole hypervisor configuration is replaced instead of merging individual field between the default config and provided config? @bergwolf | 03:25 |
|---|---|---|
| kata-irc-bot | <bergwolf> nop, each option can be configured separately. Are you seeing it otherwise? | 03:27 |
| kata-irc-bot | <feng.wang> Looking at the code in config.go, it looks like if the configration.toml is provided, then the default is ignored. | 03:29 |
| kata-irc-bot | <bergwolf> can you reproduce it in your dev environment? | 03:31 |
| kata-irc-bot | <bergwolf> I'm not sure how CI sets its config files | 03:32 |
| kata-irc-bot | <feng.wang> Let me try it locally. | 03:32 |
| kata-irc-bot | <feng.wang> I can reproduce it locally. Even if I set `defaultVmmRootless` to `true` in `src/runtime/pkg/katautils/config-settings.go.in`, qemu still launches as root user. I have to add a line: `enable_rootless_vmm = true` to the configuration.toml file. Am I missing something here? | 03:40 |
| kata-irc-bot | <bergwolf> looks like a bug to me -- the default value is not set by default | 03:47 |
| kata-irc-bot | <feng.wang> Let me open a bug report then. | 03:49 |
| kata-irc-bot | <bergwolf> `defaultVmmRootless` is added in your PR right? I cannot grep it in main branch | 03:50 |
| kata-irc-bot | <feng.wang> It’s a new flag I added in my PR. | 03:50 |
| kata-irc-bot | <bergwolf> you need something like this: | 03:51 |
| kata-irc-bot | <bergwolf> a simple wrapper to set the default value | 03:51 |
| kata-irc-bot | <feng.wang> Gotcha! Thanks! | 03:54 |
| kata-irc-bot | <feng.wang> I suspect some other fields have the same issue. | 03:56 |
| kata-irc-bot | <feng.wang> Wait…not sure how this can work for a `bool` type though. For a bool type, there is no way to detect whether it’s missing or it’s really set to `false`. | 03:59 |
| kata-irc-bot | <feng.wang> Maybe that’s why all the bool flags don’t have the default method. | 04:01 |
| kata-irc-bot | <feng.wang> To unblock testing my PR, I temporarily hardcoded `Rootless` to `true` . Can you approve the test flow to run? @bergwolf https://github.com/kata-containers/kata-containers/pull/2432 | 04:08 |
| kata-irc-bot | <bergwolf> ah, indeed. it's too bad that we use our own config interpretation instead of just rely on toml package to do it. | 04:08 |
| kata-irc-bot | <feng.wang> The current behavior is probably fine as long as the default value of the bool flags are `false` (which seems to be the case for kata). I was trying to take a shortcut for testing :slightly_smiling_face:. | 04:14 |
| kata-irc-bot | <jrieck> Hi team, thanks for the excellent work getting https://github.com/kata-containers/kata-containers/pull/2388 merged in. I can confirm my AWS EKS deployment can run kube pods within a jailed firecracker VM and shut them down no problem :partying_face: - I have 2 questions, when would the next release be so I can get the fix? and I currently use the kubernetes daemoneset method to deploy kata containers but jailer is disabled by default | 14:39 |
| kata-irc-bot | in the config filee, what would be the recommended way to have jailer enabled by default when I deploy kata containers? Thanks again for all the hard work on this project. | 14:39 |
| kata-irc-bot | <fidencio> I plan to cut the next release by the end of this week, in the worst case scenario. | 14:41 |
| kata-irc-bot | <fidencio> 1 seems reasonable to do now that we have a CI running with the jailer enabled | 14:42 |
| kata-irc-bot | <jrieck> thanks, no rush just curious :slightly_smiling_face: | 14:43 |
| kata-irc-bot | <jrieck> I will submit a PR to make it enabled, thanks | 14:44 |
| kata-irc-bot | <fidencio> `src/runtime/cli/config/configuration-fc.toml.in` is the file you want to take a look at | 14:46 |
| kata-irc-bot | <fidencio> @jrieck, you need to have an issue opened first, and then tag the issue in the PR. And have your PR signed-off-by. | 14:52 |
| kata-irc-bot | <fidencio> Otherwise CI will complain :slightly_smiling_face: | 14:52 |
| kata-irc-bot | <jrieck> ahh haha | 14:52 |
| kata-irc-bot | <jrieck> first timer, okay i will open an issue now | 14:53 |
| kata-irc-bot | <joaovanzuita> hey @fidencio, when you have some free min. , could you check the PR? @eric.ernst left a comment, Im not sure if updating the PR commit body content is enough, or is it required to update the commit message https://github.com/kata-containers/kata-containers/pull/2448 | 15:00 |
| kata-irc-bot | <fidencio> Sure, will do after the meeting! | 15:00 |
| kata-irc-bot | <jrieck> I think I formatted correctly now, please let me know | 15:04 |
| kata-irc-bot | <feng.wang> https://etherpad.opendev.org/p/Kata_Containers_2021_Architecture_Committee_Mtgs I added some notes and action items from this morning’s architecture commit meeting @fidencio @eric.ernst @archana.m.shinde | 17:59 |
| kata-irc-bot | <fidencio> And, again, thanks a lot for the presentation there! | 18:02 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!