| kata-irc-bot | <bergwolf> @feng.wang you can just remove `c.sandbox.storeSandbox` from `c.delete()` | 02:01 |
|---|---|---|
| kata-irc-bot | <bergwolf> It would allow sandbox Delete to delete containers without persisting anything. Then we can further clean up them in future PRs. | 02:03 |
| kata-irc-bot | <david_hay> G'day, looking to pick someone's brains :zombie: in the context of a PR for CCv0 .... TL;DR; this is adding PullImage support to `containerd-shim-kata-v2` Details in the thread | 15:18 |
| kata-irc-bot | <david_hay> In part, this requires us to update `src/runtime/go.mod` to use `github.com/stevenhorsman/containerd` instead of `github.com/containerd/containerd` I've edited `go.mod` via `go mod edit -replace github.com/containerd/containerd=github.com/stevenhorsman/containerd@image-offload-v0-latest` rather than hand-editing the file (!) and added `go.mod` to the list of commits within that PR However, this leads to a different issue where | 15:18 |
| kata-irc-bot | `GOFLAGS=-mod=vendor` breaks things, as per this So I've removed `-mod=vendor` from the `Makefile` and added that into my commit .... Things built OK locally, *BUT* I manually run `go mod vendor` before I run `make` to build the `kata-runtime` However, I'm guessing that `go mod vendor` doesn't get run when the automated tests run, which is why this test fails :( | 15:18 |
| kata-irc-bot | <david_hay> Long story short, anyone had a similar experience of changing `go.mod` to point to a different vendor dependency e.g. `containerd` etc. in this manner ? | 15:19 |
| kata-irc-bot | <david_hay> @fidencio wonder if this is something with which you're familiar ? All/most of the failing tests are borking because `go mod vendor` needs to be run as part of the build/test process e.g. build-asset | 15:42 |
| kata-irc-bot | <fidencio> @david_hay, I am in a meeting now. Would be okay if we sync about this in 20~30 minutes from now? | 15:44 |
| kata-irc-bot | <david_hay> Yeah, mate, absolutely no worries at all - any feedback would be much appreciated :thanks_: | 15:44 |
| kata-irc-bot | <david_hay> FYI Looking further at the Makefile I can see `handle_vendor` at line 649 which *does* run `go mod vendor` ``` go mod tidy go mod vendor go mod verify``` So trying to work out how to have the `build-asset` test run `handle_vendor` ..... | 16:16 |
| kata-irc-bot | <fidencio> let me take a look at the PR and at the issue | 16:22 |
| kata-irc-bot | <fidencio> @david_hay, basically, in https://github.com/kata-containers/kata-containers/pull/2823/commits/3fb7d0f74f90f26c8879d193abf198e8bb524c8d ... just run `make -C src/runtime handle_vendor` from the top dir | 16:23 |
| kata-irc-bot | <fidencio> and then you can do a `git add -u && git commit --amend` | 16:24 |
| kata-irc-bot | <fidencio> It works. And then you can drop https://github.com/kata-containers/kata-containers/pull/2823/commits/c056fb2ac0f4aa2ebadbf6f4c59b77689408fa11 | 16:27 |
| kata-irc-bot | <fidencio> @david_hay, I've created https://github.com/kata-containers/kata-containers/pull/2826 ... let's see if it passes the static checks | 16:31 |
| kata-irc-bot | <david_hay> Mate, you're a genius ! | 16:43 |
| kata-irc-bot | <david_hay> Thanks | 16:43 |
| kata-irc-bot | <david_hay> cc @steven FYI | 16:43 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!