| kata-irc-bot | <fidencio> Folks, we need a second reviewer on https://github.com/kata-containers/tests/pull/4031 | 10:24 |
|---|---|---|
| kata-irc-bot | <fidencio> cc @samuel.ortiz, @christophe, @bergwolf, as folks online right now. :-) | 10:25 |
| kata-irc-bot | <christophe> Looking at it right now | 10:26 |
| kata-irc-bot | <christophe> Done | 10:27 |
| kata-irc-bot | <fidencio> And merged, thanks Christophe! <3 | 10:28 |
| kata-irc-bot | <jakob.naucke> TIL what happens when someone else tries to merge in the same second (should have taken a screenshot) | 10:28 |
| kata-irc-bot | <fidencio> What happens? | 10:28 |
| kata-irc-bot | <jakob.naucke> You get the "can be safely deleted" message alongside with "we couldn't merge this, please reload" | 10:28 |
| kata-irc-bot | <fidencio> Aha! I didn't face this yet. | 10:29 |
| kata-irc-bot | <fidencio> @jakob.naucke, mind to just raise a backport for that one and we can ensure the stable-2.2 branch will be fine? | 10:29 |
| kata-irc-bot | <jakob.naucke> already on it | 10:29 |
| kata-irc-bot | <fidencio> You rock! | 10:29 |
| kata-irc-bot | <fidencio> @christophe, may we abuse you a little bit and also ask for an approval on the backport https://github.com/kata-containers/tests/pull/4040 ? | 11:34 |
| kata-irc-bot | <samuel.ortiz> @fidencio Merged | 11:35 |
| kata-irc-bot | <samuel.ortiz> Thanks @jakob.naucke | 11:36 |
| kata-irc-bot | <christophe> Sorry, in a 1x1 ;) | 12:30 |
| kata-irc-bot | <gkurz> @fidencio any take on https://github.com/kata-containers/kata-containers/pull/2756/files/ef11a0b8e86c29934dd58937d37c9c34dd7ab60a#diff-d073f6907cc01[…]736a77caeac6b011a8c ? | 12:31 |
| kata-irc-bot | <fidencio> Yep, if you can get rid of the switch that would be preferrable. | 15:31 |
| kata-irc-bot | <fidencio> That seems to also be David's preference. | 15:31 |
| khyr0n | O.o o/ | 20:49 |
| *** fidencio_ is now known as fidencio|off | 20:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!