| kata-irc-bot | <bergwolf> that flag is for CRI plugin. it doesn't work with ctr which is a container directed interface | 01:06 |
|---|---|---|
| kata-irc-bot | <simon.kaegi> https://github.com/kata-containers/tests/pull/4011 | 01:43 |
| kata-irc-bot | <fidencio> @jianyong.wu, have you seen @jakob.naucke comment about not doing the `go get ...`? | 06:36 |
| kata-irc-bot | <jianyong.wu> I just see it now. I think add "go get" may be more secure in case the kata_repo is gone | 06:43 |
| kata-irc-bot | <jianyong.wu> why "jenkins-ci-ubuntu-1804-clh-containerd-k8s-e2e-minimal" can't be triggered? | 06:48 |
| kata-irc-bot | <jakob.naucke> okay, then we keep it | 06:53 |
| kata-irc-bot | <fidencio> @bergwolf, could you please take a look at https://github.com/kata-containers/kata-containers/pull/2717? This is borderline for getting into the stable-2.2 branch, as it's not exactly a bug fix. I'd like to hear from you and from @archana.m.shinde before getting it merged. | 09:38 |
| kata-irc-bot | <fidencio> cc @fgiudici and @eric.ernst | 09:38 |
| kata-irc-bot | <fidencio> @jakob.naucke, any opinions on this? :slightly_smiling_face: | 09:46 |
| kata-irc-bot | <jakob.naucke> ugh... from a very quick look, I have nits like a function should be called `GetSandboxesStoragePath`, not `GetSanboxesStoragePath`, but that's not even for backport discussion... I can't say I'm particularly familiar with the code that's being touched here. | 09:48 |
| kata-irc-bot | <fidencio> @jakob.naucke you still have the time to raise those in the original PR: https://github.com/kata-containers/kata-containers/pull/2566 | 09:51 |
| kata-irc-bot | <fidencio> (and that's worth raising) | 09:52 |
| kata-irc-bot | <jakob.naucke> right. | 09:52 |
| kata-irc-bot | <gkurz> @fidencio Hi ! Any take on https://github.com/kata-containers/kata-containers/issues/2721 ? | 10:12 |
| kata-irc-bot | <fidencio> Added to my backlog, for now I'm focusing on surviving meetings and getting a release out Today. :slightly_smiling_face: | 10:21 |
| kata-irc-bot | <fgiudici> Hey, @jakob.naucke, thanks for looking :slightly_smiling_face: | 10:22 |
| kata-irc-bot | <fidencio> All, *PLEASE*, do not merge anything in the coming hours. I'm starting the release process now. | 10:30 |
| kata-irc-bot | <fidencio> 2.2.1: • tests: https://github.com/kata-containers/tests/pull/4015 • kata-containers: https://github.com/kata-containers/kata-containers/pull/2723 2.3.0-alpha1: • tests: https://github.com/kata-containers/tests/pull/4014 • https://github.com/kata-containers/kata-containers/pull/2722 | 10:37 |
| kata-irc-bot | <fidencio> I broke the tags in the release, let me fix it soon :slightly_smiling_face: | 15:19 |
| kata-irc-bot | <wmoschet> @fidencio done | 17:19 |
| *** devimc_ is now known as devimc | 17:23 | |
| *** devimc_ is now known as devimc | 20:08 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!